Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-15 Thread Daniel P . Berrangé
On Wed, May 13, 2020 at 01:06:58PM +0200, Peter Krempa wrote: > On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > > On Wed, May 13, 2020 at 12:05:44PM +0200, Peter Krempa wrote: > > > On Wed, May 13, 2020 at 10:57:33 +0100, Daniel Berrange wrote: > > > > On Wed, May 13, 2020 at

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Andrea Bolognani
On Wed, 2020-05-13 at 15:00 +0200, Jiri Denemark wrote: > On Wed, May 13, 2020 at 12:30:48 +0100, Daniel P. Berrangé wrote: > > On Wed, May 13, 2020 at 01:19:35PM +0200, Andrea Bolognani wrote: > > > I completely agree, #nnn is too ambiguous to be useful. > > > > The widespread usage by any other

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Jiri Denemark
On Wed, May 13, 2020 at 12:30:48 +0100, Daniel P. Berrangé wrote: > On Wed, May 13, 2020 at 01:19:35PM +0200, Andrea Bolognani wrote: ... > > I completely agree, #nnn is too ambiguous to be useful. > > The widespread usage by any other project using GitLab/GitHub proves > otherwise and libvirt

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Daniel P . Berrangé
On Wed, May 13, 2020 at 01:19:35PM +0200, Andrea Bolognani wrote: > On Wed, 2020-05-13 at 13:06 +0200, Peter Krempa wrote: > > On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > > > It isn't about giving in. Again the point is to not needlessly create > > > special rules for

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Ján Tomko
On a Wednesday in 2020, Andrea Bolognani wrote: On Wed, 2020-05-13 at 13:06 +0200, Peter Krempa wrote: On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > It isn't about giving in. Again the point is to not needlessly create > special rules for contributing to libvirt, because

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Peter Krempa
On Wed, May 13, 2020 at 13:06:58 +0200, Peter Krempa wrote: > On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > > On Wed, May 13, 2020 at 12:05:44PM +0200, Peter Krempa wrote: > > > On Wed, May 13, 2020 at 10:57:33 +0100, Daniel Berrange wrote: > > > > On Wed, May 13, 2020 at

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Andrea Bolognani
On Wed, 2020-05-13 at 13:06 +0200, Peter Krempa wrote: > On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > > It isn't about giving in. Again the point is to not needlessly create > > special rules for contributing to libvirt, because every special rule > > we add is another thing

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Peter Krempa
On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > On Wed, May 13, 2020 at 12:05:44PM +0200, Peter Krempa wrote: > > On Wed, May 13, 2020 at 10:57:33 +0100, Daniel Berrange wrote: > > > On Wed, May 13, 2020 at 11:51:50AM +0200, Peter Krempa wrote: [...] > > > The point is for

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Daniel P . Berrangé
On Wed, May 13, 2020 at 12:05:44PM +0200, Peter Krempa wrote: > On Wed, May 13, 2020 at 10:57:33 +0100, Daniel Berrange wrote: > > On Wed, May 13, 2020 at 11:51:50AM +0200, Peter Krempa wrote: > > > On Wed, May 13, 2020 at 10:41:23 +0100, Daniel Berrange wrote: > > > > On Wed, May 13, 2020 at

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Ján Tomko
On a Wednesday in 2020, Daniel P. Berrangé wrote: On Wed, May 13, 2020 at 11:51:50AM +0200, Peter Krempa wrote: On Wed, May 13, 2020 at 10:41:23 +0100, Daniel Berrange wrote: > On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote: > > On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Peter Krempa
On Wed, May 13, 2020 at 10:57:33 +0100, Daniel Berrange wrote: > On Wed, May 13, 2020 at 11:51:50AM +0200, Peter Krempa wrote: > > On Wed, May 13, 2020 at 10:41:23 +0100, Daniel Berrange wrote: > > > On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote: > > > > On Wed, 2020-05-13 at

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Daniel P . Berrangé
On Wed, May 13, 2020 at 11:51:50AM +0200, Peter Krempa wrote: > On Wed, May 13, 2020 at 10:41:23 +0100, Daniel Berrange wrote: > > On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote: > > > On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko wrote: > > > > This is not yet supported by

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Peter Krempa
On Wed, May 13, 2020 at 10:41:23 +0100, Daniel Berrange wrote: > On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote: > > On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko wrote: > > > This is not yet supported by virtiofsd. > > > > > > Fixes #23 > > > > Please include the full URL

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Daniel P . Berrangé
On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote: > On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko wrote: > > This is not yet supported by virtiofsd. > > > > Fixes #23 > > Please include the full URL here: > > https://gitlab.com/libvirt/libvirt/-/issues/23 Using the '#23'

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Andrea Bolognani
On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko wrote: > This is not yet supported by virtiofsd. > > Fixes #23 Please include the full URL here: https://gitlab.com/libvirt/libvirt/-/issues/23 > case VIR_DOMAIN_FS_DRIVER_TYPE_VIRTIOFS: > +if (fs->readonly) { > +

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Pino Toscano
On Wednesday, 13 May 2020 10:58:51 CEST Ján Tomko wrote: > +if (fs->readonly) { > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > + _("virtiofs does not yet supported read-only > mode")); s/supported/support/ -- Pino Toscano signature.asc

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Daniel P . Berrangé
On Wed, May 13, 2020 at 10:58:51AM +0200, Ján Tomko wrote: > This is not yet supported by virtiofsd. > > Fixes #23 > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_validate.c | 5 +++ > .../vhost-user-fs-readonly.xml| 44 +++ >

[libvirt PATCH] qemu: reject readonly attribute for virtiofs

2020-05-13 Thread Ján Tomko
This is not yet supported by virtiofsd. Fixes #23 Signed-off-by: Ján Tomko --- src/qemu/qemu_validate.c | 5 +++ .../vhost-user-fs-readonly.xml| 44 +++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 50 insertions(+)