Re: [libvirt PATCH] util: Reorder virStringParseVersion() arguments

2022-02-03 Thread Andrea Bolognani
On Thu, Feb 03, 2022 at 02:59:33PM +0100, Ján Tomko wrote: > On a Thursday in 2022, Andrea Bolognani wrote: > > In order to match the existing virStringParse*() and virStrTo*() > > functions, input arguments should come before output arguments. > > Or, even better, the virStr* functions should be

Re: [libvirt PATCH] util: Reorder virStringParseVersion() arguments

2022-02-03 Thread Ján Tomko
On a Thursday in 2022, Andrea Bolognani wrote: In order to match the existing virStringParse*() and virStrTo*() functions, input arguments should come before output arguments. Or, even better, the virStr* functions should be inverted to match the approach we do elsewhere (VIR_STRDUP,

Re: [libvirt PATCH] util: Reorder virStringParseVersion() arguments

2022-02-03 Thread Peter Krempa
On Thu, Feb 03, 2022 at 14:38:49 +0100, Andrea Bolognani wrote: > In order to match the existing virStringParse*() and virStrTo*() > functions, input arguments should come before output arguments. > > Signed-off-by: Andrea Bolognani > --- IMO the utility to churn ratio of this patch isn't very

[libvirt PATCH] util: Reorder virStringParseVersion() arguments

2022-02-03 Thread Andrea Bolognani
In order to match the existing virStringParse*() and virStrTo*() functions, input arguments should come before output arguments. Signed-off-by: Andrea Bolognani --- src/bhyve/bhyve_driver.c | 2 +- src/ch/ch_conf.c | 2 +- src/esx/esx_vi.c