Re: [libvirt PATCH 06/20] ci: build.sh: Always assume -Dsystem=true

2023-03-02 Thread Daniel P . Berrangé 
On Mon, Feb 06, 2023 at 02:53:03PM +0100, Erik Skultety wrote:
> There's no harm in always building in system mode, i.e. setting the
> right paths.
> 
> Signed-off-by: Erik Skultety 
> ---
>  ci/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé 


With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[libvirt PATCH 06/20] ci: build.sh: Always assume -Dsystem=true

2023-02-06 Thread Erik Skultety 
There's no harm in always building in system mode, i.e. setting the
right paths.

Signed-off-by: Erik Skultety 
---
 ci/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/build.sh b/ci/build.sh
index c7cba6ffa8..f6db4d2a7f 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -8,7 +8,7 @@ export VIR_TEST_DEBUG=1
 # populated at build time from the Dockerfile. A typical use case would
 # be to pass options to trigger cross-compilation
 
-meson setup build --werror $MESON_OPTS $CI_MESON_ARGS || \
+meson setup build --werror -Dsystem=true $MESON_OPTS $CI_MESON_ARGS || \
 (cat build/meson-logs/meson-log.txt && exit 1)
 
 ninja -C build $CI_NINJA_ARGS
-- 
2.39.1