Re: [libvirt PATCH 3/4] ci: Expose CI_USER_LOGIN as a Makefile variable for users to use

2021-02-12 Thread Andrea Bolognani
On Fri, 2021-02-12 at 13:41 +0100, Erik Skultety wrote: > On Fri, Feb 12, 2021 at 01:27:42PM +0100, Andrea Bolognani wrote: > > On Wed, 2021-02-10 at 18:00 +0100, Erik Skultety wrote: > > > # We also need the user's login and home directory to prepare the > > > # environment the way some

Re: [libvirt PATCH 3/4] ci: Expose CI_USER_LOGIN as a Makefile variable for users to use

2021-02-12 Thread Erik Skultety
On Fri, Feb 12, 2021 at 01:27:42PM +0100, Andrea Bolognani wrote: > On Wed, 2021-02-10 at 18:00 +0100, Erik Skultety wrote: > > # We need the container process to run with current host IDs > > # so that it can access the passed in build directory > > -CI_UID = $(shell id -u) > > -CI_GID =

Re: [libvirt PATCH 3/4] ci: Expose CI_USER_LOGIN as a Makefile variable for users to use

2021-02-12 Thread Andrea Bolognani
On Wed, 2021-02-10 at 18:00 +0100, Erik Skultety wrote: > # We need the container process to run with current host IDs > # so that it can access the passed in build directory > -CI_UID = $(shell id -u) > -CI_GID = $(shell id -g) > +CI_UID = $(shell id -u $(CI_USER_LOGIN)) > +CI_GID = $(shell id

[libvirt PATCH 3/4] ci: Expose CI_USER_LOGIN as a Makefile variable for users to use

2021-02-10 Thread Erik Skultety
More often than not I find myself debugging the containers which means that I need to have root inside, but without manually tweaking the Makefile each time the execution would simply fail thanks to the uid/gid mapping we do. What if we expose the CI_USER_LOGIN variable, so that when needed, the