Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-29 Thread Daniel P . Berrangé
On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: > When the firmware auto-selection was introduced it always picked first > usable firmware based on the JSON descriptions on the host. It is > possible to add/remove/change the JSON files but it will always be for > the whole host. > >

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-19 Thread Pavel Hrdina
On Fri, Mar 19, 2021 at 04:11:39PM +0100, Kashyap Chamarthy wrote: > On Fri, Mar 19, 2021 at 11:59:11AM +0100, Pavel Hrdina wrote: > > On Fri, Mar 19, 2021 at 11:10:05AM +0100, Kashyap Chamarthy wrote: > > > On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: > > [...] > > > > Nit: I'd

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-19 Thread Kashyap Chamarthy
On Fri, Mar 19, 2021 at 11:59:11AM +0100, Pavel Hrdina wrote: > On Fri, Mar 19, 2021 at 11:10:05AM +0100, Kashyap Chamarthy wrote: > > On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: [...] > > Nit: I'd recast it as: "When using firmware auto-selection, different > > features are

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-19 Thread Pavel Hrdina
On Fri, Mar 19, 2021 at 11:10:05AM +0100, Kashyap Chamarthy wrote: > On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: > > When the firmware auto-selection was introduced it always picked first > > usable firmware based on the JSON descriptions on the host. It is > > possible to

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-19 Thread Kashyap Chamarthy
On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: > When the firmware auto-selection was introduced it always picked first > usable firmware based on the JSON descriptions on the host. It is > possible to add/remove/change the JSON files but it will always be for > the whole host. > >

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-18 Thread Pavel Hrdina
On Thu, Mar 18, 2021 at 06:10:45PM +0100, Pavel Hrdina wrote: > On Thu, Mar 18, 2021 at 05:18:36PM +0100, Michal Privoznik wrote: > > On 3/18/21 1:26 PM, Pavel Hrdina wrote: > > > When the firmware auto-selection was introduced it always picked first > > > usable firmware based on the JSON

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-18 Thread Pavel Hrdina
On Thu, Mar 18, 2021 at 05:18:36PM +0100, Michal Privoznik wrote: > On 3/18/21 1:26 PM, Pavel Hrdina wrote: > > When the firmware auto-selection was introduced it always picked first > > usable firmware based on the JSON descriptions on the host. It is > > possible to add/remove/change the JSON

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-18 Thread Michal Privoznik
On 3/18/21 1:26 PM, Pavel Hrdina wrote: When the firmware auto-selection was introduced it always picked first usable firmware based on the JSON descriptions on the host. It is possible to add/remove/change the JSON files but it will always be for the whole host. This patch introduces support

[libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

2021-03-18 Thread Pavel Hrdina
When the firmware auto-selection was introduced it always picked first usable firmware based on the JSON descriptions on the host. It is possible to add/remove/change the JSON files but it will always be for the whole host. This patch introduces support for configuring the auto-selection per VM