>
> It's probably irrelevant since this will be mostly rewritten based on
> Dan's suggestions, but the resFormatFunc() pointer seems like an
> unnecessary complication - you could just move the if/else construct
> down to here and call the appropriate function directly.
>
Ack, I was trying to
> >
> > I've got a general comment about what do any of these 2-letter
> > keywords actually mean. I presume they are explaned in the
> > PCI spec, but AFAICT the spec is not publically available for
> > free.
> > So at the very least we need to document each one's meaning
> > in libvirt docs
On 9/27/21 3:30 PM, Dmitrii Shcherbakov wrote:
[...]
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
[...]
+
+static void
+virNodeDeviceCapVPDResourceFormat(virBuffer *buf, virPCIVPDResource *res)
+{
+GEnumValue *resRype = NULL;
+void (*resFormatFunc)(virBuffer
On Fri, Oct 01, 2021 at 01:11:19PM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 27, 2021 at 10:30:51PM +0300, Dmitrii Shcherbakov wrote:
> > * XML serialization and deserialization of PCI VPD resources;
> > * PCI VPD capability flags added and used in relevant places;
> > * XML to XML tests for
On Mon, Sep 27, 2021 at 10:30:51PM +0300, Dmitrii Shcherbakov wrote:
> * XML serialization and deserialization of PCI VPD resources;
> * PCI VPD capability flags added and used in relevant places;
> * XML to XML tests for the added capability.
>
> Signed-off-by: Dmitrii Shcherbakov
> diff
* XML serialization and deserialization of PCI VPD resources;
* PCI VPD capability flags added and used in relevant places;
* XML to XML tests for the added capability.
Signed-off-by: Dmitrii Shcherbakov
---
docs/schemas/nodedev.rng | 40 +++
