Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-03 Thread Laine Stump
On 2/3/22 10:52 AM, Michal Prívozník wrote: On 2/3/22 15:45, Laine Stump wrote: On 2/2/22 1:04 PM, Michal Prívozník wrote: Laine, any thoughts? I somehow thought this had already been pushed, so I was surprised when it showed up again :-/ I think the only issue I had before was that I

Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-03 Thread Dmitrii Shcherbakov
Thanks again for the feedback - much appreciated! Best Regards, Dmitrii Shcherbakov LP/MM/oftc: dmitriis On Thu, Feb 3, 2022 at 6:52 PM Michal Prívozník wrote: > > On 2/3/22 15:45, Laine Stump wrote: > > On 2/2/22 1:04 PM, Michal Prívozník wrote: > >> > >> Laine, any thoughts? > > > > I somehow

Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-03 Thread Michal Prívozník
On 2/3/22 15:45, Laine Stump wrote: > On 2/2/22 1:04 PM, Michal Prívozník wrote: >> >> Laine, any thoughts? > > I somehow thought this had already been pushed, so I was surprised when > it showed up again :-/ > > I think the only issue I had before was that I thought the new unit > tests were

Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-03 Thread Laine Stump
On 2/2/22 1:04 PM, Michal Prívozník wrote: Laine, any thoughts? I somehow thought this had already been pushed, so I was surprised when it showed up again :-/ I think the only issue I had before was that I thought the new unit tests were more testing the test setup than the actual code,

Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-03 Thread Dmitrii Shcherbakov
Squashed & auto-tested here: https://gitlab.com/dmitriis/libvirt/-/commits/2021-ignore-eperm-for-vid0 https://gitlab.com/dmitriis/libvirt/-/pipelines/462532823 Best Regards, Dmitrii Shcherbakov LP/MM/oftc: dmitriis On Wed, Feb 2, 2022 at 11:10 PM Dmitrii Shcherbakov wrote: > > Hi Michal, > >

Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-02 Thread Dmitrii Shcherbakov
Hi Michal, No problem, thanks for coming back to re-review it, I also acknowledge that it was late in the year and during the holiday season so things got slower. > and if you agree, I'd squash them in respective commits and merge. I looked at the fixup commits - I agree with the changes and

Re: [libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-02 Thread Michal Prívozník
On 2/1/22 09:28, Dmitrii Shcherbakov wrote: > SmartNIC DPUs may not expose some privileged eswitch operations > to the hypervisor hosts. For example, this happens with Bluefield > devices running in the ECPF (default) mode [1] for security reasons. While > VF MAC address programming is possible

[libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

2022-02-01 Thread Dmitrii Shcherbakov
SmartNIC DPUs may not expose some privileged eswitch operations to the hypervisor hosts. For example, this happens with Bluefield devices running in the ECPF (default) mode [1] for security reasons. While VF MAC address programming is possible via an RTM_SETLINK operation, trying to set a VLAN ID