Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-10 Thread Daniel P . Berrangé
On Wed, Mar 10, 2021 at 06:41:35PM +0100, Michal Privoznik wrote: > On 3/10/21 4:36 PM, Michal Privoznik wrote: > > On 3/9/21 6:44 PM, Daniel P. Berrangé wrote: > > > One of the conventions we have had since the early days of libvirt is > > > that every struct typedef, has a corresponding "Ptr"

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-10 Thread Peter Krempa
On Wed, Mar 10, 2021 at 18:41:35 +0100, Michal Privoznik wrote: > On 3/10/21 4:36 PM, Michal Privoznik wrote: > > On 3/9/21 6:44 PM, Daniel P. Berrangé wrote: > > > One of the conventions we have had since the early days of libvirt is > > > that every struct typedef, has a corresponding "Ptr"

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-10 Thread Michal Privoznik
On 3/10/21 4:36 PM, Michal Privoznik wrote: On 3/9/21 6:44 PM, Daniel P. Berrangé wrote: One of the conventions we have had since the early days of libvirt is that every struct typedef, has a corresponding "Ptr" typedef too. For example typedef struct _virDomainDef virDomainDef;

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-10 Thread Michal Privoznik
On 3/9/21 6:44 PM, Daniel P. Berrangé wrote: One of the conventions we have had since the early days of libvirt is that every struct typedef, has a corresponding "Ptr" typedef too. For example typedef struct _virDomainDef virDomainDef; typedef virDomainDef *virDomainDefPtr;

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Peter Krempa
On Tue, Mar 09, 2021 at 17:44:16 +, Daniel Berrange wrote: > One of the conventions we have had since the early days of libvirt is > that every struct typedef, has a corresponding "Ptr" typedef too. > > For example > > typedef struct _virDomainDef virDomainDef; > typedef virDomainDef

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Jiri Denemark
On Tue, Mar 09, 2021 at 17:44:16 +, Daniel P. Berrangé wrote: ... > We can't do anything about the use "Ptr" in the include/ files because > that is public ABI. We can potentially eliminate "Ptr" types everywhere > else in the codebase, even the src/libvirt*.c files corresponding to > the

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Laine Stump
On 3/9/21 1:23 PM, Andrea Bolognani wrote: On Tue, 2021-03-09 at 17:44 +, Daniel P. Berrangé wrote: One of the conventions we have had since the early days of libvirt is that every struct typedef, has a corresponding "Ptr" typedef too. For example typedef struct _virDomainDef

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Ján Tomko
On a Tuesday in 2021, Daniel P. Berrangé wrote: One of the conventions we have had since the early days of libvirt is that every struct typedef, has a corresponding "Ptr" typedef too. For example typedef struct _virDomainDef virDomainDef; typedef virDomainDef *virDomainDefPtr;

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 07:23:15PM +0100, Andrea Bolognani wrote: > On Tue, 2021-03-09 at 17:44 +, Daniel P. Berrangé wrote: > > One of the conventions we have had since the early days of libvirt is > > that every struct typedef, has a corresponding "Ptr" typedef too. > > > > For example > >

Re: RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Andrea Bolognani
On Tue, 2021-03-09 at 17:44 +, Daniel P. Berrangé wrote: > One of the conventions we have had since the early days of libvirt is > that every struct typedef, has a corresponding "Ptr" typedef too. > > For example > > typedef struct _virDomainDef virDomainDef; > typedef virDomainDef

RFC: do we want/need the "Ptr" typedefs for internal code ?

2021-03-09 Thread Daniel P . Berrangé
One of the conventions we have had since the early days of libvirt is that every struct typedef, has a corresponding "Ptr" typedef too. For example typedef struct _virDomainDef virDomainDef; typedef virDomainDef *virDomainDefPtr; Periodically someone has questioned what the purpose of