[libvirt] simple LXC/libvirt busybox container (Unable to get cgroup)

2009-12-10 Thread Tony Risinger
i'm trying to get even the simplest busybox container with libvirt+LXC with very limited success. I feel l am missing something supremely simple for me to be hung on this for weeks. i dont see anything interesting in domain log, but getting this error from "LIBVIRT_DEBUG=1 libvirtd": 05:27:56.11

Re: [libvirt] qemu smbios options in domain xml format

2009-12-10 Thread Paolo Bonzini
On 12/09/2009 10:47 PM, Phillip Balli wrote: Hello, I could not find any explicit mention of support for the -smbios options which are present in qemu 0.10.5+ in the domain xml format or the qemu/kvm hypervisor driver pages. Is there some way to specify commands and options which are not describ

Re: [libvirt] simple LXC/libvirt busybox container (Unable to get cgroup)

2009-12-10 Thread Ryota Ozaki
On Thu, Dec 10, 2009 at 5:22 PM, Tony Risinger wrote: > i'm trying to get even the simplest busybox container with libvirt+LXC > with very limited success.  I feel l am missing something supremely > simple for me to be hung on this for weeks. > > i dont see anything interesting in domain log, but

[libvirt] [PATCH 1/5] reload iptables rules simply by re-adding them

2009-12-10 Thread Mark McLoughlin
Currently, when we add iptables rules, we keep them on a list so that we can easily reload them on e.g. 'service libvirtd reload'. However, we don't save this list to disk, so if libvirtd is restarted we lose the ability to reload the rules. The fix is simple - just re-add the damn things on relo

[libvirt] [PATCH 2/5] reload iptables rules on libvirtd restart

2009-12-10 Thread Mark McLoughlin
This is the expected behaviour, I think - reloading libvirtd should be a subset of restarting it. Note, we reload the rules after we've determined which networks are active (because we only add the rules for active networks) and before we start autostart networks (to avoid re-adding the rules). *

[libvirt] [PATCH 3/5] remove all traces of lokkit support

2009-12-10 Thread Mark McLoughlin
Long ago we tried to use Fedora's lokkit utility in order to register our iptables rules so that 'service iptables restart' would automatically load our rules. There was one fatal flaw - if the user had configured iptables without lokkit, then we would clobber that configuration by running lokkit.

[libvirt] [PATCH 4/5] remove iptablesReloadRules() and related code

2009-12-10 Thread Mark McLoughlin
We don't use this method of reloading rules anymore, so we can just kill the code. This simplifies things a lot because we no longer need to keep a table of the rules we've added. * src/util/iptables.c: kill iptablesReloadRules() --- src/libvirt_private.syms |1 - src/util/iptables.c |

[libvirt] [PATCH 5/5] remove now unneeded iptablesContext

2009-12-10 Thread Mark McLoughlin
iptablesContext no longer contains any state, so we can drop it * src/util/iptables.c, src/util/iptables.h: drop iptablesContext * src/network/bridge_driver.c: update callers * src/libvirt_private.syms: drop context new/free functions --- src/libvirt_private.syms|2 - src/network/bridge

Re: [libvirt] [PATCH v2 0/3] Fix migration of paused VMs

2009-12-10 Thread Daniel P. Berrange
On Wed, Dec 09, 2009 at 02:38:25PM +0100, Paolo Bonzini wrote: > This is the final version of QEMU support for migrating paused VMs. > The patch series is the same as what I posted on Nov 25, except for > the check on the return value of virDomainGetInfo. > > Patch 2 also had some easily-solved co

Re: [libvirt] fc12 virsh tap device problem

2009-12-10 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 07:07:33PM -0800, Chiradeep Vittal wrote: > I have this xml: > > centos > 22d9d573-d82c-c18d-36c0-d3ffef057468 > 131072 > 1 > > hvm > > > > > > > > /usr/bin/qemu-kvm > > > > > > > > >

[libvirt] Re: libvirk KVM save (migrate) terribly slow

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 08:05:12AM +0100, Nikola Ciprich wrote: > Hi, > I noticed that using libvirt to save running domain is terribly slow, > I mean it can take even 10 minutes to save VM with 2GB RAM, although > the host is almost idle (8CPU, 16GB RAM). If I understand correctly, > libvirt firs

Re: [libvirt] Fix compilation failure if yajl is not available

2009-12-10 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 11:13:15AM +0100, Daniel Veillard wrote: > I commited the following as it was a compile breaker for most people I > assume and it's trivial > > commit a4e09c1ed81f7361ff03d95ad42eac49d4d60812 > Author: Daniel Veillard > Date: Tue Dec 8 11:08:17 2009 +0100 > > Fix

Re: [libvirt] hot swappable HD

2009-12-10 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 03:43:29PM +0100, mbutubuntu wrote: > hello folks, > in the real life a SATA Hard Drive is Hot swappable, is there any > (non-usb) type of virtual device that is also hot swappable? > if yes what of ide, scsi, virtio, xen ??? With QEMU/KVM, we support hotplug for VirtIO, S

Re: [libvirt] [RFC] New libvirt API for domain memory statistics reporting

2009-12-10 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 02:57:14PM -0500, Adam Litke wrote: > When using ballooning to manage overcommitted memory on a host, a system for > guests to communicate their memory usage to the host can provide information > that will minimize the impact of ballooning on the guests while maximizing > ef

Re: [libvirt] simple LXC/libvirt busybox container (Unable to get cgroup)

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 02:22:37AM -0600, Tony Risinger wrote: > i'm trying to get even the simplest busybox container with libvirt+LXC > with very limited success. I feel l am missing something supremely > simple for me to be hung on this for weeks. > > i dont see anything interesting in domain

Re: [libvirt] [PATCH 1/5] reload iptables rules simply by re-adding them

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 11:27:51AM +, Mark McLoughlin wrote: > Currently, when we add iptables rules, we keep them on a list so that > we can easily reload them on e.g. 'service libvirtd reload'. > > However, we don't save this list to disk, so if libvirtd is restarted > we lose the ability to

Re: [libvirt] [PATCH 2/5] reload iptables rules on libvirtd restart

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 11:27:52AM +, Mark McLoughlin wrote: > This is the expected behaviour, I think - reloading libvirtd should > be a subset of restarting it. > > Note, we reload the rules after we've determined which networks > are active (because we only add the rules for active networks

Re: [libvirt] [PATCH 3/5] remove all traces of lokkit support

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 11:27:53AM +, Mark McLoughlin wrote: > Long ago we tried to use Fedora's lokkit utility in order to register > our iptables rules so that 'service iptables restart' would > automatically load our rules. > > There was one fatal flaw - if the user had configured iptables

Re: [libvirt] [PATCH 4/5] remove iptablesReloadRules() and related code

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 11:27:54AM +, Mark McLoughlin wrote: > We don't use this method of reloading rules anymore, so we can just > kill the code. > > This simplifies things a lot because we no longer need to keep a > table of the rules we've added. > > * src/util/iptables.c: kill iptablesRe

Re: [libvirt] [PATCH 5/5] remove now unneeded iptablesContext

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 11:27:55AM +, Mark McLoughlin wrote: > iptablesContext no longer contains any state, so we can drop it > > * src/util/iptables.c, src/util/iptables.h: drop iptablesContext > > * src/network/bridge_driver.c: update callers > > * src/libvirt_private.syms: drop context n

Re: [libvirt] [PATCH 5/5] remove now unneeded iptablesContext

2009-12-10 Thread Mark McLoughlin
On Thu, 2009-12-10 at 12:08 +, Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 11:27:55AM +, Mark McLoughlin wrote: > > iptablesContext no longer contains any state, so we can drop it > > > > * src/util/iptables.c, src/util/iptables.h: drop iptablesContext > > > > * src/network/bridge

Re: [libvirt] simple LXC/libvirt busybox container (Unable to get cgroup)

2009-12-10 Thread Ryota Ozaki
On Thu, Dec 10, 2009 at 9:03 PM, Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 02:22:37AM -0600, Tony Risinger wrote: >> i'm trying to get even the simplest busybox container with libvirt+LXC >> with very limited success.  I feel l am missing something supremely >> simple for me to be hung o

Re: [libvirt] simple LXC/libvirt busybox container (Unable to get cgroup)

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 09:26:39PM +0900, Ryota Ozaki wrote: > On Thu, Dec 10, 2009 at 9:03 PM, Daniel P. Berrange > wrote: > > On Thu, Dec 10, 2009 at 02:22:37AM -0600, Tony Risinger wrote: > >> i'm trying to get even the simplest busybox container with libvirt+LXC > >> with very limited success

Re: [libvirt] simple LXC/libvirt busybox container (Unable to get cgroup)

2009-12-10 Thread Ryota Ozaki
On Thu, Dec 10, 2009 at 9:36 PM, Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 09:26:39PM +0900, Ryota Ozaki wrote: >> On Thu, Dec 10, 2009 at 9:03 PM, Daniel P. Berrange >> wrote: >> > On Thu, Dec 10, 2009 at 02:22:37AM -0600, Tony Risinger wrote: >> >> i'm trying to get even the simplest

[libvirt] Re: libvirk KVM save (migrate) terribly slow

2009-12-10 Thread Pierre Riteau
On 10 déc. 2009, at 12:44, Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 08:05:12AM +0100, Nikola Ciprich wrote: >> Hi, >> I noticed that using libvirt to save running domain is terribly slow, >> I mean it can take even 10 minutes to save VM with 2GB RAM, although >> the host is almost idle

[libvirt] [PATCH 1/3] Make QEMU driver use -chardev everywhere when it's available

2009-12-10 Thread Matthew Booth
Change -monitor, -serial and -parallel output to use -chardev if it is available. * src/qemu/qemu_conf.c: Update qemudBuildCommandLine to use -chardev where available. * tests/qemuxml2argvtest.c tests/qemuxml2argvdata/: Add -chardev equivalents for all current serial and parallel tests. --- s

[libvirt] [PATCH 2/3] Extract the assigned pty device for channels

2009-12-10 Thread Matthew Booth
* src/qemu/qemu_driver.c: Parse pty devices for channels --- src/qemu/qemu_driver.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2fb059d..c1feb0f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driv

[libvirt] [PATCH 3/3] Get QEMU pty paths from the monitor

2009-12-10 Thread Matthew Booth
This change makes the QEMU driver get pty paths from the output of the monitor 'info chardev' command. This output is structured, and contains both the name of the device and the path on the same line. This is considerably more reliable than parsing the startup log output, which requires the parsin

Re: [libvirt] [RFC] New libvirt API for domain memory statistics reporting

2009-12-10 Thread Adam Litke
On Thu, 2009-12-10 at 11:54 +, Daniel P. Berrange wrote: > I've looked at the code in all the patches, and it all looks good to me. > As others have said the main issue at hand is to get a better definition > of the set of statistics we're going to have in the public struct. > > Even though yo

[libvirt] [PATCH] Fix error in secret.rng schema.

2009-12-10 Thread Diego Elio 'Flameeyes' Pettenò
With this error the schema is not a well-formed XML file. --- docs/schemas/secret.rng |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/schemas/secret.rng b/docs/schemas/secret.rng index 40e2b7f..39f8625 100644 --- a/docs/schemas/secret.rng +++ b/docs/schemas/secret.rn

[libvirt] Apologies for miss-configured Out-of-Office auto-replies

2009-12-10 Thread Konrad Eriksson1
Dear list members, I'm terribly sorry for my badly configured Out-of-Office auto-reply feature in my email client that might have caused several replies to libvir-list emails received by me. It should be solved now (thanks to Daniel Veillard for pointing it out). Again sorry for the unintenti

[libvirt] [PATCH] Fix error in secret.rng schema.

2009-12-10 Thread Diego Elio 'Flameeyes' Pettenò
Without this error the schema is not a well-formatted XML file. --- docs/schemas/secret.rng |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/schemas/secret.rng b/docs/schemas/secret.rng index 40e2b7f..39f8625 100644 --- a/docs/schemas/secret.rng +++ b/docs/schemas/sec

[libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Diego Elio “Flameeyes” Pettenò
Hello, In a recent post on my blog [1] I ranted on about libvirt and in particular I complained that the configuration files look like what I call “almost XML”. The reasons why I say that are multiple, let me try to explain some. In the configuration files, at least those created by virt-manager

Re: [libvirt] [PATCH] Fix error in secret.rng schema.

2009-12-10 Thread Daniel Veillard
On Thu, Dec 10, 2009 at 03:57:12PM +0100, Diego Elio 'Flameeyes' Pettenò wrote: > Without this error the schema is not a well-formatted XML file. > --- > docs/schemas/secret.rng |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/docs/schemas/secret.rng b/docs/schemas/s

[libvirt] [PATCH] Replace with .

2009-12-10 Thread Diego Elio 'Flameeyes' Pettenò
The two syntax should be equivalent, but the former creates, with trang, an invalid Relax-NG Compact form file, as the output will contain the sequence "+?" which is not recognized by tools like rnv. --- docs/schemas/domain.rng | 40 +++- 1 files changed, 19 i

Re: [libvirt] Segmentation fault when shutting down VMs

2009-12-10 Thread Thomas Treutner
On Friday 13 November 2009 12:46:24 Daniel P. Berrange wrote: > On Fri, Nov 13, 2009 at 11:42:46AM +0100, Thomas Treutner wrote: > > Hi, > > > > I'm facing another problem with latest git. > > > > This happens regularly when shutting down VM(s): > > > > http://pastebin.com/m4ef1d93f > > > > It does

[libvirt] [PATCH] qemu driver: Fix segfault in libvirt/libvirtd when uri->path is NULL

2009-12-10 Thread Richard W.M. Jones
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v >From c11a82b62aefc21e070c527f59a1f9c57

Re: [libvirt] Segmentation fault when shutting down VMs

2009-12-10 Thread Matthias Bolte
2009/12/10 Thomas Treutner : > On Friday 13 November 2009 12:46:24 Daniel P. Berrange wrote: >> On Fri, Nov 13, 2009 at 11:42:46AM +0100, Thomas Treutner wrote: >> > Hi, >> > >> > I'm facing another problem with latest git. >> > >> > This happens regularly when shutting down VM(s): >> > >> > http:/

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Daniel Veillard
On Thu, Dec 10, 2009 at 04:51:54PM +0100, Diego Elio “Flameeyes” Pettenò wrote: > Hello, > > In a recent post on my blog [1] I ranted on about libvirt and in > particular I complained that the configuration files look like what I > call “almost XML”. The reasons why I say that are multiple, let me

Re: [libvirt] [PATCH] qemu driver: Fix segfault in libvirt/libvirtd when uri->path is NULL

2009-12-10 Thread Daniel Veillard
On Thu, Dec 10, 2009 at 04:40:14PM +, Richard W.M. Jones wrote: > > -- > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones > virt-p2v converts physical machines to virtual machines. Boot with a > live CD or over the network (PXE) and turn machines into Xen guests.

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Cole Robinson
On 12/10/2009 10:51 AM, Diego Elio “Flameeyes” Pettenò wrote: > Hello, > > In a recent post on my blog [1] I ranted on about libvirt and in > particular I complained that the configuration files look like what I > call “almost XMLâ€�. The reasons why I say that are multiple, let me try > to expl

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Matthias Bolte
2009/12/10 Daniel Veillard : > >  So thanks for reporting the existing bugs, I ended up on your blog > post randomly and I though the best was to get you here to actually > solve the issues, seems to have worked better than I expected :-) > There is still that crash problem you wrote about and whic

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Diego Elio “Flameeyes” Pettenò
Il giorno Thu, 10/12/2009 alle 18.28 +0100, Matthias Bolte ha scritto: > > The crash could be due to the QEMU monitor handling problem that was > recently fixed. Yup that seems to be it, tied with a crash in qemu-kvm's 0.11.0 handling of virtio network (qemu crashed, which then caused libvirt to

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 12:09:23PM -0500, Cole Robinson wrote: > > This is something that has always bugged me as well, and is indeed a > pain to deal with in virt-manager when doing things like changing cdrom > media. I think we should just loosen the input restrictions, so that any > path passed

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Richard W.M. Jones
On Thu, Dec 10, 2009 at 05:44:43PM +0100, Daniel Veillard wrote: > Your viewpoint is that users should edit the XML. My viewpoint is that > software should do this, basically in normal use of libvirt nobody > should have to look at the XML, the virt-viewer/virt-install etc... > tools should gener

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Matthias Bolte
2009/12/10 Diego Elio “Flameeyes” : > Il giorno Thu, 10/12/2009 alle 18.28 +0100, Matthias Bolte ha scritto: >> >> The crash could be due to the QEMU monitor handling problem that was >> recently fixed. > > Yup that seems to be it, tied with a crash in qemu-kvm's 0.11.0 handling > of virtio network

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 05:49:39PM +, Richard W.M. Jones wrote: > On Thu, Dec 10, 2009 at 05:44:43PM +0100, Daniel Veillard wrote: > > Your viewpoint is that users should edit the XML. My viewpoint is that > > software should do this, basically in normal use of libvirt nobody > > should have

[libvirt] [PATCH, TCK] Add missing module Test::Exception to the required module list

2009-12-10 Thread Matthias Bolte
--- Build.PL |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Build.PL b/Build.PL index df35abf..453172c 100644 --- a/Build.PL +++ b/Build.PL @@ -69,6 +69,7 @@ my $b = $class->new( 'TAP::Formatter::HTML' => 0, 'TAP::Harness' => 3.11, 'TAP::Harness::A

[libvirt] [PATCH, TCK] Install tests to /usr/share/... instead of /share/...

2009-12-10 Thread Matthias Bolte
libvirt-tck expects the tests in /usr/share/libvirt-tck/tests. --- Build.PL |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Build.PL b/Build.PL index 453172c..c85a072 100644 --- a/Build.PL +++ b/Build.PL @@ -100,5 +100,5 @@ my $b = $class->new( $b->add_build_element("con

Re: [libvirt] [PATCH, TCK] Add missing module Test::Exception to the required module list

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 07:18:27PM +0100, Matthias Bolte wrote: > --- > Build.PL |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Build.PL b/Build.PL > index df35abf..453172c 100644 > --- a/Build.PL > +++ b/Build.PL > @@ -69,6 +69,7 @@ my $b = $class->new( > 'TA

Re: [libvirt] [PATCH, TCK] Install tests to /usr/share/... instead of /share/...

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 07:18:58PM +0100, Matthias Bolte wrote: > libvirt-tck expects the tests in /usr/share/libvirt-tck/tests. > --- > Build.PL |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Build.PL b/Build.PL > index 453172c..c85a072 100644 > --- a/Build.PL > +

Re: [libvirt] [PATCH] expose SR IOV physical/virtual function relationships

2009-12-10 Thread Daniel P. Berrange
On Fri, Dec 04, 2009 at 10:30:46AM -0500, Dave Allan wrote: > Daniel P. Berrange wrote: > > > >I don't much like including the raw BDF format, because it is effectively > >adding a 3rd way of specifying PCI addresses in libvirt XML. We already > >have 2 different ways, which is 1 too many > > > >No

Re: [libvirt] [PATCH] expose SR IOV physical/virtual function relationships

2009-12-10 Thread Dave Allan
On 12/10/2009 03:16 PM, Daniel P. Berrange wrote: On Fri, Dec 04, 2009 at 10:30:46AM -0500, Dave Allan wrote: Daniel P. Berrange wrote: I don't much like including the raw BDF format, because it is effectively adding a 3rd way of specifying PCI addresses in libvirt XML. We already have 2 diffe

[libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-10 Thread Daniel P. Berrange
This patch series is a combination of series done by Wolfgang Mauerer to support proper SCSI drive hotplug and new work by myself to introduce generic addressing for all devices. Wolfgang's most recent posting was http://www.redhat.com/archives/libvir-list/2009-November/msg00574.html http://www.r

[libvirt] [PATCH 01/12] Introduce a standardized data structure for device addresses

2009-12-10 Thread Daniel P. Berrange
All guest devices now use a common device address structure summarized by: enum virDomainDeviceAddressType { VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI, }; enum virDomainDeviceAddressMode { VIR_DOMAIN_DEVICE_ADDRESS_MODE_DYNAMIC, VIR_DOMAIN_DEVIC

[libvirt] [PATCH 02/12] Extend the virDomainDeviceAddress struture to allow USB addresses

2009-12-10 Thread Daniel P. Berrange
Introduce a new structure struct _virDomainDeviceUSBAddress { unsigned int bus; unsigned int dev; }; and plug that into virDomainDeviceAddress. Convert the host device USB config to use this new address struct. XML looks like --- src/conf/domain_conf.c

[libvirt] [PATCH 03/12] Extend the virDomainDeviceAddress struture to allow disk controller addresses

2009-12-10 Thread Daniel P. Berrange
Introduce a new structure struct _virDomainDeviceDriveAddress { unsigned int controller; unsigned int bus; unsigned int unit; }; and plug that into virDomainDeviceAddress and generates XML that looks like * src/conf/domain_conf.h, src/conf/domain_conf.c: P

[libvirt] [PATCH 04/12] Add address info to sound, video and watchdog devices

2009-12-10 Thread Daniel P. Berrange
Add the virDomainDeviceAddress information to the sound, video and watchdog devices. This means all of them gain a new XML element * src/conf/domain_conf.h: Add virDomainDeviceAddress to sound, video & watchdog device struts. * src/conf/domain_conf.c: Hook up parsing/formatting for virDoma

[libvirt] [PATCH 05/12] Clear dynamic values from domain config at shutdown

2009-12-10 Thread Daniel P. Berrange
Some attributes in the guest config are only valid at runtime. Although the XML parser/formatter are careful to avoid outputting these attributes at the wrong time, there is still a risk that the driver code may accidentally use them internally. We can solve this by explicitly clearing all values

[libvirt] [PATCH 06/12] Add new domain device: "controller"

2009-12-10 Thread Daniel P. Berrange
From: Wolfgang Mauerer This augments virDomainDevice with a element that is used to represent disk controllers (e.g., scsi controllers). The XML format is given by where type denotes the disk interface (scsi, ide,...), index is an integer that identifies the controller for associat

[libvirt] [PATCH 07/12] Convert monitor over to use virDomainDeviceAddress

2009-12-10 Thread Daniel P. Berrange
Convert the QEMU monitor APIs over to use virDomainDeviceAddress structs for passing addresses in/out, instead of individual bits * src/qemu/qemu_driver.c, src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h, src/qemu/qemu_monitor_text.c, src/qemu/qemu_monitor_text.h: Change monitor hotplug APIs

[libvirt] [PATCH 08/12] Split code for building QEMU -drive arg in separate method

2009-12-10 Thread Daniel P. Berrange
To enable it to be called from multiple locations, split out the code for building the -drive arg string * src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Add qemuBuildDriveStr for building -drive arg string --- src/qemu/qemu_conf.c | 188 -- src/qem

[libvirt] [PATCH 09/12] Specify bus/unit instead of index for disks with QEMU

2009-12-10 Thread Daniel P. Berrange
The current code for using -drive simply sets the -drive 'index' parameter. QEMU internally converts this to bus/unit depending on the type of drive. This does not give us precise control over the bus/unit assignment though. This change switches over to make libvirt explicitly calculate the bus/uni

[libvirt] [PATCH 10/12] Implement SCSI controller hotplug/unplug for QEMU

2009-12-10 Thread Daniel P. Berrange
From: Wolfgang Mauerer This patch allows for explicit hotplug/unplug of SCSI controllers. Ordinarily this is not required, since QEMU/libvirt will attach a new SCSI controller whenever one is required. Allowing explicit hotplug of controllers though, enables the caller to specify a static PCI add

[libvirt] [PATCH 12/12] Detect PCI addresses at QEMU startup

2009-12-10 Thread Daniel P. Berrange
Hotunplug of devices requires that we know their PCI address. Even hotplug of SCSI drives, required that we know the PCI address of the SCSI controller to attach the drive to. We can find this out by running 'info pci' and then correlating the vendor/product IDs with the devices we booted with. *

[libvirt] [PATCH 11/12] Properly support SCSI drive hotplug

2009-12-10 Thread Daniel P. Berrange
The current SCSI hotplug support attaches a brand new SCSI controller for every disk. This is broken because the semantics differ from those used when starting the VM initially. In the latter case, each SCSI controller is filled before a new one is added. If the user specifies an high drive index

[libvirt] the tag (WAS: simple LXC/libvirt busybox container (Unable to get cgroup))

2009-12-10 Thread Tony Risinger
wow! i was starting to think i would never get past this problem! [r...@phs-001 ~]# echo $VIRSH_DEFAULT_CONNECT_URI lxc:/// [r...@phs-001 ~]# virsh create /vps/def/exec/sys/arch-nano.xml Domain arch-nano created from /vps/def/exec/sys/arch-nano.xml [r...@phs-001 ~]# virsh console arch-nano Conn

[libvirt] [PATCH] Fix memory leak in virStorageBackendCopyToFD

2009-12-10 Thread Matthias Bolte
--- src/storage/storage_backend.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index a3b4d5a..9dc801c 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -198,6 +198,8 @@ cleanu

[libvirt] [PATCH] Fix reference leak in remoteDispatchStorageVolCreateXmlFrom

2009-12-10 Thread Matthias Bolte
--- daemon/remote.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 3117615..7a43046 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -4118,12 +4118,15 @@ remoteDispatchStorageVolCreateXmlFrom (struct qemud_server *server ATT

[libvirt] [PATCH] Remove iptables.c from POTFILES.in

2009-12-10 Thread Matthias Bolte
--- po/POTFILES.in |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index f8e9130..a429b19 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -50,7 +50,6 @@ src/uml/uml_conf.c src/uml/uml_driver.c src/util/bridge.c src/util/conf.c -src/ut

Re: [libvirt] My beefs with the libvirt XML configuration format

2009-12-10 Thread Daniel Veillard
On Thu, Dec 10, 2009 at 06:07:13PM +, Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 05:49:39PM +, Richard W.M. Jones wrote: > > On Thu, Dec 10, 2009 at 05:44:43PM +0100, Daniel Veillard wrote: > > > Your viewpoint is that users should edit the XML. My viewpoint is that > > > softwar

Re: [libvirt] [PATCH] Replace with .

2009-12-10 Thread Daniel Veillard
On Thu, Dec 10, 2009 at 05:18:15PM +0100, Diego Elio 'Flameeyes' Pettenò wrote: > The two syntax should be equivalent, but the former creates, with trang, an > invalid Relax-NG Compact form file, as the output will contain the sequence > "+?" which is not recognized by tools like rnv. > --- > docs