Re: [libvirt] [PATCH 6/7] Rewrite all the DTrace/SystemTAP probing

2011-10-10 Thread Daniel P. Berrange
On Fri, Oct 07, 2011 at 12:01:18PM -0600, Eric Blake wrote: On 10/07/2011 09:56 AM, Daniel P. Berrange wrote: +libvirt_functions.stp: $(wildcard */*.x) $(srcdir)/rpc/gensystemtap.pl +$(AM_V_GEN)perl -w $(srcdir)/rpc/gensystemtap.pl $(wildcard */*.x) $@ Does this still work in VPATH

Re: [libvirt] [Qemu-devel] [RFC] Adding new filesystem 'proxy' to 9p

2011-10-10 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Thu, Sep 29, 2011 at 11:42:47PM +0530, M. Mohan Kumar wrote: On Wednesday, September 28, 2011 08:29:06 PM Daniel P. Berrange wrote: [...] If we assume that QEMU gets exploited, and that QEMU can find some flaw in the proxy_helper that it can

Re: [libvirt] [v2] storage: Do not use comma as seperator for lvs output

2011-10-10 Thread Osier Yang
于 2011年10月10日 12:28, Osier Yang 写道: * src/storage/storage_backend_logical.c: If a logical vol is created as striped. (e.g. --stripes 3), the device field of lvs output will have multiple fileds which are seperated by comma. Thus the RE we write in the codes will not work well anymore. E.g.

[libvirt] [PATCH] dissectors: Create dissector for Libvirt RPC

2011-10-10 Thread Michal Privoznik
This patch creates basic dissector for Libvirt RPC. The protocol description can be found here: http://libvirt.org/internals/rpc.html Currently, only packet head dissecting is written. To fully dissect packet payloads a more effort is needed, as each function has different arguments (in

Re: [libvirt] [RFC PATCH 1/4] powerpc: Use Sysfs to gather host info

2011-10-10 Thread Daniel P. Berrange
On Sat, Oct 08, 2011 at 12:07:08AM +0530, Prerna Saxena wrote: Libvirt presently depends on /proc/cpuinfo to gather information about the x86 host. Parsing of /proc/cpuinfo is arch-specific; the information fields are also not consistent. A cleaner way would be to use Sysfs. Both x86 and

Re: [libvirt] [RFC PATCH 2/4] powerpc: Add cpu driver for powerpc host

2011-10-10 Thread Daniel P. Berrange
On Sat, Oct 08, 2011 at 12:12:46AM +0530, Prerna Saxena wrote: This part of code primarily compares host and guest CPUs of a given architecture for feature compatibility. x86 makes this choice based on CPUID comparison. Presently the PowerPC code has stubs to just get a 'pseries' guest to

Re: [libvirt] [RFC PATCH 3/4] powerpc: Add support for qemu-system-ppc64 in qemu capabilities

2011-10-10 Thread Daniel P. Berrange
On Sat, Oct 08, 2011 at 12:17:18AM +0530, Prerna Saxena wrote: This patch has a small parser which correctly interprets qemu-system-ppc64 output for a specific query. This code is independent for powerpc and largely does not interfere with x86 implementation. ---

Re: [libvirt] [RFC PATCH 4/4] powerpc: Remove incompatible command line options from qemu startup

2011-10-10 Thread Daniel P. Berrange
On Sat, Oct 08, 2011 at 12:19:11AM +0530, Prerna Saxena wrote: This patch is a hack at the moment and would need code refactoring to split-out the defaults for x86 and powerpc. Libvirt chooses a set of default options such as disk controller, network specific options, etc which are suitable

Re: [libvirt] [v2] storage: Do not use comma as seperator for lvs output

2011-10-10 Thread Daniel P. Berrange
On Mon, Oct 10, 2011 at 12:28:04PM +0800, Osier Yang wrote: * src/storage/storage_backend_logical.c: If a logical vol is created as striped. (e.g. --stripes 3), the device field of lvs output will have multiple fileds which are seperated by comma. Thus the RE we write in the codes will not

Re: [libvirt] [RFC PATCH 0/4] powerpc : Libvirt for the PowerPC platform

2011-10-10 Thread Daniel P. Berrange
On Fri, Oct 07, 2011 at 11:58:16PM +0530, Prerna Saxena wrote: Libvirt continues to be the key interface to configure and manage the KVM guest instances on x86. We would like to enhance libvirt to support KVM guest configuration and management on Power Book3S machines. Yep, we'd like to see

Re: [libvirt] [PATCH] Introduce driver under filesystem to support open-by-handle.

2011-10-10 Thread Daniel P. Berrange
On Fri, Oct 07, 2011 at 04:32:42PM +0530, Harsh Prateek Bora wrote: VirtFS allows the user to choose between local/handle for fs driver. As of now, libvirt hardcode to use local driver only. This patch provides a solution to allow user to choose between local/handle as fs driver. Sample:

[libvirt] [PATCH] events: Propose a separate lock for event queue

2011-10-10 Thread Michal Privoznik
Currently, push pop from event queue (both server client side) rely on lock from higher levels, e.g. on driver lock (qemu), private_data (remote), ...; This alone is not sufficient as not every function that interacts with this queue can/does lock, esp. in client where we have a different

[libvirt] [PATCH v2] Introduce driver under filesystem to support open-by-handle.

2011-10-10 Thread Harsh Prateek Bora
VirtFS allows the user to choose between path/handle based fs driver. As of now, libvirt hardcode to use path based driver only. This patch provides a solution to allow user to choose between path/handle based fs driver. Sample: filesystem type='mount' driver type='handle'/

Re: [libvirt] [PATCH] Introduce driver under filesystem to support open-by-handle.

2011-10-10 Thread Harsh Bora
On 10/10/2011 03:47 PM, Daniel P. Berrange wrote: On Fri, Oct 07, 2011 at 04:32:42PM +0530, Harsh Prateek Bora wrote: VirtFS allows the user to choose between local/handle for fs driver. As of now, libvirt hardcode to use local driver only. This patch provides a solution to allow user to choose

Re: [libvirt] [v2] storage: Do not use comma as seperator for lvs output

2011-10-10 Thread Osier Yang
于 2011年10月10日 18:05, Daniel P. Berrange 写道: On Mon, Oct 10, 2011 at 12:28:04PM +0800, Osier Yang wrote: * src/storage/storage_backend_logical.c: If a logical vol is created as striped. (e.g. --stripes 3), the device field of lvs output will have multiple fileds which are seperated by comma.

[libvirt] [RFC PATCH 0/5] Summary on QEMU I/O throttling support to libvirt

2011-10-10 Thread Lei Li
Today libvirt supports the cgroups blkio-controller, which handles proportional shares and throughput/iops limits on host block devices. blkio-controller does not support network file systems (NFS) or other QEMU remote block drivers (curl, Ceph/rbd, sheepdog) since they are not host block

[libvirt] [RFC PATCH 1/5] Add new API virDomainBlockIoThrottle

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 22 src/conf/domain_conf.c | 77 ++ src/conf/domain_conf.h | 11 ++ src/driver.h | 11 ++ src/libvirt.c

[libvirt] [RFC PATCH 2/5] Add virDomainBlockIoThrottle support to the remote driver

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- daemon/remote.c | 51 src/remote/remote_driver.c | 53 ++ src/remote/remote_protocol.x | 24 ++-

[libvirt] [RFC PATCH 4/5] Enable the virDomainBlockIoThrottle API in virsh

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- tools/virsh.c | 86 +++ tools/virsh.pod | 13 2 files changed, 99 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 9532bc3..51487b7 100644 ---

[libvirt] [RFC PATCH 5/5] Enable virDomainBlockIoThrottle in the python API

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- python/generator.py |1 + python/libvirt-override-api.xml |9 python/libvirt-override.c | 43 +++ 3 files changed, 53 insertions(+), 0 deletions(-) diff --git

[libvirt] [RFC PATCH 3/5] Implement virDomainBlockIoThrottle for the qemu driver

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/qemu/qemu_command.c | 35 ++ src/qemu/qemu_driver.c | 54 + src/qemu/qemu_migration.c| 16 +++--- src/qemu/qemu_monitor.c | 19 +++ src/qemu/qemu_monitor.h |6 ++

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-10 Thread Guido Günther
On Fri, Oct 07, 2011 at 12:18:51PM +0200, Guido Günther wrote: On Thu, Oct 06, 2011 at 04:33:49PM -0600, Eric Blake wrote: On 10/06/2011 11:36 AM, Guido Günther wrote: These three errors should probably all be changed away from VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not

[libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

2011-10-10 Thread Guido Guenther
On xen 4.1 I observied configurations that look like: (image (hvm (kernel '') (loader '/foo/bar') )) The kernel element is there but unset. This leads to an emtpy kernel/ element in the XML and even worse makes us skip the boot order parsing and therefore not emit a boot

Re: [libvirt] [PATCH] add a default event handle, to passthough the new events come from qemu

2011-10-10 Thread Sheldon
On 10/10/2011 11:54 PM, shao...@linux.vnet.ibm.com wrote: From: Shaohe Fengshao...@linux.vnet.ibm.com Basically, this feature can go along with qemu monitor passthrough. That way, if we use new commands in the monitor that generate new events, we want some way to receive those new events

[libvirt] [PATCH] add a default event handle, to passthough the new events come from qemu

2011-10-10 Thread shaohef
From: Shaohe Feng shao...@linux.vnet.ibm.com Basically, this feature can go along with qemu monitor passthrough. That way, if we use new commands in the monitor that generate new events, we want some way to receive those new events too. In order to test this patch, see the attached python test

Re: [libvirt] [PATCH 1/2] snapshot: sort snapshot-list --tree

2011-10-10 Thread Eric Blake
On 10/09/2011 08:23 PM, Daniel Veillard wrote: On Fri, Oct 07, 2011 at 04:35:28PM -0600, Eric Blake wrote: Otherwise, the results are not repeatable. * tools/virsh.c (cmdSnapshotList): Print tree in predictable order. --- tools/virsh.c |4 ++-- 1 files changed, 2 insertions(+), 2

[libvirt] libvirt changes/certification questions

2011-10-10 Thread Udayan Bapat
Hi I am new to open source development and had a question about libvirt/KVM support in the linux kernel. In general since many people are contributing to the library, are there any 'standardized regressions or certification tests' available that make sure that that the existing libvirt

Re: [libvirt] [libvirt-glib 00/24] libvirt-gconfig patches

2011-10-10 Thread Daniel P. Berrange
On Fri, Oct 07, 2011 at 11:40:45AM +0200, Christophe Fergeau wrote: Hi, Here is a set of patches which start to implement functionality to libvirt-gconfig. The end result is that the name, memory and features properties are implemented for the Domain class. Most of the work is about

Re: [libvirt] [PATCH 2/2] snapshot: avoid accidental renames with snapshot-edit

2011-10-10 Thread Eric Blake
On 10/09/2011 08:24 PM, Daniel Veillard wrote: On Fri, Oct 07, 2011 at 04:35:29PM -0600, Eric Blake wrote: I was a bit surprised that 'virsh snapshot-edit dom name' silently allowed me to clone things, while still telling me the old name, especially since other commands like 'virsh edit dom'

Re: [libvirt] libvirt changes/certification questions

2011-10-10 Thread Eric Blake
On 10/10/2011 11:30 AM, Udayan Bapat wrote: Hi I am new to open source development and had a question about libvirt/KVM support in the linux kernel. In general since many people are contributing to the library, are there any 'standardized regressions or certification tests' available that make

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-10 Thread Eric Blake
On 10/07/2011 04:18 AM, Guido Günther wrote: ACK to the concept, once we decide on the correct error code. I think we've decided. (Hopefully) final version attached. I've left the first error as INTERNAL_ERROR since this it's there do detect false function parameters. Yes, you got that

Re: [libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

2011-10-10 Thread Eric Blake
On 10/10/2011 09:14 AM, Guido Guenther wrote: On xen 4.1 I observied configurations that look like: s/observied/observed/ (image (hvm (kernel '') (loader '/foo/bar') )) The kernel element is there but unset. This leads to an emtpykernel/ element in the XML and even

[libvirt] ALERT Virtualization Automatic Builder

2011-10-10 Thread berrange
Overall status: failed Start date: Mon Oct 10 2011 Start time: 19:05:02 UTC / 15:05:02 EDT Build counter: 1318273502 Build timestamp: 1318273502 URL: http://builder.virt-tools.org/index.html Module: libvirt Status: failed URL: http://builder.virt-tools.org/module-libvirt.html -- libvir-list

Re: [libvirt] ALERT Virtualization Automatic Builder

2011-10-10 Thread Eric Blake
On 10/10/2011 01:29 PM, berra...@redhat.com wrote: Overall status: failed Start date: Mon Oct 10 2011 Start time: 19:05:02 UTC / 15:05:02 EDT Build counter: 1318273502 Build timestamp: 1318273502 URL: http://builder.virt-tools.org/index.html Module: libvirt Status: failed URL:

Re: [libvirt] [PATCH] dissectors: Create dissector for Libvirt RPC

2011-10-10 Thread Dave Allan
On Mon, Oct 10, 2011 at 11:54:16AM +0200, Michal Privoznik wrote: This patch creates basic dissector for Libvirt RPC. The protocol description can be found here: http://libvirt.org/internals/rpc.html Currently, only packet head dissecting is written. To fully dissect packet payloads a

[libvirt] [PATCH] maint: typo fixes

2011-10-10 Thread Eric Blake
I noticed a couple typos in recent commits, and fixed the remaining instances of them. * docs/internals/command.html.in: Fix spelling errors. * include/libvirt/libvirt.h.in (virConnectDomainEventCallback): Likewise. * python/libvirt-override.py (virEventAddHandle): Likewise. *

Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

2011-10-10 Thread Guido Günther
On Mon, Oct 10, 2011 at 01:23:20PM -0600, Eric Blake wrote: On 10/07/2011 04:18 AM, Guido Günther wrote: ACK to the concept, once we decide on the correct error code. I think we've decided. (Hopefully) final version attached. I've left the first error as INTERNAL_ERROR since this it's

Re: [libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

2011-10-10 Thread Guido Günther
On Mon, Oct 10, 2011 at 01:24:35PM -0600, Eric Blake wrote: On 10/10/2011 09:14 AM, Guido Guenther wrote: On xen 4.1 I observied configurations that look like: s/observied/observed/ (image (hvm (kernel '') (loader '/foo/bar') )) The kernel element is there

[libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-10 Thread Eric Blake
To date, disk snapshots worked by accident, as they were always using hmp fallback due to a typo in commit e702b5b not picking up on the (intentional) difference in command names between the two monitor protocols. * src/qemu/qemu_monitor_json.c (qemuMonitorJSONDiskSnapshot): Spell QMP command

[libvirt] [PATCH] libvirt-tck: add junit output

2011-10-10 Thread Guido Günther
Hi, having JUnit like XML allows for easy integration into CI tools like Jenkins. Attach patch adds this using TAP::Formatter::JUnit. Does this look reasonable? -- Guido From 85880da3060dfad62183bb7c8ab881a345dacd3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org

Re: [libvirt] [PATCH 3/4] snapshot: take advantage of new relations

2011-10-10 Thread Eric Blake
On 10/09/2011 09:02 PM, Daniel Veillard wrote: +if (!(flags VIR_DOMAIN_SNAPSHOT_LIST_ROOTS)) { +virHashForEach(snapshots-objs, virDomainSnapshotObjListCount,data); +} else if (data.flags) { +virDomainSnapshotObjPtr root = snapshots-first_root; +while (root) { +

Re: [libvirt] [PATCH 2/4] snapshot: track qemu snapshot relations

2011-10-10 Thread Eric Blake
On 10/09/2011 08:43 PM, Daniel Veillard wrote: On Fri, Oct 07, 2011 at 06:05:55PM -0600, Eric Blake wrote: Maintain the parent/child relationships of all qemu snapshots. * src/qemu/qemu_driver.c (qemuDomainSnapshotLoad): Populate relationships after loading. (qemuDomainSnapshotCreateXML): Set

Re: [libvirt] [PATCH 1/4] snapshot: framework for more efficient relation traversal

2011-10-10 Thread Eric Blake
On 10/09/2011 08:37 PM, Daniel Veillard wrote: This layout intentionally hardcodes the size of each snapshot, by tracking sibling pointers, rather than having to deal with the headache of yet more memory management by directly sticking a child[] on each parent. Okay, so you're using a 'first

Re: [libvirt] [PATCH] libvirt-tck: add junit output

2011-10-10 Thread Eric Blake
On 10/10/2011 03:46 PM, Guido Günther wrote: Hi, having JUnit like XML allows for easy integration into CI tools like Jenkins. Attach patch adds this using TAP::Formatter::JUnit. Does this look reasonable? Do we need to modify a spec file to pull in the TAP::Formatter::JUnit module when

[libvirt] [PATCH] docs: fix html bug

2011-10-10 Thread Eric Blake
/space doesn't exist. Introduced in commit 4bb4109f. * docs/formatdomain.html.in: Use correct end tag. --- Pushing under the trivial rule. docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in

Re: [libvirt] [PATCH v4 1/2] virDomainCoreDump: Introduce VIR_DUMP_RESET flag

2011-10-10 Thread Eric Blake
On 09/26/2011 10:19 AM, Michal Privoznik wrote: This flag is intended to allow user to do so called system reset after dump, instead of sending ACPI reboot event. --- include/libvirt/libvirt.h.in |1 + src/libvirt.c| 15 ++- tools/virsh.c|

Re: [libvirt] [PATCH v4 2/2] qemu: Implement VIR_DUMP_RESET

2011-10-10 Thread Eric Blake
On 09/26/2011 10:19 AM, Michal Privoznik wrote: This patch extends qemudDomainCoreDump so it supports new VIR_DUMP_RESET flag. If this flag is set, domain is reset on successful dump. However, this is needed to be done after we start CPUs. --- src/qemu/qemu_driver.c |9 - 1 files

Re: [libvirt] [PATCHv2 1/7] snapshot: new virDomainSnapshotListChildrenNames API

2011-10-10 Thread Eric Blake
On 10/09/2011 09:13 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:23PM -0600, Eric Blake wrote: The previous API addition allowed traversal up the hierarchy; this one makes it easier to traverse down the hierarchy. In the python bindings, virDomainSnapshotNumChildren can be

Re: [libvirt] [PATCHv2 2/7] snapshot: virsh snapshot-list and children

2011-10-10 Thread Eric Blake
On 10/09/2011 09:16 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:24PM -0600, Eric Blake wrote: Sometimes, we only care about one branch of the snapshot hierarchy. Make it easier to list a single branch, by using the new APIs. Technically, I could emulate these new virsh options on

Re: [libvirt] [PATCHv2 4/7] snapshot: virsh fallback for snapshot-list --from children

2011-10-10 Thread Eric Blake
On 10/09/2011 09:23 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:26PM -0600, Eric Blake wrote: Iterating over one level of children requires parsing all snapshots and their parents; a bit of code shuffling makes it pretty easy to do this as well. -if (tree) { -char

Re: [libvirt] [PATCHv2 5/7] snapshot: virsh fallback for snapshot-list --descendants --from

2011-10-10 Thread Eric Blake
On 10/09/2011 09:25 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:27PM -0600, Eric Blake wrote: Given a list of snapshots and their parents, finding all descendants requires a hairy traversal. This code is O(n^3); it could maybe be made to scale O(n^2) with the use of a hash table,

Re: [libvirt] [PATCHv2 7/7] snapshot: implement snapshot children listing in qemu

2011-10-10 Thread Eric Blake
On 10/09/2011 09:29 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:29PM -0600, Eric Blake wrote: Not too hard to wire up. The trickiest part is realizing that listing children of a snapshot cannot use SNAPSHOT_LIST_ROOTS, and that we overloaded that bit to also mean

Re: [libvirt] [PATCHv2 10/7] snapshot: implement snapshot children listing in esx

2011-10-10 Thread Eric Blake
On 10/05/2011 02:07 AM, Matthias Bolte wrote: 2011/10/3 Eric Blakeebl...@redhat.com: It was fairly trivial to return snapshot listing based on a point in the hierarchy, rather than starting at all roots. * src/esx/esx_driver.c (esxDomainSnapshotNumChildren)

Re: [libvirt] [PATCH 3/4] snapshot: take advantage of new relations

2011-10-10 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 03:51:36PM -0600, Eric Blake wrote: On 10/09/2011 09:02 PM, Daniel Veillard wrote: +if (!(flags VIR_DOMAIN_SNAPSHOT_LIST_ROOTS)) { +virHashForEach(snapshots-objs, virDomainSnapshotObjListCount,data); +} else if (data.flags) { +

Re: [libvirt] [PATCH 1/4] snapshot: framework for more efficient relation traversal

2011-10-10 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 04:09:07PM -0600, Eric Blake wrote: On 10/09/2011 08:37 PM, Daniel Veillard wrote: This layout intentionally hardcodes the size of each snapshot, by tracking sibling pointers, rather than having to deal with the headache of yet more memory management by directly

Re: [libvirt] [PATCH 2/4] snapshot: track qemu snapshot relations

2011-10-10 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 03:58:27PM -0600, Eric Blake wrote: On 10/09/2011 08:43 PM, Daniel Veillard wrote: On Fri, Oct 07, 2011 at 06:05:55PM -0600, Eric Blake wrote: Maintain the parent/child relationships of all qemu snapshots. * src/qemu/qemu_driver.c (qemuDomainSnapshotLoad): Populate

Re: [libvirt] [PATCHv2 1/7] snapshot: new virDomainSnapshotListChildrenNames API

2011-10-10 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 05:07:47PM -0600, Eric Blake wrote: On 10/09/2011 09:13 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:23PM -0600, Eric Blake wrote: The previous API addition allowed traversal up the hierarchy; this one makes it easier to traverse down the hierarchy. In

Re: [libvirt] [PATCHv2 2/7] snapshot: virsh snapshot-list and children

2011-10-10 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 05:14:44PM -0600, Eric Blake wrote: On 10/09/2011 09:16 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:24PM -0600, Eric Blake wrote: Sometimes, we only care about one branch of the snapshot hierarchy. Make it easier to list a single branch, by using the new

Re: [libvirt] [PATCHv2 7/7] snapshot: implement snapshot children listing in qemu

2011-10-10 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 05:32:19PM -0600, Eric Blake wrote: On 10/09/2011 09:29 PM, Daniel Veillard wrote: On Fri, Sep 30, 2011 at 05:09:29PM -0600, Eric Blake wrote: Not too hard to wire up. The trickiest part is realizing that listing children of a snapshot cannot use SNAPSHOT_LIST_ROOTS,