Re: [libvirt] problems starting several qemu VMS simultaneously

2012-03-29 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@canonical.com): Quoting Wen Congyang (we...@cn.fujitsu.com): At 03/22/2012 06:54 AM, Serge Hallyn Wrote: Hi, I grabbed today's git head of libvirt. Created a VM (clean install of ubuntu oneiric, installed through virt-manager), and cloned it 3

Re: [libvirt] Constantly changing USB product ID

2012-03-29 Thread Philipp Hahn
Hello Jaap, On Thursday 29 March 2012 01:51:21 Jaap Winius wrote: Okay, thanks; so now I know that it's not just badly designed hardware that may do this. My device, however, is not a smart-phone or some other consumer device: it's a scanner with a rotating drum on which to mount flexible,

Re: [libvirt] [PATCH test-API 1/2] lib: pass instance of ConnectAPI into other lib modules

2012-03-29 Thread Martin Kletzander
On 03/26/2012 07:18 PM, Guannan Ren wrote: This change make any instance of subclasses in libvirt.py invisible to testcases in order to catch libvirtError. connectAPI.py domainAPI.py interfaceAPI.py networkAPI.py nodedevAPI.py

Re: [libvirt] [PATCH test-API 1/2] lib: pass instance of ConnectAPI into other lib modules

2012-03-29 Thread Guannan Ren
On 03/29/2012 05:14 PM, Martin Kletzander wrote: On 03/26/2012 07:18 PM, Guannan Ren wrote: This change make any instance of subclasses in libvirt.py invisible to testcases in order to catch libvirtError. connectAPI.py domainAPI.py interfaceAPI.py

[libvirt] [PATCH 0/4] Fix problems in test suite on Win32

2012-03-29 Thread Daniel P. Berrange
Since we enable the test suite by default now for all git checkouts, we need to make sure it actually builds on Win32. This series fixes it -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Set default name for SPICE agent channel

2012-03-29 Thread Christophe Fergeau
On Wed, Mar 28, 2012 at 03:20:45PM -0400, Laine Stump wrote: I know I'm a bit late to the party (I missed your mail before), but would it have been possible to do the default processing in the caller rather than in the parsing function itself? I cannot disagree since I was not sure at all that

[libvirt] [PATCH 1/4] Fix some format specifiers for size_t vs ssize_t

2012-03-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com A handful of places used %zd for format specifiers even though the args was size_t, not ssize_t. * src/remote/remote_driver.c, src/util/xml.c: s/%zd/%zu/ Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/remote/remote_driver.c |6

[libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32

2012-03-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Some of the test suites use fprintf with format specifiers that are not supported on Win32 and are not fixed by gnulib. The mingw32 compiler also has trouble detecting ssize_t correctly, complaining that 'ssize_t' does not match 'signed size_t' (which

[libvirt] [PATCH 3/4] Don't redefine the CPU comparison constants in CPU test

2012-03-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Defining an enum with names like ERROR causes a world of hurt on Win32 whose headers have such symbol names already * tests/cputest.c: Remove redefinition of CPU constants Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/cputest.c |

[libvirt] [PATCH 4/4] Disable build of commandhelper ssh on Win32

2012-03-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The commandhelper.c ssh.c programs rely on various APIs not present on Win32. Disable them, since the tests that uses these helpers are already disabled * tests/commandhelper.c, tests/ssh.c: Disable on WIN32 Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH test-API 2/2] repos: modify existing testcases to support it

2012-03-29 Thread Guannan Ren
On 03/29/2012 05:17 PM, Martin Kletzander wrote: On 03/26/2012 07:18 PM, Guannan Ren wrote: --- repos/domain/attach_disk.py|6 +++--- repos/domain/attach_interface.py |6 +++--- repos/domain/autostart.py |6

Re: [libvirt] [PATCH 1/4] Fix some format specifiers for size_t vs ssize_t

2012-03-29 Thread Laine Stump
On 03/29/2012 05:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com A handful of places used %zd for format specifiers even though the args was size_t, not ssize_t. * src/remote/remote_driver.c, src/util/xml.c: s/%zd/%zu/ Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32

2012-03-29 Thread Laine Stump
On 03/29/2012 05:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Some of the test suites use fprintf with format specifiers that are not supported on Win32 and are not fixed by gnulib. The mingw32 compiler also has trouble detecting ssize_t correctly,

Re: [libvirt] [PATCH 3/4] Don't redefine the CPU comparison constants in CPU test

2012-03-29 Thread Laine Stump
On 03/29/2012 05:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Defining an enum with names like ERROR causes a world of hurt on Win32 whose headers have such symbol names already * tests/cputest.c: Remove redefinition of CPU constants Signed-off-by: Daniel

Re: [libvirt] [PATCH 4/4] Disable build of commandhelper ssh on Win32

2012-03-29 Thread Laine Stump
On 03/29/2012 05:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The commandhelper.c ssh.c programs rely on various APIs not present on Win32. Disable them, since the tests that uses these helpers are already disabled * tests/commandhelper.c, tests/ssh.c:

[libvirt] [PATCH] qemu, util fix netlink callback registration for migration

2012-03-29 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name This patch adds a netlink callback when migrating a VEPA enabled virtual machine. It fixes a Bug where a VM would not request a port association when it was cleared by lldpad. This patch requires the latest git version of lldpad to work.

[libvirt] [PATCH test-API 0/2] add modules search path in main executable file

2012-03-29 Thread Guannan Ren
repos/domain/attach_disk.py| 11 --- repos/domain/attach_interface.py | 11 --- repos/domain/autostart.py | 11 --- repos/domain/balloon_memory.py | 11 ---

[libvirt] [PATCH test-API 1/2] Add root path of test-API into sys.path list

2012-03-29 Thread Guannan Ren
*libvirt-test-api.py before running testcases, we check whether the absolute root path of the testsuit is in sys.path. If not, add it. --- libvirt-test-api.py | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/libvirt-test-api.py b/libvirt-test-api.py

[libvirt] Java API for libvirit

2012-03-29 Thread Yaniv Hadad
Hello, Recently I found it useful to use your product for cross platform Hyperviscous in target to investigate guests and hosts os\state\version.. details . I am develop under Web-sphere environment. For saying the truth I didn't find any Java API for this target May you help me with this goal ??

Re: [libvirt] [PATCH test-API 1/2] Add root path of test-API into sys.path list

2012-03-29 Thread Osier Yang
On 2012年03月29日 19:38, Guannan Ren wrote: *libvirt-test-api.py before running testcases, we check whether the absolute root path of the testsuit is in sys.path. If not, add it. ACK with reorgnize the sentence like: libvirt-test-api.py: Check whether the absolute path of

[libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Martin Kletzander
Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to talk down to someone as it may have seemed

Re: [libvirt] [PATCH test-API 1/2] Add root path of test-API into sys.path list

2012-03-29 Thread Guannan Ren
On 03/29/2012 07:59 PM, Osier Yang wrote: On 2012年03月29日 19:38, Guannan Ren wrote: *libvirt-test-api.py before running testcases, we check whether the absolute root path of the testsuit is in sys.path. If not, add it. ACK with reorgnize the sentence like:

Re: [libvirt] [PATCH test-API 2/2] testcases: remove code of adding modules search path in testcases

2012-03-29 Thread Guannan Ren
On 03/29/2012 07:55 PM, Osier Yang wrote: On 2012年03月29日 19:38, Guannan Ren wrote: *remove the invoking for append_path() in all of testcases --- repos/domain/attach_disk.py| 11 --- repos/domain/attach_interface.py | 11 ---

Re: [libvirt] [test-API PATCH] log_output: Fix whitespace in log output XSL

2012-03-29 Thread Guannan Ren
On 03/29/2012 08:26 PM, Martin Kletzander wrote: On 03/29/2012 02:04 PM, Peter Krempa wrote: The XSL file that converts the log xml into a html file contains some strange whitespace characters that output in the HTML as squares. This patch fixes the whitespace and reformats the indetation to

Re: [libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32

2012-03-29 Thread Eric Blake
On 03/29/2012 03:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Some of the test suites use fprintf with format specifiers that are not supported on Win32 and are not fixed by gnulib. The mingw32 compiler also has trouble detecting ssize_t correctly,

Re: [libvirt] Java API for libvirit

2012-03-29 Thread Eric Blake
On 03/29/2012 05:49 AM, Yaniv Hadad wrote: Hello, Recently I found it useful to use your product for cross platform Hyperviscous in target to investigate guests and hosts os\state\version.. details . I am develop under Web-sphere environment. For saying the truth I didn't find any Java API

Re: [libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32

2012-03-29 Thread Daniel P. Berrange
On Thu, Mar 29, 2012 at 06:45:03AM -0600, Eric Blake wrote: On 03/29/2012 03:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Some of the test suites use fprintf with format specifiers that are not supported on Win32 and are not fixed by gnulib. The

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Peter Krempa
On 03/29/2012 02:14 PM, Martin Kletzander wrote: Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean

[libvirt] [PATCH] libvirt: Fix build err

2012-03-29 Thread ailvpeng25
From: Zhou Peng ailvpen...@gmail.com virNetDevMacVLanRestartWithVPortProfile is omitted in src/libvirt_private.syms, which causes link err. --- src/libvirt_private.syms |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms

[libvirt] Syntax check rules broken if 'exclude' is not defined

2012-03-29 Thread Daniel P. Berrange
I noticed that many (most) of the libvirt syntax-check rules were not generating any results, despite me introducing obvious violations. From my debugging the problem appears to be caused by this commit: commit 727075d03c670affa68f71313979781f5ba9bbfc Author: Eric Blake ebl...@redhat.com

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Osier Yang
On 2012年03月29日 20:14, Martin Kletzander wrote: Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Guannan Ren
On 03/29/2012 08:14 PM, Martin Kletzander wrote: - fix hard-coded options into real options (e.g. commit 65449e) - fix some env_* and util* code (functions duplicated with different behavior) - fix or remove harmful and pointless code (at this point, when creating domain on remote

Re: [libvirt] Java API for libvirit

2012-03-29 Thread Eric Blake
[please keep the list in the loop, avoid html mail, and avoid top-posting] On 03/29/2012 08:04 AM, Yaniv Hadad wrote: Hi Eric. Did you use it already ?? No, I have not personally used the Java bindings. Which is why keeping the list in the loop is a wise idea; you're more likely to reach

Re: [libvirt] [PATCH] libvirt: Fix build err

2012-03-29 Thread Michal Privoznik
On 29.03.2012 14:55, ailvpen...@gmail.com wrote: From: Zhou Peng ailvpen...@gmail.com virNetDevMacVLanRestartWithVPortProfile is omitted in src/libvirt_private.syms, which causes link err. --- src/libvirt_private.syms |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [libvirt] [PATCH] Consistent style for usage of sizeof operator

2012-03-29 Thread Eric Blake
On 03/29/2012 09:51 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The code is splattered with a mix of sizeof foo sizeof (foo) sizeof(foo) Standardize on sizeof(foo) and add a syntax check rule to enforce it We might also want to document our policy

Re: [libvirt] [PATCH] Consistent style for usage of sizeof operator

2012-03-29 Thread Daniel P. Berrange
On Thu, Mar 29, 2012 at 10:02:00AM -0600, Eric Blake wrote: On 03/29/2012 09:51 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The code is splattered with a mix of sizeof foo sizeof (foo) sizeof(foo) Standardize on sizeof(foo) and add a

[libvirt] [PATCHv2] qemu: support live change of the bridge used by a guest network device

2012-03-29 Thread Laine Stump
From: Hendrik Schwartke hend...@os-t.de Previously the only attribute of a network device that could be modified by virUpdateDeviceFlags() (virsh update-device) was the link state; attempts to change any other attribute would log an error and fail. (One notable exception to this was changing the

Re: [libvirt] serial console/events example script

2012-03-29 Thread Dave Allan
On Wed, Feb 15, 2012 at 09:11:32PM -0500, Dave Allan wrote: Hi all, A while back I wrote the attached code to demonstrate how to use events and serial console to create a serial console that stays up even when the VM is down. Is it worth adding to the examples? It might need some work, as

Re: [libvirt] [PATCH] Set default name for SPICE agent channel

2012-03-29 Thread Laine Stump
On 03/29/2012 05:52 AM, Christophe Fergeau wrote: On Wed, Mar 28, 2012 at 03:20:45PM -0400, Laine Stump wrote: I know I'm a bit late to the party (I missed your mail before), but would it have been possible to do the default processing in the caller rather than in the parsing function itself?

Re: [libvirt] [PATCHv2] qemu: support live change of the bridge used by a guest network device

2012-03-29 Thread Daniel P. Berrange
On Thu, Mar 29, 2012 at 04:38:50PM -0400, Laine Stump wrote: From: Hendrik Schwartke hend...@os-t.de Previously the only attribute of a network device that could be modified by virUpdateDeviceFlags() (virsh update-device) was the link state; attempts to change any other attribute would log

Re: [libvirt] serial console/events example script

2012-03-29 Thread Daniel P. Berrange
On Thu, Mar 29, 2012 at 04:55:39PM -0400, Dave Allan wrote: On Wed, Feb 15, 2012 at 09:11:32PM -0500, Dave Allan wrote: Hi all, A while back I wrote the attached code to demonstrate how to use events and serial console to create a serial console that stays up even when the VM is down.

Re: [libvirt] Syntax check rules broken if 'exclude' is not defined

2012-03-29 Thread Eric Blake
On 03/29/2012 07:17 AM, Daniel P. Berrange wrote: I noticed that many (most) of the libvirt syntax-check rules were not generating any results, despite me introducing obvious violations. From my debugging the problem appears to be caused by this commit: commit

[libvirt] [PATCH] build: avoid 'devname' for BSD

2012-03-29 Thread Eric Blake
Commit 21b5daa1 was the last time we cleaned this up. * tools/virt-host-validate-common.c (virHostValidateDevice): Rename local variable. --- Pushing under the build-breaker rule. I considered adding a syntax-check rule to catch this, but we use 'devname' in enough other places where the name

[libvirt] [PATCH] build: silence recent syntax check violations

2012-03-29 Thread Eric Blake
An upstream gnulib bug meant that some of our syntax checks weren't being run. Fix up our offenders before we upgrade to a newer gnulib. * src/util/virnetdevtap.c (virNetDevTapCreate): Use flags. * tests/lxcxml2xmltest.c (mymain): Strip useless (). --- The gnulib bug was here: