Re: [libvirt] [test-API PATCH 2/3] repo: Add test for mutualy exclusive console access

2012-04-04 Thread Guannan Ren
On 04/03/2012 09:20 PM, Peter Krempa wrote: This test case checks if the console connection code works in a safe way that the connection don't get messed up. --- repos/domain/console_mutex.py | 89 + 1 files changed, 89 insertions(+), 0 deletions(-)

Re: [libvirt] sysctl variables, FreeBSD

2012-04-04 Thread Jason Helfman
On Tue, Mar 20, 2012 at 10:46:16AM +, Daniel P. Berrange thus spake: On Mon, Mar 19, 2012 at 10:19:55PM -0700, Jason Helfman wrote: Is there a method that can be used to remove the sysctl tuning for FreeBSD in the pipeline? Here are the current patches I have, but would like to remove:

Re: [libvirt] [test-API PATCH 3/3] repo: Add test for console input and output operations

2012-04-04 Thread Guannan Ren
On 04/03/2012 09:20 PM, Peter Krempa wrote: This test checks if the console input and output work as desired. The test takes as an argument a string, that is sent to the console and another string that is expected to be read from the console. When those two compare successfuly the test succeeds.

Re: [libvirt] question on API spelling

2012-04-04 Thread Daniel P. Berrange
On Tue, Apr 03, 2012 at 03:41:12PM -0600, Eric Blake wrote: On 04/03/2012 03:10 AM, Martin Kletzander wrote: On 04/03/2012 01:05 AM, Eric Blake wrote: We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in our public API: include/libvirt/libvirt.h.in:124:

Re: [libvirt] [PATCH 2/8] Remove API XML files from libvirt RPM

2012-04-04 Thread Daniel P. Berrange
On Tue, Apr 03, 2012 at 09:01:40PM -0600, Eric Blake wrote: On 04/03/2012 06:48 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The API XML files are now formally installed as part of the libvirt-devel RPM. indirectly, since libvirt-devel pulls in

Re: [libvirt] [PATCH 8/8] Restart daemon at end of transaction

2012-04-04 Thread Daniel P. Berrange
On Tue, Apr 03, 2012 at 10:06:05PM -0600, Eric Blake wrote: On 04/03/2012 06:48 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com It is not safe to restart libvirtd after install of the libvirt-daemon RPM, since the corresponding driver modules may not yet have

Re: [libvirt] sysctl variables, FreeBSD

2012-04-04 Thread Daniel P. Berrange
On Tue, Apr 03, 2012 at 11:29:37PM -0700, Jason Helfman wrote: On Tue, Mar 20, 2012 at 10:46:16AM +, Daniel P. Berrange thus spake: On Mon, Mar 19, 2012 at 10:19:55PM -0700, Jason Helfman wrote: Is there a method that can be used to remove the sysctl tuning for FreeBSD in the pipeline?

Re: [libvirt] [PATCH] news.html.in: Fix /br void tag

2012-04-04 Thread Michal Privoznik
On 03.04.2012 17:38, Daniel P. Berrange wrote: On Tue, Apr 03, 2012 at 09:33:43AM -0600, Eric Blake wrote: On 04/03/2012 09:25 AM, Michal Privoznik wrote: Void elements should be written with slash *after* the tag name, not before, so they are not confused with ending tags. --- Pushing

Re: [libvirt] [PATCH] news.html.in: Fix /br void tag

2012-04-04 Thread Daniel P. Berrange
On Wed, Apr 04, 2012 at 10:29:17AM +0200, Michal Privoznik wrote: On 03.04.2012 17:38, Daniel P. Berrange wrote: On Tue, Apr 03, 2012 at 09:33:43AM -0600, Eric Blake wrote: On 04/03/2012 09:25 AM, Michal Privoznik wrote: Void elements should be written with slash *after* the tag name, not

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.11

2012-04-04 Thread Justin Clift
On 04/04/2012, at 3:28 PM, Jason Helfman wrote: On 03/04/2012, at 6:07 PM, Daniel Veillard wrote: So as stated last week I made the release today. It is available from the ftp: ftp://libvirt.org/libvirt/libvirt-0.9.11.tar.gz The OSX version is now available through Homebrew too. :) +

Re: [libvirt] question on API spelling

2012-04-04 Thread Daniel Veillard
On Wed, Apr 04, 2012 at 09:06:27AM +0100, Daniel P. Berrange wrote: On Tue, Apr 03, 2012 at 03:41:12PM -0600, Eric Blake wrote: On 04/03/2012 03:10 AM, Martin Kletzander wrote: On 04/03/2012 01:05 AM, Eric Blake wrote: Do either of the Dan's have a strong opinion? And if the consensus is

[libvirt] [PATCH] Don't install sysctl file on non-Linux hosts

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * configure.ac: Set WITH_SYSCTL only on Linux hosts * daemon/Makefile.am: Conditionalize install-sysctl using WITH_SYSCTL Signed-off-by: Daniel P. Berrange berra...@redhat.com Cc: Jason Helfman jhelf...@e-e.com --- configure.ac | 25

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Martin Kletzander
On 04/04/2012 07:13 AM, Guannan Ren wrote: Hi Currently, the testcase parser supports to cleanup testing environment after each testcase finished. we only need to add a flag command 'clean' after each testcase in testcase config, for example:

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Guannan Ren
On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: Hi Currently, the testcase parser supports to cleanup testing environment after each testcase finished. we only need to add a flag command 'clean' after each

Re: [libvirt] [PATCH 1/3] qemu: Don't leak temporary list of USB devices

2012-04-04 Thread Jiri Denemark
On Mon, Mar 26, 2012 at 17:39:59 +0200, Michal Privoznik wrote: and add debug message when adding USB device to the list of active devices. --- src/qemu/qemu_hostdev.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) ACK Jirka -- libvir-list mailing list

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Martin Kletzander
On 04/04/2012 01:23 PM, Guannan Ren wrote: On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: --- repos/domain/screenshot.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/repos/domain/screenshot.py

Re: [libvirt] [PATCH 2/3] qemu: Delete USB devices used by domain on stop

2012-04-04 Thread Jiri Denemark
On Mon, Mar 26, 2012 at 17:40:00 +0200, Michal Privoznik wrote: To prevent assigning one USB device to two domains, we keep a list of assigned USB devices. On domain startup - qemuProcessStart() - we insert devices used by domain into the list but remove them only on detach-device. Devices

Re: [libvirt] [PATCH 3/3] qemu: Build activeUsbHostdevs list on process reconnect

2012-04-04 Thread Jiri Denemark
On Mon, Mar 26, 2012 at 17:40:01 +0200, Michal Privoznik wrote: If the daemon is restarted it will loose list of active s/loose/lose/ USB devices assigned to active domains. Therefore we need to rebuild this list on qemuProcessReconnect(). --- src/qemu/qemu_hostdev.c | 40

Re: [libvirt] [PATCH] Don't install sysctl file on non-Linux hosts

2012-04-04 Thread Jiri Denemark
On Wed, Apr 04, 2012 at 11:17:35 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * configure.ac: Set WITH_SYSCTL only on Linux hosts * daemon/Makefile.am: Conditionalize install-sysctl using WITH_SYSCTL Signed-off-by: Daniel P. Berrange berra...@redhat.com

[libvirt] [PATCH 3/3] Fix parallel build in docs/ directory

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Every now then, with parallel builds, we get a failure to validate hvsupport.html.in. I eventually noticed that this is because we get 2 instances of the generator running at once. We already list hvsupport.html.in in BUILT_SOURCES but this was not

[libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com linuxNodeInfoCPUPopulate is not built on Mingw32 so should be in libvirt_linux.syms, not libvirt_private.syms Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/libvirt_linux.syms |3 +++ 1 files changed, 3 insertions(+), 0

[libvirt] [PATCH 2/3] Pull in GNULIB regex module for benefit of test suite on Win32

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- bootstrap.conf |1 + po/POTFILES.in |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index c6f7fd9..c6620e5 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -80,6 +80,7 @@ posix-shell

Re: [libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms

2012-04-04 Thread Daniel P. Berrange
On Wed, Apr 04, 2012 at 01:47:57PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com linuxNodeInfoCPUPopulate is not built on Mingw32 so should be in libvirt_linux.syms, not libvirt_private.syms Opps, misleading comment. For upstream, it was never in

Re: [libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms

2012-04-04 Thread Jiri Denemark
On Wed, Apr 04, 2012 at 13:47:57 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com linuxNodeInfoCPUPopulate is not built on Mingw32 so should be in libvirt_linux.syms, not libvirt_private.syms Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 2/3] Pull in GNULIB regex module for benefit of test suite on Win32

2012-04-04 Thread Jiri Denemark
On Wed, Apr 04, 2012 at 13:47:58 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- bootstrap.conf |1 + po/POTFILES.in |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index c6f7fd9..c6620e5

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Guannan Ren
On 04/04/2012 07:53 PM, Martin Kletzander wrote: On 04/04/2012 01:23 PM, Guannan Ren wrote: On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: --- repos/domain/screenshot.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

Re: [libvirt] [PATCH 3/3] Fix parallel build in docs/ directory

2012-04-04 Thread Jiri Denemark
On Wed, Apr 04, 2012 at 13:47:59 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Every now then, with parallel builds, we get a failure to validate hvsupport.html.in. I eventually noticed that this is because we get 2 instances of the generator running at

Re: [libvirt] [PATCH 0/3] qemu: Improve USB devices list handling

2012-04-04 Thread Michal Privoznik
On 03.04.2012 15:12, Michal Privoznik wrote: On 26.03.2012 17:39, Michal Privoznik wrote: This patch set fixes two bugs: https://bugzilla.redhat.com/show_bug.cgi?id=806449 https://bugzilla.redhat.com/show_bug.cgi?id=743671 tl;dr - we are only adding to the list, removing only on

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Martin Kletzander
On 04/04/2012 03:10 PM, Guannan Ren wrote: On 04/04/2012 07:53 PM, Martin Kletzander wrote: On 04/04/2012 01:23 PM, Guannan Ren wrote: On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: --- repos/domain/screenshot.py |5 + 1 files

[libvirt] Create domain using libvirt-php

2012-04-04 Thread Ali Raza Memon
Hello...! I want to create a new domain using libvirt-php, and after creating I want to start it. I have seen this to create new domain: libvirt_domain_new($conn, $name, $arch, $memMB, $maxmemMB, $vcpus, $iso_image, $disks, $networks, $flags) So in the above sysntax what should I pass in

Re: [libvirt] [test-API PATCH] Added screenshot test

2012-04-04 Thread Guannan Ren
On 04/04/2012 09:43 PM, Martin Kletzander wrote: On 04/04/2012 03:10 PM, Guannan Ren wrote: On 04/04/2012 07:53 PM, Martin Kletzander wrote: On 04/04/2012 01:23 PM, Guannan Ren wrote: On 04/04/2012 06:30 PM, Martin Kletzander wrote: On 04/04/2012 07:13 AM, Guannan Ren wrote: ---

[libvirt] [PATCH 2/4] Add API for loading daemon config from in-memory blob

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- daemon/libvirtd-config.c | 67 +++-- daemon/libvirtd-config.h |9 -- daemon/libvirtd.c|2 +- 3 files changed, 53 insertions(+), 25 deletions(-) diff --git a/daemon/libvirtd-config.c

[libvirt] [PATCH 3/4] Switch libvirtd config loading code to use error APIs

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Using VIR_ERROR means the test suite can't catch error messages easily. Use the proper error reporting APIs instead --- daemon/libvirtd-config.c | 56 - daemon/libvirtd.c|6 - 2 files

[libvirt] [PATCH 0/4] Replace daemon-conf test case

2012-04-04 Thread Daniel P. Berrange
The daemon-conf test case is terminally broken by design, despite numerous patches over the years, due to its need to test functionality indirectly by running libvirtd. Replace it with a test case which directly unit tests the code in question. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 4/4] Replace daemon-conf test script with a proper test case

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The daemon-conf test script continues to be very fragile to changes in libvirt. It currently fails 1 time in 3/4 due to race conditions in startup/shutdown of the test script. Replace it with a proper test case tailored to the code being tested *

[libvirt] [PATCH 1/4] Split libvirtd config file loading out into separate files

2012-04-04 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To enable creation of unit tests, split the libvirtd config file loading code out into separate files. * daemon/libvirtd.c: Delete config loading code / structs * daemon/libvirtd-config.c, daemon/libvirtd-config.h: Config file loading APIs

Re: [libvirt] Create domain using libvirt-php

2012-04-04 Thread Michal Novotny
Hi Ali, thanks for your e-mail, here are answers to your questions: 1) $iso_image is the location of ISO image to start installation from. This is the only supported installation source for now. 2) $disks is the array of disk settings, if you don't understand the description (array of disk

Re: [libvirt] [Libvirt-announce] Release of libvirt-0.9.11

2012-04-04 Thread Jason Helfman
On 04/04/2012, at 3:28 PM, Jason Helfman wrote: On 03/04/2012, at 6:07 PM, Daniel Veillard wrote: So as stated last week I made the release today. It is available from the ftp: ftp://libvirt.org/libvirt/libvirt-0.9.11.tar.gz The OSX version is now available through Homebrew too. :) +

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-04-04 Thread Laine Stump
On 03/29/2012 08:14 AM, Martin Kletzander wrote: So here are the things I would like to do definitely (the optional things follow later on): - fix hard-coded options into real options (e.g. commit 65449e) Forgive me if I'm suggesting things that already exist - I haven't had time to go

Re: [libvirt] [PATCH 3/3] Fix parallel build in docs/ directory

2012-04-04 Thread Eric Blake
On 04/04/2012 07:04 AM, Jiri Denemark wrote: We already list hvsupport.html.in in BUILT_SOURCES but this was not working. It turns out the flaw is that we were adding deps to the 'all:' target instead of the 'all-am:' Oh, cool. I saw this several times myself and I was wondering why it

Re: [libvirt] [PATCH 3/3] Fix parallel build in docs/ directory

2012-04-04 Thread Daniel P. Berrange
On Wed, Apr 04, 2012 at 09:17:46AM -0600, Eric Blake wrote: On 04/04/2012 07:04 AM, Jiri Denemark wrote: We already list hvsupport.html.in in BUILT_SOURCES but this was not working. It turns out the flaw is that we were adding deps to the 'all:' target instead of the 'all-am:'

Re: [libvirt] [test-API PATCH 2/3] repo: Add test for mutualy exclusive console access

2012-04-04 Thread Peter Krempa
On 04/04/2012 08:32 AM, Guannan Ren wrote: On 04/03/2012 09:20 PM, Peter Krempa wrote: This test case checks if the console connection code works in a safe way that the connection don't get messed up. --- sure about the stream, if we need to call stream.abort() in finally to close the certain

[libvirt] patch for openvz driver to support vzctl 3.1

2012-04-04 Thread Ilja Livenson
Hi, there was a recent update of vzctl from openvz, which made openvz driver crash: https://www.redhat.com/archives/libvirt-users/2012-March/msg00203.html Not sure about the correct procedure, but the patch is very simple and is shown here: https://bugzilla.redhat.com/show_bug.cgi?id=809895 .

Re: [libvirt] [PATCH] Don't install sysctl file on non-Linux hosts

2012-04-04 Thread Jason Helfman
On Wed, Apr 04, 2012 at 02:44:40PM +0200, Jiri Denemark thus spake: On Wed, Apr 04, 2012 at 11:17:35 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * configure.ac: Set WITH_SYSCTL only on Linux hosts * daemon/Makefile.am: Conditionalize install-sysctl using

Re: [libvirt] problems starting several qemu VMS simultaneously

2012-04-04 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@canonical.com): Quoting Serge Hallyn (serge.hal...@canonical.com): Quoting Wen Congyang (we...@cn.fujitsu.com): At 03/22/2012 06:54 AM, Serge Hallyn Wrote: Hi, I grabbed today's git head of libvirt. Created a VM (clean install of ubuntu

Re: [libvirt] patch for openvz driver to support vzctl 3.1

2012-04-04 Thread Eric Blake
On 04/04/2012 10:59 AM, Ilja Livenson wrote: Hi, there was a recent update of vzctl from openvz, which made openvz driver crash: https://www.redhat.com/archives/libvirt-users/2012-March/msg00203.html Not sure about the correct procedure, but the patch is very simple and is shown here:

[libvirt] ESX driver connection private data fix

2012-04-04 Thread ryan woodsmall
Hi, first time poster, my apologies if this is not the correct avenue. Since release 0.9.11, I've been getting a segfault in virsh attempting to access an ESXi 4.1 host. GDB reports it as such: ** Program received signal SIGSEGV, Segmentation fault. esxConnectToHost

[libvirt] [PATCH V2] nwfilter: Add support for ipset

2012-04-04 Thread Stefan Berger
This patch adds support for the recent ipset iptables extension to libvirt's nwfilter subsystem. Ipset allows to maintain 'sets' of IP addresses, ports and other packet parameters and allows for faster lookup (in the order of O(1) vs. O(n)) and rule evaluation to achieve higher throughput than