Re: [libvirt] [PATCH] qemu: better detection of crashed domains

2012-06-07 Thread Martin Kletzander
On 06/06/2012 05:22 PM, Eric Blake wrote: On 06/06/2012 09:03 AM, Martin Kletzander wrote: When libvirtd is started and there is an unusable/not-connectable leftover from earlier started machine, it's more reasonable to say that the machine crashed if we know it was started with -no-shutdown.

Re: [libvirt] [PATCH] command: avoid potential deadlock on handshake

2012-06-07 Thread Michal Privoznik
On 07.06.2012 01:37, Eric Blake wrote: Similar to commit 858c247, the parent process should close it's copy of the end of the pipe given to the child; otherwise, if there is an extreme bug where the parent thinks the child reported an error and is waiting for the message to go along with it,

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Martin Kletzander
On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to connect socket to

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Osier Yang
On 2012年06月07日 16:24, Martin Kletzander wrote: On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test:///default connect error: Failed to connect to the

Re: [libvirt] Looking for libvirt for RHEL 6.1 to provide Memory related metrics.

2012-06-07 Thread Xing.x.Gao
you can get the libvirt rpm package for el6.3 from here: http://veillard.com/libvirt/6.3/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] build: allow building with newer glibc-headers and -O0

2012-06-07 Thread Christophe Fergeau
Hey, On Mon, Jun 04, 2012 at 12:08:20PM -0600, Eric Blake wrote: glibc 2.15 (on Fedora 17) coupled with explicit disabling of optimization during development dies a painful death: In file included from /usr/include/limits.h:27:0, from

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Eric Blake
On 06/07/2012 02:24 AM, Martin Kletzander wrote: On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test:///default connect error: Failed to connect to

Re: [libvirt] [PATCH] build: allow building with newer glibc-headers and -O0

2012-06-07 Thread Eric Blake
On 06/07/2012 05:24 AM, Christophe Fergeau wrote: Hello, and thanks for reviewing this. This is not causing an actual issue while compiling libvirt, but __OPTIMIZE__ is not defined when using -O0, which causes a warning with -Wundef Libvirt explicitly refuses to use -Wundef (see

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Martin Kletzander
On 06/07/2012 02:22 PM, Eric Blake wrote: On 06/07/2012 02:24 AM, Martin Kletzander wrote: On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c

Re: [libvirt] [PATCH] build: allow building with newer glibc-headers and -O0

2012-06-07 Thread Christophe Fergeau
On Thu, Jun 07, 2012 at 06:25:40AM -0600, Eric Blake wrote: On 06/07/2012 05:24 AM, Christophe Fergeau wrote: Using a #ifdef would be more correct: Only if you care about -Wundef, which we don't. But I agree that if other projects are copying this trick to work around glibc's braindead

[libvirt] FLOSS Weekly podcast for libvirt is online

2012-06-07 Thread Justin Clift
Hey all, Eric Blake and Guido Gunther were on the FLOSS Weekly podcast this week, covering libvirt: http://twit.tv/show/floss-weekly/213 (also available in iTunes) Good effort guys. :) + Justin -- Aeolus Community Manager http://www.aeolusproject.org -- libvir-list mailing list

Re: [libvirt] [PATCH] build: allow building with newer glibc-headers and -O0

2012-06-07 Thread Eric Blake
On 06/07/2012 06:45 AM, Christophe Fergeau wrote: On Thu, Jun 07, 2012 at 06:25:40AM -0600, Eric Blake wrote: On 06/07/2012 05:24 AM, Christophe Fergeau wrote: Using a #ifdef would be more correct: Only if you care about -Wundef, which we don't. But I agree that if other projects are

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Jiri Denemark
On Thu, Jun 07, 2012 at 06:22:12 -0600, Eric Blake wrote: On 06/07/2012 02:24 AM, Martin Kletzander wrote: On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time

[libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-07 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a supported use case: session. --- daemon/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index

[libvirt] [PATCH] util: Fix deadlock in virLogReset

2012-06-07 Thread Jiri Denemark
When libvirtd forks off a new child, the child then calls virLogReset(), which ends up closing file descriptors used as log outputs. However, we recently started logging closed file descriptors, which means we need to lock logging mutex which was already logged by virLogReset(). We don't really

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-07 Thread Marc-André Lureau
On Thu, Jun 7, 2012 at 3:39 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: On Thu, Jun 7, 2012 at 3:31 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-07 Thread Marc-André Lureau
On Thu, Jun 7, 2012 at 3:31 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a supported use case: session. I know it may be controversial, but I give my ack anyway ;)

Re: [libvirt] [PATCH] util: Fix deadlock in virLogReset

2012-06-07 Thread Peter Krempa
On 06/07/12 15:29, Jiri Denemark wrote: When libvirtd forks off a new child, the child then calls virLogReset(), which ends up closing file descriptors used as log outputs. However, we recently started logging closed file descriptors, which means we need to lock logging mutex which was already

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-07 Thread Marc-André Lureau
On Thu, Jun 7, 2012 at 3:40 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: This binary is not admin-only at all and launching it as normal user is a supported use case: session. You may also want to move the man page from section 8 (admin) to 1. You also need to update

Re: [libvirt] [PATCH] build: allow building with newer glibc-headers and -O0

2012-06-07 Thread Christophe Fergeau
On Thu, Jun 07, 2012 at 07:24:30AM -0600, Eric Blake wrote: If the argument is that we want to make the autoconf snippet easier to copy elsewhere, then I don't mind applying a patch that uses: #if defined __OPTIMIZE__ __OPTIMIZE__ as the gate in the AH_VERBATIM block of code. That would

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Eric Blake
On 06/07/2012 06:31 AM, Martin Kletzander wrote: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to connect socket to '/run/user/eblake/libvirt/libvirt-sock': No such file or directory Odd. Looks like I have some debugging to do, then

Re: [libvirt] RFC: TODO list for a 1.0 release

2012-06-07 Thread Paolo Bonzini
Il 21/05/2012 11:27, Daniel P. Berrange ha scritto: We have mentioned a 1.0 release in passing a few times recently but we have never really set out a clear list of goals for such a notable release. This thread is an attempt to clarify such goals. To avoid making the 1.0 target too hard, we

Re: [libvirt] RFC: TODO list for a 1.0 release

2012-06-07 Thread Paolo Bonzini
Il 05/06/2012 18:53, Laine Stump ha scritto: Upstream qemu now has a setuid binary to do this for basic host bridges, but this is only a small subset of what libvirt supports, and uses file-based ACLs rather than policykit to control who is allowed to create the network devices. Oh, and

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-06-07 Thread Paolo Bonzini
Il 07/06/2012 00:45, Eric Blake ha scritto: It sounds like we need disk address structure to support more than just drive addressing, but to instead support a union of addressing based on the type='' attribute. No, we don't. The disk has a normal bus/target/unit address, like any other SCSI

Re: [libvirt] [PATCH] command: avoid potential deadlock on handshake

2012-06-07 Thread Eric Blake
On 06/07/2012 12:51 AM, Michal Privoznik wrote: On 07.06.2012 01:37, Eric Blake wrote: Similar to commit 858c247, the parent process should close it's copy of the end of the pipe given to the child; otherwise, if there is an extreme bug where the parent thinks the child reported an error and

[libvirt] [PATCH] maint: make it easier to copy FORTIFY_SOURCE snippet

2012-06-07 Thread Eric Blake
While libvirt intentionally avoids -Wundef (after all, C99 guarantees sane semantics of treating undefined macros as 0), the glibc insanity of #warning on _FORTIFY_SOURCE coupled with what some people feel is the black magic of autoconf means that other projects are likely to copy our snippet

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-07 Thread Eric Blake
On 06/07/2012 11:13 AM, Eric Blake wrote: On 06/07/2012 07:31 AM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a supported use case: session. The idea makes sense to me, but as the other

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-07 Thread Eric Blake
On 06/07/2012 07:31 AM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a supported use case: session. The idea makes sense to me, but as the other followups mentioned, you'll need a v2 that

Re: [libvirt] [PATCH] maint: make it easier to copy FORTIFY_SOURCE snippet

2012-06-07 Thread Christophe Fergeau
Thanks! On Thu, Jun 07, 2012 at 10:54:10AM -0600, Eric Blake wrote: While libvirt intentionally avoids -Wundef (after all, C99 guarantees sane semantics of treating undefined macros as 0), the glibc insanity of #warning on _FORTIFY_SOURCE coupled with what some people feel is the black magic

Re: [libvirt] [PATCH v2] virsh: add keepalive protocol in virsh

2012-06-07 Thread Eric Blake
On 06/05/2012 02:36 AM, Guannan Ren wrote: Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 add two general virsh options to support keepalive message protocol -i | --keepalive_interval interval time value (default 5 seconds) -n | --keepalive_count number of heartbeats

[libvirt] [PATCH] docs: link to FLOSS Weekly podcast

2012-06-07 Thread Eric Blake
Eric Blake and Guido Günther were guests during this week's FLOSS Weekly podcast, giving insights into libvirt as a Free Software project. * docs/relatedlinks.html.in: Add link. --- I'm not sure if I picked the best place on our web pages to stick this information, hence I'm requesting a review.

Re: [libvirt] [PATCH 1/1] Assign correct address type to spapr-vlan and spapr-vty.

2012-06-07 Thread Eric Blake
On 05/29/2012 02:35 AM, Li Zhang wrote: For pseires guest, spapr-vlan and spapr-vty is based s/pseires/pseries/ on spapr-vio address. According to model of network device, the address type should be assigned automatically. For serial device, serial pty device is recognized as spapr-vty

[libvirt] [PATCH] Fix missing ) in 2 strings

2012-06-07 Thread Cole Robinson
https://bugzilla.redhat.com/show_bug.cgi?id=801656 Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/network_conf.c |2 +- src/conf/nwfilter_conf.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index

Re: [libvirt] [PATCH] Fix missing ) in 2 strings

2012-06-07 Thread Eric Blake
On 06/07/2012 03:37 PM, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=801656 Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/network_conf.c |2 +- src/conf/nwfilter_conf.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ACK. -- Eric

Re: [libvirt] [PATCH] Fix missing ) in 2 strings

2012-06-07 Thread Cole Robinson
On 06/07/2012 05:56 PM, Eric Blake wrote: On 06/07/2012 03:37 PM, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=801656 Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/network_conf.c |2 +- src/conf/nwfilter_conf.c |2 +- 2 files changed, 2

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-06-07 Thread Li Zhang
On 06/07/2012 06:45 AM, Eric Blake wrote: On 06/04/2012 09:16 AM, Cole Robinson wrote: This isn't exactly what I had in mind when I recommended a libvirt patch. Change libvirt to add: controller type='scsi' index='0' address type='spapr-vio'/ /controller when the guest

Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-06-07 Thread Li Zhang
On 06/07/2012 11:42 PM, Paolo Bonzini wrote: Il 07/06/2012 00:45, Eric Blake ha scritto: It sounds like we needdisk address structure to support more than just drive addressing, but to instead support a union of addressing based on the type='' attribute. No, we don't. The disk has a normal

Re: [libvirt] CPU topology 'sockets' handling guest vs host

2012-06-07 Thread Doug Goldstein
On Mon, Mar 26, 2012 at 9:42 AM, Daniel P. Berrange berra...@redhat.com wrote: On my x86_64 host I have a pair of Quad core CPUs, each in a separate NUMA node. The virsh capabilities topology data reports this:  # virsh capabilities | xmllint  --xpath /capabilities/host/cpu -  cpu