On Sat, Aug 11, 2012 at 07:45:19AM +0100, Richard W.M. Jones wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=847429
Spotted by valgrind:
==2390== 45 bytes in 1 blocks are definitely lost in loss record 68 of 123
==2390==at 0x4A086DC: malloc (vg_replace_malloc.c:270)
==2390==by
Am 12.08.2012 04:48, schrieb Kevin Shanahan:
So qmp_change_blockdev uses bdrv_is_read_only() to check whether to
try and open the backing file read only, which uses the -read_only
member of struct BlockDriverState to decide whether to pass the
BDRV_O_RDRW flag to qmp_bdrv_open_encypted() and
On Mon, Aug 13, 2012 at 12:28:49AM -0500, Doug Goldstein wrote:
Fix build rules to use LDADD to add libraries to support --as-needed.
Also refactored some of the other automake variables in the same fashion
of the libvirt's automake rules.
Signed-off-by: Doug Goldstein car...@cardoe.com
---
On Fri, Aug 10, 2012 at 05:29:54PM -0400, Laine Stump wrote:
libvirt_qemu_probes.stp stopped working after switching to a build
that used --with-driver-modules. This was because the symbols listed
int libvirt_qemu_probes.stp are no longer in $(bindir)/libvirtd, but
are now in
On Sun, Aug 12, 2012 at 03:30:16PM -0500, Doug Goldstein wrote:
On Sat, Aug 11, 2012 at 4:20 PM, Peter Krempa pkre...@redhat.com wrote:
This is a second respin of the LibSSH2 transport patch series.
Annoyingly Gmail has decided to eat patch 1/4 so I've been reviewing
it on the ML archives.
On Mon, Aug 13, 2012 at 12:54:14AM -0400, Laine Stump wrote:
The following config elements now support multiple vlan subelements:
within a domain: interface, and the actual subelement of interface
within a network: the toplevel, as well as any portgroup
If multiple vlan elements are given,
Kevin Wolf kw...@redhat.com writes:
Am 12.08.2012 04:48, schrieb Kevin Shanahan:
So qmp_change_blockdev uses bdrv_is_read_only() to check whether to
try and open the backing file read only, which uses the -read_only
member of struct BlockDriverState to decide whether to pass the
BDRV_O_RDRW
Hi,
On Friday 03 August 2012 16:52:15 Gerd v. Egidy wrote:
With SysV-init libvirt-guests wrote status information to the console
during shutdown of the guests.
Since the move to systemd libvirt-guests doesn't output this progress
information anymore. This patch brings back this feature.
This is a patch for bug 826704
All sanlock resources get released when hot-dettaching a disk from the domain
because virLockManagerSanlockRelease uses the wrong function parameters/flags.
With the patch only the resources that should be released are cleaned up.
---
Am 13.08.2012 13:57, schrieb Markus Armbruster:
Kevin Wolf kw...@redhat.com writes:
Am 12.08.2012 04:48, schrieb Kevin Shanahan:
So qmp_change_blockdev uses bdrv_is_read_only() to check whether to
try and open the backing file read only, which uses the -read_only
member of struct
This series introduces a possibility to change default minimal and
maximal port numbers that are used to specify a remote display port
for both VNC and SPICE.
Because the code was a bit messy, PATCH 1/4 cleans up few things
needed to make a clean run of PATCH 2/4, that does the main change in
the
The defines QEMU_REMOTE_PORT_MIN and QEMU_REMOTE_PORT_MAX were used to
find free port when starting domains. As this was hard-coded to the
same ports as default VNC servers, there were races with these other
programs. This patch includes the possibility to change the default
starting port as well
After the cleanup of remote display port allocation, I noticed some
messages that didn't make a lot of sense the way they were written. So
I rephrased them.
---
src/qemu/qemu_process.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_process.c
This patch allows to specify a flag 'rotate' saying that the search
for next port should not be limited from the 'startPort' upwards.
This is subsequently used in the search for open SPICE TLS port when
none is specified and TLS is enabled.
---
src/qemu/qemu_process.c | 24
Port allocations for SPICE and VNC behave almost the same (with
default ports), but there is some mess in the code. This patch clears
these inconsistencies and makes sure the same behavior will be used
when ports for remote displays are changed.
Changes:
- hard-coded number 5900 removed (handled
On Aug 13, 2012, at 12:04 AM, Laine Stump wrote:
On 08/10/2012 05:44 PM, Laine Stump wrote:
How about allowing multiple vlan tag='n' [trunk='yes|no']/ at the
toplevel? Then you could have:
vlan tag='42'/
in the simplest case, or:
vlan tag='42' trunk='yes'/
if you wanted a trunk
On 08/11/2012 09:22 AM, Blue Swirl wrote:
On Sat, Aug 11, 2012 at 1:14 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote:
This patch converts all block layer close calls, that correspond
to qemu_open calls, to qemu_close.
Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com
---
v5:
-This
I'll send a new version shortly with these updates.
--
Regards,
Corey
On 08/11/2012 10:16 AM, Eric Blake wrote:
On 08/11/2012 07:14 AM, Corey Bryant wrote:
This patch adds support that enables passing of file descriptors
to the QEMU monitor where they will be stored in specified file
I'll send a new version shortly with these updates also.
--
Regards,
Corey
On 08/11/2012 10:28 AM, Eric Blake wrote:
On 08/11/2012 07:14 AM, Corey Bryant wrote:
When qemu_open is passed a filename of the /dev/fdset/nnn
format (where nnn is the fdset ID), an fd with matching access
mode flags
I'll send a new version shortly with these updates.
--
Regards,
Corey
On 08/11/2012 10:16 AM, Eric Blake wrote:
On 08/11/2012 07:14 AM, Corey Bryant wrote:
This patch adds support that enables passing of file descriptors
to the QEMU monitor where they will be stored in specified file
This is a patch for bug 826704
All sanlock resources get released when hot-dettaching a disk from the domain
because virLockManagerSanlockRelease uses the wrong function parameters/flags.
With the patch only the resources that should be released are cleaned up.
Signed-off-by: Frido Roose
On Mon, Aug 13, 2012 at 09:56:49AM -0400, Cole Robinson wrote:
I just pushed a bunch of patches to -maint branches, but both are giving me
distcheck errors that seem related to a gnulib update:
ERROR: files left in build directory after distclean:
I just pushed a bunch of patches to -maint branches, but both are giving me
distcheck errors that seem related to a gnulib update:
ERROR: files left in build directory after distclean:
./.sc-start-sc_vulnerable_makefile_CVE-2012-3386
Any hints?
I tried to reproduce on master, but it has its
On 08/13/2012 09:59 AM, Daniel P. Berrange wrote:
On Mon, Aug 13, 2012 at 09:56:49AM -0400, Cole Robinson wrote:
I just pushed a bunch of patches to -maint branches, but both are giving me
distcheck errors that seem related to a gnulib update:
ERROR: files left in build directory after
Set the close-on-exec flag for the file descriptor received
via SCM_RIGHTS.
Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com
---
v4
-This patch is new in v4 (ebl...@redhat.com)
v5
-Fallback to FD_CLOEXEC if MSG_CMSG_CLOEXEC is not available
(ebl...@redhat.com,
This patch converts all block layer open calls to qemu_open.
Note that this adds the O_CLOEXEC flag to the changed open paths
when the O_CLOEXEC macro is defined.
Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com
---
v2:
-Convert calls to qemu_open instead of file_open (kw...@redhat.com)
Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com
---
v8
-This patch is new in v8. It was reported on a prior fd passing
approach and I realized it's needed in this series.
(kw...@redhat.com)
v9-v10
-No changes
block/raw-posix.c |4 +++-
1 file changed, 3 insertions(+), 1
This patch adds support that enables passing of file descriptors
to the QEMU monitor where they will be stored in specified file
descriptor sets.
A file descriptor set can be used by a client like libvirt to
store file descriptors for the same file. This allows the
client to open a file with
Fd sets are shared by all monitor connections. Fd sets are considered
to be in use while at least one monitor is connected. When the last
monitor disconnects, all fds that are members of an fd set with no
outstanding dup references are closed. This prevents any fd leakage
associated with a
When qemu_open is passed a filename of the /dev/fdset/nnn
format (where nnn is the fdset ID), an fd with matching access
mode flags will be searched for within the specified monitor
fd set. If the fd is found, a dup of the fd will be returned
from qemu_open.
Signed-off-by: Corey Bryant
This patch converts all block layer close calls, that correspond
to qemu_open calls, to qemu_close.
Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com
---
v5:
-This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com)
v6-v9:
-No changes
v10:
-Don't use underscore prefix on functions.
libvirt's sVirt security driver provides SELinux MAC isolation for
Qemu guest processes and their corresponding image files. In other
words, sVirt uses SELinux to prevent a QEMU process from opening
files that do not belong to it.
sVirt provides this support by labeling guests and resources with
For some reason I only get this after applying subsequent upcoming
patches that touch virsh, but don't seem to actually cause the warning.
virsh.c: In function ‘vshCommandParse’:
virsh.c:2014:46: error: ‘opt_index’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
cc1: all
Similar to the previous patch, prepending 'help' to a partial
command string doesn't cut us any slack.
$ virsh help pool-define-as --name foo --type dir
error: command 'help' doesn't support option --name
This patch adds a few hacks to make 'help' ignore everything after the
first data bit, so
Often times I find myself halfway through typing a long command when
I want to see 'help' output. I instinctively append '--help' to the
command I'm typing, only to get an error:
$ virsh vol-create-as foo --help
error: command 'vol-create-as' doesn't support option --help
This patch
This just uses the existing plumping to update the guest XML to point
at the chosen snapshot disk images. It requires the VM to be inactive.
---
Reverting to a snapshot with children and then running the guest is
probably unsafe, since the backing image will change state on the child
snapshots.
On Mon, Aug 13, 2012 at 9:28 AM, Cole Robinson crobi...@redhat.com wrote:
For some reason I only get this after applying subsequent upcoming
patches that touch virsh, but don't seem to actually cause the warning.
virsh.c: In function ‘vshCommandParse’:
virsh.c:2014:46: error: ‘opt_index’ may
On Mon, Aug 13, 2012 at 4:53 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Sun, Aug 12, 2012 at 03:30:16PM -0500, Doug Goldstein wrote:
On Sat, Aug 11, 2012 at 4:20 PM, Peter Krempa pkre...@redhat.com wrote:
This is a second respin of the LibSSH2 transport patch series.
Annoyingly
On 08/12/2012 01:55 AM, Martin Kletzander wrote:
libvirt creates invalid commands if wrong locale is selected. For
example with locale that uses comma as a decimal point, JSON commands
created with decimal numbers are invalid because comma separates the
entries in JSON. Fortunately even when
On 08/13/2012 01:57 AM, Daniel P. Berrange wrote:
On Sat, Aug 11, 2012 at 07:45:19AM +0100, Richard W.M. Jones wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=847429
Spotted by valgrind:
==2390== 45 bytes in 1 blocks are definitely lost in loss record 68 of 123
==2390==by 0x5817568:
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
docs/drvparallels.html.in | 39
docs/schemas/domaincommon.rng |1 +
.../domain-parallels-vm-simple.xml | 26 +
3 files changed, 66
On 08/13/2012 03:45 AM, Daniel P. Berrange wrote:
On Mon, Aug 13, 2012 at 12:28:49AM -0500, Doug Goldstein wrote:
Fix build rules to use LDADD to add libraries to support --as-needed.
Also refactored some of the other automake variables in the same fashion
of the libvirt's automake rules.
On 08/13/2012 04:54 AM, Frido Roose wrote:
This is a patch for bug 826704
All sanlock resources get released when hot-dettaching a disk from the domain
because virLockManagerSanlockRelease uses the wrong function parameters/flags.
With the patch only the resources that should be released are
Do some cleanup of parallelsOpen, STREQ_NULLABLE can replace
a lot of checks.
Also fix error message to be VIR_ERR_INTERNAL_ERROR, the same
as in other drivers.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 17 +
1 files changed,
Let's change URI to parallels:///system. Parallels Server supports
creating VMs from non-privileged accounts, but it's not main usage
scenario and it may be forbidden in the future.
Also containers, which will be supported by the driver, can be managed
only by root, so /system path is more
libvirt creates invalid commands if wrong locale is selected. For
example with locale that uses comma as a decimal point, JSON commands
created with decimal numbers are invalid because comma separates the
entries in JSON. Fortunately even when decimal point is affected,
thousands grouping is not,
On 08/13/2012 05:51 PM, Eric Blake wrote:
Of the two alternatives, I prefer this one for now. If we ever have
need for further enhancements down the road, we can add them at that
time. No need to add code that will be unused by being more flexible
than our current needs.
I see I've sent
On Mon, Aug 13, 2012 at 10:12:01AM -0500, Doug Goldstein wrote:
On Mon, Aug 13, 2012 at 4:53 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Sun, Aug 12, 2012 at 03:30:16PM -0500, Doug Goldstein wrote:
On Sat, Aug 11, 2012 at 4:20 PM, Peter Krempa pkre...@redhat.com wrote:
This is a
On Mon, Aug 13, 2012 at 09:53:22AM -0600, Eric Blake wrote:
On 08/13/2012 01:57 AM, Daniel P. Berrange wrote:
On Sat, Aug 11, 2012 at 07:45:19AM +0100, Richard W.M. Jones wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=847429
Spotted by valgrind:
==2390== 45 bytes in 1 blocks are
On 08/13/2012 07:44 AM, Corey Bryant wrote:
I'll send a new version shortly with these updates also.
+
+ret = monitor_fdset_dup_fd_add(fdset_id, dupfd);
+if (ret == -1) {
+close(dupfd);
+return -1;
This function appears to promise a reasonable
On Mon, Aug 13, 2012 at 12:54:38PM +0200, Frido Roose wrote:
This is a patch for bug 826704
All sanlock resources get released when hot-dettaching a disk from the domain
because virLockManagerSanlockRelease uses the wrong function parameters/flags.
With the patch only the resources that should
On 08/13/2012 08:04 AM, Cole Robinson wrote:
On 08/13/2012 09:59 AM, Daniel P. Berrange wrote:
On Mon, Aug 13, 2012 at 09:56:49AM -0400, Cole Robinson wrote:
I just pushed a bunch of patches to -maint branches, but both are giving me
distcheck errors that seem related to a gnulib update:
On 08/13/2012 07:56 AM, Cole Robinson wrote:
I tried to reproduce on master, but it has its own set of issues:
IOError: [Errno 13] Permission denied:
'../../src/hyperv/hyperv_wmi.generated.h'
types_typedef = open_and_print(os.path.join(output_dirname,
esx_vi_types.generated.typedef))
On 08/13/2012 10:17 AM, Daniel P. Berrange wrote:
On Mon, Aug 13, 2012 at 12:54:38PM +0200, Frido Roose wrote:
This is a patch for bug 826704
All sanlock resources get released when hot-dettaching a disk from the domain
because virLockManagerSanlockRelease uses the wrong function
On Mon, Aug 13, 2012 at 10:23:39AM -0600, Eric Blake wrote:
On 08/13/2012 07:56 AM, Cole Robinson wrote:
I tried to reproduce on master, but it has its own set of issues:
IOError: [Errno 13] Permission denied:
'../../src/hyperv/hyperv_wmi.generated.h'
types_typedef =
On 08/13/2012 10:29 AM, Eric Blake wrote:
On 08/13/2012 10:17 AM, Daniel P. Berrange wrote:
On Mon, Aug 13, 2012 at 12:54:38PM +0200, Frido Roose wrote:
This is a patch for bug 826704
All sanlock resources get released when hot-dettaching a disk from the
domain
because
On 08/13/2012 12:16 PM, Eric Blake wrote:
On 08/13/2012 07:44 AM, Corey Bryant wrote:
I'll send a new version shortly with these updates also.
+
+ret = monitor_fdset_dup_fd_add(fdset_id, dupfd);
+if (ret == -1) {
+close(dupfd);
+return -1;
This
On 08/13/2012 10:33 AM, Corey Bryant wrote:
The only way it could fail is if we are trying to add an fd that is
already in the set, or if we don't find mon_fdset; both of which would
indicate logic bugs earlier in our program. Would it be worth asserting
that these conditions are impossible,
Otherwise distcheck can fail with:
GEN check-symfile
Can't open perl script ../../src/check-symfile.pl: No such file or directory
make[4]: *** [check-symfile] Error 2
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am
On Mon, Aug 13, 2012 at 01:13:28PM -0400, Cole Robinson wrote:
Otherwise distcheck can fail with:
GEN check-symfile
Can't open perl script ../../src/check-symfile.pl: No such file or
directory
make[4]: *** [check-symfile] Error 2
---
src/Makefile.am | 2 +-
1 file changed, 1
I pleased to announce the a new public release of libvirt-sandbox,
version 0.1.0, is now available for download
ftp://libvirt.org/libvirt/sandbox/
The packages are GPG signed with
Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R)
The libvirt-sandbox package
On 08/13/2012 10:02 AM, Martin Kletzander wrote:
libvirt creates invalid commands if wrong locale is selected. For
example with locale that uses comma as a decimal point, JSON commands
created with decimal numbers are invalid because comma separates the
entries in JSON. Fortunately even when
On 08/13/2012 01:13 PM, Eric Blake wrote:
On 08/13/2012 10:33 AM, Corey Bryant wrote:
The only way it could fail is if we are trying to add an fd that is
already in the set, or if we don't find mon_fdset; both of which would
indicate logic bugs earlier in our program. Would it be worth
On 08/13/2012 08:28 AM, Cole Robinson wrote:
Often times I find myself halfway through typing a long command when
I want to see 'help' output. I instinctively append '--help' to the
command I'm typing, only to get an error:
$ virsh vol-create-as foo --help
error: command
On 08/13/2012 08:28 AM, Cole Robinson wrote:
Similar to the previous patch, prepending 'help' to a partial
command string doesn't cut us any slack.
$ virsh help pool-define-as --name foo --type dir
error: command 'help' doesn't support option --name
This patch adds a few hacks to make
On 08/13/2012 08:08 AM, Corey Bryant wrote:
libvirt's sVirt security driver provides SELinux MAC isolation for
Qemu guest processes and their corresponding image files. In other
words, sVirt uses SELinux to prevent a QEMU process from opening
files that do not belong to it.
Corey Bryant
On 08/03/2012 08:52 AM, Gerd v. Egidy wrote:
With SysV-init libvirt-guests wrote status information to the console
during shutdown of the guests.
Since the move to systemd libvirt-guests doesn't output this progress
information anymore. This patch brings back this feature.
It is helpful
On 08/13/2012 02:02 PM, Eric Blake wrote:
On 08/13/2012 08:08 AM, Corey Bryant wrote:
libvirt's sVirt security driver provides SELinux MAC isolation for
Qemu guest processes and their corresponding image files. In other
words, sVirt uses SELinux to prevent a QEMU process from opening
files
On Mon, Aug 13, 2012 at 9:28 AM, Cole Robinson crobi...@redhat.com wrote:
Often times I find myself halfway through typing a long command when
I want to see 'help' output. I instinctively append '--help' to the
command I'm typing, only to get an error:
$ virsh vol-create-as foo --help
On Mon, Aug 13, 2012 at 9:28 AM, Cole Robinson crobi...@redhat.com wrote:
Similar to the previous patch, prepending 'help' to a partial
command string doesn't cut us any slack.
$ virsh help pool-define-as --name foo --type dir
error: command 'help' doesn't support option --name
This patch
---
configure.ac| 11 +++
libvirt.spec.in | 11 +++
src/Makefile.am | 4 ++--
src/network/bridge_driver.c | 46 +
src/util/ebtables.c | 35 ++
On 08/13/2012 01:16 PM, Daniel P. Berrange wrote:
On Mon, Aug 13, 2012 at 01:13:28PM -0400, Cole Robinson wrote:
Otherwise distcheck can fail with:
GEN check-symfile
Can't open perl script ../../src/check-symfile.pl: No such file or
directory
make[4]: *** [check-symfile] Error 2
On 08/13/2012 01:23 PM, Thomas Woerner wrote:
Subject line was a mess. You forgot a one-line summary followed by a
blank line before the actual listing of changes you made. Also, by
replying in a thread, it's not clear whether this is a new patch
unrelated to the rest of the thread, or a
On 08/13/2012 02:53 PM, Doug Goldstein wrote:
On Mon, Aug 13, 2012 at 9:28 AM, Cole Robinson crobi...@redhat.com wrote:
Similar to the previous patch, prepending 'help' to a partial
command string doesn't cut us any slack.
$ virsh help pool-define-as --name foo --type dir
error: command
On 08/13/2012 03:23 PM, Thomas Woerner wrote: ...
Thomas,
Sorry, I was on a (very long and involved) surprise phone call when you
pinged me on IRC, so our discussion was abruptly cut short, and you were
already offline by the time I got back to it.
My opinion is that it makes sense if
This is a patch for bug 847848
If registering an existing lockspace with the sanlock daemon
returns an error, libvirt should not proceed to unlink the lockspace.
Signed-off-by: Asad Saeed asad.sa...@acidseed.com
---
src/locking/lock_driver_sanlock.c |2 +-
1 files changed, 1 insertions(+), 1
On 08/13/2012 08:30 AM, Cole Robinson wrote:
This just uses the existing plumping to update the guest XML to point
at the chosen snapshot disk images. It requires the VM to be inactive.
Why limit to just offline? We already support reverting to offline
checkpoint snapshots from a running
On 08/08/2012 09:35 PM, Kyle Mestery (kmestery) wrote:
On Aug 8, 2012, at 7:06 PM, Ansis Atteka wrote:
On Wed, Aug 8, 2012 at 2:18 PM, Laine Stump la...@laine.org wrote:
On 08/08/2012 03:43 PM, Ansis Atteka wrote:
If I understand correctly, then these patch series should enable
following
libvirt 0.9.6.2 maintenance release is now available. This is
libvirt 0.9.6 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-0.9.6.2.tar.gz
Changes in this version:
* Prep for
libvirt 0.9.11.5 maintenance release is now available. This is
libvirt 0.9.11 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-0.9.11.5.tar.gz
Changes in this version:
* Prep
On 08/13/2012 02:21 PM, Asad Saeed wrote:
Subject line is a bit long (80 columns); we prefer closer to a max of
60, for use with 'git shortlog'. I changed to:
sanlock: don't unlink lockspace if registration fails
This is a patch for bug 847848
If registering an existing lockspace with the
On 08/03/2012 09:48 AM, Osier Yang wrote:
The is a preparation patch, all the files listed in _virsh_avoid_strcase
will use strcasecmp to sort the objects.
---
cfg.mk |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index e2af2bb..871e50a 100644
On 08/03/2012 09:48 AM, Osier Yang wrote:
As the consensus in:
https://www.redhat.com/archives/libvir-list/2012-July/msg01692.html,
this patch is to destroy conf/virdomainlist.[ch], foldering the
s/foldering/folding/
helpers into conf/domain_conf.[ch].
* src/Makefile.am:
- Various
On 2012年08月10日 21:20, Ján Tomko wrote:
The common code for editing files in virsh-edit.c expects EDIT_DEFINE to
return 0 on failure. virDomainSaveImageDefineXML returns 0 on success.
---
tools/virsh-domain.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On 2012年08月06日 22:57, Guido Günther wrote:
On Fri, Aug 03, 2012 at 11:48:06PM +0800, Osier Yang wrote:
This introduces a new API to list the storage pool objects,
4 groups of flags are provided to filter the returned pools:
Typo on the subject:
capital all in virStorageListALlStoragePools
On 08/10/2012 12:22 PM, Shradha Shah wrote:
Refactoring existing code without causing any functional changes to prepare
for new code.
This patch makes the code reusable.
Please make the first line of the description *much* shorter (try for
around 60 characters) and put most of the explanation
On 08/10/2012 12:23 PM, Shradha Shah wrote:
Just code movement no functional changes here. This makes the code reusable
Signed-off-by: Shradha Shah ss...@solarflare.com
---
src/network/bridge_driver.c | 86 ++
1 files changed, 53 insertions(+), 33
On 08/10/2012 12:23 PM, Shradha Shah wrote:
This patch introduces the new forward mode='hostdev' along with attribute
managed
Includes updates to the network RNG and new xml parser/formatter code.
This one still needs some tweaks. See below...
Signed-off-by: Shradha Shah
On 08/13/2012 07:27 PM, Eric Blake wrote:
On 08/13/2012 10:02 AM, Martin Kletzander wrote:
libvirt creates invalid commands if wrong locale is selected. For
example with locale that uses comma as a decimal point, JSON commands
created with decimal numbers are invalid because comma separates
On 08/10/2012 12:23 PM, Shradha Shah wrote:
The network pool should be able to keep track of both, network device
names nad PCI addresses, and return the appropriate one in the actualDevice
when networkAllocateActualDevice is called.
Signed-off-by: Shradha Shah ss...@solarflare.com
---
On 08/13/2012 11:27 PM, Laine Stump wrote:
On 08/10/2012 12:23 PM, Shradha Shah wrote:
This patch introduces the new forward mode='hostdev' along with attribute
managed
Includes updates to the network RNG and new xml parser/formatter code.
This one still needs some tweaks. See below...
On 08/10/2012 12:23 PM, Shradha Shah wrote:
Just code movement no functional changes here. This makes the code reusable
BTW - again for this patch, make the title line much shorter, e.g:
network: helper function to create interface pool from PF
Existing code that creates a list of
92 matches
Mail list logo
