Currently, in the autogen.sh script we check whether .git is an existing
directory in which case bootstrap is run. However, if libvirt is a
submodule, then the .git is just a file (with reference to the topmost
.git directory). However, our submodule routines work well. So there's
no real reason
On 19.07.2013 09:14, Michal Privoznik wrote:
Currently, in the autogen.sh script we check whether .git is an existing
directory in which case bootstrap is run. However, if libvirt is a
submodule, then the .git is just a file (with reference to the topmost
.git directory). However, our
On 07/19/2013 03:52 AM, Libaiqing wrote:
...
Then qemu reports an error:
process exited while connecting to monitor: qemu-kvm: -drive
file=iscsi://186.100.8.121:3262/iqn.2003-01.org.linux-iscsi.fedora121.x8664%3Asn.712a3704dac7,if=none,id=drive-virtio-disk0,format=raw:
Failed to parse
Currently, in the autogen.sh script we check whether .git is an existing
directory in which case bootstrap is run. However, if libvirt is a
submodule, then the .git is just a file (with reference to the topmost
.git directory). However, our submodule routines work well. So there's
no real reason
On Thu, Jul 18, 2013 at 09:43:54PM +0200, Marius Tomaschewski wrote:
Am 18.07.2013 17:02, schrieb Richard Weinberger:
Am 18.07.2013 16:50, schrieb Jim Fehlig:
Richard,
I think you should have cc'd the bug assignee when discussing this issue
upstream. Adding him now...
Oh, sorry
On Fri, Jul 19, 2013 at 07:26:09AM +0200, Michal Privoznik wrote:
On 19.07.2013 04:04, Doug Goldstein wrote:
On Thu, Jul 18, 2013 at 1:13 PM, Dave Allan dal...@redhat.com wrote:
I've seen a bunch of interest in python3 [1,2,3]. Has anybody started
thinking about python3 bindings for
On Thu, Jul 18, 2013 at 02:13:59PM -0400, Dave Allan wrote:
I've seen a bunch of interest in python3 [1,2,3]. Has anybody started
thinking about python3 bindings for libvirt?
I'm not going to do any work on it, but I have two requirements here
- We should not end up maintaining two separate
On Thu, Jul 18, 2013 at 04:19:02PM -0400, Jon Stanley wrote:
I've got a setup where a given cert (for a machine) is issued randomly
by one of three CA's, all of which are signed by a root CA.
When using this with libvirt, it will refuse to start if the cert is
signed by a CA other than the
Hi jan,
Thankyou for your reply.
I will try to hack libiscsi.
Regards,
baiqing
-Original Message-
From: Ján Tomko [mailto:jto...@redhat.com]
Sent: Friday, July 19, 2013 3:30 PM
To: Libaiqing
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] iscsi target name including colon
On 07/19/2013 01:30 AM, Michal Privoznik wrote:
Currently, in the autogen.sh script we check whether .git is an existing
directory in which case bootstrap is run. However, if libvirt is a
submodule, then the .git is just a file (with reference to the topmost
.git directory). However, our
On 07/18/2013 11:28 PM, Michal Privoznik wrote:
On 18.07.2013 17:42, Eric Blake wrote:
Makefiles are another easy file to enforce line limits.
Mostly straightforward; interesting tricks worth noting:
src/Makefile.am: $(confdir) was already defined, use it in more places
tests/Makefile.am:
On 19.07.2013 13:20, Eric Blake wrote:
On 07/19/2013 01:30 AM, Michal Privoznik wrote:
Currently, in the autogen.sh script we check whether .git is an existing
directory in which case bootstrap is run. However, if libvirt is a
submodule, then the .git is just a file (with reference to the
Upstream gnulib recently patched a bug in bootstrap, for projects
that use a different name than build-aux for a subdirectory. We
don't, but it doesn't hurt to update.
* .gnulib: Update, for bootstrap fix.
* bootstrap: Sync to upstream.
* bootstrap.conf: Match upstream bug fix.
Signed-off-by:
There are two ways to use a iSCSI LUN as disk source for qemu.
* The LUN's path as it shows up on host, e.g.
/dev/disk/by-path/ip-$ip:3260-iscsi-$iqn-fc18:iscsi.iscsi0-lun-1
* The libiscsi URI from the storage pool source element host attribute, e.g.
Make sure default iSCSI target is 3260.
---
src/storage/storage_backend_iscsi.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/storage/storage_backend_iscsi.c
b/src/storage/storage_backend_iscsi.c
index ba4f388..54bcd14 100644
---
An update to yesterday's posting:
https://www.redhat.com/archives/libvir-list/2013-July/msg01213.html
Changes in v3 over v2
* Update patch 1 per code review
* Use 'direct' instead of 'uri' and supporting documentaiton
* In patch 4, use qemuAddISCSIPoolSourceHost() instead of
From: Osier Yang jy...@redhat.com
The translation must be done before both of cgroup and security
setting, otherwise since the disk source is not translated yet,
it might be skipped on cgroup and security setting.
---
src/qemu/qemu_process.c | 13 -
1 file changed, 8 insertions(+), 5
From: Osier Yang jy...@redhat.com
virDomainDiskDefForeachPath is not only used by the security
setting helpers, also used by cgroup setting helpers, so this
is to ignore the volume type disk with mode=direct for cgroup
setting.
---
src/conf/domain_conf.c | 5 -
1 file changed, 4
The difference with already supported pool types (dir, fs, block)
is: there are two modes for iscsi pool (or network pools in future),
one can specify it either to use the volume target path (the path
showed up on host) with mode='host', or to use the remote URI qemu
supports (e.g.
Introduce a new helper to check if the disk source is of block type
---
src/conf/domain_conf.c | 32
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 5 ++---
src/qemu/qemu_conf.c | 23 +--
5
Although they produce no seclabel data, add some tests for coverage of
various network and volume disk definitions
---
tests/securityselinuxlabeldata/netdisks.txt | 5 +++
tests/securityselinuxlabeldata/netdisks.xml | 58 +
tests/securityselinuxlabeldata/voldisks.txt
On Thu, Jul 18, 2013 at 09:15:28PM -0600, Eric Blake wrote:
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of returning raw errno values, report full libvirt
errors in virCgroupNew* functions.
Signed-off-by: Daniel P. Berrange
On Fri, Jul 19, 2013 at 10:01:15AM +0100, Daniel P. Berrange wrote:
On Thu, Jul 18, 2013 at 02:13:59PM -0400, Dave Allan wrote:
I've seen a bunch of interest in python3 [1,2,3]. Has anybody started
thinking about python3 bindings for libvirt?
I'm not going to do any work on it, but I have
On Thu, Jul 18, 2013 at 05:25:56PM -0400, dwa...@redhat.com wrote:
diff --git a/libvirt.spec.in b/libvirt.spec.in
index e0e0004..34e3594 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1751,6 +1751,7 @@ fi
%config(noreplace) %{_sysconfdir}/logrotate.d/libvirtd.qemu
%endif
Am 19.07.2013 10:36, schrieb Daniel P. Berrange:
On Thu, Jul 18, 2013 at 09:43:54PM +0200, Marius Tomaschewski wrote:
Am 18.07.2013 17:02, schrieb Richard Weinberger:
Am 18.07.2013 16:50, schrieb Jim Fehlig:
Richard,
I think you should have cc'd the bug assignee when discussing this issue
---
src/libvirt_private.syms |1 +
src/util/viruuid.c | 79 ++
src/util/viruuid.h |1 +
3 files changed, 81 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 7790ede..57a1b50 100644
---
Hi,
This is a serie of patches in order to support undefining and redefining
snapshots with VirtualBox 4.2.
The serie of patches is rather big, and adds among other things some utility
functions unrelated to VirtualBox in patches 1 2.
The code review could be done in several parts: e.g. patches
---
src/libvirt_private.syms |1 +
src/util/virstring.c | 129 ++
src/util/virstring.h |6 +++
3 files changed, 136 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 57a1b50..65e85d4 100644
---
It will be needed for the futur patches because we will
redefine snapshots
---
src/conf/domain_conf.c | 20 ++-
src/vbox/vbox_tmpl.c | 426 ++--
2 files changed, 425 insertions(+), 21 deletions(-)
diff --git a/src/conf/domain_conf.c
The snapshots are saved in xml files, and then can be redefined
---
src/vbox/vbox_tmpl.c | 833 +-
1 file changed, 825 insertions(+), 8 deletions(-)
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 3dd9e8a..83cb863 100644
---
All the informations concerning snapshots (and snapshot disks)
will be deleted from the vbox xml. But the differencing disks will be
kept so you will be able to redefine the snapshots.
---
src/vbox/vbox_tmpl.c | 380 ++
1 file changed, 380
On Thu, Jul 18, 2013 at 02:13:59PM -0400, Dave Allan wrote:
I've seen a bunch of interest in python3 [1,2,3]. Has anybody started
thinking about python3 bindings for libvirt?
Dave
[1] https://fedoraproject.org/wiki/Python3
[2] https://wiki.gnome.org/GnomeGoals/Python3Porting
[3]
On Thu, Jul 18, 2013 at 09:15:28PM -0600, Eric Blake wrote:
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of returning raw errno values, report full libvirt
errors in virCgroupNew* functions.
Signed-off-by: Daniel P. Berrange
On Fri, Jul 19, 2013 at 09:58:30AM +0100, Daniel P. Berrange wrote:
On Fri, Jul 19, 2013 at 07:26:09AM +0200, Michal Privoznik wrote:
On 19.07.2013 04:04, Doug Goldstein wrote:
On Thu, Jul 18, 2013 at 1:13 PM, Dave Allan dal...@redhat.com wrote:
I've seen a bunch of interest in python3
On Thu, Jul 18, 2013 at 09:36:59PM -0600, Eric Blake wrote:
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of returning errno values, change the virCgroupKill*
APIs to fully report errors.
Signed-off-by: Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com
Add virErrorSetErrnoFromLastError and virLastErrorIsSystemErrno
to simplify code which wants to handle system errors in a more
graceful fashion.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 1 +
On Fri, Jul 19, 2013 at 03:51:25PM +0100, Daniel P. Berrange wrote:
On Thu, Jul 18, 2013 at 09:59:47PM -0600, Eric Blake wrote:
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Convert the remainiing methods in vircgroup.c to report
On Fri, Jul 19, 2013 at 09:09:40AM -0600, Eric Blake wrote:
Attempts to start a domain with both SELinux and DAC security
modules loaded will deadlock; latent problem introduced in commit
fdb3bde and exposed in commit 29fe5d7. Basically, when recursing
into the security manager for other
On Thu, Jul 18, 2013 at 09:59:47PM -0600, Eric Blake wrote:
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Convert the remainiing methods in vircgroup.c to report errors
s/remainiing/remaining/
instead of returning errno values.
On 07/19/2013 08:42 AM, Daniel P. Berrange wrote:
On Thu, Jul 18, 2013 at 09:36:59PM -0600, Eric Blake wrote:
On 07/18/2013 09:00 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of returning errno values, change the virCgroupKill*
APIs to fully report
On 07/19/2013 09:11 AM, Daniel P. Berrange wrote:
On Fri, Jul 19, 2013 at 09:09:40AM -0600, Eric Blake wrote:
Attempts to start a domain with both SELinux and DAC security
modules loaded will deadlock; latent problem introduced in commit
fdb3bde and exposed in commit 29fe5d7. Basically, when
On 07/19/2013 08:51 AM, Daniel P. Berrange wrote:
+if (virCgroupSetValueU64(group,
+ VIR_CGROUP_CONTROLLER_MEMORY,
+ filename, 1) 0)
return -1;
-}
return 0;
Can code like this be simplified to:
return
On 07/19/2013 08:34 AM, Daniel P. Berrange wrote:
Overall, looks like a decent improvement. I pointed out a few things
worth cleaning up, and the idea of splitting into two patches may have
merit. It may be faster to post the changes you will squash in than a
full-blown v2, considering the
On 07/19/2013 08:14 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Add virErrorSetErrnoFromLastError and virLastErrorIsSystemErrno
to simplify code which wants to handle system errors in a more
graceful fashion.
Signed-off-by: Daniel P. Berrange
On Fri, Jul 19, 2013 at 11:48:56PM +0800, Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
Hi, Denial
thanks your reply.
Daniel P. Berrange 2013-7-19 下午 23:53
On Fri, Jul 19, 2013 at 11:48:56PM +0800, Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was
Attempts to start a domain with both SELinux and DAC security
modules loaded will deadlock; latent problem introduced in commit
fdb3bde and exposed in commit 29fe5d7. Basically, when recursing
into the security manager for other driver's prefork, we have to
undo the asymmetric lock taken at the
---
src/conf/domain_conf.c | 11 ---
src/conf/domain_conf.h | 3 ++-
src/qemu/qemu_process.c | 2 +-
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 57cd9b1..308a96b 100644
--- a/src/conf/domain_conf.c
+++
Make virStringArrayHasString return false when called on a non-existent
string array.
---
src/util/virstring.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virstring.c b/src/util/virstring.c
index 1f4850e..d11db5c 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@
Jiri Denemark (3):
cpu_x86: Use x86-specific CPU data structure
Replace union cpuData with virCPUData
cpu: Store arch in virCPUData
src/cpu/cpu.c| 31 +++--
src/cpu/cpu.h| 62 -
src/cpu/cpu_arm.c| 8 +-
src/cpu/cpu_powerpc.c|
In case libvirtd is asked to unplug a device but the device is actually
unplugged later when libvirtd is not running, we need to detect that and
remove such device when libvirtd starts again and reconnects to running
domains.
Jiri Denemark (4):
util: Non-existent string array does not contain
---
src/cpu/cpu.c| 22 +--
src/cpu/cpu.h| 51 ++--
src/cpu/cpu_arm.c| 8 +++
src/cpu/cpu_powerpc.c| 8 +++
src/cpu/cpu_s390.c | 8 +++
src/cpu/cpu_x86.c
On 07/19/2013 11:31 AM, Daniel P. Berrange wrote:
Still incomplete - you fixed virCgroupAddTask callers, but didn't audit
for others. At least in this file, we have:
Sigh, you're right. I clearly forgot to change any of the callers.
@@ -584,14 +584,12 @@ static int
This API provides a NULL-terminated list of devices which are currently
attached to a QEMU domain.
---
src/qemu/qemu_monitor.c | 21 +++
src/qemu/qemu_monitor.h | 4 +++
src/qemu/qemu_monitor_json.c | 38 +++
src/qemu/qemu_monitor_json.h | 4 +++
In case libvirtd is asked to unplug a device but the device is actually
unplugged later when libvirtd is not running, we need to detect that and
remove such device when libvirtd starts again and reconnects to running
domains.
---
src/qemu/qemu_domain.c | 56
---
src/cpu/cpu.h | 2 +-
src/cpu/cpu_x86.c | 271 ++
2 files changed, 173 insertions(+), 100 deletions(-)
diff --git a/src/cpu/cpu.h b/src/cpu/cpu.h
index cba7149..b2c02db 100644
--- a/src/cpu/cpu.h
+++ b/src/cpu/cpu.h
@@ -33,7 +33,7 @@
---
src/cpu/cpu.c| 11 +--
src/cpu/cpu.h| 19 +++
src/cpu/cpu_powerpc.c| 4 ++--
src/cpu/cpu_x86.c| 34 --
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_command.c | 5 ++---
On 07/19/2013 08:54 AM, Daniel P. Berrange wrote:
rc = virCgroupAddTask(cgroup_vcpu, priv-vcpupids[i]);
if (rc 0) {
virReportSystemError(-rc,
_(unable to add vcpu %zu task %d to
cgroup),
i,
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
---
Changes since V2:
1), forbid parallel configure because libxl do not
On Fri, Jul 19, 2013 at 5:02 AM, Daniel P. Berrange berra...@redhat.com wrote:
This is a known limitation that I'm working on fixing. It is not quite
as simple as just replacing the method call, because it has ripple effects
into other areas of code, and also neeeds to have some significant
Two CVEs have been assigned for recent patches both related to 'virsh
vcpucount'. I have backported these patches to v1.1.0-maint (the only
release impacted by either bug).
CVE-2013-4153 was introduced by commit v1.0.6-48-gc6afcb0, and could
allow a read-only client to cause a double free in
61 matches
Mail list logo
