Re: [libvirt] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-11 Thread Eduardo Habkost
On Mon, Feb 10, 2014 at 11:39:51PM +0100, Andreas Färber wrote: Am 10.02.2014 11:21, schrieb Eduardo Habkost: +static const TypeInfo x86_cpu_host_type_info = { +.name = CPU_CLASS_NAME(host), +.parent = TYPE_X86_CPU, +.instance_size = sizeof(X86CPU), +.instance_init =

Re: [libvirt] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 23:39, Andreas Färber ha scritto: I'd rather finish my investigations and discuss my v10 patches but Paolo is already asking whether Eduardo should send a PULL, so here's my textual reply informing of some thoughts and WIP. ;) Don't worry, :) I was asking you if you are fine with

[libvirt] libvirt default network

2014-02-11 Thread Thierry Parmentelat
Hi This is in echo to a message originally sent on libvirt-users, but having not received any answer yet so we figured we would try this list instead So, we use libvirt on various flavours of fedora; with fedora18 we were using libvirt-1.0.4, that we rebuilt using a slightly modified version

Re: [libvirt] [PATCH v3 1/2] network: Introduce network hooks

2014-02-11 Thread Daniel P. Berrange
On Mon, Feb 10, 2014 at 07:52:34PM +0100, Michal Privoznik wrote: @@ -3583,6 +3639,48 @@ validate: } } +/* finally we can call the 'plugged' hook script if any */ +if (virHookPresent(VIR_HOOK_DRIVER_NETWORK)) { +/* the XML construction is a bit complicated

Re: [libvirt] libvirt default network

2014-02-11 Thread Thierry Parmentelat
Hi again answering my own post, I think I figured it out, as a missing dependency between . libvirt-daemon-driver-network that provides /usr/share/libvirt/networks/default.xml . and libvirt-daemon-config-network, shose post-install script actually uses this same file So this means that

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-11 Thread Stefan Hajnoczi
On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Project ideas Please post project ideas on the wiki page below. Project ideas should be suitable as a 12-week project that a student fluent in C/Python/etc can complete. No prior knowledge of QEMU/KVM/libvirt

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-11 Thread Martin Kletzander
On Tue, Feb 11, 2014 at 11:10:16AM +0800, Osier Yang wrote: On 11/02/14 00:48, Eric Blake wrote: On 02/10/2014 06:35 AM, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt:

Re: [libvirt] libvirt default network

2014-02-11 Thread Laine Stump
On 02/11/2014 10:28 AM, Thierry Parmentelat wrote: Hi This is in echo to a message originally sent on libvirt-users, but having not received any answer yet so we figured we would try this list instead For this question, either list is appropriate, it's just that nobody has gotten around to

Re: [libvirt] [PATCH] qemu driver: sync guest time via qemu-guest-agent when domain is resumed

2014-02-11 Thread Michal Privoznik
On 11.02.2014 01:04, Marcelo Tosatti wrote: On Mon, Feb 10, 2014 at 03:42:45PM -0700, Eric Blake wrote: On 02/10/2014 03:10 PM, Marcelo Tosatti wrote: Since QEMU commit kvmclock: clock should count only if vm is running (http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01225.html),

Re: [libvirt] [PATCH 0/2] Taint domains altered by hook scripts

2014-02-11 Thread Michal Privoznik
On 04.02.2014 16:49, Michal Privoznik wrote: Currently, we only allow XML changing in qemu driver and nowhere else. Michal Privoznik (2): virDomainTaintFlags: Introduce VIR_DOMAIN_TAINT_HOOK qemu: Implement VIR_DOMAIN_TAINT_HOOK src/conf/domain_conf.c| 3 ++-

Re: [libvirt] [Qemu-devel] [PATCH 2/5] introduce two marcos to dump the options info

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: We will use the marocs to generate two tables, which contain the option name and argument information. Signed-off-by: Amos Kong ak...@redhat.com --- qemu-options-wrapper.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [libvirt] [PATCH v3 0/4] Introduce spiceport chardev backend

2014-02-11 Thread Christophe Fergeau
Series still looks good to me, ACK. On Mon, Feb 10, 2014 at 03:03:03PM +0100, Martin Kletzander wrote: BLURB/ Martin Kletzander (4): conf: introduce spiceport chardev backend qemu: rework '-serial none' qemu: remove pointless condition qemu: introduce spiceport chardev backend

Re: [libvirt] [PATCH v3 3/4] qemu: remove pointless condition

2014-02-11 Thread Christophe Fergeau
On Mon, Feb 10, 2014 at 03:03:06PM +0100, Martin Kletzander wrote: This patch is here just to ease the code review and make related changes look more sensible. Hehe this description actually made things not as easy as they could have ;) I would have specifically mentioned that if (def-nserials)

Re: [libvirt] libvirt default network

2014-02-11 Thread Thierry Parmentelat
Hello Laine; please see inline — many thanks for the feedback in any case — Thierry On 11 Feb 2014, at 11:48, Laine Stump la...@laine.org wrote: On 02/11/2014 10:28 AM, Thierry Parmentelat wrote: Hi This is in echo to a message originally sent on libvirt-users, but having not received

Re: [libvirt] [PATCH v7 1/2] bhyve: add a basic driver

2014-02-11 Thread Daniel P. Berrange
On Sun, Feb 09, 2014 at 06:46:12PM +0400, Roman Bogorodskiy wrote: +static int +bhyveBuildDiskArgStr(const virDomainDef *def, virCommandPtr cmd) +{ +virDomainDiskDefPtr disk; + +if (def-ndisks != 1) { +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, %s, +

Re: [libvirt] [PATCH v7 2/2] bhyve: add ACL support

2014-02-11 Thread Daniel P. Berrange
On Sun, Feb 09, 2014 at 06:46:13PM +0400, Roman Bogorodskiy wrote: --- src/Makefile.am | 5 ++-- src/bhyve/bhyve_driver.c | 63 2 files changed, 61 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am

Re: [libvirt] [PATCH V5] Sheepdog: Adding volume and on pool and refresh.

2014-02-11 Thread Daniel P. Berrange
On Fri, Feb 07, 2014 at 12:45:42PM +0100, joel SIMOES wrote: +static int +virStorageBackendSheepdogAddVolume(virConnectPtr conn ATTRIBUTE_UNUSED, + virStoragePoolObjPtr pool, const char *diskInfo) +{ +virStorageVolDefPtr vol = NULL; + +if

Re: [libvirt] libvirt default network

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 12:13:49PM +0100, Thierry Parmentelat wrote: Hello Laine; please see inline — many thanks for the feedback in any case — Thierry 4) Even if you are installing/upgrading libvirt-daemon-config-network and the system doesn't already have a default network in place,

Re: [libvirt] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Fri, Feb 07, 2014 at 11:55:25AM +0100, Paolo Bonzini wrote: Il 07/02/2014 11:16, Eduardo Habkost ha scritto: You are not alone. I remember we spent lots of time trying to convince Anthony to allow global properties and compat_props affect dynamic properties not just static properties, and

Re: [libvirt] [Qemu-devel] [PATCH 3/5] query-command-line-options: query all the options in qemu-options.hx

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: vm_config_groups[] contain the options which have parameter, but some legcy options haven't been added to vm_config_groups[]. All the options can be found in qemu-options.hx, this patch used two new marcos to generate two tables, we can check if the option

Re: [libvirt] [Qemu-devel] [PATCH 4/5] introduce QEMU_OPTIONS_GENERATE_HELPMSG

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: This patch introduced a new maroc, it will be used to dump the help messages of all the options. macro. Also misspelled in PATCH 2/5. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/2] lxc: Add virCgroupSetOwner()

2014-02-11 Thread Daniel P. Berrange
On Sat, Feb 08, 2014 at 06:37:43PM +0100, Richard Weinberger wrote: Add a new helper function to change the permissions of a control group. Signed-off-by: Richard Weinberger rich...@nod.at --- src/lxc/lxc_controller.c | 7 +++ src/util/vircgroup.c | 43

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-02-11 Thread Daniel P. Berrange
On Thu, Jan 30, 2014 at 03:19:11PM +0100, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit from the new RBD format. Older versions of libvirt can work with this new RBD

Re: [libvirt] [Qemu-devel] [PATCH 5/5] query-command-line-options: return help message for legacy options

2014-02-11 Thread Markus Armbruster
[Note cc: Eric] Amos Kong ak...@redhat.com writes: Some legacy options that have arguments weren't added to vm_config_groups[], so query-command-line-options returns a NULL parameters infolist. This patch try to return help message for this kind of legacy options. Example: {

Re: [libvirt] [PATCH 0/3] libxl: misc trivial cleanups

2014-02-11 Thread Michal Privoznik
On 07.02.2014 02:21, Jim Fehlig wrote: A few trivial patches for things I noticed while working on my upcoming patches that add job support in the libxl driver. Jim Fehlig (3): libxl: rename libxlCreateDomEvents to libxlDomEventsRegister libxl: register for domain events immediately after

Re: [libvirt] [PATCH v3 3/4] qemu: remove pointless condition

2014-02-11 Thread Martin Kletzander
On Tue, Feb 11, 2014 at 12:13:43PM +0100, Christophe Fergeau wrote: On Mon, Feb 10, 2014 at 03:03:06PM +0100, Martin Kletzander wrote: This patch is here just to ease the code review and make related changes look more sensible. Hehe this description actually made things not as easy as they

Re: [libvirt] [PATCH v3 0/4] Introduce spiceport chardev backend

2014-02-11 Thread Martin Kletzander
On Tue, Feb 11, 2014 at 12:13:54PM +0100, Christophe Fergeau wrote: Series still looks good to me, ACK. Thanks for the review, pushed now. Martin On Mon, Feb 10, 2014 at 03:03:03PM +0100, Martin Kletzander wrote: BLURB/ Martin Kletzander (4): conf: introduce spiceport chardev

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-11 Thread Osier Yang
On 11/02/14 18:21, Martin Kletzander wrote: On Tue, Feb 11, 2014 at 11:10:16AM +0800, Osier Yang wrote: On 11/02/14 00:48, Eric Blake wrote: On 02/10/2014 06:35 AM, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1)

Re: [libvirt] [PATCHv4 1/7] storage: gluster: Set volume metadata in a separate function

2014-02-11 Thread Peter Krempa
On 02/07/14 00:23, Eric Blake wrote: On 02/03/2014 09:54 AM, Peter Krempa wrote: Extract the metadata setting code into a separate function for future use. --- src/storage/storage_backend_gluster.c | 66 --- 1 file changed, 46 insertions(+), 20 deletions(-)

Re: [libvirt] [PATCH V5] Sheepdog: Adding volume and on pool and refresh.

2014-02-11 Thread Joel Simoes
Thx Le 11/02/2014 12:33, Daniel P. Berrange a écrit : On Fri, Feb 07, 2014 at 12:45:42PM +0100, joel SIMOES wrote: +static int +virStorageBackendSheepdogAddVolume(virConnectPtr conn ATTRIBUTE_UNUSED, + virStoragePoolObjPtr pool, const char *diskInfo) +{ +

Re: [libvirt] [PATCHv4 3/7] storage: Implement file storage APIs in the default storage driver

2014-02-11 Thread Peter Krempa
On 02/10/14 23:09, Eric Blake wrote: On 02/03/2014 09:54 AM, Peter Krempa wrote: Implement the APIs added by the previous patch in the default storage driver used by qemu. --- src/check-aclrules.pl | 1 + src/storage/storage_backend.c | 37 ++

Re: [libvirt] [PATCH 1/3] libxl: rename libxlCreateDomEvents to libxlDomEventsRegister

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 06:21:41PM -0700, Jim Fehlig wrote: libxlDomEventsRegister better reflects its purpose: register for domain events from libxl. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [libvirt] [PATCH 3/3] libxl: fix libxlDoDomainSave documentation

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 06:21:43PM -0700, Jim Fehlig wrote: Update the function's comment, which was missed when removing use of the driver lock everywhere. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH 2/3] libxl: register for domain events immediately after creation

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 06:21:42PM -0700, Jim Fehlig wrote: A small fix for the possiblitiy of jumping to an error path before registering for domain events, preventing receiving important ones like shutdown and death. Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH 01/11] libxl: Add job support to libxl driver

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:05PM -0700, Jim Fehlig wrote: Follows the pattern used in the QEMU driver for managing multiple, simultaneous jobs within the driver. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 128

Re: [libvirt] [PATCH 02/11] libxl: use job functions in libxlVmStart

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:06PM -0700, Jim Fehlig wrote: Creating a large domain could potentially be time consuming. Use the recently added job functions and unlock the virDomainObj while the create operation is in progress. Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH 03/11] libxl: use job functions in libxlDomainSetMemoryFlags

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:07PM -0700, Jim Fehlig wrote: Large balloon operation can be time consuming. Use the recently added job functions and unlock the virDomainObj while ballooning. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 32

Re: [libvirt] [PATCH 04/11] libxl: use job functions in libxlDomain{Suspend, Resume}

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:08PM -0700, Jim Fehlig wrote: These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 24 ++-- 1 file changed, 18

Re: [libvirt] [PATCH 05/11] libxl: use job functions in libxlDomainDestroyFlags

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:09PM -0700, Jim Fehlig wrote: Modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git

Re: [libvirt] [PATCH 06/11] libxl: use job functions in domain save operations

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:10PM -0700, Jim Fehlig wrote: Saving domain memory and cpu state can take considerable time. Use the recently added job functions and unlock the virDomainObj while saving the domain. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 54

Re: [libvirt] [PATCH 08/11] libxl: use job functions in vcpu set and pin functions

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:12PM -0700, Jim Fehlig wrote: These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 46 +- 1 file

Re: [libvirt] [PATCH 07/11] libxl: use job functions in libxlDomainCoreDump

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:11PM -0700, Jim Fehlig wrote: Dumping a domain's core can take considerable time. Use the recently added job functions and unlock the virDomainObj while dumping core. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 37

Re: [libvirt] [PATCH 11/11] libxl: use job functions in libxlDomainSetSchedulerParametersFlags

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:15PM -0700, Jim Fehlig wrote: Modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) ACK Daniel -- |:

Re: [libvirt] [PATCH 09/11] libxl: use job functions in device attach and detach functions

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:13PM -0700, Jim Fehlig wrote: These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 40 ++-- 1 file

Re: [libvirt] [PATCH 10/11] libxl: use job functions in libxlDomainSetAutostart

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 08:53:14PM -0700, Jim Fehlig wrote: Setting autostart is a modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 18 -- 1 file changed, 12 insertions(+), 6

Re: [libvirt] [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Anthony Liguori
On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/02/2014 11:16, Eduardo Habkost ha scritto: You are not alone. I remember we spent lots of time trying to convince Anthony to allow global properties and compat_props affect dynamic properties not just static

Re: [libvirt] [PATCH v2 1/2] Handle non-sequential NUMA node numbers

2014-02-11 Thread Daniel P. Berrange
On Sat, Feb 08, 2014 at 12:21:39PM +0530, Pradipta Kr. Banerjee wrote: On some platforms like IBM PowerNV the NUMA node numbers can be non-sequential. For eg. numactl --hardware o/p from such a machine looks as given below node distances: node 0 1 16 17 0: 10 40 40 40

Re: [libvirt] [PATCH 09/11] libxl: use job functions in device attach and detach functions

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 40 ++-- 1 file changed, 26 insertions(+), 14

Re: [libvirt] [PATCH v2 2/2] vircapstest: Introduce virCapabilitiesGetCpusForNodemask test

2014-02-11 Thread Daniel P. Berrange
On Sat, Feb 08, 2014 at 12:21:40PM +0530, Pradipta Kr. Banerjee wrote: This test creates a Fake NUMA topology with non-sequential cell ids to check if libvirt properly handles the same Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com Signed-off-by: Pradipta Kr. Banerjee

Re: [libvirt] [PATCH 06/11] libxl: use job functions in domain save operations

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Saving domain memory and cpu state can take considerable time. Use the recently added job functions and unlock the virDomainObj while saving the domain. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 54

Re: [libvirt] [PATCH 04/11] libxl: use job functions in libxlDomain{Suspend, Resume}

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-)

Re: [libvirt] [PATCH 07/11] libxl: use job functions in libxlDomainCoreDump

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Dumping a domain's core can take considerable time. Use the recently added job functions and unlock the virDomainObj while dumping core. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 37 ++---

Re: [libvirt] [PATCH 03/11] libxl: use job functions in libxlDomainSetMemoryFlags

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Large balloon operation can be time consuming. Use the recently added job functions and unlock the virDomainObj while ballooning. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 32 ++-- 1 file

Re: [libvirt] [PATCH 11/11] libxl: use job functions in libxlDomainSetSchedulerParametersFlags

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c

Re: [libvirt] [PATCH 05/11] libxl: use job functions in libxlDomainDestroyFlags

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_driver.c

Re: [libvirt] [PATCH 10/11] libxl: use job functions in libxlDomainSetAutostart

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Setting autostart is a modify operation that needs to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

Re: [libvirt] [PATCH 01/11] libxl: Add job support to libxl driver

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Follows the pattern used in the QEMU driver for managing multiple, simultaneous jobs within the driver. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 128 +++

Re: [libvirt] [PATCH 00/11] libxl: add job support

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: This patch series adds job support to the libxl driver, using techiques from the qemu driver. One benefit is no longer blocking get operations during long running modify operations. E.g. with these patches 'vish dominfo dom' will work while 'virsh save

Re: [libvirt] [PATCH 02/11] libxl: use job functions in libxlVmStart

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: Creating a large domain could potentially be time consuming. Use the recently added job functions and unlock the virDomainObj while the create operation is in progress. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 59

Re: [libvirt] [PATCH 08/11] libxl: use job functions in vcpu set and pin functions

2014-02-11 Thread Michal Privoznik
On 07.02.2014 04:53, Jim Fehlig wrote: These operations aren't necessarily time consuming, but need to wait in the queue of modify jobs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 46 +- 1 file changed, 29

Re: [libvirt] [PATCH 00/11] libxl: add job support

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 03:36:15PM +0100, Michal Privoznik wrote: On 07.02.2014 04:53, Jim Fehlig wrote: This patch series adds job support to the libxl driver, using techiques from the qemu driver. One benefit is no longer blocking get operations during long running modify operations. E.g.

Re: [libvirt] [PATCH] add option to enforce minimal pagesize for hugetlbfs backed guests

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 11:48:51AM -0500, Marcelo Tosatti wrote: Require a minimal pagesize for hugetlbfs backed guests. Fail guest initialization if hugetlbfs mount is configured with smaller page size. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com +#ifdef __linux__ +

Re: [libvirt] [PATCH v3 21/21] blkiotune: allow node major='' minor=''/ in place of path

2014-02-11 Thread Daniel P. Berrange
On Wed, Feb 05, 2014 at 03:10:19PM +0100, Cédric Bosdonnat wrote: To ease LXC configuration conversion, allow blkiotune device XML fragments to define the device using its major:minor numbers. --- docs/formatdomain.html.in | 10 +- src/conf/domain_conf.c

Re: [libvirt] [PATCH 1/6] qemu: new API for tracking arbitrary monitor events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:06PM -0700, Eric Blake wrote: Several times in the past, qemu has implemented a new event, but libvirt has not yet caught up to reporting that event to the user applications. While it is possible to track libvirt logs to see that an unknown event was received and

Re: [libvirt] [PATCH 2/6] qemu: virsh wrapper for qemu events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:07PM -0700, Eric Blake wrote: Any new API deserves a good virsh wrapper :) qemu-monitor-event [domain] [event] [--pretty] [--loop] [--timeout number] It helps that we already have an event loop running in a dedicated thread, so a blocking read() on a

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote: Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by event name is saved for a later patch. * src/conf/domain_event.c

Re: [libvirt] [PATCH 4/6] qemu: wire up RPC for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:09PM -0700, Eric Blake wrote: These are the first async events in the qemu protocol, so this patch looks rather big compared to most RPC additions. However, a large majority of this patch is just mechanical copy-and-paste from recently-added network events. It

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 03:08:46PM +, Daniel P. Berrange wrote: On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote: Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote: Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by event name is saved for a later patch. * src/conf/domain_event.c

Re: [libvirt] [PATCH 5/6] qemu: enable monitor event reporting

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:10PM -0700, Eric Blake wrote: Wire up all the pieces to send arbitrary qemu events to a client using libvirt-qemu.so. If the extra bookkeeping of generating event objects even when no one is listening turns out to be noticeable, we can try to further optimize

Re: [libvirt] [PATCH 6/6] qemu: enable monitor event filtering by name

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:11PM -0700, Eric Blake wrote: Filtering monitor events by name requires tracking the name for the duration of the filtering. In order to free the name, I found it easiest to just piggyback on the user's freecb function, which gets called when the event is

Re: [libvirt] [PATCH 7/6] qemu: allow filtering events by regex

2014-02-11 Thread Daniel P. Berrange
On Thu, Feb 06, 2014 at 04:19:53PM -0700, Eric Blake wrote: When listening for a subset of monitor events, it can be tedious to register for each event name in series; nicer is to register for multiple events in one go. Implement a flag to use regex interpretation of the event filter.

Re: [libvirt] [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/02/2014 11:16, Eduardo Habkost ha scritto: You are not alone. I remember we spent lots of time trying to convince Anthony to allow global

Re: [libvirt] [PATCH 2/6] qemu: virsh wrapper for qemu events

2014-02-11 Thread Eric Blake
On 02/11/2014 08:07 AM, Daniel P. Berrange wrote: On Fri, Jan 31, 2014 at 07:12:07PM -0700, Eric Blake wrote: Any new API deserves a good virsh wrapper :) qemu-monitor-event [domain] [event] [--pretty] [--loop] [--timeout number] * tools/virsh-domain.c (cmdQemuMonitorEvent): New

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Eric Blake
On 02/11/2014 08:15 AM, Daniel P. Berrange wrote: --- src/conf/domain_event.c | 140 +++ src/conf/domain_event.h | 22 src/libvirt_private.syms | 2 + 3 files changed, 164 insertions(+) I think these APIs should be in

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 08:26:50AM -0700, Eric Blake wrote: On 02/11/2014 08:15 AM, Daniel P. Berrange wrote: --- src/conf/domain_event.c | 140 +++ src/conf/domain_event.h | 22 src/libvirt_private.syms | 2 + 3 files

[libvirt] [PATCH] Rename 'index' in virCapabilitiesGetCpusForNode

2014-02-11 Thread Ján Tomko
This shadows the index function on some systems (RHEL-6.4, FreeBSD 9): ../../src/conf/capabilities.c: In function 'virCapabilitiesGetCpusForNode': ../../src/conf/capabilities.c:1005: warning: declaration of'index' shadows a global declaration [-Wshadow] /usr/include/strings.h:57: warning:

[libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.baseline() handler for aarch64

2014-02-11 Thread Oleg Strikov
Openstack Nova calls virConnectBaselineCPU() during initialization of the instance to get a full list of CPU features. This patch adds a stub to aarch64-specific code to handle this request (no actual work is done). That's enough to have this stub with limited functionality because qemu/kvm

Re: [libvirt] [PATCH] Rename 'index' in virCapabilitiesGetCpusForNode

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 04:39:47PM +0100, Ján Tomko wrote: This shadows the index function on some systems (RHEL-6.4, FreeBSD 9): ../../src/conf/capabilities.c: In function 'virCapabilitiesGetCpusForNode': ../../src/conf/capabilities.c:1005: warning: declaration of'index' shadows a

Re: [libvirt] [PATCHv2 2/6] event: server RPC protocol tweaks for domain lifecycle events

2014-02-11 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 10:49:22AM -0700, Eric Blake wrote: This patch adds some new RPC call numbers, but for ease of review, they sit idle until a later patch adds the client counterpart to drive the new RPCs. Also for ease of review, I limited this patch to just the lifecycle event;

Re: [libvirt] [PATCHv2 3/6] event: prepare client to track domain callbackID

2014-02-11 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 10:49:23AM -0700, Eric Blake wrote: We want to convert over to server-side events, even for older APIs. To do that, the client side of the remote driver wants to distinguish between legacy virConnectDomainEventRegister and normal virConnectDomainEventRegisterAny, while

Re: [libvirt] [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Anthony Liguori
On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/02/2014 11:16, Eduardo Habkost ha scritto: You are not alone. I

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Eric Blake
On 02/11/2014 08:28 AM, Daniel P. Berrange wrote: On Tue, Feb 11, 2014 at 08:26:50AM -0700, Eric Blake wrote: On 02/11/2014 08:15 AM, Daniel P. Berrange wrote: --- src/conf/domain_event.c | 140 +++ src/conf/domain_event.h | 22

Re: [libvirt] [PATCHv2 4/6] event: client RPC protocol tweaks for domain lifecycle events

2014-02-11 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 10:49:24AM -0700, Eric Blake wrote: The counterpart to the server RPC additions; here, a single function can serve both old and new calls, while incoming events must be serviced by two different functions. Again, some wise choices in our XDR makes event sharing easier.

Re: [libvirt] [PATCHv2 5/6] event: convert remaining domain events to new style

2014-02-11 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 10:49:25AM -0700, Eric Blake wrote: Following the patterns established by lifecycle events, this creates all the new RPC calls needed to pass callback IDs for every domain event, and changes the limits in client and server codes to use modern style when possible.

Re: [libvirt] [PATCHv2 6/6] event: pass reason for PM events

2014-02-11 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 10:49:26AM -0700, Eric Blake wrote: Commit 57ddcc23 (v0.9.11) introduced the pmwakeup event, with an optional 'reason' field reserved for possible future expansion. But it failed to wire the field through RPC, so even if we do add a reason in the future, we will be

[libvirt] [PATCHv5 4/7] storage: Add storage file backends for gluster

2014-02-11 Thread Peter Krempa
Implement storage backend functions to deal with gluster volumes and implement the stat and unlink backend APIs. --- Notes: Version 5: - adapted to error reporting changes - tweaked error message src/storage/storage_backend.c | 3 + src/storage/storage_backend_gluster.c |

[libvirt] [PATCHv5 0/7] Gluster snapshot series

2014-02-11 Thread Peter Krempa
New version after the recent feedback and fixing a few bugs found while testing. Please see individual patches for changes. Peter Krempa (7): storage: Add APIs for internal handling of files via the storage driver storage: Implement file storage APIs in the default storage driver

[libvirt] [PATCHv5 2/7] storage: Implement file storage APIs in the default storage driver

2014-02-11 Thread Peter Krempa
Implement the APIs added by the previous patch in the default storage driver used by qemu. --- Notes: Version 5: - adapt to error reporting change src/check-aclrules.pl | 1 + src/storage/storage_backend.c | 37 + src/storage/storage_backend.h | 43

Re: [libvirt] [PATCH v3 1/2] network: Introduce network hooks

2014-02-11 Thread Michal Privoznik
On 11.02.2014 10:54, Daniel P. Berrange wrote: On Mon, Feb 10, 2014 at 07:52:34PM +0100, Michal Privoznik wrote: @@ -3583,6 +3639,48 @@ validate: } } +/* finally we can call the 'plugged' hook script if any */ +if (virHookPresent(VIR_HOOK_DRIVER_NETWORK)) { +/*

[libvirt] [PATCHv5 5/7] qemu: Switch snapshot deletion to the new API functions

2014-02-11 Thread Peter Krempa
Use the new storage driver APIs to delete snapshot backing files in case of failure instead of directly relying on unlink. This will help us in the future when we will be adding network based storage without local representation in the host. --- Notes: Version 5: - no change, wasn't

[libvirt] [PATCHv5 6/7] qemu: snapshot: Use new APIs to detect presence of existing storage files

2014-02-11 Thread Peter Krempa
Use the new storage driver based stat api to detect exiting files just as we did with local files. --- Notes: Version 5: - new in sereis src/qemu/qemu_driver.c | 59 +++--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git

[libvirt] [PATCHv5 3/7] storage: add file functions for local and block files

2014-02-11 Thread Peter Krempa
Implement the stat and unlink function for file volumes and stat for block volumes using the regular system calls. --- Notes: Version 5: - added debug messages - adapted to error reporting changes Version 4: - adapt to change in error reporting

[libvirt] [PATCHv5 1/7] storage: Add APIs for internal handling of files via the storage driver

2014-02-11 Thread Peter Krempa
Some remote filesystems are not accessible via the local filesystem calls, but libvirt needs means to do operations on such files. This patch adds internal APIs into the storage driver that will allow operations on various networked and other filesystems. --- Notes: Version 5: - changed

Re: [libvirt] [PATCHv2 1/6] event: dynamically manage server-side RPC domain events

2014-02-11 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 10:49:21AM -0700, Eric Blake wrote: This patch continues the earlier conversion made for network events, with a goal of introducing server-side event filtering in a later patch. Actual behavior is unchanged without further RPC changes. * daemon/libvirtd.h

[libvirt] [PATCHv5 7/7] qemu: snapshot: Add support for external active snapshots on gluster

2014-02-11 Thread Peter Krempa
Add support for gluster backed images as sources for snapshots in the qemu driver. This will also simplify adding further network backed volumes as sources for snapshot in case qemu will support them. --- Notes: Version 5: - no change, wasn't reviewed yet docs/formatsnapshot.html.in |

Re: [libvirt] [PATCH v3 21/21] blkiotune: allow node major='' minor=''/ in place of path

2014-02-11 Thread Cedric Bosdonnat
Hi Daniel, On Tue, 2014-02-11 at 14:55 +, Daniel P. Berrange wrote: I realize this is helping the conversion of existing configs, but personally I'm pretty loathe to add this syntax. With device paths it is possible to have stable paths ie using /dev/disk/by*. With major/minor the XML

Re: [libvirt] [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Paolo Bonzini
Il 11/02/2014 17:43, Eduardo Habkost ha scritto: But compat properties as a concept could be made to work with dynamic properties. They would have to be evaluated after instance init. There's quite a few places they would end up touching I suspect. They already work. But if they work by

Re: [libvirt] [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Tue, Feb 11, 2014 at 07:58:30AM -0800, Anthony Liguori wrote: On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il

Re: [libvirt] [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Andreas Färber
Am 11.02.2014 16:58, schrieb Anthony Liguori: On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/02/2014 11:16, Eduardo

  1   2   >