Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Ján Tomko
On 02/13/2014 07:51 PM, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something time critical. In addition, NTP may

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Michal Privoznik
On 14.02.2014 09:10, Ján Tomko wrote: On 02/13/2014 07:51 PM, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something

Re: [libvirt] [PATCH v3 00/21] LXC configuration conversion

2014-02-14 Thread Ján Tomko
On 02/05/2014 03:09 PM, Cédric Bosdonnat wrote: Here is an updated version of the patch set fixing comments from Daniel. It also adds 3 commits: * One adding conversion for the newly supported blkio throttle tune in lxc driver. * One actually using the state of the veth network device

[libvirt] [PATCH v7 4/7] qemu_cap: Add USB keyboard capability

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com QEMU can support USB keyboard but libvirt haven't supportted it yet. This patch is to add USB keyboard capabilities and test cases. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c | 3 +++

[libvirt] [PATCH v7 0/7] Support keyboard device

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patchset is to add keyboard input device. For PPC64, it doesn't support a default keyboard device when the graphic is enabled. Libvirt supports QEMU command line as -device VGA which won't create any keyboard device for it. So it requires libvirt

[libvirt] [PATCH v7 1/7] conf: Add a keyboard input device type

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com There is no keyboard for non-x86 platforms when graphics are enabled. It's preferred to add one USB keyboard. This patch is to add keyboard input device type. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- docs/schemas/domaincommon.rng | 1 +

[libvirt] [PATCH v7 2/7] conf: Add one interface to add default input devices

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to add one new interface to add input devices. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 27 +++ src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files

[libvirt] [PATCH v7 3/7] conf: Remove the implicit PS2 mouse for non-X86 and platforms and add an implicit PS2 keyboard device for X86 platforms.

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com PS2 device only works for X86 platform, other platforms may need USB mouse. Athough it doesn't influence the QEMU command line, but it's not right to add one PS2 mouse for non-X86 platform. What's more, PS2 keyboard can be supported for X86. So, this

[libvirt] [PATCH v7 5/7] qemu: format qemu command line for USB keyboard

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to format qemu command line for USB keyboard and add test cases for it. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/qemu/qemu_command.c| 41 --

[libvirt] [PATCH v7 6/7] xen: format xen command line for USB keyboard

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patch is to format xen command line for USB keyboard Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/xenxs/xen_sxpr.c | 27 +++ src/xenxs/xen_xm.c | 30 ++ 2 files changed, 41

[libvirt] [PATCH v7 7/7] Add a default USB keyboard and USB mouse for PPC64

2014-02-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com There is no keyboard working on PPC64 and PS2 mouse is only for PPC64 when graphics are enabled. It needs to add a USB keyboard and USB mouse for it. This patch is to add a USB keyboard and USB mouse when graphics are enabled. Signed-off-by: Li Zhang

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Martin Kletzander
On Fri, Feb 14, 2014 at 08:47:37AM +0100, Richard Weinberger wrote: Am 14.02.2014 08:10, schrieb Martin Kletzander: On Thu, Feb 13, 2014 at 05:15:22PM +, Daniel P. Berrange wrote: From: Richard Weinberger rich...@nod.at Add a new helper function to change the permissions of a control

Re: [libvirt] [PATCH v6 1/6] conf: Add a keyboard input device type

2014-02-14 Thread Li Zhang
On 2014年02月14日 00:39, Daniel P. Berrange wrote: On Thu, Feb 13, 2014 at 04:48:21PM +0800, Li Zhang wrote: @@ -12422,10 +12426,12 @@ virDomainDefParseXML(xmlDocPtr xml, * XXX will this be true for other virt types ? */ if ((STREQ(def-os.type, hvm) input-bus

Re: [libvirt] [PATCH v6 1/6] conf: Add a keyboard input device type

2014-02-14 Thread Ján Tomko
On 02/14/2014 10:02 AM, Li Zhang wrote: On 2014年02月14日 00:39, Daniel P. Berrange wrote: On Thu, Feb 13, 2014 at 04:48:21PM +0800, Li Zhang wrote: @@ -12422,10 +12426,12 @@ virDomainDefParseXML(xmlDocPtr xml, * XXX will this be true for other virt types ? */ if

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 09:16:19AM +0100, Jan Kiszka wrote: On 2014-02-11 11:17, Stefan Hajnoczi wrote: On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Project ideas Please post project ideas on the wiki page below. Project ideas should be suitable as a 12-week

Re: [libvirt] [libvirt-java] [PATCH 01/65] Fix warnings about using raw types

2014-02-14 Thread Guido Günther
Hi, On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote: Eclipse generates this kind of warning: org/libvirt/jna/virConnectCredential.java:20: List is a raw type. References to generic type ListE should be parameterized Signed-off-by: Claudio Bley cb...@av-test.de ---

Re: [libvirt] [libvirt-java] [PATCH 05/65] test: ensure that exceptions are thrown when expected

2014-02-14 Thread Guido Günther
On Thu, Feb 13, 2014 at 04:22:13PM +0100, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- src/test/java/org/libvirt/TestJavaBindings.java |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/java/org/libvirt/TestJavaBindings.java

Re: [libvirt] [libvirt-java] [PATCH 03/65] Fix typos in Error.java

2014-02-14 Thread Guido Günther
On Thu, Feb 13, 2014 at 04:22:11PM +0100, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- src/main/java/org/libvirt/Error.java |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/libvirt/Error.java

Re: [libvirt] [libvirt-java] [PATCH 06/65] Make comments proper javadoc comments for enum constants

2014-02-14 Thread Guido Günther
On Thu, Feb 13, 2014 at 04:22:14PM +0100, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- src/main/java/org/libvirt/Error.java | 397 ++ 1 file changed, 262 insertions(+), 135 deletions(-) diff --git

Re: [libvirt] [libvirt-java] [PATCH 07/65] Ignore editor backup files

2014-02-14 Thread Guido Günther
On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index b02fd55..28ddc6e 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,5 @@

[libvirt] Destroying a suspended LXC domain

2014-02-14 Thread Richard Weinberger
Hi! If we suspend a LXC domain libvirt freezes all tasks in the cgroup using the process freezer. Upon destroy libvirt tries to kill all tasks using SIGTERM and later SIGKILL, but as they are frozen the tasks are unkillable. This seems to confuse libvirt, all tasks remain but libvirt forgets

Re: [libvirt] [libvirt-java] [PATCH 02/65] Fix warnings about accessing static methods

2014-02-14 Thread Guido Günther
On Thu, Feb 13, 2014 at 04:22:10PM +0100, Claudio Bley wrote: java/org/libvirt/Error.java:217: The static method wrap(int) from the type Error.ErrorDomain should be accessed in a static way Signed-off-by: Claudio Bley cb...@av-test.de --- src/main/java/org/libvirt/Error.java |6 +++---

Re: [libvirt] [PATCHv6 8/8] qemu: snapshot: Add support for external active snapshots on gluster

2014-02-14 Thread Peter Krempa
On 02/13/14 22:17, Eric Blake wrote: On 02/13/2014 09:49 AM, Peter Krempa wrote: Add support for gluster backed images as sources for snapshots in the qemu driver. This will also simplify adding further network backed volumes as sources for snapshot in case qemu will support them. ---

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Stephan Sachse
this patch works for me. container is starting fine. but a login (ssh/console) is not possible. host: centos6 kernel: 3.13.2 libvirt: 1.2.1 (+ lxc: Add virCgroupSetOwner()) container logs says agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1:

Re: [libvirt] [PATCH 2/2] lxc: Only delegate VIR_CGROUP_CONTROLLER_SYSTEMD to containers

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 08:49:07AM +0100, Richard Weinberger wrote: Am 13.02.2014 18:16, schrieb Daniel P. Berrange: On Tue, Feb 11, 2014 at 11:51:26PM +0100, Richard Weinberger wrote: Due to security concerns we delegate only VIR_CGROUP_CONTROLLER_SYSTEMD to containers. Currently it is

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Richard Weinberger
Am 14.02.2014 11:21, schrieb Stephan Sachse: this patch works for me. container is starting fine. but a login (ssh/console) is not possible. Thanks for testing! But I fear my patch is not the culprit for your login issues. host: centos6 kernel: 3.13.2 libvirt: 1.2.1 (+ lxc: Add

Re: [libvirt] Destroying a suspended LXC domain

2014-02-14 Thread Michal Privoznik
On 14.02.2014 11:14, Richard Weinberger wrote: Hi! If we suspend a LXC domain libvirt freezes all tasks in the cgroup using the process freezer. Upon destroy libvirt tries to kill all tasks using SIGTERM and later SIGKILL, but as they are frozen the tasks are unkillable. This seems to confuse

Re: [libvirt] Destroying a suspended LXC domain

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 11:14:39AM +0100, Richard Weinberger wrote: Hi! If we suspend a LXC domain libvirt freezes all tasks in the cgroup using the process freezer. Upon destroy libvirt tries to kill all tasks using SIGTERM and later SIGKILL, but as they are frozen the tasks are

[libvirt] [PATCH] storage: Fix build with older compilers afeter gluster snapshot series

2014-02-14 Thread Peter Krempa
In commit e32268184b4fd1611ed5ffd3c758b8f6a34152e6 I accidentally added twice a typedef for virStorageFileBackend when I moved it between files across patch iterations. The double declaration breaks build on older compilers in RHEL5 and FreeBSD. Remove the spurious definition. --- Notes:

Re: [libvirt] [PATCH 2/2] lxc: Only delegate VIR_CGROUP_CONTROLLER_SYSTEMD to containers

2014-02-14 Thread Richard Weinberger
Am 14.02.2014 11:30, schrieb Daniel P. Berrange: On Fri, Feb 14, 2014 at 08:49:07AM +0100, Richard Weinberger wrote: Am 13.02.2014 18:16, schrieb Daniel P. Berrange: On Tue, Feb 11, 2014 at 11:51:26PM +0100, Richard Weinberger wrote: Due to security concerns we delegate only

Re: [libvirt] [PATCH 2/2] lxc: Only delegate VIR_CGROUP_CONTROLLER_SYSTEMD to containers

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 12:11:13PM +0100, Richard Weinberger wrote: Am 14.02.2014 11:30, schrieb Daniel P. Berrange: On Fri, Feb 14, 2014 at 08:49:07AM +0100, Richard Weinberger wrote: Am 13.02.2014 18:16, schrieb Daniel P. Berrange: On Tue, Feb 11, 2014 at 11:51:26PM +0100, Richard

Re: [libvirt] [PATCHv6 5/8] storage: Add storage file backends for gluster

2014-02-14 Thread John Ferlan
Coverity has found a RESOURCE_LEAK... ...snip... +static int +virStorageFileBackendGlusterInit(virStorageFilePtr file) +{ +virStorageFileBackendGlusterPrivPtr priv = NULL; +virDomainDiskHostDefPtr host = (file-hosts[0]); +const char *hostname = host-name; +int port = 0; +

[libvirt] [PATCH] storage: gluster: Don't leak private data when storage file init fails

2014-02-14 Thread Peter Krempa
In a44b7b87bcc6681e2939f65a3552fc96f68bc7b6 I've introduced a function that initializes a storage file wrapper object on gluster based volumes. The initialization function leaks the private data pointer in case of failure. This patch fixes it. Reported by John Ferlan. --- Notes: Pushed

Re: [libvirt] [PATCHv6 5/8] storage: Add storage file backends for gluster

2014-02-14 Thread Peter Krempa
On 02/14/14 12:24, John Ferlan wrote: ... +error: +VIR_FREE(priv-volname); +glfs_fini(priv-vol); Adding the free here would be the salve for Coverity. Thanks for reporting the issue. This is now fixed by commit commit ad95fa59572c99c26959e6808a1e779a4ffed6de Author: Peter Krempa

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Stephan Sachse
agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1: cannot set process group: Inappropriate ioctl for device Is this really the reason why the login fails? Does getty not

[libvirt] [PATCH] lxc: Don't shadow global symbol link

2014-02-14 Thread Peter Krempa
Yet another variable name frowned upon by older compilers. Introduced in commit b73c029d. --- src/lxc/lxc_native.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 2cf479d..663e29c 100644 ---

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Richard Weinberger
Am 14.02.2014 13:42, schrieb Stephan Sachse: agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1: cannot set process group: Inappropriate ioctl for device Is this really

Re: [libvirt] [PATCH] lxc: Don't shadow global symbol link

2014-02-14 Thread Pavel Hrdina
On 14.2.2014 13:48, Peter Krempa wrote: Yet another variable name frowned upon by older compilers. Introduced in commit b73c029d. --- ACK, Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] lxc: Don't shadow global symbol link

2014-02-14 Thread Peter Krempa
On 02/14/14 14:00, Pavel Hrdina wrote: On 14.2.2014 13:48, Peter Krempa wrote: Yet another variable name frowned upon by older compilers. Introduced in commit b73c029d. --- ACK, Pavel Pushed; Thanks. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Jan Kiszka
On 2014-02-11 11:17, Stefan Hajnoczi wrote: On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Project ideas Please post project ideas on the wiki page below. Project ideas should be suitable as a 12-week project that a student fluent in C/Python/etc can complete. No

Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time

2014-02-14 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote: This is also adding new ACL permission to check 'set_time'. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/remote.c | 35 +++ src/access/viraccessperm.c | 2 +-

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Tom Kuther
Am 14.02.2014 13:42, schrieb Stephan Sachse: set LogLevel to DEBUG3. keyexchange is down. put then hangs for some time und sshd dies sshd[269]: debug1: KEX done [preauth] sshd[269]: debug1: userauth-request for user root service ssh-connection method none [preauth] sshd[269]: debug1:

[libvirt] [PATCH v2] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Richard Weinberger
Add a new helper function to change the permissions of a control group. This function is needed for user namespaces, we need to chmod() the cgroup to the initial uid/gid such that systemd is allowed to use the cgroup. Signed-off-by: Richard Weinberger rich...@nod.at --- Changes between v1 and v2:

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 01:42:25PM +0100, Stephan Sachse wrote: agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1: cannot get controlling tty: Operation not permitted agetty[38]: /dev/tty1: cannot set process group: Inappropriate ioctl for

Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time

2014-02-14 Thread Eric Blake
On 02/14/2014 06:23 AM, Martin Kletzander wrote: On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote: This is also adding new ACL permission to check 'set_time'. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Applies to previous patch too, this 'time' will be a

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Tom Kuther
Am 14.02.2014 14:17, schrieb Tom Kuther: Am 14.02.2014 13:42, schrieb Stephan Sachse: set LogLevel to DEBUG3. keyexchange is down. put then hangs for some time und sshd dies sshd[269]: debug1: KEX done [preauth] sshd[269]: debug1: userauth-request for user root service ssh-connection method

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 02:17:24PM +0100, Tom Kuther wrote: Am 14.02.2014 13:42, schrieb Stephan Sachse: set LogLevel to DEBUG3. keyexchange is down. put then hangs for some time und sshd dies sshd[269]: debug1: KEX done [preauth] sshd[269]: debug1: userauth-request for user root

Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 06:32:21AM -0700, Eric Blake wrote: On 02/14/2014 06:23 AM, Martin Kletzander wrote: On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote: This is also adding new ACL permission to check 'set_time'. Signed-off-by: Michal Privoznik mpriv...@redhat.com

Re: [libvirt] [PATCH v1 3/4] virsh: Expose virDomain{Get,Set}Time

2014-02-14 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 07:51:44PM +0100, Michal Privoznik wrote: These APIs are exposed under new virsh command 'domtime' which both gets and sets (not at the same time of course :)). Signed-off-by: Michal Privoznik mpriv...@redhat.com --- tools/virsh-domain-monitor.c | 126

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Tom Kuther
Am 14.02.2014 14:32, schrieb Daniel P. Berrange: On Fri, Feb 14, 2014 at 02:17:24PM +0100, Tom Kuther wrote: Am 14.02.2014 13:42, schrieb Stephan Sachse: set LogLevel to DEBUG3. keyexchange is down. put then hangs for some time und sshd dies sshd[269]: debug1: KEX done [preauth] sshd[269]:

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Stephan Sachse
systemctl mask console-getty.service fix the console login problem. sshd is still not working. dns works fine in the container. UseDNS=no fix the sshd login problem. crazy! yet I cannot reach any clients on the LAN using their lan hostname.domainname ping host.name works for me -- libvir-list

Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time

2014-02-14 Thread Eric Blake
On 02/14/2014 06:34 AM, Daniel P. Berrange wrote: On Fri, Feb 14, 2014 at 06:32:21AM -0700, Eric Blake wrote: On 02/14/2014 06:23 AM, Martin Kletzander wrote: On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote: This is also adding new ACL permission to check 'set_time'.

[libvirt] [PATCH v2] qemu: Use virtio network device for aarch64/virt

2014-02-14 Thread Oleg Strikov
This patch changes network device type used by default from rtl8139 to virtio when architecture type is aarch64 and machine type is virt. Qemu doesn't support any other machine types for aarch64 right now and we can't make any other aarch64-specific tuning in this function yet. Signed-off-by:

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Richard Weinberger
On Fri, Feb 14, 2014 at 2:17 PM, Tom Kuther t...@kuther.net wrote: Am 14.02.2014 13:42, schrieb Stephan Sachse: set LogLevel to DEBUG3. keyexchange is down. put then hangs for some time und sshd dies sshd[269]: debug1: KEX done [preauth] sshd[269]: debug1: userauth-request for user root

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Eric Blake
On 02/13/2014 11:51 AM, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something time critical. In addition, NTP may

[libvirt] [PATCH] [RFC] lxc: Remove !priv-cgroup case

2014-02-14 Thread Richard Weinberger
Currently we enforce that every container has a cgroup. So we can delete these two !priv-cgroup branches. Signed-off-by: Richard Weinberger rich...@nod.at --- Hi! Maybe I miss something but I think we can delete these two !priv-cgroup branches. If virLXCCgroupCreate() returns NULL the LXC

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Cedric Bosdonnat
On Fri, 2014-02-14 at 09:16 +0100, Jan Kiszka wrote: I need to submit our organization application (including our project ideas) on Friday. Hope it's not too late: just added the VT-d emulation proposal. It's not too late. Ideas page must be ready when students will discover the list of

Re: [libvirt] [PATCH] [RFC] lxc: Remove !priv-cgroup case

2014-02-14 Thread Daniel P. Berrange
On Fri, Feb 14, 2014 at 03:21:01PM +0100, Richard Weinberger wrote: Currently we enforce that every container has a cgroup. So we can delete these two !priv-cgroup branches. Signed-off-by: Richard Weinberger rich...@nod.at --- Hi! Maybe I miss something but I think we can delete these

Re: [libvirt] [PATCH v1 4/4] qemu: Implement virDomain{Get, Set}Time

2014-02-14 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 07:51:45PM +0100, Michal Privoznik wrote: One caveat though, qemu-ga is expecting time and returning time in nanoseconds. With all the buffering and propagation delay, the time is already wrong once it gets to the qemu-ga, but there's nothing we can do about it.

Re: [libvirt] [PATCH] [RFC] lxc: Remove !priv-cgroup case

2014-02-14 Thread Richard Weinberger
Am 14.02.2014 15:30, schrieb Daniel P. Berrange: On Fri, Feb 14, 2014 at 03:21:01PM +0100, Richard Weinberger wrote: Currently we enforce that every container has a cgroup. So we can delete these two !priv-cgroup branches. Signed-off-by: Richard Weinberger rich...@nod.at --- Hi! Maybe I

Re: [libvirt] Destroying a suspended LXC domain

2014-02-14 Thread Serge Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): On Fri, Feb 14, 2014 at 11:14:39AM +0100, Richard Weinberger wrote: Hi! If we suspend a LXC domain libvirt freezes all tasks in the cgroup using the process freezer. Upon destroy libvirt tries to kill all tasks using SIGTERM and later

Re: [libvirt] [PATCHv3 0/2] Support IPv6 in port allocator

2014-02-14 Thread Ján Tomko
On 02/06/2014 05:43 PM, Ján Tomko wrote: v1: Support IPv6 in port allocator https://www.redhat.com/archives/libvir-list/2013-October/msg7.html v2: https://www.redhat.com/archives/libvir-list/2013-October/msg01313.html bind to v4 and v6 separately v3: fix the embarrasing bug of

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Michal Privoznik
On 14.02.2014 15:16, Eric Blake wrote: On 02/13/2014 11:51 AM, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something

[libvirt] [PATCH 0/2] Test secret XML parsing and formatting

2014-02-14 Thread Ján Tomko
Ján Tomko (2): docs: remove auth from secret XML format Add tests for secret XML parsing docs/formatsecret.html.in| 2 - tests/Makefile.am| 12 ++- tests/secretschematest | 10 +++

[libvirt] [PATCH] Revert storage: Introduce internal pool support

2014-02-14 Thread Peter Krempa
The internal pools were an idea in one of the first iterations of the gluster series that deemed unused. Somehow still this got pushed. Remove it as the internal flag isn't needed. This reverts commit 362da8209d760fc1acd3a1c8df5b04aa676492eb. --- src/conf/storage_conf.c | 3 ---

[libvirt] [PATCH] Forgot to add lxcconf2xmldata to dist.

2014-02-14 Thread Cédric Bosdonnat
--- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 0718a69..9bb61ca 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -72,6 +72,7 @@ EXTRA_DIST = \ domainsnapshotxml2xmlout \ fchostdata \

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Michal Privoznik
On 13.02.2014 19:51, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something time critical. In addition, NTP may refuse

Re: [libvirt] [PATCH] Forgot to add lxcconf2xmldata to dist.

2014-02-14 Thread Ján Tomko
On 02/14/2014 04:06 PM, Cédric Bosdonnat wrote: --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) ACK and pushed. Jan signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] Add tests for secret XML parsing

2014-02-14 Thread Ján Tomko
also validate it against the RNG schema. --- tests/Makefile.am| 12 ++- tests/secretschematest | 10 +++ tests/secretxml2xmlin/ephemeral-usage-volume.xml | 7 ++ tests/secretxml2xmlin/usage-ceph.xml | 7 ++

Re: [libvirt] [PATCH] Revert storage: Introduce internal pool support

2014-02-14 Thread Eric Blake
On 02/14/2014 08:08 AM, Peter Krempa wrote: The internal pools were an idea in one of the first iterations of the gluster series that deemed unused. Somehow still this got pushed. Remove grammar is off, but I'm not sure of the best fix. Maybe one of: of the gluster series, which we decided

[libvirt] [PATCH glib] Fix symfile checks in VPATH build

2014-02-14 Thread Daniel P. Berrange
The check-symfile and check-symsorting rules were not taking $(srcdir) into account when accessing the symfile paths. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- build-aux/check-symsorting.pl | 3 +-- libvirt-gconfig/Makefile.am | 4 ++-- libvirt-glib/Makefile.am | 4 ++--

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Stephan Sachse
next problem: on centos6 there is no systemd. the init of the cgroups is handled by cgconfig. per default cgroups are mounted below /cgroup. i change /etc/cgconfig.conf to mount all cgroups below /sys/fs/cgroup. but thats not enough for the systemd in the container. i must add name=systemd =

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Eric Blake
On 02/14/2014 08:14 AM, Michal Privoznik wrote: On 13.02.2014 19:51, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running

[libvirt] [PATCH] lxc: Add destroy support for suspended domains

2014-02-14 Thread Richard Weinberger
Destroying a suspended domain needs special action. We cannot simply terminate all process because they are frozen. Do deal with that we send them SIGKILL and thaw them. Upon wakeup the process sees the pending signal and dies immediately. Signed-off-by: Richard Weinberger rich...@nod.at ---

Re: [libvirt] [PATCH 0/2] Test secret XML parsing and formatting

2014-02-14 Thread Eric Blake
On 02/14/2014 08:08 AM, Ján Tomko wrote: Ján Tomko (2): docs: remove auth from secret XML format Add tests for secret XML parsing ACK series. Wow - we've gone that long without testing secret XML? docs/formatsecret.html.in| 2 - tests/Makefile.am

Re: [libvirt] [PATCH 0/2] Test secret XML parsing and formatting

2014-02-14 Thread Ján Tomko
On 02/14/2014 04:44 PM, Eric Blake wrote: On 02/14/2014 08:08 AM, Ján Tomko wrote: Ján Tomko (2): docs: remove auth from secret XML format Add tests for secret XML parsing ACK series. Wow - we've gone that long without testing secret XML? Thanks, pushed. Jan signature.asc

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 03:22:04PM +0100, Cedric Bosdonnat wrote: On Fri, 2014-02-14 at 09:16 +0100, Jan Kiszka wrote: I need to submit our organization application (including our project ideas) on Friday. Hope it's not too late: just added the VT-d emulation proposal. It's not too

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-14 Thread Michal Privoznik
On 14.02.2014 16:39, Eric Blake wrote: On 02/14/2014 08:14 AM, Michal Privoznik wrote: On 13.02.2014 19:51, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't

[libvirt] [PATCHv4 01/10] Add util virCgroupGetBlkioIo*Serviced methods.

2014-02-14 Thread Thorsten Behrens
This reads blkio stats from blkio.throttle.io_service_bytes and blkio.throttle.io_serviced. --- src/libvirt_private.syms | 2 + src/util/vircgroup.c | 254 +++ src/util/vircgroup.h | 12 +++ 3 files changed, 268 insertions(+) diff --git

[libvirt] [PATCHv4 06/10] Widening API change - accept empty path for virDomainBlockStats

2014-02-14 Thread Thorsten Behrens
And provide domain summary stat in that case, for lxc backend. Use case is a container inheriting all devices from the host, e.g. when doing application containerization. --- src/libvirt.c| 8 ++-- tools/virsh-domain-monitor.c | 11 --- tools/virsh.pod |

[libvirt] [PATCHv4 10/10] Add unit test for virCgroupGetPercpuStats.

2014-02-14 Thread Thorsten Behrens
--- tests/vircgrouptest.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c index e05b882..5c14efb 100644 --- a/tests/vircgrouptest.c +++ b/tests/vircgrouptest.c @@ -33,6 +33,7 @@ # include

[libvirt] [PATCHv4 00/10] Add BlkIO and CPU/mem stat API implementations for lxc

2014-02-14 Thread Thorsten Behrens
This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens

[libvirt] [PATCHv4 02/10] Implement domainMemoryStats API slot for LXC driver.

2014-02-14 Thread Thorsten Behrens
--- Notes to v4: - check errors before filling param array - UL-ULL change punted to separate patch src/lxc/lxc_driver.c | 56 1 file changed, 56 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index f735631..827d989

[libvirt] [PATCHv4 05/10] Implement lxcDomainBlockStats* for lxc driver

2014-02-14 Thread Thorsten Behrens
Adds lxcDomainBlockStatsFlags and lxcDomainBlockStats functions. --- src/lxc/lxc_driver.c | 195 +++ 1 file changed, 195 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index e31b3ac..e1fcceb 100644 --- a/src/lxc/lxc_driver.c

[libvirt] [PATCHv4 03/10] Make qemuGetDomainTotalCPUStats a virCgroup function.

2014-02-14 Thread Thorsten Behrens
To reuse this from other drivers, like lxc. --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 54 ++-- src/util/vircgroup.c | 53 +++ src/util/vircgroup.h | 5 + 4 files changed, 61

[libvirt] [PATCHv4 07/10] Add unit test for virCgroupGetBlkioIo*Serviced

2014-02-14 Thread Thorsten Behrens
--- Notes to v4: - share fake disk device path via header file instead of env var tests/testutilslxc.h | 3 ++ tests/vircgroupmock.c | 98 +- tests/vircgrouptest.c | 129 ++ 3 files changed, 228

[libvirt] [PATCHv4 08/10] Add unit test for virCgroupGetMemoryUsage.

2014-02-14 Thread Thorsten Behrens
--- tests/vircgrouptest.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c index df29531..e05b882 100644 --- a/tests/vircgrouptest.c +++ b/tests/vircgrouptest.c @@ -530,6 +530,38 @@ static int

[libvirt] [PATCHv4 04/10] Implement domainGetCPUStats for lxc driver.

2014-02-14 Thread Thorsten Behrens
--- Notes to v4: - removed extraneous variable src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 49 +++ src/util/vircgroup.c | 75 src/util/vircgroup.h | 7 + 4 files changed, 132 insertions(+)

[libvirt] [PATCHv4 09/10] Fix misspelled cpuacct.usage_percpu in cgroup mock.

2014-02-14 Thread Thorsten Behrens
--- tests/vircgroupmock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c index d154a4a..ae88984 100644 --- a/tests/vircgroupmock.c +++ b/tests/vircgroupmock.c @@ -215,7 +215,7 @@ static int make_controller(const char *path, mode_t

[libvirt] ANNOUNCE: virt-manager 1.0.0 released

2014-02-14 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.0.0! Our version numbers were starting to get awkward, and this release was suitably featureful, so it felt like time to bump the major version. (And it's trendy these days, right?). virt-manager is a desktop application for managing KVM, Xen,

[libvirt] [PATCH 1/4] virsh: common code for parsing --seconds

2014-02-14 Thread Eric Blake
Several virsh commands ask for a --timeout parameter in seconds, then use it to control interfaces that operate on millisecond limits; I also plan on adding a 'virsh event' command that also does this. Factor this into a common function. * tools/virsh.h (vshCommandOptTimeoutToMs): New prototype.

[libvirt] [PATCH 2/4] virsh: common code for waiting for an event

2014-02-14 Thread Eric Blake
I plan to add 'virsh event' to virsh-domain.c and 'virsh net-event' to virsh-network.c; but as they will share quite a bit of common boilerplate, it's better to set that up now in virsh.c. * tools/virsh.h (_vshControl): Add fields. (vshEventStart, vshEventWait, vshEventDone, vshEventCleanup): New

[libvirt] [PATCH 0/4] add 'virsh event' and friends

2014-02-14 Thread Eric Blake
Inspired by my work on qemu monitor events; Dan correctly argued that if we're going to expose those through virsh, we also need to expose regular events. Patch 5/4 still coming, which adds handlers for the remaining 15 domain event types. Eric Blake (4): virsh: common code for parsing

[libvirt] [PATCH 4/4] virsh: add net-event command

2014-02-14 Thread Eric Blake
Add 'virsh net-event --list' and 'virsh net-event [net] --event=name [--loop] [--timeout]'. Very similar to 'virsh event'. * tools/virsh.pod (net-event): Document new command. * tools/virsh-network.c (vshNetworkEventToString, vshNetEventData) (vshEventLifecyclePrint, cmdNetworkEvent): New struct

[libvirt] [PATCH 3/4] virsh: add event command, for lifecycle events

2014-02-14 Thread Eric Blake
Add 'virsh event --list' and 'virsh event [dom] --event=name [--loop] [--timeout]'. Borrows somewhat from event-test.c, but defaults to a one-shot notification, and takes advantage of the event loop integration to allow Ctrl-C to interrupt the wait for an event. For now, this just does lifecycle