Re: [libvirt] [PATCH v6 2/2] blockcommit: turn on active commit

2014-07-30 Thread Peter Krempa
On 07/30/14 06:05, Eric Blake wrote: With this in place, I can (finally!) now do: virsh blockcommit $dom vda --shallow --verbose --pivot and watch qemu shorten the backing chain by one, followed by libvirt automatically updating the dumpxml output, effectively undoing the work of virsh

Re: [libvirt] [PATCH v6 1/2] blockcommit: track job type in xml

2014-07-30 Thread Peter Krempa
On 07/30/14 06:05, Eric Blake wrote: A future patch is going to wire up qemu active block commit jobs; but as they have similar events and are canceled/pivoted in the same way as block copy jobs, it is easiest to track all bookkeeping for the commit job by reusing the mirror element. This

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

2014-07-30 Thread Chun Yan Liu
On 7/29/2014 at 11:47 PM, in message 53d7c1f6.4030...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/29/2014 07:37 AM, Eric Blake wrote: On 07/29/2014 03:59 AM, Chunyan Liu wrote: Check whether dst is the same device as source, if yes, report error and exit. Currently

Re: [libvirt] [PATCH v2] storage: Refresh storage pool after upload

2014-07-30 Thread Daniel P. Berrange
On Tue, Jul 29, 2014 at 04:41:55PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1072653 Upon successful upload of a volume, the target volume and storage pool were not updated to reflect any changes as a result of the upload. Make use of the existing stream close

[libvirt] [PATCH] Domain config: write features/ if some capabilities are set.

2014-07-30 Thread Cédric Bosdonnat
If all features are set to default (including the capabilities policy), but some capabilities are toggled, we need to output the features element when formatting the config. --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c

[libvirt] [RFC] Adding a none model for video cards

2014-07-30 Thread Jean-Baptiste Rouault
Hi, I'm trying to run vexpress-a9 virtual machines (armv7l architecture) using libvirt. The vexpress-a9 doesn't support vga cards, but libvirt adds a video cirrus video card when there is a graphics element in the domain xml. This prevents the domain from booting. At the moment, the only

Re: [libvirt] [RFC] Memory hotplug for qemu guests and the relevant XML parts

2014-07-30 Thread Daniel P. Berrange
On Tue, Jul 29, 2014 at 05:05:23PM +0100, Daniel P. Berrange wrote: On Tue, Jul 29, 2014 at 04:40:50PM +0200, Peter Krempa wrote: On 07/24/14 17:03, Peter Krempa wrote: On 07/24/14 16:40, Daniel P. Berrange wrote: On Thu, Jul 24, 2014 at 04:30:43PM +0200, Peter Krempa wrote: On

Re: [libvirt] [PATCH] Domain config: write features/ if some capabilities are set.

2014-07-30 Thread Ján Tomko
On 07/30/2014 11:25 AM, Cédric Bosdonnat wrote: If all features are set to default (including the capabilities policy), but some capabilities are toggled, we need to output the features element when formatting the config. --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [libvirt] [RFC] Memory hotplug for qemu guests and the relevant XML parts

2014-07-30 Thread Peter Krempa
On 07/30/14 12:08, Daniel P. Berrange wrote: On Tue, Jul 29, 2014 at 05:05:23PM +0100, Daniel P. Berrange wrote: On Tue, Jul 29, 2014 at 04:40:50PM +0200, Peter Krempa wrote: On 07/24/14 17:03, Peter Krempa wrote: On 07/24/14 16:40, Daniel P. Berrange wrote: On Thu, Jul 24, 2014 at 04:30:43PM

Re: [libvirt] [RFC] Memory hotplug for qemu guests and the relevant XML parts

2014-07-30 Thread Daniel P. Berrange
On Wed, Jul 30, 2014 at 01:37:36PM +0200, Peter Krempa wrote: On 07/30/14 12:08, Daniel P. Berrange wrote: On Tue, Jul 29, 2014 at 05:05:23PM +0100, Daniel P. Berrange wrote: Looking at the big picture, we've got a bunch of memory related configuration sets - Guest NUMA topology setup,

Re: [libvirt] [PATCH] Domain config: write features/ if some capabilities are set.

2014-07-30 Thread Cedric Bosdonnat
On Wed, 2014-07-30 at 12:37 +0200, Ján Tomko wrote: On 07/30/2014 11:25 AM, Cédric Bosdonnat wrote: If all features are set to default (including the capabilities policy), but some capabilities are toggled, we need to output the features element when formatting the config. ---

Re: [libvirt] [RFC] Adding a none model for video cards

2014-07-30 Thread Eric Blake
On 07/30/2014 03:51 AM, Jean-Baptiste Rouault wrote: Hi, I'm trying to run vexpress-a9 virtual machines (armv7l architecture) using libvirt. The vexpress-a9 doesn't support vga cards, but libvirt adds a video cirrus video card when there is a graphics element in the domain xml. This

Re: [libvirt] [PATCH v6 2/2] blockcommit: turn on active commit

2014-07-30 Thread Eric Blake
On 07/30/2014 02:53 AM, Peter Krempa wrote: On 07/30/14 06:05, Eric Blake wrote: With this in place, I can (finally!) now do: virsh blockcommit $dom vda --shallow --verbose --pivot and watch qemu shorten the backing chain by one, followed by libvirt automatically updating the dumpxml

Re: [libvirt] [PATCH v6 0/2] turn on active commit

2014-07-30 Thread Kashyap Chamarthy
On Tue, Jul 29, 2014 at 10:05:55PM -0600, Eric Blake wrote: v5 was here, and got tentative ACKs: https://www.redhat.com/archives/libvir-list/2014-July/msg01414.html the only change is some reordering of logic in patch 2/2 (the former 4/4) to make sure that even for a super-fast commit where

Re: [libvirt] [PATCH] docs: bhyve: document recent changes

2014-07-30 Thread Roman Bogorodskiy
Ján Tomko wrote: On 07/24/2014 05:54 PM, Roman Bogorodskiy wrote: - mention that one disk and one network limitation is no longer actual for 1.2.6 and newer s/actual/current/ - add 'cdrom' device to the sample domain XML --- docs/drvbhyve.html.in | 12 +--- 1

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-30 Thread Jason Herne
Hi Eric, Thanks for continuing work on this. To repeat my test: Make a small disk image (50MB) and mount it at /usr/local/var/lib/libvirt/qemu/save/. Then attempt to managed save a guest whose memory is larger, say 256MB. The image will quickly fill and you should see the Unexpected Error

[libvirt] missing libvirt-sock after compile and install libvirt 1.2.6

2014-07-30 Thread Yuanzhen Gu
Hi folks, I compiled and installed libvirt latest version 1.2.6, based on this tutorial, http://blog.scottlowe.org/2012/11/05/compiling-libvirt-1-0-0-on-ubuntu-12-04-and-12-10/ I have compiled qemu and installed too, and make a symbolic link to /usr/bin/qemu-system-x86_64 but my question is

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2014-07-30 Thread Jason Herne
When I use this patch: diff --git a/src/util/iohelper.c b/src/util/iohelper.c index 8a3c377..255365c 100644 --- a/src/util/iohelper.c +++ b/src/util/iohelper.c @@ -307,6 +307,7 @@ main(int argc, char **argv) if (delete) unlink(path); +fprintf(stderr, _(goodbye world \n)); goto

Re: [libvirt] missing libvirt-sock after compile and install libvirt 1.2.6

2014-07-30 Thread Eric Blake
On 07/30/2014 08:55 AM, Yuanzhen Gu wrote: Hi folks, I compiled and installed libvirt latest version 1.2.6, based on this tutorial, http://blog.scottlowe.org/2012/11/05/compiling-libvirt-1-0-0-on-ubuntu-12-04-and-12-10/ I have compiled qemu and installed too, and make a symbolic link to

Re: [libvirt] missing libvirt-sock after compile and install libvirt 1.2.6

2014-07-30 Thread Claudio Bley
At Wed, 30 Jul 2014 09:30:45 -0600, Eric Blake wrote: On 07/30/2014 08:55 AM, Yuanzhen Gu wrote: Hi folks, I compiled and installed libvirt latest version 1.2.6, based on this tutorial, http://blog.scottlowe.org/2012/11/05/compiling-libvirt-1-0-0-on-ubuntu-12-04-and-12-10/ I

[libvirt] [RFC] Re: [PATCH 2/9] LXC: set IP addresses to veth devices in the container

2014-07-30 Thread Cedric Bosdonnat
Hi all, On Fri, 2014-07-25 at 17:03 +0200, Cédric Bosdonnat wrote: Uses the new virDomainNetDef ips to set the IP addresses on the network interfaces in the container. --- src/lxc/lxc_container.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 1/2] virsh: check if domiftune parameters fit into UINT

2014-07-30 Thread John Ferlan
On 07/28/2014 09:30 AM, Ján Tomko wrote: We parse the bandwidth rates as unsinged long long, then try to fit them in VIR_TYPED_PARAM_UINT. Report an error if they exceed UINT_MAX instead of quietly using wrong values. https://bugzilla.redhat.com/show_bug.cgi?id=1043735 ---

Re: [libvirt] [PATCH 2/2] Don't overwrite errors from virNetDevBandwidthSet

2014-07-30 Thread John Ferlan
On 07/28/2014 09:30 AM, Ján Tomko wrote: Otherwise this beautiful error would be overwritten when the function is called with a really high rate number: 2014-07-28 12:51:47.920+: 2304: error : virCommandWait:2399 : internal error: Child process (/sbin/tc class add dev vnet0 parent 1:

Re: [libvirt] missing libvirt-sock after compile and install libvirt 1.2.6

2014-07-30 Thread Yuanzhen Gu
I got your point, thanks a lot! I think the self-build libvirt didn't start, but there is no libvirt-bin under /etc/init.d/, don't know how to start it, and $ initctl start libvirt-binshows unknow job: libvirt-bin. I remember compile and installed libvirt before, but don't remember the

Re: [libvirt] missing libvirt-sock after compile and install libvirt 1.2.6

2014-07-30 Thread Yuanzhen Gu
I see, thank you very much! Best, Yuanzhen On Wed, Jul 30, 2014 at 12:40 PM, Claudio Bley cb...@av-test.de wrote: At Wed, 30 Jul 2014 09:30:45 -0600, Eric Blake wrote: On 07/30/2014 08:55 AM, Yuanzhen Gu wrote: Hi folks, I compiled and installed libvirt latest version 1.2.6,

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

2014-07-30 Thread Chun Yan Liu
On 7/29/2014 at 11:47 PM, in message 53d7c1f6.4030...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/29/2014 07:37 AM, Eric Blake wrote: On 07/29/2014 03:59 AM, Chunyan Liu wrote: Check whether dst is the same device as source, if yes, report error and exit. Currently

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

2014-07-30 Thread Eric Blake
On 07/30/2014 09:29 PM, Chun Yan Liu wrote: A better idea would be to rely on the volume lease manager - obtaining a lease should be impossible for an image already in use (and should even cover the case of copying 'base - active' onto 'base', which your equality test wouldn't catch). I'm

[libvirt] [PATCH v2 1/2] LXC: add support for persistent config in lxcDomainSetMemoryFlags

2014-07-30 Thread Chen Hanxiao
Currently, setmaxmem return success on an active domain, but nothing happened. This patch will disable this behaviour, also add support persistent config. And it will be used in a later patch. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- v2: disable changing max memory on an active

[libvirt] [PATCH v2 2/2] LXC: add support for --config in setmaxmem command

2014-07-30 Thread Chen Hanxiao
In lxc, we could not use setmaxmem command with --config options. This patch will add support for this. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/lxc/lxc_driver.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git

[libvirt] [PATCH v2 0/2] add support for --config in setmaxmem command

2014-07-30 Thread Chen Hanxiao
Currently, setmaxmem return success on an active domain, but nothing happened, which is not correct. This series will disable changing max memory on an active domain; then add --config support for setmaxmem command. v2: disable changing max memory on an active domain drop useless as_assert

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

2014-07-30 Thread Chun Yan Liu
On 7/31/2014 at 11:35 AM, in message 53d9b993.4040...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/30/2014 09:29 PM, Chun Yan Liu wrote: A better idea would be to rely on the volume lease manager - obtaining a lease should be impossible for an image already in use (and