[libvirt] [PATCH V2 libvirt-python] Fix duplicate entries in AUTHORS

2015-05-28 Thread Jim Fehlig
The generated AUTHORS file contains many duplicates. If an author has N commits, there will be N entries for the author in AUTHORS. Check if an author already exists in the list before appending. While at it, add a .mailmap (derived from libivrt's .mailmap) to futher tidy the generated AUTHORS

Re: [libvirt] [PATCH libvirt-python] Fix duplicate entries in AUTHORS

2015-05-28 Thread Jim Fehlig
On 05/28/2015 03:33 AM, Michal Privoznik wrote: On 11.05.2015 22:05, Jim Fehlig wrote: Andreas Färber wrote: Am 11.05.2015 um 21:08 schrieb Jim Fehlig: The generated AUTHORS file contains many duplicates. If an author has N commits, there will be N entries for the author in AUTHORS.

Re: [libvirt] Plans for next release

2015-05-28 Thread Jim Fehlig
On 05/28/2015 05:33 AM, Michal Privoznik wrote: On 27.05.2015 20:45, Jim Fehlig wrote: On 05/23/2015 07:22 AM, Daniel Veillard wrote: Hi everybody, if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have 137 commits since 1.2.15

[libvirt] [PATCH] qemu: Check for qemu capability when calling virDomainGetBlockIoTune()

2015-05-28 Thread Martin Kletzander
When getting block device I/O tuning data there is no check for whether QEMU supports such options and the call fails on qemuMonitorGetBlockIoThrottle() when getting the particular throttle data. So try reporting a better error when blkdeviotune is not supported. Resolves:

Re: [libvirt] [PATCH 0/4] libxl: support SPICE graphics

2015-05-28 Thread Jim Fehlig
On 05/28/2015 05:10 AM, Michal Privoznik wrote: On 09.05.2015 00:31, Jim Fehlig wrote: This series provides support for SPICE graphics in the libxl driver. The first patch is mostly code movement. The second patch is a trivial name change of a structure member. Patch3 populates the

Re: [libvirt] [PATCH] debug: assure NULLSTR() around all %s args in debug at top of public APIs

2015-05-28 Thread Laine Stump
On 05/28/2015 05:58 AM, Martin Kletzander wrote: On Wed, May 27, 2015 at 02:02:53PM -0400, Laine Stump wrote: There are also a couple that were very uninformatively just logging the value of the pointer rather than the string itself: * the name arg to virNodeDeviceLookupByName() * wwnn and

[libvirt] [PATCH] virsh: Fix printing of XML for pool-create-as

2015-05-28 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1224088 commit id 'bd00e00e' neglected to add the new adapter source options into the if condition that allowed printing the source XML fields. The adapter type='fc_host'.../ doesn't require other options in order to be complete. Signed-off-by: John

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-28 Thread Daniel P. Berrange
On Thu, May 28, 2015 at 11:12:38AM +0300, Dmitry Guryanov wrote: On 05/26/2015 08:05 PM, Daniel P. Berrange wrote: On Tue, May 26, 2015 at 08:04:25PM +0300, Maxim Nestratov wrote: 26.05.2015 18:01, Daniel P. Berrange пишет: On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote: It

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-28 Thread Dmitry Guryanov
On 05/26/2015 08:05 PM, Daniel P. Berrange wrote: On Tue, May 26, 2015 at 08:04:25PM +0300, Maxim Nestratov wrote: 26.05.2015 18:01, Daniel P. Berrange пишет: On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote: It is necessary to have unpolluted screen when connecting to

Re: [libvirt] [PATCH v2] libxl: load on FreeBSD

2015-05-28 Thread Roman Bogorodskiy
Jim Fehlig wrote: On 05/27/2015 09:06 AM, Martin Kletzander wrote: On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote: The libxl tries to check if it's running in dom0 by parsing /proc/xen/capabilities and if that fails it doesn't load. There's no procfs interface in

Re: [libvirt] [PATCH v2] libxl: load on FreeBSD

2015-05-28 Thread Martin Kletzander
On Thu, May 28, 2015 at 11:11:06AM +0400, Roman Bogorodskiy wrote: Jim Fehlig wrote: On 05/27/2015 09:06 AM, Martin Kletzander wrote: On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote: The libxl tries to check if it's running in dom0 by parsing /proc/xen/capabilities and if

Re: [libvirt] [PATCH 0/8 v3] parallels: add vz driver

2015-05-28 Thread Dmitry Guryanov
On 05/26/2015 08:12 PM, Maxim Nestratov wrote: v2-v3 change: * Patch parallels: set virtType depending on driver name reworked. Implemented ability to set virtType depending on driver name. v1-v2 change: * Only parallels: accept vz as a driver uri and name patch is changed. Fixed

Re: [libvirt] [PATCH] lxc: properly clean up qemu-nbd

2015-05-28 Thread Martin Kletzander
On Wed, May 27, 2015 at 10:56:06AM +0200, Cédric Bosdonnat wrote: Add the qemu-nbd tasks to the container cgroup to make sure those will be killed when the container is stopped. In order to reliably get the qemu-nbd tasks PIDs, we use /sys/devices/virtual/block/DEV/pid as qemu-nbd is daemonizing

Re: [libvirt] [PATCH v2] qemu: Limit rtc-reset-reinjection requirement to x86 only.

2015-05-28 Thread Andrea Bolognani
On Wed, 2015-05-27 at 16:55 +0200, Martin Kletzander wrote: ACK, will push in a while. Thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-28 Thread Dmitry Guryanov
On 05/28/2015 12:01 PM, Daniel P. Berrange wrote: On Thu, May 28, 2015 at 11:12:38AM +0300, Dmitry Guryanov wrote: On 05/26/2015 08:05 PM, Daniel P. Berrange wrote: On Tue, May 26, 2015 at 08:04:25PM +0300, Maxim Nestratov wrote: 26.05.2015 18:01, Daniel P. Berrange пишет: On Tue, May 26,

Re: [libvirt] [PATCH] debug: assure NULLSTR() around all %s args in debug at top of public APIs

2015-05-28 Thread Martin Kletzander
On Wed, May 27, 2015 at 02:02:53PM -0400, Laine Stump wrote: There are also a couple that were very uninformatively just logging the value of the pointer rather than the string itself: * the name arg to virNodeDeviceLookupByName() * wwnn and wwpn args to virNodeDeviceLookupSCSIHostByWWN() All

Re: [libvirt] [PATCH 3/4] libxl: support SPICE graphics for HVM domains

2015-05-28 Thread Michal Privoznik
On 09.05.2015 00:31, Jim Fehlig wrote: Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 72 +- 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

Re: [libvirt] Plans for next release

2015-05-28 Thread Michal Privoznik
On 27.05.2015 20:45, Jim Fehlig wrote: On 05/23/2015 07:22 AM, Daniel Veillard wrote: Hi everybody, if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have 137 commits since 1.2.15 but sticking to the monthly release is

[libvirt] [PATCH v3 4/5] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-28 Thread Andrea Bolognani
This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we

Re: [libvirt] [PATCH 0/4] libxl: support SPICE graphics

2015-05-28 Thread Michal Privoznik
On 09.05.2015 00:31, Jim Fehlig wrote: This series provides support for SPICE graphics in the libxl driver. The first patch is mostly code movement. The second patch is a trivial name change of a structure member. Patch3 populates the libxl_domain_build_info struct with SPICE info. SPICE

[libvirt] [PATCH v3 3/5] virsh: Make vshCommandOptScaledInt() use vshCommandOpt().

2015-05-28 Thread Andrea Bolognani
This aligns it to the other vshCommandOpt*() functions. --- tools/virsh.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1348985..720b715 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1804,16 +1804,16 @@

[libvirt] [PATCH v3 1/5] virsh: Use standard error message in vshCommandOptTimeoutToMs().

2015-05-28 Thread Andrea Bolognani
I missed this in the first time around, thanks Michal for noticing. --- tools/virsh.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1005ba8..865948f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1869,7 +1869,9 @@

Re: [libvirt] [PATCH libvirt-python] Fix duplicate entries in AUTHORS

2015-05-28 Thread Michal Privoznik
On 11.05.2015 22:05, Jim Fehlig wrote: Andreas Färber wrote: Am 11.05.2015 um 21:08 schrieb Jim Fehlig: The generated AUTHORS file contains many duplicates. If an author has N commits, there will be N entries for the author in AUTHORS. Check if an author already exists in the list before

Re: [libvirt] [PATCH] node_device: more informative error log when device isn't found

2015-05-28 Thread Martin Kletzander
On Wed, May 27, 2015 at 02:03:27PM -0400, Laine Stump wrote: In a couple of cases, the node device driver (and the test node device driver which likely copied it) was only logging Node device not found when it couldn't find the requested device. This patch changes those cases to log the name

Re: [libvirt] [PATCH 0/3] qemu: Allow arm 32-on-64 KVM

2015-05-28 Thread John Ferlan
On 05/21/2015 07:03 PM, Cole Robinson wrote: qemu 2.3.0 added support for enabling armv7l VMs to run on aarch64 hosts with KVM. First patch handles the special command line bit, last two patches are about advertising things in virsh capabilities. After these patches, 'virt-install --arch

Re: [libvirt] [PATCH 3/3] qemu: caps: Advertise arm 32-on-64 KVM option

2015-05-28 Thread Daniel P. Berrange
On Thu, May 21, 2015 at 07:03:28PM -0400, Cole Robinson wrote: We need to use qemu-system-aarch64 to run armv7l KVM VMs on an aarch64 host. --- src/qemu/qemu_capabilities.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git

[libvirt] [PATCH v3 5/5] virsh: Move error messages inside vshCommandOpt*() functions.

2015-05-28 Thread Andrea Bolognani
--- tests/vcpupin| 4 +- tools/virsh-domain-monitor.c | 9 +-- tools/virsh-domain.c | 134 +++ tools/virsh-host.c | 61 +++- tools/virsh-interface.c | 6 +- tools/virsh-network.c| 6 +-

Re: [libvirt] [PATCH v2 3/3] virsh: Move error messages inside vshCommandOpt*() functions.

2015-05-28 Thread Andrea Bolognani
On Wed, 2015-05-27 at 16:47 +0200, Michal Privoznik wrote: diff --git a/tools/virsh.c b/tools/virsh.c index 9f44793..db9354c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1517,23 +1517,27 @@ vshCommandOpt(const vshCmd *cmd, * 0 in all other cases (@value untouched) */

[libvirt] [PATCH v3 2/5] virsh: Improve vshCommandOptTimeoutToMs().

2015-05-28 Thread Andrea Bolognani
Use vshCommandOptUInt() instead of parsing the value as a signed integer and checking whether it's positive afterwards. Improve comments as well. --- tools/virsh.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/tools/virsh.c

[libvirt] [PATCH v3 0/5] virsh: Further improve handling of integer options

2015-05-28 Thread Andrea Bolognani
As suggested by Michal: now that we have a generic error message for failures related to the parsing of integer options, it makes sense to perform the corresponding check in a single spot instead of replicating it every time vshCommandOpt*() is used. Andrea Bolognani (5): virsh: Use standard

Re: [libvirt] [PATCH 1/3] Simplify allocation check in storageVolResize

2015-05-28 Thread Ján Tomko
On Wed, May 27, 2015 at 03:03:04PM -0400, John Ferlan wrote: On 05/27/2015 11:08 AM, Ján Tomko wrote: The volume cannot be shrinked below existing allocation, thus a successful resize with VOL_RESIZE_ALLOCATE will never increase the pool's available value. Since shrinking a volume

Re: [libvirt] [PATCH] storage: Report error when using metadata prealloc with non-qcow2 volumes

2015-05-28 Thread Erik Skultety
On 05/26/2015 02:58 PM, Erik Skultety wrote: We already report error from backend (virStorageBackendCreateRaw, virStorageBackendCreateBlockFrom), but we should also report the same error (applies to raw formated volumes and block type volumes as well) when creating a volume from a XML, not

Re: [libvirt] [PATCH v2] qemu: Deal with panic device on pSeries.

2015-05-28 Thread Andrea Bolognani
On Wed, 2015-05-27 at 09:44 -0400, John Ferlan wrote: This should be split into two patches The first one dealing with just the error/bug and the second dealing with adding a panic device by default for PPC* Thanks for the review, John! I've split the changes into separate commits, as

Re: [libvirt] Plans for next release

2015-05-28 Thread Daniel Veillard
On Thu, May 28, 2015 at 01:33:52PM +0200, Michal Privoznik wrote: On 27.05.2015 20:45, Jim Fehlig wrote: On 05/23/2015 07:22 AM, Daniel Veillard wrote: Hi everybody, if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have

[libvirt] [PATCHv2] Always add 'console' matching the 'serial' device

2015-05-28 Thread Ján Tomko
We have been formatting the first serial device also as a console device, but only if there were no other consoles. If there is a serial device present in the XML, but no serial console, or if there isn't any console at all but the domain definition hasn't gone through a parse-format-parse

[libvirt] [PATCH v3 3/3] qemu: Automatically add panic element for pSeries guests.

2015-05-28 Thread Andrea Bolognani
The guest firmware provides the same functionality as the pvpanic device, and the relevant element should always be present in the domain XML to reflect this fact, so add it after parsing the definition if it wasn't there already. --- docs/formatdomain.html.in | 5

[libvirt] [PATCH v3 2/3] qemu: Allow panic device for pSeries guests

2015-05-28 Thread Andrea Bolognani
The guest firmware provides the same functionality as the pvpanic device, which is not available in QEMU on pSeries, so the domain XML should be allowed to contain the panic element. On the other hand, unlike the pvpanic device, the guest firmware can't be configured, so report an error if an

[libvirt] [PATCH v3 0/3] qemu: Deal with panic device on pSeries

2015-05-28 Thread Andrea Bolognani
Currently, having the panic element in a domain XML prevents it from starting on pSeries. The error message in this case is not very accurate, and the first commit improves it. Since the guest firmware provides the same features as the pvpanic device for pSeries guests, the element should be

[libvirt] [PATCH v3 1/3] qemu: Improve error message for missing QEMU_CAPS_DEVICE_PANIC.

2015-05-28 Thread Andrea Bolognani
--- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d8ce511..f39442b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10840,7 +10840,7 @@ qemuBuildCommandLine(virConnectPtr

[libvirt] [PATCH] Fix the event name in vshEventTrayChangePrint

2015-05-28 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1206114#c5 Reported by: zhenfeng wang zhw...@redhat.com --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as trivial. diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 91a1ca2..fc4d1fc 100644 ---

Re: [libvirt] [PATCH v2 0/3] storage: Fix problem with disk backend pool allocation calculation

2015-05-28 Thread Ján Tomko
On Tue, May 26, 2015 at 11:29:16AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1224018 v1 here: http://www.redhat.com/archives/libvir-list/2015-May/msg00865.html This series adjusts the patches in order to first revert patches for

[libvirt] [PATCH v2 1/2] storage: Don't update volume objs list before we successfully create one

2015-05-28 Thread Erik Skultety
We do update pool volume object list before we actually create any volume. If buildVol fails, we then try to delete the volume in the storage as well as remove it from our structures. The problem is, that any backend that supports both buildVol and deleteVol would fail in this case which is

[libvirt] [PATCH v2 0/2] storage: Fix error when deleting non-existent volumes

2015-05-28 Thread Erik Skultety
Erik Skultety (2): storage: Don't update volume objs list before we successfully create one storage: RBD: do not return error when deleting non-existent volume src/storage/storage_backend_rbd.c | 6 +++--- src/storage/storage_driver.c | 31 +-- 2 files

Re: [libvirt] [PATCH 3/4] libxl: support SPICE graphics for HVM domains

2015-05-28 Thread Jim Fehlig
On May 28, 2015, at 4:07 AM, Michal Privoznik mpriv...@redhat.com wrote: On 09.05.2015 00:31, Jim Fehlig wrote: Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 72 +- 1 file changed, 66 insertions(+), 6 deletions(-)

Re: [libvirt] [PATCH 3/4] libxl: support SPICE graphics for HVM domains

2015-05-28 Thread Michal Privoznik
On 28.05.2015 17:45, Jim Fehlig wrote: On May 28, 2015, at 4:07 AM, Michal Privoznik mpriv...@redhat.com wrote: On 09.05.2015 00:31, Jim Fehlig wrote: Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 72 +- 1 file

Re: [libvirt] [PATCH v2] virsh: Fix to list online cpus using virsh capabilities

2015-05-28 Thread Michal Privoznik
On 26.05.2015 18:40, Kothapally Madhu Pavan wrote: Virsh capabilities will list offline cpus as online when libvirt is compiled with numactl option disabled. This fix will list correct set of online cpus. --- src/nodeinfo.c | 43 +++ 1 file changed,

[libvirt] [PATCH v2 2/2] storage: RBD: do not return error when deleting non-existent volume

2015-05-28 Thread Erik Skultety
RBD API returns negative value of errno, in that case we can silently ignore if RBD tries to delete a non-existent volume, just like FS backend does. --- src/storage/storage_backend_rbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_rbd.c