[libvirt] [PATCH v2 0/5] Add read error ignore to storage backend vol info APIs

2015-11-24 Thread John Ferlan
v1 took a simplistic approach: http://www.redhat.com/archives/libvir-list/2015-October/msg00919.html but not specific enough according to the review. So adding some extra complexity of checking for specific errors and flag bits to "ignore" the error similar to the catch-all openflags

[libvirt] [PATCH v2 1/5] storage: Add readflags for backend error processing

2015-11-24 Thread John Ferlan
Similar to the openflags which allow VIR_STORAGE_VOL_OPEN_NOERROR to be passed to avoid open errors, add a 'readflags' variable so that in the future various read failures could also be ignored. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 24

[libvirt] [PATCH v2 4/5] storage: Add debug message

2015-11-24 Thread John Ferlan
I found this useful while processing a volume that wouldn't end up showing up in the resulting list of block volumes. In this case, the partition type wasn't found in the disk_types table. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 4 1 file changed,

[libvirt] [PATCH v2 5/5] storage: Ignore block devices that fail format detection

2015-11-24 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1276198 Prior to commit id '98322052' failure to saferead the block device would cause an error to be logged and the device to be skipped while attempting to discover/create a stable target path for a new LUN (NPIV). This was because

[libvirt] [PATCH v2 3/5] storage: Handle readflags errors

2015-11-24 Thread John Ferlan
Similar to the openflags VIR_STORAGE_VOL_OPEN_NOERROR processing, if some read processing operation fails, check the readflags for the corresponding error flag being set. If so, rather then causing an error - use VIR_WARN to flag the error, but return -2 which some callers can use to perform

[libvirt] [PATCH v2 2/5] storage: Add comments for backend APIs

2015-11-24 Thread John Ferlan
Just so it's clearer what to expect upon input and what types of return values could be generated. These were loosely copied from existing virStorageBackendUpdateVolTargetInfoFD. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 30

Re: [libvirt] [PATCH] apparmor: add missing qemu binaries

2015-11-24 Thread Guido Günther
Hi, On Tue, Nov 24, 2015 at 03:20:00PM +, Daniel P. Berrange wrote: > On Tue, Nov 24, 2015 at 04:16:11PM +0100, Guido Günther wrote: > > This adds the qemu binaries as of 1.2.4 in Debian. It also removes a > > duplicate sparc64 entry. > > --- > > examples/apparmor/libvirt-qemu | 21

Re: [libvirt] [PATCH 4/8] perf: implement the remote protocol for perf event

2015-11-24 Thread Ren, Qiaowei
> -Original Message- > From: Jiri Denemark [mailto:jdene...@redhat.com] > Sent: Tuesday, November 24, 2015 5:43 PM > To: Ren, Qiaowei > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 4/8] perf: implement the remote protocol for > perf > event > > On Tue, Nov 17, 2015 at

[libvirt] ANNOUNCE: virt-manager 1.3.0 released

2015-11-24 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.3.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - Git hosting moved to

Re: [libvirt] [PATCH java] Add support for Libvirt Qemu Library

2015-11-24 Thread Wido den Hollander
On 11/17/2015 08:43 AM, Claudio Bley wrote: > At Mon, 16 Nov 2015 21:26:57 +0100, > Wido den Hollander wrote: >> >> >> >>> Since there are no flags currently, simply drop the flags >>> parameter. We add flags (as enums) later when the function starts to >>> support one. >>> >> >> Good point,

[libvirt] [libvirt-glib v4] gobject: Port to GTask API

2015-11-24 Thread Zeeshan Ali (Khattak)
Drop usage of deprecated GSimpleAsyncResult API. --- libvirt-gobject/libvirt-gobject-domain.c| 290 +--- libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++---

Re: [libvirt] [libvirt-glib v4] gobject: Port to GTask API

2015-11-24 Thread Zeeshan Ali (Khattak)
On Tue, Nov 24, 2015 at 4:23 PM, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- This version ensures that async result is returned from the main thread in gvir_stream_close_async(). > libvirt-gobject/libvirt-gobject-domain.c|

Re: [libvirt] how to know if PCI device has SR-IOV PF capability

2015-11-24 Thread Moshe Levi
Hi Laine, Did you have a bug for this issue? I need it to document it in for my workaround in OpenStack. Thanks, Moshe Levi. > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, November 23, 2015 6:29 PM > To: Laine Stump

Re: [libvirt] [PATCH v4 08/10] Add iommu info for pci on mocked sysfs

2015-11-24 Thread Shivaprasad bhat
Thanks for the comments Michal.. I'll fix them all in my next version. Regards, Shivaprasad On Mon, Nov 23, 2015 at 10:34 PM, Michal Privoznik wrote: > On 14.11.2015 09:38, Shivaprasad G Bhat wrote: >> The iommu group info can be used to check if the devices are

Re: [libvirt] [PATCH v2 3/7] qemu: Introduce qemuProcessFinishStartup

2015-11-24 Thread Pavel Hrdina
On Thu, Nov 19, 2015 at 01:09:17PM +0100, Jiri Denemark wrote: > Finishes starting a new domain launched by qemuProcessLaunch. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - save status before running VIR_HOOK_QEMU_OP_STARTED hook > - rename

Re: [libvirt] [PATCH v2 5/7] qemu: Kill QEMU process if Prepare phase fails

2015-11-24 Thread Pavel Hrdina
On Thu, Nov 19, 2015 at 01:09:19PM +0100, Jiri Denemark wrote: > Some failure paths in qemuMigrationPrepareAny forgot to kill the just > started QEMU process. This patch fixes this by combining 'stop' and > 'endjob' label into a new label 'stopjob'. This name was chosen to avoid > confusion with

Re: [libvirt] [PATCH 4/8] perf: implement the remote protocol for perf event

2015-11-24 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:44 +0800, Qiaowei Ren wrote: > Add remote support for perf event. > > Signed-off-by: Qiaowei Ren > --- > daemon/remote.c | 60 > > src/remote/remote_driver.c | 49

Re: [libvirt] [PATCH v2 7/7] qemu: Use qemuProcessLaunch in migration Prepare phase

2015-11-24 Thread Pavel Hrdina
On Thu, Nov 19, 2015 at 01:09:21PM +0100, Jiri Denemark wrote: > Using qemuProcess{Init,Launch,FinishStartup} allows us to run > pre-migration commands on destination before asking QEMU to wait for > incoming migration data. > > Signed-off-by: Jiri Denemark > --- >

Re: [libvirt] [PATCH] vz: Allow to create container based on template

2015-11-24 Thread Dmitry Guryanov
On Thu, 2015-11-19 at 14:44 +0300, Mikhail Feoktistov wrote: > We shouldn't delete disk from default config if we create container based on > template, > because we don't have the new disk from XML, only template name. > And don't add template section from XML as new filesystem, > we use

Re: [libvirt] [PATCH] vz: allow to boot VM from cdrom

2015-11-24 Thread Dmitry Guryanov
On Fri, 2015-11-20 at 16:00 +0300, Mikhail Feoktistov wrote: Could you add some detail to commit message, because this change is not trivial? > --- >  src/vz/vz_sdk.c | 22 +- >  1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/src/vz/vz_sdk.c

Re: [libvirt] [PATCH] vz: implementation of domainCreateXML callback

2015-11-24 Thread Dmitry Guryanov
On Fri, 2015-11-20 at 16:52 +0300, Mikhail Feoktistov wrote: > --- >  src/vz/vz_driver.c | 33 + >  1 file changed, 33 insertions(+) > > diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c > index 39f58a4..31dfb6a 100644 > --- a/src/vz/vz_driver.c > +++

Re: [libvirt] [PATCH] vz: implementation of domainCreateXML callback

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 05:24:48PM +0300, Dmitry Guryanov wrote: > On Fri, 2015-11-20 at 16:52 +0300, Mikhail Feoktistov wrote: > > --- > >  src/vz/vz_driver.c | 33 + > >  1 file changed, 33 insertions(+) > > > > diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c

Re: [libvirt] [PATCH 5/6] RFC qemu: add spice opengl support

2015-11-24 Thread Marc-André Lureau
Hi Jan On Mon, Nov 23, 2015 at 6:58 PM, Ján Tomko wrote: > Overall, the XML looks good to me. Apart from the accel3d attribute, > which is ugly, but less ugly than inveting a separate one. Thanks for your feedback. While reworking the patches and adding xml2xml test, I

Re: [libvirt] build issue due to '-Werror=cast-align' on ARM (armhf) [was: Re: [Xen-devel] [libvirt test] 63528: regressions - FAIL]

2015-11-24 Thread Ian Campbell
Hi Maxim, On Fri, 2015-11-13 at 20:26 -0700, Jim Fehlig wrote: > On 11/13/2015 10:00 AM, Dario Faggioli wrote: > > Hello, > > > > The Xen Project's automated test suite is failing at running its > > libvirt tests for a few time, like this: > > > > On Wed, 2015-11-04 at 09:04 +, osstest

Re: [libvirt] [PATCH 5/6] RFC qemu: add spice opengl support

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 03:50:02PM +0100, Marc-André Lureau wrote: > Hi Jan > > On Mon, Nov 23, 2015 at 6:58 PM, Ján Tomko wrote: > > Overall, the XML looks good to me. Apart from the accel3d attribute, > > which is ugly, but less ugly than inveting a separate one. > > Thanks

Re: [libvirt] [PATCH] storage: Ignore block devices that fail format detection

2015-11-24 Thread John Ferlan
On 11/23/2015 09:13 AM, Ján Tomko wrote: > On Fri, Oct 30, 2015 at 11:13:21AM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1276198 >> >> Prior to commit id '98322052' failure to saferead the block device would >> cause an error to be logged and the device to be

Re: [libvirt] [libvirt-glib v3] gobject: Port to GTask API

2015-11-24 Thread Christophe Fergeau
On Mon, Nov 23, 2015 at 10:50:48PM +, Zeeshan Ali (Khattak) wrote: > On Mon, Nov 23, 2015 at 10:45 PM, Zeeshan Ali (Khattak) > wrote: > > Drop usage of deprecated GSimpleAsyncResult API. > > --- > > Sorry, forgot to pass --annotate option to git-send-email. > > v3 just

[libvirt] [PATCH] apparmor: add missing qemu binaries

2015-11-24 Thread Guido Günther
This adds the qemu binaries as of 1.2.4 in Debian. It also removes a duplicate sparc64 entry. --- examples/apparmor/libvirt-qemu | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index

Re: [libvirt] [PATCH] apparmor: add missing qemu binaries

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 04:16:11PM +0100, Guido Günther wrote: > This adds the qemu binaries as of 1.2.4 in Debian. It also removes a > duplicate sparc64 entry. > --- > examples/apparmor/libvirt-qemu | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) ACK Regards,

[libvirt] [PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- We've dropped support for old QEMU and there was a vote to change version to 1.3.0, let's make it official. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f481c50..4b7c9ed

Re: [libvirt] [PATCH 32/34] qemu: Add helper to retrieve vCPU pid

2015-11-24 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Instead of directly accessing the array add a helper to do this. > --- > src/qemu/qemu_cgroup.c | 3 ++- > src/qemu/qemu_domain.c | 20 > src/qemu/qemu_domain.h | 1 + > src/qemu/qemu_driver.c | 7 --- >

[libvirt] [PATCHv5 4/9] qemu: add support for hv_crash feature as a panic device

2015-11-24 Thread Dmitry Andreev
Panic device type used depends on 'model' attribute. If no model is specified then device type depends on hypervisor and guest arch. 'pseries' model is used for pSeries guest and 'isa' model is used in other cases. XML: QEMU command line: qemu -cpu ,hv_crash --- v5: * autoselection of

[libvirt] [PATCHv5 2/9] conf: add 'model' attribute for panic device with values isa, pseries, hyperv

2015-11-24 Thread Dmitry Andreev
Libvirt already has two types of panic devices - pvpanic and pSeries firmware. This patch introduces the 'model' attribute and a new type of panic device. 'isa' model is for ISA pvpanic device. 'pseries' model is a default value for pSeries guests. 'hyperv' model is the new type. It's used for

[libvirt] [PATCHv5 0/9] Hyper-v crash feature support

2015-11-24 Thread Dmitry Andreev
A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature will become available in v2.5.0. What is changed in v5: * minor code fixes * code was moved between patches * patch sequence changed Dmitry Andreev (9): conf: refactor code for checking ABI stability of panic device conf:

[libvirt] [PATCHv5 9/9] conf: reject multiple panic devices of same model

2015-11-24 Thread Dmitry Andreev
Only one panic device per model is allowed. --- v5: minor code fixes src/conf/domain_conf.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ef322f5..c30f420 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCHv5 7/9] Allow multiple panic devices

2015-11-24 Thread Dmitry Andreev
'model' attribute was added to a panic device but only one panic device is allowed. This patch changes panic device presence from 'optional' to 'zeroOrMore'. --- v5: part of the code was moved out from this commit docs/formatdomain.html.in | 1 + docs/schemas/domaincommon.rng | 4 ++--

[libvirt] [PATCHv5 1/9] conf: refactor code for checking ABI stability of panic device

2015-11-24 Thread Dmitry Andreev
--- v5: this code was moved from another patch src/conf/domain_conf.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0ac7dbf..a14dd77 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt] [PATCHv5 5/9] tests: rework tests for panic devices

2015-11-24 Thread Dmitry Andreev
Panic device model will be selected automatically if it is not chosen by the user. Tests should cover this case. --- .../qemuxml2argv-panic-no-address.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml | 2 +- .../qemuxml2argv-pseries-nvram.xml | 2 +-

[libvirt] [PATCHv5 6/9] tests: add tests for the new 'hyperv' panic device model

2015-11-24 Thread Dmitry Andreev
--- tests/qemuargv2xmltest.c| 1 + .../qemuxml2argvdata/qemuxml2argv-hyperv-panic.args | 21 + tests/qemuxml2argvtest.c| 1 + 3 files changed, 23 insertions(+) create mode 100644

Re: [libvirt] [PATCH] qemu: pass the asyncJob to qemuProcessStartCPUs

2015-11-24 Thread Peter Krempa
On Tue, Nov 24, 2015 at 13:25:05 +0100, Ján Tomko wrote: > Now that new domains are started inside a QEMU_ASYNC_JOB_START job, > we need to pass it down to qemuProcessStartCPUs too. > > This removes the warning: > qemuDomainObjEnterMonitorInternal:1750 : This thread seems to be the > async job

Re: [libvirt] [PATCH] qemu: pass the asyncJob to qemuProcessStartCPUs

2015-11-24 Thread Ján Tomko
On Tue, Nov 24, 2015 at 01:33:41PM +0100, Peter Krempa wrote: > On Tue, Nov 24, 2015 at 13:25:05 +0100, Ján Tomko wrote: > > Now that new domains are started inside a QEMU_ASYNC_JOB_START job, > > we need to pass it down to qemuProcessStartCPUs too. > > > > This removes the warning: > >

Re: [libvirt] [PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread John Ferlan
On 11/24/2015 06:52 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > > We've dropped support for old QEMU and there was a vote to change version to > 1.3.0, let's make it official. > > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I

Re: [libvirt] [PATCH 1/2] conf: support reporting maxCount attribute for virtual_functions cap

2015-11-24 Thread Pavel Hrdina
On Mon, Nov 23, 2015 at 04:50:13PM -0500, Laine Stump wrote: > Report the maximum possible number of VFs for an SRIOV PF, like this: > > > ... > > > I've just discovered that the virtual_functions and physical_functions > capabilities are not supported in the virNodeDeviceParse

Re: [libvirt] [PATCH 5/8] perf: implement a set of util functions for perf event

2015-11-24 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:45 +0800, Qiaowei Ren wrote: > This patch implement a set of interfaces for perf event. Based on > these interfaces, we can implement internal driver API for perf, > and get the results of perf conuter you care about. > > Signed-off-by: Qiaowei Ren

Re: [libvirt] [PATCH 2/2] nodedev: report maxCount for virtual_functions capability

2015-11-24 Thread Pavel Hrdina
On Mon, Nov 23, 2015 at 04:50:14PM -0500, Laine Stump wrote: > A PCI device may have the capability to setup virtual functions (VFs) > but have them currently all disabled. Prior to this patch, if that was > the case the the node device XML for the device wouldn't report any s/the the/the/ >

Re: [libvirt] [PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 07:01:03AM -0500, John Ferlan wrote: > > > On 11/24/2015 06:52 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > > > We've dropped support for old QEMU and there was a vote to change version to > > 1.3.0, let's make it official. > >

[libvirt] [PATCH] qemu: pass the asyncJob to qemuProcessStartCPUs

2015-11-24 Thread Ján Tomko
Now that new domains are started inside a QEMU_ASYNC_JOB_START job, we need to pass it down to qemuProcessStartCPUs too. This removes the warning: qemuDomainObjEnterMonitorInternal:1750 : This thread seems to be the async job owner; entering monitor without asking for a nested job is dangerous

[libvirt] [PATCHv5 8/9] tests: add tests for multiple panic devices

2015-11-24 Thread Dmitry Andreev
--- .../qemuxml2argv-panic-double.args | 21 .../qemuxml2argvdata/qemuxml2argv-panic-double.xml | 28 ++ tests/qemuxml2argvtest.c | 2 ++ tests/qemuxml2xmltest.c| 1 + 4 files changed, 52

[libvirt] [PATCHv5 3/9] tests: add tests for the new panic device attribute - 'model'

2015-11-24 Thread Dmitry Andreev
--- v5: tests was moved from another patch .../qemuxml2argvdata/qemuxml2argv-hyperv-panic.xml | 25 + tests/qemuxml2argvdata/qemuxml2argv-panic-isa.xml | 31 ++ .../qemuxml2argv-panic-pseries.xml | 30 +

[libvirt] [PATCH v2] Post-release version bump to 1.3.0

2015-11-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac | 2 +- src/libxl/libxl_driver.c | 4 ++-- src/vz/vz_driver.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index f481c50..4b7c9ed 100644 --- a/configure.ac +++

[libvirt] [python PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Pushed setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 61fa369..04e3de4 100755 --- a/setup.py +++ b/setup.py @@ -311,7 +311,7 @@ class my_clean(clean): _c_modules, _py_modules =

[libvirt] [perl PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Makefile.PL | 2 +- README | 2 +- lib/Sys/Virt.pm | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 709be83..4ae538f 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -3,7 +3,7 @@

Re: [libvirt] [PATCH 5/8] perf: implement a set of util functions for perf event

2015-11-24 Thread Jiri Denemark
On Tue, Nov 24, 2015 at 13:23:49 +0100, Jiri Denemark wrote: > On Tue, Nov 17, 2015 at 16:00:45 +0800, Qiaowei Ren wrote: > > This patch implement a set of interfaces for perf event. Based on > > these interfaces, we can implement internal driver API for perf, > > and get the results of perf

Re: [libvirt] [perl PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 01:41:33PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > Makefile.PL | 2 +- > README | 2 +- > lib/Sys/Virt.pm | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Need to add a dummy entry in Changes eg just put

Re: [libvirt] [PATCH v2] Post-release version bump to 1.3.0

2015-11-24 Thread Pavel Hrdina
On Tue, Nov 24, 2015 at 12:49:11PM +, Daniel P. Berrange wrote: > On Tue, Nov 24, 2015 at 01:28:14PM +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > configure.ac | 2 +- > > src/libxl/libxl_driver.c | 4 ++-- > > src/vz/vz_driver.c

[libvirt] [PATCH] logging: inhibit virtlogd shutdown while log files are open

2015-11-24 Thread Daniel P. Berrange
The virtlogd daemon is launched with a 30 second timeout for unprivileged users. Unfortunately the timeout is only inhibited while RPC clients are connected, and they only connect for a short while to open the log file descriptor. We need to hold an inhibition for as long as the log file

[libvirt] [PATCH] virtlockd: fix misc memory leaks and other bugs

2015-11-24 Thread Daniel P. Berrange
Fix memory leaks, failure to restore umask and missing man page docs. Signed-off-by: Daniel P. Berrange --- src/locking/lock_daemon.c| 6 +- src/locking/virtlockd.pod.in | 7 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 0/8] Add perf and Intel CMT feature support

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 02:24:22PM +0100, Jiri Denemark wrote: > On Tue, Nov 17, 2015 at 16:00:40 +0800, Qiaowei Ren wrote: > > The series mainly adds Intel CMT feature support into libvirt. CMT is > > new introduced PQos (Platform Qos) feature to monitor the usage of > > cache by applications

Re: [libvirt] [PATCH v2] Post-release version bump to 1.3.0

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 01:28:14PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 2 +- > src/libxl/libxl_driver.c | 4 ++-- > src/vz/vz_driver.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) ACK Regards,

Re: [libvirt] [PATCH 5/8] perf: implement a set of util functions for perf event

2015-11-24 Thread Daniel P. Berrange
On Tue, Nov 24, 2015 at 01:44:53PM +0100, Jiri Denemark wrote: > On Tue, Nov 24, 2015 at 13:23:49 +0100, Jiri Denemark wrote: > > On Tue, Nov 17, 2015 at 16:00:45 +0800, Qiaowei Ren wrote: > > > This patch implement a set of interfaces for perf event. Based on > > > these interfaces, we can

Re: [libvirt] [PATCH 33/34] qemu: driver: Refactor qemuDomainHelperGetVcpus

2015-11-24 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Change some of the control structures and switch to using the new vcpu > structure. > --- > src/qemu/qemu_driver.c | 77 > -- > 1 file changed, 43 insertions(+), 34 deletions(-) > > diff --git

Re: [libvirt] [PATCH 6/8] qemu_driver: add support to perf event

2015-11-24 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:46 +0800, Qiaowei Ren wrote: > This patch implement the internal driver API for perf event into > qemu driver. > > In addition, this patch extend virDomainListGetStats API to get > the statistics for perf event. To do so, we add a > 'VIR_DOMAIN_STATS_PERF' enum to

[libvirt] [PATCH 1/6] process: Allow virProcessPrLimit() to get current limit

2015-11-24 Thread Andrea Bolognani
The prlimit() function allows both getting and setting limits for a process; expose the same functionality in our wrapper. Add the const modifier for new_limit, in accordance with the prototype for prlimit(). --- src/util/virprocess.c | 16 ++-- 1 file changed, 10 insertions(+), 6

Re: [libvirt] [perl PATCH] Post-release version bump to 1.3.0

2015-11-24 Thread Pavel Hrdina
On Tue, Nov 24, 2015 at 12:51:47PM +, Daniel P. Berrange wrote: > On Tue, Nov 24, 2015 at 01:41:33PM +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > Makefile.PL | 2 +- > > README | 2 +- > > lib/Sys/Virt.pm | 2 +- > > 3 files changed,

Re: [libvirt] [PATCH 7/8] virsh: extend domstats command

2015-11-24 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:47 +0800, Qiaowei Ren wrote: > This patch extend domstats command to match extended > virDomainListGetStats API in previous patch. > > Signed-off-by: Qiaowei Ren > --- > tools/virsh-domain-monitor.c | 7 +++ > tools/virsh.pod

Re: [libvirt] [PATCH 0/8] Add perf and Intel CMT feature support

2015-11-24 Thread Jiri Denemark
On Tue, Nov 17, 2015 at 16:00:40 +0800, Qiaowei Ren wrote: > The series mainly adds Intel CMT feature support into libvirt. CMT is > new introduced PQos (Platform Qos) feature to monitor the usage of > cache by applications running on the platform. > > Currently CMT patches has been merged into

Re: [libvirt] [PATCH 05/34] conf: Use local copy of maxvcpus in virDomainVcpuParse

2015-11-24 Thread Peter Krempa
On Mon, Nov 23, 2015 at 07:04:43 -0500, John Ferlan wrote: > > > On 11/20/2015 10:21 AM, Peter Krempa wrote: > > Use the local variable rather than getting it all the time from the > > struct. This will simplify further refactors. > > --- > > src/conf/domain_conf.c | 6 +++--- > > 1 file

Re: [libvirt] [PATCH 34/34] qemu: cgroup: Don't use priv->ncpupids to iterate domain vCPUs

2015-11-24 Thread John Ferlan
On 11/20/2015 10:22 AM, Peter Krempa wrote: > Use the proper data structures for the iteration since ncpupids will be > made private later. > --- > src/qemu/qemu_cgroup.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_cgroup.c

[libvirt] [PATCH 0/6] Memory locking limit improvements

2015-11-24 Thread Andrea Bolognani
As noticed by Peter[1], the memory locking limit for the QEMU process is increased before assigning a VFIO device to a guest, but it might not be decreased when returning said device to the host. This series fixes this inconsistent behaviour and cleans up the code a little bit along the way. The

[libvirt] [PATCH 6/6] qemu: Replace Mlock with MemLock in function names

2015-11-24 Thread Andrea Bolognani
MemLock is already used in other modules and, while still an abbreviation, is not ambiguous. --- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_domain.c | 10 +- src/qemu/qemu_domain.h | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_command.c

Re: [libvirt] [PATCH 34/34] qemu: cgroup: Don't use priv->ncpupids to iterate domain vCPUs

2015-11-24 Thread Peter Krempa
On Tue, Nov 24, 2015 at 08:41:53 -0500, John Ferlan wrote: > > > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Use the proper data structures for the iteration since ncpupids will be > > made private later. > > --- > > src/qemu/qemu_cgroup.c | 14 -- > > 1 file changed, 12

[libvirt] [PATCH 3/6] qemu: Add qemuDomainAdjustMaxMemLock()

2015-11-24 Thread Andrea Bolognani
This function detects whether a domain needs RLIMIT_MEMLOCK to be set, and if so, uses an appropriate value. It also stores the original value inside the virDomainObj for the domain so that it can be later restored. --- src/conf/domain_conf.h | 3 +++ src/qemu/qemu_domain.c | 50

[libvirt] [PATCH 4/6] qemu: Use qemuDomainAdjustMaxMemLock()

2015-11-24 Thread Andrea Bolognani
Replace all uses of the qemuDomainRequiresMlock/virProcessSetMaxMemLock combination with the equivalent qemuDomainAdjustMaxMemLock() call. --- src/qemu/qemu_hotplug.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git

[libvirt] [PATCH 2/6] process: Add virProcessGetMaxMemLock()

2015-11-24 Thread Andrea Bolognani
This function can be used to retrieve the current locked memory limit for a process, so that the setting can be later restored. Add a configure check for getrlimit(), which we now use. --- configure.ac | 2 +- src/libvirt_private.syms | 1 + src/util/virprocess.c| 42

[libvirt] [PATCH 5/6] qemu: Reduce memlock limit after detaching hostdev

2015-11-24 Thread Andrea Bolognani
We increase the limit before plugging in a PCI hostdev or a memory module because some memory might need to be locked due to eg. VFIO. Of course we should do the opposite after unplugging a device: this was already the case for memory modules, but not for hostdevs. --- src/qemu/qemu_hotplug.c |