Re: [libvirt] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

On 11/28/2016 11:18 PM, Thomas Monjalon wrote: 2016-11-28 16:28, Maxime Coquelin: On 11/24/2016 04:24 PM, Kavanagh, Mark B wrote: DPDK v16.04 added support for vHost User TSO; as such, by default, TSO is advertised to guest devices as an available feature during feature negotiation with

Re: [libvirt] [PATCH 1/2] qemu: Create hugepage path on per domain basis

On 25.11.2016 09:35, Martin Kletzander wrote: > On Tue, Nov 22, 2016 at 01:45:42PM +0100, Michal Privoznik wrote: >> If you've ever tried running a huge page backed guest under >> different user than root, you probably failed. Problem is even > > Surely you mean different than the default user

[libvirt] [PATCH v2] qemu: Prevent detaching SCSI controller used by hostdev

Consider the following XML snippets: $ cat scsicontroller.xml $ cat scsihostdev.xml If we create a guest that includes the contents of scsihostdev.xml, but forget the virtio-scsi controller described in scsicontroller.xml, one is

Re: [libvirt] [REPOST PATCH v2 6/9] qemu: Add support for parsing iotune group setting

[...] >>> Also, once you do what I'm suggesting, the crash from 6/9 will be resolved, >>> however I still would like to see the @reply structure in >>> qemuDomainGetBlockIoTune initialized properly on the stack. >> >> Weird how that crash happens for you, but not me especially since you >> show

[libvirt] [PATCH 1/2] cpu: Remove useless comments from CPU map

They didn't really help anything. Signed-off-by: Jiri Denemark --- src/cpu/cpu_map.xml | 144 ++-- 1 file changed, 72 insertions(+), 72 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index

[libvirt] [PATCH 0/2] cpu: Add alternative feature spellings to CPU map

Jiri Denemark (2): cpu: Remove useless comments from CPU map cpu: Add alternative feature spellings to CPU map src/cpu/cpu_map.xml | 154 ++-- 1 file changed, 77 insertions(+), 77 deletions(-) -- 2.11.0.rc2 -- libvir-list mailing list

[libvirt] [PATCH 2/2] cpu: Add alternative feature spellings to CPU map

We can't change feature names for compatibility reasons even if they contain typos or other software uses different names for the same features. By adding alternative spellings in our CPU map we at least allow anyone to grep for them and find the correct libvirt's name. Signed-off-by: Jiri

Re: [libvirt] [PATCH] qemu: Prevent detaching SCSI controller used by hostdev

[...] >>> If we attach/create a virtio-scsi hostdev device but forget to include >>> a virtio-scsi controller, one is silently created for us. (See >>> qemuDomainFindOrCreateSCSIDiskController for context.) >> So is this attach/create done to a guest with or without the above >> controller? Is

Re: [libvirt] [PATCH 3/6] qemu: qmp query-cpu-model-expansion command

On 11/28/2016 10:46 AM, Jiri Denemark wrote: +if (!(cpu_props = virJSONValueObjectGetObject(cpu_model, "props"))) I believe this should be if (!(cpu_props = virJSONValueObjectGetArray(cpu_model, "props"))) The JSON data returned by query-cpu-model-expansion doesn't seem to use an

Re: [libvirt] [REPOST PATCH v2 6/9] qemu: Add support for parsing iotune group setting

On Mon, Nov 28, 2016 at 05:14:54PM -0500, John Ferlan wrote: > > [...] > > >> @@ -4535,6 +4535,11 @@ qemuMonitorJSONBlockIoThrottleInfo(virJSONValuePtr > >> result, > >> GET_THROTTLE_STATS_OPTIONAL("iops_rd_max", read_iops_sec_max); > >>

Re: [libvirt] [REPOST PATCH v2 6/9] qemu: Add support for parsing iotune group setting

On Mon, Nov 28, 2016 at 11:28:10AM -0500, John Ferlan wrote: > [...] > > >> BLOCK_IOTUNE_ASSIGN(SIZE_IOPS_SEC, size_iops_sec); > >> > >> +if (*nparams < maxparams && > >> +virTypedParameterAssign([(*nparams)++], > >> +

Re: [libvirt] [PATCH v3] qemu: report block job errors from qemu to the user

ping On 02.11.2016 12:15, Nikolay Shirokovskiy wrote: > So that you can see nice report on migration: > > "error: operation failed: migration of disk sda failed: No space left on > device" > > diff from v2: > 1. split into 2 patches > 2. change formal documentation where it is present

Re: [libvirt] [PATCH] qemuProcessReconnect: Avoid relabeling images after migration

On Wed, Nov 23, 2016 at 14:29:50 +0100, Jiri Denemark wrote: > Restarting libvirtd on the source host at the end of migration when a > domain is already running on the destination would cause image labels to > be reset effectively killing the domain. Commit e8d0166e1d fixed similar > issue on the

Re: [libvirt] [PATCH 5/6] qemu: migration: warn if migrating with host-passthrough

On Mon, Nov 21, 2016 at 14:11:55 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Warn the user when migrating a guest that is using the host-passthrough cpu > mode. host-passthrough is not migration safe because the host hypervisor is > not > attempting

[libvirt] [PATCH v2 3/3] security: Drop virSecurityManagerSetHugepages

Since its introduction in 2012 this internal API did nothing. Moreover we have the same API that does exactly the same: virSecurityManagerDomainSetPathLabel. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms| 1 - src/qemu/qemu_process.c | 4

[libvirt] [PATCH v2 1/3] virDomainObjGetShortName: take virDomainDef

So far this function takes virDomainObjPtr which: 1) is an overkill, 2) might be not available in all the places we will use it. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- src/qemu/qemu_domain.c | 2 +-

[libvirt] [PATCH v2 0/3] Fix case with non-root domain and hugepages

v2 of: https://www.redhat.com/archives/libvir-list/2016-November/msg01060.html diff to v1: - use virDomainObjGetShortName to construct hugepages path - instead of implementing virSecurityManagerSetHugepages drop it Michal Privoznik (3): virDomainObjGetShortName: take virDomainDef qemu:

[libvirt] Entering freeze for 2.5.0

With exception of the patch set of Laine which we will likely push in today or tomorrow. I have made the signed tarball and rpms available at the usual place: ftp://libvirt.org/libvirt/ and also tagged the RC1 in git. This seems to work fine with my minimal testing, but obviously others

Re: [libvirt] [PATCH 6/6] qemu: command: Support new cpu feature argument syntax

On Mon, Nov 21, 2016 at 14:11:56 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Qemu has abandoned the +/-feature syntax in favor of key=value. Some > architectures (s390) do not support +/-feature. So we update libvirt to handle > both formats. > > If

Re: [libvirt] Plan for next release(s)

On Mon, Nov 28, 2016 at 09:06:41PM +0100, Daniel Veillard wrote: > I'm late so I think that if we don't want to slip too much > the best would be to enter freeze tomorrow (Tuesday) then have RC2 > around Thursday and a release over the week-end. > > That said they are supposed to mess with my

Re: [libvirt] Plan for next release(s)

Planning the release before flying, i.e. before you can do anything my bad I was late. Patches 1 and 2 can't seem to be able to introduce regressions. The meat is really into patches 3 and 4. if you and others feel confident about those 2 then have the series pushed between rc1 and rc2, that

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

Hi Christian, Sorry for being sitting on that one. Your v2 looks good to me. ACK from me. -- Cedric On Mon, 2016-11-28 at 13:29 +0100, Christian Ehrhardt wrote: > > On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther wrote: > > This looks good to me (and looks more terse now) .

Re: [libvirt] [PATCH] qemu: Report tunnelled post-copy migration as unsupported

On Tue, Nov 22, 2016 at 20:41:42 +0100, Jiri Denemark wrote: > Post-copy migration needs bi-directional communication between the > source and the destination QEMU processes, which is not supported by > tunnelled migration. > > https://bugzilla.redhat.com/show_bug.cgi?id=1371358 > >

Re: [libvirt] [PATCH 4/6] qemu-caps: Get host model directly from Qemu when available

On Mon, Nov 21, 2016 at 14:11:54 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > When qmp query-cpu-model-expansion is available probe Qemu for its view of the > host model. In kvm environments this can provide a more complete view of the > host model

[libvirt] [PATCH v3 1/4] util: new function virFileLength()

This new function just calls fstat() (if provided with a valid fd) or stat() (if fd is -1) and returns st_size (or -1 if there is an error). We may decide we want this function to be more complex, and handle things like block devices - this is a placeholder (that works) for any more complicated

Re: [libvirt] [PATCH v3 1/4] util: new function virFileLength()

On 11/29/2016 01:23 PM, Laine Stump wrote: > This new function just calls fstat() (if provided with a valid fd) or > stat() (if fd is -1) and returns st_size (or -1 if there is an > error). We may decide we want this function to be more complex, and > handle things like block devices - this is a

[libvirt] [PATCH v2 1/2] conf: Detect misconfiguration between disk bus and disk address

This patch detects a misconfiguration between the disk bus type and disk address type for controller based disk buses (SATA, SCSI, FDC and IDE). The addresses of these bus types are all managed in common code so it's possible to decide in common code whether the disk address and bus type are

[libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

This patch series adds the functionality to detect a misconfiguration between disk bus type and disk address type for disks that are using the address type virDomainDeviceDriveAddress. It also adds a test for it. A check for other bus types may be needed. This may require a driver specific

Re: [libvirt] [PATCH 0/2] qemu: error out on USB ports out of range

On Mon, Nov 28, 2016 at 05:51:44PM +0100, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1399260 > > Ján Tomko (2): > tests: Fix USB ports in usb-redir-filter > qemu: error out on USB ports out of range ACK series and safe for freeze. Erik > > src/conf/domain_addr.c

[libvirt] [PATCH v2 2/2] tests: Add tests for disk configuration validation

Add tests for controller based disks to check disk address compatibility with disk bus types. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk ---

Re: [libvirt] [REPOST PATCH v2 6/9] qemu: Add support for parsing iotune group setting

On 11/29/2016 03:50 AM, Erik Skultety wrote: > On Mon, Nov 28, 2016 at 05:14:54PM -0500, John Ferlan wrote: >> >> [...] >> @@ -4535,6 +4535,11 @@ qemuMonitorJSONBlockIoThrottleInfo(virJSONValuePtr result, GET_THROTTLE_STATS_OPTIONAL("iops_rd_max", read_iops_sec_max);

Re: [libvirt] [PATCH 1/3] Enhance documentation of virDomainMigrateFlags

On Fri, Nov 25, 2016 at 11:51:41 +0100, Jiri Denemark wrote: > The enhanced documentation of VIR_MIGRATE_RDMA_PIN_ALL fixes > https://bugzilla.redhat.com/show_bug.cgi?id=1373783 > > Signed-off-by: Jiri Denemark > --- > include/libvirt/libvirt-domain.h | 153 >

Re: [libvirt] [PATCH 2/3] Consolidate documentation of virDomainMigrate{, ToURI}{, 2, 3}

On Fri, Nov 25, 2016 at 11:51:42 +0100, Jiri Denemark wrote: > Only the latest APIs are fully documented and the documentation of the > older variants (which are just limited versions of the new APIs anyway) > points to the newest APIs. > > Signed-off-by: Jiri Denemark > ---

Re: [libvirt] [PATCH] qemu: Prevent detaching SCSI controller used by hostdev

On 11/28/2016 04:14 PM, John Ferlan wrote: On 11/28/2016 09:01 AM, Eric Farman wrote: Consider a guest started with the following XML snippet: That's an awfully large unit # isn't it? For the guest... Large, yes. Unreasonable, no. This is the

Re: [libvirt] [RFC PATCH 1/1] gluster: cache glfs connection object per volume

On Tue, Nov 15, 2016 at 3:07 PM, Peter Krempa wrote: > On Mon, Nov 14, 2016 at 20:04:16 +0530, Prasanna Kumar Kalever wrote: >> This patch offer, >> 1. Optimizing the calls to glfs_init() and friends >> 2. Temporarily reduce the memory leak appear in libvirt process account,

Re: [libvirt] [REPOST PATCH v2 6/9] qemu: Add support for parsing iotune group setting

On Tue, Nov 29, 2016 at 07:28:51AM -0500, John Ferlan wrote: > > > On 11/29/2016 03:50 AM, Erik Skultety wrote: > > On Mon, Nov 28, 2016 at 05:14:54PM -0500, John Ferlan wrote: > >> > >> [...] > >> > @@ -4535,6 +4535,11 @@ > qemuMonitorJSONBlockIoThrottleInfo(virJSONValuePtr result, >

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

On Mon, Nov 28, 2016 at 01:29:02PM +0100, Christian Ehrhardt wrote: > On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther wrote: > > > This looks good to me (and looks more terse now) . It would be great to > > have another review though. > > > > No other eye looking at it over the

[libvirt] [Question] vhost-user hotplug: multiqueue hotplug seems doesn't pass mq and vectors

Hi ALL: Recently I review the vhost-user hotplug codes, when attach a vhost-user nic with multiqueue, it seems that it doesn't pass mq=on and vectors num to qemu. Is there any special consideration or just a small mistake? Parts of codes: qemuDomainAttachNetDevice(vhostfdSize is 0 when type is

Re: [libvirt] [PATCH 1/2] qemu: Create hugepage path on per domain basis

On Tue, Nov 29, 2016 at 09:28:29AM +0100, Michal Privoznik wrote: On 25.11.2016 09:35, Martin Kletzander wrote: On Tue, Nov 22, 2016 at 01:45:42PM +0100, Michal Privoznik wrote: If you've ever tried running a huge page backed guest under different user than root, you probably failed. Problem

[libvirt] [PATCH] daemon: Install virt-guest-shutdown.target properly

When trying to install libvirtd from sources I've noticed the following failure: /usr/bin/install: cannot stat 'virt-guest-shutdown.target': No such file or directory Makefile:2792: recipe for target 'install-init-systemd' failed make[3]: *** [install-init-systemd] Error 1 make[3]: *** Waiting

Re: [libvirt] [RFC v2 00/20] qmp: Report bus information on 'query-machines'

On Fri, Nov 25, 2016 at 08:05:36PM -0200, Eduardo Habkost wrote: [...] > Example output > -- > > TODO: update it. I've forgot to update it. Here it is: { "return": [ { "cpu-max": 1, "hotpluggable-cpus": false, "name": "none"

Re: [libvirt] [PATCH 2/3] Consolidate documentation of virDomainMigrate{, ToURI}{, 2, 3}

On Tue, Nov 29, 2016 at 13:04:21 +0100, Peter Krempa wrote: > On Fri, Nov 25, 2016 at 11:51:42 +0100, Jiri Denemark wrote: > > Only the latest APIs are fully documented and the documentation of the > > older variants (which are just limited versions of the new APIs anyway) > > points to the newest

Re: [libvirt] [PATCH v2 1/4] util: new function virFileLength()

On 11/20/2016 11:01 PM, Laine Stump wrote: > This new function just calls stat() and returns st_size (or -1 if > there is an error). We may decide we want this function to be more > complex, and handle things like block devices - this is a placeholder > (that works) for any more complicated