Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-05 Thread Laine Stump
(Sorry for any duplicates. I sent it from the wrong address the first time) On 12/01/2016 11:18 PM, David Gibson wrote: On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: On Wed, 2016-11-23 at 16:00 +1100, David Gibson wrote: Existing libvirt versions assume that pseries guests

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-05 Thread Laine Stump
On 12/01/2016 11:18 PM, David Gibson wrote: On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: On Wed, 2016-11-23 at 16:00 +1100, David Gibson wrote: Existing libvirt versions assume that pseries guests have a legacy PCI root bus, and will base their PCI address allocation / PCI

Re: [libvirt] [PATCH] AppArmor: allow QEMU to set_process_name.

2016-12-05 Thread Jamie Strandboge
On Mon, 2016-12-05 at 11:21 +, intrigeri wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1369281 > --- >  examples/apparmor/libvirt-qemu | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu > index 11381d4df0..a07291d583

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-05 Thread David Hildenbrand
Is static really needed? I can understand why migration-safe might be of interest, but can't see how "static" could help (I mean we have static expansion for this purpose). Do you have anything special in mind regarding exposing "static"? I didn't have any specific use case in mind. My main

Re: [libvirt] [PATCH] AppArmor policy: support merged-/usr.

2016-12-05 Thread Jamie Strandboge
On Sat, 2016-12-03 at 18:32 +, intrigeri wrote: > From: intrigeri > > --- >  examples/apparmor/libvirt-qemu   | 8 >  examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 +- >  examples/apparmor/usr.sbin.libvirtd  | 4 ++-- >  3 files

Re: [libvirt] [PATCH v5 0/2] List only online cpus for vcpupin/emulatorpin when vcpu placement static

2016-12-05 Thread Nitesh Konkar
Polite ping. Thanks, Nitesh. On Fri, Nov 25, 2016 at 2:53 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Currently when the vcpu placement is static and > cpuset is not specified, CPU Affinity shows 0.. > CPUMAX. This patchset will result in display of > only online CPU's under

Re: [libvirt] [REPOST PATCH v2 0/9] Add group_name support for

2016-12-05 Thread John Ferlan
On 11/28/2016 09:54 AM, Erik Skultety wrote: > On Mon, Nov 21, 2016 at 06:35:45PM -0500, John Ferlan wrote: >> This is just a REPOST of the v2 series: >> >> http://www.redhat.com/archives/libvir-list/2016-November/msg00363.html >> >> The only difference being updating to the current top of tree

Re: [libvirt] [PATCH v2] storage: vz storage pool support

2016-12-05 Thread John Ferlan
On 12/02/2016 12:09 PM, Olga Krishtal wrote: > On 20/09/16 23:30, John Ferlan wrote: >> >> On 07/14/2016 01:13 PM, Olga Krishtal wrote: >>> This patch supports pool and volume management within Virtuozzo Storage. >>> Virtuozzo Storage is a highly-available distributed software defined >>>

Re: [libvirt] [PATCH] cpu: Add support for pku and ospke Intel features for Memory Protection Keys

2016-12-05 Thread Jiri Denemark
On Fri, Nov 25, 2016 at 16:44:30 +0800, Lin Ma wrote: > qemu commit: f74eefe0 > https://lwn.net/Articles/667156/ > > Signed-off-by: Lin Ma > --- > src/cpu/cpu_map.xml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml >

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-05 Thread Eduardo Habkost
On Mon, Dec 05, 2016 at 07:18:47PM +0100, David Hildenbrand wrote: > Am 02.12.2016 um 22:18 schrieb Eduardo Habkost: > > The query-cpu-model-expand QMP command needs at least one static > > model, to allow the "static" expansion mode to be implemented. > > Instead of defining static versions of

Re: [libvirt] [PATCH] cpu: Add support for more AVX512 Intel features

2016-12-05 Thread Jiri Denemark
On Thu, Nov 24, 2016 at 17:50:08 +0800, Lin Ma wrote: > These features are included: > AVX512DQ, AVX512IFMA, AVX512BW, AVX512VL, AVX512VBMI, AVX512_4VNNIW and > AVX512_4FMAPS. > > qemu commits: cc728d14 and 95ea69fb > > Signed-off-by: Lin Ma > --- > src/cpu/cpu_map.xml | 24

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-05 Thread Eduardo Habkost
On Mon, Dec 05, 2016 at 07:13:36PM +0100, David Hildenbrand wrote: > > > > Is static really needed? I can understand why migration-safe might be > > > of interest, but can't see how "static" could help (I mean we have > > > static expansion for this purpose). Do you have anything special in > > >

[libvirt] [PATCH python] libvirt-override: fix setBlockIoTune failure passed

2016-12-05 Thread xieyingtai
From: Yingtai Xie virDomainGetBlockIoTune() will be called before setBlockIoTune, as a result, it leads to a failure if set flags with VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG which is an reasonable option. Signed-off-by: Yingtai Xie ---

Re: [libvirt] [PATCH] Add support for parsing -vga virtio

2016-12-05 Thread Nehal J Wani
On Fri, Nov 18, 2016 at 12:27 PM, Nehal J Wani wrote: > Since a94f0c5c qemu supports '-vga virtio'. > Libvirt also supports it since 21373feb. > > This patch enables libvirt to parse the qemu-argv: > > virsh domxml-from-native qemu-argv <(echo '/usr/bin/qemu-system-x86_64

[libvirt] [RFC] provide error string on blockjob event

2016-12-05 Thread Nikolay Shirokovskiy
Hi, all. There is a patch series [1] that adds reporting qemu blockjob errors to the client on migration. I guess if somebody uses block{copy/pull/commit} he would be glad to see the precise qemu error too. But these operation are asynchronous and blockjob result is provided via event. So what

Re: [libvirt] [PATCH 0/5] Reject duplicate drive addresses

2016-12-05 Thread Marc Hartmayer
On Mon, Dec 05, 2016 at 11:12 AM +0100, Michal Privoznik wrote: >> ACK series. We are currently in freeze so I will push this after the >> release. Technically this could go in as it is a bug fix, but rather a >> big one so I'd rather push it after the release, if you don't

[libvirt] [PATCH v2 07/10] network: Track MAC address map

2016-12-05 Thread Michal Privoznik
Now that we have a module that's able to track pairs, hook it up into our network driver. Signed-off-by: Michal Privoznik --- src/conf/network_conf.h | 4 ++ src/network/bridge_driver.c | 93 + 2

[libvirt] [PATCH v2 06/10] util: Introduce virMACMap module

2016-12-05 Thread Michal Privoznik
This module will be used to track: pairs. It will be important to know these mappings without libvirt connection (that is from a JSON file), because NSS module will use those to provide better host name translation. Signed-off-by: Michal Privoznik

[libvirt] [PATCH v2 03/10] virstring: Introduce virStringListAdd

2016-12-05 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virstring.c | 34 ++ src/util/virstring.h | 3 +++ tests/virstringtest.c| 42 ++ 4 files changed, 80

[libvirt] [PATCH v2 09/10] nss: Move address appending code into a separate function

2016-12-05 Thread Michal Privoznik
The part of the code that appends found IP address into a list is going to be re-used. Instead of copying it over, move it to a separate function. Signed-off-by: Michal Privoznik --- tools/nss/libvirt_nss.c | 95 - 1 file

[libvirt] [PATCH v2 08/10] nss: Use macro to generate public API names

2016-12-05 Thread Michal Privoznik
The name of the exported functions for an NSS module is quite fixed, it is derived from the module name: _nss_$module_$function Since we will create another NSS module with very similar implementation we might as well generate the function names at the compile time. Signed-off-by: Michal

[libvirt] [PATCH v2 10/10] nss: Introduce libvirt-guest module

2016-12-05 Thread Michal Privoznik
So far the NSS module looks up only hostnames as provided by guests themselves. However, there are some cases where this is not enough: e.g. when there's a fresh new guest being installed (with some generic hostname) say from a live ISO image; or some (older) systems don't advertise their hostname

[libvirt] [PATCH v2 02/10] nssmock: Prefer free() over VIR_FREE()

2016-12-05 Thread Michal Privoznik
Problem with VIR_FREE() is that we are not linking libvirt-utils.so to our mock libs therefore there will be an unresolved symbol. Fortunately, nsstest that eventually links with the nssmock links also with libvirt-utils.so and thus the symbol is resolved after all. However, if one wants to run

[libvirt] [PATCH v2 01/10] network: Don't unlock non-locked network driver

2016-12-05 Thread Michal Privoznik
In dd7bfb2cdc5d I've removed locking of the network driver upon it's allocation. However, I forgot to remove one location of the driver unlock. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[libvirt] [PATCH v2 04/10] virstring: Introduce virStringListRemove

2016-12-05 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virstring.c | 50 ++ src/util/virstring.h | 3 +++ tests/virstringtest.c| 56 4 files changed,

Re: [libvirt] [PATCH v1 00/21] Run qemu under its own namespace

2016-12-05 Thread Michal Privoznik
On 24.11.2016 15:47, Michal Privoznik wrote: > Finally. This is full implementation of my RFC: > > https://www.redhat.com/archives/libvir-list/2016-November/msg00691.html > > The first two patches were posted separately, but since they lack > review I'm sending them here too because they are

Re: [libvirt] [PATCH 0/5] Reject duplicate drive addresses

2016-12-05 Thread Michal Privoznik
On 02.12.2016 17:28, Michal Privoznik wrote: > On 30.11.2016 12:47, Marc Hartmayer wrote: >> Reject duplicate drive addresses at domain definition. Hot-plug for >> disks and hostdevs is still to fix and this is why the old version of >> drive address checking is still there. Additionally, it isn't

Re: [libvirt] [PATCH v2 1/1] gluster: cache glfs connection object per volume

2016-12-05 Thread Prasanna Kalever
On Wed, Nov 30, 2016 at 5:41 PM, Peter Krempa wrote: > On Wed, Nov 30, 2016 at 16:06:37 +0530, prasanna.kale...@redhat.com wrote: >> From: Prasanna Kumar Kalever >> >> This patch optimizes calls to glfs_init() and friends >> >> Currently, a start

[libvirt] [PATCH v2 05/10] util: Introduce virFileRewriteStr

2016-12-05 Thread Michal Privoznik
There are couple of places where we have a string and want to save it to a file. Atomically. In all those places we use virFileRewrite() but also implement the very same callback which takes the string and write it into temp file. This makes no sense. Unify the callbacks and move them to one

[libvirt] [PATCH v2 00/10] Introduce new libvirt-guest NSS module

2016-12-05 Thread Michal Privoznik
v2 of: https://www.redhat.com/archives/libvir-list/2016-November/msg01456.html diff to v1: - New module is created instead of putting everything into already existing one - Few hints from review of v1 were worked in Michal Privoznik (10): network: Don't unlock non-locked network driver

[libvirt] [PATCH] AppArmor: allow QEMU to set_process_name.

2016-12-05 Thread intrigeri
https://bugzilla.redhat.com/show_bug.cgi?id=1369281 --- examples/apparmor/libvirt-qemu | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index 11381d4df0..a07291d583 100644 --- a/examples/apparmor/libvirt-qemu +++

Re: [libvirt] [PATCH v1 09/21] qemu: Spawn qemu under mount namespace

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:58PM +0100, Michal Privoznik wrote: > Prime time. When it comes to spawning qemu process and > relabelling all the devices it's going to touch, there's inherent > race with other applications in the system (e.g. udev). Instead > of trying convincing udev to not touch

[libvirt] [PATCH v3 2/3] storage: optimize calls to virStorageFileInit and friends

2016-12-05 Thread Prasanna Kumar Kalever
Currently, each among virStorageFileGetMetadataRecurse, qemuSecurityChownCallback, qemuDomainSnapshotPrepareDiskExternal and qemuDomainSnapshotCreateSingleDiskActive makes calls to virStorageFileInit and friends for simple operations like stat, read headers, chown and etc. This patch

Re: [libvirt] [PATCH v1 04/21] virfile: Introduce virFileSetupDev

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:53PM +0100, Michal Privoznik wrote: > This part of code that LXC currently uses will be reused so move > to a generic function. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 2 ++ > src/lxc/lxc_container.c | 20

Re: [libvirt] [PATCH v1 08/21] qemu_cgroup: Expose defaultDeviceACL

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:57PM +0100, Michal Privoznik wrote: > This is a list of devices that qemu needs for its run (apart from > what's configured for domain). The devices on the list are > enabled in the CGroups by default so they will be good candidates > for initial /dev for new qemu. >

Re: [libvirt] [PATCH v1 06/21] virusb: Introduce virUSBDeviceGetPath

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:55PM +0100, Michal Privoznik wrote: > We will need this function in near future so that we know what > /dev device corresponds to the USB device. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 1 + > src/util/virusb.c

Re: [libvirt] [PATCH v1 07/21] virscsi: Introduce virSCSIDeviceGetPath

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:56PM +0100, Michal Privoznik wrote: > We will need this function in near future so that we know what > /dev device corresponds to the SCSI device. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 1 + > src/util/virscsi.c

[libvirt] [PATCH v3 1/3] util: change the virStorageNetHostDef type

2016-12-05 Thread Prasanna Kumar Kalever
Currently, the Host object looks like struct _virStorageNetHostDef { char *name; char *port; int transport; /* virStorageNetHostTransport */ char *socket; /* path to unix socket */ } We don't actually need a 'name' and 'port' if the transport type is unix domain

[libvirt] [PATCH v3 0/3] gluster: cache glfs connection object per volume

2016-12-05 Thread Prasanna Kumar Kalever
v3: Address comments by Daniel and Peter on v2 * Split the patch to 3 parts Patch 1: change the virStorageNetHostDef type Patch 2: optimize calls to virStorageFileInit and friends Patch 3: add the caching for glfs * Thanks to Daniel, this version make all the methods as thread safe * Thanks to

[libvirt] [PATCH v3 3/3] gluster: cache glfs connection object per volume

2016-12-05 Thread Prasanna Kumar Kalever
Currently, in case if we have 4 extra attached disks, then for each disk we need to call 'glfs_init' (over network) and friends which could be costly. Additionally snapshot(external) scenario will further complex the situation. This patch maintain a cache of glfs objects per volume, hence the

[libvirt] [PATCH] tests: blacklist gnutls 3.5.6 for wildcard tests

2016-12-05 Thread Daniel P. Berrange
GNUTLS 3.5.6 broke wildcard support by reversing the fields in the reported dname. This regression will be fixed in 3.5.7, so rather than workaround it in libvirt we just blacklist that version https://lists.gnupg.org/pipermail/gnutls-devel/2016-November/008224.html Signed-off-by: Daniel P.

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: > Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs and > virFileCopyACLs. These functions are going to be required when we > are creating /dev for qemu. We have copy anything that's in > host's /dev exactly as is. Including

[libvirt] [PATCH] Deal with gnutls 3.5.6 regression

2016-12-05 Thread Daniel P. Berrange
I was not originally planning to do anything for the gnutls 3.5.6 regression: https://www.redhat.com/archives/libvir-list/2016-November/msg00816.html but there's still no immediate sign of the new 3.5.7 release, so while I still don't want to workaround the bug in libvirt, we can at least

Re: [libvirt] [PATCH v1 03/21] virprocess: Introduce virProcessSetupPrivateMountNS

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:52PM +0100, Michal Privoznik wrote: > This part of code that LXC currently uses will be reused so move > to a generic function. > > Signed-off-by: Michal Privoznik > --- > configure.ac | 2 +- > src/libvirt_private.syms | 1 + >

Re: [libvirt] [PATCH] storage: Fix type PLOOP type check for storageVolUpload

2016-12-05 Thread Erik Skultety
On Fri, Dec 02, 2016 at 03:06:37PM -0500, John Ferlan wrote: > Commit id '03e750f3' added support for checking the PLOOP type; however, > it used 'target.type' which no storage code ever fills in, so it will > never be set. Change to just vol->type (could use vol->target.format > as well). > >

Re: [libvirt] [PATCH] NEWS: Remove end-of-sentence period

2016-12-05 Thread Andrea Bolognani
On Thu, 2016-12-01 at 14:17 +0100, Martin Kletzander wrote: > On Thu, Dec 01, 2016 at 12:25:21PM +0100, Andrea Bolognani wrote: > > > > None of the other sentences in the file ends with the period, > > and we want to maintain a consistent style. > > --- > > Pushed as trivial. > > I pushed one

Re: [libvirt] [PATCH] storage: Fix type PLOOP type check for storageVolUpload

2016-12-05 Thread Olga Krishtal
You are absolutely right.[?] Thanks a lot. From: John Ferlan Sent: Friday, December 2, 2016 11:06:37 PM To: libvir-list@redhat.com Cc: Olga Krishtal Subject: [PATCH] storage: Fix type PLOOP type check for storageVolUpload Commit id

Re: [libvirt] [PATCH v1 16/21] qemu: Enter the namespace on relabelling

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:48:05PM +0100, Michal Privoznik wrote: > Instead of trying to fix our security drivers, we can use a > simple trick to relabel paths in both namespace and the host. > I mean, if we enter the namespace some paths are still shared > with the host so any change done to them

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Michal Privoznik
On 05.12.2016 13:36, Daniel P. Berrange wrote: > On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: >> Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs and >> virFileCopyACLs. These functions are going to be required when we >> are creating /dev for qemu. We have copy

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 02:56:12PM +0100, Michal Privoznik wrote: > On 05.12.2016 13:36, Daniel P. Berrange wrote: > > On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: > >> Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs and > >> virFileCopyACLs. These functions are going

Re: [libvirt] [PATCH v1 09/21] qemu: Spawn qemu under mount namespace

2016-12-05 Thread Michal Privoznik
On 05.12.2016 14:26, Daniel P. Berrange wrote: > On Thu, Nov 24, 2016 at 03:47:58PM +0100, Michal Privoznik wrote: >> Prime time. When it comes to spawning qemu process and >> relabelling all the devices it's going to touch, there's inherent >> race with other applications in the system (e.g.

Re: [libvirt] [PATCH v1 16/21] qemu: Enter the namespace on relabelling

2016-12-05 Thread Michal Privoznik
On 05.12.2016 14:40, Daniel P. Berrange wrote: > On Thu, Nov 24, 2016 at 03:48:05PM +0100, Michal Privoznik wrote: >> Instead of trying to fix our security drivers, we can use a >> simple trick to relabel paths in both namespace and the host. >> I mean, if we enter the namespace some paths are

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Michal Privoznik
On 05.12.2016 15:00, Daniel P. Berrange wrote: > On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: >> Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs and >> virFileCopyACLs. These functions are going to be required when we >> are creating /dev for qemu. We have copy

Re: [libvirt] [PATCH v3 3/3] gluster: cache glfs connection object per volume

2016-12-05 Thread Peter Krempa
On Mon, Dec 05, 2016 at 18:55:19 +0530, Prasanna Kumar Kalever wrote: > Currently, in case if we have 4 extra attached disks, then for each disk > we need to call 'glfs_init' (over network) and friends which could be costly. > > Additionally snapshot(external) scenario will further complex the

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: > Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs and > virFileCopyACLs. These functions are going to be required when we > are creating /dev for qemu. We have copy anything that's in > host's /dev exactly as is. Including

Re: [libvirt] [PATCH v3 2/3] storage: optimize calls to virStorageFileInit and friends

2016-12-05 Thread Peter Krempa
On Mon, Dec 05, 2016 at 18:55:18 +0530, Prasanna Kumar Kalever wrote: > Currently, each among virStorageFileGetMetadataRecurse, > qemuSecurityChownCallback, qemuDomainSnapshotPrepareDiskExternal and > qemuDomainSnapshotCreateSingleDiskActive makes calls to virStorageFileInit > and friends for

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 03:18:29PM +0100, Michal Privoznik wrote: > On 05.12.2016 15:00, Daniel P. Berrange wrote: > > On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: > >> Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs and > >> virFileCopyACLs. These functions are going

Re: [libvirt] [PATCH v1 16/21] qemu: Enter the namespace on relabelling

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 03:14:50PM +0100, Michal Privoznik wrote: > On 05.12.2016 14:40, Daniel P. Berrange wrote: > > On Thu, Nov 24, 2016 at 03:48:05PM +0100, Michal Privoznik wrote: > >> Instead of trying to fix our security drivers, we can use a > >> simple trick to relabel paths in both

Re: [libvirt] [PATCH v1 16/21] qemu: Enter the namespace on relabelling

2016-12-05 Thread Michal Privoznik
On 05.12.2016 15:25, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 03:14:50PM +0100, Michal Privoznik wrote: >> On 05.12.2016 14:40, Daniel P. Berrange wrote: >>> On Thu, Nov 24, 2016 at 03:48:05PM +0100, Michal Privoznik wrote: Instead of trying to fix our security drivers, we can use

Re: [libvirt] [PATCH v1 21/21] qemu: Let users opt-out from containerization

2016-12-05 Thread Daniel P. Berrange
On Thu, Nov 24, 2016 at 03:48:10PM +0100, Michal Privoznik wrote: > Given how intrusive previous patches are, it might happen that > there's a bug or imperfection. Lets give users a way out: if they > set 'containerize' to false in qemu.conf the feature is > suppressed. > > Signed-off-by: Michal

Re: [libvirt] [PATCH v3 1/3] util: change the virStorageNetHostDef type

2016-12-05 Thread Peter Krempa
On Mon, Dec 05, 2016 at 18:55:17 +0530, Prasanna Kumar Kalever wrote: qemuargv2xmltest, qemuxml2argvtest, qemuxml2xmltest, virstoragetest fail after this patch. I did not bother checking further or see the case. Peter signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-05 Thread David Hildenbrand
Am 02.12.2016 um 22:17 schrieb Eduardo Habkost: This series implements query-cpu-model-expansion on target-i386. QAPI / interface changes When implementing this, I have noticed that the "host" CPU model in i386 includes some migration-unsafe features that can't be

Re: [libvirt] [PATCH v2 04/10] virstring: Introduce virStringListRemove

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 11:31:50AM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virstring.c | 50 ++ src/util/virstring.h | 3 +++ tests/virstringtest.c| 56

Re: [libvirt] [PATCH v2 08/10] nss: Use macro to generate public API names

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 11:31:54AM +0100, Michal Privoznik wrote: The name of the exported functions for an NSS module is quite fixed, it is derived from the module name: _nss_$module_$function Since we will create another NSS module with very similar implementation we might as well generate

Re: [libvirt] [PATCH v2 07/10] network: Track MAC address map

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 11:31:53AM +0100, Michal Privoznik wrote: Now that we have a module that's able to track pairs, hook it up into our network driver. Shouldn't networkUpdateState() (or similar) be updated so that we don't loose all the info on daemon restart?

Re: [libvirt] [PATCH v1 05/21] virfile: Introduce ACL helpers

2016-12-05 Thread Michal Privoznik
On 05.12.2016 15:21, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 03:18:29PM +0100, Michal Privoznik wrote: >> On 05.12.2016 15:00, Daniel P. Berrange wrote: >>> On Thu, Nov 24, 2016 at 03:47:54PM +0100, Michal Privoznik wrote: Namely, virFileGetACLs, virFileSetACLs, virFileFreeACLs

Re: [libvirt] [PATCH v2 06/10] util: Introduce virMACMap module

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 11:31:52AM +0100, Michal Privoznik wrote: This module will be used to track: pairs. It will be important to know these mappings without libvirt connection (that is from a JSON file), because NSS module will use those to provide better host

[libvirt] [RFC] phi support in libvirt

2016-12-05 Thread Feng, Shaohe
Hi all: As we are know Intel® Xeon phi targets high-performance computing and other parallel workloads. Now qemu has supported phi virtualization,it is time for libvirt to support phi. Different from the traditional X86 server, There is a special numa node with Multi-Channel DRAM (MCDRAM) on

Re: [libvirt] [PATCH v2 04/10] virstring: Introduce virStringListRemove

2016-12-05 Thread Michal Privoznik
On 05.12.2016 16:23, Martin Kletzander wrote: > On Mon, Dec 05, 2016 at 11:31:50AM +0100, Michal Privoznik wrote: >> Signed-off-by: Michal Privoznik >> --- >> src/libvirt_private.syms | 1 + >> src/util/virstring.c | 50 ++ >>

Re: [libvirt] [PATCH v2 00/10] Introduce new libvirt-guest NSS module

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 11:31:46AM +0100, Michal Privoznik wrote: v2 of: https://www.redhat.com/archives/libvir-list/2016-November/msg01456.html I feel like this can go in if the nits are solved (fixed or explained). So conditional ACK for that. signature.asc Description: Digital signature

Re: [libvirt] [PATCH] AppArmor: allow QEMU to set_process_name.

2016-12-05 Thread Christian Ehrhardt
On Mon, Dec 5, 2016 at 12:21 PM, intrigeri wrote: > + @{PROC}/@{pid}/task/@{tid}/comm rw, > Hi, we have used the following for now that we planned to submit soon: owner @{PROC}/@{pid}/task/[0-9]*/comm rw But I like yours more since you are adding the explicit TID

Re: [libvirt] [PATCH v2 08/10] nss: Use macro to generate public API names

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 04:55:18PM +0100, Martin Kletzander wrote: On Mon, Dec 05, 2016 at 11:31:54AM +0100, Michal Privoznik wrote: The name of the exported functions for an NSS module is quite fixed, it is derived from the module name: _nss_$module_$function Since we will create another

Re: [libvirt] [PATCH v2 07/10] network: Track MAC address map

2016-12-05 Thread Michal Privoznik
On 05.12.2016 16:52, Martin Kletzander wrote: > On Mon, Dec 05, 2016 at 11:31:53AM +0100, Michal Privoznik wrote: >> Now that we have a module that's able to track >> pairs, hook it up into >> our network driver. >> > > Shouldn't networkUpdateState() (or similar) be

Re: [libvirt] [PATCH v2 10/10] nss: Introduce libvirt-guest module

2016-12-05 Thread Martin Kletzander
On Mon, Dec 05, 2016 at 11:31:56AM +0100, Michal Privoznik wrote: So far the NSS module looks up only hostnames as provided by guests themselves. However, there are some cases where this is not enough: e.g. when there's a fresh new guest being installed (with some generic hostname) say from a

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-05 Thread Eduardo Habkost
On Mon, Dec 05, 2016 at 04:15:38PM +0100, David Hildenbrand wrote: > Am 02.12.2016 um 22:17 schrieb Eduardo Habkost: > > This series implements query-cpu-model-expansion on target-i386. > > > > QAPI / interface changes > > > > > > When implementing this, I have noticed