Re: [libvirt] [PATCH V3 2/2] qemu: Allow use of hot plugged host CPUs if no affinity set

2016-12-13 Thread John Ferlan
On 11/25/2016 08:57 AM, Viktor Mihajlovski wrote: > If the cpuset cgroup controller is disabled in /etc/libvirt/qemu.conf > QEMU virtual machines can in principle use all host CPUs, even if they > are hot plugged, if they have no explicit CPU affinity defined. > > However, there's libvirt code

Re: [libvirt] [PATCH 2/4] perf: add stalled_cycles_frontend perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > This patch adds support and documentation > for the stalled_cycles_frontend perf event. > > Signed-off-by: Nitesh Konkar > --- > docs/formatdomain.html.in | 6 ++ > docs/news.html.in

Re: [libvirt] [PATCH 4/4] perf: add ref_cpu_cycles perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > This patch adds support and documentation for > the ref_cpu_cycles perf event. > > Signed-off-by: Nitesh Konkar > --- > docs/formatdomain.html.in | 6 ++ > docs/news.html.in

Re: [libvirt] [PATCH V3 1/2] util: Allow to query the presence of host CPU bitmaps

2016-12-13 Thread John Ferlan
On 11/25/2016 08:57 AM, Viktor Mihajlovski wrote: > The functions to retrieve online and present host CPU information > are only supported on Linux for the time being. > > This leads to runtime errors if these function are used on other > platforms. To avoid that, code in higher levels using

Re: [libvirt] [PATCH 3/4] perf: add stalled_cycles_backend perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > This patch adds support and documentation for > the stalled_cycles_backend perf event. > > Signed-off-by: Nitesh Konkar > --- > docs/formatdomain.html.in | 6 ++ > docs/news.html.in

Re: [libvirt] [PATCH v2 1/5] tests: Check more network XMLs for schema compliance

2016-12-13 Thread Laine Stump
On 12/13/2016 08:52 AM, Jiri Denemark wrote: This revealed bugs in RNG schema for /network/dns/srv. ACK. Signed-off-by: Jiri Denemark --- docs/schemas/network.rng | 8 tests/virschematest.c| 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff

Re: [libvirt] [PATCH 0/4] Add generic perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > Add support and documentation for generic > perf events like bus_cycles, stalled_cycles_frontend, > stalled_cycles_backend and ref_cpu_cycles. > > Nitesh Konkar (4): > perf: add bus_cycles perf event support > perf: add stalled_cycles_frontend

Re: [libvirt] [PATCH v5 1/2] conf: List only online cpus for virsh vcpupin

2016-12-13 Thread John Ferlan
On 11/24/2016 04:55 AM, Nitesh Konkar wrote: > Currently when the vcpu placement is static > and cpuset is not specified, CPU Affinity > under virsh vcpupin shows 0..CPUMAX. This > patchset will result in display of only > online CPU's under CPU Affinity on linux. > > Signed-off-by: Nitesh

Re: [libvirt] [PATCH v5 2/2] conf: List only online cpus for virsh emulatorpin

2016-12-13 Thread John Ferlan
On 11/24/2016 04:55 AM, Nitesh Konkar wrote: > Currently when the vcpu placement is static > and cpuset is not specified, CPU Affinity > under virsh emulatorpin shows 0..CPUMAX. This > patchset will result in display of only > online CPU's under CPU Affinity on linux. > > Signed-off-by: Nitesh

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread David Gibson
On Tue, Dec 13, 2016 at 09:15:37AM -0600, Benjamin Herrenschmidt wrote: > On Tue, 2016-12-13 at 14:25 +0200, Marcel Apfelbaum wrote: > > > > Hrm, the suggestion of providing both a vanilla-PCI and PCI-E host > > > > bridge came up before.  I think one of us spotted a problem with that, > > > > but

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread David Gibson
On Tue, Dec 13, 2016 at 02:25:44PM +0200, Marcel Apfelbaum wrote: > On 12/07/2016 06:42 PM, Andrea Bolognani wrote: > > [Added Marcel to CC] > > > > > Hi, > > Sorry for the late reply. > > > On Wed, 2016-12-07 at 15:11 +1100, David Gibson wrote: > > > > Is the difference between q35 and

Re: [libvirt] [PATCH] formatnetwork: Cleanup /network/ip documentation

2016-12-13 Thread Michal Privoznik
On 13.12.2016 10:11, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > docs/formatnetwork.html.in | 125 > ++--- > 1 file changed, 60 insertions(+), 65 deletions(-) ACK Michal -- libvir-list mailing list

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-13 Thread Markus Armbruster
Eduardo Habkost writes: > Implement query-cpu-model-expansion for target-i386. > > The code needs to be careful to handle non-migration-safe > features ("pmu" and "host-cache-info") according to the expansion > type. > > Cc: libvir-list@redhat.com > Cc: Jiri Denemark

[libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6

2016-12-13 Thread Michal Privoznik
These builds often fails with false positives due to ancient compiler found on this system. For instance it fails to see when symbol is used as a variable and when it is used as a function producing the following warnings: ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat':

[libvirt] [PATCHv4 3/3] qemu: Add args generation for file memory backing

2016-12-13 Thread Jaroslav Safka
This patch add support for file memory backing on numa topology. The specified access mode in memoryBacking can be overriden by specifying token memAccess in numa cell. --- src/qemu/qemu_command.c| 113 ++---

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread Marcel Apfelbaum
On 12/07/2016 06:42 PM, Andrea Bolognani wrote: [Added Marcel to CC] Hi, Sorry for the late reply. On Wed, 2016-12-07 at 15:11 +1100, David Gibson wrote: Is the difference between q35 and pseries guests with respect to PCIe only relevant when it comes to assigned devices, or in general?

Re: [libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6

2016-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2016 at 12:04:17PM +0100, Michal Privoznik wrote: > On 13.12.2016 11:51, Daniel P. Berrange wrote: > > On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote: > >> These builds often fails with false positives due to ancient > >> compiler found on this system. For

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: > Quick interface review only: > > Eduardo Habkost writes: > > > This adds a new command to QMP: query-device-slots. It will allow > > management software to query possible slots where devices can be > >

[libvirt] [libvirt-perl][PATCH] Add PERF_PARAM_BRANCH_MISSES constant

2016-12-13 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- Changes| 1 + Virt.xs| 1 + lib/Sys/Virt/Domain.pm | 7 +++ 3 files changed, 9 insertions(+) diff --git a/Changes b/Changes index b1248c9..ffb1911 100644 --- a/Changes +++ b/Changes @@ -4,6 +4,7 @@

Re: [libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6

2016-12-13 Thread Michal Privoznik
On 13.12.2016 11:51, Daniel P. Berrange wrote: > On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote: >> These builds often fails with false positives due to ancient >> compiler found on this system. For instance it fails to see when >> symbol is used as a variable and when it is used

Re: [libvirt] [PATCH 0/3] network: Add support for local PTR domains

2016-12-13 Thread Jiri Denemark
On Tue, Dec 13, 2016 at 13:28:04 +0100, Jiri Denemark wrote: > I run a system dnsmasq to be able to forward specific DNS requests to > specific servers. And I have it configured for both forward and reverse > lookups. Another dnsmasq is started for a virtual network with domain > "virt". The

[libvirt] [PATCH] formatnetwork: Cleanup /network/ip documentation

2016-12-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- docs/formatnetwork.html.in | 125 ++--- 1 file changed, 60 insertions(+), 65 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index cc7d7c7e7..9cf940052 100644 ---

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Markus Armbruster
Quick interface review only: Eduardo Habkost writes: > This adds a new command to QMP: query-device-slots. It will allow > management software to query possible slots where devices can be > plugged. > > This implementation of the command will return: > > * Multiple PCI

[libvirt] [PATCHv4 2/3] conf: Add new xml elements for file memorybacking support

2016-12-13 Thread Jaroslav Safka
This first change introduces new xml elements for file based memorybacking support and their parsing. It allows vhost-user to be used without hugepages. New xml elements: --- docs/formatdomain.html.in | 9 ++ docs/schemas/domaincommon.rng

[libvirt] [PATCHv4 1/3] qemu, conf: Rename virNumaMemAccess to virDomainMemoryAccess

2016-12-13 Thread Jaroslav Safka
Rename to avoid duplicate code. Because virDomainMemoryAccess will be used in memorybacking for setting default behaviour. NOTE: The enum cannot be moved to qemu/domain_conf because of headers dependency --- src/conf/numa_conf.c| 15 --- src/conf/numa_conf.h| 14

[libvirt] [PATCHv4 0/3] Add support for file memorybacking

2016-12-13 Thread Jaroslav Safka
Hi, we would like to introduce 3 new elements source,access and allocation in memoryBacking element. For now it was made for numa topology. If allocation is immediate then -mem-prealloc should be added to the qemu commanline. If source is file then -object

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 14/17] qapi: add static/migration-safe info to query-cpu-model-expansion

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 10:47:38AM +0100, Markus Armbruster wrote: > I'm not familiar with CPU model expansion, but here goes anyway. > > Eduardo Habkost writes: > > > On x86, "-cpu host" enables some features that can't be > > represented by a static CPU model definition:

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 14/17] qapi: add static/migration-safe info to query-cpu-model-expansion

2016-12-13 Thread Markus Armbruster
I'm not familiar with CPU model expansion, but here goes anyway. Eduardo Habkost writes: > On x86, "-cpu host" enables some features that can't be > represented by a static CPU model definition: cache info > passthrough ("host-cache-info") and PMU passthrough ("pmu"). This

Re: [libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6

2016-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote: > These builds often fails with false positives due to ancient > compiler found on this system. For instance it fails to see when > symbol is used as a variable and when it is used as a function > producing the following warnings: >

Re: [libvirt] [libvirt-perl][PATCH] Add PERF_PARAM_BRANCH_MISSES constant

2016-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2016 at 11:58:49AM +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes| 1 + > Virt.xs| 1 + > lib/Sys/Virt/Domain.pm | 7 +++ > 3 files changed, 9 insertions(+) ACK Regards, Daniel -- |:

Re: [libvirt] [PATCH RFC] libxl: reverse defaults on HVM net device attach

2016-12-13 Thread Joao Martins
On 12/13/2016 03:24 AM, Jim Fehlig wrote: > On 12/09/2016 04:35 AM, Joao Martins wrote: >> libvirt libxl picks its own default with respect to the default NIC >> to use. libxlMakeNic is the one responsible for this and on boot it >> picks LIBXL_NIC_TYPE_VIF_IOEMU such that it accomodates both PV

[libvirt] [PATCH 1/3] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-13 Thread Jiri Denemark
Iterating over all child nodes when we only support one instance of each child is pretty weired. And it would even cause memory leaks if more than one element was specified. Signed-off-by: Jiri Denemark --- src/conf/network_conf.c | 36 ++--

[libvirt] [PATCH 2/3] util: Introduce virSocketAddrPTRDomain

2016-12-13 Thread Jiri Denemark
The API creates PTR domain which corresponds to a given addr/prefix. Both IPv4 and IPv6 addresses are supported, but the prefix must be divisible by 8 for IPv4 and divisible by 4 for IPv6. The generated PTR domain has the following format IPv4: 1.2.3.4.in-addr.arpa IPv6:

Re: [libvirt] [PATCH 00/11] Allow creation of vHBA by parent_wwnn/wwpn or fabric_name

2016-12-13 Thread John Ferlan
On 12/12/2016 07:50 PM, Jim Fehlig wrote: > On 12/03/2016 07:09 AM, John Ferlan wrote: >> >> ping? > > Sorry, I seem to have lost your initial cover letter so responding here... > >> >> On 11/18/2016 09:26 AM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1349696 >>> >>>

[libvirt] [PATCH 3/3] network: Add support for local PTR domains

2016-12-13 Thread Jiri Denemark
Similarly to localOnly DNS domain, local PTR domains can be used to tell the DNS server not to forward reverse lookups for unknown IPs which belong to the virtual network. Signed-off-by: Jiri Denemark --- docs/formatnetwork.html.in | 37 ++---

[libvirt] [PATCH 0/3] network: Add support for local PTR domains

2016-12-13 Thread Jiri Denemark
I run a system dnsmasq to be able to forward specific DNS requests to specific servers. And I have it configured for both forward and reverse lookups. Another dnsmasq is started for a virtual network with domain "virt". The system dnsmasq knows it needs to forward any requests for the "virt"

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 04:15:18PM +0200, Marcel Apfelbaum wrote: > On 12/13/2016 02:42 PM, Eduardo Habkost wrote: > > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: > > > Quick interface review only: > > > > > > Eduardo Habkost writes: > > > > > > >

Re: [libvirt] [PATCH 04/11] nodedev: Add the ability to create vHBA by parent wwnn/wwpn or fabric_wwn

2016-12-13 Thread Boris Fiuczynski
John, I have a concern regarding usage of the parent_fabric_name. As far I have been told there are a lot of fc_host attributes in Linux that are optional and left to the low-level driver to decide if implemented. fabric_name apparently happens to be one of these attributes and I know an

[libvirt] [PATCH 1/4] perf: add bus_cycles perf event support

2016-12-13 Thread Nitesh Konkar
This patch adds support and documentation for the bus_cycles perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 3 ++- docs/schemas/domaincommon.rng | 1

[libvirt] [PATCH 4/4] perf: add ref_cpu_cycles perf event support

2016-12-13 Thread Nitesh Konkar
This patch adds support and documentation for the ref_cpu_cycles perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 4 ++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH 2/4] perf: add stalled_cycles_frontend perf event support

2016-12-13 Thread Nitesh Konkar
This patch adds support and documentation for the stalled_cycles_frontend perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 6 +++--- docs/schemas/domaincommon.rng

[libvirt] [PATCH 0/4] Add generic perf event support

2016-12-13 Thread Nitesh Konkar
Add support and documentation for generic perf events like bus_cycles, stalled_cycles_frontend, stalled_cycles_backend and ref_cpu_cycles. Nitesh Konkar (4): perf: add bus_cycles perf event support perf: add stalled_cycles_frontend perf event support perf: add stalled_cycles_backend perf

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Marcel Apfelbaum
On 12/13/2016 02:42 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: Quick interface review only: Eduardo Habkost writes: This adds a new command to QMP: query-device-slots. It will allow management software to query possible

Re: [libvirt] [PATCH v2 08/10] virt-admin: Wire-up the logging APIs

2016-12-13 Thread John Ferlan
On 12/13/2016 09:32 AM, Erik Skultety wrote: > On Mon, Dec 12, 2016 at 11:21:08AM -0500, John Ferlan wrote: >> >> >> On 12/12/2016 10:42 AM, Erik Skultety wrote: >>> On Fri, Dec 09, 2016 at 07:29:36AM -0500, John Ferlan wrote: On 11/25/2016 08:12 AM, Erik Skultety wrote: >

Re: [libvirt] [PATCH] AppArmor: allow QEMU to set_process_name.

2016-12-13 Thread Daniel P. Berrange
On Mon, Dec 12, 2016 at 04:04:34PM +0100, Martin Kletzander wrote: > On Mon, Dec 12, 2016 at 02:09:52PM +, Daniel P. Berrange wrote: > > On Mon, Dec 12, 2016 at 02:53:02PM +0100, Christian Ehrhardt wrote: > > > Acked-by: Christian Ehrhardt > > > > > > That

Re: [libvirt] [PATCH v2 08/10] virt-admin: Wire-up the logging APIs

2016-12-13 Thread Erik Skultety
On Mon, Dec 12, 2016 at 11:21:08AM -0500, John Ferlan wrote: > > > On 12/12/2016 10:42 AM, Erik Skultety wrote: > > On Fri, Dec 09, 2016 at 07:29:36AM -0500, John Ferlan wrote: > >> > >> > >> On 11/25/2016 08:12 AM, Erik Skultety wrote: > >>> Finally, now that all APIs have been introduced, wire

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread Greg Kurz
On Tue, 13 Dec 2016 14:25:44 +0200 Marcel Apfelbaum wrote: > >> Now... from what Laine was saying it sounds like more of the > >> differences between PCI-E placement and PCI placement may be > >> implemented by libvirt than qemu than I realized. So possibly we do > >> want to

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 11:16:01AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Implement query-cpu-model-expansion for target-i386. > > > > The code needs to be careful to handle non-migration-safe > > features ("pmu" and "host-cache-info") according to

[libvirt] [PATCH v2 1/5] tests: Check more network XMLs for schema compliance

2016-12-13 Thread Jiri Denemark
This revealed bugs in RNG schema for /network/dns/srv. Signed-off-by: Jiri Denemark --- docs/schemas/network.rng | 8 tests/virschematest.c| 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng

[libvirt] [PATCH v2 4/5] util: Introduce virSocketAddrPTRDomain

2016-12-13 Thread Jiri Denemark
The API creates PTR domain which corresponds to a given addr/prefix. Both IPv4 and IPv6 addresses are supported, but the prefix must be divisible by 8 for IPv4 and divisible by 4 for IPv6. The generated PTR domain has the following format IPv4: 1.2.3.4.in-addr.arpa IPv6:

[libvirt] [PATCH v2 3/5] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-13 Thread Jiri Denemark
Iterating over all child nodes when we only support one instance of each child is pretty weired. And it would even cause memory leaks if more than one element was specified. Signed-off-by: Jiri Denemark --- src/conf/network_conf.c | 36 ++--

[libvirt] [PATCH v2 2/5] schema: Let elements in /network/ip be specified in any order

2016-12-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- docs/schemas/network.rng| 80 + tests/networkxml2confdata/dhcp6-nat-network.xml | 2 +- tests/networkxml2confdata/netboot-network.xml | 2 +- 3 files changed, 44 insertions(+), 40

[libvirt] [PATCH v2 0/5] network: Add support for local PTR domains

2016-12-13 Thread Jiri Denemark
I run a system dnsmasq to be able to forward specific DNS requests to specific servers. And I have it configured for both forward and reverse lookups. Another dnsmasq is started for a virtual network with domain "virt". The system dnsmasq knows it needs to forward any requests for the "virt"

[libvirt] [PATCH v2 5/5] network: Add support for local PTR domains

2016-12-13 Thread Jiri Denemark
Similarly to localOnly DNS domain, local PTR domains can be used to tell the DNS server not to forward reverse lookups for unknown IPs which belong to the virtual network. Signed-off-by: Jiri Denemark --- docs/formatnetwork.html.in | 37 ++---

[libvirt] [PATCH] Point to the new libvirt-go bindings

2016-12-13 Thread Daniel P. Berrange
The github.com/rgbkrk/libvirt-go bindings were the most complete bindings historically, but their API coverage stops at 1.2.4, with exception of a couple of newer APIs. The new bindings at http://libvirt.org/git/?p=libvirt-go.git;a=log how have (almost[1]) 100% API coverage all the way to 2.5.0.

Re: [libvirt] [PATCH 0/4] Add generic perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:11 AM, John Ferlan wrote: > > > On 12/13/2016 11:01 AM, Nitesh Konkar wrote: >> Add support and documentation for generic >> perf events like bus_cycles, stalled_cycles_frontend, >> stalled_cycles_backend and ref_cpu_cycles. >> >> Nitesh Konkar (4): >> perf: add bus_cycles

Re: [libvirt] [PATCH] qemu: Fix virQEMUCapsFindTarget on ppc64le

2016-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2016 at 05:21:24PM +0100, Jiri Denemark wrote: > virQEMUCapsFindTarget is supposed to find an alternative QEMU binary if > qemu-system-$GUEST_ARCH doesn't exist. The alternative is using host > architecture when it is compatible with $GUEST_ARCH. But a special > treatment has to be

[libvirt] [PATCH python] HACKING: fix grammar

2016-12-13 Thread Cole Robinson
From: Prabodh Agarwal --- Pushed as trivial. This was submitted on github, and since it's trivial I just pushed it, but I pointed the user at the hacking guidelines for future submissions

[libvirt] [PATCH 3/4] perf: add stalled_cycles_backend perf event support

2016-12-13 Thread Nitesh Konkar
This patch adds support and documentation for the stalled_cycles_backend perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.html.in | 3 ++- docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH RFC] libxl: reverse defaults on HVM net device attach

2016-12-13 Thread Jim Fehlig
Joao Martins wrote: > On 12/13/2016 03:24 AM, Jim Fehlig wrote: >> On 12/09/2016 04:35 AM, Joao Martins wrote: >>> libvirt libxl picks its own default with respect to the default NIC >>> to use. libxlMakeNic is the one responsible for this and on boot it >>> picks LIBXL_NIC_TYPE_VIF_IOEMU such

Re: [libvirt] [PATCH 0/4] Add generic perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > Add support and documentation for generic > perf events like bus_cycles, stalled_cycles_frontend, > stalled_cycles_backend and ref_cpu_cycles. > > Nitesh Konkar (4): > perf: add bus_cycles perf event support > perf: add stalled_cycles_frontend

[libvirt] [PATCH] qemu: Fix virQEMUCapsFindTarget on ppc64le

2016-12-13 Thread Jiri Denemark
virQEMUCapsFindTarget is supposed to find an alternative QEMU binary if qemu-system-$GUEST_ARCH doesn't exist. The alternative is using host architecture when it is compatible with $GUEST_ARCH. But a special treatment has to be applied for ppc64le since the QEMU binary is always called

Re: [libvirt] [PATCH v2 08/10] virt-admin: Wire-up the logging APIs

2016-12-13 Thread Erik Skultety
On Tue, Dec 13, 2016 at 09:50:49AM -0500, John Ferlan wrote: > > > On 12/13/2016 09:32 AM, Erik Skultety wrote: > > On Mon, Dec 12, 2016 at 11:21:08AM -0500, John Ferlan wrote: > >> > >> > >> On 12/12/2016 10:42 AM, Erik Skultety wrote: > >>> On Fri, Dec 09, 2016 at 07:29:36AM -0500, John Ferlan

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread Benjamin Herrenschmidt
On Tue, 2016-12-13 at 14:25 +0200, Marcel Apfelbaum wrote: > > > Hrm, the suggestion of providing both a vanilla-PCI and PCI-E host > > > bridge came up before.  I think one of us spotted a problem with that, > > > but I don't recall what it was now.  I guess one is how libvirt would > > > map

[libvirt] [PATCH 0/2] Fix copy-pasta errors in config loading for aux daemons

2016-12-13 Thread Peter Krempa
Apparently the option is not configured very often since nobody figured it out until now. Peter Krempa (2): lock: Fix loading of config file for the lock daemon log: Fix loading of conf file for log daemon src/locking/lock_daemon_config.c | 2 +- src/logging/log_daemon_config.c | 2 +- 2

[libvirt] [PATCH 1/2] lock: Fix loading of config file for the lock daemon

2016-12-13 Thread Peter Krempa
'log_outputs' would be read into the variable for log_filters --- src/locking/lock_daemon_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locking/lock_daemon_config.c b/src/locking/lock_daemon_config.c index 9362b2b74..20824b870 100644 ---

[libvirt] [PATCH 2/2] log: Fix loading of conf file for log daemon

2016-12-13 Thread Peter Krempa
'log_outputs' would be read into the variable for log_filters --- src/logging/log_daemon_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c index 10b42e912..cf58e6230 100644 ---

Re: [libvirt] [PATCH] qemu: Fix virQEMUCapsFindTarget on ppc64le

2016-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2016 at 04:23:48PM +, Daniel P. Berrange wrote: > On Tue, Dec 13, 2016 at 05:21:24PM +0100, Jiri Denemark wrote: > > virQEMUCapsFindTarget is supposed to find an alternative QEMU binary if > > qemu-system-$GUEST_ARCH doesn't exist. The alternative is using host > > architecture

Re: [libvirt] [PATCH v2 08/10] virt-admin: Wire-up the logging APIs

2016-12-13 Thread John Ferlan
On 12/13/2016 11:43 AM, Erik Skultety wrote: > On Tue, Dec 13, 2016 at 09:50:49AM -0500, John Ferlan wrote: >> >> >> On 12/13/2016 09:32 AM, Erik Skultety wrote: >>> On Mon, Dec 12, 2016 at 11:21:08AM -0500, John Ferlan wrote: On 12/12/2016 10:42 AM, Erik Skultety wrote: > On

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-13 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Dec 13, 2016 at 11:16:01AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Implement query-cpu-model-expansion for target-i386. >> > >> > The code needs to be careful to handle non-migration-safe >>

Re: [libvirt] [PATCH 04/11] nodedev: Add the ability to create vHBA by parent wwnn/wwpn or fabric_wwn

2016-12-13 Thread John Ferlan
On 12/13/2016 10:58 AM, Boris Fiuczynski wrote: > John, > I have a concern regarding usage of the parent_fabric_name. > As far I have been told there are a lot of fc_host attributes in Linux > that are optional and left to the low-level driver to decide if > implemented. fabric_name apparently

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: >> Quick interface review only: >> >> Eduardo Habkost writes: >> >> > This adds a new command to QMP: query-device-slots. It will allow >> > management

[libvirt] [PATCH] qemu: Adjust qemuDomainGetBlockInfo data for sparse backed files

2016-12-13 Thread John Ferlan
According to commit id '0282ca45a' the 'physical' value should essentially be the last offset of the image or the host physical size in bytes of the image container. However, commit id '15fa84ac' refactored the GetBlockInfo to use the same returned data as the GetStatsBlock API for an active

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: > >> Quick interface review only: > >> > >> Eduardo Habkost writes: > >> > >> > This

[libvirt] [PATCH 0/3] Get the voldef target physical value

2016-12-13 Thread John Ferlan
This effort started primarily to address some ideas/thoughts brought up in https://bugzilla.redhat.com/show_bug.cgi?id=1332019 although as things were updated, it seems that using storage volume definitions wouldn't be necessary since the same data can be obtained via the virDomainGetBlockInfo

[libvirt] [PATCH 2/3] storage: Introduce virStorageVolInfoFlags

2016-12-13 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1332019 This function will essentially be a wrapper to virStorageVolInfo in order to provide a mechanism to have the "physical" size of the volume returned instead of the "allocation" size. This will provide similar capabilities to the

[libvirt] [PATCH 3/3] virsh: Allow display of the physical volume size

2016-12-13 Thread John Ferlan
Add a new qualifier '--physical' to the 'vol-info' command in order to dispaly the physical size of the volume. The size can differ from the allocation value depending on the volume file time. In particular, qcow2 volumes will have a physical value larger than allocation. This also occurs for

[libvirt] [PATCH 1/3] conf: Display in output of voldef

2016-12-13 Thread John Ferlan
Although the virStorageBackendUpdateVolTargetInfo will update the target.physical value, there is no way to provide that information via the virStorageGetVolInfo API since it only returns the capacity and allocation of a volume. So as described in commit id '0282ca45', it should be possible to

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 08:20:39PM +0100, Markus Armbruster wrote: [...] > >> > +if (type == CPU_MODEL_EXPANSION_TYPE_STATIC) { > >> > +/* static expansion force migration-unsafe features off: */ > >> > +ret->q_static = ret->migration_safe = true; > >> > +

Re: [libvirt] [PATCH 0/2] Fix copy-pasta errors in config loading for aux daemons

2016-12-13 Thread Jiri Denemark
On Tue, Dec 13, 2016 at 18:37:21 +0100, Peter Krempa wrote: > Apparently the option is not configured very often since nobody figured it out > until now. > > Peter Krempa (2): > lock: Fix loading of config file for the lock daemon > log: Fix loading of conf file for log daemon > >

[libvirt] [PATCH] docs: Update formatstorage to match code for pool path

2016-12-13 Thread John Ferlan
Seems commit id '0257d06b' forgot to include formatstorage when updating the docs to describe allowing zfs as a pool type and to furthermore note that the pool's target path element will be generated rather than read. Similarly commit id 'efab27afb' neglected to indicate that the target path for

Re: [libvirt] [PATCH] qemu: Fix virQEMUCapsFindTarget on ppc64le

2016-12-13 Thread Jiri Denemark
On Tue, Dec 13, 2016 at 16:25:22 +, Daniel P. Berrange wrote: > On Tue, Dec 13, 2016 at 04:23:48PM +, Daniel P. Berrange wrote: > > On Tue, Dec 13, 2016 at 05:21:24PM +0100, Jiri Denemark wrote: > > > virQEMUCapsFindTarget is supposed to find an alternative QEMU binary if > > >

Re: [libvirt] [PATCH 1/4] perf: add bus_cycles perf event support

2016-12-13 Thread John Ferlan
On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > This patch adds support and documentation > for the bus_cycles perf event. > > Signed-off-by: Nitesh Konkar > --- > docs/formatdomain.html.in | 6 ++ > docs/news.html.in