Hi guys,
Does anyone have any comments ? :)
--
Regards,
Longpeng(Mike)
On 2017/1/11 16:28, Longpeng(Mike) wrote:
> As virtio-crypto has been supported in QEMU 2.8 and the frontend
> driver has been merged in linux 4.10, so it's necessary to support
> virtio-crypto in libvirt.
>
> ---
>
On Thu, Feb 02, 2017 at 08:57:53PM +0100, Martin Kletzander wrote:
On Thu, Feb 02, 2017 at 03:09:15PM +, Daniel P. Berrange wrote:
On Thu, Feb 02, 2017 at 03:11:56PM +0100, Martin Kletzander wrote:
On Fri, Jan 20, 2017 at 10:42:42AM +0100, Michal Privoznik wrote:
> We will need to traverse
On Tue, Feb 07, 2017 at 02:43:04PM +0800, Eli Qiao wrote:
> On Tuesday, 7 February 2017 at 12:17 AM, Daniel P. Berrange wrote:
>
> > On Mon, Feb 06, 2017 at 10:23:39AM +0800, Eli Qiao wrote:
> > > virResCtrlSetCacheBanks: Set cache banks of a libvirt domain. It will
> > > create new resource
On Fri, Jan 20, 2017 at 10:42:47AM +0100, Michal Privoznik wrote:
Imagine you have a disk with the following source set up:
/dev/disk/by-uuid/$uuid (symlink to) -> /dev/sda
After cbc45525cb21 the transitive end of the symlink chain is
created (/dev/sda), but we need to create any item in chain
On 02/02/2017 04:03 PM, Martin Kletzander wrote:
> On Fri, Jan 20, 2017 at 10:42:45AM +0100, Michal Privoznik wrote:
>> The idea is to move all the seclabel setting to security driver.
>> Having the relabel code spread all over the place looks very
>> messy.
>>
>> Signed-off-by: Michal Privoznik
On Tue, Feb 07, 2017 at 02:43:17PM +0800, Eli Qiao wrote:
> On Tuesday, 7 February 2017 at 12:11 AM, Daniel P. Berrange wrote:
>
> > On Mon, Feb 06, 2017 at 10:23:36AM +0800, Eli Qiao wrote:
> > > This patch adds some utils struct and functions to expose resctrl
> > > information.
> > >
> > >
On Tue, Feb 07, 2017 at 02:43:13PM +0800, Eli Qiao wrote:
> > 3) CDP / non-CDP convertion.
> >
> > In case the size determination has been performed with non-CDP,
> > to emulate such allocation on a CDP host,
> > it would be good to allow both code and data allocations to share
> > the CBM
On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote:
[...]
> + However, as this doesn't match libvirt's understanding of
> + disk addresses, it was changed for the bhyve driver
"it was changed for the bhyve driver"
→ "the bhyve driver was changed"
Sorry for not
On Fri, Jan 20, 2017 at 10:42:46AM +0100, Michal Privoznik wrote:
After previous commit this has become redundant step.
Also setting up devices in namespace and setting their label
later on are two different steps and should be not done at once.
Signed-off-by: Michal Privoznik
On 02/07/2017 10:59 AM, Martin Kletzander wrote:
> On Fri, Jan 20, 2017 at 10:42:46AM +0100, Michal Privoznik wrote:
>> After previous commit this has become redundant step.
>> Also setting up devices in namespace and setting their label
>> later on are two different steps and should be not done
On 02/06/2017 11:08 PM, Jim Fehlig wrote:
> When a user does not explicitly set a in the disk config,
> libvirt defers selection of a default to libxl. This approach works
> fine when starting a domain with such configuration or attaching a
> disk to a running domain. But when detaching such a
On 02/06/2017 08:18 PM, Jim Fehlig wrote:
> Michal Privoznik wrote:
>> ==11260== 1,006 bytes in 1 blocks are definitely lost in loss record 106 of
>> 111
>> ==11260==at 0x4C2AE5F: malloc (vg_replace_malloc.c:297)
>> ==11260==by 0x4C2BDFF: realloc (vg_replace_malloc.c:693)
>> ==11260==
From: Chen Hanxiao
This patch introduces QEMU_CAPS_SD_CARD for probing
whether qemu support SD card by:
{"execute": "device-list-properties",
"arguments":{"typename":"sd-card"}}
It will be helpful for apps which used
cmd 'virsh domcaps` etc.
Also helpful for:
On Tue, Feb 07, 2017 at 08:43:56AM +0100, Jiri Denemark wrote:
> On Mon, Feb 06, 2017 at 18:29:59 +0100, Andrea Bolognani wrote:
> > In order for memory locking to work, the hard limit on memory
> > locking (and usage) has to be set appropriately by the user.
> >
> > The documentation mentions
On 02/07/2017 11:57 AM, Martin Kletzander wrote:
> On Fri, Jan 20, 2017 at 10:42:49AM +0100, Michal Privoznik wrote:
>> Similarly to one of the previous commits, we need to deal
>> properly with symlinks in hotplug case too.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>>
On Wed, Jan 11, 2017 at 04:28:25PM +0800, Longpeng(Mike) wrote:
This patch implements support for the virtio-crypto-pci device
and the builtin backend in qemu.
Two capabilities bits are added to track support for those:
QEMU_CAPS_DEVICE_VIRTIO_CRYPTO - for the device support and
ping?
tks -
John
On 01/25/2017 03:27 PM, John Ferlan wrote:
> Don't be scared off by the quantity of patches...
>
> There's quite a bit of code motion and function renaming going on before
> being able to more easily add tests that will ensure that from a nodedev
> perspective creation and
On Tue, Feb 07, 2017 at 07:56:29 -0500, Kothapally Madhu Pavan wrote:
> This patch will prevent guest to start when the maximum
> vcpus are greater than cpu topology limit. Currently similar
> checks do exist only during setvcpus. The patch adds the
> missing check. The c9cb35c255222 reverted
On 02/07/2017 11:34 AM, Martin Kletzander wrote:
> On Fri, Jan 20, 2017 at 10:42:48AM +0100, Michal Privoznik wrote:
>> When working with symlinks it is fairly easy to get into a loop.
>> Don't.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/qemu/qemu_domain.c | 28
Although currently this is documented in virsh man page
and virsh help, the expicit mention in the error message
is helful for tools using the API directly.
Signed-off-by: Nitesh Konkar
---
src/util/virnodesuspend.c | 4 +++-
1 file changed, 3 insertions(+), 1
On Fri, Jan 20, 2017 at 10:42:48AM +0100, Michal Privoznik wrote:
When working with symlinks it is fairly easy to get into a loop.
Don't.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 28
1 file changed, 24 insertions(+), 4
On 01/20/2017 10:42 AM, Michal Privoznik wrote:
> The major problem was with symlinks. Imagine the following chain of symlinks:
>
> /dev/my_awesome_disk -> /home/user/blaah -> /dev/disk/by-uuid/$uuid ->
> /dev/sda
>
> We really need to create all those /dev/* symlinks and /dev/sda device. Also,
On Tue, Feb 07, 2017 at 07:56:29AM -0500, Kothapally Madhu Pavan wrote:
> This patch will prevent guest to start when the maximum
> vcpus are greater than cpu topology limit. Currently similar
> checks do exist only during setvcpus. The patch adds the
> missing check. The c9cb35c255222 reverted
--
Eli Qiao
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Tuesday, 7 February 2017 at 6:15 PM, Daniel P. Berrange wrote:
> On Tue, Feb 07, 2017 at 02:43:04PM +0800, Eli Qiao wrote:
> > On Tuesday, 7 February 2017 at 12:17 AM, Daniel P. Berrange wrote:
> >
> > > On Mon, Feb 06,
On Fri, Jan 20, 2017 at 10:42:50AM +0100, Michal Privoznik wrote:
When working with symlinks it is fairly easy to get into a loop.
Don't.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 32 +++-
1 file changed, 27 insertions(+), 5
On Fri, Jan 20, 2017 at 10:42:49AM +0100, Michal Privoznik wrote:
Similarly to one of the previous commits, we need to deal
properly with symlinks in hotplug case too.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 120
On Tue, Feb 07, 2017 at 11:02:09AM +0100, Michal Privoznik wrote:
On 02/02/2017 04:03 PM, Martin Kletzander wrote:
On Fri, Jan 20, 2017 at 10:42:45AM +0100, Michal Privoznik wrote:
The idea is to move all the seclabel setting to security driver.
Having the relabel code spread all over the
On Tue, Feb 07, 2017 at 10:17:37AM +, Daniel P. Berrange wrote:
> On Tue, Feb 07, 2017 at 02:43:13PM +0800, Eli Qiao wrote:
> > > 3) CDP / non-CDP convertion.
> > >
> > > In case the size determination has been performed with non-CDP,
> > > to emulate such allocation on a CDP host,
> > > it
On Wed, Jan 11, 2017 at 04:28:24PM +0800, Longpeng(Mike) wrote:
This patch parse the domain XML with virtio-crypto
support, the virtio-crypto XML looks like this:
Signed-off-by: Longpeng(Mike)
---
src/conf/domain_conf.c | 213
This patch will prevent guest to start when the maximum
vcpus are greater than cpu topology limit. Currently similar
checks do exist only during setvcpus. The patch adds the
missing check. The c9cb35c255222 reverted similar check to
avoid older configs from vanishing. The current patch adds
it in
In order for memory locking to work, the hard limit on memory
locking (and usage) has to be set appropriately by the user.
The documentation mentions the requirement already: with this
patch, it's going to be enforced by runtime checks as well,
by forbidding a non-compliant guest from being
On Wed, Jan 11, 2017 at 04:28:23PM +0800, Longpeng(Mike) wrote:
This patch documents XML elements used for support of virtual
crypto devices.
In the devices section in the domain XML users may specify:
to enable the crypto device for guests.
Signed-off-by: Longpeng(Mike)
On Mon, Feb 06, 2017 at 10:23:35AM +0800, Eli Qiao wrote:
This series patches are for supportting CAT featues, which also
called cache tune in libvirt.
First to expose cache information which could be tuned in capabilites XML.
Then add new domain xml element support to add cacahe bank which
In order for memory locking to work, the hard limit on memory
locking (and usage) has to be set appropriately by the user.
The documentation mentions the requirement already: with this
patch, it's going to be enforced by runtime checks as well,
by forbidding a non-compliant guest from starting at
On Tue, Feb 07, 2017 at 02:43:13PM +0800, Eli Qiao wrote:
>
>
> --
> Eli Qiao
> Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
>
>
> On Tuesday, 7 February 2017 at 3:03 AM, Marcelo Tosatti wrote:
>
> > On Mon, Feb 06, 2017 at 01:33:09PM -0200, Marcelo Tosatti wrote:
> > > On Mon,
Andrea Bolognani wrote:
> On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote:
> [...]
> > + However, as this doesn't match libvirt's understanding of
> > + disk addresses, it was changed for the bhyve driver
>
> "it was changed for the bhyve driver"
> → "the bhyve
On Wed, 2017-02-01 at 20:25 +0400, Roman Bogorodskiy wrote:
> Like it usually happens, I fixed one thing and broke another:
> in 803966c76 address allocation was fixed for SATA disks, but
> broke that for virtio disks, because it dropped disk address
> assignment completely. It's not needed for
On Tue, Feb 07, 2017 at 12:35:03PM +0100, Andrea Bolognani wrote:
> In order for memory locking to work, the hard limit on memory
> locking (and usage) has to be set appropriately by the user.
>
> The documentation mentions the requirement already: with this
> patch, it's going to be enforced by
On Tue, 2017-02-07 at 12:07 +0100, Pavel Hrdina wrote:
> Actually there is a third option, we have domainValidateCallback
> that is what you are looking for. This function is called only
> when defining new XML and is skipped while parsing the XML from
> disk on libvirtd startup or while
The issue lies in how we check whether a FS is already mounted or not, we
compare the pool's source/target with source/target in the mount's binary
output both of which can actually be just symlinks to the same location yet
failing our check on the FS being mounted, thus reporting a strange error
When FS pool's source is already mounted on the target location instead
of just simply marking the pool as active, thus starting it we fail with
an error stating that the source is indeed already mounted on the target.
Signed-off-by: Erik Skultety
---
So rather than comparing 2 paths (strings) as they are, which can very
easily lead to unnecessary errors (e.g. in storage driver) that the paths
are not the same when in fact they'd be e.g. just symlinks to the same
location, we should put our best effort into resolving any symlinks and
Right now, we use simple string comparison both on the source paths
(mount's output vs pool's source) and the target (mount's mnt_dir vs
pool's target). The problem are symlinks and mount indeed returns
symlinks in its output, e.g. /dev/mappper/lvm_symlink. The same goes for
the pool's
On 02/06/2017 01:57 PM, Michal Privoznik wrote:
On 03.02.2017 18:35, Laine Stump wrote:
libvirt was able to set the host_mtu option when an MTU was explicitly
given in the interface config (with ), set the MTU of a
libvirt network in the network config (with the same named
subelement), and
On Mon, Feb 06, 2017 at 09:33:14AM -0700, Alex Williamson wrote:
> On Mon, 6 Feb 2017 13:19:42 +0100
> Erik Skultety wrote:
>
> > Finally. It's here. This is the initial suggestion on how libvirt might
> > interract with the mdev framework, currently only focussing on the
On Mon, Feb 06, 2017 at 04:44:37PM +, Daniel P. Berrange wrote:
> On Mon, Feb 06, 2017 at 01:19:42PM +0100, Erik Skultety wrote:
> > Finally. It's here. This is the initial suggestion on how libvirt might
> > interract with the mdev framework, currently only focussing on the
> > non-managed
>
This patchs allows to set the timeout value used for all
openvswitch calls. The default timeout value remains as
before at 5 seconds.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
---
src/libvirt_private.syms| 1 +
Since a successful completion of the calls to openvswitch is expected
a longer timeout should be able to be chosen to account for loaded systems.
Therefore this patch provides the ability to specify the timeout value for
openvswitch calls in the libvirtd configuration file.
Signed-off-by: Boris
Since a successful completion of openvswitch calls is expected a longer
timeout should be able to be chosen in order to account for loaded systems.
Therefore this patch series provides the ability to specify the timeout value
for openvswitch calls in the libvirtd configuration file.
Boris
Provide the ability to specify a default timeout value for
successful completion of openvswitch calls in the libvirtd
configuration file.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
---
daemon/libvirtd-config.c| 6 ++
Andrea Bolognani wrote:
> On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote:
> [...]
> > + However, as this doesn't match libvirt's understanding of
> > + disk addresses, it was changed for the bhyve driver
>
> "it was changed for the bhyve driver"
> → "the bhyve
Andrea Bolognani wrote:
> On Wed, 2017-02-01 at 20:25 +0400, Roman Bogorodskiy wrote:
> > Like it usually happens, I fixed one thing and broke another:
> > in 803966c76 address allocation was fixed for SATA disks, but
> > broke that for virtio disks, because it dropped disk address
> >
On 02/07/2017 03:26 AM, Michal Privoznik wrote:
On 02/06/2017 11:08 PM, Jim Fehlig wrote:
When a user does not explicitly set a in the disk config,
libvirt defers selection of a default to libxl. This approach works
fine when starting a domain with such configuration or attaching a
disk to a
On Tue, Feb 07, 2017 at 05:48:23PM +0100, Erik Skultety wrote:
> On Mon, Feb 06, 2017 at 04:44:37PM +, Daniel P. Berrange wrote:
> > On Mon, Feb 06, 2017 at 01:19:42PM +0100, Erik Skultety wrote:
> > > Finally. It's here. This is the initial suggestion on how libvirt might
> > > interract with
On Tue, 2017-02-07 at 18:05 +0100, Pavel Hrdina wrote:
> ACK
Pushed, thanks :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Feb 07, 2017 at 02:16:49PM +0100, Andrea Bolognani wrote:
> In order for memory locking to work, the hard limit on memory
> locking (and usage) has to be set appropriately by the user.
>
> The documentation mentions the requirement already: with this
> patch, it's going to be enforced by
On 02/07/2017 08:30 AM, Jim Fehlig wrote:
On 02/07/2017 03:26 AM, Michal Privoznik wrote:
On 02/06/2017 11:08 PM, Jim Fehlig wrote:
When a user does not explicitly set a in the disk config,
libvirt defers selection of a default to libxl. This approach works
fine when starting a domain with
On Tue, 7 Feb 2017 17:26:51 +0100
Erik Skultety wrote:
> On Mon, Feb 06, 2017 at 09:33:14AM -0700, Alex Williamson wrote:
> > On Mon, 6 Feb 2017 13:19:42 +0100
> > Erik Skultety wrote:
> >
> > > Finally. It's here. This is the initial suggestion on
When starting a domian, a libxl_domain_config object is created from
virDomainDef. Any virDomainDiskDef devices with a format of
VIR_STORAGE_FILE_NONE are mapped to LIBXL_DISK_FORMAT_RAW in the
corresponding libxl_disk_device, but the virDomainDiskDef format is
never updated to reflect the change.
V2 of
https://www.redhat.com/archives/libvir-list/2017-February/msg00185.html
Patch1 is new in V2 and essentially moves default setting of disk
format from domain build time to device post-parse, which addresses
Michal's comment from V1.
Patch2 is mostly unchanged. The hunk setting format of
When a user does not explicitly set a in the disk config,
libvirt defers selection of a default to libxl. This approach works
fine when starting a domain with such configuration or attaching a
disk to a running domain. But when detaching such a disk, libxl
will fail with "unrecognized disk
On 02/08/2017 12:35 AM, Joao Martins wrote:
> Hey!
>
> Presented herewith is take 2 from tunnelled migration addressing all previous
> comments. Changelog in individual patches (patch 1 and 2 are small
> refactorings
> suggested in v1) Despite being functional changes mostly I had a quick round
From: Bob Liu
Tunnelled migration doesn't require any extra network connections beside
the libvirt daemon. It's capable of strong encryption and the default
option of openstack-nova.
This patch adds the tunnelled migration(Tunnel3params) support to libxl.
On the source
The newly introduced function libxlDomainMigrationPrepareAny
will be shared between P2P and tunnelled variations.
Signed-off-by: Joao Martins
---
New in v2
---
src/libxl/libxl_migration.c | 92 +++--
1 file changed, 56
This allows us to reuse a single function for both tunnelled and
non-tunnelled variants.
Signed-off-by: Joao Martins
---
New in v2
---
src/libxl/libxl_driver.c | 36 +++-
1 file changed, 27 insertions(+), 9 deletions(-)
diff --git
Hey!
Presented herewith is take 2 from tunnelled migration addressing all previous
comments. Changelog in individual patches (patch 1 and 2 are small refactorings
suggested in v1) Despite being functional changes mostly I had a quick round of
testing too.
Thanks,
Joao
Bob Liu (1):
libxl: add
--
Eli Qiao
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Tuesday, 7 February 2017 at 7:56 PM, Marcelo Tosatti wrote:
> On Tue, Feb 07, 2017 at 02:43:13PM +0800, Eli Qiao wrote:
> >
> >
> > --
> > Eli Qiao
> > Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
> >
>
Hi Martin,
On 2017/2/7 19:11, Martin Kletzander wrote:
> On Wed, Jan 11, 2017 at 04:28:23PM +0800, Longpeng(Mike) wrote:
>> This patch documents XML elements used for support of virtual
...
>> + type
>> +
>> +
>> +The required type element specifies
Hi Martin,
On 2017/2/7 20:15, Martin Kletzander wrote:
> On Wed, Jan 11, 2017 at 04:28:24PM +0800, Longpeng(Mike) wrote:
>> This patch parse the domain XML with virtio-crypto
>> support, the virtio-crypto XML looks like this:
>>
>>
>>
>>
>>
>> Signed-off-by: Longpeng(Mike)
69 matches
Mail list logo