On Fri, 16 Jun 2017 18:11:17 +0100
"Daniel P. Berrange" wrote:
> On Fri, Jun 16, 2017 at 11:02:55AM -0600, Alex Williamson wrote:
> > On Fri, 16 Jun 2017 11:32:04 -0400
> > Laine Stump wrote:
> >
> > > On 06/15/2017 02:42 PM, Alex Williamson wrote:
>
On Thu, Jun 15, 2017 at 02:44:02PM +0200, Martin Kletzander wrote:
Change the settings from qemuDomainUpdateDeviceLive() as otherwise the
call would succeed even though nothing has changed.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1460862
Dang, this should be
On Thu, Jun 15, 2017 at 10:12:51PM -0400, John Ferlan wrote:
On 06/15/2017 10:40 AM, Pavel Hrdina wrote:
On Thu, Jun 15, 2017 at 07:57:18AM -0400, John Ferlan wrote:
On 06/15/2017 03:11 AM, Pavel Hrdina wrote:
On Tue, Jun 13, 2017 at 08:00:41PM -0400, John Ferlan wrote:
[...]
Wouldn't
All the pieces are now in place, so we can finally start
using isolation groups to achieve our initial goal, which is
separating hostdevs from emulated PCI devices while keeping
hostdevs that belong to the same host IOMMU group together.
Resolves:
Use 0001:01:00.0 instead of :04:02.0 as the source address
for the host device. This doesn't change anything at the moment,
but it will make a difference later on.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
There are no external users.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 5 -
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 7 deletions(-)
diff --git
Move @function after @flags to match other functions in the
same module like virDomainPCIAddressReserveNextAddr().
Also move virDomainPCIAddressReserveNextAddr() closer to
virDomainPCIAddressReserveAddr() in the header file.
Reviewed-by: Laine Stump
Signed-off-by: Andrea
On Sun, Jun 04, 2017 at 04:41:58PM +0200, Guido Günther wrote:
> On Tue, May 23, 2017 at 06:22:42PM +0200, Stefan Bader wrote:
> > From: Serge Hallyn
> >
> > Updates profile to allow running on ppc64el.
> >
> > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1374554
> >
>
On 06/10/2017 08:53 PM, jean-christophe manciot wrote:
> Hello everyone,
>
> I have multiple virtual networks defined on my Server:
> # virsh net-list --all
> Name State Autostart Persistent
> --
> default
On Fri, Jun 02, 2017 at 08:46:26PM +0200, Guido Günther wrote:
> On Tue, May 23, 2017 at 06:22:39PM +0200, Stefan Bader wrote:
> > From: Simon McVittie
> >
> > The split firmware and variables files introduced by
> > https://bugs.debian.org/764918 are in a different directory
On Fri, Jun 02, 2017 at 09:01:49PM +0200, Guido Günther wrote:
> On Tue, May 23, 2017 at 06:22:48PM +0200, Stefan Bader wrote:
> > From: Serge Hallyn
> >
> > When setting up VncTLS according to the official Libvirt documentation,
> > only one certificate for
On Tue, May 23, 2017 at 06:22:41PM +0200, Stefan Bader wrote:
> From: William Grant
>
> Allow access to aarch64 UEFI images.
>
> Signed-off-by: Christian Ehrhardt
> Signed-off-by: Stefan Bader
> Acked-by: Guido
Signed-off-by: Andrea Bolognani
---
docs/schemas/domaincommon.rng | 5 +
src/conf/domain_conf.c| 24
src/conf/domain_conf.h| 1 +
3 files changed, 30 insertions(+)
diff --git a/docs/schemas/domaincommon.rng
PCI bus has to be numbered sequentially, and no index can be
missing, so libvirt will fill in the blanks automatically for
the user.
Up until now, it has done so using either pci-bridge, for machine
types based on legacy PCI, or pcie-root-port, for machine types
based on PCI Express. Neither
pSeries guests will soon need the new information; luckily,
we can figure it out automatically most of the time, so
users won't have to worry about it.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain_address.c | 88 +-
These rules will make it possible for libvirt to
automatically assign PCI addresses in a way that
respects any isolation constraints devices might
have.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 81 +++---
1
When looking for slots suitable for a PCI device, libvirt
might need to add an extra PCI controller: for pSeries guests,
we want that extra controller to be a PHB (pci-root) rather
than a PCI bridge.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c
These tests demonstrate that, while it's now possible for the
user to create PHB explicitly and manually assign devices to
them, libvirt still defaults to extending the guest PCI
topology using PCI bridges and making suboptimal device
placement choices.
The next few commits will improve on these
This new capability can be used to detect whether a QEMU
binary supports the spapr-pci-host-bridge controller.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_capabilities.c | 2 ++
Moving the check and rewriting it this way doesn't alter
the current behavior, but will allow us to special-case
pci-root down the line.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 26 --
1
Signed-off-by: Andrea Bolognani
---
.../qemuxml2argv-pseries-phb-default-missing.args | 22 +++
.../qemuxml2argv-pseries-phb-default-missing.xml | 16 +++
.../qemuxml2argv-pseries-phb-simple.args | 22 +++
The current algorithm for slot allocation tries to be clever
and avoid looking at buses / slots more than once unless it's
necessary. Unfortunately that makes the code more complex,
and it will cause problem later on in some situations unless
even more complex code is added.
Since the performance
Usually, a controller with alias 'x' will create a bus with the
same name; however, the bus created by a PHBs with alias 'x' will
be named 'x.0' instead, so we need to account for that.
As an exception to the exception, the implicit PHB that's added
automatically to every pSeries guest creates
We will soon need to be able to return a NULL pointer
without the caller considering that an error: to make
it possible, change the return type to int and use
an out parameter for the string instead.
Add some documentation for the function as well.
Reviewed-by: Laine Stump
The virDomainDeviceInfoIsSet() function no longer exists.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
src/conf/device_conf.h | 4
1 file changed, 4 deletions(-)
diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h
index
There are no external users.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 8
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/conf/domain_addr.c
Later on we're going to need access to information about IOMMU
groups for host devices. Implement the support in virpcimock,
and start using that mock library in a few QEMU test cases.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
pSeries guests will soon be allowed to have multiple
PHBs (pci-root controllers), which of course means that
all but one of them will have a non-zero index; hence,
we'll need to relax the current check.
However, right now the check is performed in the conf
module, which is generic rather than
Adding it to the virDomainControllerPCIModelName enumeration
is enough for existing code to handle it, so parsing and
formatting will work without further tweaking.
Signed-off-by: Andrea Bolognani
---
docs/schemas/domaincommon.rng | 2 ++
src/conf/domain_conf.c| 1 +
pSeries guests will soon be allowed to have multiple
PHBs (pci-root controllers), meaning the current check
on the controller index no longer applies to them.
Reviewed-by: Laine Stump
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 11
Dear list,
while trying to fix a bug of mine, I've realized the mounts are not
being propagated into qemu namespaces once domains are running. That is,
imagine you have a domain running and then you plug in a flash disk,
mount it into host, because you have a file there that you want to
hotplug
On Wed, Jun 07, 2017 at 07:00:56PM +0200, Guido Günther wrote:
> On Wed, Jun 07, 2017 at 10:44:59AM -0600, Christian Ehrhardt wrote:
> > On Fri, Jun 2, 2017 at 12:57 PM, Guido Günther wrote:
> >
> > > Shouldn't this only be added when ceph is in use?
> > > Cheers,
> > > --
On Fri, Jun 02, 2017 at 08:58:57PM +0200, Guido Günther wrote:
> On Tue, May 23, 2017 at 06:22:44PM +0200, Stefan Bader wrote:
> > On Debian/Ubuntu the libxl-save-helper (used when saving/restoring
> > a domain through libxl) is located under /usr/lib/xen-/bin.
> >
> > Bug-Ubuntu:
On Fri, Jun 02, 2017 at 08:46:42PM +0200, Guido Günther wrote:
> On Tue, May 23, 2017 at 06:22:40PM +0200, Stefan Bader wrote:
> > From: Christian Ehrhardt
> >
> > This replaces individual tests for firmware locations by
> > a generic function which will
On Thu, Jun 15, 2017 at 02:44:02PM +0200, Martin Kletzander wrote:
> Change the settings from qemuDomainUpdateDeviceLive() as otherwise the
> call would succeed even though nothing has changed.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1460862
>
> Signed-off-by: Martin Kletzander
Changes from [v1]:
* address review comments;
* implement a much better isolation algorithm that doesn't
require parsing and formatting the isolation group and
can handle more dynamic scenarios, such as empty PHBs
changing their isolation groups to accomodate hotplugged
Isolation groups will eventually allow us to make sure certain
devices, eg. PCI hostdevs, are assigned to guest PCI buses in
a way that guarantees improved isolation, error detection and
recovery for machine types and hypervisors that support it,
eg. pSeries guest on QEMU.
Signed-off-by: Andrea
Additional PHBs (pci-root controllers) will be created for
the guest using the spapr-pci-host-bridge QEMU device, if
available; the implicit default PHB, while present in the
guest configuration, will be skipped.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1431193
Signed-off-by: Andrea
On Fri, Jun 09, 2017 at 10:52:20AM +0200, Martin Kletzander wrote:
> On some platforms the number of bits in the cbm_mask might not be
> divisible by 4 (and not even by 2), so we need to properly count the
> bits. Similar file, min_cbm_bits, is properly parsed and used, but if
> the number is
On Thu, Jun 15, 2017 at 05:51:42PM -0300, Julio Faracco wrote:
Thanks to share the commit SHA, Martin.
My only doubt is: I speak Brazilian portuguese (so pt_BR-Latin
America and we use comma as separator). Should libvirt consider
it as a separator? Or only dot? Because this approach fails to
---
domain.go | 29 +
domain_test.go | 4
2 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/domain.go b/domain.go
index eb7ff9e..ecb8550 100644
--- a/domain.go
+++ b/domain.go
@@ -185,19 +185,24 @@ type DomainInterfaceDriver struct {
Yes, except that it *does not work*. As you can see below, libnss-libvirt
is installed and configured, but the VM "KVM-Ubuntu-GNS3-Server-17.04" is
not reachable through its DNS name.
# apt-cache policy libnss-libvirt
libnss-libvirt:
Installed: 3.0.0-4
...
# cat /etc/nsswitch.conf
passwd:
On 06/16/2017 12:21 PM, jean-christophe manciot wrote:
> Yes, except that it *does not work*. As you can see below, libnss-libvirt
> is installed and configured, but the VM "KVM-Ubuntu-GNS3-Server-17.04" is
> not reachable through its DNS name.
libvirt-nss is not for translating DNS names, rather
On 06/16/2017 01:14 PM, Daniel P. Berrange wrote:
> On Fri, Jun 16, 2017 at 10:01:26AM +0200, Michal Privoznik wrote:
>> Dear list,
>>
>> while trying to fix a bug of mine, I've realized the mounts are not
>> being propagated into qemu namespaces once domains are running. That is,
>> imagine you
On Fri, Jun 16, 2017 at 10:01:26AM +0200, Michal Privoznik wrote:
> Dear list,
>
> while trying to fix a bug of mine, I've realized the mounts are not
> being propagated into qemu namespaces once domains are running. That is,
> imagine you have a domain running and then you plug in a flash disk,
On Sat, Jun 10, 2017 at 08:53:16PM +0200, jean-christophe manciot wrote:
Hello everyone,
I have multiple virtual networks defined on my Server:
# virsh net-list --all
Name State Autostart Persistent
--
default
>
> libvirt-nss is not for translating DNS names, rather than libvirt guest
> names
I meant hostname/guest name. There is no static DNS in /etc/hosts for the
VMs and no specific records in DNS server.
Can you see the guest in: /var/lib/libvirt/dnsmasq/virbr0.{macs,status}
>
# cat
Since qemu 2.9 the options changed from a monolithic string into fine
grained options for the json pseudo-protocol object.
---
src/util/virstoragefile.c | 19 ---
tests/virstoragetest.c| 11 +++
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git
The same json strucutre is used for NBD and sheepdog volumes for
specifying of the host. Rename the function and fix up error messages to
be more universal.
---
src/util/virstoragefile.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/util/virstoragefile.c
Since qemu 2.9 the options changed from a monolithic string into fine
grained options for the json pseudo-protocol object.
---
src/util/virstoragefile.c | 50 +++
tests/virstoragetest.c| 19 ++
2 files changed, 65 insertions(+), 4
Merge the reporting of the missing source host data into the parser
functions so that callers don't have to do it separately.
---
src/util/virstoragefile.c | 30 --
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/src/util/virstoragefile.c
Few backing protocols support only TCP. Split out the function which
will correspond to parsing qemu's InetSocketAddressBase.
---
src/util/virstoragefile.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/src/util/virstoragefile.c
Since 2.9 the host and port for NBD are no longer directly under the
json pseudo-protocol object, but rather belong to a sub-object called
'server'.
---
src/util/virstoragefile.c | 28 +---
tests/virstoragetest.c| 11 +++
2 files changed, 28 insertions(+), 11
If the number of servers is not expected the code would report an error
but would not return failure.
---
src/util/virstoragefile.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 020c69def..6b0af521f 100644
---
The conversion to proper structures in qemu 2.9 lead to a change in the JSON
pseudo protocol fields, which made them unknown to libvirt.
This patchset fixes and refactors a few helpers and then adds the new format
to the backing store string parser.
Peter Krempa (10):
util: storage: Output
Starting from qemu 2.9, more granular options are supported. Add parser
for the relevant bits.
With this patch libvirt is able to parse the host and target IQN of from
the JSON pseudo-protocol specification.
This corresponds to BlockdevOptionsIscsi in qemu qapi.
---
src/util/virstoragefile.c |
---
src/util/virstoragefile.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index e82a7fb53..020c69def 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -3229,6 +3229,8 @@
Since qemu 2.9 the options changed from a monolithic string into fine
grained options for the json pseudo-protocol object.
---
src/util/virstoragefile.c | 28
tests/virstoragetest.c| 11 +++
2 files changed, 35 insertions(+), 4 deletions(-)
diff --git
Docker Memory and VCPU configuration is converted to fit for LXC container XML
configuration
---
po/POTFILES.in | 1 +
src/Makefile.am| 1 +
src/lxc/lxc_driver.c | 13 ++-
Docker Json command is split between entrypoint and command properties. Compute
a command
out of those to fit the LXC container XML configuration.
---
src/lxc/lxc_native_docker.c| 65 ++
.../dockerjson2xmldata-command.json| 50
On 06/12/2017 05:57 PM, Michal Privoznik wrote:
> Yet again, some corner cases, nothing critical.
> But it is certainly nice to fix them regardless.
>
> Michal Privoznik (3):
> qemuDomainBuildNamespace: Clean up temp files
> qemuDomainGetPreservedMounts: Prune nested mount points
>
Hi,
Over the past few days I've been trying to get a prototype working of a
stateful firewall for a Virtual Machine using Libvirt's network filters.
My goal is to replace the current custom Python/Java code in the Apache
CloudStack [0] project by Network Filters of Libvirt.
Both IPv4 and IPv6
On 06/15/2017 02:42 PM, Alex Williamson wrote:
> On Thu, 15 Jun 2017 09:33:01 +0100
> "Daniel P. Berrange" wrote:
>
>> On Thu, Jun 15, 2017 at 12:06:43AM +0200, Erik Skultety wrote:
>>> Hi all,
>>>
>>> so there's been an off-list discussion about finally implementing
On Fri, Jun 16, 2017 at 05:29:38PM +0200, Peter Krempa wrote:
> ---
> src/util/virstoragefile.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
Quick note: next time you send a patch series, add a cover letter to it.
You can get git to automatically ask you about one by running
git config add format.coverletter auto
Having reviewed them off-list first, ACK from me to those changes.
Daniel, do you want to double-review them?
--
On Fri, Jun 16, 2017 at 05:29:40PM +0200, Peter Krempa wrote:
> The same json strucutre is used for NBD and sheepdog volumes for
> specifying of the host. Rename the function and fix up error messages to
> be more universal.
> ---
> src/util/virstoragefile.c | 12 ++--
> 1 file changed, 6
On Fri, Jun 16, 2017 at 11:32:04AM -0400, Laine Stump wrote:
> On 06/15/2017 02:42 PM, Alex Williamson wrote:
> > On Thu, 15 Jun 2017 09:33:01 +0100
> > "Daniel P. Berrange" wrote:
> >
> >> On Thu, Jun 15, 2017 at 12:06:43AM +0200, Erik Skultety wrote:
> >>> Hi all,
> >>>
>
On Fri, Jun 16, 2017 at 05:29:41PM +0200, Peter Krempa wrote:
> Few backing protocols support only TCP. Split out the function which
> will correspond to parsing qemu's InetSocketAddressBase.
> ---
> src/util/virstoragefile.c | 38 +-
> 1 file changed, 25
On Fri, Jun 16, 2017 at 05:29:42PM +0200, Peter Krempa wrote:
> Merge the reporting of the missing source host data into the parser
> functions so that callers don't have to do it separately.
> ---
> src/util/virstoragefile.c | 30 --
> 1 file changed, 24
On Fri, Jun 16, 2017 at 05:29:43PM +0200, Peter Krempa wrote:
> Starting from qemu 2.9, more granular options are supported. Add parser
> for the relevant bits.
>
> With this patch libvirt is able to parse the host and target IQN of from
> the JSON pseudo-protocol specification.
>
> This
On Fri, Jun 16, 2017 at 05:29:44PM +0200, Peter Krempa wrote:
> Since 2.9 the host and port for NBD are no longer directly under the
> json pseudo-protocol object, but rather belong to a sub-object called
> 'server'.
> ---
> src/util/virstoragefile.c | 28 +---
>
On Fri, Jun 16, 2017 at 05:29:45PM +0200, Peter Krempa wrote:
> Since qemu 2.9 the options changed from a monolithic string into fine
> grained options for the json pseudo-protocol object.
> ---
> src/util/virstoragefile.c | 50
> +++
>
On Fri, 16 Jun 2017 11:32:04 -0400
Laine Stump wrote:
> On 06/15/2017 02:42 PM, Alex Williamson wrote:
> > On Thu, 15 Jun 2017 09:33:01 +0100
> > "Daniel P. Berrange" wrote:
> >
> >> On Thu, Jun 15, 2017 at 12:06:43AM +0200, Erik Skultety wrote:
> >>>
On Fri, Jun 16, 2017 at 05:29:46PM +0200, Peter Krempa wrote:
> Since qemu 2.9 the options changed from a monolithic string into fine
> grained options for the json pseudo-protocol object.
> ---
> src/util/virstoragefile.c | 19 ---
> tests/virstoragetest.c| 11 +++
>
On Fri, Jun 16, 2017 at 11:02:55AM -0600, Alex Williamson wrote:
> On Fri, 16 Jun 2017 11:32:04 -0400
> Laine Stump wrote:
>
> > On 06/15/2017 02:42 PM, Alex Williamson wrote:
> > > On Thu, 15 Jun 2017 09:33:01 +0100
> > > "Daniel P. Berrange" wrote:
> > >
On Fri, Jun 16, 2017 at 06:11:17PM +0100, Daniel P. Berrange wrote:
> On Fri, Jun 16, 2017 at 11:02:55AM -0600, Alex Williamson wrote:
> > On Fri, 16 Jun 2017 11:32:04 -0400
> > Laine Stump wrote:
> >
> > > On 06/15/2017 02:42 PM, Alex Williamson wrote:
> > > > On Thu, 15 Jun
On Fri, Jun 16, 2017 at 05:29:47PM +0200, Peter Krempa wrote:
> Since qemu 2.9 the options changed from a monolithic string into fine
> grained options for the json pseudo-protocol object.
> ---
> src/util/virstoragefile.c | 28
> tests/virstoragetest.c| 11
77 matches
Mail list logo