Re: [libvirt] [PATCH] src: remove WITH_LIBVIRTD condition around hal/udev build

On Thu, Feb 22, 2018 at 08:15:26AM +0100, Michal Privoznik wrote: > On 02/21/2018 04:22 PM, Daniel P. Berrangé wrote: > > Currently building --without-libvirtd causes a failure to link the node > > device driver: > > > > node_device/.libs/libvirt_driver_nodedev_la-node_device_driver.o: In > >

Re: [libvirt] [PATCH v2 0/6] port allocator: make used port bitmap global etc

ping On 06.02.2018 12:09, Nikolay Shirokovskiy wrote: > This patch set addresses issue(s) described in [1] and the core of > changes go to the first patch. The others are cleanups and > refactorings. > > Diff from v1: > - rename virPortRange to virPortAllocatorRange (virPortRange is occupied) >

[libvirt] [PATCH] bhyve: add missing cases for graphics listen type

Address warning from -Wswitch-enum by adding missing cases for graphics listen types that are not supported. Signed-off-by: Daniel P. Berrangé --- Pushed as a CI build fix src/bhyve/bhyve_command.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 07/10] daemon: move init system files into src/remote/

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Move the systemd, sysvinit, upstart and sysconfig files into the > src/remote/ directory. > > Signed-off-by: Daniel P. Berrangé > --- > .gitignore | 1 + > daemon/Makefile.am

Re: [libvirt] [PATCH 05/10] daemon: move libvirtd code into src/remote/ directory

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Having a daemon/ directory makes little sense from a code structure > point of view, as 90% of the code that is built into libvirtd already > lives in the src/ directory. The virtlockd and virlogd daemons also live > entirely in

Re: [libvirt] [PATCH 09/10] daemon: move misc libvirtd policy files to src/remote/

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > daemon/Makefile.am| 87 ++--- > src/Makefile.am | 92 > ++- > {daemon =>

Re: [libvirt] [PATCH 08/10] daemon: move configuration files to src/remote

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > daemon/Makefile.am | 26 -- > src/Makefile.am | 24 +++- > {daemon =>

Re: [libvirt] [PATCH 10/10] daemon: move logrotate files to src/remote/

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > Makefile.am| 2 +- > configure.ac | 1 - > daemon/Makefile.am | 117

Re: [libvirt] [PATCH 03/10] src: simplify sysconfig file handling in make rules

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Remove lots of duplication in the sysconfig file handling, so we can > add more conf files without modifying so many places. > > Signed-off-by: Daniel P. Berrangé > --- > src/Makefile.am | 25 - > 1

Re: [libvirt] [PATCH 00/10] Move the libvirtd daemon into src/remote/

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > Having a daemon/ directory makes little sense from a code structure > point of view, as 90% of the code that is built into libvirtd already > lives in the src/ directory. The virtlockd and virlogd daemons also live > entirely in

Re: [libvirt] [PATCH 04/10] daemon: remove obsolete doc describing daemon threading

On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > The THREADS.txt describes the way threading worked in libvirtd many many > years ago, long before even the RPC code was modularized. Things have > evolved significantly since then, so delete this potentially misleading doc. > > Signed-off-by:

Re: [libvirt] [PATCH] news: libxl now supports setting clock offset and adjustment

On 02/21/2018 08:50 PM, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > --- > docs/news.xml | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index b60cb2d98..86a0c8d18 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -77,6

[libvirt] [PATCH v1 01/16] make: split UML driver build rules into uml/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 57 +++-- src/uml/Makefile.inc.am | 46 +++ 2 files changed, 63 insertions(+), 40 deletions(-) create mode 100644

[libvirt] [PATCH v1 15/16] make: split vz driver build rules into vz/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am| 31 +-- src/vz/Makefile.inc.am | 38 ++ 2 files changed, 39 insertions(+), 30 deletions(-) create mode 100644 src/vz/Makefile.inc.am diff --git

[libvirt] [PATCH v1 09/16] make: split qemu driver build rules into qemu/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 122 +- src/qemu/Makefile.inc.am | 148 +++ 2 files changed, 162 insertions(+), 108 deletions(-) create mode 100644

[libvirt] [PATCH v1 10/16] make: split bhyve driver build rules into bhyve/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 62 ++-- src/bhyve/Makefile.inc.am | 73 +++ 2 files changed, 75 insertions(+), 60 deletions(-) create mode 100644

[libvirt] [PATCH v1 11/16] make: split xenconfig driver build rules into xenconfig/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 21 + src/xenconfig/Makefile.inc.am | 28 2 files changed, 29 insertions(+), 20 deletions(-) create mode 100644 src/xenconfig/Makefile.inc.am diff --git

[libvirt] [PATCH v1 16/16] make: split lxc driver build rules into lxc/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 184 ++ src/lxc/Makefile.inc.am | 207 2 files changed, 212 insertions(+), 179 deletions(-) create mode 100644

[libvirt] [PATCH v1 12/16] make: split libxl driver build rules into libxl/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 82 +--- src/libxl/Makefile.inc.am | 104 ++ 2 files changed, 106 insertions(+), 80 deletions(-) create mode 100644

[libvirt] [PATCH v1 08/16] make: split openvz driver build rules into openvz/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am| 22 +- src/openvz/Makefile.inc.am | 28 2 files changed, 29 insertions(+), 21 deletions(-) create mode 100644 src/openvz/Makefile.inc.am diff --git

[libvirt] [PATCH v1 02/16] make: split PHyp driver build rules into phyp/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 18 +++--- src/phyp/Makefile.inc.am | 19 +++ 2 files changed, 22 insertions(+), 15 deletions(-) create mode 100644 src/phyp/Makefile.inc.am diff --git a/src/Makefile.am

[libvirt] [PATCH v1 13/16] make: split xen driver build rules into xen/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 39 +--- src/xen/Makefile.inc.am | 67 + 2 files changed, 68 insertions(+), 38 deletions(-) create mode 100644 src/xen/Makefile.inc.am

[libvirt] [PATCH v1 05/16] make: split hyperv driver build rules into hyperv/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am| 47 +--- src/hyperv/Makefile.inc.am | 59 ++ 2 files changed, 60 insertions(+), 46 deletions(-) create mode 100644

[libvirt] [PATCH v1 06/16] make: split vmware driver build rules into vmware/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am| 21 + src/vmware/Makefile.inc.am | 27 +++ 2 files changed, 28 insertions(+), 20 deletions(-) create mode 100644 src/vmware/Makefile.inc.am diff --git

[libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

Before 3f055b5997c we were doing that. However after the commit we are leaving the files behind. Signed-off-by: Michal Privoznik --- Pushed under build breaker rule. src/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am

Re: [libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

On Thu, Feb 22, 2018 at 02:34:56PM +0100, Michal Privoznik wrote: > Before 3f055b5997c we were doing that. However after the commit > we are leaving the files behind. > > Signed-off-by: Michal Privoznik > --- > > Pushed under build breaker rule. What are you running that

Re: [libvirt] [PATCH] make: fix VPATH build for libvirtd augeas check

On Thu, Feb 22, 2018 at 13:33:49 +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/Makefile.am b/src/Makefile.am > index b8e2cbf139..41a3cb2628 100644 >

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

On Thu, Feb 22, 2018 at 01:29:35PM +, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this

[libvirt] [PATCH v1 03/16] make: split test driver build rules into test/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 21 + src/test/Makefile.inc.am | 26 ++ 2 files changed, 27 insertions(+), 20 deletions(-) create mode 100644 src/test/Makefile.inc.am diff --git a/src/Makefile.am

[libvirt] [PATCH v1 04/16] make: split ESX driver build rules into esx/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 79 --- src/esx/Makefile.inc.am | 90 + 2 files changed, 97 insertions(+), 72 deletions(-) create mode 100644

[libvirt] [PATCH v1 07/16] make: split vbox driver build rules into vbox/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 50 +-- src/vbox/Makefile.inc.am | 76 2 files changed, 77 insertions(+), 49 deletions(-) create mode 100644

[libvirt] [PATCH v1 00/16] Start to modularize src/Makefile.am

The src/Makefile.am is quite large and has quite poor grouping of rules / variables / etc. This makes it increasingly hard to identify all the rules relating to a particular area of code. Traditionally one might create Makefile.am's in each sub-directory and let make recurse into each. Recursive

[libvirt] [PATCH v1 14/16] make: split xenapi driver build rules into xenapi/Makefile.inc.am

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am| 18 +- src/xenapi/Makefile.inc.am | 28 2 files changed, 29 insertions(+), 17 deletions(-) create mode 100644 src/xenapi/Makefile.inc.am diff --git

[libvirt] RFC: should we mandate use of VPATH builds ?

One of the things we (well I) constantly screw up is VPATH builds. I've always tended to just build in the source tree, and as a result I'll often miss changes which break VPATH builds. Now our Jenkins CI catches this because it does VPATH builds only, so we don't bit-rot for very long.

[libvirt] [PATCH] make: fix VPATH build for libvirtd augeas check

Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index b8e2cbf139..41a3cb2628 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2297,7 +2297,7 @@

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

On Thu, Feb 22, 2018 at 13:29:35 +, Daniel Berrange wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. I vote for _no_. I mostly use in-tree

Re: [libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

On 02/22/2018 02:37 PM, Daniel P. Berrangé wrote: > On Thu, Feb 22, 2018 at 02:34:56PM +0100, Michal Privoznik wrote: >> Before 3f055b5997c we were doing that. However after the commit >> we are leaving the files behind. >> >> Signed-off-by: Michal Privoznik >> --- >> >>

Re: [libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

On Thu, Feb 22, 2018 at 02:44:58PM +0100, Michal Privoznik wrote: > On 02/22/2018 02:37 PM, Daniel P. Berrangé wrote: > > On Thu, Feb 22, 2018 at 02:34:56PM +0100, Michal Privoznik wrote: > >> Before 3f055b5997c we were doing that. However after the commit > >> we are leaving the files behind. >

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

On Thu, Feb 22, 2018 at 13:29:35 +, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this

[libvirt] [PATCH] qemu_hotplug: Drop dead code in net update

vm->def->nets[changeidx] can never be NULL for changeidx returned by virDomainNetFindIdx. Signed-off-by: Jiri Denemark --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCH v2 0/6] port allocator: make used port bitmap global etc

On 02/06/2018 10:09 AM, Nikolay Shirokovskiy wrote: > This patch set addresses issue(s) described in [1] and the core of > changes go to the first patch. The others are cleanups and > refactorings. > > Diff from v1: > - rename virPortRange to virPortAllocatorRange (virPortRange is occupied) > -

[libvirt] [PATCH] rpm: don't enable fuse on RHEL-6

Fuse was recently enabled whereever LXC is enabled: commit 34783a9e6b9c3d8850db878fc323c1ff40703ea6 Author: Jiri Denemark Date: Fri Feb 9 13:42:50 2018 +0100 spec: Enable fuse only if LXC is enabled Unfortunately the version of Fuse in RHEL-6 is too old for

Re: [libvirt] [PATCH 03/10] src: simplify sysconfig file handling in make rules

On Thu, Feb 22, 2018 at 11:24:39AM +0100, Michal Privoznik wrote: > On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > > Remove lots of duplication in the sysconfig file handling, so we can > > add more conf files without modifying so many places. > > > > Signed-off-by: Daniel P. Berrangé

Re: [libvirt] [PATCH 05/10] daemon: move libvirtd code into src/remote/ directory

On Thu, Feb 22, 2018 at 11:24:24AM +0100, Michal Privoznik wrote: > On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > > Having a daemon/ directory makes little sense from a code structure > > point of view, as 90% of the code that is built into libvirtd already > > lives in the src/ directory.

Re: [libvirt] [PATCH 10/10] daemon: move logrotate files to src/remote/

On Thu, Feb 22, 2018 at 11:24:18AM +0100, Michal Privoznik wrote: > On 02/21/2018 04:35 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > Makefile.am| 2 +- > > configure.ac

Re: [libvirt] [PATCH v2 0/6] port allocator: make used port bitmap global etc

On 22.02.2018 15:45, Michal Privoznik wrote: > On 02/06/2018 10:09 AM, Nikolay Shirokovskiy wrote: >> This patch set addresses issue(s) described in [1] and the core of >> changes go to the first patch. The others are cleanups and >> refactorings. >> >> Diff from v1: >> - rename virPortRange to

[libvirt] [PATCH] virLogGetOutputs: remove unnecessary braces

Commit 9275def reduced the if block to one line without removing the braces. Signed-off-by: Ján Tomko --- I pushed this yesterday as a build fix, but forgot to send an e-mail. src/util/virlog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH v2 0/6] port allocator: make used port bitmap global etc

On 02/22/2018 01:46 PM, Nikolay Shirokovskiy wrote: > > > On 22.02.2018 15:45, Michal Privoznik wrote: >> On 02/06/2018 10:09 AM, Nikolay Shirokovskiy wrote: >>> This patch set addresses issue(s) described in [1] and the core of >>> changes go to the first patch. The others are cleanups and >>>

[libvirt] [PATCH V2] libxl: round memory values to next 1MiB increment

libxl requires the memory sizes to be rounded to 1MiB increments. Attempting to start a domain that violates this requirement will fail with the marginally helpful error 2018-02-22 01:55:32.921+: xc: panic: xc_dom_boot.c:141: xc_dom_boot_mem_init: can't allocate low memory for domain: Out of

Re: [libvirt] [PATCH] libxl: round memory values to next 1MiB increment

On 02/21/2018 11:53 PM, Peter Krempa wrote: On Wed, Feb 21, 2018 at 19:08:41 -0700, Jim Fehlig wrote: libxl requires the memory sizes to be rounded to 1MiB increments. Attempting to start a domain that violates this requirement will fail with the marginally helpful error 2018-02-22

[libvirt] [PATCH] travis: add a scenario for running make distcheck

Running "make distcheck" ensures that we have CLEANFILES and uninstall rules setup correctly, as well as validating VPATH builds succeeed. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml

[libvirt] [PATCH] libxl: don't hardcode scheduler weight

Long ago in commit dfa1e1dd53 the scheduler weight was accidentally hardcoded to 1000. Weight is a setting with no unit since it is relative to the weight of other domains. If no weight is specified, libxl defaults to 256. Instead of hardcoding the weight to 1000, honor any specified in .

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-master-py3-check » libvirt-debian-9 #14

I'm confused why this is still failing. I set up a debian9 vm, reproduced the issue which fails about 50% of the time, and verified that commit 059fb7d0ba1d414db3db485903972b48c1dda629 fixes it completely, or at least I can't reproduce. But this is still failing. Weirdly though On 02/22/2018

[libvirt] [PATCH] make: fix another VPATH bug impacting install of sysconf files

Signed-off-by: Daniel P. Berrangé --- Pushed as build fix src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 2166e17dbe..8ceeda5756 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2833,7

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

On 22.02.2018 14:29, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this because it does VPATH

[libvirt] [PATCH 2/3] Pass oldDev to virDomainDefCompatibleDevice on device update

When calling virDomainDefCompatibleDevice to check a new device during device update, we need to pass the original device which is going to be updated in addition to the new device. Otherwise, the function can report false conflicts. The new argument is currently ignored by

[libvirt] [PATCH 0/3] qemu: Fix updating device with boot order

Commit v3.7.0-14-gc57f3fd2f8 prevented adding a element to an inactive domain with global element. However, as a result of that change updating any device with boot order would fail with 'boot order X is already used by another device', where "another device" is in fact the device which is being

[libvirt] [PATCH 1/3] lxc: Drop useless check in live device update

Checking the new device definition makes little sense when lxc driver does not support live device update at all. Signed-off-by: Jiri Denemark --- src/lxc/lxc_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index

[libvirt] [PATCH 3/3] qemu: Fix updating device with boot order

Commit v3.7.0-14-gc57f3fd2f8 prevented adding a element to an inactive domain with global element. However, as a result of that change updating any device with boot order would fail with 'boot order X is already used by another device', where "another device" is in fact the device which is being