Re: [libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

On Sun, Mar 04, 2018 at 16:24:21 -0300, Julio Faracco wrote: > When a length of a file is defined, the responsible thread to send > stream is finishing inappropriately. It is happening because there is > wrong conditional which compares an offset with the length and because > of that the code

Re: [libvirt] [PATCH 1/6] qemu: add capability detection for query-cpus-fast

On 03/02/2018 12:44 PM, Peter Krempa wrote: On Fri, Mar 02, 2018 at 10:29:06 +0100, Viktor Mihajlovski wrote: Detect whether QEMU supports the QMP query-cpus-fast API and set QEMU_CAPS_QUERY_CPUS_FAST in this case. Signed-off-by: Viktor Mihajlovski Reviewed-by:

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

On 03/05/2018 12:43 PM, Cordius Wu wrote: On 03/05/2018 03:20 AM, Wuzongyong (Euler Dept) wrote: > Hi, > > We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF to workerPool: > > static void > qemuProcessHandleMonitorEOF(qemuMonitorPtr mon,

Re: [libvirt] [tck PATCH v2 3/4] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test

On Thu, Mar 01, 2018 at 09:49:59PM -0500, Laine Stump wrote: > Adding these parameters to the clean-traffic filter causes a > significant extra piece of code to be executed (a separate thread is > started up, which uses libpcap to capture DHCP traffic and learn the > IP address of the guest / test

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

On 03/05/2018 10:39 AM, Wuzongyong (Euler Dept) wrote: > > > Thanks, > Zongyong Wu [Please don't top post on technical lists] > > >> -Original Message- >> From: Michal Privoznik [mailto:mpriv...@redhat.com] >> Sent: Monday, March 05, 2018 5:27 PM >> To: Wuzongyong (Euler Dept)

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Monday, March 5, 2018 8:09 PM > To: Cordius Wu; 'Wuzongyong (Euler Dept)'; libvir-list@redhat.com > Cc: 'Wanzongshun (Vincent)'; 'weijinfen' > Subject: Re: [libvirt] [Question]Libvirt doesn't care about

Re: [libvirt] [tck PATCH v2 2/4] new NetworkHelper function get_network_ip()

On Thu, Mar 01, 2018 at 09:49:58PM -0500, Laine Stump wrote: > This function gets the first IP address for the named virtual > network. It is returned as a Net::IP object, so that we will have info > about its netmask/prefix and can easily get it broadcast address and > perform arithmetic on the

Re: [libvirt] [PATCH 2/2] qemu: Call virDomainDefCompatibleDevice when live add cdrom/floppy

On Thu, Mar 01, 2018 at 08:03:39 -0500, John Ferlan wrote: > Prior to calling qemuDomainChangeEjectableMedia when adding > the cdrom/floppy to the guest, make a second pass at the > virDomainDefCompatibleDevice with the old_disk that's being > updated by the call. > > This is similar to the

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

Thanks, Zongyong Wu > -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Monday, March 05, 2018 5:27 PM > To: Wuzongyong (Euler Dept) ; libvir- > l...@redhat.com > Cc: Wanzongshun (Vincent) ; weijinfen >

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

>>> On 03/05/2018 03:20 AM, Wuzongyong (Euler Dept) wrote: Hi, We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF >>> to workerPool: static void qemuProcessHandleMonitorEOF(qemuMonitorPtr mon, virDomainObjPtr vm,

[libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

Fedora rawhide has just upgraded to the latest glibc git master snapshot, of what will become the 2.28 release, and this has exposed bugs in gnulib's fseeko.c implementation (and probably more macros) besides. The issue starts are line 50:

[libvirt] [PATCH] qemuDomainObjBeginJob: Don't account DESTROY job to maxQueuedJobs

When trying to destroy a domain (e.g. because we've seen EOF on the monitor) we try to acquire QEMU_JOB_DESTROY. However, if max_queued is set in qemu.conf this may fail and since our code doesn't count on that we will still report domain as active even though the qemu process is long gone. More

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

On 03/05/2018 10:26 AM, Michal Privoznik wrote: > On 03/05/2018 03:20 AM, Wuzongyong (Euler Dept) wrote: >> Hi, >> >> We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF to >> workerPool: >> >> static void >> qemuProcessHandleMonitorEOF(qemuMonitorPtr mon, >>

Re: [libvirt] [tck PATCH v2 4/4] nwfilter tests: remove all hardcoded references to 192.168.122 network

On Thu, Mar 01, 2018 at 09:50:00PM -0500, Laine Stump wrote: > The nwfilter tests have a few places that hardcode 192.168.122 as the > address of libvirt's default network. Remove all of these and replace > them with addresses that are dynamically determined based on > get_network_ip(). > > (This

[libvirt] [PATCH] travis: force install of python2 into $PATH on macOS

The homebrew formula's ignored Python PEP-0394 recommendations and changed the plain python binary in /usr/local/bin to point to Python 3 instead of Python 2. Python 2 is not even installed into a location that is in $PATH by default anymore. The homebrew packages print a message to stderr

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On Mon, Mar 05, 2018 at 12:19:24PM +, Daniel P. Berrangé wrote: > Fedora rawhide has just upgraded to the latest glibc git master snapshot, > of what will become the 2.28 release, and this has exposed bugs in gnulib's > fseeko.c implementation (and probably more macros) besides. > > The issue

Re: [libvirt] [PATCH] virtlockd: acquire locks on re-exec

On Fri, Mar 02, 2018 at 03:24:53PM -0700, Jim Fehlig wrote: > On 03/02/2018 11:12 AM, Daniel P. Berrangé wrote: > > On Fri, Mar 02, 2018 at 04:52:23PM +, Daniel P. Berrangé wrote: > > > On Thu, Mar 01, 2018 at 04:42:36PM -0700, Jim Fehlig wrote: > > > > Locks held by virtlockd are dropped on

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

On 03/05/2018 03:20 AM, Wuzongyong (Euler Dept) wrote: > Hi, > > We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF to > workerPool: > > static void > qemuProcessHandleMonitorEOF(qemuMonitorPtr mon, > virDomainObjPtr vm, >

Re: [libvirt] [tck PATCH v2 1/4] nwfilter tests: auto-add test appliance ssh key to known_hosts on host

On Thu, Mar 01, 2018 at 09:49:57PM -0500, Laine Stump wrote: > Without this option, attempts to ssh into the test appliance will fail > unless someone has previously ssh'ed into the appliance manually and > accepted its key. > > Signed-off-by: Laine Stump > --- Reviewed-by:

Re: [libvirt] [PATCH go-xml] fix type tag for rdp and destkop graphics devices

On Sun, Mar 04, 2018 at 10:41:43AM -0500, Ryan Goodfellow wrote: > The current behavior is to generate a type="vnc" tag in the > element generated from either a DomainGrapicRDP or DomainGraphicDesktop. > The correct tags should be type="rdp" and type="desktop" respectively. > This commit emits

[libvirt] [PATCHv2 3/6] tests: add qemumonitorjson tests for query-cpus-fast

Extended the json monitor test program with support for query-cpus-fast and added a sample file set for x86 data obtained using the it. Signed-off-by: Viktor Mihajlovski --- ...qemumonitorjson-cpuinfo-x86-full-fast-cpus.json | 71 +

[libvirt] [PATCHv2 5/6] tests: add testcase for s390 query-cpus-fast

The s390 testcase verifies that the s390-specific cpu-state field is correctly mapped to the halted property. Since a few of the x86 and ppc testcases return "halted": "true" it was necessary to update the respective .data files. Signed-off-by: Viktor Mihajlovski

[libvirt] [PATCHv2 1/6] qemu: add capability detection for query-cpus-fast

Detect whether QEMU supports the QMP query-cpus-fast API and set QEMU_CAPS_QUERY_CPUS_FAST in this case. Signed-off-by: Viktor Mihajlovski Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Acked-by:

[libvirt] [PATCHv2 4/6] qemu: add architecture-specific CPU info handling

Extract architecture specific data from query-cpus[-fast] if available. A new function qemuMonitorJSONExtractCPUArchInfo() uses a call-back table to find and call architecture-specific extraction handlers. Initially, there's a handler for s390 cpu info to set the halted property depending on the

[libvirt] [PATCHv2 2/6] qemu: use query-cpus-fast in JSON monitor

Use query-cpus-fast instead of query-cpus if supported by QEMU. Based on the QEMU_CAPS_QUERY_CPUS_FAST capability. Signed-off-by: Viktor Mihajlovski --- src/qemu/qemu_domain.c | 12 ++-- src/qemu/qemu_monitor.c | 30 ++

[libvirt] [PATCHv2 6/6] qemu: refresh vcpu halted state only via query-cpus-fast

In order to not affect running VMs, refreshing the halted state is only performed if QEMU supports the query-cpus-fast QAPI. Signed-off-by: Viktor Mihajlovski Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Monday, March 05, 2018 5:27 PM > To: Wuzongyong (Euler Dept) ; libvir- > l...@redhat.com > Cc: Wanzongshun (Vincent) ; weijinfen > >

[libvirt] Py3 compat nedeed Re: update keycodemapdb submodule for 4.1.0 release

On Thu, Mar 01, 2018 at 09:47:32AM -0700, Jim Fehlig wrote: > I mistakenly dropped keycodemapdb commit 6b3d716e from our libvirt 4.1.0 > builds only to stumble across the failures in py3 environments that are > fixed by that commit. Should the submodule be updated for the 4.1.0 release? BTW, we

Re: [libvirt] Py3 compat nedeed Re: update keycodemapdb submodule for 4.1.0 release

On 05/03/18 10:27, Daniel P. Berrangé wrote: > BTW, we just hit a problem with macOS homebrew changing python to > point to > a py3 binary and that showed other libvirt failures. In particular the ESX > code generator is broken under py2. I wouldn't be surprised if more of our > python scripts

[libvirt] [PATCHv2 0/6] Use query-cpus-fast instead of query-cpus

The QEMU monitor commmand query-cpus is deprecated starting with QEMU 2.12.0 because it can adversely affect the performance of a running virtual machine. This series enables libvirt to use the new query-cpus-fast interface if supported by the local QEMU instance and is required in order to

[libvirt] [PATCH python] Post-release version bump to 4.2.0

Signed-off-by: Daniel P. Berrangé --- Pushed as trivial change setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 63da8c5..c40908b 100755 --- a/setup.py +++ b/setup.py @@ -334,7 +334,7 @@ class my_clean(clean):

Re: [libvirt] [PATCH] virt-aa-helper: resolve yet to be created paths

Ping, I'd appreciate if somebody would find the time to review as I'd like to backport to 4.0 in Ubuntu soon. On Thu, Mar 1, 2018 at 3:53 PM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > In certain cases a xml contains paths that do not yet exist, but > are valid as qemu will

[libvirt] [PATCH] make sure libvirt is linked first

so it's not affected by flags that might be passed in $(*_LIBS) like -L/usr/lib which might result in linking against system library and requiring incorrect version of private symbols --- src/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am

[libvirt] [PATCH] util: mdev: Treat the 'name' sysfs attribute as optional

When commit 3545cbef moved the sysfs attribute reading logic from _udev.c module to virmdev.c, it had to replace our udev read wrappers with the ones available from virfile.c. The problem is that the original logic worked correctly with udev read wrappers which don't return an error code for a

Re: [libvirt] [tck PATCH v2 2/4] new NetworkHelper function get_network_ip()

On Mon, Mar 05, 2018 at 10:10:36AM -0500, Laine Stump wrote: > On 03/05/2018 04:31 AM, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 09:49:58PM -0500, Laine Stump wrote: > >> This function gets the first IP address for the named virtual > >> network. It is returned as a Net::IP object, so

Re: [libvirt] [PATCH] travis: force install of python2 into $PATH on macOS

On Mon, 2018-03-05 at 12:19 +, Daniel P. Berrangé wrote: > The homebrew formula's ignored Python PEP-0394 recommendations and > changed the plain python binary in /usr/local/bin to point to Python 3 > instead of Python 2. Python 2 is not even installed into a location that > is in $PATH by

Re: [libvirt] [PATCH] make sure libvirt is linked first

On Mon, Mar 05, 2018 at 03:04:48PM +0100, Jan Palus wrote: > so it's not affected by flags that might be passed in $(*_LIBS) like > -L/usr/lib which might result in linking against system library and > requiring incorrect version of private symbols Ewww, nasty problem. > --- > src/Makefile.am |

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: libvirt-master-mingw » libvirt-fedora-rawhide #1863

On Mon, Mar 05, 2018 at 02:28:37PM +, c...@centos.org wrote: > See > > > Changes: > > [jtomko] conf: set postParseFailed even without ALLOW_POST_PARSE_FAIL > > [berrange]

[libvirt] [PATCH] tests: force use of "NORMAL" TLS priority in test suite

When generating certificates we rely on GNUTLS' built-in default setup for the ciphers used in the certs. We then currently run with the distro specific TLS priority setup which can be much stronger, to the extent that the certificates we generate are considered untrustworthy. We don't care about

[libvirt] [PATCH] Post-release version bump to 4.2.0

Signed-off-by: Daniel P. Berrangé --- Pushed as trivial fix configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 5e720d1b76..970a695ad1 100644 --- a/configure.ac +++ b/configure.ac

Re: [libvirt] [tck PATCH v2 2/4] new NetworkHelper function get_network_ip()

On 03/05/2018 04:31 AM, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 09:49:58PM -0500, Laine Stump wrote: >> This function gets the first IP address for the named virtual >> network. It is returned as a Net::IP object, so that we will have info >> about its netmask/prefix and can easily get

Re: [libvirt] [PATCH v3] make sure libvirt is linked first

On Mon, Mar 05, 2018 at 04:39:48PM +0100, Jan Palus wrote: > so it's not affected by flags that might be passed in $(*_LIBS) like > -L/usr/lib which might result in linking against system library and > requiring incorrect version of private symbols > > Signed-off-by: Jan Palus

Re: [libvirt] [PATCH v2] make sure libvirt is linked first

On Mon, Mar 05, 2018 at 04:19:50PM +0100, Jan Palus wrote: > so it's not affected by flags that might be passed in $(*_LIBS) like > -L/usr/lib which might result in linking against system library and > requiring incorrect version of private symbols > > Signed-off-by: Jan Palus

Re: [libvirt] [PATCH] make sure libvirt is linked first

On 05.03.2018 14:21, Daniel P. Berrangé wrote: > Although you tripped up on DBUS_LIBS - it looks like there are quite a > few cases of this problem present in the various modules. > > eg libvirt_storage_backend_mpath_la_LIBADD can break if DEVMAPPER_LIBS > had similar issue. > > Same for

Re: [libvirt] [PATCH v5 11/12] qemu: Validate PCI controllers (QEMU capabilities)

On Fri, 2018-03-02 at 18:44 -0500, Laine Stump wrote: [...] > > +static int > > +virDomainControllerPCIModelNameToQEMUCaps(int modelName) > > +{ > > +switch ((virDomainControllerPCIModelName) modelName) { > > +case VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_PCI_BRIDGE: > > +return

[libvirt] [PATCH v6 02/11] qemu: Validate PCI controller options (modelName)

https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 226 +++-- 1 file changed, 142 insertions(+), 84 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v6 03/11] qemu: Validate PCI controller options (index)

https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 68 +++--- 1 file changed, 43 insertions(+), 25 deletions(-) diff --git

[libvirt] [PATCH v6 04/11] qemu: Validate PCI controller options (targetIndex)

https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 46 -- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH v5 03/12] qemu: Validate PCI controller options (modelName)

On Fri, 2018-03-02 at 16:16 -0500, Laine Stump wrote: [...] > > +/* modelName */ > > +switch ((virDomainControllerModelPCI) cont->model) { > > +case VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE: > > +case VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE: > > +case

[libvirt] [PATCH v3] make sure libvirt is linked first

so it's not affected by flags that might be passed in $(*_LIBS) like -L/usr/lib which might result in linking against system library and requiring incorrect version of private symbols Signed-off-by: Jan Palus --- src/Makefile.am | 29 +++--

[libvirt] [PATCH v6 08/11] qemu: Validate PCI controller options (chassisNr)

https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git

[libvirt] [PATCH v6 11/11] qemu: Remove old qemuDomainDeviceDefValidateControllerPCI()

We've implemented all existing checks, and more, in the new function, so we can finally drop the old one. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 21 + 1 file changed, 1 insertion(+), 20

[libvirt] [PATCH v6 10/11] qemu: Validate PCI controllers (QEMU capabilities)

Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 190 - 1 file changed, 77 insertions(+), 113 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH v6 09/11] qemu: Validate PCI controller options (chassis and port)

https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 50 +- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH v6 06/11] qemu: Validate PCI controller options (busNr)

This change catches an invalid use of the option in our test suite. https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 42

Re: [libvirt] [PATCH 00/17] Split up the src/Makefile.am even more

On 02/28/2018 11:14 AM, Daniel P. Berrangé wrote: > This is a continuation of my previous work to split src/Makefile.am > > This series does all the other non-virt drivers and utility code > directories. > > This is about as far as I'm intending to take it for now. > > This is for post-freeze

[libvirt] [PATCH v6 00/11] qemu: Validate PCI controller options

Applies cleanly on top of 11819aee65b8ea71860526f529d86ab646b9cd1f. Patches 2/11 and 4/11 are the only ones missing R-bs, everything else hasn't been significantly altered since the previous respin. Changes from [v5]: * patch 1 has been pushed; * add virReportController*() functions to cut

[libvirt] [PATCH v6 05/11] qemu: Validate PCI controller options (pcihole64)

https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v6 01/11] qemu: Create new qemuDomainDeviceDefValidateControllerPCI()

The existing function is renamed and called from the new one, so that even while we're in the process of implementing new checks all the existing ones will be performed. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c |

[libvirt] [PATCH v6 07/11] qemu: Validate PCI controller options (numaNode)

This change catches an invalid use of the option in our test suite. https://bugzilla.redhat.com/show_bug.cgi?id=1483816 Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 44

[libvirt] [PATCH v2] make sure libvirt is linked first

so it's not affected by flags that might be passed in $(*_LIBS) like -L/usr/lib which might result in linking against system library and requiring incorrect version of private symbols Signed-off-by: Jan Palus --- src/Makefile.am | 42

[libvirt] [PATCH 1/3] Extract stats functions from the qemu driver

Some of the qemu functions getting statistics can easily be reused in other drivers. Create a conf/domain_stats.[ch] pair to host some of them. --- src/Makefile.am | 1 + src/conf/domain_stats.c | 139 + src/conf/domain_stats.h | 64

[libvirt] [PATCH] cfg.mak: ignore trailing whitespace in gnulib local patches

The diff files in gnulib/local may well contain trailing whitespace. They are simply diff's of gnulib code which should not be modified to follow libvirt style rules. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix cfg.mk | 2 +- 1 file changed, 1

[libvirt] [PATCH 3/3] lxc: implement connectGetAllDomainStats

LXC containers can also provide some statistics. Allow users to fetch them using the existing API. --- src/lxc/lxc_driver.c | 203 +++ 1 file changed, 203 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index

[libvirt] [PATCH] gnulib: update to latest upstream changeset

Signed-off-by: Daniel P. Berrangé --- Pushed as trivial rule .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 7e7c5c7952..0404c9ae28 16 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit

[libvirt] [PATCH] gnulib: temporary hacks to deal with glibc libio.h removal

GLibc deprecated libio.h in 2.27 and has removed it in current code that will become 2.28. The latter is now in Fedora rawhide and this change breaks gnulib which mistakenly still relies on these ancient symbols. Add a local hack for gnulib until a proper fix is available upstream. Signed-off-by:

[libvirt] [PATCH 2/3] lxc: factorize code for block stats

lxcDomainBlockStats and lxcDomainBlockStatsFlags were both using very similar code. This commit factorizes them into a lxcDomainBlockStatsInternal. --- src/lxc/lxc_driver.c | 131 --- 1 file changed, 50 insertions(+), 81 deletions(-) diff --git

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: Yes, this worked on rawhide when I tested with libvirt. Thanks, I installed it into Gnulib since it was breaking builds. Bruno's the expert here, and perhaps he can come up with something better. -- libvir-list mailing list

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On Mon, Mar 05, 2018 at 11:00:40AM -0800, Paul Eggert wrote: > On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: > > I'm curious why we're trying to replace fseeko impl at all, since I > > would expect the modern glibc impl to be suitable to use as-is. > > It's to work around glibc bug#12799, a

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: I'm curious why we're trying to replace fseeko impl at all, since I would expect the modern glibc impl to be suitable to use as-is. It's to work around glibc bug#12799, a longstanding bug with ungetc and fflush. See the bug-gnulib thread that

Re: [libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

On 03/05/2018 01:21 PM, Cordius Wu wrote: > >> -Original Message- >> From: Michal Privoznik [mailto:mpriv...@redhat.com] >> Sent: Monday, March 5, 2018 8:09 PM >> To: Cordius Wu; 'Wuzongyong (Euler Dept)'; libvir-list@redhat.com >> Cc: 'Wanzongshun (Vincent)'; 'weijinfen' >> Subject: Re:

Re: [libvirt] [PATCH] make sure libvirt is linked first

On Mon, Mar 05, 2018 at 03:04:48PM +0100, Jan Palus wrote: > so it's not affected by flags that might be passed in $(*_LIBS) like > -L/usr/lib which might result in linking against system library and > requiring incorrect version of private symbols BTW, patches to libvirt also now require a

Re: [libvirt] [tck PATCH v2 2/4] new NetworkHelper function get_network_ip()

On 03/05/2018 10:15 AM, Daniel P. Berrangé wrote: > On Mon, Mar 05, 2018 at 10:10:36AM -0500, Laine Stump wrote: >> On 03/05/2018 04:31 AM, Daniel P. Berrangé wrote: >>> On Thu, Mar 01, 2018 at 09:49:58PM -0500, Laine Stump wrote: This function gets the first IP address for the named virtual

Re: [libvirt] [RFC PATCH v3 4/9] qemu: Add capabilities for optional pSeries features

Hi Andrea, This is wrt diffs for old qemus, which I picked from your git. diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.replies b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.replies index 065e2b4..a82438e 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.replies +++