Re: [libvirt] [PATCH 2/2] util: introduce virSocketAddrParseAny

2018-04-05 Thread Jim Fehlig
On 03/29/2018 11:27 AM, John Ferlan wrote: On 03/26/2018 04:29 PM, Jim Fehlig wrote: When preparing for migration, the libxl driver creates a new TCP listen socket for the incoming migration by calling virNetSocketNewListenTCP, passing the destination host name. virNetSocketNewListenTCP calls

Re: [libvirt] [PATCH 2/2] util: introduce virSocketAddrParseAny

2018-04-05 Thread Jim Fehlig
On 04/05/2018 02:55 PM, Jim Fehlig wrote: On 03/29/2018 11:27 AM, John Ferlan wrote: On 03/26/2018 04:29 PM, Jim Fehlig wrote: When preparing for migration, the libxl driver creates a new TCP listen socket for the incoming migration by calling virNetSocketNewListenTCP, passing the

[libvirt] [PATCH] util: fix spelling in virSocketAddrParseAny docs

2018-04-05 Thread Jim Fehlig
s/netork/network/ Signed-off-by: Jim Fehlig --- Pushing as trivial. src/util/virsocketaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 4f2457629..5c3bfad0a 100644 ---

[libvirt] [PATCH 0/6] Add support for TPM emulator and CRB interface

2018-04-05 Thread Stefan Berger
This series of patches add support for the new TPM CRB interface in QEMU that will become available with QEMU 2.12. The rest of the patches add support for the TPM emulator backend that is available in QEMU and based on swtpm + libtpms. Here I hope for feedback for how to organize the layout of

[libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-05 Thread Stefan Berger
This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will currently only start a TPM 1.2. Upon the first start, libvirt will run `swtpm_setup`, which will simulate the manufacturing of a TPM and create certificates for it and

[libvirt] [PATCH 3/6] tpm: Label the external swtpm with SELinux labels

2018-04-05 Thread Stefan Berger
In this patch we label the swtpm process with SELinux labels. We give it the same label as the QEMU process has. We label its state directory and files as well. The file and process labels now look as follows: [root@localhost tpm]# ls -lZ total 4 rwx--. 2 tss tss

[libvirt] [PATCH 4/6] tpm: Handle TPM emulator device reconfigurations

2018-04-05 Thread Stefan Berger
This patch looks at device changes due to modified XML. With the TPM emulator we have to handle cases where the TPM is removed from the VM or when it is reconfigured in some way. In the device removal case we remove the storage path. The function we create here will be used later to handle other

[libvirt] [PATCH 5/6] tpm: Add support for choosing emulation of a TPM 2

2018-04-05 Thread Stefan Berger
This patch extends the TPM's device XML with TPM 2 support. This only works for the emulator type backend and looks as follows: Once the version of a TPM has been chosen it cannot be changed anymore unless one removes the TPM device first and then reads it. However, one looses

[libvirt] [PATCH 1/6] tpm: Enable TPM CRB interface

2018-04-05 Thread Stefan Berger
Enable the TPM CRB interface added in QEMU 2.12. The TPM CRB interface is a simpler interface than the TPM TIS and should only be used with a TPM 2. Signed-off-by: Stefan Berger --- docs/formatdomain.html.in | 2 ++

[libvirt] [PATCH 6/6] tpm: Add swtpm to emulator cgroup

2018-04-05 Thread Stefan Berger
Add the external swtpm to the emulator cgroup so that upper limits of CPU usage can be enforced on the emulated TPM. To enable this we need to have the swtpm write its pid into a file. We then take the pid from this file to configure the emulator cgroup. Signed-off-by: Stefan Berger

[libvirt] [PATCH v4 1/3] util: Introduce virDevMapperGetTargets

2018-04-05 Thread Michal Privoznik
This helper fetches dependencies for given device mapper target. At the same time, we need to provide a dummy log function because by default libdevmapper prints out error messages to stderr which we need to suppress. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH v4 2/3] qemu_cgroup: Handle device mapper targets properly

2018-04-05 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1557769 Problem with device mapper targets is that there can be several other devices 'hidden' behind them. For instance, /dev/dm-1 can consist of /dev/sda, /dev/sdb and /dev/sdc. Therefore, when setting up devices CGroup and namespaces we have to take

[libvirt] [PATCH v4 0/3] Improve handling of multipath devices

2018-04-05 Thread Michal Privoznik
The saga continues. v3: https://www.redhat.com/archives/libvir-list/2018-April/msg00083.html diff to v3: - hopefully all Peter's review comments are worked in now. Michal Privoznik (3): util: Introduce virDevMapperGetTargets qemu_cgroup: Handle device mapper targets properly news:

[libvirt] [dbus PATCH v3 4/4] Implement NetworkLookupByName method for Connect interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 11 +++ 3 files changed, 46 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH v3 3/4] Implement Name property for Network interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 43 +++ test/Makefile.am | 3 ++- test/libvirttest.py | 12 test/test_network.py | 19

[libvirt] [dbus PATCH v3 1/4] Introduce Network Interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/Makefile.am | 3 ++- data/org.libvirt.Network.xml | 7 + src/Makefile.am | 3 ++- src/connect.c| 6 + src/connect.h| 1 + src/network.c| 64

Re: [libvirt] [dbus PATCH v3 1/4] Introduce Network Interface

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 12:40:17PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/Makefile.am | 3 ++- > data/org.libvirt.Network.xml | 7 + > src/Makefile.am | 3 ++- > src/connect.c| 6 + >

Re: [libvirt] [PATCH v2] docs: add page describing goals for host platform version support

2018-04-05 Thread Daniel P . Berrangé
On Thu, Apr 05, 2018 at 12:56:57PM +0200, Pavel Hrdina wrote: > On Thu, Apr 05, 2018 at 11:05:04AM +0100, Daniel P. Berrangé wrote: > > Described how we decide which host platforms to support for libvirt, > > which in turn makes it easier to decide when a platform / software > > version can be

Re: [libvirt] [PATCH v2 0/8] Prepare for daemon split

2018-04-05 Thread John Ferlan
On 04/05/2018 06:51 AM, Daniel P. Berrangé wrote: > When we split up the daemons, libvirtd will need to forward different > sets of APIs to different daemons. This means libvirtd is going to need > to have multiple virConnectPtr instances open. > > This series prepares for that by introducing

[libvirt] Libvirt master compilation failed

2018-04-05 Thread Mathieu Tarral
Hello, i have been trying to compile the latest libvirt from the Github mirror. I checked out on this commit: 3487973ee0c730b6fbfc6183af798c46ae3b85ff virjsontest: Use a more stable floating point number for testing But the compilation failed with this error: CC ssh.o CCLD

Re: [libvirt] [PATCH] docs: add page describing goals for host platform version support

2018-04-05 Thread Daniel P . Berrangé
On Tue, Apr 03, 2018 at 05:23:21PM +0200, Pavel Hrdina wrote: > On Tue, Apr 03, 2018 at 03:56:11PM +0100, Daniel P. Berrangé wrote: > > Describe how we decide which host platforms to support for libvirt, > > which in turn makes it easier to decide when a platform / software > > version can be

Re: [libvirt] [PATCH v4 1/3] util: Introduce virDevMapperGetTargets

2018-04-05 Thread Peter Krempa
On Thu, Apr 05, 2018 at 10:09:39 +0200, Michal Privoznik wrote: > This helper fetches dependencies for given device mapper target. > > At the same time, we need to provide a dummy log function because > by default libdevmapper prints out error messages to stderr which > we need to suppress. > >

[libvirt] [PATCH v2 6/8] remote: use a separate connection for nwfilter APIs

2018-04-05 Thread Daniel P . Berrangé
Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 3 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 10 insertions(+) diff --git

[libvirt] [PATCH v2 2/8] remote: push check for conn down into remoteClientFreePrivateCallbacks

2018-04-05 Thread Daniel P . Berrangé
There will shortly be many connection objects, so we should not assume a single check against priv->conn is sufficient. Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon_dispatch.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH v2 8/8] remote: use a separate connection for storage APIs

2018-04-05 Thread Daniel P . Berrangé
Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8

[libvirt] [PATCH v2 0/8] Prepare for daemon split

2018-04-05 Thread Daniel P . Berrangé
When we split up the daemons, libvirtd will need to forward different sets of APIs to different daemons. This means libvirtd is going to need to have multiple virConnectPtr instances open. This series prepares for that by introducing "separate" connections, which are actually just an extra

[libvirt] [PATCH v2 5/8] remote: use a separate connection for nodedev APIs

2018-04-05 Thread Daniel P . Berrangé
Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8

[libvirt] [PATCH v2 7/8] remote: use a separate connection for secret APIs

2018-04-05 Thread Daniel P . Berrangé
Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8

[libvirt] [PATCH v2 3/8] remote: use a separate connection for interface APIs

2018-04-05 Thread Daniel P . Berrangé
Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 4 src/rpc/gendispatch.pl | 25 - 3 files changed, 29

Re: [libvirt] [PATCH v4 2/3] qemu_cgroup: Handle device mapper targets properly

2018-04-05 Thread Peter Krempa
On Thu, Apr 05, 2018 at 10:09:40 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1557769 > > Problem with device mapper targets is that there can be several > other devices 'hidden' behind them. For instance, /dev/dm-1 can > consist of /dev/sda, /dev/sdb and /dev/sdc.

Re: [libvirt] [dbus PATCH v3 0/4] Introduce Network Interface

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 12:40:16PM +0200, Katerina Koukiou wrote: > This patchset introduces also some basic methods and properties for > Network interface. > More functionality will be added in following patchsets. > New functions are covered by the test suite. > > Changes from v2: > * Added

[libvirt] [PATCH v2] docs: add page describing goals for host platform version support

2018-04-05 Thread Daniel P . Berrangé
Described how we decide which host platforms to support for libvirt, which in turn makes it easier to decide when a platform / software version can be dropped. Signed-off-by: Daniel P. Berrangé --- docs/index.html.in | 2 +- docs/platforms.html.in | 105

[libvirt] [dbus PATCH v3 0/4] Introduce Network Interface

2018-04-05 Thread Katerina Koukiou
This patchset introduces also some basic methods and properties for Network interface. More functionality will be added in following patchsets. New functions are covered by the test suite. Changes from v2: * Added test_list_networks test. * xml files should group methods/signals/properties

[libvirt] [dbus PATCH v3 2/4] Implement ListNetworks method for Connect interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 41 + test/test_connect.py | 12 3 files changed, 59 insertions(+) diff --git

Re: [libvirt] [PATCH v2] docs: add page describing goals for host platform version support

2018-04-05 Thread John Ferlan
On 04/05/2018 06:05 AM, Daniel P. Berrangé wrote: > Described how we decide which host platforms to support for libvirt, > which in turn makes it easier to decide when a platform / software > version can be dropped. > > Signed-off-by: Daniel P. Berrangé > --- >

Re: [libvirt] Libvirt master compilation failed

2018-04-05 Thread Pino Toscano
Hi, On Thursday, 5 April 2018 13:54:17 CEST Mathieu Tarral wrote: > [...] > make[3]: Entering directory '/var/ansible/libvirt/po' > rm -f af.gmo && : -c --statistics -o af.gmo af.po > mv: cannot stat 't-af.gmo': No such file or directory > Makefile:470: recipe for target 'af.gmo' failed >

Re: [libvirt] [PATCH] docs: add page describing goals for host platform version support

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 10:54:53AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 03, 2018 at 05:23:21PM +0200, Pavel Hrdina wrote: > > On Tue, Apr 03, 2018 at 03:56:11PM +0100, Daniel P. Berrangé wrote: > > > Describe how we decide which host platforms to support for libvirt, > > > which in turn

Re: [libvirt] [PATCH v2] docs: add page describing goals for host platform version support

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 11:05:04AM +0100, Daniel P. Berrangé wrote: > Described how we decide which host platforms to support for libvirt, > which in turn makes it easier to decide when a platform / software > version can be dropped. > > Signed-off-by: Daniel P. Berrangé >

Re: [libvirt] [dbus PATCH v3 0/4] Introduce Network Interface

2018-04-05 Thread Katerina Koukiou
On Thu, 2018-04-05 at 12:51 +0200, Pavel Hrdina wrote: > On Thu, Apr 05, 2018 at 12:40:16PM +0200, Katerina Koukiou wrote: > > This patchset introduces also some basic methods and properties for > > Network interface. > > More functionality will be added in following patchsets. > > New functions

Re: [libvirt] [PATCH 1/7] rpc: refactor way connection object is generated for remote dispatch

2018-04-05 Thread Daniel P . Berrangé
On Wed, Apr 04, 2018 at 01:41:54PM -0400, John Ferlan wrote: > > > On 03/28/2018 11:18 AM, Daniel P. Berrangé wrote: > > Calling a push_privconn method to directly push the connection object > > name into the arg list is inconvenient. Refactor so that we acquire > > the connection variable name

Re: [libvirt] [PATCH 3/7] remote: use a separate connection for network APIs

2018-04-05 Thread Daniel P . Berrangé
On Wed, Apr 04, 2018 at 01:45:45PM -0400, John Ferlan wrote: > > > On 03/28/2018 11:18 AM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > src/remote/remote_daemon.h | 1 + > > src/remote/remote_daemon_dispatch.c | 19

[libvirt] [PATCH v2 1/8] rpc: refactor way connection object is generated for remote dispatch

2018-04-05 Thread Daniel P . Berrangé
Calling a push_privconn method to directly push the connection object name into the arg list is inconvenient. Refactor so that we acquire the connection variable name upfront, and push it to the arg list separately. This allows various hardcoded usage of "priv->conn" to be parameterized.

[libvirt] [PATCH v2 4/8] remote: use a separate connection for network APIs

2018-04-05 Thread Daniel P . Berrangé
Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/remote/remote_daemon.h | 1 + src/remote/remote_daemon_dispatch.c | 19 +++ src/rpc/gendispatch.pl | 6 ++ 3 files changed, 18 insertions(+), 8

Re: [libvirt] [PATCH v4 3/3] news: Document device mapper fix

2018-04-05 Thread Peter Krempa
On Thu, Apr 05, 2018 at 10:09:41 +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 12 > 1 file changed, 12 insertions(+) ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] qemu: cpu: fix fullCPU to include all emulatable qemu features

2018-04-05 Thread Nikolay Shirokovskiy
I've checked against latest upstream version of libvirt. Issue is still not fixed. I guess I should provide cpu data for tests like in next patch: Author: Jiri Denemark Date: Fri Jan 5 14:52:45 2018 +0100 cputest: Add data for Intel(R) Xeon(R) CPU E5-2609 v3

[libvirt] [PATCH v4 3/3] news: Document device mapper fix

2018-04-05 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 87f52e83ef..8521204a35 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -49,6 +49,18 @@ + +

Re: [libvirt] [PATCH] docs: Update the format of the generate metadata example

2018-04-05 Thread Erik Skultety
On Wed, Apr 04, 2018 at 04:23:54PM -0400, John Ferlan wrote: > Initially, update the UUID field to have the proper format, but > then also changed the type, id, and name fields. > > Signed-off-by: John Ferlan > --- > > While beginning to think more about the vmgenid RFC and

[libvirt] [jenkins-ci PATCH 02/10] guests: Enable ~/.bashrc on FreeBSD

2018-04-05 Thread Andrea Bolognani
Due to the way bash is compiled on FreeBSD, we need to flip an extra switch in order to convince it to process the shell profile even when we're running commands non-interactively through ssh. Signed-off-by: Andrea Bolognani --- guests/tasks/kludges.yml | 18

[libvirt] [jenkins-ci PATCH 00/10] guests: Improve enviroment handling

2018-04-05 Thread Andrea Bolognani
The basic goal is to move all environment configuration that affects builds to a single place which is tracked along with all other changes to the CI environment. Patch 8/10 also happens to fix build of packages that depend on libvirt-perl on FreeBSD now that they've switched to Perl 5.26, though

[libvirt] [jenkins-ci PATCH 01/10] guests: Rename compat -> kludges

2018-04-05 Thread Andrea Bolognani
This task only contains workarounds that we shouldn't have to worry about to begin with, and that hopefully in due time we'll be able to drop entirely. Rename it to make this more apparent. Signed-off-by: Andrea Bolognani --- guests/site.yml | 2 +-

[libvirt] [dbus PATCH] test: Don't hardcode python3 path

2018-04-05 Thread Andrea Bolognani
Using /usr/bin/python3 is fine for Linux, but it's not portable to other operating systems such as FreeBSD, where the binary lives under /usr/local/bin instead. Use /usr/bin/env to abstract the issue away. With this, 'make check' completes successfully on FreeBSD 10, 11 and -CURRENT.

[libvirt] [jenkins-ci PATCH 1/2] guests: Add libvirt-dbus project

2018-04-05 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml| 1 + guests/host_vars/libvirt-debian-9/main.yml| 1 + guests/host_vars/libvirt-debian-sid/main.yml | 1 + guests/host_vars/libvirt-fedora-26/main.yml | 1 +

Re: [libvirt] [dbus PATCH 07/10] Register Network Lifecycle Events

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:31PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 + > src/connect.c| 13 ++ > src/connect.h| 1 + > src/events.c | 60 >

Re: [libvirt] [dbus PATCH 02/10] Implement Autostart property for Network Interface

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:26PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 21 + > test/test_network.py | 1 + > 3 files changed, 26

Re: [libvirt] [dbus PATCH 01/10] Implement BridgeName property for Network interface.

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:25PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 23 +++ > test/test_network.py | 1 + > 3 files changed, 28

Re: [libvirt] [dbus PATCH 03/10] Implement UUID property for Network interface.

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:27PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 21 + > test/test_network.py | 1 + > 3 files changed, 26

Re: [libvirt] [dbus PATCH 01/10] Implement BridgeName property for Network interface.

2018-04-05 Thread Katerina Koukiou
On Thu, 2018-04-05 at 15:44 +0200, Pavel Hrdina wrote: > On Thu, Apr 05, 2018 at 03:29:25PM +0200, Katerina Koukiou wrote: > > Signed-off-by: Katerina Koukiou > > --- > > data/org.libvirt.Network.xml | 4 > > src/network.c| 23 +++ >

[libvirt] [jenkins-ci PATCH 0/2] Add libvirt-dbus project

2018-04-05 Thread Andrea Bolognani
Andrea Bolognani (2): guests: Add libvirt-dbus project projects: Add libvirt-dbus project guests/host_vars/libvirt-centos-7/main.yml| 1 + guests/host_vars/libvirt-debian-9/main.yml| 1 + guests/host_vars/libvirt-debian-sid/main.yml | 1 +

Re: [libvirt] [PATCH 01/68] qemu: Move qemuDomainCheckMigrationCapabilities

2018-04-05 Thread Ján Tomko
On Wed, Apr 04, 2018 at 04:40:50PM +0200, Jiri Denemark wrote: Since the function is tightly connected to migration, it was renamed as qemuMigrationCapsCheck and moved to qemu_migration.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c| 72

Re: [libvirt] Libvirt master compilation failed

2018-04-05 Thread Mathieu Tarral
> Forgot to install 'gettext', maybe. I was missing gettext indeed. I ran the autogen.sh again, then make, and the build was successful. I wonder why this wasn't spotted by the configure.sh script from autotools ? There is an issue to be fixed here. Thank you Pino ! -- Mathieu Tarral --

Re: [libvirt] [PATCH] qemu: cpu: fix fullCPU to include all emulatable qemu features

2018-04-05 Thread Jiri Denemark
On Thu, Apr 05, 2018 at 10:26:48 +0300, Nikolay Shirokovskiy wrote: > I've checked against latest upstream version of libvirt. Issue is still not > fixed. > > I guess I should provide cpu data for tests like in next patch: Yeah, CPU data would be helpful to see more details about the CPU. You

[libvirt] [dbus PATCH 02/10] Implement Autostart property for Network Interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 21 + test/test_network.py | 1 + 3 files changed, 26 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 10/10] Implement Create method for Network Interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 21 + test/test_network.py | 14 ++ 3 files changed, 39 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 09/10] Implement Undefine method for Network Interface

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 21 + test/test_network.py | 13 + 3 files changed, 38 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 04/10] Implement NetworkLookupByUUID method for network interface.

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 1 + 3 files changed, 36 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH 01/10] Implement BridgeName property for Network interface.

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 23 +++ test/test_network.py | 1 + 3 files changed, 28 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 03/10] Implement UUID property for Network interface.

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 21 + test/test_network.py | 1 + 3 files changed, 26 insertions(+) diff --git a/data/org.libvirt.Network.xml

[libvirt] [dbus PATCH 08/10] Implement Destroy method for Network Interface.

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 4 src/network.c| 21 + test/test_network.py | 13 + 3 files changed, 38 insertions(+) diff --git a/data/org.libvirt.Network.xml

Re: [libvirt] [dbus PATCH 06/10] Rename callback_ids variable to domain_callback_ids

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:30PM +0200, Katerina Koukiou wrote: > The callback_ids var is domain specific. > Renaming it now, so as to keep consistent naming when introducing > events for other entities. > > Signed-off-by: Katerina Koukiou > --- > src/connect.c | 8

[libvirt] [jenkins-ci PATCH 2/2] projects: Add libvirt-dbus project

2018-04-05 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- projects/libvirt-dbus.yaml | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 projects/libvirt-dbus.yaml diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml new file mode 100644

[libvirt] [PATCH] qemu: use target.port for isa-serial

2018-04-05 Thread Thilo Cestonaro
A configured target.port is currently totaly ignored, while contsructing qemu commandline, for all types of serial devices. This patch adds a -device parameter "index" for the target model isa-serial. This enables the user to specify which serial device will end in which ttySX device. ---

[libvirt] Run libvirtd from git: virsh hangs

2018-04-05 Thread Mathieu Tarral
Hi, I managed to compile libvirt from the git repo, now i have some trouble to run it. This is what i did: I configured the source to use /var because i wanted the socket to be at the same place as the system one (/var/run/libvirt/libvirt-sock) ./configure --prefix=$HOME/usr

Re: [libvirt] [dbus PATCH 08/10] Implement Destroy method for Network Interface.

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:32PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 21 + > test/test_network.py | 13 + > 3 files

[libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0

2018-04-05 Thread Ján Tomko
v2: * Change the version from 1.3.0 to 1.5.0 * Mention this breaks RHEL 6 QEMU and list the versions in relevant long-term releases Some of the patches are very big, available in my repo: https://repo.or.cz/libvirt/jtomko.git/shortlog/refs/heads/caps_cleanup_v2 git fetch

[libvirt] [libvirt PATCH v2 01/44] qemuxml2argvtest: Fix q35-virt-manager capabilities

2018-04-05 Thread Ján Tomko
Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT since it specifies . Signed-off-by: Ján Tomko --- tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +- tests/qemuxml2argvtest.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)

[libvirt] [jenkins-ci PATCH 10/10] guests: Remove per-host make variable

2018-04-05 Thread Andrea Bolognani
We are figuring out which make binary we should use dynamically in the shell profile now, so this variable is redundant; plus, we were not actually using it anywhere. Signed-off-by: Andrea Bolognani --- guests/group_vars/all/main.yml| 1 -

Re: [libvirt] [PATCH v2] docs: add page describing goals for host platform version support

2018-04-05 Thread Andrea Bolognani
On Thu, 2018-04-05 at 11:05 +0100, Daniel P. Berrangé wrote: > Described how we decide which host platforms to support for libvirt, > which in turn makes it easier to decide when a platform / software > version can be dropped. > > Signed-off-by: Daniel P. Berrangé > --- >

[libvirt] [jenkins-ci PATCH 06/10] guests: Move $PATH configuration to shell profile

2018-04-05 Thread Andrea Bolognani
Same as for $MAKE, moving the configuration here makes it easier to reproduce issues outside of the CI environment. Signed-off-by: Andrea Bolognani --- guests/group_vars/all/main.yml | 6 -- guests/templates/bashrc| 2 ++ jobs/defaults.yaml | 1 - 3

[libvirt] [jenkins-ci PATCH 05/10] guests: Move make configuration to shell profile

2018-04-05 Thread Andrea Bolognani
Now that we have our custom shell profile, we can pick the correct make variant dynamically there instead of doing it in the Jenkins job definition, so that the $MAKE variable will also be available when using the guests outside of the CI environment. Signed-off-by: Andrea Bolognani

[libvirt] [jenkins-ci PATCH 09/10] guests: Add Python configuration to shell profile

2018-04-05 Thread Andrea Bolognani
This is conceptually identical to how Perl is handled, except that we still need to override $PYTHONPATH in Jenkins jobs in order to be able to build projects using both Python 3 and Python 2 on the same guest. We might want to reconsider that decision, but for the time being this change is still

[libvirt] [jenkins-ci PATCH 03/10] guests: Add custom shell profile

2018-04-05 Thread Andrea Bolognani
We want to take control of the user's environment. For now the custom shell profile only sets the prompt, but it will later be used to influence the build environment. Signed-off-by: Andrea Bolognani --- guests/tasks/users.yml| 17 +

[libvirt] [jenkins-ci PATCH 04/10] guests: Move ccache configuration to shell profile

2018-04-05 Thread Andrea Bolognani
Now that we have our custom shell profile, making sure ccache is used is way simpler. Signed-off-by: Andrea Bolognani --- guests/tasks/users.yml | 18 -- guests/templates/bashrc | 2 ++ 2 files changed, 2 insertions(+), 18 deletions(-) diff --git

[libvirt] [jenkins-ci PATCH 08/10] guests: Move Perl configuration to shell profile

2018-04-05 Thread Andrea Bolognani
Same as for $VIRT_PREFIX and friends, we want these to be tracked along with the rest of the CI setup instead of being a completely opaque, side-loaded blob. Signed-off-by: Andrea Bolognani --- guests/group_vars/all/main.yml| 1 +

[libvirt] [jenkins-ci PATCH 07/10] guests: Add more enviroment variables to shell profile

2018-04-05 Thread Andrea Bolognani
All these are currently defined per-worker at the Jenkins level, which has several disadvantages: first of all, they are completely invisible to anyone except people with admin access to the Jenkins instance; moreover, updating them requires a lot of clicking in the web interface, and change

[libvirt] [libvirt PATCH v2 02/44] Delete bogus cpu-host-passthrough test

2018-04-05 Thread Ján Tomko
We test the same XML for a type='kvm' domain twice, once with QEMU_CAPS_KVM (expecting success), once without (expecting failure). The failure case relies on QEMU_CAPS_MACHINE_OPT not being set, failing in qemuBuildObsoleteAccelArg. Checking a domain-type error message in a cpu test is strange.

[libvirt] [dbus PATCH 07/10] Register Network Lifecycle Events

2018-04-05 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 + src/connect.c| 13 ++ src/connect.h| 1 + src/events.c | 60 4 files changed, 80 insertions(+)

[libvirt] [dbus PATCH 00/10] Impement some APIs for network Interface

2018-04-05 Thread Katerina Koukiou
Katerina Koukiou (10): Implement BridgeName property for Network interface. Implement Autostart property for Network Interface Implement UUID property for Network interface. Implement NetworkLookupByUUID method for network interface. Rename virtDBusEventsRegisterEvent to

[libvirt] [dbus PATCH 05/10] Rename virtDBusEventsRegisterEvent to virtDBusDomainEventsRegisterEvent

2018-04-05 Thread Katerina Koukiou
This function was specific to Domain Lifecycle Events. Rename it now, so that we can keep consistent naming when introducing Events for other entities. Signed-off-by: Katerina Koukiou --- src/events.c | 36 ++-- 1 file changed, 18

[libvirt] [dbus PATCH 06/10] Rename callback_ids variable to domain_callback_ids

2018-04-05 Thread Katerina Koukiou
The callback_ids var is domain specific. Renaming it now, so as to keep consistent naming when introducing events for other entities. Signed-off-by: Katerina Koukiou --- src/connect.c | 8 src/connect.h | 2 +- src/events.c | 16 3 files

Re: [libvirt] [dbus PATCH 05/10] Rename virtDBusEventsRegisterEvent to virtDBusDomainEventsRegisterEvent

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:29PM +0200, Katerina Koukiou wrote: > This function was specific to Domain Lifecycle Events. > Rename it now, so that we can keep consistent naming when introducing > Events for other entities. > > Signed-off-by: Katerina Koukiou > --- >

Re: [libvirt] [dbus PATCH 04/10] Implement NetworkLookupByUUID method for network interface.

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:28PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 29 + > test/test_connect.py | 1 + > 3 files changed,

Re: [libvirt] Run libvirtd from git: virsh hangs

2018-04-05 Thread Michal Privoznik
On 04/05/2018 03:59 PM, Mathieu Tarral wrote: > Hi, > > I managed to compile libvirt from the git repo, > now i have some trouble to run it. > > This is what i did: > > I configured the source to use /var because i wanted the socket > to be at the same place as the system one >

Re: [libvirt] [dbus PATCH 10/10] Implement Create method for Network Interface

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:34PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 21 + > test/test_network.py | 14 ++ > 3 files

Re: [libvirt] [PATCH v4 3/3] news: Document device mapper fix

2018-04-05 Thread Michal Privoznik
On 04/05/2018 12:51 PM, Peter Krempa wrote: > On Thu, Apr 05, 2018 at 10:09:41 +0200, Michal Privoznik wrote: >> Signed-off-by: Michal Privoznik >> --- >> docs/news.xml | 12 >> 1 file changed, 12 insertions(+) > > ACK > I've pushed these. Thanks, Michal --

[libvirt] [jenkins-ci PATCH 2/2] jobs: Build using $PYTHON

2018-04-05 Thread Andrea Bolognani
The current setup is fairly complicated and doesn't buy us much in terms of coverage: we can default to Python 3 wherever it's available, and still test Python 2 builds pass thanks to CentOS, which doesn't have Python 3 yet, and the RPM build jobs, which build both variants if at all possible.

Re: [libvirt] Run libvirtd from git: virsh hangs

2018-04-05 Thread Mathieu Tarral
> strace isn't very helpful for debugging hangs - better to connect to > libvirtd with GDB and get a stack trace of all threads, using > > (gdb) thread apply all bt This is what i have with GDB (gdb) thread apply all bt Thread 1 (Thread 0x7f8b18e7c700 (LWP 4196)): #0

Re: [libvirt] Run libvirtd from git: virsh hangs

2018-04-05 Thread Daniel P . Berrangé
On Thu, Apr 05, 2018 at 06:11:44PM +0300, Mathieu Tarral wrote: > > You can enable debugging for virsh too: > > > > LIBVIRT_DEBUG=1 ./tools/virsh list --all > > > > Alternatively, you can run the libvirtd under strace to see if it > > accepts() the connection request. Seems like virsh is trying to

[libvirt] [jenkins-ci PATCH 0/2] jobs: Simplify Python jobs

2018-04-05 Thread Andrea Bolognani
By reverting a bunch of semi-recent changes. Requires https://www.redhat.com/archives/libvir-list/2018-April/msg00356.html Andrea Bolognani (2): jobs: Don't set $PYTHONPATH for python-distutil jobs jobs: Build using $PYTHON jobs/python-distutils.yaml | 29 +

[libvirt] [jenkins-ci PATCH 1/2] jobs: Don't set $PYTHONPATH for python-distutil jobs

2018-04-05 Thread Andrea Bolognani
Now that $PYTHONPATH is set in the environment through the shell profile, we no longer need to set it at the Jenkins level for the virt-manager build to succeed. This reverts commit 6116509ac308562f69d533651d40599a7ce36b39. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [dbus PATCH 09/10] Implement Undefine method for Network Interface

2018-04-05 Thread Pavel Hrdina
On Thu, Apr 05, 2018 at 03:29:33PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Network.xml | 4 > src/network.c| 21 + > test/test_network.py | 13 + > 3 files

  1   2   >