Re: [libvirt] [PATCH 0/4] Introduce wildcard to log filters

2018-04-09 Thread Erik Skultety
On Tue, Apr 03, 2018 at 10:45:45AM +0200, Erik Skultety wrote: > First, 2 tiny fixes along the way, then the actual change, which lets you do > the following for example during runtime: > virt-admin daemon-log-filters "1:* 4:remote 4:json" > > which previously, given the default config setting log_

Re: [libvirt] [PATCH 3/4] util: virlog: Introduce wildcard to log filters

2018-04-09 Thread Erik Skultety
On Fri, Apr 06, 2018 at 03:00:14PM +0200, Ján Tomko wrote: > On Tue, Apr 03, 2018 at 10:45:48AM +0200, Erik Skultety wrote: > > Since the introduction of log tuning capabilities to virt-admin by > > @06b91785, this has been a much needed missing improvement on the way to > > deprecate the global 'l

Re: [libvirt] [PATCH 03/11] conf: Remove dubious code from virDomainPCIAddressSetGrow()

2018-04-09 Thread Andrea Bolognani
On Fri, 2018-04-06 at 14:23 -0400, Laine Stump wrote: > So it turns out that once all of your patches are applied, the error is > the same before or after this code is removed, so I think it may not be > executed at all. > > > Since it doesn't solve the issue it originally was intended to solve,

Re: [libvirt] [jenkins-ci PATCH 12/10] guests: Enable bash completion by default

2018-04-09 Thread Pavel Hrdina
On Fri, Apr 06, 2018 at 05:22:37PM +0200, Andrea Bolognani wrote: > In order for bash completion to be available right after login > we need to make sure the corresponding package is installed and, > for FreeBSD only, the enviroment script gets sourced. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Thomas Huth
Hi Laszlo, On 07.04.2018 02:01, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. > > Each firmware executable installed on a host system should come with a > JSON file that conforms to this schema, and informs the management > applications about the f

Re: [libvirt] Permissions and ownership on /dev/kvm keep reverting after starting a vm

2018-04-09 Thread Michal Privoznik
On 04/06/2018 11:40 PM, Tom wrote: > Hey guys, > > /dev/kvm permissions and ownership keeps reverting after starting a vm. > > The ownership and permissions keep going back to > > crw-rw—— root root > > After starting a vm. I have to revert the perms and ownership to: > > crw-crw-crw ro

Re: [libvirt] [PATCH 1/2] qemu: Fix qemuProcessAutoDestroy

2018-04-09 Thread Marc Hartmayer
On Thu, Mar 29, 2018 at 02:48 PM +0200, John Ferlan wrote: > Upon entry from virCloseCallbacksRun, the @dom will have a > Ref and Lock from virDomainObjListFindByUUIDRef, so there's > no need to take an extra reference nor should the code call > virDomainObjEndAPI when done since that both Unref's

Re: [libvirt] [PATCH 2/2] util: Alter virCloseCallback typedef to return void

2018-04-09 Thread Marc Hartmayer
On Thu, Mar 29, 2018 at 02:48 PM +0200, John Ferlan wrote: > Since virCloseCallbacksRun was ignoring the value anyway, let's > just change it to be a void function. > > Signed-off-by: John Ferlan > --- > src/bhyve/bhyve_process.c| 8 ++-- > src/lxc/lxc_process.c| 8 ++-- > sr

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Thomas Huth
On 07.04.2018 02:01, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. [...] > +## > +# @SystemFirmware: > +# > +# Describes a system firmware binary and any NVRAM slots that it requires. > +# > +# @executable: Identifies the platform firmware executable.

Re: [libvirt] Permissions and ownership on /dev/kvm keep reverting after starting a vm

2018-04-09 Thread Daniel P . Berrangé
On Fri, Apr 06, 2018 at 05:40:39PM -0400, Tom wrote: > Hey guys, > > /dev/kvm permissions and ownership keeps reverting after starting a vm. > > The ownership and permissions keep going back to > > crw-rw—— root root > > After starting a vm. I have to revert the perms and ownership to: >

Re: [libvirt] [jenkins-ci PATCH 12/10] guests: Enable bash completion by default

2018-04-09 Thread Andrea Bolognani
On Mon, 2018-04-09 at 09:22 +0200, Pavel Hrdina wrote: [...] > > diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml > > index a0483d8..49d4d2e 100644 > > --- a/guests/vars/projects/base.yml > > +++ b/guests/vars/projects/base.yml > > @@ -4,6 +4,7 @@ packages: > >- automa

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Gerd Hoffmann
> > +{ 'enum' : 'SystemFirmwareType', > > + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } > > The naming here is quite a bad mixture between firmware interface > ('bios', 'uefi') and firmware implementations ('slof', 'uboot'). There > could be other implementations of BIOS or UEFI than SeaBIOS a

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Gerd Hoffmann
> +# { > +# "executable": { > +# "pathname": "/usr/share/OVMF/OVMF_CODE.secboot.fd", > +# "description": "OVMF with Secure Boot and SMM-protected varstore", > +# "tags": [ > +# "FD_SIZE_4MB", > +# "IA32X64", > +# "SECURE_BOOT_ENABLE",

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

2018-04-09 Thread Daniel P . Berrangé
On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. > > Each firmware executable installed on a host system should come with a > JSON file that conforms to this schema, and informs the management > applications abo

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-04-09 Thread Kashyap Chamarthy
On Fri, Apr 06, 2018 at 08:21:00PM +0200, Laszlo Ersek wrote: > On 04/06/18 20:10, Eric Blake wrote: [...] > # key=value pairs also support Python or JSON object literal subset notations, > # without spaces. Dictionaries/objects {} are supported as are arrays []. > # > #example-command arg-na

Re: [libvirt] [jenkins-ci PATCH 12/10] guests: Enable bash completion by default

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 10:11:23AM +0200, Andrea Bolognani wrote: > On Mon, 2018-04-09 at 09:22 +0200, Pavel Hrdina wrote: > [...] > > > diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml > > > index a0483d8..49d4d2e 100644 > > > --- a/guests/vars/projects/base.yml > > > +++

[libvirt] [dbus PATCH 0/8] Properties/Methods for Connect Interface

2018-04-09 Thread Katerina Koukiou
Plus some minor fixes. Katerina Koukiou (8): Implement Capabilities property for connect Interface Implement Hostname property for Connect Interface Implement LibVersion property for Connect Interface Implement Encrypted property for Connect Interface Implement Secure property for Connec

[libvirt] [dbus PATCH 6/8] Implement GetSysinfo method for connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 27 +++ test/test_connect.py | 4 3 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 84

[libvirt] [dbus PATCH 1/8] Implement Capabilities property for connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index e36b7f6..caf0a

[libvirt] [dbus PATCH 5/8] Implement Secure property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 3791251..84163

[libvirt] [dbus PATCH 2/8] Implement Hostname property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index caf0a47..264f8

[libvirt] [dbus PATCH 4/8] Implement Encrypted property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 5548820..37912

[libvirt] [dbus PATCH 8/8] Removing G_GNUC_UNUSED in cases where the parameter is used

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- src/domain.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/domain.c b/src/domain.c index a530987..0066788 100644 --- a/src/domain.c +++ b/src/domain.c @@ -311,7 +311,7 @@ virtDBusDomainGetStats(GVariant *inArgs, } static

[libvirt] [dbus PATCH 3/8] Implement LibVersion property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 19 +++ test/test_connect.py | 1 + 3 files changed, 24 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 264f84c..554882

[libvirt] [dbus PATCH 7/8] All functions in src/connect.c should have virtDBusConnect prefix.

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- src/connect.c | 80 +-- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/src/connect.c b/src/connect.c index 7f9344e..1ff3341 100644 --- a/src/connect.c +++ b/src/connect.c @@ -301,13 +301,1

Re: [libvirt] [dbus PATCH 1/8] Implement Capabilities property for connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:32PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 25 insertions(+) Adding Dan to C

Re: [libvirt] [dbus PATCH 2/8] Implement Hostname property for Connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:33PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 25 insertions(+) Reviewed-by: Pa

Re: [libvirt] [dbus PATCH 3/8] Implement LibVersion property for Connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:34PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 19 +++ > test/test_connect.py | 1 + > 3 files changed, 24 insertions(+) Reviewed-by: Pav

Re: [libvirt] [dbus PATCH 4/8] Implement Encrypted property for Connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:35PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 25 insertions(+) This and the Se

Re: [libvirt] [dbus PATCH 6/8] Implement GetSysinfo method for connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:37PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 27 +++ > test/test_connect.py | 4 > 3 files changed, 37 insertions(+) Rev

[libvirt] [PATCH] qemu: use target.port for isa-serial

2018-04-09 Thread Thilo Cestonaro
A configured target.port is currently totaly ignored, while contsructing qemu commandline, for all types of serial devices. This patch adds a -device parameter "index" for the target model isa-serial. This enables the user to specify which serial device will end in which ttySX device. Signed-off-b

Re: [libvirt] [dbus PATCH 7/8] All functions in src/connect.c should have virtDBusConnect prefix.

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:38PM +0200, Katerina Koukiou wrote: s/.// in $subject > Signed-off-by: Katerina Koukiou > --- > src/connect.c | 80 > +-- > 1 file changed, 40 insertions(+), 40 deletions(-) Reviewed-by: Pavel Hrdina sign

Re: [libvirt] [dbus PATCH 8/8] Removing G_GNUC_UNUSED in cases where the parameter is used

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:47:39PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > src/domain.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature -- libvir-list mailing list libvir-lis

Re: [libvirt] [dbus PATCH 1/8] Implement Capabilities property for connect Interface

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 02:25:04PM +0200, Pavel Hrdina wrote: > On Mon, Apr 09, 2018 at 01:47:32PM +0200, Katerina Koukiou wrote: > > Signed-off-by: Katerina Koukiou > > --- > > data/org.libvirt.Connect.xml | 4 > > src/connect.c| 20 > > test/test_conne

Re: [libvirt] [dbus PATCH 4/8] Implement Encrypted property for Connect Interface

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 02:40:27PM +0200, Pavel Hrdina wrote: > On Mon, Apr 09, 2018 at 01:47:35PM +0200, Katerina Koukiou wrote: > > Signed-off-by: Katerina Koukiou > > --- > > data/org.libvirt.Connect.xml | 4 > > src/connect.c| 20 > > test/test_conne

Re: [libvirt] [PATCH] qemu: use target.port for isa-serial

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 02:41:55PM +0200, Thilo Cestonaro wrote: > A configured target.port is currently totaly ignored, while contsructing > qemu commandline, for all types of serial devices. This patch adds a -device > parameter "index" for the target model isa-serial. > This enables the user to

Re: [libvirt] [dbus PATCH 4/8] Implement Encrypted property for Connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 01:49:07PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 02:40:27PM +0200, Pavel Hrdina wrote: > > On Mon, Apr 09, 2018 at 01:47:35PM +0200, Katerina Koukiou wrote: > > > Signed-off-by: Katerina Koukiou > > > --- > > > data/org.libvirt.Connect.xml | 4 >

Re: [libvirt] [dbus PATCH 1/8] Implement Capabilities property for connect Interface

2018-04-09 Thread Katerina Koukiou
On Mon, 2018-04-09 at 13:45 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 02:25:04PM +0200, Pavel Hrdina wrote: > > On Mon, Apr 09, 2018 at 01:47:32PM +0200, Katerina Koukiou wrote: > > > Signed-off-by: Katerina Koukiou > > > --- > > > data/org.libvirt.Connect.xml | 4 > > > sr

[libvirt] [jenkins-ci PATCH] guests: Clean up packages after update

2018-04-09 Thread Andrea Bolognani
The package cache can grow to eat up a lot of disk space, and not removing unused packages can lead to upgrade issues down the line for fast moving distributions such as Fedora Rawhide. Signed-off-by: Andrea Bolognani --- guests/tasks/base.yml | 19 +++ 1 file changed, 19 inserti

[libvirt] [dbus PATCH v2 0/8] Properties/Methods for Connect Interface

2018-04-09 Thread Katerina Koukiou
Plus some minor fixes. Changes from v1: * Cabalitities property rewritten as method as dnb suggested. * Added documentation on Secure and Encrypted properties as discussed. Katerina Koukiou (8): Implement GetCapabilities method for connect Interface Implement Hostname property for Connect Int

[libvirt] [dbus PATCH v2 2/8] Implement Hostname property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 91faa73..d7542

[libvirt] [dbus PATCH v2 1/8] Implement GetCapabilities method for connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 23 +++ test/test_connect.py | 3 +++ 3 files changed, 31 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index e36b7f6.

[libvirt] [dbus PATCH v2 6/8] Implement GetSysinfo method for connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 27 +++ test/test_connect.py | 4 3 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 10

[libvirt] [dbus PATCH v2 7/8] All functions in src/connect.c should have virtDBusConnect prefix

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- src/connect.c | 80 +-- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/src/connect.c b/src/connect.c index eb4c74d..9820de5 100644 --- a/src/connect.c +++ b/src/connect.c @@ -304,13 +304,1

[libvirt] [dbus PATCH v2 3/8] Implement LibVersion property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 4 src/connect.c| 19 +++ test/test_connect.py | 1 + 3 files changed, 24 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index d754235..0e5c7e

[libvirt] [dbus PATCH v2 5/8] Implement Secure property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 26 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 84eadb0..10bd

[libvirt] [dbus PATCH v2 4/8] Implement Encrypted property for Connect Interface

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 26 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 0e5c7e2..84ea

[libvirt] [dbus PATCH v2 8/8] Removing G_GNUC_UNUSED in cases where the parameter is used

2018-04-09 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- src/domain.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/domain.c b/src/domain.c index a530987..0066788 100644 --- a/src/domain.c +++ b/src/domain.c @@ -311,7 +311,7 @@ virtDBusDomainGetStats(GVariant *inArgs, } static

Re: [libvirt] [dbus PATCH v2 1/8] Implement GetCapabilities method for connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 04:00:51PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 23 +++ > test/test_connect.py | 3 +++ > 3 files changed, 31 insertions(+) Reviewed-

Re: [libvirt] [dbus PATCH v2 4/8] Implement Encrypted property for Connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 04:00:54PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 26 insertions(+) > > diff --git

Re: [libvirt] [dbus PATCH v2 5/8] Implement Secure property for Connect Interface

2018-04-09 Thread Pavel Hrdina
On Mon, Apr 09, 2018 at 04:00:55PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 26 insertions(+) > > diff --git

Re: [libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

2018-04-09 Thread Marc Hartmayer
On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Because we allow a QEMU_JOB_DESTROY to occur while we're starting > up and we drop the @vm lock prior to qemuMonitorOpen, it's possible > that a domain destroy operation "wins" the race, calls qemuProcessStop > which will free and reinit

Re: [libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefNew for vhostuser

2018-04-09 Thread Marc Hartmayer
On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Rather than using VIR_ALLOC, use the New API since we already > use the virDomainChrSourceDefFree function when done. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libvirt] [PATCH V2 2/8] tests: move sexpr2xml tests to WITH_LIBXL

2018-04-09 Thread Daniel P . Berrangé
On Fri, Apr 06, 2018 at 02:44:54PM -0600, Jim Fehlig wrote: > In preparation of removing the legacy Xen driver, move the > sexpr2xml tests from WITH_XEN to WITH_LIBXL. Even though the > legacy driver will be removed, we'll want to maintain the ability > to convert sexpr to XML. Requires fixing up t

Re: [libvirt] [PATCH 2/4] qemu: Use virDomainChrSourceDefNew for monConfig

2018-04-09 Thread Marc Hartmayer
On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Rather than VIR_ALLOC, use the New function for allocation. We > already use the Free function anyway. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 2 +- > src/conf/domain_conf.h | 3 +++ > src/libvirt_private.sy

Re: [libvirt] [PATCH V2 0/8] Remove the legacy xen driver

2018-04-09 Thread Daniel P . Berrangé
On Fri, Apr 06, 2018 at 02:44:52PM -0600, Jim Fehlig wrote: > Long overdue removal the old xen driver. The first 3 patches move existing > tests to WITH_LIBXL since we'll want to continue supporting conversion of > the various xen config formats. The remain patches remove the cruft. > > Patch8, ne

Re: [libvirt] [libvirt PATCH v2 01/44] qemuxml2argvtest: Fix q35-virt-manager capabilities

2018-04-09 Thread Andrea Bolognani
On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT > since it specifies . > > Signed-off-by: Ján Tomko > --- > tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +- > tests/qemuxml2argvtest.c | 2 ++ > 2

Re: [libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0

2018-04-09 Thread Andrea Bolognani
On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > v2: > * Change the version from 1.3.0 to 1.5.0 > * Mention this breaks RHEL 6 QEMU and list the versions > in relevant long-term releases > > Some of the patches are very big, available in my repo: > https://repo.or.cz/libvirt/jtomko.git/shortl

Re: [libvirt] [PATCH 3/4] conf: Convert virDomainChrSourceDefNew to return object

2018-04-09 Thread Marc Hartmayer
On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Let's use object referencing to handle the ChrSourceDef. A subsequent > patch then can allow the monConfig to take an extra reference before > dropping the domain lock to then ensure nothing free's the memory that > needs to be used. > >

Re: [libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

2018-04-09 Thread Marc Hartmayer
On Mon, Apr 09, 2018 at 04:25 PM +0200, Marc Hartmayer wrote: > On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan > wrote: >> Because we allow a QEMU_JOB_DESTROY to occur while we're starting >> up and we drop the @vm lock prior to qemuMonitorOpen, it's possible >> that a domain destroy opera

Re: [libvirt] Race condition between qemuDomainCreate and qemuDomainDestroy

2018-04-09 Thread Marc Hartmayer
On Fri, Apr 06, 2018 at 06:27 PM +0200, John Ferlan wrote: > On 04/03/2018 07:47 AM, Marc Hartmayer wrote: >> On Tue, Mar 20, 2018 at 11:25 AM +0100, Marc Hartmayer >> wrote: >>> Hi, >>> >>> there is a race condition between 'qemuDomainCreate' and >>> 'qemuDomainDestroy' causing a NULL pointer s

Re: [libvirt] [libvirt PATCH v2 02/44] Delete bogus cpu-host-passthrough test

2018-04-09 Thread Andrea Bolognani
On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > We test the same XML for a type='kvm' domain twice, once with > QEMU_CAPS_KVM (expecting success), once without (expecting failure). > > The failure case relies on QEMU_CAPS_MACHINE_OPT not being set, > failing in qemuBuildObsoleteAccelArg. >

[libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

2018-04-09 Thread Katerina Koukiou
In C and XML files the order is: 1) properties 2) methods 3) signals All of them sorted in their category alphabetically. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 12 +-- data/org.libvirt.Domain.xml | 54 ++-- src/connect.c| 2 +- src/domain

[libvirt] [libvirt PATCH v2 05/44] Deprecate QEMU_CAPS_PCI_MULTIFUNCTION

2018-04-09 Thread Ján Tomko
Supported since QEMU 0.13, but we require QEMU 0.15. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 15 -- tests/qemucapabilitiesdata/caps

[libvirt] [libvirt PATCH v2 08/44] Remove unused qemuDomainNetVLAN

2018-04-09 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 6 -- src/qemu/qemu_domain.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 37837c8cf3..fab1519969 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9192,12 +9

[libvirt] [libvirt PATCH v2 06/44] Deprecate QEMU_CAPS_NETDEV

2018-04-09 Thread Ján Tomko
This makes qemuDomainSupportsNetdev identical to qemuDomainSupportsNicdev and leaves some code in qemuDomainAttachNetDevice to be cleaned up later. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +-

[libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

2018-04-09 Thread Ján Tomko
We require QEMU >= 0.15.0, assume every QEMU supports it. Sadly that does not let us trivially drop qemuMonitor's priv->monJSON bool, because of qemuDomainQemuAttach. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h

[libvirt] [libvirt PATCH v2 09/44] Remove qemuDomainSupportsNetdev

2018-04-09 Thread Ján Tomko
Now that we assume QEMU_CAPS_NETDEV, the only thing left to check is whether we need to use the legacy -net syntax because of a non-conforming armchitecture. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 20 +--- src/qemu/qemu_domain.c| 10 -- src/qemu/qemu

[libvirt] [libvirt PATCH v2 07/44] Clean up qemuDomainAttachNetDevice

2018-04-09 Thread Ján Tomko
Now that we assume -netdev support, we no longer set the VLAN or need the hostPlugged bool. Signed-off-by: Ján Tomko --- src/qemu/qemu_hotplug.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qem

[libvirt] [libvirt PATCH v2 12/44] Deprecate QEMU_CAPS_MEM_PATH

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 12 ++ tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |

[libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 +--- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 9 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1

[libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used when QEMU_CAPS_NO_USER_CONFIG is unsupported. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h

[libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 20 tests/qemucapabilitiesdata/caps_1.5.3.

[libvirt] [libvirt PATCH v2 21/44] Deprecate QEMU_CAPS_NAME_PROCESS

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 3 +-- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/

[libvirt] [libvirt PATCH v2 29/44] Deprecate QEMU_CAPS_DRIVE_CACHE_UNSAFE

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 --- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - te

[libvirt] [libvirt PATCH v2 30/44] Deprecate QEMU_CAPS_FSDEV_READONLY

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 12 ++-- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |

[libvirt] [libvirt PATCH v2 27/44] Deprecate QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 --- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - te

[libvirt] [libvirt PATCH v2 38/44] Deprecate QEMU_CAPS_IPV6_MIGRATION

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_migration.c | 10 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |

[libvirt] [libvirt PATCH v2 17/44] Deprecate QEMU_CAPS_VHOST_NET

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 3 +-- src/qemu/qemu_hotplug.c| 9 +++--

[libvirt] [libvirt PATCH v2 35/44] Deprecate QEMU_CAPS_NETDEV_BRIDGE

2018-04-09 Thread Ján Tomko
Unused since commit <2d80fbb1>. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - te

[libvirt] [libvirt PATCH v2 36/44] Deprecate QEMU_CAPS_SECCOMP_SANDBOX

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 14 -- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml

[libvirt] [libvirt PATCH v2 31/44] Deprecate QEMU_CAPS_DRIVE_COPY_ON_READ

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 --- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - te

[libvirt] [libvirt PATCH v2 16/44] Deprecate QEMU_CAPS_RTC_TD_HACK

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 0.12.0. Deprecated by QEMU commit 1ed2fc1 included in 0.12.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 21 + 2 files changed, 2 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu_capabilities

[libvirt] [libvirt PATCH v2 32/44] Deprecate QEMU_CAPS_FSDEV_WRITEOUT

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 16 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml

[libvirt] [libvirt PATCH v2 15/44] Deprecate QEMU_CAPS_RTC

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 41 -- tests/qemucapabilitiesdata/caps_1.5.3.x86_

[libvirt] [libvirt PATCH v2 18/44] Deprecate QEMU_CAPS_NODEFCONFIG

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 -

[libvirt] [libvirt PATCH v2 24/44] Deprecate QEMU_CAPS_DRIVE_AIO

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 --- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - te

[libvirt] [libvirt PATCH v2 22/44] Deprecate QEMU_CAPS_SMBIOS_TYPE

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 12 ++-- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |

[libvirt] [libvirt PATCH v2 26/44] Deprecate QEMU_CAPS_DEVICE_SPICEVMC

2018-04-09 Thread Ján Tomko
The (now assumed) QEMU_CAPS_CHARDEV_SPICEVMC is preferred. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 -- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 71 tests/qemuxm

[libvirt] [libvirt PATCH v2 37/44] Deprecate QEMU_CAPS_DTB

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 11 ++- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |

[libvirt] [libvirt PATCH v2 41/44] Deprecate QEMU_CAPS_VNC_SHARE_POLICY

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 --- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - te

[libvirt] [libvirt PATCH v2 39/44] Deprecate QEMU_CAPS_MACHINE_OPT

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 317 + tests/qemucapabilitiesdata/caps_1.5.3.x8

[libvirt] [libvirt PATCH v2 42/44] Deprecate QEMU_CAPS_HOST_PCI_MULTIDOMAIN

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Delete the negative test cases now that they always pass. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 10 +---

[libvirt] [libvirt PATCH v2 19/44] Deprecate QEMU_CAPS_BOOT_MENU

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 15 --- tests/qemucapabilitiesdata/caps_1.5.3.x86_6

[libvirt] [libvirt PATCH v2 33/44] Deprecate QEMU_CAPS_DRIVE_IOTUNE

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 9 - src/qemu/qemu_driver.c | 14

[libvirt] [libvirt PATCH v2 34/44] Deprecate QEMU_CAPS_WAKEUP

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_driver.c | 16 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xm

[libvirt] [libvirt PATCH v2 25/44] Deprecate QEMU_CAPS_CHARDEV_SPICEVMC

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 +--- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 5 - tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1

[libvirt] [libvirt PATCH v2 23/44] Deprecate QEMU_CAPS_VGA_NONE

2018-04-09 Thread Ján Tomko
Last use was removed by commit 0586cf98 deprecating QEMU_CAPS_DEVICE. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilities

[libvirt] [libvirt PATCH v2 28/44] Deprecate QEMU_CAPS_NO_SHUTDOWN

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 4 +--- src/qemu/qemu_driver.c

[libvirt] [libvirt PATCH v2 20/44] Deprecate QEMU_CAPS_FSDEV

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 6 -- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 -

  1   2   >