Re: [libvirt] [PATCH] qemu: use target.port for isa-serial

Hi! > We'd generally expect to see a change to tests/qemuxml2argvtest.c for > this. Either adding a new test data file, or updating existing data > files if they would cover it. Sorry! Updated my patch. Have I still missed something? I checked the valgrind tests, but they don't fail because of

[libvirt] [PATCH 1/5] po: provide custom make rules for po file management

Historically we have relied on autopoint/gettextize to install a standard po/Makefile.in.in. There is very limited scope for customizing this and it also causes a bunch of extra stuff to be pulled into configure.ac which potentially clashes with gnulib. Writing make rules for po file management is

[libvirt] [PATCH libvirt v2 6/9] remote/rpc: Use virNetServerGetProgram() to determine the program

Use virNetServerGetProgram() to determine the virNetServerProgram instead of using hard coded global variables. This allows us to remove the global variables @remoteProgram and @qemuProgram as they're now no longer necessary. Signed-off-by: Marc Hartmayer

Re: [libvirt] [RFC v2] external (pull) backup API

On 12.04.2018 07:14, John Snow wrote: > > > On 04/11/2018 12:32 PM, Eric Blake wrote: >> On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote: >>> Hi, all. >>> >>>

Re: [libvirt] [PATCH 08/10] qemu: Handle genid processing during startup/launch

On 04/12/2018 07:13 AM, Daniel P. Berrangé wrote: > On Wed, Apr 11, 2018 at 04:10:03PM -0400, John Ferlan wrote: >> Before we generate the command line for qemu, if the domain about to >> be launched desires to utilize the VM Generation ID functionality, then >> handle both the regenerating the

Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

On 04/12/2018 04:44 AM, Erik Skultety wrote: > On Thu, Apr 12, 2018 at 09:14:50AM +0200, Michal Privoznik wrote: >> In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into >> virObject. Well, this requires 'virObject' member to be stored on >> the first position of the struct. This

Re: [libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

On Thu, Apr 12, 2018 at 10:41:03AM +0200, Andrea Bolognani wrote: On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h

[libvirt] CfP for VHPC ‘18 - Papers due May 15 (extended) for the 13th Virtualization in High­-Performance Cloud Computing Workshop

*Please accept our apologies if you receive multiple copies of this Call for PapersCALL FOR PAPERS 13th Workshop on Virtualization in High­-Performance Cloud Computing (VHPC '18)held in conjunction with the International

[libvirt] [dbus PATCH v2 05/22] Implement AttachDevice method for Domain Interface

This method is not tested for now since the test driver doesn't suport this API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 25 + 2 files changed, 31 insertions(+) diff --git

[libvirt] [dbus PATCH v2 15/22] Implement SetVcpus method for Domain Interface

Move testing of [Get,Set]Vcpus to seperate test. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 26 ++ test/test_domain.py | 9 +++-- 3 files changed, 39 insertions(+), 2

[libvirt] [PATCH] qemu: remove obsolete qemuMonitorMigrateToCommand

The last use of qemuMonitorMigrateToCommand was removed years back in commit 2e90c9daf9eabe15d826a48c06607acb9d18fda6 Author: Daniel P. Berrange Date: Fri Nov 6 16:50:26 2015 + qemu: assume support for all migration protocols except rdma Prior to that

Re: [libvirt] [PATCH 0/9] Add Jansson support

On Thu, Mar 29, 2018 at 01:09:49AM +0200, Ján Tomko wrote: > Prefer Jansson, but allow fallback/choice of yajl. > > Support for yajl can hopefully be dropped after we ditch CentOS 6 > which has no Jansson. Seems like we can revisit this patch series given our discusions about supported

[libvirt] [PATCH libvirt v2 7/9] rpc: use the return value of virObjectRef directly

Use the return value of virObjectRef directly. This way, it's easier for another reader to identify the reason why the additional reference is required. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/rpc/virnetserver.c | 3

[libvirt] [PATCH v7 4/9] libxl: do not enable nested HVM unless global nested_hvm option enabled

Introduce global libxl option for enabling nested HVM feature, similar to kvm module parameter. This will prevent enabling experimental feature by mere presence of element in domain config, unless explicitly enabled. element may be used to configure other features, like NUMA, or CPUID.

[libvirt] [PATCH v7 7/9] tests: check CPU features handling in libxl driver

Test enabling/disabling individual CPU features and also setting nested HVM support, which is also controlled by CPU features node. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé

[libvirt] [PATCH 0/2] Don't choke on valid NUMA nodesets on daemon restart

Details in the commit message for 2/2 and the bug report referenced therein. Andrea Bolognani (2): tests: Create full host NUMA topology by default qemu: Figure out nodeset bitmap size correctly src/qemu/qemu_domain.c| 11 +- tests/qemustatusxml2xmldata/modern-in.xml

[libvirt] [PATCH v7 0/9] Add setting CPU features (CPUID) with libxenlight driver.

Add support for CPUID setting based on element. Since libxl format support only adjusting specific bits over host CPU, only mode='host-passthrough' is supported - other values are rejected (including default 'custom'). This will break some configurations working before (bare element with for

[libvirt] [dbus PATCH v3 08/20] Implement MigrateSetMaxDowntime method for Domain interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 25 + 2 files changed, 31 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 074dd62..c3c64fa 100644

Re: [libvirt] [RFC v2] external (pull) backup API

On 13.04.2018 02:53, John Snow wrote: >> > First a few facts about qemu dirty bitmaps. > > Bitmap can be either in active or disable state. In disabled state it > does not > get changed on guest writes. And oppositely in active state it tracks > guest > writes.

Re: [libvirt] [dbus PATCH v2 15/22] Implement SetVcpus method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:54PM +0200, Katerina Koukiou wrote: > Move testing of [Get,Set]Vcpus to seperate test. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 26 ++ >

[libvirt] [dbus PATCH v3 15/20] Implement GetBlkioParameters method for domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 36 2 files changed, 42 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

Re: [libvirt] [RFC v2] external (pull) backup API

On 13.04.2018 03:04, John Snow wrote: > > > On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> I propose, not to say that bitmap represents a checkpoint. It is simpler >> to say (and it reflects the reality) that bitmap is a difference between >> two consecutive checkpoints. And

Re: [libvirt] [PATCH v2 10/73] qemu: Move qemuMigrationCompression struct

On Wed, Apr 11, 2018 at 04:41:00PM +0200, Jiri Denemark wrote: It provides just another view on some migration parameters so let's move it close to them. The end goal is to merge compression parameters with the rest of migration parameters since it doesn't make any sense to handle them

Re: [libvirt] [dbus PATCH v2 10/22] Implement MigrateSetMaxDowntime method for Domain interface

On Thu, Apr 12, 2018 at 04:32:49PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 25 + > 2 files changed, 31 insertions(+) [...] > +static void >

Re: [libvirt] [PATCH v2 08/73] qemu: Allocate struct for migration parameters

On Wed, Apr 11, 2018 at 04:40:58PM +0200, Jiri Denemark wrote: It will get a bit more complicated soon and storing it on a stack with {0} initializer will no longer work. We need a proper constructor. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 20

Re: [libvirt] [PATCHv2] Remove redundant virFileIsExecutable check

On 04/13/2018 09:34 AM, Radostin Stoyanov wrote: > Remove unnecessary virFileIsExecutable check after virFindFileInPath. > Since commit 9ae992f, virFindFileInPath will reject non-executables. > > 9ae992f24353d6506f570fc9dd58355b165e4472 > virFindFileInPath: only find executable non-directory > >

[libvirt] [dbus PATCH v3 20/20] Implement GetSchedulerParameters method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 36 2 files changed, 42 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

Re: [libvirt] [PATCH v2 26/73] qemu: Set migration caps via migration params APIs

On Wed, Apr 11, 2018 at 04:41:16PM +0200, Jiri Denemark wrote: Migration capabilities are closely related to migration parameters and it makes sense to keep them in a single data structure. Similarly to migration parameters the capabilities are all send to QEMU at once in

Re: [libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

On 04/12/2018 05:40 PM, Sukrit Bhatnagar wrote: > Incremental patches do look better. Just to make sure I am on the right > track, I have some queries. > > I have to apply the changes one function at a time, and these changes > will be the same ones I made in the v2 and v3 patches, right? yes,

Re: [libvirt] [PATCH v2 22/73] qemu: Hide cfg inside qemuMigrationParamsEnableTLS

On Wed, Apr 11, 2018 at 04:41:12PM +0200, Jiri Denemark wrote: There's no real reason for qemuMigrationParamsEnableTLS to require the callers to pass a valid virQEMUDriverConfigPtr, it can just call virQEMUDriverGetConfig. Signed-off-by: Jiri Denemark ---

[libvirt] [dbus PATCH v3 17/20] Implement MigrateGetMaxSpeed method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 28 2 files changed, 34 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 21eb162..eec9dcb 100644

[libvirt] [dbus PATCH v3 16/20] Implement Updated property for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 src/domain.c| 22 ++ test/test_domain.py | 1 + 3 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml

Re: [libvirt] [PATCH v2 15/73] qemu: Pass job object to qemuProcessRecoverMigration{In, Out}

On Wed, Apr 11, 2018 at 04:41:05PM +0200, Jiri Denemark wrote: Currently, only job->phase is passed and both APIs will need to look at more details about the job. Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [libvirt] [PATCH] Remove redundant virFileIsExecutable check

On 13/04/18 08:35, Michal Privoznik wrote: > On 04/13/2018 08:01 AM, Radostin Stoyanov wrote: >> Remove unnecessary virFileIsExecutable check after virFindFileInPath. >> Since the commit 9ae992f virFindFileInPath will reject non-executables. >> >> 9ae992f24353d6506f570fc9dd58355b165e4472 >>

Re: [libvirt] [PATCH v2 25/73] qemu: Introduce qemuMonitorSetMigrationCapabilities

On Wed, Apr 11, 2018 at 04:41:15PM +0200, Jiri Denemark wrote: Our current monitor API forces the caller to call migrate-set-capabilities QMP command for each capability separately, which is quite suboptimal. Let's add a new API for setting all capabilities at once. Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH v2 13/73] qemu: Store original migration params in job

On Wed, Apr 11, 2018 at 04:41:03PM +0200, Jiri Denemark wrote: Any job which touches migration parameters will first store their original values (i.e., QEMU defaults) to qemuDomainJobObj to make it easier to reset them back once the job finishes. Signed-off-by: Jiri Denemark

[libvirt] [dbus PATCH v3 13/20] Implement SetVcpus method for Domain Interface

Move testing of [Get,Set]Vcpus to seperate test. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 26 ++ test/test_domain.py | 9 +++-- 3 files changed, 39 insertions(+), 2

Re: [libvirt] [dbus PATCH v2 21/22] Implement SetMemory method for Domain Interface

On Thu, Apr 12, 2018 at 04:33:00PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 26 ++ > 2 files changed, 32 insertions(+) [...] > +static void >

Re: [libvirt] [PATCH v2 09/73] qemu: Drop qemuMigrationParamsClear

On Wed, Apr 11, 2018 at 04:40:59PM +0200, Jiri Denemark wrote: It's no longer used since we do not store the struct on a stack anymore. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 12 +--- src/qemu/qemu_migration_params.h | 3 --- 2 files

[libvirt] [dbus PATCH v3 05/20] Implement DetachDevice method for Domain Interface

This method is not tested for now since the test driver doesn't suport this API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 25 + 2 files changed, 31 insertions(+) diff --git

Re: [libvirt] [PATCH v2 19/73] qemu: Rename qemuMigrationParamsSetEmptyTLS

On Wed, Apr 11, 2018 at 04:41:09PM +0200, Jiri Denemark wrote: The new name is qemuMigrationParamsDisableTLS. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 4 ++-- src/qemu/qemu_migration_params.c | 6 +++--- src/qemu/qemu_migration_params.h | 4 ++-- 3

Re: [libvirt] [PATCH v2 12/73] qemu: Reset migration parameters in qemuMigrationSrcCleanup

On Wed, Apr 11, 2018 at 04:41:02PM +0200, Jiri Denemark wrote: When connection to the client which controls a non-p2p migration gets closed between Perform and Confirm phase, we don't know whether the domain was successfully migrated or not. Thus, we have to leave the domain paused and just

Re: [libvirt] [PATCH v2 18/73] qemu: Drop qemuMigrationParamsCheckTLSCreds

On Wed, Apr 11, 2018 at 04:41:08PM +0200, Jiri Denemark wrote: The function checks whether QEMU supports TLS migration and stores the original value of tls-creds parameter to priv->migTLSAlias. This is no longer needed because we already have the original value stored in priv->migParams.

[libvirt] [PATCH v2 27/73] qemu: Do not use qemuMonitorSetMigrationCapability

Rework all remaining callers of qemuMonitorSetMigrationCapability to use the new qemuMonitorSetMigrationCapabilities API. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 11 --- tests/qemumonitorjsontest.c | 16 +++- 2 files

Re: [libvirt] [RFC v2] external (pull) backup API

11.04.2018 16:56, Eric Blake wrote: On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote: Hi, all. This is another RFC on pull backup API. This API provides means to read domain disks in a

[libvirt] [PATCH v2 18/73] qemu: Drop qemuMigrationParamsCheckTLSCreds

The function checks whether QEMU supports TLS migration and stores the original value of tls-creds parameter to priv->migTLSAlias. This is no longer needed because we already have the original value stored in priv->migParams. Signed-off-by: Jiri Denemark ---

[libvirt] [PATCH v2 04/73] qemu: Move qemuDomainCheckMigrationCapabilities

Since the function is tightly connected to migration, it was renamed as qemuMigrationCapsCheck and moved to qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 72 src/qemu/qemu_domain.h |

[libvirt] [PATCH v2 12/73] qemu: Reset migration parameters in qemuMigrationSrcCleanup

When connection to the client which controls a non-p2p migration gets closed between Perform and Confirm phase, we don't know whether the domain was successfully migrated or not. Thus, we have to leave the domain paused and just cleanup the migration job and reset migration parameters. Previously

[libvirt] [PATCH v2 17/73] qemu: Drop qemuMigrationParamsCheckSetupTLS

The code can be merged directly in qemuMigrationParamsAddTLSObjects. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 15 --- src/qemu/qemu_migration_params.c | 73 ++-- src/qemu/qemu_migration_params.h | 6 --- 3 files

Re: [libvirt] [PATCH] qemu: Format gic-version=2 on the command line

On Wed, 2018-04-11 at 08:52 -0400, John Ferlan wrote: > On 05/03/2018 08:57 AM, Andrea Bolognani wrote: > > Up until now we have only formatted non-default GIC versions on > > the command line, in order to maintain compatibility with older > > QEMU versions that didn't implement the gic-version

Re: [libvirt] [RFC v2] external (pull) backup API

On 11.04.2018 17:16, Vladimir Sementsov-Ogievskiy wrote: > 11.04.2018 16:56, Eric Blake wrote: >> On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote: >>> Hi, all. >>> >>>   This is another RFC on

[libvirt] [PATCH v2 20/73] qemu: Rename qemuMigrationParamsAddTLSObjects

The new name is qemuMigrationParamsEnableTLS. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 12 ++-- src/qemu/qemu_migration_params.c | 18 +- src/qemu/qemu_migration_params.h | 16 3 files changed, 23

[libvirt] [PATCH v2 07/73] qemu: Make qemuMigrationParamsFree follow common pattern

Our *Free functions usually do not take a double pointer and the caller has to make sure it doesn't use the stale pointer after the *Free function returns. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_migration_params.c | 10

[libvirt] [jenkins-ci PATCH] guests: Set remote_user at the playbook level

This is very convenient for developers using the 'test' flavor, because it ensures $ ./lcitool update all still works by logging in as root, but at the same time ad-hoc invocations such as $ ansible all -m shell -a 'cd libvirt && $MAKE -j check' and custom playbooks log in as the 'test'

Re: [libvirt] [PATCH 0/2] Fix lxc callers using virDomainObjListRemove

ping? Tks, John On 04/02/2018 10:15 AM, John Ferlan wrote: > Details in each patch - being consistent for future adjustment. > > John Ferlan (2): > lxc: Fix possible leaked @vm in lxcDomainCreateXMLWithFiles > lxc: Fix object locking after virDomainObjListRemove > > src/lxc/lxc_driver.c

[libvirt] [jenkins-ci PATCH v2 0/6] Mostly drop CentOS 6

Changes from [v1]: * instead of dropping CentOS 6 altogether, simply stop building pretty much all projects on it; * introduce a new job type specifically for whatever little stuff we need to ensure still works on CentOS 6; * the end result is still a nice cleanup thanks to not

[libvirt] [dbus PATCH v2 22/22] Implement GetSchedulerParameters method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 38 ++ 2 files changed, 44 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] [dbus PATCH v2 08/22] Implement GetJobInfo method for Domain interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 + src/domain.c| 35 +++ 2 files changed, 40 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 83e37bc..2e0339b

Re: [libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

On Thu, 2018-04-12 at 17:16 +0200, Ján Tomko wrote: > On Thu, Apr 12, 2018 at 10:07:50AM +0200, Andrea Bolognani wrote: > > On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > > > Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used > > > when QEMU_CAPS_NO_USER_CONFIG is

Re: [libvirt] [PATCHv3 0/6] Use query-cpus-fast instead of query-cpus

On 04/04/2018 10:45 AM, Viktor Mihajlovski wrote: > The QEMU monitor commmand query-cpus is deprecated starting > with QEMU 2.12.0 because it can adversely affect the performance of > a running virtual machine. > > This series enables libvirt to use the new query-cpus-fast interface > if

Re: [libvirt] [PATCHv3 3/6] tests: add qemumonitorjson tests for query-cpus-fast

On 04/04/2018 10:45 AM, Viktor Mihajlovski wrote: > Extended the json monitor test program with support for query-cpus-fast > and added a sample file set for x86 data obtained using the it. > Also extend the test program to recognize the halted property. This last sentence involves code that

[libvirt] [PATCH] acl: remove various left over Xen ACL whitelist entries

The legacy xen driver is removed, so these ACLL hacks can be removed too now. Signed-off-by: Daniel P. Berrangé --- src/check-aclrules.pl | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/check-aclrules.pl

Re: [libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

Incremental patches do look better. Just to make sure I am on the right track, I have some queries. I have to apply the changes one function at a time, and these changes will be the same ones I made in the v2 and v3 patches, right? If that is the case, do I need the next patch to be v4 or can the

Re: [libvirt] [RFC v2] external (pull) backup API

On 04/12/2018 08:26 AM, Vladimir Sementsov-Ogievskiy wrote: > 1. It looks unsafe to use nbd server + backup(sync=none) on same node, > synchronization is needed, like in block/replication, which uses > backup_wait_for_overlapping_requests, backup_cow_request_begin, > backup_cow_request_end. We

Re: [libvirt] [PATCH v3 2/2] qemu: conf: Network stats support for VF Representors

On 04/04/2018 12:29 PM, Jai Singh Rana wrote: > In case of pci SR-IOV device with interface_type as 'hostdev', return > network stats if it has a VF Representor interface on host for > pci SR-IOV device according to switchdev model. > --- > v3 includes changes based on v2's[1] feedback and

Re: [libvirt] [dbus PATCH v2 05/22] Implement AttachDevice method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:44PM +0200, Katerina Koukiou wrote: > This method is not tested for now since the test driver > doesn't suport this API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 25

Re: [libvirt] [PATCH v2 5/6] tpm: Add support for choosing emulation of a TPM 2

On 04/10/2018 10:50 PM, Stefan Berger wrote: This patch extends the TPM's device XML with TPM 2 support. This only works for the emulator type backend and looks as follows: Once the version of a TPM has been chosen it cannot be changed anymore unless one removes the TPM

Re: [libvirt] [REPOST PATCH 0/2] vz - Clean/fix test driver usage of FindBy{UUID|ID}

ping? Changes are less about vz driver and more about domain object manipulation consistency. Tks, John On 04/02/2018 09:21 AM, John Ferlan wrote: > Reposting patches 16-17 from: > https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html > > Reposting and using the vz prefix to

Re: [libvirt] [libvirt PATCH v2 09/44] Remove qemuDomainSupportsNetdev

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > Now that we assume QEMU_CAPS_NETDEV, the only thing left to check > is whether we need to use the legacy -net syntax because of > a non-conforming armchitecture. I see you're having "pun" writing these commit messages ;) [...] > diff --git

[libvirt] [PATCH 2/2] openvz: Clean up openvzDomainGetHostname

Remove the unnecessary goto error followed by goto cleanup processing. Signed-off-by: John Ferlan --- src/openvz/openvz_driver.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index

Re: [libvirt] [libvirt PATCH v2 08/44] Remove unused qemuDomainNetVLAN

On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_domain.c | 6 -- > src/qemu/qemu_domain.h | 2 -- > 2 files changed, 8 deletions(-) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat /

Re: [libvirt] [PATCH 4/6] qemu: caps: Add capability for 'write-cache' parameter of disk frontends

On Wed, Apr 04, 2018 at 10:13:57AM +0200, Peter Krempa wrote: QEMU translates the cache mode of a disk internally into 3 flags. 'write-cache' is a flag of the frontend while others are flag of the backing storage. Add capability which will allow expressing it via the frontend attribute.

Re: [libvirt] [PATCH 0/8] vfio-ccw passthrough support

On Wed, 11 Apr 2018 17:49:51 +0200 Shalini Chellathurai Saroja wrote: > Let us support the basic channel I/O passthrough infrastructure based on > vfio, which have been introduced in QEMU 2.10. The current focus is to > support dasd-eckd (cu_type/dev_type =

Re: [libvirt] [PATCH jenkins-ci] Run "make check" for osinfo-db

On Tue, 2018-04-10 at 17:29 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > projects/osinfo-db.yaml | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/projects/osinfo-db.yaml b/projects/osinfo-db.yaml > index

[libvirt] [PATCH v1 7/7] qemu: Enable memory-backend-file.discard-data whenever possible

https://bugzilla.redhat.com/show_bug.cgi?id=1480668 Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f864350bd5..67350719aa 100644 ---

Re: [libvirt] [PATCH] apparmor: add rules to use qemu_bridge_helper

On Mon, Apr 09, 2018 at 08:34:06AM +0200, Christian Ehrhardt wrote: > Due to mediation of socket and signal activity currently qemu:///session > connections calling qemu_bridge_helper fail. > > We need the profile for libvirtd itself and the subprofile for > qemu-bridge-helper to be able to

Re: [libvirt] [PATCH v4 14/14] qemu: Detect pr-manager-helper capability

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_capabilities.c | 1 + > tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + > tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + >

Re: [libvirt] [PATCH v4 07/14] qemu_cgroup: Allow /dev/mapper/control for PR

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > Just like in previous commit, qemu-pr-helper might want to open > /dev/mapper/control under certain circumstances. Therefore we > have to allow it in cgroups. Perhaps the two patches should be combined then... yes, I know cgroups is different

Re: [libvirt] [PATCH v4 12/14] qemu_hotplug: Hotplug of reservations

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > When attaching a disk that requires pr-manager we might need to > plug the pr-manager object too. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_hotplug.c | 41 + > 1 file

Re: [libvirt] [PATCH v4 11/14] qemu: Start PR daemon on disk hotplug

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > When plugging a disk into domain we need to start qemu-pr-helper > process iff this is the first disk with PR enabled for the > domain. Otherwise the helper is already running (or not needed). > > Signed-off-by: Michal Privoznik

[libvirt] [PATCH v2 1/2] vmware: Fix initialization of VMware Fusion

The vmware driver wants to execute vmware-vmx from the same directory in which vmrun was found. However, on VMware Fusion 10 vmrun at /Applications/VMware Fusion.app/Contents/Public/vmrun is a symlink pointing to ../Library/vmrun. vmware-vmx cannot be found, as it is not in PATH, but only in this

Re: [libvirt] [PATCH v4 06/14] qemu_ns: Allow /dev/mapper/control for PR

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > If qemu-pr-helper is compiled with multipath support the first > thing it does is opening /dev/mapper/control. Since we're going s/opening/open > to be running it inside qemu namespace we need to create it > there. Unfortunately, we don't know

Re: [libvirt] [PATCH v4 10/14] qemu: Start PR daemon on domain startup

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > Before we exec() qemu we have to spawn pr-helper processes for > all managed reservations (well, technically there can only one). Don't mince words - what have to spawn the qemu-pr-helper process for all managed persistent reservations. > The

Re: [libvirt] [PATCH v4 08/14] qemu: Generate cmd line at startup

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > This is the easier part. All we need to do here is put -object > pr-manager-helper,id=$alias,path=$socketPath and then just > reference the object in -drive file.pr-manager=$alias. > > Signed-off-by: Michal Privoznik > ---

[libvirt] [PATCH v2 0/2] Fix vmware driver for VMware Fusion 10

These changes were required to get VMware Fusion working at all. I tested with VMware Fusion 10.1.1 on macOS 10.12 Sierra. I am not sure whether calling virCapabilitiesInitCaches() makes sense at all on macOS. This function looks highly specific to Linux as it relies on /sys/devices/system, so it

[libvirt] [PATCH v2 41/73] qemu: Generalize macro for getting VIR_MIGRATE_* typed params

So far it's used only for CPU throttling parameters which are all ints, but we'll soon want to use it for more parameters with different types. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 31 +++ 1 file changed, 15

[libvirt] [PATCH v2 31/73] qemu: Move ParamsCheck closer to ParamsApply on Dst side

We reached the point when qemuMigrationParamsApply is the only API which sends migration parameters and capabilities to QEMU. Thus all but the TLS parameters can be set before we ask QEMU for the current values of all parameters in qemuMigrationParamsCheck. Supported migration capabilities are

[libvirt] [PATCH v2 32/73] qemu: Move ParamsCheck closer to ParamsApply on Src side

We reached the point when qemuMigrationParamsApply is the only API which sends migration parameters and capabilities to QEMU. Thus all but the TLS parameters can be set before we ask QEMU for the current values of all parameters in qemuMigrationParamsCheck. Supported migration capabilities are

[libvirt] [PATCH v2 53/73] qemu: Move migration parameters JSON formatting

We want to have all migration parameters parsing and formatting at one place, i.e., in qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 68 +++- src/qemu/qemu_monitor.c | 35

[libvirt] [PATCH v2 43/73] qemu: Move qemuMigrationParamsSetCompression

The API will soon be called from qemuMigrationParamsFromFlags. Let's move it to avoid the need to add a forward declaration. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 59 1 file changed, 30 insertions(+), 29

[libvirt] [PATCH v2 58/73] qemu: Move qemuMonitorMigrationCaps enum

Since the monitor code no longer needs to see this enum, we move it to the place where migration parameters are defined and drop the "monitor" reference from the name. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 4 +-

[libvirt] [PATCH v2 72/73] qemu: Don't delete TLS objects unless TLS migration was requested

Trying to delete the non-existent TLS objects results in ugly error messages in the log, which could easily confuse users. Let's avoid this confusion by not trying to delete the objects if we were not asked to enable TLS migration and thus we didn't created the objects anyway. This patch restores

Re: [libvirt] [PATCH v2 0/4] vmware - Clean/fix test driver usage of FindBy{UUID|ID}

ping? This is less about vmware specifically and more about domain object manipulation coordination... Tks, John On 04/02/2018 09:16 AM, John Ferlan wrote: > Patches 12-15 of the formerly larger series: > > https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html > > Changes

[libvirt] [PATCH v2 67/73] qemu: Store API flags for async jobs in qemuDomainJobObj

When an async job is running, we sometimes need to know how it was started to distinguish between several types of the job, e.g., post-copy vs. normal migration. So far we added a specific bool item to qemuDomainJobObj for such cases, which doesn't scale very well and storing such bools in status

Re: [libvirt] [PATCH 2/6] tests: qemuxm2argv: Add infrastructure for testing with real qemuCaps

On 04/04/2018 04:13 AM, Peter Krempa wrote: > Allow testing of XML->argv conversion with using a real capability map > as used in the qemucapabilitiestest. This allows specifying the required > qemu version with the test rather than having to enumerate all the > required capabilities. > >

[libvirt] [PATCH v2 37/73] qemu: Drop qemuMigrationParamsSetPostCopy

It's just a tiny wrapper around qemuMigrationParamsSetCapability and setting priv->job.postcopyEnabled is not something qemuMigrationParams code should be doing anyway so let the callers do it. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 16

[libvirt] [PATCH v2 24/73] qemu: Hide internals of qemuMigrationParams struct

All users of migration parameters are supposed to use APIs provided by qemu_migration_params.c without having to worry about the internals. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 5 + src/qemu/qemu_migration_params.h | 3 --- 2 files

[libvirt] [PATCH v2 56/73] qemu: Refactor qemuMigrationParams

Adding support for new migration parameter requires a lot of places to be changed (most likely by copy engineering): new variables to store the parameter value and the associated *_set bool, JSON formatter and parser, XML formatter and parser (to be added soon), and the actual code to set the

[libvirt] [PATCH v2 29/73] qemu: Add support for xbzrle-cache-size migration parameter

Originally QEMU provided query-migrate-cache-size and migrate-set-cache-size QMP commands for querying/setting XBZRLE cache size. In version 2.11 QEMU added support for XBZRLE cache size to the general migration paramaters commands. This patch adds support for this parameter to libvirt to make

[libvirt] [PATCH v2 45/73] qemu: Hide qemuMigrationParamsSetCompression

There's no need to call this API explicitly in the migration code. We can pass the compression parameters to qemuMigrationParamsFromFlags and it can internally call qemuMigrationParamsSetCompression to apply them to the qemuMigrationParams structure. Signed-off-by: Jiri Denemark

  1   2   >