Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > Since libvirt is currently not able to setup the NBD migration stream > secured by TLS we should not allow such migration since data would be > transferred unencrypted. > > This will break compatibility of TLS migration if non-shared

[libvirt] [dbus PATCH 2/6] Implement InterfaceAddresses method for Domain Interface

VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP should be added later on. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 7 src/domain.c| 87 + 2 files changed, 94 insertions(+) diff --git

[libvirt] [dbus PATCH 1/6] Implement BlockCopy method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 35 +++ 2 files changed, 43 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] [dbus PATCH 3/6] Implement PinEmulator method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 40 2 files changed, 46 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] [dbus PATCH 6/6] Implement PMWakeup method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 + src/domain.c| 24 2 files changed, 29 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 00b4988..c6234e9 100644 ---

[libvirt] [dbus PATCH 0/6] More DomainAPIs

Katerina Koukiou (6): Implement BlockCopy method for Domain Interface Implement InterfaceAddresses method for Domain Interface Implement PinEmulator method for Domain Interface Implement PinIOThread method for Domain Interface Implement PinVcpu method for Domain Interface Implement

[libvirt] [dbus PATCH 5/6] Implement PinVcpu method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 7 +++ src/domain.c| 41 + 2 files changed, 48 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > Since libvirt is currently not able to setup the NBD migration stream > secured by TLS we should not allow such migration since data would be > transferred unencrypted. > > This will break compatibility of TLS migration if non-shared

[libvirt] [dbus PATCH 4/6] Implement PinIOThread method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 7 +++ src/domain.c| 41 + 2 files changed, 48 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

Re: [libvirt] [jenkins-ci PATCH 0/5] guests: Enable ccache transparently

On Thu, 2018-04-26 at 16:23 +0200, Pavel Hrdina wrote: > On Wed, Apr 18, 2018 at 05:25:17PM +0200, Andrea Bolognani wrote: > > This allows us to drop the ugly workaround from the Go and > > MinGW templates; as a nice side-effect, we also remove the > > need to hardcode most OS-dependent paths in

Re: [libvirt] [dbus PATCH 00/10] NodeAPIs for Connect Interface

On Thu, Apr 26, 2018 at 04:54:07PM +0200, Katerina Koukiou wrote: > Katerina Koukiou (10): > Implement NodeGetCellsFreeMemory method for Connect Interface > Implement NodeGetCPUStats method for Connect Interface > Implement NodeGetFreeMemory method for Connect Interface > Implement

[libvirt] [GSoC] Introduction

Hi, I am Sukrit Bhatnagar, selected in GSoC '18 for the project "Automatic freeing of resources". I will be modifying the libvirt core C library to add functionality for GCC cleanup attribute. Over the next couple of months, I will be discussing the general code design in this list. I had

Re: [libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

On Fri, Apr 27, 2018 at 03:16:46PM +0200, Peter Krempa wrote: > The code setting TLS parameters verifies that TLS is supported by > looking at the dump of parameters which will be reset after migration, > but sets the parameters in the list of new parameters. As > qemuMigrationParamsSetString did

Re: [libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

On Fri, Apr 27, 2018 at 03:16:46PM +0200, Peter Krempa wrote: The code setting TLS parameters verifies that TLS is supported by looking at the dump of parameters which will be reset after migration, but sets the parameters in the list of new parameters. As qemuMigrationParamsSetString did not

[libvirt] [dbus PATCH] Revert "Implement MigrateGetMaxDowntime method for Domain Interface"

This reverts commit d4a4fd4e9e0ab50f473c24192abc34644cd8213e. This API was introduced in libvirt 3.7.0 and no APIs from version > 3.0.0 should be included until next release. --- data/org.libvirt.Domain.xml | 6 -- src/domain.c| 31 --- 2 files

Re: [libvirt] [dbus PATCH] Revert "Implement MigrateGetMaxDowntime method for Domain Interface"

On Fri, Apr 27, 2018 at 01:48:13PM +0200, Katerina Koukiou wrote: > This reverts commit d4a4fd4e9e0ab50f473c24192abc34644cd8213e. > > This API was introduced in libvirt 3.7.0 and no APIs from > version > 3.0.0 should be included until next release. > --- > data/org.libvirt.Domain.xml | 6 --

Re: [libvirt] [PATCH 1/2] qemu: migration: Move and unexport qemuMigrationParamsSetString

On Fri, Apr 27, 2018 at 03:16:45PM +0200, Peter Krempa wrote: The function is not used outside of the src/qemu/qemu_migration_params.c file so unexport it. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration_params.c | 30 +++---

[libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

The code setting TLS parameters verifies that TLS is supported by looking at the dump of parameters which will be reset after migration, but sets the parameters in the list of new parameters. As qemuMigrationParamsSetString did not set the 'set' property, the TLS parameters would not be used.

Re: [libvirt] [dbus PATCH v3] Implement GetIOThreadInfo method for Domain Interface

On Fri, Apr 27, 2018 at 01:38:00PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > Use VIR_CPU_USED to parse cpumap > > data/org.libvirt.Domain.xml | 6 > src/domain.c| 68 > + > 2

Re: [libvirt] [dbus PATCH 05/10] Implement NodeGetMemoryParameters method in Connect Interface

On Thu, Apr 26, 2018 at 04:54:12PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 36 > 2 files changed, 42 insertions(+) > > diff --git

Re: [libvirt] [dbus PATCH 07/10] Implement NodeGetSecurityModel method for Domain Interface

On Thu, Apr 26, 2018 at 04:54:14PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 23 +++ > 2 files changed, 29 insertions(+) > > diff --git

[libvirt] [dbus PATCH v3] Implement GetIOThreadInfo method for Domain Interface

Signed-off-by: Katerina Koukiou --- Use VIR_CPU_USED to parse cpumap data/org.libvirt.Domain.xml | 6 src/domain.c| 68 + 2 files changed, 74 insertions(+) diff --git a/data/org.libvirt.Domain.xml

Re: [libvirt] [dbus PATCH 06/10] Implement NodeGetMemoryStats method for Connect Interface

On Thu, Apr 26, 2018 at 04:54:13PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 7 +++ > src/connect.c| 42 ++ > 2 files changed, 49 insertions(+) > >

Re: [libvirt] [dbus PATCH 01/10] Implement NodeGetCellsFreeMemory method for Connect Interface

On Thu, Apr 26, 2018 at 04:54:08PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 7 +++ > src/connect.c| 39 +++ > 2 files changed, 46 insertions(+) > > diff

Re: [libvirt] [dbus PATCH 02/10] Implement NodeGetCPUStats method for Connect Interface

On Thu, Apr 26, 2018 at 04:54:09PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 7 +++ > src/connect.c| 42 ++ > 2 files changed, 49 insertions(+) > >

[libvirt] [PATCH 0/2] URGENT: Fix TLS migration

TLS would not be enabled for migration even when requested. This is a regression introduced in the migration params refactoring series pushed in this devel cycle. Peter Krempa (2): qemu: migration: Move and unexport qemuMigrationParamsSetString qemu: migration: Set the 'set' boolean in

[libvirt] [PATCH 1/2] qemu: migration: Move and unexport qemuMigrationParamsSetString

The function is not used outside of the src/qemu/qemu_migration_params.c file so unexport it. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration_params.c | 30 +++--- src/qemu/qemu_migration_params.h | 5 - 2 files changed, 15 insertions(+),

Re: [libvirt] [PATCH v2 1/4] Revert "util: virlog: Introduce wildcard to log filters"

On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > This reverts commit 8daa593b0741452a78daea76075254ae7d3c6ab6. > > There are two undesirable aspects to the impl > > - Only a bare wildcard is permitted > - The wildcard match is not performed in the order listed > --- >

Re: [libvirt] [PATCH v2 1/4] Revert "util: virlog: Introduce wildcard to log filters"

On Fri, Apr 27, 2018 at 09:38:06AM -0400, John Ferlan wrote: > > > On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > > This reverts commit 8daa593b0741452a78daea76075254ae7d3c6ab6. > > > > There are two undesirable aspects to the impl > > > > - Only a bare wildcard is permitted > > - The

Re: [libvirt] [PATCH] Qemu driver: Support network-backed pflash disks.

On 04/20/2018 04:59 AM, Prerna Saxena wrote: > So far libvirt domain XML only allows local filepaths that can be > used to specify a loader element or its matching NVRAM disk. > Given that Vms may themselves move across hypervisor hosts, it should be > possible to allocate loaders/NVRAM disks on

Re: [libvirt] [PATCH 0/3] sample: vfio mdev display devices.

On Thu, 26 Apr 2018 19:55:23 +0100 "Dr. David Alan Gilbert" wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > > > > > On 4/26/2018 1:22 AM, Dr. David Alan Gilbert wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > >> On Wed, 25 Apr 2018

Re: [libvirt] [PATCHv2 3/3] qemu_monitor: query-cpu-model-baseline QMP command

$SUBJ: qemu: Introduce qemuMonitorGetCPUModelBaseline On 04/19/2018 12:06 AM, Chris Venteicher wrote: > Function qemuMonitorGetCPUModelBaseline exposed to carry out a QMP > query-cpu-model-baseline transaction with QEMU. > > QEMU determines a baseline CPU Model from two input CPU Models to

Re: [libvirt] ignore_value

On 04/27/2018 03:23 AM, gaosheng cui wrote: > Hi,using ignore_value in libvirt source code > to do function return value processing,but I > can’t understand about it,can you give me some tips?thanks very much! > Beyond what's stated in "gnulib/lib/ignore-value.h"? Not sure how much more can

Re: [libvirt] [PATCHv2 1/3] qemu_monitor_json: Populate CPUModelInfo struct from json

$SUBJ: "qemu_monitor_json: Introduce qemuMonitorJSONBuildCPUModelInfoFromJSON" On 04/19/2018 12:06 AM, Chris Venteicher wrote: > New function qemuMonitorJSONBuildCPUModelInfoFromJSON > created by extracting code from existing function > qemuMonitorJSONGetCPUModelExpansion > to create a

Re: [libvirt] [PATCH v2] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

On 04/27/2018 12:44 PM, Laine Stump wrote: > When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", > this turns on the "dhcpsnoop" thread, which uses libpcap to monitor > traffic on the domain's tap device and extract the IP address from the > DHCP response. > > If libpcap on the

Re: [libvirt] [PATCHv2 2/3] qemu_monitor_json: Build Json CPU Model Info

$SUBJ: qemu_monitor_json: Introduce qemuMonitorJSONBuildCPUModelInfoToJSON The corollary for qemuMonitorJSONBuildCPUModelInfoFromJSON is to build the JSON data from the qemuMonitorCPUModelInfoPtr. On 04/19/2018 12:06 AM, Chris Venteicher wrote: > Function

Re: [libvirt] [PATCH 3/3] domain_capabilities: Report support

On 04/17/2018 02:40 PM, Cole Robinson wrote: > Report domaincaps if the guest > config accepts > > Signed-off-by: Cole Robinson > --- > This bucks the domaincapabilities trend of always having a child > enum if supported='yes'. Following that trend we would give us >

[libvirt] [PATCH 02/14] nwfilter: remove methods that are trivial wrappers for virHash APIs

This removes the virNWFilterHashTableFree, virNWFilterHashTablePut and virNWFilterHashTableRemove methods, in favour of just calling the virHash APIs directly. The virNWFilterHashTablePut method was unreasonably complex because the virHashUpdateEntry already knows how to create the entry if it

Re: [libvirt] [PATCH v2 2/6] tpm: Add support for external swtpm TPM emulator

On 04/26/2018 08:07 PM, John Ferlan wrote: [...] Two blank lines between new functions and we like Free instead of Delete unless of course this is something more specific... This is something more specifc. The TPM emulator writes state into files in a dedicated directory. That state

[libvirt] [PATCH 12/14] nwfilter: report an error if nic needs filtering by no driver is present

If a includes a filter name but the nwfilter driver is not present we silently do nothing. This is very bad, because an application that thinks it is protected by malicious guest traffic will in fact be vulnerable. Reporting an error gives the administrator the ability to know there is a problem

[libvirt] [PATCH 11/14] nwfilter: convert DHCP address snooping code to virNWFilterBinding

Use the virNWFilterBinding struct in the DHCP address snooping code directly. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_dhcpsnoop.c | 150 + src/nwfilter/nwfilter_dhcpsnoop.h | 7 +-

[libvirt] [PATCH 09/14] nwfilter: convert the gentech driver code to use virNWFilterBinding

Use the virNWFilterBinding struct in the gentech driver code directly. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_dhcpsnoop.c | 35 +++--- src/nwfilter/nwfilter_driver.c | 21 +++- src/nwfilter/nwfilter_gentech_driver.c | 211

[libvirt] [PATCH 10/14] nwfilter: convert IP address learning code to virNWFilterBinding

Use the virNWFilterBinding struct i nthe IP address learning code directly. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_gentech_driver.c | 7 +-- src/nwfilter/nwfilter_learnipaddr.c| 98 ++

Re: [libvirt] [PATCH 1/4] tests: Fix virnetsockettest on FreeBSD

On Fri, Apr 27, 2018 at 05:21:20PM +0200, Andrea Bolognani wrote: > FreeBSD doesn't let IPv4 clients to connect to IPv6 sockets, > so one of our test cases has to be compiled out there. Yep, IPV6_V6ONLY is set to true by default, where as it is false by default on Linux, however, . > >

[libvirt] [PATCH] qemu: migration: Don't crash on access to 'current' job

When a VM is destroyed while being migrated (waiting in qemuMigrationSrcWaitForCompletion) the private object cleanup code frees the 'current' job info. Since the migration code attempts to setup various aspects of the current job even on failure this results into a crash. Job data is cleared in

[libvirt] ignore_value

Hi,using ignore_value in libvirt source code to do function return value processing,but I can’t understand about it,can you give me some tips?thanks very much! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 2/6] Implement InterfaceAddresses method for Domain Interface

On Fri, Apr 27, 2018 at 11:00:51AM +0200, Katerina Koukiou wrote: > VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP should be added > later on. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 > src/domain.c| 87 >

[libvirt] [PATCH 04/14] nwfilter: make virNWFilterIPAddrLearnReq type private

The virNWFilterIPAddrLearnReq type should only be used by the IP address learning code, so can live in the implementation file instead of header file. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_gentech_driver.c | 8

[libvirt] [PATCH 08/14] nwfilter: pass vm name in when instantiating filters

The vm name is not needed for any functional requirement, but it will be useful when debugging problems to identify which VM is associated with a filter, since UUID is not human friendly. Signed-off-by: Daniel P. Berrangé --- src/conf/domain_nwfilter.c | 5 +++--

Re: [libvirt] [dbus PATCH 3/6] Implement PinEmulator method for Domain Interface

On Fri, Apr 27, 2018 at 11:00:52AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 40 > 2 files changed, 46 insertions(+) Reviewed-by:

Re: [libvirt] [dbus PATCH 6/6] Implement PMWakeup method for Domain Interface

On Fri, Apr 27, 2018 at 11:00:55AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/domain.c| 24 > 2 files changed, 29 insertions(+) Reviewed-by: Pavel Hrdina

Re: [libvirt] [dbus PATCH 5/6] Implement PinVcpu method for Domain Interface

On Fri, Apr 27, 2018 at 11:00:54AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 +++ > src/domain.c| 41 + > 2 files changed, 48 insertions(+)

Re: [libvirt] [dbus PATCH 4/6] Implement PinIOThread method for Domain Interface

On Fri, Apr 27, 2018 at 11:00:53AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 +++ > src/domain.c| 41 + > 2 files changed, 48 insertions(+)

Re: [libvirt] [PATCH 2/3] conf: Add a comment warning about boolean feature XML

On 04/17/2018 02:40 PM, Cole Robinson wrote: > This is the old style and we really shouldn't be adding any more > examples like this. Add a comment to warn devs away > > Signed-off-by: Cole Robinson > --- > docs/schemas/domaincommon.rng | 6 +- >

Re: [libvirt] [PATCH 1/3] conf: format/parse as tristate

On 04/17/2018 02:40 PM, Cole Robinson wrote: > is a bare boolean XML property. We don't really > use this format anymore and instead prefer tristate > since it's required for modeling on/off/default. If for example future > qemu started enabling vmcoreinfo by default we wouldn't have any way >

[libvirt] [PATCH 4/4] tests: Fix qemuxml2argvtest on FreeBSD

When hostdevs and host NUMA nodes are involved, libvirt needs to poke into sysfs to collect some information about them; since that pseudo-filesystem doesn't exist on platforms other than Linux, the corresponding tests would fail and need to be compiled out. Signed-off-by: Andrea Bolognani

[libvirt] [PATCH 3/4] tests: Fix qemuxml2xmltest on FreeBSD

When hostdevs are involved, libvirt needs to poke into sysfs to collect some information about them; since that pseudo-filesystem doesn't exist on platforms other than Linux, the corresponding tests would fail and need to be compiled out. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH 2/4] tests: Fix qemumemlocktest on FreeBSD

When hostdevs are involved, libvirt needs to poke into sysfs to collect some information about them; since that pseudo-filesystem doesn't exist on platforms other than Linux, the corresponding tests would fail and need to be compiled out. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH 0/4] tests: Fix 'make check' on FreeBSD

macOS still chokes on it, but hey, it's something. Andrea Bolognani (4): tests: Fix virnetsockettest on FreeBSD tests: Fix qemumemlocktest on FreeBSD tests: Fix qemuxml2xmltest on FreeBSD tests: Fix qemuxml2argvtest on FreeBSD tests/qemumemlocktest.c | 12

[libvirt] [PATCH 1/4] tests: Fix virnetsockettest on FreeBSD

FreeBSD doesn't let IPv4 clients to connect to IPv6 sockets, so one of our test cases has to be compiled out there. Signed-off-by: Andrea Bolognani --- tests/virnetsockettest.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/virnetsockettest.c

Re: [libvirt] [PATCH 2/4] tests: Fix qemumemlocktest on FreeBSD

On Fri, Apr 27, 2018 at 05:21:21PM +0200, Andrea Bolognani wrote: > When hostdevs are involved, libvirt needs to poke into sysfs to > collect some information about them; since that pseudo-filesystem > doesn't exist on platforms other than Linux, the corresponding > tests would fail and need to be

[libvirt] [PATCH v2] nwfilter: increase pcap buffer size to be compatible with TPACKET_V3

When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", this turns on the "dhcpsnoop" thread, which uses libpcap to monitor traffic on the domain's tap device and extract the IP address from the DHCP response. If libpcap on the host is built with HAVE_TPACKET3 defined (to enable

Re: [libvirt] [dbus PATCH 1/6] Implement BlockCopy method for Domain Interface

On Fri, Apr 27, 2018 at 11:00:50AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 8 > src/domain.c| 35 +++ > 2 files changed, 43 insertions(+) Reviewed-by:

[libvirt] [PATCH 07/14] nwfilter: introduce virNWFilterBinding to decouple from virDomainNet

The virDomainNet struct contains everything related to configuring a guest network device. Out of all of this info, only 5 fields are relevant to configuring network filters. It will be more convenient for future changes to the nwfilter driver if the relevant fields are kept in a dedicated struct.

[libvirt] [PATCH 00/14] nwfilter: refactor the driver to make it independent of virt drivers

Today the nwfilter driver is entangled with the virt drivers in both directions. At various times when rebuilding filters nwfilter will call out to the virt driver to iterate over running guest's NICs. This has caused very complicated lock ordering rules to be required. If we are to split the virt

[libvirt] [PATCH 01/14] nwfilter: remove pointless virNWFilterHashTable struct

The virNWFilterHashTable struct only contains a single virHashTable member since commit 293d4fe2f11db98c91175525056c8883725d4b22 Author: Daniel P. Berrange Date: Mon Mar 24 16:35:23 2014 + Remove pointless storage of var names in virNWFilterHashTable Thus,

[libvirt] [PATCH WIP 14/14] nwfilter: remove virt driver callback layer for rebuilding filters

Now that the nwfilter driver keeps a list of bindings that it has created, there is no need for the complex virt driver callbacks. It is possible to simply iterate of the list of recorded filter bindings. This means that rebuilding filters no longer has to acquire any locks on the virDomainObj

[libvirt] [PATCH 03/14] nwfilter: remove virNWFilterHashTable typedefs entirely

All the code now just uses the virHashTablePtr type directly. Signed-off-by: Daniel P. Berrangé --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 +- src/conf/nwfilter_conf.h | 2 +- src/conf/nwfilter_ipaddrmap.c

[libvirt] [PATCH 06/14] nwfilter: fix leaking of filter parameters upon error

The filter parameters were not correctly free'd when an error hits while adding to the hash table. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_gentech_driver.c | 22 ++ src/nwfilter/nwfilter_gentech_driver.h | 2 +- 2 files changed, 7

[libvirt] [PATCH 05/14] nwfilter: remove obsolete code related to firewalld

There is a bunch of left over code in the nwfilter driver related to monitoring firewalld over dbus, that is no longer used since the conversion to use virFirewall APIs. Signed-off-by: Daniel P. Berrangé --- src/conf/virnwfilterobj.h | 1 -

[libvirt] [PATCH 13/14] nwfilter: keep track of active filter bindings

Currently the nwfilter driver does not keep any record of what filter bindings it has active. This means that when it needs to recreate filters, it has to rely on triggering callbacks provided by the virt drivers. This introduces a hash table recording the virNWFilterBinding objects so the driver

Re: [libvirt] [PATCH REBASE 0/5] qemu: fix domain object wait to handle monitor errors

ping On 18.04.2018 17:44, Nikolay Shirokovskiy wrote: > Main patch is 4th, others are misc. > > Nikolay Shirokovskiy (5): > qemu: erase synchronous block job cancel mentions in comments > qemu: monitor: set error flag even in OOM conditions > utils: export virCopyError > qemu: fix domain