Re: [libvirt] [PATCHv1 5/7] qemu_capabilities: Find QEMU binary for S390 arch

On Thu, May 17, 2018 at 17:02:23 -0400, Collin Walling wrote: > On 05/17/2018 04:41 PM, Jiri Denemark wrote: > > On Sat, May 05, 2018 at 12:48:47 -0500, Chris Venteicher wrote: > >> S390 uses qemu-kvm in /usr/libexec. > > > > That's incorrect, /usr/libexec/qemu-kvm is the native binary on > >

Re: [libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

On Thu, May 17, 2018 at 08:30:03AM +0200, Boris Fiuczynski wrote: > On 05/16/2018 06:30 PM, John Ferlan wrote: > > > > > > On 05/16/2018 11:09 AM, Pavel Hrdina wrote: > > > On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: > > > > Using a QEMU 2.12 tagged tree build and full build,

Re: [libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too

On Wed, 2018-05-16 at 17:42 +0200, Erik Skultety wrote: > On Thu, May 10, 2018 at 05:35:45PM +0200, Andrea Bolognani wrote: > > Perl jobs use the -test suffix instead of -check, which is > > used everywhere else. Rename them in order to be consistent. > > > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCHv3 12/13] build: switch --with-qemu default from yes to check

On Tue, 2018-05-15 at 16:00 +0200, Ján Tomko wrote: > On Tue, May 15, 2018 at 03:14:33PM +0200, Peter Krempa wrote: > > > AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [ > > > - LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [yes]) > > > > Well if we've required it until now, I'd be inclined to continue

Re: [libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

On 05/16/2018 06:30 PM, John Ferlan wrote: On 05/16/2018 11:09 AM, Pavel Hrdina wrote: On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: Using a QEMU 2.12 tagged tree build and full build, used: tests/qemucapsprobe /home/qemu/x86_64-softmmu/qemu-system-x86_64 > \

Re: [libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

On Wed, May 16, 2018 at 12:30:30PM -0400, John Ferlan wrote: > > > On 05/16/2018 11:09 AM, Pavel Hrdina wrote: > > On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: > >> Using a QEMU 2.12 tagged tree build and full build, used: > >> > >> tests/qemucapsprobe

Re: [libvirt] [jenkins-ci PATCH] projects: switch libvirt-perl over to using Module::Build

On Tue, 2018-05-15 at 20:30 +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 16:37 +0100, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > jobs/perl-makemaker.yaml | 136 - > > projects/libvirt-perl.yaml

Re: [libvirt] [REPOST PATCH] tests: Update x86_64 replies, caps to QEMU 2.12

On 05/17/2018 10:19 AM, Pavel Hrdina wrote: On Thu, May 17, 2018 at 08:30:03AM +0200, Boris Fiuczynski wrote: On 05/16/2018 06:30 PM, John Ferlan wrote: On 05/16/2018 11:09 AM, Pavel Hrdina wrote: On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: Using a QEMU 2.12 tagged tree

[libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

virCopyLastError is intended to be used after last error is set. However due to virLastErrorObject failures (very unlikely through as thread local error is allocated on first use) we can have zero fields in a copy as a result. In particular code field can be set to VIR_ERR_OK. In some places

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On 17.05.2018 14:01, Erik Skultety wrote: > On Thu, May 17, 2018 at 01:42:36PM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 17.05.2018 13:11, Nikolay Shirokovskiy wrote: >>> virCopyLastError is intended to be used after last error is set. >>> However due to virLastErrorObject failures (very

Re: [libvirt] [jenkins-ci PATCH] projects: set TEST_MAINTAINER for libvirt-perl build job too

On Thu, 2018-05-17 at 12:46 +0100, Daniel P. Berrangé wrote: > The TEST_MAINTAINER=1 env variable will effect running of Build.PL, > causing it to turn on many more GCC warning flags to validate the > build. So we need to set it for build job as well as test job. > > Signed-off-by: Daniel P.

Re: [libvirt] [PATCH 2/9] qemu: enable GIC only on AArch64

On Tue, 2018-05-15 at 12:53 +0200, Lubomir Rintel wrote: > Other "virt" type machines don't support it. > > Signed-off-by: Lubomir Rintel > --- > src/qemu/qemu_domain.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c >

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On Thu, May 17, 2018 at 02:49:12PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.05.2018 14:01, Erik Skultety wrote: > > On Thu, May 17, 2018 at 01:42:36PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 17.05.2018 13:11, Nikolay Shirokovskiy wrote: > >>> virCopyLastError is intended to be

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On 17.05.2018 15:25, Erik Skultety wrote: > On Thu, May 17, 2018 at 02:49:12PM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 17.05.2018 14:01, Erik Skultety wrote: >>> On Thu, May 17, 2018 at 01:42:36PM +0300, Nikolay Shirokovskiy wrote: On 17.05.2018 13:11, Nikolay Shirokovskiy

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 14:18 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > > > Perl to the rescue! The script ends up being only marginally > > > more verbose and obscure

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On Thu, May 17, 2018 at 01:42:36PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.05.2018 13:11, Nikolay Shirokovskiy wrote: > > virCopyLastError is intended to be used after last error is set. > > However due to virLastErrorObject failures (very unlikely through > > as thread local error is

Re: [libvirt] [PATCH REBASE 1/5] qemu: erase synchronous block job cancel mentions in comments

pushed slightly reworded On 03.05.2018 10:01, Nikolay Shirokovskiy wrote: > > > On 01.05.2018 01:03, John Ferlan wrote: >> >> >> On 04/18/2018 10:44 AM, Nikolay Shirokovskiy wrote: >>> Commit [1] dropped support for synchronous block job cancel. >>> This patch erases remnants from comments. >>>

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

On Thu, 2018-05-17 at 14:18 +0100, Daniel P. Berrangé wrote: > On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > > Perl to the rescue! The script ends up being only marginally > > more verbose and obscure as a result, the indentation is > > significantly better, and it should

[libvirt] KVM Forum 2018: Call For Participation

KVM Forum 2018: Call For Participation October 24-26, 2018 - Edinburgh International Conference Centre - Edinburgh, UK (All submissions must be received before midnight June 14, 2018)

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On 17.05.2018 14:49, Nikolay Shirokovskiy wrote: > > > On 17.05.2018 14:01, Erik Skultety wrote: >> On Thu, May 17, 2018 at 01:42:36PM +0300, Nikolay Shirokovskiy wrote: >>> >>> >>> On 17.05.2018 13:11, Nikolay Shirokovskiy wrote: virCopyLastError is intended to be used after last error

Re: [libvirt] [PATCH] docs: Fix copy-paste error in formatdomaincaps

On Thu, May 17, 2018 at 02:56:29PM +0200, Martin Kletzander wrote: > Reported-instead-of-fixing-immediately-by: Jiri Denemark > Signed-off-by: Martin Kletzander > --- > docs/formatdomaincaps.html.in | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On 17.05.2018 13:11, Nikolay Shirokovskiy wrote: > virCopyLastError is intended to be used after last error is set. > However due to virLastErrorObject failures (very unlikely through > as thread local error is allocated on first use) we can have zero > fields in a copy as a result. In

[libvirt] [jenkins-ci PATCH] projects: set TEST_MAINTAINER for libvirt-perl build job too

The TEST_MAINTAINER=1 env variable will effect running of Build.PL, causing it to turn on many more GCC warning flags to validate the build. So we need to set it for build job as well as test job. Signed-off-by: Daniel P. Berrangé --- projects/libvirt-perl.yaml | 2 ++ 1

[libvirt] [REPOSTv2 PATCH v3 5/6] domcaps: Add 'genid' to domain capabilities

Report domaincaps if the guest config accepts or $GUID. Signed-off-by: John Ferlan --- docs/formatdomaincaps.html.in | 7 ++- docs/schemas/domaincaps.rng | 7 +++ src/conf/domain_capabilities.c

[libvirt] [REPOSTv2 PATCH v3 3/6] qemu: Alter VM Generation ID for specific startup/launch transitions

Before we generate the command line for qemu, if the domain about to be launched desires to utilize the VM Generation ID functionality, then handle both the regenerating the GUID value for backup recovery (restore operation) and the startup after snapshot as both require a new GUID to be generated

[libvirt] [REPOSTv2 PATCH v3 6/6] docs: Add news article for VM Generation ID

Signed-off-by: John Ferlan --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 7d40e85b9a..67128e1120 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -54,6 +54,19 @@ a QEMU virtual machine.

[libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

We claim to be using Python 2 at the moment: however, we rely on crypt.mksalt(), which was introduced in Python 3 and has only been backported to Python 2 in RHEL and Fedora, so the script will only work on those operating systems. We could move to Python 3, but the CI nodes are running on a

[libvirt] [PATCH v3 0/4] qemu: use FD passing for chardev UNIX sockets

This series makes use of the chardev fd passing arriving in QEMU 2.12 to get rid of the startup race wrt opening the QEMU monitor. It is actually enabled in all chardev UNIX sockets for sake of having the same codepath everywhere, but is only important for the monitor socket. Changed in v3: -

[libvirt] [PATCH v3 1/4] qemu: probe for -chardev 'fd' parameter for FD passing

QEMU >= 2.12 will support passing of pre-opened file descriptors for socket based character devices. Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[libvirt] [PATCH v3 2/4] qemu: support passing pre-opened UNIX socket listen FD

There is a race condition when spawning QEMU where libvirt has spawned QEMU but the monitor socket is not yet open. Libvirt has to repeatedly try to connect() to QEMU's monitor until eventually it succeeds, or times out. We use kill() to check if QEMU is still alive so we avoid waiting a long time

[libvirt] [REPOSTv2 PATCH v3 1/6] conf: Add VM Generation ID parse/format support

The VM Generation ID is a mechanism to provide a unique 128-bit, cryptographically random, and integer value identifier known as the GUID (Globally Unique Identifier) to the guest OS. The value is used to help notify the guest operating system when the virtual machine is executed with a different

[libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

Second reposting of: https://www.redhat.com/archives/libvir-list/2018-May/msg00813.html To update patches with more conflicts for patch 2 (capabilities) and patch 6 (news) Cover from the v3 posting: v2: https://www.redhat.com/archives/libvir-list/2018-April/msg02234.html Changes since v2:

[libvirt] [REPOSTv2 PATCH v3 4/6] qemu: Add VM Generation ID to qemu command line

https://bugzilla.redhat.com/show_bug.cgi?id=1149445 If the domain requests usage of the genid functionality, then add the QEMU '-device vmgenid' to the command line providing either the supplied or generated GUID value. Add tests for both a generated and supplied GUID value. Signed-off-by: John

[libvirt] [REPOSTv2 PATCH v3 2/6] qemu: Add VM Generation ID device capability

Add the query of the device objects for the vmgenid device Signed-off-by: John Ferlan --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 +

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > We claim to be using Python 2 at the moment: however, we rely > on crypt.mksalt(), which was introduced in Python 3 and has > only been backported to Python 2 in RHEL and Fedora, so the > script will only work on those operating

[libvirt] [PATCH] docs: Fix copy-paste error in formatdomaincaps

Reported-instead-of-fixing-immediately-by: Jiri Denemark Signed-off-by: Martin Kletzander --- docs/formatdomaincaps.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in

Re: [libvirt] [PATCH 1/9] conf: add an option to specify a NS16550A serial port

On Tue, 2018-05-15 at 12:53 +0200, Lubomir Rintel wrote: > QEMU attaches this to a riscv/virt board. It's perhaps the same thing as > used on x86/pc, somewhat unfortunately called model="isa-serial". > > Signed-off-by: Lubomir Rintel > --- > docs/schemas/domaincommon.rng | 1 + >

[libvirt] [PATCH v3 4/4] qemu: remove pointless connect retry logic in agent

When the agent code was first introduced back in commit c160ce3316852a797d7b06b4ee101233866e69a9 Author: Daniel P. Berrange Date: Wed Oct 5 18:31:54 2011 +0100 QEMU guest agent support there was code that would loop and retry the connection when opening the

[libvirt] [PATCH v3 3/4] qemu: don't retry connect() if doing FD passing

Since libvirt called bind() and listen() on the UNIX socket, it is guaranteed that connect() will immediately succeed, if QEMU is running normally. It will only fail if QEMU has closed the monitor socket by mistake or if QEMU has exited, letting the kernel close it. With this in mind we can

Re: [libvirt] [PATCH 3/9] qemu: rename qemuDomainAssignARMVirtioMMIOAddresses()

On Tue, 2018-05-15 at 12:53 +0200, Lubomir Rintel wrote: > Having a MMIO VirtIO interface is not specific to ARM. RISC-V can use it > too. > > Signed-off-by: Lubomir Rintel > --- > src/qemu/qemu_domain_address.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [libvirt] [PATCH 4/9] util: add RISC-V support

On Tue, 2018-05-15 at 12:53 +0200, Lubomir Rintel wrote: > What works, with images from [1]: > > virt-install \ > --import --name riscv64 \ > --arch riscv64 --machine virt \ > --memory 2048 \ > --rng /dev/urandom \ > --disk /var/lib/libvirt/images/stage4-disk.img,bus=virtio

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

On Thu, May 17, 2018 at 04:35:12PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 15:22 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > > > A friend suggested > > > > > > diff --git a/guests/lcitool b/guests/lcitool > > > index

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > A typical XML representation of the virNWFilterBindingDefPtr struct > looks like this: > > > > f25arm7 > 12ac8b8c-4f23-4248-ae42-fdcd50c400fd > > > > > > > > > Signed-off-by: Daniel P.

Re: [libvirt] [PATCH] util: return generic error in virCopyLastError if error is not set

On Thu, May 17, 2018 at 03:35:59PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.05.2018 15:25, Erik Skultety wrote: > > On Thu, May 17, 2018 at 02:49:12PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 17.05.2018 14:01, Erik Skultety wrote: > >>> On Thu, May 17, 2018 at 01:42:36PM +0300,

Re: [libvirt] [PATCH] qemu: Add support for -device hda-output (disable line-in)

On 05/16/2018 06:11 PM, Filip Alac wrote: > Add support for hda 'output' codec for ich6 and ich9 sound devices, > which allow us to disable line-in for guest. > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1126641 > > Signed-off-by: Filip Alac > --- >

[libvirt] [PATCH 4/4] qemu: command: Remove qemuBuildHasMasterKey

The thin wrapper is not necessary. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 19c7149b5b..f3724a766b 100644 ---

[libvirt] [PATCH 2/3] util: Introduce virStringListSearch

The function performs a case insensitive search in a string list. Signed-off-by: Jiri Denemark --- src/libvirt_private.syms | 1 + src/util/virstring.c | 28 src/util/virstring.h | 3 +++ 3 files changed, 32 insertions(+) diff --git

[libvirt] [PATCH 3/3] qemu: Adapt to changed ppc64 CPU model names

QEMU 2.11 for ppc64 changed all CPU model names to lower case. Since libvirt can't change the model names for compatibility reasons, we need to translate the matching lower case models to the names known by libvirt. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [PATCH v2 04/21] conf: move virNWFilterBindingDefPtr into its own files

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > There's no code sharing between virNWFilterDef and > virNWFilterBindingDefPtr types, so it is clearer if they live in > separate source files and headers. > > Signed-off-by: Daniel P. Berrangé > --- >

[libvirt] [PATCH 0/2] qemu: Enable multihead screendumps

There's one small problem. QEMU might crash: https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04113.html But apart from that, works like charm. Michal Privoznik (2): qemu: Introduce QEMU_CAPS_SCREENDUMP_DEVICE qemu: Implement multiple screen support for virDomainScreenshot

[libvirt] [PATCH 1/4] qemu: command: Optimize formatting of 'passwordid' in qemuBuildTLSx509BackendProps

Use the 'S' modifier for create the field optionally rather than calling another JSON formatter function. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH 0/4] qemu: TLS cleanup and fix of path escaping

Clean up some code and fix wrong escaping of TLS certificate path. Peter Krempa (4): qemu: command: Optimize formatting of 'passwordid' in qemuBuildTLSx509BackendProps tests: qemuxml2argv: Test TLS certificate path containing a comma qemu: command: Fix formatting of TLS backend

Re: [libvirt] [PATCH v2 02/21] conf: change virNWFilterBindingPtr to virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > We are going to want to expose the NWFilter binding concept in the > public API, so the virNWFilterBindingPtr type needs to be used there. > Our internal type will shortly gain an XML representation, so rename > it to virNWFilterBindingDefPtr

[libvirt] [PATCH 0/3] Fix ppc64 CPU configuration for QEMU 2.11+

The original fix was both incomplete and too general. It only fixed domain startup, but libvirt would still report empty list of supported CPU models with recent QEMU for ppc64. On the other hand, while ppc64 QEMU ignores case when looking up CPU model names, x86_64 QEMU does case sensitive

Re: [libvirt] [PATCH 0/4] qemu: TLS cleanup and fix of path escaping

On Thu, May 17, 2018 at 05:17:31PM +0200, Peter Krempa wrote: Clean up some code and fix wrong escaping of TLS certificate path. Peter Krempa (4): qemu: command: Optimize formatting of 'passwordid' in qemuBuildTLSx509BackendProps tests: qemuxml2argv: Test TLS certificate path containing a

[libvirt] [tck PATCH] Stop deleting MANIFEST file when making release dists

The MANIFEST file is now pre-created rather than auto-generated Signed-off-by: Daniel P. Berrangé --- Pushed as trivial + build fix prepare-release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prepare-release.sh b/prepare-release.sh index

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

On Thu, 2018-05-17 at 15:22 +0100, Daniel P. Berrangé wrote: > On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > > A friend suggested > > > > diff --git a/guests/lcitool b/guests/lcitool > > index 568e52c..5855368 100755 > > --- a/guests/lcitool > > +++ b/guests/lcitool > > @@

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > A typical XML representation of the virNWFilterBindingDefPtr struct > looks like this: > > > > f25arm7 > 12ac8b8c-4f23-4248-ae42-fdcd50c400fd > > > > > > > > > Signed-off-by: Daniel P.

Re: [libvirt] [PATCH 2/2] qemu: Implement multiple screen support for virDomainScreenshot

On Thu, May 17, 2018 at 17:18:29 +0200, Michal Privoznik wrote: > According to virDomainScreenshot() documentation, screens are > numbered sequentially. e.g. having two graphics cards, both with > four heads, screen ID 5 addresses the second head on the second > card. > > But apart from that,

Re: [libvirt] [PATCH v2 03/21] conf: add missing virxml.h include for nwfilter_params.h

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > The nwfilter_params.h header references the xmlNodePtr type, so must > include the virxml.h header to get the libxml2 types defined. > > Signed-off-by: Daniel P. Berrangé > --- > src/conf/nwfilter_params.h | 1 + > 1

Re: [libvirt] [PATCH v2 06/21] schemas: add schema for nwfilter binding XML document

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > docs/schemas/domaincommon.rng| 27 +- > docs/schemas/nwfilter.rng| 29 +-- > docs/schemas/nwfilter_params.rng | 32

[libvirt] [PATCH 2/2] qemu: Implement multiple screen support for virDomainScreenshot

According to virDomainScreenshot() documentation, screens are numbered sequentially. e.g. having two graphics cards, both with four heads, screen ID 5 addresses the second head on the second card. But apart from that, there's nothing special happening here. Signed-off-by: Michal Privoznik

[libvirt] [PATCH 1/2] qemu: Introduce QEMU_CAPS_SCREENDUMP_DEVICE

As of v2.12.0-rc0~32^2 QEMU is capable specifying which display device and head should the screendump be taken from. Track this capability so that we can use it later in our virDomainScreenshot API. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c

[libvirt] [PATCH 3/4] qemu: command: Fix formatting of TLS backend properties

The JSON property generator should not escape commas as we do on the command line. The JSON->commandline generator already does that. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 20 +++-

[libvirt] [PATCH 2/4] tests: qemuxml2argv: Test TLS certificate path containing a comma

We have to escape commas when formatting them on the command line. Add a test case of a TLS path containing a comma. Note that the output is wrong, this test case is to prove there's a bug. Signed-off-by: Peter Krempa ---

[libvirt] [PATCH 1/3] Revert "domcaps: Treat host models as case-insensitive strings"

This reverts commit 2d8721e2606806164782028ecf1ee33a9bbaa8fe. This fix was both incomplete and too general. It only fixed domain startup, but libvirt would still report empty list of supported CPU models with recent QEMU for ppc64. On the other hand, while ppc64 QEMU ignores case when looking up

Re: [libvirt] [PATCH 1/2] qemu: Introduce QEMU_CAPS_SCREENDUMP_DEVICE

On Thu, May 17, 2018 at 17:18:28 +0200, Michal Privoznik wrote: > As of v2.12.0-rc0~32^2 QEMU is capable specifying which display > device and head should the screendump be taken from. Track this > capability so that we can use it later in our virDomainScreenshot > API. > > Signed-off-by: Michal

Re: [libvirt] [PATCH] qemu: Add support for -device hda-output (disable line-in)

On Thu, May 17, 2018 at 12:11:12AM +0200, Filip Alac wrote: > Add support for hda 'output' codec for ich6 and ich9 sound devices, > which allow us to disable line-in for guest. > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1126641 > > Signed-off-by: Filip Alac >

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > A typical XML representation of the virNWFilterBindingDefPtr struct > looks like this: > > > > f25arm7 > 12ac8b8c-4f23-4248-ae42-fdcd50c400fd > > > > > > > I haven't had time to look at

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

On Thu, May 17, 2018 at 01:31:04PM -0400, Laine Stump wrote: > On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > > A typical XML representation of the virNWFilterBindingDefPtr struct > > looks like this: > > > > > > > > f25arm7 > > 12ac8b8c-4f23-4248-ae42-fdcd50c400fd > >

Re: [libvirt] [PATCHv1 5/7] qemu_capabilities: Find QEMU binary for S390 arch

On 05/17/2018 04:41 PM, Jiri Denemark wrote: > On Sat, May 05, 2018 at 12:48:47 -0500, Chris Venteicher wrote: >> S390 uses qemu-kvm in /usr/libexec. > > That's incorrect, /usr/libexec/qemu-kvm is the native binary on > RHEL/CentOS. That is it's arch matches host arch. > >> --- >>

Re: [libvirt] [PATCHv1 3/7] qemu_capabilities: Start and connect to QEMU

On Sat, May 05, 2018 at 12:48:45 -0500, Chris Venteicher wrote: > Start and connect to QEMU so QMP commands can be performed. > > Isolates code for starting QEMU and establishing Monitor connections > from code for obtaining capabilities so that arbitrary QMP commands can > be exchanged with

Re: [libvirt] [PATCHv1 2/7] qemu_capabilities: CPUModelInfo: XML/QMP format conversion

On Sat, May 05, 2018 at 12:48:44 -0500, Chris Venteicher wrote: > Functions converting directly between virsh XML and QMEU QMP forms of > CPUModelInfo. The XML parsing formatting code is in src/conf/cpu_conf.c and there's no need to duplicate it here. The translation should just work between

Re: [libvirt] [PATCHv1 0/7] Baseline CPU model using QEMU QMP exchanges

On Sat, May 05, 2018 at 12:48:42 -0500, Chris Venteicher wrote: > Some architectures (S390) depend on QEMU to compute baseline CPU model. > > Interacting with QEMU requires starting the QEMU process and completing one or > more query-cpu-model-baseline QMP exchanges with QEMU. > > > This patch

Re: [libvirt] [PATCHv1 5/7] qemu_capabilities: Find QEMU binary for S390 arch

On Sat, May 05, 2018 at 12:48:47 -0500, Chris Venteicher wrote: > S390 uses qemu-kvm in /usr/libexec. That's incorrect, /usr/libexec/qemu-kvm is the native binary on RHEL/CentOS. That is it's arch matches host arch. > --- > src/qemu/qemu_capabilities.c | 5 + > 1 file changed, 5

Re: [libvirt] [PATCHv1 0/7] Baseline CPU model using QEMU QMP exchanges

On 05/17/2018 04:15 PM, Jiri Denemark wrote: > On Sat, May 05, 2018 at 12:48:42 -0500, Chris Venteicher wrote: >> Some architectures (S390) depend on QEMU to compute baseline CPU model. >> >> Interacting with QEMU requires starting the QEMU process and completing one >> or >> more

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

On 05/17/2018 01:37 PM, Daniel P. Berrangé wrote: > On Thu, May 17, 2018 at 01:31:04PM -0400, Laine Stump wrote: >> On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: >>> A typical XML representation of the virNWFilterBindingDefPtr struct >>> looks like this: >>> >>> >>> >>> f25arm7

Re: [libvirt] [PATCH v2 07/21] nwfilter: export port binding concept in the public API

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > When the daemons are split there will need to be a way for the virt > drivers and/or network driver to create and delete bindings between > network ports and network filters. This defines a set of public APIs > that are suitable for managing

Re: [libvirt] [PATCH v2 09/21] remote: add support for nwfilter binding objects

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/remote/remote_daemon_dispatch.c | 15 + > src/remote/remote_driver.c | 20 +++ > src/remote/remote_protocol.x| 90 - >

Re: [libvirt] [PATCH v2 08/21] access: add nwfilter binding object permissions

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/access/viraccessdriver.h | 5 > src/access/viraccessdrivernop.c| 10 > src/access/viraccessdriverpolkit.c | 21 >

Re: [libvirt] [PATCH v2 11/21] nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > Use the virNWFilterBindingDefPtr struct in the gentech driver code > directly. > > Signed-off-by: Daniel P. Berrangé > --- > src/nwfilter/nwfilter_dhcpsnoop.c | 35 +++-- > src/nwfilter/nwfilter_driver.c |

Re: [libvirt] [PATCH v1] Loop through all resolved addresses in virNetSocketNewListenTCP

On 05/17/2018 02:14 AM, Olaf Hering wrote: > Am Wed, 16 May 2018 18:44:32 -0400 > schrieb John Ferlan : > >> On 05/15/2018 04:20 AM, Olaf Hering wrote: >>> Currently virNetSocketNewListenTCP bails out early under the following >>> conditions: >>> - the hostname resolves to

Re: [libvirt] [PATCH v2 12/21] nwfilter: convert IP address learning code to virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > Use the virNWFilterBindingDefPTr struct in the IP address learning code > directly. > > Signed-off-by: Daniel P. Berrangé > --- > src/nwfilter/nwfilter_gentech_driver.c | 7 +- > src/nwfilter/nwfilter_learnipaddr.c|

Re: [libvirt] [PATCH v2 10/21] virsh: add nwfilter binding commands

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > $ virsh nwfilter-binding-list > Port Dev Filter > -- > vnet0 clean-traffic > vnet1 clean-traffic I know this is

Re: [libvirt] [PATCH v2 13/21] nwfilter: convert DHCP address snooping code to virNWFilterBindingDefPtr

On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > Use the virNWFilterBindingDefPtr struct in the DHCP address snooping code > directly. > > Signed-off-by: Daniel P. Berrangé > --- > src/nwfilter/nwfilter_dhcpsnoop.c | 150 ++--- >

[libvirt] [RFC v3] external (pull) backup API

Here's my updated counterproposal for a backup API. In comparison to v2 posted by Nikolay: https://www.redhat.com/archives/libvir-list/2018-April/msg00115.html - changed terminology a bit: Nikolay's "BlockSnapshot" is now called a "Checkpoint", and "BlockExportStart/Stop" is now

Re: [libvirt] [PATCH] qemu: Add support for -device hda-output (disable line-in)

On Thu, May 17, 2018 at 12:15:08PM -0400, John Ferlan wrote: > > > On 05/16/2018 06:11 PM, Filip Alac wrote: > > Add support for hda 'output' codec for ich6 and ich9 sound devices, > > which allow us to disable line-in for guest. > > > > Fixes: > >

Re: [libvirt] [PATCHv1 4/7] qemu_capabilities: Baseline CPUModel via QEMU

On Sat, May 05, 2018 at 12:48:46 -0500, Chris Venteicher wrote: > Spinup QEMU instance and complete QMP query-cpu-model-baseline exchanges > to determine CPUModel Baseline. > > query-cpu-model-baseline only compares two CPUModels so multiple > exchanges are needed to evaluate more than two

Re: [libvirt] Question about using cpu mode "host-model" while providing a cpu model name

On Wed, May 09, 2018 at 13:36:55 +0200, Halil Pasic wrote: > > > On 05/09/2018 12:41 PM, Jiri Denemark wrote: > > On Tue, May 08, 2018 at 10:44:22 -0400, Collin Walling wrote: > >> Hi > >> > >> I have noticed something that may be misconstrued regarding the libvirt > >> domain xml format > >>

Re: [libvirt] [PATCHv1 6/7] qemu_capabilities: qmperr pointer tracked in QMPCommand

On Sat, May 05, 2018 at 12:48:48 -0500, Chris Venteicher wrote: > Allow QEMU process to be started without requirement for caller to > maintain handle to qmperr pointer. > > The handle to qmperr pointer can be > stored in QMPCommand structure (new way) > stored in calling function's stack

Re: [libvirt] [PATCH v1] Loop through all resolved addresses in virNetSocketNewListenTCP

Am Wed, 16 May 2018 18:44:32 -0400 schrieb John Ferlan : > On 05/15/2018 04:20 AM, Olaf Hering wrote: > > Currently virNetSocketNewListenTCP bails out early under the following > > conditions: > > - the hostname resolves to at least one IPv4 and at least one IPv6 > > address