On 11/19/18 9:10 PM, Wang Huaqiang wrote:
> The path argument of virFileIsDir should be a full name
> of file, pathname and filename. Fixed it by passing the
> full path name to virFileIsDir.
>
> Signed-off-by: Wang Huaqiang
> ---
> src/util/virresctrl.c | 9 -
> 1 file changed, 8
Radostin Stoyanov (2):
builder: Use prefix '=> /' to identify lib path
Use "/boot/vmlinuz-linux" as default kernel path
bin/virt-sandbox.c| 5 +++--
libvirt-sandbox/libvirt-sandbox-builder-machine.c | 4
libvirt-sandbox/libvirt-sandbox-builder.c
The output of ldd might contain a fully qualified path on the left
hand side of the '=>'. For example:
(glibc 2.28)
$ ldd /usr/libexec/libvirt-sandbox-init-common | grep ld
/lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2
(0x7fcdceb96000)
(glibc 2.27)
$ ldd
On some linux distributions "/boot/vmlinuz-linux" is set as default
kernel path. If this file does not exist we fallback to the value
"/boot/vmlinuz-$KERNEL-VERSION"
Signed-off-by: Radostin Stoyanov
---
bin/virt-sandbox.c| 5 +++--
Signed-off-by: John Ferlan
---
Well I've given it a "go", hopefully it's (more or less) right. The build
and test at least pass ;-)
domain.go | 52 +++
domain_wrapper.go | 20 ++
domain_wrapper.h | 8
3 files
Signed-off-by: John Ferlan
---
This one I'll push under the build/test breaker rule...
I hadn't "installed" the libvirt library with the API so when "testing"
the build I just removed the CHECK_VERSION lines... Of course when looking
at the CI results I still saw the fail... So I looked
On Mon, Nov 19, 2018 at 10:35:56PM +0100, Martin Kletzander wrote:
> The virGet*ID() functions should be called only if the user exists not when it
> doesn't.
>
> Signed-off-by: Martin Kletzander
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Mon, Nov 19, 2018 at 10:35:57PM +0100, Martin Kletzander wrote:
> Since the functions only return 0 or 1, they should return bool. I missed the
> change when "refactoring" the first commit.
>
> Signed-off-by: Martin Kletzander
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
Hi,
while working on the Python type annotations for the Python libvirt
binding I noticed the following code in
libvirt-override-virDomainSnapshot.py:
> def listAllChildren(self, flags=0):
> """List all child snapshots and returns a list of snapshot objects"""
...
> raise
On Tue, Nov 20, 2018 at 01:27:05PM +0100, Andrea Bolognani wrote:
> On Mon, 2018-11-19 at 14:14 -0500, Michael S. Tsirkin wrote:
> > On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote:
> > > On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin"
> > > wrote:
> > > > We have this
There are certain cases e.g. containers where the sysfs path might
exists, but might fail. Unfortunately the exact restrictions are only
known to libvirt when trying to write to it so we need to try it.
But in case it fails there is no need to fully abort, in those cases try
to fall back to the
On Tue, Nov 20, 2018 at 01:25:46PM +0100, Christian Ehrhardt wrote:
> There are certain cases e.g. containers where the sysfs path might
> exists, but might fail. Unfortunately the exact restrictions are only
> known to libvirt when trying to write to it so we need to try it.
>
> But in case it
Adding the interface in qemu to report CMT statistic information
through command 'virsh domstats --cpu-total'.
Below is a typical output:
# virsh domstats 1 --cpu-total
Domain: 'ubuntu16.04-base'
...
cpu.cache.monitor.count=2
Signed-off-by: Wang Huaqiang
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4406aeb..deadb85 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -68,6 +68,18 @@
be viewed via the domain statistics.
These two patches are the remaining part for the CMT enabling series, and most
of the series have been merged.
This series is addressing John's review comments and suggestions, which are
https://www.redhat.com/archives/libvir-list/2018-November/msg00510.html
On Tue, Nov 20, 2018 at 11:17:07AM +0100, Christian Ehrhardt wrote:
> There are certain cases e.g. containers where the sysfs path might
> exists, but might fail. Unfortunately the exact restrictions are only
> known to libvirt when trying to write to it so we need to try it.
>
> But in case it
Hi
On Mon, Nov 12, 2018 at 8:03 PM Daniel P. Berrangé wrote:
>
> On Wed, Nov 07, 2018 at 07:13:11PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> > review, let's define a common set of backend conventions to help with
> > management layer
On Tue, Nov 20, 2018 at 01:03:09PM +0100, Christian Ehrhardt wrote:
> On Tue, Nov 20, 2018 at 12:58 PM Daniel P. Berrangé
> wrote:
> >
> > On Tue, Nov 20, 2018 at 11:17:07AM +0100, Christian Ehrhardt wrote:
> > > There are certain cases e.g. containers where the sysfs path might
> > > exists,
> -Original Message-
> From: Wang, Huaqiang
> Sent: Thursday, November 15, 2018 8:41 PM
> To: John Ferlan ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Ding, Jian-feng feng.d...@intel.com>; Zang, Rui
> Subject: RE: [PATCHv8 16/17] qemu: Report cache occupancy (CMT) with
> domstats
>
From: Marc Hartmayer
The test driver state (@testDriver) uses it's own reference counting
and locking implementation. Instead of doing that, convert @testDriver
into a virObjectLockable and use the provided functionalities.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
This
On Mon, 2018-11-19 at 14:14 -0500, Michael S. Tsirkin wrote:
> On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote:
> > On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin"
> > wrote:
> > > We have this assumption that if we force a choice then people will
> > > choose the right
The test driver state (@testDriver) uses it's own reference counting
and locking implementation. Instead of doing that, convert @testDriver
into a virObjectLockable and use the provided functionalities.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
This patch was originally
On Thu, Nov 01, 2018 at 04:37 PM +0100, Michal Privoznik
wrote:
> On 10/30/2018 01:55 PM, Daniel P. Berrangé wrote:
>> On Tue, Oct 30, 2018 at 10:32:08AM +, Daniel P. Berrangé wrote:
>>> On Tue, Oct 30, 2018 at 11:08:45AM +0100, Michal Privoznik wrote:
On 10/30/2018 10:35 AM, Daniel P.
On Mon, 19 Nov 2018 19:32:32 -0200
Eduardo Habkost wrote:
> However, I wish this kind of usability magic didn't automatically
> imposed us the burden of keeping guest ABI compatibility too.
> Keeping ABI compatibility on the machine-friendly device types and
> interfaces is already hard enough.
On Tue, Nov 20, 2018 at 12:58 PM Daniel P. Berrangé wrote:
>
> On Tue, Nov 20, 2018 at 11:17:07AM +0100, Christian Ehrhardt wrote:
> > There are certain cases e.g. containers where the sysfs path might
> > exists, but might fail. Unfortunately the exact restrictions are only
> > known to libvirt
On 11/17/18 8:51 PM, Radoslaw Biernacki wrote:
> libvirt wrongly assumes that VF netdev has to have the
> netdev assigned to PF. There is no such requirement in SRIOV standard.
> This patch change the virNetDevSwitchdevFeature() function to deal
> with SRIOV devices which does not have netdev on
On 11/17/18 8:51 PM, Radoslaw Biernacki wrote:
> Removing redundant sections of the code
>
> Signed-off-by: Radoslaw Biernacki
> Reviewed-by: Michal Privoznik
> ---
> src/util/virnetdev.c | 40 +++-
> 1 file changed, 5 insertions(+), 35 deletions(-)
>
> diff --git
There are certain cases e.g. containers where the sysfs path might
exists, but might fail. Unfortunately the exact restrictions are only
known to libvirt when trying to write to it so we need to try it.
But in case it fails there is no need to fully abort, in those cases try
to fall back to the
On Mon, Nov 19, 2018 at 10:44:54PM -0200, Eduardo Habkost wrote:
> On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote:
> > On Thu, 15 Nov 2018 10:05:59 +
> > Daniel P. Berrangé wrote:
> >
> > > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote:
> > > > Many of the
On Mon, 19 Nov 2018 22:44:54 -0200
Eduardo Habkost wrote:
> On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote:
> > On Thu, 15 Nov 2018 10:05:59 +
> > Daniel P. Berrangé wrote:
> > > If libvirt did this compatibility approach, can you
> > > confirm this would be live migration
On Tue, Nov 20, 2018 at 11:52:27AM +0100, Cornelia Huck wrote:
> On Mon, 19 Nov 2018 22:44:54 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote:
> > > On Thu, 15 Nov 2018 10:05:59 +
> > > Daniel P. Berrangé wrote:
>
> > > > If libvirt did
On Tue, Nov 20, 2018 at 11:17 AM Christian Ehrhardt
wrote:
>
> There are certain cases e.g. containers where the sysfs path might
> exists, but might fail. Unfortunately the exact restrictions are only
> known to libvirt when trying to write to it so we need to try it.
>
> But in case it fails
On Tue, Nov 20, 2018 at 04:05:43PM +0100, Marcin Mirecki wrote:
> Hello,
>
> The network filters feature has an option of automatically detecting the IP
> of a VM [1].
> Is it possible to retrieve this IP by any means?
It is possibly visible in the live XML in the XML as a
parameter.
> If not,
Signed-off-by: John Ferlan
---
Although I suppose a build breaker, it would be good to have someone
review my (lack of) Perl writing skills. The changes do allow the build
to pass though ;-).
Changes| 2 ++
lib/Sys/Virt.xs| 41
Hello,
The network filters feature has an option of automatically detecting the IP
of a VM [1].
Is it possible to retrieve this IP by any means?
If not, would you considering adding such a feature?
It would be very useful for uses cases where there is no guest agent.
Thanks,
Marcin
[1]
On Tue, Nov 20, 2018 at 09:26:28AM -0500, John Ferlan wrote:
> Signed-off-by: John Ferlan
> ---
> Although I suppose a build breaker, it would be good to have someone
> review my (lack of) Perl writing skills. The changes do allow the build
> to pass though ;-).
>
> Changes|
On Sat, Oct 20, 2018 at 05:19:56PM +0300, Roman Bolshakov wrote:
> With this change virsh domcapabilites shows:
>
>
> Signed-off-by: Roman Bolshakov
> ---
> src/qemu/qemu_capabilities.c | 22 +++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git
Both VIR_DOMAIN_FEATURE_HPT and VIR_DOMAIN_FEATURE_HTM are
handled in the exact same way, so we can remove some duplicated
code without losing any functionality.
Signed-off-by: Andrea Bolognani
---
There are plenty more opportunities for refactoring in the code
that handles features, but I
Signed-off-by: Andrea Bolognani
---
docs/formatdomain.html.in | 12
docs/schemas/domaincommon.rng | 5 +
src/conf/domain_conf.c| 4
src/conf/domain_conf.h| 1 +
src/qemu/qemu_domain.c
Andrea Bolognani (6):
qemu: Drop duplicated code from qemuDomainDefValidateFeatures()
tests: Add capabilities data for QEMU 3.1.0 on ppc64
qemu: Introduce QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV
conf: Parse and format nested-hv feature
qemu: Format nested-hv feature on the command line
Signed-off-by: Andrea Bolognani
---
Snipped heavily; the full patch can be retrieved from
https://github.com/andreabolognani/libvirt/tree/nested-hv
.../caps_3.1.0.ppc64.replies | 23503
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1075 +
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 +
tests/qemuxml2argvtest.c| 1 +
tests/qemuxml2xmltest.c
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 20
tests/qemuxml2argvdata/pseries-features.args | 2 +-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
Need to free params like similar API's such as libvirt_virDomainMigrate3
and libvirt_virDomainMigrateToURI3.
Signed-off-by: John Ferlan
---
libvirt-override.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 761b71b..0353306 100644
---
Similar to libvirt_virDomainBlockCopy (and migration API's). Create
the code for the new API.
Signed-off-by: John Ferlan
---
generator.py | 1 +
libvirt-override-api.xml | 8 +++
libvirt-override.c | 51
3 files changed, 60
On Tue, Nov 20, 2018 at 11:17:10AM -0500, John Ferlan wrote:
> Signed-off-by: John Ferlan
> ---
> libvirt-override.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
--
libvir-list mailing list
On Tue, Nov 20, 2018 at 11:17:12AM -0500, John Ferlan wrote:
> Similar to libvirt_virDomainBlockCopy (and migration API's). Create
> the code for the new API.
>
> Signed-off-by: John Ferlan
> ---
> generator.py | 1 +
> libvirt-override-api.xml | 8 +++
> libvirt-override.c
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4406aeb775..3569c6cd48 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -68,6 +68,16 @@
be viewed via the domain statistics.
On 11/20/18 10:17 AM, Daniel P. Berrangé wrote:
> On Tue, Nov 20, 2018 at 04:05:43PM +0100, Marcin Mirecki wrote:
>> Hello,
>>
>> The network filters feature has an option of automatically detecting the IP
>> of a VM [1].
>> Is it possible to retrieve this IP by any means?
> It is possibly visible
First two patches are a couple of fixes I noted while implementing
and looking for "similar examples". The last patch is the impl for
the API (it does fix the build).
John Ferlan (3):
Fix typos in virDomainSetSchedulerParameters name
Add missing virPyDictToTypedParams for
Signed-off-by: John Ferlan
---
libvirt-override.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index e74c7dd..761b71b 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -571,7 +571,7 @@
On Tue, Nov 20, 2018 at 11:17:11AM -0500, John Ferlan wrote:
> Need to free params like similar API's such as libvirt_virDomainMigrate3
> and libvirt_virDomainMigrateToURI3.
>
> Signed-off-by: John Ferlan
> ---
> libvirt-override.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Pavel
Similar to libvirt_virDomainBlockCopy (and migration API's). Create
the code for the new API.
Signed-off-by: John Ferlan
---
generator.py | 1 +
libvirt-override-api.xml | 8 ++
libvirt-override.c | 54
3 files changed, 63
v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00772.html
Changes since v1:
- Pushed the first two patches w/ R-By
- Add/Insert a patch to handle when PyDict_Check fails
- Modify libvirt_virDomainSetIOThreadParams from code review for
the @args on the same line (not
If PyDict_Check fails, we should force an error rather than
blindly continuing on.
Signed-off-by: John Ferlan
---
libvirt-override.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 0353306..8748101 100644
--- a/libvirt-override.c
On Tue, Nov 20, 2018 at 12:13:02PM -0500, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00772.html
>
> Changes since v1:
>
> - Pushed the first two patches w/ R-By
>
> - Add/Insert a patch to handle when PyDict_Check fails
>
> - Modify
56 matches
Mail list logo
