On 12/12/18 9:29 AM, Michal Privoznik wrote:
> On 12/4/18 9:32 PM, John Ferlan wrote:
>> If virSecretGetSecretString is using by secretLookupByUUID,
>> then it's possible the found sec->usageType doesn't match the
>> desired @secretUsageType. If this occurs for the encrypted
>> volume creation
On 12.12.2018 17:28, John Ferlan wrote:
>
>
> On 12/12/18 5:59 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 11.12.2018 19:41, John Ferlan wrote:
>>>
>>>
>>> On 12/11/18 6:04 AM, Nikolay Shirokovskiy wrote:
On 10.12.2018 19:58, John Ferlan wrote:
>
>
> On 11/8/18 8:02
The blockjob module uses 'qemuDomainAsyncJob' in it's public headers.
As I plan adding a new structure containing job data which will need to
be included in "qemu_domain.h" it's necessary to break the circular
dependency.
Convert 'qemuDomainAsyncJob' type to 'int' as it's an enum.
Signed-off-by:
The event reports the disk path to identify the disk which makes sense
only for local disks. Additionally network backed disks like NBD don't
need to have a path so the callback would return NULL.
Report VIR_DOMAIN_EVENT_ID_BLOCK_JOB only for non-empty local disks.
Signed-off-by: Peter Krempa
Modify qemuBlockJobSyncBeginDisk to operate on qemuBlockt sJobDataPtr and
rename it accordingly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 11 +++
src/qemu/qemu_blockjob.h | 2 +-
src/qemu/qemu_driver.c| 10 +-
src/qemu/qemu_migration.c | 11 +++
If the job wasn't started, we don't need to end the synchronous job. Add
a note and drop the unnecessary calls.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 4 +++-
src/qemu/qemu_migration.c | 8 ++--
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git
Block jobs can also happen on objects which are not a disk at a given
point (e.g. the frontend was not hotplugged yet) and thus will be
eventually kept separately. Add a reference back to the disk for
blockjobs which do correspond to a disk.
Signed-off-by: Peter Krempa
---
Don't split out individual fields, just pass in the job.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 531de035af..c6b70c5388
Reference counting will simplify semantics of the lifecycle of the
object.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 33 -
src/qemu/qemu_blockjob.h | 5 +++--
src/qemu/qemu_domain.c | 4 ++--
3 files changed, 33 insertions(+), 9 deletions(-)
The processing function modifies the job state so it should make sure
that the variable holding the new state is cleared properly and not the
caller. The caller should only deal with the job state and not the
transition that happened.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c |
Rather than direclty modifying fields in the qemuBlockJobDataPtr
structure add a bunch of fields which allow to do the transitions.
This will help later when adding more complexity to the job handing.
APIs introduced in this patch are:
qemuBlockJobDiskNew - prepare for starting a new blockjob
Put the emitting of VIR_DOMAIN_EVENT_ID_BLOCK_JOB and
VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 into a separate function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git
This series refactors how libvirt stores block job data and handles
block job events in general. This is done in preparation for -blockdev
support where we'll need to add support for the 'blockdev-create' job
which is not associated to any frontend 'disk' in some cases.
This series introduces a
Replace use of qemuBlockJobEventProcess with the general helper. A small
tweak is required to pass in the 'type' and 'status' of the job via the
appropriate private data variables.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 14 --
1 file changed, 12 insertions(+), 2
The function is now only called locally. Some code movement was
necessary to avoid forward declarations.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 80
src/qemu/qemu_blockjob.h | 6 ---
2 files changed, 40 insertions(+), 46 deletions(-)
All the public APIs of the qemu_blockjob module operate on a 'disk'.
Since I'll be adding APIs which operate on a job later let's rename the
existing ones.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 28 ++--
src/qemu/qemu_blockjob.h | 16
On 12.12.2018 16:28, John Ferlan wrote:
>
>
> On 12/12/18 3:04 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 11.12.2018 17:33, John Ferlan wrote:
>>>
>>>
>>> On 12/11/18 2:34 AM, Nikolay Shirokovskiy wrote:
On 11.12.2018 01:05, John Ferlan wrote:
>
> $SUBJ:
>
>
On 12/12/18 9:32 AM, Nikolay Shirokovskiy wrote:
>
>
> On 12.12.2018 16:28, John Ferlan wrote:
>>
>>
>> On 12/12/18 3:04 AM, Nikolay Shirokovskiy wrote:
>>>
>>>
>>> On 11.12.2018 17:33, John Ferlan wrote:
On 12/11/18 2:34 AM, Nikolay Shirokovskiy wrote:
>
>
> On
On Tue, Dec 11, 2018 at 06:54:31PM -0500, John Ferlan wrote:
>
>
> On 12/7/18 9:47 AM, Erik Skultety wrote:
> > The validation code for graphics has been in place for a while, but
> > because it is only executed from the device iterator, that validation
> > code was never truly run. The
When cancelling job after a reconnect we can now use the disk block job
state rather than having to re-detect it in the migration code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 63 +++
1 file changed, 18 insertions(+), 45 deletions(-)
diff
Later on we'll format these values into the status XML so the from/to
string functions will come handy. The implementation also notes that
these will be used in the status XML to avoid somebody changing the
values.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 7 +++
Block job state was widely untracked by libvirt across restarts which
was allowed by a stateless block job finishing handler which discarded
disk state and redetected it. This is undesirable since we'll need to
track more information for individual blockjobs due to -blockdev
integration
Allow using the node name to specify the base of the 'stream' operation,
allow specifying explicit job name and add support for delayed dismiss
of the job so that we can reap the state even if libvirtd was not
running when qemu emitted the job completion event.
Signed-off-by: Peter Krempa
---
We need to store the block job state in the status XML so that we can
properly recover any data when reconnecting after startup and also in
the end to be able to do any transition of the backing chain that
happened while libvirt was not connected to the monitor.
First step is to note the name,
Signed-off-by: Peter Krempa
---
.../blockjob-blockdev-in.xml | 364 ++
.../blockjob-blockdev-out.xml | 1 +
tests/qemuxml2xmltest.c | 2 +
3 files changed, 367 insertions(+)
create mode 100644
Internally we do a 'block-copy' to accomodate non-shared storage
migration but the code did not fill in that the block job was active on
the disk when starting the copy job. Since we handle block jobs finishes
regardless of having it registered it's not a problem but soon will
become one.
Allow using the node name to specify the base and top of the 'commit'
operation, allow specifying explicit job name and add support for
delayed dismiss of the job so that we can reap the state even if
libvirtd was not running when qemu emitted the job completion event.
Signed-off-by: Peter Krempa
Instead of passing in the disk information, pass in the job and name the
function accordingly.
Few callers needed to be modified to have the job pointer handy.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 20
src/qemu/qemu_blockjob.h | 6 +++---
The field is used to note the state the job has transitioned to while
handling the blockjob state change event. Rename the field so that it's
obvious that this is the new state and not the general state of the
blockjob.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 12 ++--
qemuBlockJobEventProcessLegacy was getting too big. Remove handling of
completed jobs in a separate function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 118 +--
1 file changed, 65 insertions(+), 53 deletions(-)
diff --git
This will handle blockjob finalizing for the old approach so rename it
accordingly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index
The same message is reported in 3 distinct places. Move it out into a
single function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 43 ---
1 file changed, 18 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_migration.c
Rather than storing the presence of the blockjob in a flag we can bind
together the lifecycle of the job with the lifecycle of the object which
is tracking the data for it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 76 +---
Now that we reprobe the status of blockjobs when reconnecting in
addition to handling job status events, the status reprobing can be
removed as we always track the correct status internally.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 20 +---
1 file changed, 1
Currently the job name corresponds to the disk the job belongs to. For
jobs which will not correspond to disks we'll need to track the name
separately.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 20
src/qemu/qemu_blockjob.h | 7 +--
Block jobs currently belong to disks only so we can look up the block
job data for them in the corresponding disks. This won't be the case
when using blockdev as certain jobs don't even correspond to a disk and
most of them can run on a part of the backing chain.
Add a global table of blockjobs
Add the job structure to the table when instantiating a new job and
remove it when it terminates/fails.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 31 ---
src/qemu/qemu_blockjob.h | 6 --
src/qemu/qemu_driver.c| 16
'cleanup' label was accessed only from a jump to 'error'. Consolidate
everyting into 'cleanup'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index
Struct qemuDomainDiskPrivate was holding multiple variables connected to
a disk block job. Consolidate them into a new struct qemuBlockJobData.
This will also allow simpler extensions to the block job mechanisms.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 36
This belongs to the new job management API which can manage also
non-block based jobs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
src/qemu/qemu_monitor_json.c | 27 +++
This belongs to the new job management API which can manage also
non-block based jobs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
src/qemu/qemu_monitor_json.c | 27 +++
Allow using the delayed dismiss of the job so that we can reap the state
even if libvirtd was not running when qemu emitted the job completion
event.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c| 2 +-
src/qemu/qemu_monitor.c | 9 +
src/qemu/qemu_monitor.h |
This belongs to the new job management API which can manage also
non-block based jobs.
The dismiss command is meant to remove a concluded job after we were
able to get the final status.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h
This new state is entered when qemu finished the job but libvirt does
not know whether it was successful or not.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 2 +-
src/qemu/qemu_blockjob.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 23 +
src/qemu/qemu_monitor.h | 49 ++
src/qemu/qemu_monitor_json.c | 86 ++
src/qemu/qemu_monitor_json.h | 6 ++
Extract the disk mirroring startup code from the loop into a separate
function to allow cleaner cleanup paths.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 85 +--
1 file changed, 55 insertions(+), 30 deletions(-)
diff --git
We can properly track the job type when starting the job so that we
don't have to infer it later.
This patch also adds an enum of block job types specific to qemu
(qemuBlockjobType) which mirrors the public block job types
(virDomainBlockJobType) but allows for other types to be added later
which
The job error can be safely accessed in the job structure, so we don't
need to propagate it through qemuBlockJobUpdateDisk.
Drop the propagation and refactor any caller that pased non-NULL error.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 12 ++--
Add a field tracking the current state of job so that it can be queried
later. Until now the job state e.g. that the job is _READY for
finalizing was tracked only for mirror jobs. Add tracking of state for
all jobs.
Similarly to 'qemuBlockJobType' this maps the existing states of the
blockjob
Now that the data is per-job, we don't really need to bother with
finishing the synchronous job handling if the job is already terminated.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_migration.c
And rename it in accordance with the change.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 20 ++--
src/qemu/qemu_blockjob.h | 6 +++---
src/qemu/qemu_driver.c| 4 ++--
src/qemu/qemu_migration.c | 2 +-
4 files changed, 16 insertions(+), 16 deletions(-)
On 12/12/18 9:04 AM, Michal Privoznik wrote:
> On 12/4/18 5:47 PM, John Ferlan wrote:
>> Similar to qemuxml2argv and storagevolxml2argv, add storagepoolxml2argvtest
>> in order to check the command line creation for the pool 'Start' commands.
>>
>> Only applicable for pool types with a
Add support for handling the event either synchronously or
asynchronously using the event thread.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 3 ++
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_driver.c | 23 ++
src/qemu/qemu_process.c | 66
With blockdev we'll need to use the JOB_STATUS_CHANGE so gate the old
events by the blockdev capability.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index
This new event is a superset of the BLOCK_JOB* events and also covers
jobs which don't bind to a VM disk.
In this patch the monitor part is implemented.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13 +
src/qemu/qemu_monitor.h | 9 +
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 41
src/qemu/qemu_blockjob.h | 3 +++
2 files changed, 44 insertions(+)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index ee545fc8de..020e7b3994 100644
---
Refresh the state of the jobs and process any events that might have
happened while libvirt was not running.
The job state processing requires some care to figure out if a job
needs to be bumped.t
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 57
Add the infrastructure to handle block job events in the -blockdev era.
Some complexity is required as qemu does not bother to notify whether
the job was concluded successfully or failed. Thus it's necessary to
re-query the monitor.
To minimize the possibility of stuck jobs save the state into
On 12/12/18 5:59 AM, Nikolay Shirokovskiy wrote:
>
>
> On 11.12.2018 19:41, John Ferlan wrote:
>>
>>
>> On 12/11/18 6:04 AM, Nikolay Shirokovskiy wrote:
>>>
>>>
>>> On 10.12.2018 19:58, John Ferlan wrote:
On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote:
> For qemu capable of
On 12/4/18 9:32 PM, John Ferlan wrote:
> If virSecretGetSecretString is using by secretLookupByUUID,
> then it's possible the found sec->usageType doesn't match the
> desired @secretUsageType. If this occurs for the encrypted
> volume creation processing and a subsequent pool refresh is
>
On Sat, Nov 17, 2018 at 1:17 PM Radoslaw Biernacki
wrote:
>
> ThunderX is Cavium SoC. This platform contain SRIOV NIC.
> Unlike other commonly known network devices it does not have VF functionality
> duplicated in its PF. PF is purely management device (on HW level).
>
> This creates several
On Fri, Nov 23, 2018 at 09:46:36PM +0300, Roman Bolshakov wrote:
> On Fri, Nov 23, 2018 at 06:16:46PM +0100, Jiri Denemark wrote:
> > On Fri, Nov 23, 2018 at 18:55:00 +0300, Roman Bolshakov wrote:
> > > On Fri, Nov 23, 2018 at 04:30:13PM +0100, Jiri Denemark wrote:
> > > > On Fri, Nov 23, 2018 at
On 12/12/18 9:04 AM, Michal Privoznik wrote:
> On 12/4/18 5:47 PM, John Ferlan wrote:
>> Similar to qemuxml2argv and storagevolxml2argv, let's create some
>> tests to ensure that the XML generates a consistent command line.
>>
>> Using the same list of pools as storagepoolxml2xmltest, start
On 12/12/18 7:58 AM, Michal Privoznik wrote:
> v2 of:
>
> https://www.redhat.com/archives/libvir-list/2018-November/msg00159.html
>
> diff to v1:
> - Patch 01/02 is completely new
> - Patch 02/02 has reworded commit message
>
> Michal Prívozník (2):
> qemuBuildMemoryBackendProps: Pass @priv
It's been deprecated since QEMU 3.0, and nobody complained so far, so
it is time to remove this option now.
Signed-off-by: Thomas Huth
---
docs/qdev-device-use.txt | 4
include/hw/boards.h | 1 -
qemu-deprecated.texi | 5
qemu-options.hx | 10
vl.c
The rewrite to support cgroup v2 missed this function. In cgroup v2
we have different files to track tasks.
We would fail to remove cgroup on non-systemd OSes if there is any
extra process assigned to guest cgroup because we would not kill any
process form the guest cgroup.
Signed-off-by: Pavel
While working on cgroup v2 devices and doing some extended testing I
figured out that there are two issues with the current code.
Pavel Hrdina (2):
vircgroup: introduce virCgroupKillRecursiveCB
vircgroupv2: fix virCgroupV2ValidateMachineGroup
src/util/vircgroup.c| 69
When libvirt is reconnecting to running domain that uses cgroup v2
the QEMU process reports cgroup for the emulator directory because the
main thread is in that cgroup. We need to remove the "/emulator" part
in order to match with the root cgroup directory name for that domain.
Signed-off-by:
On 11.12.2018 19:41, John Ferlan wrote:
>
>
> On 12/11/18 6:04 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 10.12.2018 19:58, John Ferlan wrote:
>>>
>>>
>>> On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote:
For qemu capable of setting l2-cache-size for qcow2 images
to INT64_MAX and
On Tue, Dec 11, 2018 at 06:51:56PM -0500, John Ferlan wrote:
>
>
> On 12/7/18 9:47 AM, Erik Skultety wrote:
> > As commit d8266ebe161 demonstrated, it's so easy to forget to add a
> > single capability which in turn can easily fool the test suite so that
> > tests expecting a failure can fail with
On Tue, Dec 11, 2018 at 06:48:26PM -0500, John Ferlan wrote:
>
>
> On 12/7/18 9:47 AM, Erik Skultety wrote:
> > Since the code was never run, this stupid mistake could have only been
> > spotted by an accident.
> >
> > Signed-off-by: Erik Skultety
> > ---
> > src/qemu/qemu_domain.c | 4 +---
> >
On 11.12.2018 17:33, John Ferlan wrote:
>
>
> On 12/11/18 2:34 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 11.12.2018 01:05, John Ferlan wrote:
>>>
>>> $SUBJ:
>>>
>>> 'storage sources'
>>>
>>> On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote:
Every time we call all domain stats for
On Tue, Dec 11, 2018 at 06:50:19PM -0500, John Ferlan wrote:
>
>
> On 12/7/18 9:47 AM, Erik Skultety wrote:
> > One of the usages of the device iterator is to run config validation.
> > That's a problem for graphics devices, because they don't have any @info
> > data (graphics shouldn't have been
On 11.12.2018 19:34, John Ferlan wrote:
>
>
> On 12/11/18 5:22 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 10.12.2018 19:56, John Ferlan wrote:
>>>
>>> On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote:
Signed-off-by: Nikolay Shirokovskiy
---
docs/formatdomain.html.in
On Tue, Dec 11, 2018 at 06:54:31PM -0500, John Ferlan wrote:
>
>
> On 12/7/18 9:47 AM, Erik Skultety wrote:
> > The validation code for graphics has been in place for a while, but
> > because it is only executed from the device iterator, that validation
> > code was never truly run. The
On 12/12/18 3:29 AM, Erik Skultety wrote:
> On Tue, Dec 11, 2018 at 06:50:19PM -0500, John Ferlan wrote:
>>
>>
>> On 12/7/18 9:47 AM, Erik Skultety wrote:
>>> One of the usages of the device iterator is to run config validation.
>>> That's a problem for graphics devices, because they don't have
On 12/4/18 5:47 PM, John Ferlan wrote:
> Add the logical storage pool startup validation (xml2argv) tests.
>
> Signed-off-by: John Ferlan
> ---
> src/storage/storage_backend_logical.c | 6 +-
> src/storage/storage_util.c | 11 +++
>
On 12/4/18 5:47 PM, John Ferlan wrote:
> Similar to qemuxml2argv and storagevolxml2argv, let's create some
> tests to ensure that the XML generates a consistent command line.
>
> Using the same list of pools as storagepoolxml2xmltest, start with
> the file system tests (fs, netfs, netfs-cifs,
On 12/4/18 5:47 PM, John Ferlan wrote:
> Similar to qemuxml2argv and storagevolxml2argv, add storagepoolxml2argvtest
> in order to check the command line creation for the pool 'Start' commands.
>
> Only applicable for pool types with a "@startPool" function - that is disk,
> fs, iscsi, logical,
It's important to keep XATTRs untouched (well, in the same state
they were in when entering the function). Otherwise our
refcounting would be messed up.
Signed-off-by: Michal Privoznik
Reviewed-by: Daniel P. Berrangé
---
src/security/security_dac.c | 20 +++-
1 file changed, 19
v3 of:
https://www.redhat.com/archives/libvir-list/2018-November/msg01070.html
diff to v2:
- dropped 01/18 from v2
- Introduced a test
- Couple of minor adjustments as suggested in review of v2
Michal Prívozník (18):
util: Introduce xattr getter/setter/remover
security: Include
This file implements wrappers over XATTR getter/setter. It
ensures the proper XATTR namespace is used.
Signed-off-by: Michal Privoznik
---
src/security/Makefile.inc.am | 2 +
src/security/security_util.c | 256 +++
src/security/security_util.h | 32 +
3
add more configure options for NVDIMM
Signed-off-by: Luyao Zhong
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 5bdbd34..0112c91 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -38,6 +38,15 @@
would normally
-object memory-backend-file[,align=][,pmem=]
Signed-off-by: Luyao Zhong
---
src/qemu/qemu_capabilities.c | 8 +++-
src/qemu/qemu_capabilities.h | 4
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
1.alignsize
The 'alignsize' option allows users to specify the proper alignment.
2.pmem
The 'pmem' option allows users to specify whether the backend storage of
memory-backend-file is a real persistent memory.
3.unarmed
The 'unarmed' option allows users to mark vNVDIMM read-only.
These options
Hi libvirt experts,
This is the RFC v3 for updating NVDIMM support in libvirt.
There are some gaps between qemu and libvirt, libvirt has not
supported several config options about NVDIMM memory while
qemu is ready now, including 'align', 'pmem', 'unarmed'.
I reworded and recoded my patches
v2 of:
https://www.redhat.com/archives/libvir-list/2018-November/msg00159.html
diff to v1:
- Patch 01/02 is completely new
- Patch 02/02 has reworded commit message
Michal Prívozník (2):
qemuBuildMemoryBackendProps: Pass @priv instead of its individual
members
qemu: Don't use
On 12/7/18 6:27 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1624336
>
> Details are in patch2, but essentially the issue is the check
> for whether cold/hot plug of memory is supported occurs during
> qemuDomainDefValidateMemoryHotplug; however, that is called
> after
On 12/12/18 3:39 AM, Nikolay Shirokovskiy wrote:
>
>
> On 11.12.2018 19:34, John Ferlan wrote:
>>
>>
>> On 12/11/18 5:22 AM, Nikolay Shirokovskiy wrote:
>>>
>>>
>>> On 10.12.2018 19:56, John Ferlan wrote:
On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay
We are setting label on kernel, initrd, dtb and slic_table files.
But we never restored it.
Signed-off-by: Michal Privoznik
Reviewed-by: Daniel P. Berrangé
---
src/security/security_dac.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/security/security_dac.c
It helps whe trying to match calls with virSecuritySELinuxSetAllLabel
if the order in which devices are set/restored is the same in
both functions.
Signed-off-by: Michal Privoznik
Reviewed-by: Daniel P. Berrangé
---
src/security/security_selinux.c | 14 +++---
1 file changed, 7
It helps whe trying to match calls with virSecurityDACSetAllLabel
if the order in which devices are set/restored is the same in
both functions.
Signed-off-by: Michal Privoznik
Reviewed-by: Daniel P. Berrangé
---
src/security/security_dac.c | 36 ++--
1 file
It is going to be important to know if the current transaction we
are running is a restore operation or set label operation so that
we know whether to call virSecurityGetRememberedLabel() or
virSecuritySetRememberedLabel(). That is, whether we are in a
restore and therefore have to fetch the
Signed-off-by: Michal Privoznik
---
src/libvirt_private.syms | 3 +
src/util/virfile.c | 121 +++
src/util/virfile.h | 11
3 files changed, 135 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
This test checks if security label remembering works correctly.
It uses qemuSecurity* APIs to do that. And some mocking (even
though it's not real mocking as we are used to from other tests
like virpcitest). So far, only DAC driver is tested.
Signed-off-by: Michal Privoznik
---
cfg.mk
When iterating over list of paths/disk sources to relabel it may
happen that the process fails at some point. In that case, for
the sake of keeping seclabel refcount (stored in XATTRs) in sync
with reality we have to perform rollback. However, if that fails
too the only thing we can do is warn
We are setting label on kernel, initrd, dtb and slic_table files.
But we never restored it.
Signed-off-by: Michal Privoznik
Reviewed-by: Daniel P. Berrangé
---
src/security/security_selinux.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/security/security_selinux.c
When iterating over list of paths/disk sources to relabel it may
happen that the process fails at some point. In that case, for
the sake of keeping seclabel refcount (stored in XATTRs) in sync
with reality we have to perform rollback. However, if that fails
too the only thing we can do is warn
Because the implementation that will be used for label
remembering/recall is not atomic we have to give callers a chance
to enable or disable it. That is, enable it if and only if
metadata locking is enabled. Otherwise the feature MUST be turned
off.
Signed-off-by: Michal Privoznik
Reviewed-by:
Our code is not bug free. The refcounting I introduced will
almost certainly not work in some use cases. Provide a script
that will remove all the XATTRs set by libvirt so that it can
start cleanly.
Signed-off-by: Michal Privoznik
---
tools/Makefile.am | 1 +
1 - 100 of 109 matches
Mail list logo
