Since we're setting the zone anyway, it will be useful to allow
setting a different (custom) zone for each network. This will be done
by adding a "zone" attribute to the "bridge" element, e.g.:
...
...
If a zone is specified in the config and it can't be honored, this
will be an error.
From: Laine Stump
In the past (when both libvirt and firewalld used iptables), if either
libvirt's rules *OR* firewalld's rules accepted a packet, it would be
accepted. This was because libvirt and firewalld rules were processed
by the same kernel hook.
But now firewalld can use nftables for
Since I'm going to be adding at least one more firewalld-specific
function, this seems like a good time to separate the code that's
unique to firewalld from the more-generic "firewall" file.
Signed-off-by: Laine Stump
---
include/libvirt/virterror.h | 1 +
src/libvirt_private.syms| 3 +
Sets the firewalld zone of the given interface. This function assumes
that you've already called virFirewallDIsActive(), and relies on
virDBusCallMethod's standard error reporting to log any errors.
Signed-off-by: Laine Stump
---
src/libvirt_private.syms | 1 +
src/util/virfirewalld.c | 23
The detailed explanation of this is in Patch 4/5. Basically, when
firewalld enables their new nftables backend, libvirt virtual networks
lose all ability to forward packets from guests out to the physical
network, and can only communicate with the host itself as much as
firewalld's "public" zone
A couple places in the docs didn't get updated when the forward mode
"open" was added.
Signed-off-by: Laine Stump
---
docs/formatnetwork.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index
networkMigrateStateFiles was added nearly 5 years ago when the network
state directory was moved from /var/lib/libvirt to /var/run/libvirt
just prior to libvirt-1.2.4). It was only required to maintain proper
state information for networks that were active during an upgrade that
didn't involve
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Subject: [libvirt] [PATCH] network: remove stale function
Message-id: 20190110021955.11360-1-la...@laine.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will
On 12/7/18 11:21 AM, Daniel P. Berrangé wrote:
Some of the query callbacks want to know the firewall layer that was
being used for triggering the query to avoid duplicating that data.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
---
On 12/7/18 11:21 AM, Daniel P. Berrangé wrote:
Allow the platform driver impls to run logic before and after the
firewall reload process.
Signed-off-by: Daniel P. Berrangé
---
src/network/bridge_driver.c | 13 -
src/network/bridge_driver_linux.c| 11 +++
> -Original Messages-
> From: "Wodkowski, PawelX"
> Sent Time: 2019-01-10 00:19:48 (Thursday)
> To: "stefa...@gmail.com" , "s...@lists.01.org"
>
> Cc: "libvir-list@redhat.com" , "xieyon...@baidu.com"
> , "qemu-de...@nongnu.org" ,
> "lili...@baidu.com"
> Subject: Re: [SPDK]
networkMigrateStateFiles was added nearly 5 years ago when the network
state directory was moved from /var/lib/libvirt to /var/run/libvirt
just prior to libvirt-1.2.4). It was only required to maintain proper
state information for networks that were active during an upgrade that
didn't involve
On 1/9/19 3:53 PM, Daniel Veillard wrote:
Happy New Year everybody,
as planned we should release 5.0.0 around Jan 15. This means that
the best to meet that deadline would be to enter freeze tomorrow Thur,
then have an RC2 over the w.e. and then if all goes well we can roll
out the
On Thu, Jan 03, 2019 at 01:41:56PM -0600, Eric Blake wrote:
> Since v1: fix the gnulib bug I accidentally introduced, then
> copy the gist of Roman's gnulib changes to also apply to our
> cfg.mk syntax checks.
>
> Eric Blake (3):
> maint: update gnulib for syntax-check on BSD
> maint: prefer
On Wed, 2019-01-09 at 12:53 +, Daniel P. Berrangé wrote:
> On Wed, Jan 09, 2019 at 01:33:44PM +0100, Andrea Bolognani wrote:
> > The way I see it, our examples are supposed to illustrate how to use
> > libvirt itself, not how to write C code that is portable to a
> > multitude of platforms:
On Wed, Jan 09, 2019 at 03:46:19PM +0100, Andrea Bolognani wrote:
> On Wed, 2019-01-09 at 12:53 +, Daniel P. Berrangé wrote:
> > On Wed, Jan 09, 2019 at 01:33:44PM +0100, Andrea Bolognani wrote:
> > > The way I see it, our examples are supposed to illustrate how to use
> > > libvirt itself,
ping
On Fri, Dec 07, 2018 at 04:21:31PM +, Daniel P. Berrangé wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00018.html
>
> The virtual networks in NAT mode are supposed to only allow outbound
> network access for guests. Unfortunately due to ordering of the
On Wed, Jan 09, 2019 at 21:23:25 +0800, wuzhouhui wrote:
> > -Original Messages-
> > From: "Stefan Hajnoczi"
> > Sent Time: 2019-01-09 20:42:58 (Wednesday)
> > To: wuzhouhui
> > Cc: qemu-de...@nongnu.org, xieyon...@baidu.com, lili...@baidu.com,
> > libvir-list@redhat.com,
On Wed, Jan 09, 2019 at 01:33:44PM +0100, Andrea Bolognani wrote:
> On Tue, 2019-01-08 at 13:56 -0600, Eric Blake wrote:
> > My recent patch to make all of the examples work independently of
> > gnulib worked fine on Linux, but failed on mingw:
> >
> -Original Messages-
> From: "Stefan Hajnoczi"
> Sent Time: 2019-01-09 20:42:58 (Wednesday)
> To: wuzhouhui
> Cc: qemu-de...@nongnu.org, xieyon...@baidu.com, lili...@baidu.com,
> libvir-list@redhat.com, s...@lists.01.org
> Subject: Re: [Qemu-devel] Qemu migration with vhost-user-blk on
On Wed, Jan 09, 2019 at 10:24:40AM +, Daniel P. Berrangé wrote:
On Fri, Jan 04, 2019 at 04:22:42PM +0100, Ján Tomko wrote:
Since gnulib commit 6954995d unistd.h is included via stdlib.h
on BSD systems, which requires config.h to be included first.
Add config.h to the files that use it.
On 12/24/18 11:15 AM, Yuval Shaia wrote:
> This event is emitted on the monitor when a GID table in pvrdma device
> is modified and the change needs to be propagate to the backend RDMA
> device's GID table.
>
> The control over the RDMA device's GID table is done by updating the
> device's
>
> ACKed and pushed. Congratulations on your first libvirt contribution!
>
> Michal
Thanks!
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jan 09, 2019 at 06:23:42PM +0800, wuzhouhui wrote:
> Hi everyone,
>
> I'm working qemu with vhost target (e.g. spdk), and I attempt to migrate VM
> with
> 2 local storages. One local storage is a regular file, e.g. /tmp/c74.qcow2,
> and
> the other is a malloc bdev that spdk created.
In the previous commit we are using uint64_t for storing subnet
prefix and interface id that qemu reports in
RDMA_GID_STATUS_CHANGED event. We also report them in some debug
messages. This poses a problem because uint64_t can be UL or ULL
depending on the host architecture and hence we wouldn't
On Tue, 2019-01-08 at 13:56 -0600, Eric Blake wrote:
> My recent patch to make all of the examples work independently of
> gnulib worked fine on Linux, but failed on mingw:
> https://travis-ci.org/libvirt/libvirt/jobs/476898635
>
> The whole point of gnulib is to work around portability pitfalls
On 1/9/19 7:33 AM, Andrea Bolognani wrote:
> On Tue, 2019-01-08 at 13:56 -0600, Eric Blake wrote:
>> My recent patch to make all of the examples work independently of
>> gnulib worked fine on Linux, but failed on mingw:
>> https://travis-ci.org/libvirt/libvirt/jobs/476898635
>>
>> The whole
On Fri, Jan 04, 2019 at 04:22:42PM +0100, Ján Tomko wrote:
> Since gnulib commit 6954995d unistd.h is included via stdlib.h
> on BSD systems, which requires config.h to be included first.
>
> Add config.h to the files that use it.
This is not desirable. The examples/ programs are supposed to
be
Three lines are a bit off there.
Signed-off-by: Michal Privoznik
---
src/qemu/Makefile.inc.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am
index 2afa67f195..0b2bc074c0 100644
--- a/src/qemu/Makefile.inc.am
+++
On 1/8/19 6:52 PM, John Ferlan wrote:
> Modify the storagepool.rng to allow for the usage of a different
> XML namespace to parse the netfs_mount_opts to be included with
> the storage source.
>
> Modify the storagepoolxml2xmltest to utilize a properly modified
> XML file to parse and format the
On 1/8/19 6:52 PM, John Ferlan wrote:
> Allow for adjustment of RBD configuration options via Storage
> Pool XML Namespace adjustments.
>
> Based off original patch/concept:
>
> https://www.redhat.com/archives/libvir-list/2014-May/msg00940.html
>
> Signed-off-by: John Ferlan
> ---
>
On 1/8/19 6:52 PM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
>
> Kept the subject the same, but the concept has been adjusted to follow
> issues pointed out by jtomko vis-a-vis allowing arbitrary options via XML.
> This series adds both the
On 1/8/19 6:52 PM, John Ferlan wrote:
> Introduce the virStoragePoolNetFSMountOptionsDef to be used to
> manage the NFS Storage Pool XML Namespace for mount options.
>
> Using a new virStorageBackendNamespaceInit function, set the
> virStoragePoolXMLNamespace into the _virStoragePoolOptions when
On Tue, Jan 08, 2019 at 12:52:21PM -0500, John Ferlan wrote:
> Introduce the infrastructure necessary to manage a Storage Pool XML
> Namespace. The general concept is similar to virDomainXMLNamespace,
> except that for Storage Pools the storage backend specific details
> can be stored within the
On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
> On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
>> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
>>
>> Kept the subject the same, but the concept has been adjusted to follow
>> issues pointed out by jtomko
On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
>
> Kept the subject the same, but the concept has been adjusted to follow
> issues pointed out by jtomko vis-a-vis allowing arbitrary options via XML.
> This
On Wed, 2019-01-09 at 14:54 +, Daniel P. Berrangé wrote:
[...]
> I don't really agree. There's no need to clone the git repo to use
> the examples. I've given people direct links to the gitweb viewer
> for example programs and just told them to build using the $CC
> arg above. Sure we could
On Wed, 2019-01-09 at 21:23 +0800, wuzhouhui wrote:
> > -Original Messages-
> > From: "Stefan Hajnoczi"
> > Sent Time: 2019-01-09 20:42:58 (Wednesday)
> > To: wuzhouhui
> > Cc: qemu-de...@nongnu.org, xieyon...@baidu.com, lili...@baidu.com,
> > libvir-list@redhat.com, s...@lists.01.org
>
On Wed, Jan 09, 2019 at 05:23:39PM +0100, Michal Privoznik wrote:
> Three lines are a bit off there.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/Makefile.inc.am | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/Makefile.inc.am
On Wed, Jan 09, 2019 at 12:41:27PM -0500, John Ferlan wrote:
>
>
> On 1/9/19 12:06 PM, Daniel P. Berrangé wrote:
> > On Tue, Jan 08, 2019 at 12:52:21PM -0500, John Ferlan wrote:
> >> Introduce the infrastructure necessary to manage a Storage Pool XML
> >> Namespace. The general concept is
On 1/9/19 11:55 AM, Michal Privoznik wrote:
[...]
>
>
> ACK
>
Thanks for the review... although it seems I'll have to consider a 3rd
approach as a result of Daniel's comments. Nothing is ever easy.
> My only worry is that we don't validate the options in any way. They are
> basically a
On 1/9/19 12:40 PM, Daniel P. Berrangé wrote:
> On Wed, Jan 09, 2019 at 12:31:02PM -0500, John Ferlan wrote:
>>
>>
>> On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
>>> On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
v1:
Avoid building the same path several times.
Signed-off-by: Andrea Bolognani
---
src/remote/Makefile.inc.am | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index d9f559dce5..0633b05768 100644
---
Avoid building the same path several times.
Signed-off-by: Andrea Bolognani
---
src/remote/Makefile.inc.am | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 04a2ec8cc0..d9f559dce5 100644
---
On Wed, Jan 09, 2019 at 12:31:02PM -0500, John Ferlan wrote:
>
>
> On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
> > On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
> >> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
> >>
> >> Kept the subject the same,
This same operation needs to be done in multiple places, so move the
inline code into a separate function.
Signed-off-by: Laine Stump
---
src/util/virnetdevip.c | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/src/util/virnetdevip.c
This is about the same number of code lines, but is simpler, and more
consistent with what will be added to check another attribute in a
coming patch.
As a side effect, it
Resolves: https://bugzilla.redhat.com/1583131
Signed-off-by: Laine Stump
---
src/util/virnetdevip.c | 53
These patches fix the crash described in:
https://bugzilla.redhat.com/1583131
They also fix a deficiency revealed by that crash - we weren't
checking the accept_ra value of interfaces in the "nexthop" elements
of multipath RA routes.
Laine Stump (4):
util: remove const specifier from
When checking the setting of accept_ra, we have assumed that all
routes have a single nexthop, so the interface of the route would be
in the RTA_OIF attribute of the netlink RTM_NEWROUTE message. But
multipath routes don't have an RTA_OIF; instead, they have an
RTA_MULTIPATH attribute, which is an
This is problematic if a callback function wants to send the nlmsghdr
to a library function that has no "const" in its prototype
(e.g. nlmsg_find_attr())
Signed-off-by: Laine Stump
---
src/util/virnetdevip.c | 2 +-
src/util/virnetlink.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Instead of defining targets conditionally and depending on
them unconditionally, define a couple of variables and
conditionally add targets to them.
In addition to removing a bunch of useless code, this has
the nice effect of no longer requiring the main Makefile.am
to have any knowledge about
These files need to be installed on the system for apparmor
support to work, so they don't belong with examples.
Signed-off-by: Andrea Bolognani
---
examples/Makefile.am | 40 ---
src/security/Makefile.inc.am | 40 +++
Vim won't recognize them, and thus not enable niceties
such as syntax highlighting, otherwise.
Signed-off-by: Andrea Bolognani
---
src/access/Makefile.inc.am | 2 ++
src/admin/Makefile.inc.am | 2 ++
src/bhyve/Makefile.inc.am | 2 ++
src/conf/Makefile.inc.am| 2 ++
Came for 6/7, stayed for the yak shaving.
Andrea Bolognani (7):
remote: Move polkitdir definition
remote: Define polkit{actions,rules}dir
remote: Define sysctldir
remote: Define sasldir
src: Simplify installing/uninstalling data
apparmor: Move static data out of examples/
src: Add
No need to have two conditional blocks.
Signed-off-by: Andrea Bolognani
---
src/remote/Makefile.inc.am | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index d188c4e348..04a2ec8cc0 100644
---
Avoid building the same path several times.
Signed-off-by: Andrea Bolognani
---
src/remote/Makefile.inc.am | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 0633b05768..5ef082c595 100644
---
On Wed, Jan 09, 2019 at 01:26:19PM -0500, John Ferlan wrote:
>
>
> On 1/9/19 12:40 PM, Daniel P. Berrangé wrote:
> > On Wed, Jan 09, 2019 at 12:31:02PM -0500, John Ferlan wrote:
> >>
> >>
> >> On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
> >>> On Tue, Jan 08, 2019 at 12:52:20PM -0500, John
On Wed, Dec 12, 2018 at 12:23 PM dann frazier
wrote:
>
> On Sat, Nov 17, 2018 at 1:17 PM Radoslaw Biernacki
> wrote:
> >
> > ThunderX is Cavium SoC. This platform contain SRIOV NIC.
> > Unlike other commonly known network devices it does not have VF
> > functionality
> > duplicated in its PF.
On 1/9/19 12:06 PM, Daniel P. Berrangé wrote:
> On Tue, Jan 08, 2019 at 12:52:21PM -0500, John Ferlan wrote:
>> Introduce the infrastructure necessary to manage a Storage Pool XML
>> Namespace. The general concept is similar to virDomainXMLNamespace,
>> except that for Storage Pools the storage
Happy New Year everybody,
as planned we should release 5.0.0 around Jan 15. This means that
the best to meet that deadline would be to enter freeze tomorrow Thur,
then have an RC2 over the w.e. and then if all goes well we can roll
out the release next Tuesday.
If there is no issue with
[...]
>>> For the general nosuid, nodev flags, I think we can do something like we
>>> have for the element in the domain XML.
>>>
>>
>> So that means to me that every option currently possible in mount would
>> need to be listed. Doesn't that feel excessive? Not that mount changes
>> that
61 matches
Mail list logo
