Re: [libvirt] [PATCH] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-07 Thread Erik Skultety
On Tue, Aug 06, 2019 at 06:20:07PM +0200, Ilias Stamatis wrote: > Until now, testDomainGetTime would always return the same fixed value > everytime it was called. By using domain-private data we can make this > API return the values previously set with testDomainSetTime, or use the > same old

Re: [libvirt] [PATCH] test_driver: implement virDomainReset

2019-08-07 Thread Erik Skultety
On Tue, Aug 06, 2019 at 05:56:23PM +0200, Ilias Stamatis wrote: > The qemu and vz implementations don't emit any signals when this API is > called, so we can do the same here for now and succeed by doing nothing. > > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety -- libvir-list

[libvirt] [PATCH v2 05/15] tools: Separate storage volume related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to storage volumes (e.g. they complete various storage volume aspects) into virsh-completer-volume.c Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 07/15] tools: Separate network related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to networks (e.g. they complete various network aspects) into virsh-completer-network.c Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 06/15] tools: Separate interface related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to interfaces (e.g. they complete various interface aspects) into virsh-completer-interface.c Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 04/15] tools: Separate storage pool related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to storage pools (e.g. they complete various storage pool aspects) into virsh-completer-pool.c. Signed-off-by: Michal Privoznik --- tools/Makefile.am| 1 +

[libvirt] [PATCH v2 03/15] tools: Separate domain related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to domains (e.g. they complete various domain aspects) into virsh-completer-domain.c. Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 02/15] tools: Expose virshCommaStringListComplete()

2019-08-07 Thread Michal Privoznik
In next commits the virsh-completer.c is going to be split into smaller files. Expose virshCommaStringListComplete() so that it can still be used from those new files. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 2 +- tools/virsh-completer.h | 3 +++ 2 files changed, 4

[libvirt] [PATCH v2 11/15] tools: Separate snapshot related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to snapshot (e.g. they complete various snapshot aspects) into virsh-completer-snapshot.c Signed-off-by: Michal Privoznik --- tools/Makefile.am| 1 +

[libvirt] [PATCH v2 10/15] tools: Separate secret related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to secret (e.g. they complete various secret aspects) into virsh-completer-secret.c Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 09/15] tools: Separate nwfilter related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to nwfilter (e.g. they complete various nwfilter aspects) into virsh-completer-nwfilter.c Signed-off-by: Michal Privoznik --- tools/Makefile.am| 1 +

[libvirt] [PATCH v2 00/15] Split and enhancement of virsh completer

2019-08-07 Thread Michal Privoznik
v2 of: https://www.redhat.com/archives/libvir-list/2019-July/msg01225.html diff to v1: - Rebase and adapt to new checkpoint completer Michal Prívozník (15): tools: s/Nodedev/NodeDevice/ tools: Expose virshCommaStringListComplete() tools: Separate domain related completers into a file

[libvirt] [PATCH v2 12/15] tools: Separate host related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to host (e.g. they complete various host aspects) into virsh-completer-host.c Signed-off-by: Michal Privoznik --- tools/Makefile.am| 1 + tools/virsh-completer-host.c | 148

[libvirt] [PATCH v2 15/15] virsh: Introduce virshPoolTypeCompleter

2019-08-07 Thread Michal Privoznik
This completer can be used to complete pool types. Signed-off-by: Michal Privoznik --- tools/virsh-completer-pool.c | 27 +++ tools/virsh-completer-pool.h | 4 tools/virsh-pool.c | 1 + 3 files changed, 32 insertions(+) diff --git

[libvirt] [PATCH v2 13/15] tools: Separate checkpoint related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to host (e.g. they complete various checkpoint aspects) into virsh-completer-checkpoint.c Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 08/15] tools: Separate nodedev related completers into a file

2019-08-07 Thread Michal Privoznik
Mixing all completers in one file does not support maintainability. Separate those completers which relate to nodedev (e.g. they complete various nodedev aspects) into virsh-completer-nodedev.c Signed-off-by: Michal Privoznik --- tools/Makefile.am | 1 +

[libvirt] [PATCH v2 01/15] tools: s/Nodedev/NodeDevice/

2019-08-07 Thread Michal Privoznik
The proper name is [vir|virsh]NodeDevice* and not Nodedev. Fortunately, there are only handful of offenders. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 14 +++--- tools/virsh-completer.h | 12 ++-- tools/virsh-nodedev.c | 16

[libvirt] [PATCH v2 14/15] virsh-completer: Drop needless #include

2019-08-07 Thread Michal Privoznik
Now that there is no code in virsh-completer.c it doesn't make much sense to keep those #include-s around. Delete them. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 13 - tools/virsh-completer.h | 2 -- 2 files changed, 15 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-07 Thread Ilias Stamatis
On Sun, Aug 4, 2019 at 6:32 PM Erik Skultety wrote: > > On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > > > I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults > > in order to leave the function simpler. I think

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-07 Thread Eric Blake
On 7/31/19 2:30 PM, Eric Blake wrote: > Commit fed58d83 was a hack to fix a mingw build failure due to header > inclusion order resulting in a clash over the use of DATADIR, by > repeating a trick made several other times in the past of tweaking > inclusion order until it goes away. Better is to

[libvirt] [PATCH v2 1/2] test_driver: make testDomainGetTime read time from vm-private data

2019-08-07 Thread Ilias Stamatis
Until now, testDomainGetTime would always return the same fixed values everytime it was called. By using domain-private data we can make this API return the values previously set with testDomainSetTime, or use the same old fixed values in case testDomainSetTime hasn't been called at all.

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetTime

2019-08-07 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 3e2cd3a9a4..6f18baa265 100755 --- a/src/test/test_driver.c +++

[libvirt] [PATCH] src: security: Replace bitwise OR with logical OR

2019-08-07 Thread Erik Skultety
Typo introduced by commit d73f3f58360. https://bugzilla.redhat.com/show_bug.cgi?id=1738483 Signed-off-by: Erik Skultety --- Pushed as trivial. src/security/security_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_util.c

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-07 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: make testDomainGetTime read time from vm-private data test_driver: implement virDomainSetTime src/test/test_driver.c | 43 -- 1 file changed, 41 insertions(+), 2 deletions(-) -- 2.22.0 -- libvir-list mailing list

[libvirt] [PATCH] tools: console: Relax stream EOF handling

2019-08-07 Thread Roman Bolshakov
An attempt to poweroff a VM from inside triggers the error for existing session of virsh console and it returns with non-zero exit code: error: internal error: console stream EOF The message and status code are misleading because there's no real error. Fixes: 29f2b5248c6 ("tools: console: pass

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-08-07 Thread Ilias Stamatis
On Sun, Aug 4, 2019 at 5:32 PM Erik Skultety wrote: > > On Sun, Aug 04, 2019 at 03:46:03PM +0200, Ilias Stamatis wrote: > > On Sun, Aug 4, 2019 at 11:12 AM Erik Skultety wrote: > > > > > > On Sat, Jul 27, 2019 at 05:04:37PM +0200, Ilias Stamatis wrote: > > > > Signed-off-by: Ilias Stamatis > >

Re: [libvirt] [PATCH 0/7] add virDomainGetGuestInfo()

2019-08-07 Thread Tomáš Golembiovský
On Thu, Aug 01, 2019 at 08:37:03AM -0500, Jonathon Jongsma wrote: > This series adds several bits of guest information provided by a new API > function virDomainGetGuestInfo(). There is an implementation for qemu using > the > guest agent. In particular, it adds information about logged-in users,

Re: [libvirt] [PATCH 00/17] Refactor virt-login-shell and nss module

2019-08-07 Thread Michal Privoznik
On 8/1/19 5:00 PM, Daniel P. Berrangé wrote: > > Very nice cleanup, which also makes NSS library smaller in size (I mean those .so.2 files). I've found some mem leaks and mis-alignments, though. Please squash this into respective patches: diff --git a/tools/nss/libvirt_nss.c

Re: [libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-07 Thread Erik Skultety
On Wed, Aug 07, 2019 at 12:22:54PM +0200, Ilias Stamatis wrote: > Ilias Stamatis (2): > test_driver: make testDomainGetTime read time from vm-private data > test_driver: implement virDomainSetTime > > src/test/test_driver.c | 43 -- > 1 file changed, 41

[libvirt] [PATCH 1/2] qemu: Fix possible NULL deref in qemuDomainGetResctrlMonData

2019-08-07 Thread John Ferlan
If virQEMUDriverGetCapabilities returns NULL, then a subsequent deref of @caps would cause an error, so we just return failure. Found by Coverity Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 0/2] Couple of Coverity fixes

2019-08-07 Thread John Ferlan
Both from recent changes, it was just as easy for me to post the patches as write the annoying email that someone else needs to generate them ;-). John Ferlan (2): qemu: Fix possible NULL deref in qemuDomainGetResctrlMonData tests: Fix memory leak in mymain src/qemu/qemu_driver.c | 3 ++-

[libvirt] [PATCH 2/2] tests: Fix memory leak in mymain

2019-08-07 Thread John Ferlan
Commit d2899a648 added a new exit path, but didn't free @fakerootdir. Let's just use VIR_AUTOFREE instead to make life easier. Found by Coverity Signed-off-by: John Ferlan --- tests/virhostdevtest.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/virhostdevtest.c

[libvirt] [PATCH 0/2] test_driver: implement the remaining ManagedSave APIs

2019-08-07 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainManagedSaveGetXMLDesc test_driver: implement virDomainManagedSaveDefineXML src/test/test_driver.c | 66 ++ 1 file changed, 66 insertions(+) -- 2.22.0 -- libvir-list mailing list

[libvirt] [dockerfiles PATCH v3 2/3] refresh: Add libosinfo project

2019-08-07 Thread Fabiano Fidêncio
libosinfo Dockerfile will consist on a single container that will be able to build & test libosinfo, osinfo-db-tools, and osinfo-db. And from those "subprojects", only libosinfo and osinfo-db-tools are subject for mingw builds. Signed-off-by: Fabiano Fidêncio --- refresh | 5 + 1 file

[libvirt] [dockerfiles PATCH v3 1/3] refresh: Learn how to deal with the project's name

2019-08-07 Thread Fabiano Fidêncio
Let's change the refresh script in order to take into consideration Dockerfiles containing the project's name. This is needed in order to add different projects to libvirt-dockerfiles. An important change that deservers a mention here is that the PROJECTS variable, part of Dockerfile class, has

[libvirt] [dockerfiles PATCH v3 0/3] Add libosinfo Dockerfiles

2019-08-07 Thread Fabiano Fidêncio
This patch series aims to add libosinfo Dockerfiles to this project, so those containers can be used by libosinfo projects' gitlab CI. Please, take a look at each patch for more context of what has been done. Changes since v2: https://www.redhat.com/archives/libvir-list/2019-July/msg01934.html -

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-07 Thread Michal Privoznik
On 7/31/19 9:30 PM, Eric Blake wrote: Commit fed58d83 was a hack to fix a mingw build failure due to header inclusion order resulting in a clash over the use of DATADIR, by repeating a trick made several other times in the past of tweaking inclusion order until it goes away. Better is to revert

[libvirt] [dockerfiles PATCH v3 3/3] Add Dockerfiles for libosinfo project

2019-08-07 Thread Fabiano Fidêncio
The corresponding libvirt-jenkins-ci commit is 81eabc6f888a3. Signed-off-by: Fabiano Fidêncio --- buildenv-libosinfo-centos-7.Dockerfile| 43 + ...bosinfo-debian-10-cross-aarch64.Dockerfile | 64 +++ ...ibosinfo-debian-10-cross-armv6l.Dockerfile | 64

Re: [libvirt] [PATCH 0/2] Couple of Coverity fixes

2019-08-07 Thread Michal Privoznik
On 8/7/19 4:45 PM, John Ferlan wrote: Both from recent changes, it was just as easy for me to post the patches as write the annoying email that someone else needs to generate them ;-). John Ferlan (2): qemu: Fix possible NULL deref in qemuDomainGetResctrlMonData tests: Fix memory leak in

Re: [libvirt] [PATCH 0/7] add virDomainGetGuestInfo()

2019-08-07 Thread Jonathon Jongsma
On Wed, 2019-08-07 at 12:39 +0200, Tomáš Golembiovský wrote: > On Thu, Aug 01, 2019 at 08:37:03AM -0500, Jonathon Jongsma wrote: > > This series adds several bits of guest information provided by a > > new API > > function virDomainGetGuestInfo(). There is an implementation for > > qemu using the

[libvirt] [PATCH 2/2] test_driver: implement virDomainManagedSaveDefineXML

2019-08-07 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8715d6c0d6..360bdef373 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@

[libvirt] [PATCH 1/2] test_driver: implement virDomainManagedSaveGetXMLDesc

2019-08-07 Thread Ilias Stamatis
The managedSave APIs according to the documentation are supposed to operate on a disk file. However, this might not be appropriate in the case of the test driver since: * It's better if the test driver keeps all its state in memory only and doesn't affect the host in any way. * The test driver,

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-07 Thread Eric Blake
On 8/7/19 9:59 AM, Michal Privoznik wrote: > On 7/31/19 9:30 PM, Eric Blake wrote: >> Commit fed58d83 was a hack to fix a mingw build failure due to header >> inclusion order resulting in a clash over the use of DATADIR, by >> repeating a trick made several other times in the past of tweaking >>