Re: [libvirt] [PATCH v2 03/24] build: force a UTF-8 locale for python

2019-09-11 Thread Eric Blake
On 9/11/19 11:23 AM, Daniel P. Berrangé wrote: > Python3 versions less than 3.7 have very unhelpful handling > of the C locale where they assume data is 7-bit only. This > violates POSIX which requires the C locale to be 8-bit clean. > Python3 >= 3.7 now assumes that the C locale is always UTF-8.

[libvirt] [PATCH v2 0/3] unplug timeout changes for PPC64

2019-09-11 Thread Daniel Henrique Barboza
This is a redesign of the previous patch series [1]. After the reviews of the first version, I ended up discarding the idea of a qemu user configuration for the unplug timeout value. Instead, this patch series now handles the problematic case of PPC64 guests with an exclusive PPC64 only timeout

[libvirt] [PATCH v2 2/3] qemu: Remove qemu_hotplugpriv.h and qemuDomainRemoveDeviceWaitTime

2019-09-11 Thread Daniel Henrique Barboza
qemu_hotplugpriv.h is a header file created to share a global variable called 'qemuDomainRemoveDeviceWaitTime', declared in qemu_hotplug.c, to other files that would want to change the timeout value (currently, only tests/qemuhotplugtest.c). Previous patch deprecated the variable, using

[libvirt] [PATCH v2 1/3] qemu: use a bigger unplug timeout for PPC64 guests

2019-09-11 Thread Daniel Henrique Barboza
For some architectures and setups, device removal can take longer than the default 5 seconds. This results in commands such as 'virsh setvcpus' to fire timeout messages even if the operation were successful in the guest, confusing the user. This patch sets a new 10 seconds unplug timeout for

[libvirt] [PATCH v2 3/3] qemu_hotplug: make setvcpus timeout error message user-friendlier

2019-09-11 Thread Daniel Henrique Barboza
The current 'setvcpus' timeout message requires a deeper understanding of QEMU/Libvirt internals to proper react to it. One who knows how setvcpus unplug work (it is an asynchronous operation between QEMU and guest that Libvirt can't know for sure if it failed, unless an explicit error happened

Re: [libvirt] [PATCH v2 03/10] conf: Adding resolution property for model element

2019-09-11 Thread Cole Robinson
On 8/30/19 5:40 PM, jcfara...@gmail.com wrote: > From: Julio Faracco > > New element 'resolution' with parameters 'x' and 'y' were added to > support this settings for VGA, QXL, Virtio and Bochs XMLs. A new > structure was created as Acceleration element has. It is easy to parse > this property.

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Jim Fehlig
On 9/11/19 10:33 AM, Marek Marczykowski-Górecki wrote: > On Wed, Sep 11, 2019 at 01:31:34PM +, Jim Fehlig wrote: >> On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: >>> On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote: On 9/10/19 5:24 PM, Marek Marczykowski-Górecki

Re: [libvirt] [PATCH v2 02/24] cfg.mk: fix comment detection for python semicolon check

2019-09-11 Thread Eric Blake
On 9/11/19 11:23 AM, Daniel P. Berrangé wrote: > The pattern > > ^[^#].*\;$$ > > Was attempting to detect any trailing ';' in python code > which was not in a comment. This does not allow for the > comment '#' character to be indented with whitespace. > > Signed-off-by: Daniel P. Berrangé

Re: [libvirt] [PATCH 0/4] Colourize configure output

2019-09-11 Thread Cole Robinson
On 9/9/19 4:52 AM, Ján Tomko wrote: > On Mon, Sep 09, 2019 at 09:49:38AM +0200, Michal Privoznik wrote: >> An example how configure looks like with these changes applied: >> >> https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247 >> >> Michal Prívozník (4): >>  configure: Prefer

Re: [libvirt] [PATCH v2 00/10] Adding resolution properties for video models

2019-09-11 Thread Cole Robinson
On 8/30/19 5:40 PM, jcfara...@gmail.com wrote: > From: Julio Faracco > > This serie adds 'xres' and 'yres' QEMU display properties into a new > element called 'resolution'. This element is covered by model element: > > > > > > Only types VGA, QXL, Virtio and Bochs support

Re: [libvirt] [PATCH 2/4] virt-result.m4: Align string more generously

2019-09-11 Thread Cole Robinson
On 9/9/19 3:49 AM, Michal Privoznik wrote: > The times, when we had small CRTs are long gone. Now, in the era > of wide screens we can be more generous when it comes to aligning > the output of configure. The longest string before the colon is > 'wireshark_dissector' which counts 19 characters.

Re: [libvirt] [PATCH 0/5] qemu: Use FW descriptors to report FW image paths

2019-09-11 Thread Cole Robinson
On 8/5/19 12:14 PM, Michal Privoznik wrote: > It feels a bit odd to report a built in list of FW images when we have > FW descriptor files. Especially, when some weird architectures are > concerned. For instance, OVMF_CODE.fd is reported even for > non-x86_64/non-i386 arches, like ppc. But if FW

Re: [libvirt] [PATCH 3/5] qemu_firmware: Extend qemuFirmwareGetSupported to return FW paths

2019-09-11 Thread Cole Robinson
On 8/5/19 12:14 PM, Michal Privoznik wrote: > The qemuFirmwareGetSupported() function is called from qemu > driver to generate domain capabilities XML based on FW descriptor > files. However, the function currently reports only some features > from domcapabilities XML and not actual FW image

Re: [libvirt] [PATCH v4 0/2] snapshot: Store both config and live XML in the

2019-09-11 Thread Jiri Denemark
On Thu, Aug 29, 2019 at 17:55:41 -0300, Maxiwell S. Garcia wrote: > This patchset store both config and live XML in the snapshot XML. > To avoid nest 'config' XML one level deeper ('inactive/domain'), > it was necessary to create a function that has a new rootname parameter. > > V4: > - Create a

Re: [libvirt] [PATCH] qemu: Don't leak domain def when RevertToSnapshot fails

2019-09-11 Thread Pavel Hrdina
On Tue, Sep 10, 2019 at 02:04:38PM +0200, Jiri Denemark wrote: > Once we copy the domain definition from virDomainSnapshotDef, we either > need to assign it to the domain object or free it to avoid memory leaks. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_driver.c | 16

[libvirt] [dockerfiles PATCH] Add 'trigger' and 'monitor' scripts

2019-09-11 Thread Andrea Bolognani
These are extremely crude scripts that are nonetheless useful when it's time to rebuild all images. Usage is along these lines: $ ls libvirt-debian-10* >in $ ./trigger in out $ ./monitor out 3 Error handling is almost non-existent, but realistically speaking at most three people will ever

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Marek Marczykowski-Górecki
On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote: > On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: > > On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote: > >> On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: > >>> From: Ivan Kardykov > >>> > >>> Libxl driver did

[libvirt] [PATCH v2 0/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Michal Privoznik
Technically, this is a v2 of: https://www.redhat.com/archives/libvir-list/2019-August/msg01273.html but a different approach is implemented here. The limitation for lsilogic, buslogic, spapr-vscsi and vmpvscsi comes from this document:

[libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Michal Privoznik
In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() function which returns true or false if given drive address is already in use for given domain config or not. However, it also takes a shortcut and returns true (meaning address in use) if the unit number equals 7. This is because for some

[libvirt] [PATCH v2 1/2] domain_conf: Make virDomainDeviceFindSCSIController accept virDomainDeviceDriveAddress struct

2019-09-11 Thread Michal Privoznik
So far, the virDomainDeviceFindSCSIController() takes virDomainDeviceInfo structure which is an overkill. It assumes that the passed structure is type of VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE which is not obvious. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 6 +++---

Re: [libvirt] [PATCH] domain_conf: Drop ancient reservation of unit 7 in drive address

2019-09-11 Thread Michal Privoznik
On 9/10/19 3:05 PM, Ján Tomko wrote: On Wed, Aug 28, 2019 at 11:52:45AM +0200, Michal Privoznik wrote: Introduced in v1.0.6~3, the idea was that unit 7 was reserved and couldn't be used by QEMU. Well, that limitation is long gone. How does "long gone" translate to our platform support

Re: [libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Daniel P . Berrangé
On Wed, Sep 11, 2019 at 03:17:42PM +0200, Michal Privoznik wrote: > In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() > function which returns true or false if given drive address is > already in use for given domain config or not. However, it also > takes a shortcut and returns true

Re: [libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Michal Privoznik
On 9/11/19 3:24 PM, Daniel P. Berrangé wrote: > On Wed, Sep 11, 2019 at 03:17:42PM +0200, Michal Privoznik wrote: >> In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() >> function which returns true or false if given drive address is >> already in use for given domain config or not.

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Jim Fehlig
On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: > On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote: >> On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: >>> On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote: On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote:

[libvirt] [PATCH v1] docs: Expand the "BIOS bootloader" documentation for domainCaps

2019-09-11 Thread Kashyap Chamarthy
Rewrite some parts for clarity, elaborate the meaning of some of the XML attributes. And where necessary, distinguish that we're dealing with two different XML documents here: - the domainCapabilities XML, to detect the host "hypervisor" (QEMU/KVM) capabilities, and what libvirt knows

[libvirt] [PATCH] docs: Expand the "BIOS bootloader" documentation for domainCaps

2019-09-11 Thread Kashyap Chamarthy
Rewrite some parts for clarity, elaborate the meaning of some of the XML attributes. And where necessary, distinguish that we're dealing with two different XML documents here: - the domainCapabilities XML, to detect the host "hypervisor" (QEMU/KVM) capabilities, and what libvirt knows

[libvirt] [PATCH v2 07/24] build-aux: rewrite whitespace checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-spacing.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 11/24] src: rewrite symfile sorting checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-symsorting.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 13/24] src: rewrite systemtap probe generator in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the dtrace2systemtap.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 03/24] build: force a UTF-8 locale for python

2019-09-11 Thread Daniel P . Berrangé
Python3 versions less than 3.7 have very unhelpful handling of the C locale where they assume data is 7-bit only. This violates POSIX which requires the C locale to be 8-bit clean. Python3 >= 3.7 now assumes that the C locale is always UTF-8. Set env variables to force LC_CTYPE to en_US.UTF-8 so

[libvirt] [PATCH v2 14/24] src: rewrite systemtap function generator in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the gensystemtap.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 02/24] cfg.mk: fix comment detection for python semicolon check

2019-09-11 Thread Daniel P . Berrangé
The pattern ^[^#].*\;$$ Was attempting to detect any trailing ';' in python code which was not in a comment. This does not allow for the comment '#' character to be indented with whitespace. Signed-off-by: Daniel P. Berrangé --- cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH v2 05/24] build-aux: rewrite po file minimizer in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the minimize-po.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 06/24] build-aux: rewrite duplicate header checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the prohibit-duplicate-header.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same.

[libvirt] [PATCH v2 08/24] build-aux: rewrite mock inline checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the mock-noinline.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 09/24] build-aux: rewrite header ifdef checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the header-ifdef.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-11 Thread Daniel P . Berrangé
This series is an effort to reduce the number of different languages we use by eliminating most use of perl in favour of python. This aligns with fact that the likely future build system we'll use (meson) is written in python, and that python is much more commonly used/understood by developers

[libvirt] [PATCH v2 18/24] src: rewrite polkit ACL generator in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the genpolkit.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel P.

[libvirt] [PATCH v2 01/24] docs: document that C & Python are the preferred languages

2019-09-11 Thread Daniel P . Berrangé
Blacklist Perl and Shell code in favour of Python for sake of readability and portability. Signed-off-by: Daniel P. Berrangé --- docs/hacking.html.in | 30 ++ 1 file changed, 30 insertions(+) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index

[libvirt] [PATCH v2 04/24] build-aux: rewrite augest test generator in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the augeas-gentest.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. The use of

[libvirt] [PATCH v2 23/24] docs: rewrite hvsupport.html page generator in python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the hvsupport.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. The new impl generates

[libvirt] [PATCH v2 12/24] src: rewrite symfile library checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-symfile.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 15/24] src: rewrite driver name checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-drivername.pl tool in Python. This was mostly a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. In testing

[libvirt] [PATCH v2 24/24] docs: rewrite polkit docs generator in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the genaclperms.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v2 17/24] src: rewrite ACL rule checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-aclrules.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 16/24] src: rewrite driver impl checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-driverimpls.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 19/24] src: rewrite remote protocol checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the pdwtags processing script in Python. The original inline shell and perl code was completely unintelligible. The new python code is a manual conversion that attempts todo basically the same thing. Signed-off-by: Daniel P.

[libvirt] [PATCH v2 21/24] tests: rewrite qemu capability grouper in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the group-qemu-caps.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 22/24] tests: rewrite file access checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-file-access.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 20/24] tests: rewrite test argv line wrapper in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the test-wrap-argv.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v2 10/24] src: rewrite ACL permissions checker in Python

2019-09-11 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-aclperms.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Marek Marczykowski-Górecki
On Wed, Sep 11, 2019 at 01:31:34PM +, Jim Fehlig wrote: > On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: > > On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote: > >> On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: > >>> On Tue, Sep 10, 2019 at 10:54:15PM +, Jim

Re: [libvirt] [dockerfiles PATCH] Add 'trigger' and 'monitor' scripts

2019-09-11 Thread Fabiano Fidêncio
On Wed, Sep 11, 2019 at 3:12 PM Andrea Bolognani wrote: > > These are extremely crude scripts that are nonetheless useful when > it's time to rebuild all images. Usage is along these lines: > > $ ls libvirt-debian-10* >in > $ ./trigger in out > $ ./monitor out 3 > > Error handling is almost

Re: [libvirt] [PATCH] libvirt.spec.in: Add the Secure Boot-variant OVMF binaries

2019-09-11 Thread Michal Privoznik
On 9/10/19 8:56 PM, Cole Robinson wrote: On 7/30/19 12:11 PM, Kashyap Chamarthy wrote: Currently the RPM spec doesn't add the 'secboot'-variant OVMF binaries (an unintentional omission, checking with Cole on #virt, OFTC) for 'x86_64' and 'ia32'. Add them. This way, getDomainCapabilities()

Re: [libvirt] [PATCH v1] docs: Expand the "BIOS bootloader" documentation for domainCaps

2019-09-11 Thread Michal Privoznik
On 9/11/19 4:34 PM, Kashyap Chamarthy wrote: Rewrite some parts for clarity, elaborate the meaning of some of the XML attributes. And where necessary, distinguish that we're dealing with two different XML documents here: - the domainCapabilities XML, to detect the host "hypervisor"