On Fri, Sep 20, 2019 at 03:12:01PM +0100, Daniel P. Berrangé wrote:
> There are various ideas / plans floating around for future libvirt work,
> some of which is actively in progress. Historically we've never captured
> this kind of information anywhere, except in mailing list discussions.
> In
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c | 26 +-
src/conf/domain_conf.h | 7 +--
2 files changed, 22 insertions(+), 11 deletions(-)
diff --git
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 38 ++
src/qemu/qemu_domain.h | 12
2 files changed, 50 insertions(+)
Reviewed-by: Cole Robinson
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Whether a directory exists or is not readable shouldn't make a big
diffence.
This removes errors when firmare or vhost-user config is looked up
from a user session libvirt if /etc/libvirt is not readable.
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Check qemu capability, and accept 3d acceleration. 3d acceleration
support is checked when looking for a suitable vhost-user helper.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_process.c | 57
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
vhost-user device doesn't have a virgl option, it is passed to the
vhost-user-gpu helper process instead.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c| 9 ++---
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
See function documentation. Used in a following patch.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_security.c | 40
src/qemu/qemu_security.h | 6 ++
2 files
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Add qemuVhostUserFetchConfigs() to discover vhost-user helpers.
qemuVhostUserFillDomainGPU() will find the first matching GPU helper
with the required capabilities and set the associated
vhost_user_binary.
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
...host-user-gpu-secondary.x86_64-latest.args | 43 +
.../vhost-user-gpu-secondary.xml | 46 +++
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Ján Tomko
---
src/qemu/qemu_cgroup.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Similar to the qemu_tpm.c, add a unit with a few functions to
start/stop and setup the cgroup of the external vhost-user-gpu
process. See function documentation.
The vhost-user connection fd is set on
On Mon, Sep 16, 2019 at 05:37:43PM +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> generator.py | 1 +
> libvirt-override.c | 66 ++
> 2 files changed, 67 insertions(+)
This is missing XML description in
Signed-off-by: Daniel P. Berrangé
---
generator.py | 1 +
libvirt-override-api.xml | 7 +
libvirt-override.c | 64
3 files changed, 72 insertions(+)
diff --git a/generator.py b/generator.py
index 433c1f2..913dab8 100755
---
On Fri, Sep 20, 2019 at 11:33:11AM +0200, Pavel Hrdina wrote:
> Introduced in libvirt 5.4.0 by commit .
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1683516
>
> Signed-off-by: Pavel Hrdina
> ---
> libvirt-override.c | 8
> 1 file changed, 8 insertions(+)
Reviewed-by:
On Fri, Sep 20, 2019 at 11:33:10AM +0200, Pavel Hrdina wrote:
> Introduced in libvirt 4.6.0 by commit .
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1683516
>
> Signed-off-by: Pavel Hrdina
> ---
> libvirt-override.c | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel
On Fri, Sep 20, 2019 at 11:28:40AM +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> generator.py | 1 +
> libvirt-override-api.xml | 7 +
> libvirt-override.c | 64
> 3 files changed, 72 insertions(+)
On Thu, Sep 19, 2019 at 05:48:37AM +, Linus Färnstrand wrote:
* pass same size to virStreamRecv as the buffer has allocated
* Handle -2 error case
* Fix FFI declaration to take size_t instead of c_uint
* Allow user to pass in buffer. To allow user to decide where to
allocate it. And to be
On Thu, Sep 19, 2019 at 05:04:46PM -0300, Daniel Henrique Barboza wrote:
> A few 'cleanup' labels gone after using VIR_AUTOFREE() in the
> strings.
s/in the strings/on the @addrStr variable
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Thu, Sep 19, 2019 at 05:48:21AM +, Linus Färnstrand wrote:
Hi,
Fixing memory soundness bugs in Stream::recv, and other bugs in both
Stream::recv and Stream::send.
The method Stream::recv takes a size argument that it passes on as the nbytes
argument to virStreamRecv. The problem is that
On Thu, Sep 19, 2019 at 05:48:49AM +, Linus Färnstrand wrote:
* Handle the -2 error case
* Allow sending arbitrary byte array, not just UTF-8 strings
* Fix FFI declaration, takes size_t, not c_uint
* Return usize to be more idiomatic (type used for slice indexing)
Signed-off-by: Linus
On 19.09.19 22:24, Collin Walling wrote:
> Note: since I've made some changes to a lot of these patches / split
> up some patches, I've decided to hold off on adding any r-b's in case
> there is a specific change that someone does not agree with.
>
> Changelog:
>
> - Properly refactored code
On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote:
> Meson build system is simple and quick compared to Autotools and it's
> able to fully replace our Autotools usage. There are few drawbacks as
> it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0,
> it's still
Introduced in libvirt 5.4.0 by commit .
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1683516
Signed-off-by: Pavel Hrdina
---
libvirt-override.c | 8
1 file changed, 8 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 3310b54..c76c447 100644
---
On Mon, Sep 16, 2019 at 03:27:25PM +0200, Chris Coulson wrote:
The AppArmor profile generated by virt-aa-helper is too strict for swtpm.
This change contains 2 small fixes:
- Relax append access to swtpm's log file to permit write access instead.
Append access is insufficient because the log is
ping, this would fix our broken CI...
On Mon, Sep 16, 2019 at 05:37:43PM +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> generator.py | 1 +
> libvirt-override.c | 66 ++
> 2 files changed, 67 insertions(+)
>
>
Meson build system is simple and quick compared to Autotools and it's
able to fully replace our Autotools usage. There are few drawbacks as
it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0,
it's still evolving and the user base is not that large and there were
some tweaks
On Thu, Sep 19, 2019 at 05:04:47PM -0300, Daniel Henrique Barboza wrote:
> A common operation in qemu_domain_address is comparing a
> virPCIDeviceAddress and assigning domain, bus, slot and function
> to a specific value. The former can be done with the existing
> virPCIDeviceAddressEqual()
Introduced in libvirt 4.6.0 by commit .
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1683516
Signed-off-by: Pavel Hrdina
---
libvirt-override.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index ff2cfdf..3310b54 100644
---
Pavel Hrdina (2):
virDomainMemoryStats: include disk caches
virDomainMemoryStats: include hugetlb pgalloc and pgfail
libvirt-override.c | 13 +
1 file changed, 13 insertions(+)
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Sep 20, 2019 at 10:14:00AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote:
> > Meson build system is simple and quick compared to Autotools and it's
> > able to fully replace our Autotools usage. There are few drawbacks as
> > it's a fairly
On Fri, Sep 20, 2019 at 11:36:53AM +0200, Pavel Hrdina wrote:
> On Fri, Sep 20, 2019 at 10:14:00AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote:
> > > Meson build system is simple and quick compared to Autotools and it's
> > > able to fully
On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote:
>
> Meson build system is simple and quick compared to Autotools and it's
> able to fully replace our Autotools usage. There are few drawbacks as
> it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0,
> it's still evolving
On Fri, Sep 20, 2019 at 1:28 PM Fabiano Fidêncio wrote:
>
> On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote:
> >
> > Meson build system is simple and quick compared to Autotools and it's
> > able to fully replace our Autotools usage. There are few drawbacks as
> > it's a fairly new build
Commit 50dfabbb59 forgot to add this important bit on how to check that
all the changes to the XML actually worked.
---
docs/kbase/launch_security_sev.html.in | 12
1 file changed, 12 insertions(+)
diff --git a/docs/kbase/launch_security_sev.html.in
Signed-off-by: Daniel P. Berrangé
---
src/remote/Makefile.inc.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index e05ae64169..e02c20d47c 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@
'vm' is passed in which contains the definition which contains the UUID
so we don't need another parameter for this.
Signed-off-by: Peter Krempa
---
src/conf/checkpoint_conf.c | 7 +++
src/conf/checkpoint_conf.h | 3 +--
src/qemu/qemu_driver.c | 2 +-
src/test/test_driver.c | 2 +-
Move it to qemu_domain.c and rename it to qemuDomainObjFromDomain. This
will allow reusing it after splitting out checkpoint code from
qemu_driver.c.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 31 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_driver.c | 303
The code that gets the job to refresh disk sizes was not merged yet so
remove this artifact.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 69467c21f6..485b38ebac 100644
---
'vm' is passed in which contains the definition which contains the UUID
so we don't need another parameter for this.
Signed-off-by: Peter Krempa
---
src/conf/snapshot_conf.c | 5 ++---
src/conf/snapshot_conf.h | 3 +--
src/qemu/qemu_driver.c | 2 +-
src/test/test_driver.c | 2 +-
4 files
Signed-off-by: Peter Krempa
---
src/qemu/qemu_checkpoint.c | 185 ++---
src/qemu/qemu_checkpoint.h | 5 +
src/qemu/qemu_domain.c | 162 +---
src/qemu/qemu_domain.h | 15 ---
4 files changed, 180 insertions(+), 187
The checkpoint code is quite complex and was dispersed in many places.
Refactor it to be in one new separate file.
I also plan to do the same to the snapshot code once this is dealt with.
Additionally aggregating all the code in one place will allow
refactoring and reuse in the incremental
There's nothing that uses it directly now. Also not allowing direct use
will promote our layering.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 89a0b0963d..186b6ed528 100644
---
Move all extensive functions to a new file so that we don't just pile
everything in the common files. This obviously isn't possible with
straight code movement as we still need stubs in qemu_driver.c
Additionally some functions e.g. for looking up a checkpoint by name
were so short that moving
[snip]
>
> > In general, it looks good and works as expected.
> > I will add my "Reviewed-by: " after we discuss the points raised.
> >
> > Another thing, please, let's sync to have the libvirt-jenkins-ci work
> > done and merged before this one gets merged.
>
> Works for me, thanks for review,
There are various ideas / plans floating around for future libvirt work,
some of which is actively in progress. Historically we've never captured
this kind of information anywhere, except in mailing list discussions.
In particular guidelines in hacking.html.in don't appear until a policy
is
On Fri, Sep 20, 2019 at 10:06:35AM -0400, Laine Stump wrote:
> When the bridge re-attach handling was moved out of the network driver
> and into the hypervisor driver (commit b806a60e) as a part of the
> refactor to split the network driver into a separate daemon, the check
> was accidentally
On Fri, Sep 20, 2019 at 01:28:28PM +0200, Fabiano Fidêncio wrote:
> On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote:
> >
> > Meson build system is simple and quick compared to Autotools and it's
> > able to fully replace our Autotools usage. There are few drawbacks as
> > it's a fairly new
On Fri, 2019-09-20 at 13:12 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/remote/Makefile.inc.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Fixes b7ed8ce98112.
Reviewed-by: Andrea Bolognani
In a separate patch, you might want to
A common operation in qemu_domain_address is comparing a
virPCIDeviceAddress and assigning domain, bus, slot and function
to a specific value. The former can be done with the existing
virPCIDeviceAddressEqual() helper, as long as we provide
a virPCIDeviceAddress to compare it to.
The later can be
Second round of these cleanups after the reviews from
Eric.
changes from v1:
- fixed the commit message of patch 1
- ditched the virPCIAddressSet() approach - use direct
assignment instead
v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00823.html
Daniel Henrique Barboza
A few 'cleanup' labels gone after using VIR_AUTOFREE() on the
@addrStr variable.
Reviewed-by: Erik Skultety
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain_address.c | 69 +++---
1 file changed, 30 insertions(+), 39 deletions(-)
diff --git
On Fri, 2019-09-20 at 15:12 +0100, Daniel P. Berrangé wrote:
[...]
> + This document attempts to outline the libvirt project strategy for
> + the near future. Think of this is a high level vision or todo list
s/is a high/as a high/
> + setting the direction for the project & its
On 9/20/19 6:25 AM, Erik Skultety wrote:
On Thu, Sep 19, 2019 at 05:04:47PM -0300, Daniel Henrique Barboza wrote:
A common operation in qemu_domain_address is comparing a
virPCIDeviceAddress and assigning domain, bus, slot and function
to a specific value. The former can be done with the
When the bridge re-attach handling was moved out of the network driver
and into the hypervisor driver (commit b806a60e) as a part of the
refactor to split the network driver into a separate daemon, the check
was accidentally changed to only check for type='bridge'. The check for
type in this case
On Fri, Sep 20, 2019 at 15:12:01 +0100, Daniel Berrange wrote:
> There are various ideas / plans floating around for future libvirt work,
> some of which is actively in progress. Historically we've never captured
> this kind of information anywhere, except in mailing list discussions.
> In
55 matches
Mail list logo
