On Fri, Sep 20, 2019 at 2:34 PM Fabiano Fidêncio wrote:
>
> [snip]
>
> >
> > > In general, it looks good and works as expected.
> > > I will add my "Reviewed-by: " after we discuss the points raised.
> > >
> > > Another thing, please, let's sync to have the libvirt-jenkins-ci work
> > > done and
Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler.
NB: these two patches should also be included with the other patches for
https://bugzilla.redhat.com/1745815
Laine Stump (2):
conf: take advantage of VIR_AUTO* in virDomainNetCreatePort()
conf: refresh network ports missing
From: Julio Faracco
Function qemuMigrationEatCookie() calls
qemuMigrationCookieXMLParseStr(), when qemuCaps is not set, function
assumes priv as a NULL pointer. At the end, function tries to set
job info operation to the same current job. But, if priv is NULL due to
missing qemuCaps, code
Before the refactoring that properly separated the network driver from
the hypervisor driver and forced all interaction to go through public
APIs, all network usage counters were zeroed when the network driver
was initialized, and the network driver's now-deprecated
"semi-private" API
Before adding new code to this function that will be made easier by
using auto-cleaning pointers, update it to use auto-cleaning pointers
(and the more modern virErrorPreserveLast()).
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 53 ++--
On 9/16/19 9:27 AM, Chris Coulson wrote:
The AppArmor profile generated by virt-aa-helper is too strict for swtpm.
This change contains 2 small fixes:
- Relax append access to swtpm's log file to permit write access instead.
Append access is insufficient because the log is opened with O_CREAT.
-
