Re: [libvirt] [PATCH 16/30] storagefile: Don't access backingStoreRaw directly in FromBackingRelative

2019-10-09 Thread Daniel Henrique Barboza
On 10/7/19 6:49 PM, Cole Robinson wrote: For the only usage, the rel == parent->backingStoreRaw, so drop the direct access Signed-off-by: Cole Robinson --- Reviewed-by: Daniel Henrique Barboza src/util/virstoragefile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] [PATCH 0/5] security_stack: Perform rollback if one of stacked drivers fails

2019-10-09 Thread Cole Robinson
On 9/16/19 5:12 AM, Michal Privoznik wrote: See 5/5 for explanation. Michal Prívozník (5): security: Pass @migrated to virSecurityManagerSetAllLabel security: Rename virSecurityManagerGetDriver() to virSecurityManagerGetVirtDriver() security: Introduce

Re: [libvirt] Add support for vhost-user-scsi-pci/vhost-user-blk-pci

2019-10-09 Thread Cole Robinson
Sorry for the late reply, and thanks Jano for pointing out elsewhere that this didn't receive a response. On 8/12/19 5:56 AM, Li Feng wrote: Hi Guys, And I want to add the vhost-user-scsi-pci/vhost-user-blk-pci support for libvirt. The usage in qemu like this: Vhost-SCSI -chardev

Re: [libvirt] [PATCH 14/30] storagefile: Parse qcow2 external data file

2019-10-09 Thread Daniel Henrique Barboza
On 10/7/19 6:49 PM, Cole Robinson wrote: This is tracked as a qcow2 extension, like backing store format Signed-off-by: Cole Robinson --- Reviewed-by: Daniel Henrique Barboza src/util/virstoragefile.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH v2 2/3] qemu: Implement the ccf-assist pSeries feature

2019-10-09 Thread Cole Robinson
On 10/8/19 4:06 PM, Daniel Henrique Barboza wrote: This patch adds the implementation of the ccf-assist pSeries feature, based on the QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST capability that was added in the previous patch. Signed-off-by: Daniel Henrique Barboza --- docs/formatdomain.html.in

[libvirt] [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-09 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Libvirt-checked-by: Peter Krempa Signed-off-by: John Snow --- qemu-deprecated.texi |

[libvirt] [PATCH v2 0/1] IDE: Deprecate ide-drive

2019-10-09 Thread John Snow
V2: Change phrasings and spellings as Markus suggested. John Snow (1): IDE: deprecate ide-drive qemu-deprecated.texi | 5 + hw/ide/qdev.c | 3 +++ tests/qemu-iotests/051.pc.out | 6 -- 3 files changed, 12 insertions(+), 2 deletions(-) -- 2.21.0 --

Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-09 Thread John Snow
On 10/8/19 2:51 AM, Markus Armbruster wrote: >> I'll respin to hit the tests with a stiffer scrub-brush. > Thanks! 051 is the only test I can find that uses ide-drive, and the non-pc version of the test doesn't seem to use it, so this actually seems sufficient. I'd like to keep the test for

Re: [libvirt] [PATCH 15/30] storagefile: Fill in meta->externalDataStoreRaw

2019-10-09 Thread Daniel Henrique Barboza
On 10/7/19 6:49 PM, Cole Robinson wrote: Call qcow2GetExtensions to actually fill in the virStorageSource externalDataStoreRaw member Signed-off-by: Cole Robinson --- Reviewed-by: Daniel Henrique Barboza src/util/virstoragefile.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [libvirt] [PATCH 1/2] qemu: Fix @vm locking issue when connecting to the monitor

2019-10-09 Thread Jonathon Jongsma
This change gives me a segfault at startup when running libvirtd from my working directory. Reverting these two patches solves the issue. Thread 17 "lt-libvirtd" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffc0dff700 (LWP 4338)] virDomainObjIsActive

Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-09 Thread Pavel Hrdina
On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote: > On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: > > Converting from virObject to GObject is reasonably straightforward, > > as illustrated by this patch for virIdentity > > > > In the header file > > > > - Remove >

Re: [libvirt] [jenkins-ci PATCH v3 06/12] guests: Install meson via pip

2019-10-09 Thread Andrea Bolognani
On Tue, 2019-10-08 at 22:48 +0200, Fabiano Fidêncio wrote: > +- name: '{{ project }}: Verify pip mappings' > + fail: > +msg: 'No mappings defined for {{ item }}' > + with_items: > +'{{ packages }}' > + when: > +- pip_mappings[item] is undefined Turns out you actually need the

Re: [libvirt] [PATCH v2 17/23] conf: convert over to use GRegex for regular expressions

2019-10-09 Thread Bjoern Walk
Daniel P. Berrangé [2019-10-07, 06:14PM +0100]: > @@ -2306,20 +2304,17 @@ > virDomainQemuMonitorEventStateRegisterID(virConnectPtr conn, > return -1; > data->flags = flags; > if (event && flags != -1) { > -int rflags = REG_NOSUB; > - > -if (flags &

[libvirt] [jenkins-ci PATCH] lcitool: Fix pip handling in Dockerfiles

2019-10-09 Thread Andrea Bolognani
We're currently only installing pip packages for cross-build Dockerfiles, which was obviously not the original intention. Signed-off-by: Andrea Bolognani --- Pushed as trivial. guests/lcitool | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git

[libvirt] [dockerfiles PATCH] Refresh libosinfo containers after adding Meson to more platforms

2019-10-09 Thread Fabiano Fidêncio
This will bring back the ability to have CentOS7, Debian9, Ubuntu16 and Ubuntu18 containers. The corresponding libvirt-jenkins-ci commit is b6aabedc67ca. Signed-off-by: Fabiano Fidêncio --- https://gitlab.com/fidencio/libvirt-dockerfiles/tree/wip/more_libosinfo_containers ---

Re: [libvirt] [PATCH v2 0/5] build: take full ownership of syntax-check from gnulib

2019-10-09 Thread Michal Privoznik
On 10/8/19 5:48 PM, Daniel P. Berrangé wrote: Our syntax-check rule relies in various files imported during the gnulib bootstrap process. As we switch to meson & try to eliminate gnulib, we need to take ownership of syntax-check. This patch series follows the approach taken for libosinfo &

[libvirt] [dockerfiles PATCH] Refresh after adding Meson to more platforms

2019-10-09 Thread Andrea Bolognani
The corresponding libvirt-jenkins-ci commit is b6aabedc67ca. Signed-off-by: Andrea Bolognani --- Pushed under the Dockerfile refresh rule. Plain-text diff below. buildenv-libvirt-centos-7.zip| Bin 671 -> 715 bytes buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 991 -> 1021

[libvirt] [dockerfiles PATCH] Re-introduce some libosinfo platforms

2019-10-09 Thread Andrea Bolognani
Now that we can install Meson from pip, building libosinfo and friends is once again possible on these platforms. Signed-off-by: Andrea Bolognani --- Plain-text diff below. buildenv-libosinfo-centos-7.zip | Bin 0 -> 532 bytes buildenv-libosinfo-debian-9.zip | Bin 0 -> 659 bytes

[libvirt] [PATCH v4 12/26] src: rewrite systemtap function generator in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the gensystemtap.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v4 26/26] docs: move hyperv_wmi_generator.py to the scripts/ directory

2019-10-09 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Makefile.am | 1 + {src/hyperv => scripts}/hyperv_wmi_generator.py | 0 src/hyperv/Makefile.inc.am | 5 ++--- 3 files changed, 3 insertions(+), 3 deletions(-) rename {src/hyperv =>

[libvirt] [PATCH v4 01/26] build: fix use of $(AUG_GENTEST) as a dependency

2019-10-09 Thread Daniel P . Berrangé
The use of $(AUG_GENTEST) as a dependency in the makefiles is a problem because this was assumed to be the filename of the script, but is in fact a full shell command line. Split it into two variables, so it can be correctly used for dependencies. Reviewed-by: Ján Tomko Signed-off-by: Daniel P.

[libvirt] [PATCH v4 24/26] docs: move reformat-news.py to the scripts/ directory

2019-10-09 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Makefile.am| 7 --- {docs => scripts}/reformat-news.py | 0 2 files changed, 4 insertions(+), 3 deletions(-) rename {docs => scripts}/reformat-news.py (100%) diff --git a/Makefile.am b/Makefile.am index e63c005db7..f131c40f62

[libvirt] [PATCH v4 03/26] build-aux: rewrite po file minimizer in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the minimize-po.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v4 10/26] src: rewrite symfile library checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-symfile.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v4 04/26] build-aux: rewrite duplicate header checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the prohibit-duplicate-header.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same.

[libvirt] [PATCH v4 07/26] build-aux: rewrite header ifdef checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the header-ifdef.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v4 16/26] src: rewrite polkit ACL generator in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the genpolkit.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel P.

[libvirt] [PATCH v4 18/26] tests: rewrite test argv line wrapper in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the test-wrap-argv.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v4 09/26] src: rewrite symfile sorting checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-symsorting.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

Re: [libvirt] [PATCH v3 00/12] hostdev: handle usb detach/attach on node

2019-10-09 Thread Nikolay Shirokovskiy
ping On 17.09.2019 16:47, Nikolay Shirokovskiy wrote: > Diff to v2[1] version: > - add 'replug' attribute for hostdev element to allow replug semantics > - avoid accuiring domain lock in event loop thread on udev events as > suggested by Peter > - nit picks after review by Daniel Henrique

[libvirt] [PATCH v4 17/26] src: rewrite remote protocol checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the pdwtags processing script in Python. The original inline shell and perl code was completely unintelligible. The new python code is a manual conversion that attempts todo basically the same thing. Signed-off-by: Daniel P.

[libvirt] [PATCH v4 20/26] tests: rewrite file access checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-file-access.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v4 22/26] docs: rewrite polkit docs generator in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the genaclperms.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] [PATCH v4 23/26] docs: move apibuild.py to the scripts/ directory

2019-10-09 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Makefile.am | 1 + cfg.mk| 2 +- docs/Makefile.am | 5 ++--- {docs => scripts}/apibuild.py | 0 4 files changed, 4 insertions(+), 4 deletions(-) rename {docs => scripts}/apibuild.py (100%) diff --git

[libvirt] [PATCH v4 25/26] docs: move esx_vi_generator.py to the scripts/ directory

2019-10-09 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Makefile.am | 1 + {src/esx => scripts}/esx_vi_generator.py | 0 src/esx/Makefile.inc.am | 5 ++--- 3 files changed, 3 insertions(+), 3 deletions(-) rename {src/esx => scripts}/esx_vi_generator.py (100%) diff

Re: [libvirt] [PATCH 00/10] scripts: fix nearly all flake8 style violations

2019-10-09 Thread Eric Blake
On 10/9/19 7:58 AM, Daniel P. Berrangé wrote: We recently introduced flake8 to check for bogus semicolon at the end of line in python code. It can check for sooo much more than this. In general it is desirable to comply with as much as possible, since this results in python code that is more

Re: [libvirt] [PATCH 2/2] qemu: Add support for pseries 'host-model' machine parameter

2019-10-09 Thread Daniel P . Berrangé
On Tue, Oct 08, 2019 at 01:46:57PM -0300, Fabiano Rosas wrote: > Since QEMU v4.0.0, the host's model is no longer automatically exposed > to the guest via /proc/device-tree/host-model. There is now a machine > option 'host-model' that allows an arbitrary string to be used as the > host model [1].

Re: [libvirt] Semantic change in v4.3 slows down image creation and snapshots (on ZFS)

2019-10-09 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 02:25:09PM +0200, Peter Krempa wrote: > On Wed, Oct 09, 2019 at 13:39:54 +0200, Christian Ehrhardt wrote: > > Hi, > > when discussing bug [1] triggered by [2] Daniel and I have found that > > the change [3] which is in since v4.3 was a semantic change to the > > behavior of

Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-09 Thread Ján Tomko
On Wed, Oct 09, 2019 at 09:07:57AM +0200, Pavel Hrdina wrote: On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote: On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: > Converting from virObject to GObject is reasonably straightforward, > as illustrated by this patch for

Re: [libvirt] [PATCH 02/10] build: change flake8 to use blacklist instead of whitelist

2019-10-09 Thread Eric Blake
On 10/9/19 7:58 AM, Daniel P. Berrangé wrote: The current flake8 check only looks at one item (semicolons at end of line). This means that our code quality will continue to get worse, violating an increasing number of checks. Switching to a whitelist means that we freeze the badness at its

Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-09 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 03:16:38PM +0200, Ján Tomko wrote: > On Wed, Oct 09, 2019 at 09:07:57AM +0200, Pavel Hrdina wrote: > > On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote: > > > On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: > > > > Converting from virObject to

Re: [libvirt] [PATCH] tests: delete objectlocking test code

2019-10-09 Thread Michal Privoznik
On 10/8/19 5:19 PM, Daniel P. Berrangé wrote: The object locking test code is not run by any CI tests and has bitrotted to the point where it isn't worth the effort to try to fix it. Signed-off-by: Daniel P. Berrangé --- .gitignore | 3 - configure.ac | 12 -

[libvirt] [PATCH v4 05/26] build-aux: rewrite whitespace checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-spacing.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

Re: [libvirt] [dockerfiles PATCH] Re-introduce some libosinfo platforms

2019-10-09 Thread Fabiano Fidêncio
On Wed, Oct 9, 2019 at 12:18 PM Andrea Bolognani wrote: > > Now that we can install Meson from pip, building libosinfo and > friends is once again possible on these platforms. > > Signed-off-by: Andrea Bolognani Reviewed-by: Fabiano Fidêncio -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v4 21/26] docs: rewrite hvsupport.html page generator in python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the hvsupport.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. The new impl generates

[libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-09 Thread Daniel P . Berrangé
This series is an effort to reduce the number of different languages we use by eliminating most use of perl in favour of python. This aligns with fact that the likely future build system we'll use (meson) is written in python, and that python is much more commonly used/understood by developers

[libvirt] [PATCH v4 11/26] src: rewrite systemtap probe generator in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the dtrace2systemtap.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v4 13/26] src: rewrite driver name checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-drivername.pl tool in Python. This was mostly a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. In testing

[libvirt] [PATCH v4 14/26] src: rewrite driver impl checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-driverimpls.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v4 06/26] build-aux: rewrite mock inline checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the mock-noinline.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel

[libvirt] Semantic change in v4.3 slows down image creation and snapshots (on ZFS)

2019-10-09 Thread Christian Ehrhardt
Hi, when discussing bug [1] triggered by [2] Daniel and I have found that the change [3] which is in since v4.3 was a semantic change to the behavior of libvirt. virt-manager used and still does issue a volume XML like: disk.qcow2 16106127360 16106127360 Up

Re: [libvirt] [PATCH 0/2] qemu: Add support for host-model pseries machine option

2019-10-09 Thread Daniel P . Berrangé
On Tue, Oct 08, 2019 at 01:46:55PM -0300, Fabiano Rosas wrote: > This series adds support for the -machine,host-model= QEMU option for > for pseries guests. > > Pseries guests used to have a node (/proc/device-tree/host-model) in > device-tree that exposed the host's model string so that guest >

[libvirt] [PATCH 04/10] python: mark regex strings with 'r' prefix

2019-10-09 Thread Daniel P . Berrangé
When writing regexes special regex matches like "\d" can get misinterpreted as normal string escape sequences: docs/apibuild.py:1359:51: W605 invalid escape sequence '\d' value = value + re.sub("^(\d+)U$", "\\1", token[1])

[libvirt] [PATCH 02/10] build: change flake8 to use blacklist instead of whitelist

2019-10-09 Thread Daniel P . Berrangé
The current flake8 check only looks at one item (semicolons at end of line). This means that our code quality will continue to get worse, violating an increasing number of checks. Switching to a whitelist means that we freeze the badness at its current level & can incrementally fix things up. We

[libvirt] [PATCH 05/10] python: avoid variable named 'l'

2019-10-09 Thread Daniel P . Berrangé
Python code style recommends avoiding a variable named 'l' as it is visually similar to '1'. docs/apibuild.py:482:13: E741 ambiguous variable name 'l' l = len(line) ^ docs/apibuild.py:503:21: E741 ambiguous variable name 'l' l = len(line)

[libvirt] [PATCH 06/10] python: avoid bare 'except:' clause

2019-10-09 Thread Daniel P . Berrangé
Exception catching statements should always match on a class name, the most specific one possible. Rather than analyse the code to look at what the most specific one is, this just uses the base Exception class. docs/apibuild.py:255:9: E722 do not use bare 'except' except: ^

[libvirt] [PATCH 01/10] docs: remove some dead code in apibuild.py

2019-10-09 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/apibuild.py | 23 --- 1 file changed, 23 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 92886e1276..3f0b72d18e 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -553,17 +553,10 @@ class CLexer:

[libvirt] [PATCH 00/10] scripts: fix nearly all flake8 style violations

2019-10-09 Thread Daniel P . Berrangé
We recently introduced flake8 to check for bogus semicolon at the end of line in python code. It can check for sooo much more than this. In general it is desirable to comply with as much as possible, since this results in python code that is more consistent in style to that seen in other projects.

Re: [libvirt] [dockerfiles PATCH] Refresh libosinfo containers after adding Meson to more platforms

2019-10-09 Thread Fabiano Fidêncio
On Wed, Oct 9, 2019 at 12:56 PM Fabiano Fidêncio wrote: > > This will bring back the ability to have CentOS7, Debian9, Ubuntu16 and > Ubuntu18 containers. > > The corresponding libvirt-jenkins-ci commit is b6aabedc67ca. > > Signed-off-by: Fabiano Fidêncio Self-nack as Andrea submitted the very

[libvirt] [PATCH 2/2] qemu: Add support for pseries 'host-model' machine parameter

2019-10-09 Thread Fabiano Rosas
Since QEMU v4.0.0, the host's model is no longer automatically exposed to the guest via /proc/device-tree/host-model. There is now a machine option 'host-model' that allows an arbitrary string to be used as the host model [1]. This patch adds support for exposing the real host model string from

[libvirt] [PATCH 1/2] qemu: Add capability for pseries machine 'host-model' parameter

2019-10-09 Thread Fabiano Rosas
As of QEMU v4.0.0, the pseries machine has a new parameter 'host-model' which receives an arbitrary string to be exposed inside the guest at /proc/device-tree/host-model. Signed-off-by: Fabiano Rosas --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h

[libvirt] [PATCH 0/2] qemu: Add support for host-model pseries machine option

2019-10-09 Thread Fabiano Rosas
This series adds support for the -machine,host-model= QEMU option for for pseries guests. Pseries guests used to have a node (/proc/device-tree/host-model) in device-tree that exposed the host's model string so that guest userspace tools could determine the host machine they were running on.

[libvirt] [PATCH 03/10] python: fix use of undeclared variables in python scripts

2019-10-09 Thread Daniel P . Berrangé
docs/apibuild.py:2436:65: F821 undefined name 'first_letter' chunks.append(["chunk%s" % (chunk - 1), first_letter, letter]) ^ src/hyperv/hyperv_wmi_generator.py:415:57: F821 undefined name 'number'

[libvirt] [PATCH 09/10] python: sanitize indentation after line continuations

2019-10-09 Thread Daniel P . Berrangé
Line continuations should be 4 space indented unless a previous opening brace required different alignment. docs/apibuild.py:2014:24: E126 continuation line over-indented for hanging indent token[0], token[1])) ^ docs/apibuild.py:74:3: E121

[libvirt] [PATCH 08/10] python: sanitize spaces either side of operators

2019-10-09 Thread Daniel P . Berrangé
There should be a single space either side of operators. Inline comments should have two spaces before the '#' src/hyperv/hyperv_wmi_generator.py:130:45: E261 at least two spaces before inline comment source += '{ "", "", 0 },\n' # null terminated

[libvirt] [PATCH 07/10] python: sanitize blank line usage

2019-10-09 Thread Daniel P . Berrangé
Coding style expects 1 blank line between each method and 2 blank lines before each class. docs/apibuild.py:171:5: E303 too many blank lines (2) def set_header(self, header): ^ docs/apibuild.py:230:1: E302 expected 2 blank lines, found 1 class index: ^ docs/apibuild.py:175:5: E301

[libvirt] [PATCH 10/10] build: comment on why we're not adopting certain flake8 rules

2019-10-09 Thread Daniel P . Berrangé
Simplify the list of ignored warnings now that we only have two left, and document why we're not honouring them. Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/build-aux/syntax-check.mk

[libvirt] [PATCH v4 08/26] src: rewrite ACL permissions checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-aclperms.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v4 02/26] build-aux: rewrite augeas test generator in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the augeas-gentest.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. The use of

[libvirt] [PATCH v4 15/26] src: rewrite ACL rule checker in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the check-aclrules.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

[libvirt] [PATCH v4 19/26] tests: rewrite qemu capability grouper in Python

2019-10-09 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the group-qemu-caps.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by:

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-09 Thread Peter Krempa
On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: [...] > - src/rpc/gendispatch.pl > - src/rpc/genprotocol.pl > - tools/wireshark/util/genxdrstub.pl [...] > Note that the check-spacing.py script is significantly > slower in Python than in Perl. After researching this > it

Re: [libvirt] Semantic change in v4.3 slows down image creation and snapshots (on ZFS)

2019-10-09 Thread Peter Krempa
On Wed, Oct 09, 2019 at 13:39:54 +0200, Christian Ehrhardt wrote: > Hi, > when discussing bug [1] triggered by [2] Daniel and I have found that > the change [3] which is in since v4.3 was a semantic change to the > behavior of libvirt. > > virt-manager used and still does issue a volume XML like:

[libvirt] [jenkins-ci PATCH 0/3] Add python3 & python3-setup tools to the base project

2019-10-09 Thread Fabiano Fidêncio
The former can be added to tbe base project as a direct or indirect dependency of the most part of the projects in libvirt-jenkins-ci. The latter is needed in order to use pip module for ansible, which is used to install meson in platforms where it's either not supported or doesn't match the

Re: [libvirt] [PATCH 1/7] conf: Move -virDomainDiskDefForeachPath to virt-aa-helper

2019-10-09 Thread Michal Privoznik
On 10/8/19 6:22 PM, Cole Robinson wrote: It is the only user. Rename it to match the local style Signed-off-by: Cole Robinson --- src/conf/domain_conf.c| 42 - src/conf/domain_conf.h| 10 --- src/libvirt_private.syms | 1 -

Re: [libvirt] [PATCH 0/7] security: apparmor: prep for qcow2 data_file

2019-10-09 Thread Michal Privoznik
On 10/8/19 6:22 PM, Cole Robinson wrote: This series does some preparation cleanup and refactoring to simplify adding qcow2 data_file support to the apparmor driver. More info on the qcow2 feature and libvirt work here: https://www.redhat.com/archives/libvir-list/2019-October/msg00303.html Cole

[libvirt] [jenkins-ci PATCH 1/3] guests: Move python3 to the base project

2019-10-09 Thread Fabiano Fidêncio
As a bunch of projects already directly depend on python3 (libvirt-dbus, libvirt-python, osinfo-db-tools, osinfo-db, virt-manager), and some depend on it indirectly (as libvirt or anything else depending on flake8), let's add python3 to the base project. Signed-off-by: Fabiano Fidêncio ---

Re: [libvirt] [jenkins-ci PATCH] guests: Install EPEL on CentOS 7 container

2019-10-09 Thread Andrea Bolognani
On Wed, 2019-10-09 at 17:52 +0200, Fabiano Fidêncio wrote: > +++ b/guests/lcitool > @@ -714,6 +714,14 @@ class Application: > {package_manager} autoremove -y && \\ > {package_manager} clean all -y > """).format(**varmap)) > +

Re: [libvirt] [jenkins-ci PATCH 0/3] Add python3 & python3-setup tools to the base project

2019-10-09 Thread Andrea Bolognani
On Wed, 2019-10-09 at 17:08 +0200, Fabiano Fidêncio wrote: > The former can be added to tbe base project as a direct or indirect > dependency of the most part of the projects in libvirt-jenkins-ci. The > latter is needed in order to use pip module for ansible, which is used > to install meson in

[libvirt] [jenkins-ci PATCH] guests: Install EPEL on CentOS 7 container

2019-10-09 Thread Fabiano Fidêncio
Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to have both "ninja" and "python36-*" packages in the system. However, we've forgot to add the very code to the lcitool so the containers would also have EPEL release installed. Signed-off-by: Fabiano Fidêncio --- guests/lcitool

Re: [libvirt] [jenkins-ci PATCH] guests: Install EPEL on CentOS 7 container

2019-10-09 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 05:52:27PM +0200, Fabiano Fidêncio wrote: > Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to > have both "ninja" and "python36-*" packages in the system. > > However, we've forgot to add the very code to the lcitool so the > containers would also have

[libvirt] Update the release note of released version

2019-10-09 Thread Han Han
Hi, Although libvirt-5.8 is released, however some features or improvement like "slirp helper process" are missing in release note now. Can I update the news.xml even after v5.8 ? -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone:

Re: [libvirt] Update the release note of released version

2019-10-09 Thread Michal Privoznik
On 10/9/19 4:44 PM, Han Han wrote: Hi, Although libvirt-5.8 is released, however some features or improvement like "slirp helper process" are missing in release note now. Can I update the news.xml even after v5.8 ? That would only affect our web page and future releases. Unfortunately, we

Re: [libvirt] Update the release note of released version

2019-10-09 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 10:44:25PM +0800, Han Han wrote: > Hi, > Although libvirt-5.8 is released, however some features or improvement like > "slirp helper process" are missing in release note now. Can I update the > news.xml > even after v5.8 ? Yes, that's fine. The website will see the update.

[libvirt] [jenkins-ci PATCH 3/3] guests: Add python3-setuptools to the base project

2019-10-09 Thread Fabiano Fidêncio
python3-setuptools is an ansible pip module dependency, which is not automatically pulled in. Signed-off-by: Fabiano Fidêncio --- guests/vars/projects/base.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index

[libvirt] [jenkins-ci PATCH 2/3] mappings: Add python3-setuptools

2019-10-09 Thread Fabiano Fidêncio
python3-setuptools is an ansible pip module dependency, which is not automatically pulled in. Signed-off-by: Fabiano Fidêncio --- guests/vars/mappings.yml | 4 1 file changed, 4 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index ba0f1cf..02bf8fd 100644

Re: [libvirt] [jenkins-ci PATCH] guests: Install EPEL on CentOS 7 container

2019-10-09 Thread Fabiano Fidêncio
On Wed, Oct 9, 2019 at 6:03 PM Daniel P. Berrangé wrote: > > On Wed, Oct 09, 2019 at 05:52:27PM +0200, Fabiano Fidêncio wrote: > > Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to > > have both "ninja" and "python36-*" packages in the system. > > > > However, we've forgot to

[libvirt] [dockerfiles PATCH] Refresh after recent changes to Python handling

2019-10-09 Thread Andrea Bolognani
The corresponding libvirt-jenkins-ci commit is 1ec59b56598b. Signed-off-by: Andrea Bolognani --- Pushed under the Dockerfile refresh rule. Plain-text diff below. buildenv-libosinfo-centos-7.zip | Bin 532 -> 546 bytes buildenv-libosinfo-debian-10.zip | Bin 638 -> 646

Re: [libvirt] [PATCH v3 01/12] conf: add replug option for usb hostdev

2019-10-09 Thread Jonathon Jongsma
On Tue, 2019-09-17 at 16:47 +0300, Nikolay Shirokovskiy wrote: > If usb device attached to a domain is unplugged from host and > then plugged back then it will no longer be available in guest. > We are going to support this case so that device will be detached > from qemu on unplug and attached

Re: [libvirt] [PATCH 0/2] qemu: Add support for host-model pseries machine option

2019-10-09 Thread Fabiano Rosas
Daniel P. Berrangé writes: > What userspace tool is broken, and in what way ? The major use case, as far as I know, is from software license managers which use this to determine how much to charge for software. I would have to ask around to know exactly which ones and how they operate. >

[libvirt] [PATCH] conf: remove parse code for long-extinct "

2019-10-09 Thread Laine Stump
Back in July 2009, in the days before libvirt supported explicitly assigning a PCI address to every device, code was added to save the PCI addresses of hotplugged network, disk, and hostdevs in the domain status with this XML element: This was added in commits 4e21a95a, 01654107, in v0.7.0,

Re: [libvirt] [PATCH 2/2] qemu: Add support for pseries 'host-model' machine parameter

2019-10-09 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Tue, Oct 08, 2019 at 01:46:57PM -0300, Fabiano Rosas wrote: >> Since QEMU v4.0.0, the host's model is no longer automatically exposed >> to the guest via /proc/device-tree/host-model. There is now a machine >> option 'host-model' that allows an arbitrary string to

Re: [libvirt] [PATCH v2 1/3] qemu: use a bigger unplug timeout for PPC64 guests

2019-10-09 Thread Cole Robinson
On 9/11/19 5:05 PM, Daniel Henrique Barboza wrote: For some architectures and setups, device removal can take longer than the default 5 seconds. This results in commands such as 'virsh setvcpus' to fire timeout messages even if the operation were successful in the guest, confusing the user.

Re: [libvirt] [PATCH] conf: remove parse code for long-extinct "

2019-10-09 Thread Ján Tomko
Unmatched double quote in the commit summary On Wed, Oct 09, 2019 at 12:39:15PM -0400, Laine Stump wrote: Back in July 2009, in the days before libvirt supported explicitly assigning a PCI address to every device, code was added to save the PCI addresses of hotplugged network, disk, and

Re: [libvirt] [PATCH] libvirt_python:fix bug of sanitytest.py script

2019-10-09 Thread Cole Robinson
On 9/10/19 2:19 AM, oss...@puresoftware.com wrote: From: ossdev libvirt-python:fix bug of sanitytest.py script Hmm, what exactly is the bug you are hitting? Are you seeing an error? I don't exactly follow what the patch is achieving Signed-off-by: ossdev This needs to list your real

Re: [libvirt] [PATCH 03/30] storagefile: qcow1: Fix check for empty backing file

2019-10-09 Thread Daniel Henrique Barboza
On 10/7/19 6:49 PM, Cole Robinson wrote: >From f772b3d91fd the intention of this code seems to be to set Is this leading '>' a bogus? format=NONE when the image does not have a backing file. However 'buf' here is the whole qcow1 file header. What we want to be checking is 'res' which is

[libvirt] [PATCH] security: apparmor: Allow RO /usr/share/edk2/

2019-10-09 Thread Cole Robinson
On Fedora, already whitelisted paths to AAVMF and OVMF binaries are symlinks to binaries under /usr/share/edk2/. Add that directory to the RO whitelist so virt-aa-helper-test passes Signed-off-by: Cole Robinson --- I don't know if anyone is actually using apparmor on Fedora, but I have the libs

Re: [libvirt] [PATCH 1/4] qemu: validate bochs-display capability

2019-10-09 Thread Jonathon Jongsma
ping series On Fri, 2019-09-13 at 16:20 -0500, Jonathon Jongsma wrote: > When the bochs display type was added, the capability was never > checked. > Add that check in the same place as the other video device capability > checks. > > Signed-off-by: Jonathon Jongsma > --- >

[libvirt] [PATCH v5 1/1] tests: add a test for driver.c:virConnectValidateURIPath()

2019-10-09 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- tests/Makefile.am | 7 ++- tests/virdriverconnvalidatetest.c | 90 +++ 2 files changed, 96 insertions(+), 1 deletion(-) create mode 100644 tests/virdriverconnvalidatetest.c diff --git a/tests/Makefile.am

[libvirt] [PATCH v5 0/1] add test for driver.c:virConnectValidateURIPath()

2019-10-09 Thread Daniel Henrique Barboza
changes from v4: - other patches got merged, this is the last survivor - enhanced the code by attending to all suggestions from Cole Robinson v4: https://www.redhat.com/archives/libvir-list/2019-September/msg01164.html Daniel Henrique Barboza (1): tests: add a test for

  1   2   >