[libvirt] [PATCH] src: add missing include access path for bhyve and vz drivers

2019-11-08 Thread Pavel Hrdina
Commit forgot to update bhyve and vz Makefile files as well. Signed-off-by: Pavel Hrdina --- Pushed under build-breaker rule. src/bhyve/Makefile.inc.am | 1 + src/vz/Makefile.inc.am| 1 + 2 files changed, 2 insertions(+) diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am

Re: [libvirt] [PATCH v2 0/2] qemu: fix type of default video device

2019-11-08 Thread Pavel Mores
Hi, could someone please take a look at this so that I can move on with it? Thanks, pvl On Fri, Oct 18, 2019 at 12:27:20PM +0200, Pavel Mores wrote: > This new version mostly integrates Cole's comments about the first version. > > Pavel Mores (2): > qemu: fix type of default video

Re: [libvirt] [jenkins-ci PATCH v2] Add python3-docutils package for libvirt

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 06:08:06PM +0100, Andrea Bolognani wrote: > On Fri, 2019-11-08 at 14:29 +, Daniel P. Berrangé wrote: > > This is needed to acquire the rst2html command line tool > > > > Signed-off-by: Daniel P. Berrangé > > --- > > guests/vars/mappings.yml | 5 + > >

Re: [libvirt] [jenkins-ci PATCH v2] Add python3-docutils package for libvirt

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 14:29 +, Daniel P. Berrangé wrote: > This is needed to acquire the rst2html command line tool > > Signed-off-by: Daniel P. Berrangé > --- > guests/vars/mappings.yml | 5 + > guests/vars/projects/libvirt.yml | 1 + > 2 files changed, 6 insertions(+)

Re: [libvirt] [PATCH 2/5] news: Support unmanaged macvtap devices in 5.8

2019-11-08 Thread Laine Stump
On 11/8/19 2:00 AM, Han Han wrote: Signed-off-by: Han Han --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 88affb66a3..c0fd006a77 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -189,6 +189,18 @@ +

Re: [libvirt] [PATCH v4 00/20] cleanup current build system

2019-11-08 Thread Laine Stump
make rpm is now broken. I'm making a rash assumption something in this series is the cause (if I have time in the morning I'll investigate further) + /usr/bin/mkdir -p /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs + cp -pr AUTHORS

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-08 Thread Jonathon Jongsma
Thanks for the thorough review Michal, clearly it needs more work. In particular, I was not yet aware of the private xml save/restore stuff. Thanks for the pointers in that regard. But I have one particular question below: On Fri, 2019-11-08 at 11:46 +0100, Michal Privoznik wrote: > 1: It's not

[libvirt] [PATCH v4 07/20] [ACKED] po: rewrite the way how we generate files

2019-11-08 Thread Pavel Hrdina
There was no need to handle files for translation from build directory but that will change with following patches where we will stop generating source files into source directory. In order to have them included for translation we have to prefix each file with SRCDIR or BUILDDIR. Signed-off-by:

[libvirt] [PATCH v4 20/20] [ACKED] tools: stop distributing generated source files

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- tools/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 68320c7246..1a541a3984 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -84,7 +84,6

[libvirt] [PATCH v4 19/20] [ACKED] src: stop distributing generated source files

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- src/Makefile.am | 6 +++--- src/access/Makefile.inc.am | 3 ++- src/admin/Makefile.inc.am | 13 +++-- src/bhyve/Makefile.inc.am | 1 + src/esx/Makefile.inc.am

[libvirt] [PATCH v4 04/20] [ACKED] syntax-check.mk: cleanup sc_po_check dependencies

2019-11-08 Thread Pavel Hrdina
Introduce new rule 'generated-sources' as a helper for PO files check to make sure that all generated files are prepared and to not duplicate the list on different places. This will be used as a dependency for sc_po_check rule instead of duplicated list of generated files. Signed-off-by: Pavel

[libvirt] [PATCH v4 15/20] [ACKED] src: locking: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore - modify generated_files for sc_po_check as well .gitignore | 1 - build-aux/syntax-check.mk | 2 +-

[libvirt] [PATCH v4 16/20] [ACKED] src: logging: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore - modify generated_files for sc_po_check as well .gitignore | 1 - build-aux/syntax-check.mk | 2 +-

[libvirt] [PATCH v4 18/20] [ACKED] src: remote: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore - modify generated_files for sc_po_check as well .gitignore | 2 -- build-aux/syntax-check.mk | 2 --

Re: [libvirt] [PATCH v3 1/6] rpc: use the return value of virObjectRef directly

2019-11-08 Thread Pavel Hrdina
On Fri, Nov 01, 2019 at 06:35:43PM +0100, Marc Hartmayer wrote: > Use the return value of virObjectRef directly. This way, it's easier > for another reader to identify the reason why the additional reference > is required. > > Signed-off-by: Marc Hartmayer > Reviewed-by: John Ferlan > --- >

Re: [libvirt] [PATCH v3 2/6] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

2019-11-08 Thread Pavel Hrdina
On Fri, Nov 01, 2019 at 06:35:44PM +0100, Marc Hartmayer wrote: > The commit 'close callback: move it to driver' (88f09b75eb99) moved > the responsibility for the close callback to the driver. But if the > driver doesn't support the connectRegisterCloseCallback API this > function does nothing,

Re: [libvirt] [PATCH v4 01/20] build: mandate use of a build dir != src dir

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 04:42:02PM +0100, Pavel Hrdina wrote: > Historically we've allowed builds in the main src dir, but meson does > not support this. Explicitly force separate build dir in autotools to > align with meson. We must re-enable dependency tracking which the RPM > %configure macro

Re: [libvirt] [PATCH v4 06/20] po: generate files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 04:42:07PM +0100, Pavel Hrdina wrote: > Historically we did not support VPATH builds and everything was > generated into source directory. The introduction of VPATH builds > did not changed the way how our translation files are handled. > > This patch changes the rules to

Re: [libvirt] [PATCH v4 06/20] po: generate files into build directory

2019-11-08 Thread Pavel Hrdina
On Fri, Nov 08, 2019 at 03:51:25PM +, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 04:42:07PM +0100, Pavel Hrdina wrote: > > Historically we did not support VPATH builds and everything was > > generated into source directory. The introduction of VPATH builds > > did not changed the way

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:49:23PM +0100, Christian Borntraeger wrote: > > > On 08.11.19 12:43, Daniel P. Berrangé wrote: > > On Mon, Nov 04, 2019 at 11:49:01AM +0100, David Hildenbrand wrote: > >> On 02.11.19 11:32, Daniel P. Berrangé wrote: > >>> On Fri, Nov 01, 2019 at 06:43:16PM +0100,

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 11:24 +, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 12:15:53PM +0100, Andrea Bolognani wrote: > > On Fri, 2019-11-08 at 10:04 +, Daniel P. Berrangé wrote: > > > Moving this HAVE_GNU_GETTEXT_TOOLS conditional means that on OS that > > > lack the GNU gettext

Re: [libvirt] [PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108101655.10611-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [libvirt] [jenkins-ci PATCH 0/5] Add Fedora 31, drop Fedora 29

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 10:42 +0100, Fabiano Fidêncio wrote: > On Fri, Nov 8, 2019 at 9:24 AM Erik Skultety wrote: > > On Thu, Nov 07, 2019 at 07:51:56PM +0100, Andrea Bolognani wrote: > > > Andrea Bolognani (5): > > > guests: Explicitly enable ssh root login in kickstart > > > guests: Add

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 01:56:47PM +0100, Christian Borntraeger wrote: > > > On 08.11.19 12:52, Daniel P. Berrangé wrote: > > On Fri, Nov 08, 2019 at 12:49:23PM +0100, Christian Borntraeger wrote: > >> > >> > >> On 08.11.19 12:43, Daniel P. Berrangé wrote: > >>> On Mon, Nov 04, 2019 at

Re: [libvirt] [PATCH 5/5] news: Introduce virConnectSetIdentity API in 5.8

2019-11-08 Thread Jiri Denemark
On Fri, Nov 08, 2019 at 15:00:22 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 571a1b6ea4..c37d0d22ef 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -199,6

Re: [libvirt] [PATCH v3 01/20] build: mandate use of a build dir != src dir

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:19PM +0200, Pavel Hrdina wrote: > From: Daniel P. Berrangé > > Historically we've allowed builds in the main src dir, but meson does > not support this. Explicitly force separate build dir in autotools to > align with meson. We must re-enable dependency tracking

Re: [libvirt] [PATCH v3 02/20] .gitignore: cleanup old and obsolete ignores

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:20PM +0200, Pavel Hrdina wrote: > Now that we forbid builds in source directory we can remove a lot of > ignores that are created during build time. To make the cleanup easier > in the future create a sections in our .gitignore file. > > Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCH v3 20/20] tools: stop distributing generated source files

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:38PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > tools/Makefile.am | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH v3 19/20] src: stop distributing generated source files

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:37PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > src/Makefile.am | 6 +++--- > src/access/Makefile.inc.am | 3 ++- > src/admin/Makefile.inc.am | 13 +++-- > src/bhyve/Makefile.inc.am

Re: [libvirt] [PATCH v3 17/20] src: lxc: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:35PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > - modify generated_files for sc_po_check as well > > .gitignore| 2 --

Re: [libvirt] [PATCH v3 16/20] src: logging: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:34PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > - modify generated_files for sc_po_check as well > > .gitignore | 1

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 10:04 +, Daniel P. Berrangé wrote: > On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > > -endif HAVE_GNU_GETTEXT_TOOLS > > - > > if ENABLE_NLS > > > > # Cannot use 'localedir' since this conflicts with autoconf. > > @@ -99,7 +104,7 @@ install-data-hook:

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Daniel P . Berrangé
On Mon, Nov 04, 2019 at 11:49:01AM +0100, David Hildenbrand wrote: > On 02.11.19 11:32, Daniel P. Berrangé wrote: > > On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: > > > On the KVM forum I have discussed the default cpu model mode on s390. > > > Right now if the xml does

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Christian Borntraeger
On 08.11.19 12:43, Daniel P. Berrangé wrote: > On Mon, Nov 04, 2019 at 11:49:01AM +0100, David Hildenbrand wrote: >> On 02.11.19 11:32, Daniel P. Berrangé wrote: >>> On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: On the KVM forum I have discussed the default cpu

Re: [libvirt] [jenkins-ci PATCH] Add python-docutils package for libvirt

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 11:22 +, Daniel P. Berrangé wrote: > +++ b/guests/vars/mappings.yml > @@ -795,6 +795,11 @@ mappings: > + python-docutils: The mapping should be called python3-docutils... > +default: python3-docutils > +CentOS7: python2-docutils ... and should install

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Christian Borntraeger
On 08.11.19 12:52, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 12:49:23PM +0100, Christian Borntraeger wrote: >> >> >> On 08.11.19 12:43, Daniel P. Berrangé wrote: >>> On Mon, Nov 04, 2019 at 11:49:01AM +0100, David Hildenbrand wrote: On 02.11.19 11:32, Daniel P. Berrangé wrote:

Re: [libvirt] [jenkins-ci PATCH 1/5] guests: Explicitly enable ssh root login in kickstart

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 09:22 +0100, Erik Skultety wrote: > On Thu, Nov 07, 2019 at 07:51:57PM +0100, Andrea Bolognani wrote: > > Both CentOS and Fedora have had this enabled by default up until > > now, but that's no longer the case as of Fedora 31. Enabling it > > explicitly makes the first

Re: [libvirt] [PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-11-08 at 13:16 +0300, Vladimir Sementsov-Ogievskiy wrote: > v2: > Don't deprecate drive-backup, it is unrelated thing and will be resent > in separate. > Don't deprecate drive-mirror. Instead add filter-node-name to > drive-mirror to behave like blockdev-mirror > Fix all broken

Re: [libvirt] [PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
Something strange, I don't think it related to patchset. 08.11.2019 15:00, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20191108101655.10611-1-vsement...@virtuozzo.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the >

Re: [libvirt] [PATCH v2 07/39] qemu: Explicitly add/remove /dev/vfio/vfio to/from NS/CGroups

2019-11-08 Thread Michal Privoznik
On 10/18/19 12:10 AM, Cole Robinson wrote: On 9/26/19 12:12 PM, Michal Privoznik wrote: In near future, the decision what to do with /dev/vfio/vfio with respect to domain namespace and CGroup is going to be moved out of qemuDomainGetHostdevPath() because there will be some other types of

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Christian Borntraeger
On 08.11.19 14:10, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 01:56:47PM +0100, Christian Borntraeger wrote: >> >> >> On 08.11.19 12:52, Daniel P. Berrangé wrote: >>> On Fri, Nov 08, 2019 at 12:49:23PM +0100, Christian Borntraeger wrote: On 08.11.19 12:43, Daniel P.

Re: [libvirt] [PATCH v2 2/2] qapi: deprecate implicit filters

2019-11-08 Thread Peter Krempa
On Fri, Nov 08, 2019 at 13:16:55 +0300, Vladimir Sementsov-Ogievskiy wrote: > To get rid of implicit filters related workarounds in future let's > deprecate them now. > > Deprecation warning breaks some bash iotests output, so fix it here > too: in most of cases just add filter-node-name in test.

Re: [libvirt] [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror

2019-11-08 Thread Peter Krempa
On Fri, Nov 08, 2019 at 13:16:54 +0300, Vladimir Sementsov-Ogievskiy wrote: > To correspond to blockdev-mirror command and make it possible to > deprecate implicit filters in the next commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 7 +++ > blockdev.c

Re: [libvirt] [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-08 Thread Max Reitz
On 07.11.19 20:13, Vladimir Sementsov-Ogievskiy wrote: > 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: >> Hi Markus, >> >> On 8/15/19 7:40 PM, John Snow wrote: >>> On 8/15/19 10:16 AM, Markus Armbruster wrote: John Snow writes: >> [...] > I asked Markus this not too long ago; do we

Re: [libvirt] [PATCH v3 13/20] src: esx: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:31PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > > .gitignore | 1 - > src/esx/Makefile.inc.am | 5 +++-- >

Re: [libvirt] [PATCH v3 14/20] src: hyperv: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:32PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > > .gitignore | 1 - > src/hyperv/Makefile.inc.am | 5 +++--

Re: [libvirt] [PATCH v3 15/20] src: locking: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:33PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > - modify generated_files for sc_po_check as well > > .gitignore | 1

Re: [libvirt] [PATCH 5/5] news: Introduce virConnectSetIdentity API in 5.8

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 10:47:52AM +0100, Jiri Denemark wrote: > On Fri, Nov 08, 2019 at 15:00:22 +0800, Han Han wrote: > > Signed-off-by: Han Han > > --- > > docs/news.xml | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/docs/news.xml b/docs/news.xml > > index

Re: [libvirt] [PATCH v3 03/20] syntax-check.mk: fix sc_po_check rule

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:21PM +0200, Pavel Hrdina wrote: > Commit <22d8e27ccd5faf48ee2bf288a1b9059aa7ffd28b> introduced our > syntax-check.mk file based on gnulib rules. However, the rule was > completely ignored as we don't have POTFILES.in file. Yikes, we've got quite out of date as a

Re: [libvirt] [PATCH v3 04/20] syntax-check.mk: cleanup sc_po_check dependencies

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:22PM +0200, Pavel Hrdina wrote: > Introduce new rule 'generated-sources' as a helper for PO files check > to make sure that all generated files are prepared and to not duplicate > the list on different places. This will be used as a dependency for > sc_po_check rule

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > Historically we did not support VPATH builds and everything was > generated into source directory. The introduction of VPATH builds > did not changed the way how our translation files are handled. > > This patch changes the rules to

Re: [libvirt] [PATCH 5/5] news: Introduce virConnectSetIdentity API in 5.8

2019-11-08 Thread Han Han
Well, excluding developers and testers, few people use libvirt directly by APIs. Since libvirt is also a library, it is worthwhile to mention updates on public APIs in release notes even it is supposed for internal implementation. On Fri, Nov 8, 2019 at 5:47 PM Jiri Denemark wrote: > On Fri,

Re: [libvirt] [PATCH v3 07/20] po: rewrite the way how we generate files

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:25PM +0200, Pavel Hrdina wrote: > There was no need to handle files for translation from build directory > but that will change with following patches where we will stop > generating source files into source directory. > > In order to have them included for

[libvirt] [PATCH] qemu_process: fix starting VMs if machine group has limited cpuset.cpus

2019-11-08 Thread Pavel Hrdina
Commit reworked process affinity setting but did not take cgroups into account which introduced an issue when starting VM with custom cpuset.cpus for the whole machine group. If the machine group is limited to some pCPUs libvirt should not try to set a VM to run on all pCPUs as it will result in

[libvirt] [PATCH 1/6] docs: split TLS certificate setup into its own file

2019-11-08 Thread Daniel P . Berrangé
The generation and deployment of x509 certificates for TLS is complex and verbose and thus deserves its own standalone page. Signed-off-by: Daniel P. Berrangé --- docs/docs.html.in | 3 + docs/remote.html.in | 408 + docs/tlscerts.html.in | 413

[libvirt] [PATCH 4/6] docs: adapt filling of section for rst2html output

2019-11-08 Thread Daniel P . Berrangé
The HTML from rst2html doesn't have immediately under the tag, instead there is at least one in between. There are also many things added in the section that we don't want to have copied over, since our templating system already adds suitable elements. We only need to copy the

[libvirt] [PATCH 3/6] build: introduce rst2html as a mandatory build tool

2019-11-08 Thread Daniel P . Berrangé
The rst2html tool is provided by python docutils, and as the name suggests, it converts RST documents into HTML. This enables us to start writing docs on our website in RST format instead of HTML, without changing the rest of our website templating system away from XSLT yet. Signed-off-by:

[libvirt] [PATCH 5/6] docs: add a kbase page about RPM packaging options

2019-11-08 Thread Daniel P . Berrangé
The libvirt RPM packaging is quite fine grained but it is not obvious to users which package is best to install. Add a kbase doc that describes the different RPMs, and illustrates some example deployment use cases. Signed-off-by: Daniel P. Berrangé --- .gitignore| 1 +

[libvirt] [PATCH 0/6] docs: some refactoring and new docs about RPM deployment

2019-11-08 Thread Daniel P . Berrangé
This refactors existing docs related to the remote driver/daemon and URIs. It then also adds a kbase page about RPM package options. This introduces the use of RST for docs as a replacement for HTML. The intent is that all new docs should use RST from this point. Existing HTML docs are

[libvirt] [jenkins-ci PATCH] Add python-docutils package for libvirt

2019-11-08 Thread Daniel P . Berrangé
This is needed to acquire the rst2html command line tool Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 5 + guests/vars/projects/libvirt.yml | 1 + 2 files changed, 6 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index

[libvirt] [PATCH 6/6] docs: add page describing the libvirt daemons

2019-11-08 Thread Daniel P . Berrangé
Now that we have more than just the libvirtd daemon, we should be explaining to users what they are all for & important aspects of their configuration. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 7 +- docs/daemons.rst | 209 ++

[libvirt] [PATCH 2/6] docs: move docs about remote driver URIs into URI docs

2019-11-08 Thread Daniel P . Berrangé
The docs about remote URIs in uri.html are somewhat sparse with the full docs being in remote.html. Move all the URI content from remote.html into uri.html so the user only needs to look in one place for URI info. Signed-off-by: Daniel P. Berrangé --- docs/remote.html.in | 278

Re: [libvirt] [jenkins-ci PATCH 1/5] guests: Explicitly enable ssh root login in kickstart

2019-11-08 Thread Erik Skultety
On Thu, Nov 07, 2019 at 07:51:57PM +0100, Andrea Bolognani wrote: > Both CentOS and Fedora have had this enabled by default up until > now, but that's no longer the case as of Fedora 31. Enabling it > explicitly makes the first connection work as expected on the > newer distributions without

Re: [libvirt] [jenkins-ci PATCH 0/5] Add Fedora 31, drop Fedora 29

2019-11-08 Thread Erik Skultety
On Thu, Nov 07, 2019 at 07:51:56PM +0100, Andrea Bolognani wrote: > You know the drill :) > > Andrea Bolognani (5): > guests: Explicitly enable ssh root login in kickstart > guests: Add Fedora 31 > Start building on Fedora 31 > Stop building on Fedora 29 > guests: Drop Fedora 29

Re: [libvirt] [PATCH v3 09/20] remote: unify rpc server dispatch generated files

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:27PM +0200, Pavel Hrdina wrote: > Our naming was not consistent. Use the protocol name as prefix for all > generated files. > > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - modify generated_files in for

Re: [libvirt] [PATCH v3 08/20] po: README.md: add a note about which Zanata client is required

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:26PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > > Notes: > New in v3. > > po/README.md | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/po/README.md b/po/README.md > index

Re: [libvirt] [PATCH v3 18/20] src: remote: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:36PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > - modify generated_files for sc_po_check as well > > .gitignore | 2

[libvirt] [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
To correspond to blockdev-mirror command and make it possible to deprecate implicit filters in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 7 +++ blockdev.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
07.11.2019 21:52, Philippe Mathieu-Daudé wrote: > Hi Markus, > > On 8/15/19 7:40 PM, John Snow wrote: >> On 8/15/19 10:16 AM, Markus Armbruster wrote: >>> John Snow writes: > [...] I asked Markus this not too long ago; do we want to amend the QAPI schema specification to allow commands

[libvirt] [PATCH v2 2/2] qapi: deprecate implicit filters

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
To get rid of implicit filters related workarounds in future let's deprecate them now. Deprecation warning breaks some bash iotests output, so fix it here too: in most of cases just add filter-node-name in test. In 161 add FIXME and deprecation warning into 161.out. In 249, the test case is

[libvirt] [PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
v2: Don't deprecate drive-backup, it is unrelated thing and will be resent in separate. Don't deprecate drive-mirror. Instead add filter-node-name to drive-mirror to behave like blockdev-mirror Fix all broken iotests. Vladimir Sementsov-Ogievskiy (2): qapi: add filter-node-name option to

Re: [libvirt] Deprecating stuff for 4.2

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
08.11.2019 9:41, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: > [...] >>> Pre-release period, time to deprecate some stuffs :) >>> >>> How should we proceed? Do you have something in mind? >>> >>> There are older threads

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-08 Thread Michal Privoznik
On 11/6/19 10:13 PM, Jonathon Jongsma wrote: Some layered products such as oVirt have requested a way to avoid being blocked by guest agent commands when querying a loaded vm. For example, many guest agent commands are polled periodically to monitor changes, and rather than blocking the calling

Re: [libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

2019-11-08 Thread Michal Privoznik
On 11/7/19 6:29 PM, Jonathon Jongsma wrote: On Thu, 2019-11-07 at 14:19 +0100, Michal Privoznik wrote: The qemuDomainGetStatsIOThread() accesses the monitor by calling qemuDomainGetIOThreadsMon(). And it's also marked as "need monitor" in qemuDomainGetStatsWorkers[]. However, it's not checking

Re: [libvirt] [jenkins-ci PATCH 0/5] Add Fedora 31, drop Fedora 29

2019-11-08 Thread Fabiano Fidêncio
On Fri, Nov 8, 2019 at 9:24 AM Erik Skultety wrote: > > On Thu, Nov 07, 2019 at 07:51:56PM +0100, Andrea Bolognani wrote: > > You know the drill :) > > > > Andrea Bolognani (5): > > guests: Explicitly enable ssh root login in kickstart > > guests: Add Fedora 31 > > Start building on Fedora

Re: [libvirt] [PATCH v3 05/20] syntax-check.mk: cleanup generated_files list for sc_po_check

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:23PM +0200, Pavel Hrdina wrote: > Move generated_files variable closer to the sc_po_check rule and > remove non-existent gnulib internal path. > > Signed-off-by: Pavel Hrdina > --- > > Notes: > New in v2. > > build-aux/syntax-check.mk | 20

Re: [libvirt] [PATCH v3 10/20] src: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:28PM +0200, Pavel Hrdina wrote: > This affects more than src/Makefile.am as the rule to generate source > files for protocols is generic for all sub-directories. > > Affected files are: > src/admin/admin_protocol.{h,c} > src/locking/lock_protocol.{h,c} >

Re: [libvirt] [PATCH v3 11/20] src: access: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:29PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > > .gitignore | 7 --- > po/POTFILES.in | 3 +++ >

Re: [libvirt] [PATCH v3 12/20] src: admin: generate source files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:30PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Ján Tomko > --- > > Notes: > Changes in v2: > - remove entries from .gitignore > - modify generated_files for sc_po_check as well > > .gitignore| 2 --

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

2019-11-08 Thread Han Han
On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik wrote: > On 10/15/19 7:23 AM, Han Han wrote: > > Hi Michal, > > Any more advice update? > > Well, as I've said earlier, since we document that -1 is accepted value > and it means that it suppresses automatic reboots we need a way to > preserve

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-08 Thread Daniel P . Berrangé
On Wed, Nov 06, 2019 at 03:13:21PM -0600, Jonathon Jongsma wrote: > Some layered products such as oVirt have requested a way to avoid being > blocked by guest agent commands when querying a loaded vm. For example, > many guest agent commands are polled periodically to monitor changes, > and rather

Re: [libvirt] [PATCH v6] util: Set SIGPIPE to a no-op handler in virFork

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 08:25:15AM +0800, Wang Yechao wrote: > Libvirtd has set SIGPIPE to ignored, and virFork resets all signal > handlers to the defaults. But child process may write logs to > stderr/stdout, that may generate SIGPIPE if journald has stopped. > > So set SIGPIPE to a dummy no-op

Re: [libvirt] [PATCH v3 00/52] qemu: Store default CPU in domain XML

2019-11-08 Thread Christian Borntraeger
As discussed, does it make sense to add the default change to host-model for s390 in this series or should that be a separate patch? On 05.11.19 14:26, Jiri Denemark wrote: > When starting a domain without a CPU model specified in the domain XML, > QEMU will choose a default one. Which is fine

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:15:53PM +0100, Andrea Bolognani wrote: > On Fri, 2019-11-08 at 10:04 +, Daniel P. Berrangé wrote: > > On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > > > -endif HAVE_GNU_GETTEXT_TOOLS > > > - > > > if ENABLE_NLS > > > > > > # Cannot use

Re: [libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

2019-11-08 Thread Michal Privoznik
On 11/8/19 4:05 PM, Jonathon Jongsma wrote: On Fri, 2019-11-08 at 10:44 +0100, Michal Privoznik wrote: On 11/7/19 6:29 PM, Jonathon Jongsma wrote: On Thu, 2019-11-07 at 14:19 +0100, Michal Privoznik wrote: The qemuDomainGetStatsIOThread() accesses the monitor by calling

[libvirt] [PATCH v4 00/20] cleanup current build system

2019-11-08 Thread Pavel Hrdina
As preparation to switch to Meson there are some things that needs be cleaned up to make the conversion easier. The important thing in Meson is that there is a strict separation between source and build directory and the distributed tarball by default contains only files tracked by git with a

[libvirt] [PATCH v4 09/20] [ACKED] remote: unify rpc server dispatch generated files

2019-11-08 Thread Pavel Hrdina
Our naming was not consistent. Use the protocol name as prefix for all generated files. Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - modify generated_files in for sc_po_check as well build-aux/syntax-check.mk

[libvirt] [PATCH v4 01/20] build: mandate use of a build dir != src dir

2019-11-08 Thread Pavel Hrdina
Historically we've allowed builds in the main src dir, but meson does not support this. Explicitly force separate build dir in autotools to align with meson. We must re-enable dependency tracking which the RPM %configure macro turns off. Without this, the build dir doesn't get the source directory

[libvirt] [PATCH v4 14/20] [ACKED] src: hyperv: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore .gitignore | 1 - src/hyperv/Makefile.inc.am | 5 +++-- src/hyperv/hyperv_wmi_generator.py | 11

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 02:29:15PM +0100, Christian Borntraeger wrote: > > > On 08.11.19 14:10, Daniel P. Berrangé wrote: > > On Fri, Nov 08, 2019 at 01:56:47PM +0100, Christian Borntraeger wrote: > >> > >> > >> On 08.11.19 12:52, Daniel P. Berrangé wrote: > >>> On Fri, Nov 08, 2019 at

[libvirt] [PATCH v4 11/20] [ACKED] src: access: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore .gitignore | 7 --- po/POTFILES.in | 3 +++ src/access/Makefile.inc.am | 14

[libvirt] [PATCH v4 08/20] [ACKED] po: README.md: add a note about which Zanata client is required

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrangé --- Notes: New in v3. po/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/po/README.md b/po/README.md index 71b5793a2d..2f77c5d48c 100644 --- a/po/README.md +++ b/po/README.md @@ -4,6 +4,9 @@ Libvirt Message

[libvirt] [PATCH v4 02/20] [ACKED] .gitignore: cleanup old and obsolete ignores

2019-11-08 Thread Pavel Hrdina
Now that we forbid builds in source directory we can remove a lot of ignores that are created during build time. To make the cleanup easier in the future create a sections in our .gitignore file. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrangé --- Notes: New in v2.

[libvirt] [PATCH v4 10/20] [ACKED] src: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
This affects more than src/Makefile.am as the rule to generate source files for protocols is generic for all sub-directories. Affected files are: src/admin/admin_protocol.{h,c} src/locking/lock_protocol.{h,c} src/logging/log_protocol.{h,c} src/lxc/lxc_monitor_protocol.{h,c}

[libvirt] [PATCH v4 17/20] [ACKED] src: lxc: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore - modify generated_files for sc_po_check as well .gitignore| 2 -- build-aux/syntax-check.mk | 1 -

[libvirt] [PATCH v4 03/20] [ACKED] syntax-check.mk: fix sc_po_check rule

2019-11-08 Thread Pavel Hrdina
Commit <22d8e27ccd5faf48ee2bf288a1b9059aa7ffd28b> introduced our syntax-check.mk file based on gnulib rules. However, the rule was completely ignored as we don't have POTFILES.in file. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrangé --- Notes: New in v2.

[libvirt] [PATCH v4 05/20] [ACKED] syntax-check.mk: cleanup generated_files list for sc_po_check

2019-11-08 Thread Pavel Hrdina
Move generated_files variable closer to the sc_po_check rule and remove non-existent gnulib internal path. Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrangé --- Notes: New in v2. build-aux/syntax-check.mk | 20 ++-- 1 file changed, 10 insertions(+), 10

[libvirt] [PATCH v4 12/20] [ACKED] src: admin: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore - modify generated_files for sc_po_check as well .gitignore| 2 -- build-aux/syntax-check.mk | 1 - po/POTFILES.in

[libvirt] [PATCH v4 13/20] [ACKED] src: esx: generate source files into build directory

2019-11-08 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko Reviewed-by: Daniel P. Berrangé --- Notes: Changes in v2: - remove entries from .gitignore .gitignore | 1 - src/esx/Makefile.inc.am | 5 +++-- src/esx/esx_vi_generator.py | 11 ---

[libvirt] [PATCH v4 06/20] po: generate files into build directory

2019-11-08 Thread Pavel Hrdina
Historically we did not support VPATH builds and everything was generated into source directory. The introduction of VPATH builds did not changed the way how our translation files are handled. This patch changes the rules to generate everything into build directory and stops distributing

  1   2   >