On Tue, Jan 14, 2020 at 04:22:39PM +0100, Pavel Hrdina wrote:
On Fri, Jan 10, 2020 at 03:41:15PM +, Daniel P. Berrangé wrote:
gmtime_r/localtime_r are mostly used in combination with
strftime to format timestamps in libvirt. This can all
be replaced with GDateTime resulting in simpler code
Signed-off-by: Han Han
---
docs/manpages/virsh.rst | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index c637caa583..92f113fbde 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -4391,9
virDomainUpdateDeviceFlags has been introduced since v0.8.0. There is no
reason to use virDomainAttachDevice* API to update media for cdrom or
floopy device.
https://bugzilla.redhat.com/show_bug.cgi?id=1788793
Signed-off-by: Han Han
---
src/qemu/qemu_hotplug.c | 12
1 file
Signed-off-by: Han Han
---
src/libvirt-domain.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index eb66999f07..a6a246c3a4 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8208,10 +8208,6 @@ virDomainAttachDevice(virDomainPtr
Signed-off-by: Han Han
---
src/libxl/libxl_driver.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index f021ec9c5d..b481e950da 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -3030,8 +3030,10
https://bugzilla.redhat.com/show_bug.cgi?id=1788793
Before virDomainUpdateDeviceFlags, virDomainAttachDevice* were used for
media update. Now we have introduced virDomainUpdateDeviceFlags for 9
years(since commit 46a2ea3689) but keep that compatibility of
virDomainAttachDevice* until now.
I
On Wed, Jan 15, 2020 at 04:24:54PM +0800, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1788793
>
> Before virDomainUpdateDeviceFlags, virDomainAttachDevice* were used for
> media update. Now we have introduced virDomainUpdateDeviceFlags for 9
> years(since commit 46a2ea3689) but
Cole Robinson writes:
Hi,
> On 12/5/19 12:11 PM, Arnaud Patard wrote:
>> When emulating smartcard with host certificates, qemu needs to
>> be able to read the certificates files. Add necessary code to
>> add the smartcard certificates file path to the apparmor profile.
>>
>> Passthrough
On Fri, Jan 10, 2020 at 03:41:11PM +, Daniel P. Berrangé wrote:
> We don't need all the platforms gnulib deals with, so
> this is a cut down version of GNULIB's physmem.c
> code. This also allows us to integrate libvirt's
> error reporting functions closer to the error cause.
>
>
On Wed, Jan 15, 2020 at 03:45:50PM +0100, Tomasz Barański wrote:
> Hello,
>
> I'm looking for a way to read guest memory usage information (RAM used,
> RAM available) for VMs with balloon driver disabled.
>
> oVirt used to read that information using ovirt guest agent, but OGA is no
> longer
Since libvirt commit 82fe58ff libvirt has been formatting the network
mask to the dnsmasq's dhcp-range config option which broke a few of the
networking tests.
Signed-off-by: Erik Skultety
---
scripts/networks/networkxml2hostout/tck-testnet-1.dat | 2 +-
libvirt's has been defining private chains within iptables for a while,
only putting a target labels inside the master FORWARD chain which broke
the networking test suite which wasn't adjusted accordingly.
Signed-off-by: Erik Skultety
---
.../networks/networkxml2hostout/tck-testnet-1.dat|
Erik Skultety (3):
network: Fix the iptables FORWARD chain name being queried
network: Fix the dhcp range output being matched
nwfilter: Fix the expected output from ebtables
.../networks/networkxml2hostout/tck-testnet-1.dat | 5 +++--
.../networks/networkxml2hostout/tck-testnet-2.dat |
Hello,
I'm looking for a way to read guest memory usage information (RAM used,
RAM available) for VMs with balloon driver disabled.
oVirt used to read that information using ovirt guest agent, but OGA is no
longer used (and not even available for RHEL8).
I've seen that there was a discussion
On 1/15/20 9:23 AM, Thomas Huth wrote:
The "ps2" bus is only available on certain machines like x86. On
machines like s390x, we should refuse to add a device to this bus
instead of silently ignoring it.
Looking at the QEMU sources, PS/2 is only available if the QEMU binary
has the "i8042"
On 1/15/20 9:23 AM, Thomas Huth wrote:
The "ps2" bus is only available on certain machines like x86. On
machines like s390x, we should refuse to add a device to this bus
instead of silently ignoring it.
Looking at the QEMU sources, PS/2 is only available if the QEMU binary
has the "i8042"
Feature has been deprecated since 4.1 (4bb4a273),
remove it.
As result if RAM distribution wasn't specified explicitly,
the machine won't start and CLI should be changed to explicitly
assign RAM to nodes using options:
-node node,memdev (5.0 and newer machine types)
-node node,mem (4.2
Deprecation period is ran out and it's a time to flip the switch
introduced by cd5ff8333a.
Disable legacy option for new machine types and amend documentation.
Signed-off-by: Igor Mammedov
---
CC: peter.mayd...@linaro.org
CC: ehabk...@redhat.com
CC: marcel.apfelb...@gmail.com
CC: m...@redhat.com
On Tue, 2020-01-14 at 18:21 +0100, Andrea Bolognani wrote:
> Note that I have not actually had the time to confirm this fixes
> the problem, or to reproduce it in the first place (I'll do that
> tomorrow).
I haven't been able to reproduce the issue in a fully up to date
Fedora 31 ppc64le guest,
For some reason, some of the PTP link addresses didn't specify the
/128 prefix explicitly which fails the pattern matching in the nwfilter
tests.
Signed-off-by: Erik Skultety
---
.../nwfilter/nwfilterxml2fwallout/ipv6-test.fwall| 12 ++--
1 file changed, 6 insertions(+), 6
On Fri, Jan 10, 2020 at 03:41:09PM +, Daniel P. Berrangé wrote:
> Windows sockets take a SOCKET HANDLE object instead of a
> file descriptor. Wrap them in the same way that gnulib
> does so that they use C runtime file descriptors.
>
> While we could in theory use GSocket, it is hard to get
>
Signed-off-by: Ján Tomko
---
configure.ac | 2 +-
docs/news.xml | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 002a3dcdb0..8837928358 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ dnl You should have received a copy
If virHostdevManagerGetDefault in qemuhotplugtest fails it works
for quite a while to later segfault when accessing
mgr->activePCIHostdevs.
Report the error details and break on a failed init to see the
real issue right away.
Signed-off-by: Christian Ehrhardt
---
tests/qemuhotplugtest.c | 5
After debugging for a while and eventually finding the root cause we
discussed this on IRC today:
danpb: BTW the test crash in 6.0 that I'm tracing (asked yesterday)
is virHostdevManagerInitialize failing
the test goes on with mgr set to 0x0 and that is the segfault
later
In certain build environments (e.g. Debian and Ubuntu) $HOME is set
to a non existing path intentionally. That breaks and crashes
qemuhotplugtest by failing the init in virHostdevManagerGetDefault.
Avoid that issue by mocking the virFileMakePath behavior if it is
passed a path that matches $HOME
As planned the release is available, tagged in git, and the signed
tarball and source rpm are available from the usual place:
https://libvirt.org/sources/
I also made the release of the pythn bindings which can be found at:
https://libvirt.org/sources/python/
This release carries some
On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote:
> Deprecation period is ran out and it's a time to flip the switch
> introduced by cd5ff8333a.
> Disable legacy option for new machine types and amend documentation.
>
> Signed-off-by: Igor Mammedov
> ---
> CC: peter.mayd...@linaro.org
On Wed, 15 Jan 2020 16:34:53 +0100
Peter Krempa wrote:
> On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote:
> > Deprecation period is ran out and it's a time to flip the switch
> > introduced by cd5ff8333a.
> > Disable legacy option for new machine types and amend documentation.
> >
>
FYI, I'm intending to make this change tomorrow (Thursday Jan 16th)
On Fri, Jan 10, 2020 at 12:26:07PM +, Daniel P. Berrangé wrote:
> Hi List Subscribers,
>
> In recent months we have been seeing an increasing number of bounced
> deliveries from libvirt mailing lists[1] due to DMARC policies
On Thu, Jan 09, 2020 at 03:53:10PM +0100, Pavel Hrdina wrote:
> This patch series is motivated by the effort to adopt Meson as our
> build system but all of it improves the current build system on its own.
>
> It moves the burden to run bootstrap/autoreconf to developers which
> means it will
On 1/15/20 1:37 PM, Christian Ehrhardt wrote:
If virHostdevManagerGetDefault in qemuhotplugtest fails it works
for quite a while to later segfault when accessing
mgr->activePCIHostdevs.
Report the error details and break on a failed init to see the
real issue right away.
Signed-off-by:
On 1/15/20 1:37 PM, Christian Ehrhardt wrote:
In certain build environments (e.g. Debian and Ubuntu) $HOME is set
to a non existing path intentionally. That breaks and crashes
qemuhotplugtest by failing the init in virHostdevManagerGetDefault.
Avoid that issue by mocking the virFileMakePath
From: Dan Zheng
Some APIs are only supported from new version. This is to compare
the current running version to the supporting version in order to
decide if one test should be skipped.
Signed-off-by: Dan Zheng
---
lib/Sys/Virt/TCK.pm | 15 +++
1 file changed, 15 insertions(+)
On Tue, Jan 14, 2020 at 06:21:33PM +0100, Andrea Bolognani wrote:
> In particular, we're interested in the following commits:
>
> commit 43b5194d5b156f8dd7ae576952568d331978f5f0
> Author: Bruno Haible
> Date: Sun Jan 5 20:42:12 2020 +0100
>
> tests: Avoid GCC over-optimization
The "ps2" bus is only available on certain machines like x86. On
machines like s390x, we should refuse to add a device to this bus
instead of silently ignoring it.
Looking at the QEMU sources, PS/2 is only available if the QEMU binary
has the "i8042" device, so let's check for that and only allow
On Fri, Jan 10, 2020 at 03:41:10PM +, Daniel P. Berrangé wrote:
> Convert to use socket wrappers. Aside from the header file
> include change, this requires changing close -> closesocket
> since our portability isn't trying to replace the close
> function.
>
> Signed-off-by: Daniel P.
36 matches
Mail list logo
