Re: [libvirt PATCH v2 6/8] tests: Add test case for the armvtimer timer

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:06PM +0100, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- .../clock-timer-armvtimer.aarch64-latest.args | 32 +++ .../clock-timer-armvtimer.xml | 27 tests/qemuxml2argvtest.c | 2 ++

Re: [libvirt PATCH v2 7/8] docs: List the armvtimer timer among all others

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:07PM +0100, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 44e2062d01..3e899ffe4e 100644 ---

Re: [PATCH v3 06/15] qemuDomainValidateStorageSource: Reject unsupported slices

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:17PM +0100, Peter Krempa wrote: We will currently support slice only for the 'raw' format slice reject format slice. Reject any other option. any other option. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 12 1 file changed, 12

Re: [PATCH v3 01/15] qemu: domain: Refactor formatting of node names into status XML

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:12PM +0100, Peter Krempa wrote: Use virXMLFormatElement to simplify the logic. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [PATCH v3 08/15] docs: Document the new sub-element of disk's

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:19PM +0100, Peter Krempa wrote: We are going to add support for specifying offset and size attributes which will allow controling where the image and where the guest data itself starts in the source of the disk. This will be represented by a element filled with

Re: [libvirt PATCH v2 2/8] qemu: Add the QEMU_CAPS_CPU_KVM_NO_ADJVTIME capability

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:02PM +0100, Andrea Bolognani wrote: We will use this capability to detect whether the QEMU binary supports the kvm-no-adjvtime CPU feature. Reviewed-by: Ján Tomko Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 2 ++

Re: [libvirt PATCH v2 3/8] conf: Introduce VIR_DOMAIN_TIMER_NAME_ARMVTIMER

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:03PM +0100, Andrea Bolognani wrote: This new timer model will be used to control the behavior of the virtual timer for KVM ARM/virt guests. Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 1 +

Re: [PATCH v3 09/15] conf: Implement support for of disk source

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:20PM +0100, Peter Krempa wrote: Implement parsing and formatting of the 'source' and 'format' slices. s/'source' and 'format'/'storage'/ Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 86 ++ 1 file changed, 86

Re: [libvirt PATCH v2 1/8] qemu: Use switch statement in qemuBuildCpuCommandLine()

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:01PM +0100, Andrea Bolognani wrote: Make sure we are taking all possible virDomainTimerNameType values into account. This will make upcoming changes easier. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 34 -- 1 file

Re: [PATCH v3 07/15] qemu: block: forbid creation of storage sources with

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:18PM +0100, Peter Krempa wrote: Specifically creating such images via libvirt during blockjobs would be much more hassle than it's worth. Just forbid them for now. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH v3 03/15] tests: virstorage: Add test data for json specified raw image with offset/size

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:14PM +0100, Peter Krempa wrote: QEMU allows specifying the offset and size into a raw file to expose a sub-slice of the image to the guest with the raw driver. Libvirt currently doesn't support it but we can add test case for future reference. Signed-off-by: Peter

[PATCH] apparmor: allow to call vhost-user-gpu

2020-02-13 Thread Christian Ehrhardt
Configuring vhost-user-gpu like: Triggers an apparmor denial like: apparmor="DENIED" operation="exec" profile="libvirtd" name="/usr/lib/qemu/vhost-user-gpu" pid=888257 comm="libvirtd" requested_mask="x" denied_mask="x" fsuid=0 ouid=0 This helper is provided by

Re: [PATCH v3 02/15] docs: formatdomain: Close on one of disk examples

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:13PM +0100, Peter Krempa wrote: Signed-off-by: Peter Krempa Missing Reviewed-by tag from v2 of this series. Also, you could have pushed it already since it's independent. Jano --- docs/formatdomain.html.in | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt PATCH v2 8/8] news: Mention the armvtimer timer

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:08PM +0100, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH v2 4/8] qemu: Validate configuration for the armvtimer timer

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:04PM +0100, Andrea Bolognani wrote: Its use is limited to certain guest types, and it only supports a subset of all possible tick policies. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 33 + 1 file changed, 33

Re: [libvirt PATCH v2 5/8] qemu: Format the armvtimer timer on the command line

2020-02-13 Thread Ján Tomko
On Fri, Feb 07, 2020 at 03:27:05PM +0100, Andrea Bolognani wrote: Its behavior is controlled by a KVM-specific CPU feature. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 13 + 1 file changed, 13 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH v3 04/15] util: virstoragefile: Add data structure for storing storage source slices

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:15PM +0100, Peter Krempa wrote: Introduce virStorageSourceSlice which will store the 'offset' and 'size' of a virStorageSource and declare it as 'sliceStorage' and 'sliceFormat' attributes of a virStorageSource. Signed-off-by: Peter Krempa ---

Re: [rust PATCH 1/3] Implement virStoragePoolListAllVolumes and virStoragePoolListVolumes for StoragePool

2020-02-13 Thread Sahid Orentino Ferdjaoui
On Mon, Feb 10, 2020 at 01:38:04PM +, math...@pius.io wrote: > From: Mathias Pius > > --- > src/storage_pool.rs | 54 ++- > tests/storage_pool.rs | 34 +++ > 2 files changed, 87 insertions(+), 1 deletion(-) Sounds good thank

Re: [PULL 00/10] Ui 20200212 patches

2020-02-13 Thread Peter Maydell
On Wed, 12 Feb 2020 at 16:18, Gerd Hoffmann wrote: > > The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging > (2020-02-10 18:09:14 +) > > are available in the Git

Re: [PATCH v3 05/15] qemuBlockStorageSourceGetFormatRawProps: format 'offset' and 'size' for slice

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:16PM +0100, Peter Krempa wrote: If we have a 'format' type slice for a raw driver we can directly format the values. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v3 13/15] qemu: Add support for slices of type 'storage'

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:24PM +0100, Peter Krempa wrote: Implement support for the slice of type 'storage' which allows to set the offset and size which modifies where qemu should look for the start of the format container inside the image. Since slicing is done using the 'raw' driver we

Re: [libvirt PATCH v2 4/8] qemu: Validate configuration for the armvtimer timer

2020-02-13 Thread Andrea Bolognani
On Thu, 2020-02-13 at 14:28 +0100, Ján Tomko wrote: > On Fri, Feb 07, 2020 at 03:27:04PM +0100, Andrea Bolognani wrote: > > +++ b/src/qemu/qemu_domain.c > > @@ -5430,6 +5430,39 @@ qemuDomainDefValidateClockTimers(const virDomainDef > > *def, > > break; > > > > case

Re: [libvirt PATCH v2 6/8] tests: Add test case for the armvtimer timer

2020-02-13 Thread Andrea Bolognani
On Thu, 2020-02-13 at 14:30 +0100, Ján Tomko wrote: > On Fri, Feb 07, 2020 at 03:27:06PM +0100, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > .../clock-timer-armvtimer.aarch64-latest.args | 32 +++ > > .../clock-timer-armvtimer.xml | 27

Re: [PATCH v3 15/15] virStorageSourceParseBackingJSONRaw: Parse 'offset' and 'size' attributes

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:26PM +0100, Peter Krempa wrote: If the parsed 'raw' format JSON string has 'offset' or 'size' attributes parse them as the format slice. https://bugzilla.redhat.com/show_bug.cgi?id=1791788 Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 20

Re: [libvirt PATCH v2 3/8] conf: Introduce VIR_DOMAIN_TIMER_NAME_ARMVTIMER

2020-02-13 Thread Andrea Bolognani
On Thu, 2020-02-13 at 14:26 +0100, Ján Tomko wrote: > On Fri, Feb 07, 2020 at 03:27:03PM +0100, Andrea Bolognani wrote: > > +++ b/src/conf/domain_conf.c > > @@ -1063,6 +1063,7 @@ VIR_ENUM_IMPL(virDomainTimerName, > > "tsc", > > "kvmclock", > >

Re: [PATCH v3 10/15] qemu: domain: Store nodenames of slice in status XML

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:21PM +0100, Peter Krempa wrote: The storage slice will require a specific node name in cases when the image format is not raw. Store and format them in the status XML. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c| 7 +++

Re: [PATCH v3 14/15] tests: qemu: Add test data for the new element

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:25PM +0100, Peter Krempa wrote: Signed-off-by: Peter Krempa --- .../disk-slices.x86_64-latest.args| 53 ++ tests/qemuxml2argvdata/disk-slices.xml| 45 +++ tests/qemuxml2argvtest.c | 2 +

Re: [PATCH v3 11/15] qemu: block: Properly format storage slice into backing store strings

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:22PM +0100, Peter Krempa wrote: When creating overlay images e.g. for snapshots or when merging snapshots we often specify the backing store string to use. Make the formatter aware of backing chain entries which have a configured so that we record it properly.

Re: [PATCH v3 12/15] tests: qemublock: Add cases for creating image overlays on top of disks with

2020-02-13 Thread Ján Tomko
On Wed, Feb 12, 2020 at 07:03:23PM +0100, Peter Krempa wrote: Add a set of test data to see whether the backing store strings are formatted reasonably. Note that we don't support direct creation of such images so those tests are not enabled. Signed-off-by: Peter Krempa ---