Re: GSoC'20 Interested Student: Adding support to Jailhouse Hypervisor

2020-03-24 Thread PRAKHAR BANSAL
Hi Jan, Thanks for the reply. I looked deeper into the libvirt and Jailhouse source code and found following two things that seem relevant to the project I am interested in. - Libvirt driver interface at [libvirt.git] / src

Re: [libvirt PATCH v2 7/9] gitlab: add variable for make command name

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > To facilitate future jobs that will use FreeBSD > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.yml | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) As mentioned, this should be the very first patch in

Re: [libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > We don't need the full git history when running CI jobs. From a code POV > we only need the most recent commit, but we want to be able to run > checks on the commits too. In particular to validate the DCO signoff for > each commit. >

Re: [PATCH v4 0/6] NVDIMM suport for pSeries guests

2020-03-24 Thread Michal Prívozník
On 23. 3. 2020 20:40, Daniel Henrique Barboza wrote: > changes in v4: > - moved label size requirement from virDomainMemoryDefParseXML() > to virDomainMemoryDefValidate() > > Previous version: > https://www.redhat.com/archives/libvir-list/2020-March/msg00769.html > > Daniel Henrique Barboza

Re: [libvirt-tck] scripts: fix disk media change test

2020-03-24 Thread Daniel P . Berrangé
On Mon, Mar 23, 2020 at 05:09:24PM -0600, Jim Fehlig wrote: > Since the introduction of the 'index' attribute of a disk's > element, test 207-disk-media-change.t is failing. The > test is a bit flawed in that it compares initial and final domXML > after changing the media of a cdrom disk device.

Re: [libvirt-tck] scripts: fix disk media change test

2020-03-24 Thread Erik Skultety
On Mon, Mar 23, 2020 at 05:09:24PM -0600, Jim Fehlig wrote: > Since the introduction of the 'index' attribute of a disk's > element, test 207-disk-media-change.t is failing. The > test is a bit flawed in that it compares initial and final domXML > after changing the media of a cdrom disk device.

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-24 Thread Jiri Denemark
On Mon, Mar 23, 2020 at 15:47:49 -0600, Jim Fehlig wrote: > The domain capabilities documentation contains a small but confusing > error in the host-model CPU description, referencing the element > instead of . Fix this small typo. > > Signed-off-by: Jim Fehlig > --- > > I only found this

Re: [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration

2020-03-24 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > On Tue, Mar 24, 2020 at 05:29:59AM +0800, Alex Williamson wrote: > > On Mon, 3 Jun 2019 20:34:22 -0400 > > Yan Zhao wrote: > > > > > On Tue, Jun 04, 2019 at 03:29:32AM +0800, Alex Williamson wrote: > > > > On Thu, 30 May 2019 20:44:38 -0400 > > > > Yan

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Daniel P . Berrangé
On Tue, Mar 24, 2020 at 07:24:39AM +, Ani Sinha wrote: > Hi All : > > I have been playing with Qemu trying to disable hot-unplug capability for > conventional PCI. I have discussed this briefly on IRC and the plan is to > have an option on the pci-pci bridge that would disable SHPC and ACPI

Re: [PATCH] util: virhostcpu: Fail when fetching CPU Stats for invalid cpu

2020-03-24 Thread Michal Prívozník
On 21. 2. 2020 19:10, Mauro S. M. Rodrigues wrote: > virHostCPUGetStatsLinux walks through every cpu in /proc/stat until it > finds cpu%cpuNum that matches with the requested cpu. > If none is found it logs the error but it should return -1, instead of 0. > Otherwise virsh nodecpustats --cpu and

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Ani Sinha
> On Mar 24, 2020, at 2:53 PM, Daniel P. Berrangé wrote: > > This is a patch against QEMU actually. Oops! Yes sorry, not sure what I was thinking. Yes this is Qemu. I will resend the email in Qemu-devel mailing list. ani

Re: [PATCH 5/6] virprocess: Passthru error from virProcessRunInForkHelper

2020-03-24 Thread Daniel P . Berrangé
On Wed, Mar 18, 2020 at 06:32:15PM +0100, Michal Privoznik wrote: > When running a function in a forked child, so far the only thing > we could report is exit status of the child and the error > message. However, it may be beneficial to the caller to know the > actual error that happened in the

Re: [PATCH 5/6] virprocess: Passthru error from virProcessRunInForkHelper

2020-03-24 Thread Pino Toscano
On Tuesday, 24 March 2020 11:48:17 CET Daniel P. Berrangé wrote: > On Wed, Mar 18, 2020 at 06:32:15PM +0100, Michal Privoznik wrote: > > When running a function in a forked child, so far the only thing > > we could report is exit status of the child and the error > > message. However, it may be

Re: [PATCH RESEND 2/5] qemuProcessStartManagedPRDaemon: Don't pass -f pidfile to the daemon

2020-03-24 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2020 at 6:48 PM Michal Prívozník wrote: > > On 23. 3. 2020 17:36, Marc-André Lureau wrote: > > Hi > > > > On Mon, Mar 23, 2020 at 5:16 PM Michal Privoznik > > wrote: > >> > >> Now, that our virCommandSetPidFile() is more intelligent we don't > >> need to rely on the daemon

Re: [PATCH 03/14] virDomainDiskSourceNVMeFormat: Format only valid 'managed' values

2020-03-24 Thread Michal Prívozník
On 23. 3. 2020 19:11, Peter Krempa wrote: > VIR_TRISTATE_BOOL_ABSENT which maps to the 'default' string would not be > parsed back, so we shouldn't format it either. > > Signed-off-by: Peter Krempa > --- > src/conf/domain_conf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [PATCH 03/14] virDomainDiskSourceNVMeFormat: Format only valid 'managed' values

2020-03-24 Thread Peter Krempa
On Tue, Mar 24, 2020 at 12:38:58 +0100, Michal Privoznik wrote: > On 23. 3. 2020 19:11, Peter Krempa wrote: > > VIR_TRISTATE_BOOL_ABSENT which maps to the 'default' string would not be > > parsed back, so we shouldn't format it either. > > > > Signed-off-by: Peter Krempa > > --- > >

Re: [PATCH] commandtest: Fix test28 error detection

2020-03-24 Thread Daniel P . Berrangé
On Tue, Mar 24, 2020 at 01:54:35PM +0100, Michal Privoznik wrote: > As a part of c799d150d5e9dae I've introduced a test case that > tests whether passing error object between processes works. The > test spawns a child which reports a system error, parent process > then reads the error and compares

[PATCH] qemu_monitor_text.c: Use g_autofree

2020-03-24 Thread Seeteena Thoufeek
Signed-off-by: Seeteena Thoufeek --- src/qemu/qemu_monitor_text.c | 85 1 file changed, 30 insertions(+), 55 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 9135a11..5a890af 100644 ---

Re: [PATCH] qemu_monitor_text.c: Use g_autofree

2020-03-24 Thread Daniel Henrique Barboza
On 3/24/20 9:44 AM, Seeteena Thoufeek wrote: Signed-off-by: Seeteena Thoufeek --- Reviewed-by: Daniel Henrique Barboza

Re: [PATCH v1 1/4] qemu_domain.c: do not launch ppc64 guests with APIC-EOI setting

2020-03-24 Thread Daniel Henrique Barboza
On 3/23/20 2:45 PM, Andrea Bolognani wrote: On Mon, 2020-03-23 at 14:21 -0300, Daniel Henrique Barboza wrote: On 3/23/20 2:01 PM, Andrea Bolognani wrote: This is https://bugzilla.redhat.com/show_bug.cgi?id=1236440 Please include the Bugzilla URL for other patches in the series as

Re: [PATCH v1 3/4] qemu_domain.c: do not launch ppc64 guests with 'pmu' setting

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 09:27 -0300, Daniel Henrique Barboza wrote: > Andrea, I see that the behavior of the 'panic' device in the ppc64 XML is to > always add a: > > > > Even if I remove it Libvirt will automatically added it back again. How do you > suggest we handle this PMU? > > We can

Re: [PATCH v1 3/4] qemu_domain.c: do not launch ppc64 guests with 'pmu' setting

2020-03-24 Thread Daniel Henrique Barboza
On 3/23/20 9:34 PM, David Gibson wrote: On Mon, Mar 23, 2020 at 06:28:34PM +0100, Andrea Bolognani wrote: On Thu, 2020-03-19 at 18:44 -0300, Daniel Henrique Barboza wrote: The Perfomance Monitoring Unit (PMU) feature is not available for the Power architecture. The "" feature will always

Re: [PATCH 03/14] virDomainDiskSourceNVMeFormat: Format only valid 'managed' values

2020-03-24 Thread Michal Prívozník
On 24. 3. 2020 13:12, Peter Krempa wrote: > > Well, the issue is when the virStorageSource is created from the backing > store rather than parsed from XML which is added later on. > Should have a source post parse callback then? Anyway, Reviewed-by: Michal Privoznik for whole series. Michal

Re: [PATCH] qemu_monitor_text.c: Use g_autofree

2020-03-24 Thread Michal Prívozník
On 24. 3. 2020 13:51, Daniel Henrique Barboza wrote: > > > On 3/24/20 9:44 AM, Seeteena Thoufeek wrote: >> Signed-off-by: Seeteena Thoufeek >> --- > > > Reviewed-by: Daniel Henrique Barboza > Pushed now. Michal

Re: [PATCH v1 3/4] qemu_domain.c: do not launch ppc64 guests with 'pmu' setting

2020-03-24 Thread Daniel Henrique Barboza
On 3/24/20 11:00 AM, Andrea Bolognani wrote: On Tue, 2020-03-24 at 09:27 -0300, Daniel Henrique Barboza wrote: Andrea, I see that the behavior of the 'panic' device in the ppc64 XML is to always add a: [...] For the sake of completeness, I'll also mention that we can simply allow to

[PATCH] commandtest: Fix test28 error detection

2020-03-24 Thread Michal Privoznik
As a part of c799d150d5e9dae I've introduced a test case that tests whether passing error object between processes works. The test spawns a child which reports a system error, parent process then reads the error and compares with expected output. Problem with this approach is that error message

Re: [PATCH 5/6] virprocess: Passthru error from virProcessRunInForkHelper

2020-03-24 Thread Michal Prívozník
On 24. 3. 2020 11:52, Pino Toscano wrote: > On Tuesday, 24 March 2020 11:48:17 CET Daniel P. Berrangé wrote: >> IIUC the problem here is that the STREQ check is assuming that the >> ENODATA errno results in the string "No data available". The strings >> are not standardized by POSIX AFAIK, so C

Re: [PATCH v1 3/4] qemu_domain.c: do not launch ppc64 guests with 'pmu' setting

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 11:05 -0300, Daniel Henrique Barboza wrote: > On 3/24/20 11:00 AM, Andrea Bolognani wrote: > > On Tue, 2020-03-24 at 09:27 -0300, Daniel Henrique Barboza wrote: > > > For the sake of completeness, I'll also mention that we can simply allow > > > to be > > > declared in the

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-24 Thread Jim Fehlig
On 3/24/20 3:44 AM, Jiri Denemark wrote: On Mon, Mar 23, 2020 at 15:47:49 -0600, Jim Fehlig wrote: The domain capabilities documentation contains a small but confusing error in the host-model CPU description, referencing the element instead of . Fix this small typo. Signed-off-by: Jim Fehlig

Re: [PATCH v1 1/4] qemu_domain.c: do not launch ppc64 guests with APIC-EOI setting

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 10:22 -0300, Daniel Henrique Barboza wrote: > On 3/23/20 2:45 PM, Andrea Bolognani wrote: > > On Mon, 2020-03-23 at 14:21 -0300, Daniel Henrique Barboza wrote: > > > And while we're at it, something that just occurred to me, I'll also gate > > > the ppc64 > > > only

Re: [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration

2020-03-24 Thread Alex Williamson
On Tue, 24 Mar 2020 09:23:31 + "Dr. David Alan Gilbert" wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > On Tue, Mar 24, 2020 at 05:29:59AM +0800, Alex Williamson wrote: > > > On Mon, 3 Jun 2019 20:34:22 -0400 > > > Yan Zhao wrote: > > > > > > > On Tue, Jun 04, 2019 at 03:29:32AM

[PATCH 6/7] vbox: move video default logic to driver

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code. Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 2 -- src/vbox/vbox_common.c | 16 2 files changed, 16 insertions(+), 2 deletions(-) diff --git

[PATCH 1/7] bhyve: move video default logic to driver

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code. Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_domain.c | 5 + src/conf/domain_conf.c | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_domain.c

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-24 Thread Daniel P . Berrangé
On Tue, Mar 24, 2020 at 04:41:20PM +0100, Andrea Bolognani wrote: > On Mon, 2020-03-23 at 15:16 +, Daniel P. Berrangé wrote: > > On Mon, Mar 23, 2020 at 04:00:17PM +0100, Andrea Bolognani wrote: > > > Since we're going to need a FreeBSD machine configured as a GitLab > > > runner, wouldn't it

[PATCH 2/7] libxl: move video default logic to driver

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code. Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 2 +- src/libxl/libxl_domain.c | 60 2 files changed, 37 insertions(+), 25 deletions(-) diff

[PATCH 7/7] conf: domain_conf: remove virDomainVideoDefaultType

2020-03-24 Thread Rafael Fonseca
The logic has been moved to the individual drivers. Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 35 --- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - 3 files changed, 4 insertions(+), 33 deletions(-) diff --git

[PATCH 3/7] vz: openvz: move video default logic to driver

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code. Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 4 src/openvz/openvz_conf.c | 8 src/vz/vz_driver.c | 8 3 files changed, 16 insertions(+), 4 deletions(-)

[PATCH 4/7] vmx: vmware: move video default logic to driver

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code. Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 2 -- src/vmware/vmware_driver.c | 4 src/vmx/vmx.c | 4 3 files changed, 8 insertions(+), 2 deletions(-)

[PATCH 5/7] test: move video default logic to driver

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code. Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 10 +- src/test/test_driver.c | 23 +++ 2 files changed, 24 insertions(+), 9 deletions(-) diff --git

[libvirt PATCH v2 3/9] gitlab: group jobs into stages

2020-03-24 Thread Daniel P . Berrangé
Within a stage all jobs run in parallel. Stages are ordered so later stages are only executed if previous stages succeeded. By using separate stages for the cross builds, we can avoid wasting CI resources if the relatively simple website build fails. Later we can avoid running cross builds, if the

Re: [PATCH] qemu: softfail for TCG capabilities probe

2020-03-24 Thread Ján Tomko
[please wrap the lines to something sensible like 72 columns, especially in the commit message] On a Monday in 2020, Tobin Feldman-Fitzthum wrote: As of version 2.10, QEMU can be built without the TCG. When libvirt determines that capabilities of a QEMU binary using QMP, it launches a QEMU

[libvirt PATCH v2 1/9] gitlab: use CI for building website contents

2020-03-24 Thread Daniel P . Berrangé
Run the bare minimum build that is possible to create the docs. Ideally the '--without-remote' arg would be passed, but there are several bugs preventing a build from succeeding without the remote driver built. The generated website is published as an artifact and thus is browsable on build

[libvirt PATCH v2 2/9] gitlab: reduce number of cross-build CI jobs

2020-03-24 Thread Daniel P . Berrangé
We're going to add more build jobs to CI, and users have limited time granted on the shared CI runners. The number of cross-build jobs currently present is not sustainable, so cut it down to two interesting jobs to cover big endian and 32-bit platform variants. Signed-off-by: Daniel P. Berrangé

[libvirt PATCH v2 9/9] gitlab: add job for building latest potfile

2020-03-24 Thread Daniel P . Berrangé
Whenever there is a change to the translatable strings we need to push a new libvirt.pot to weblate. This only needs to be done when code merges into git master, so the job is restricted to that branch. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 26 ++ 1 file

Re: [libvirt PATCH v2 0/9] gitlab: expand the CI job coverage (RESEND)

2020-03-24 Thread Daniel P . Berrangé
On Tue, Mar 24, 2020 at 04:23:56PM +, Daniel P. Berrangé wrote: > There are main goals with this series > > - Introduce a minimal job building the website and publishing > an artifact which can be deployed onto libvirt.org > - Introduce a minimal job building the libvirt.pot for

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-24 Thread Andrea Bolognani
On Mon, 2020-03-23 at 15:16 +, Daniel P. Berrangé wrote: > On Mon, Mar 23, 2020 at 04:00:17PM +0100, Andrea Bolognani wrote: > > Since we're going to need a FreeBSD machine configured as a GitLab > > runner, wouldn't it make sense for us to also create one or more > > Linux machines that would

[PATCH 0/7] Move video default logic to individual drivers

2020-03-24 Thread Rafael Fonseca
The logic setting a device default should be in the post parse function of individual driver code, not in `src/conf/domain_conf.c`. Rafael Fonseca (7): bhyve: move video default logic to driver libxl: move video default logic to driver vz: openvz: move video default logic to driver vmx:

[libvirt PATCH v2 7/9] gitlab: add variable for make command name

2020-03-24 Thread Daniel P . Berrangé
To facilitate future jobs that will use FreeBSD Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 58abcbe1f3..9814b6580a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@

[libvirt PATCH v2 0/9] gitlab: expand the CI job coverage (RESEND)

2020-03-24 Thread Daniel P . Berrangé
There are main goals with this series - Introduce a minimal job building the website and publishing an artifact which can be deployed onto libvirt.org - Introduce a minimal job building the libvirt.pot for import into Weblate (only runs on git master branch) - Expanding CI jobs to

[libvirt PATCH v2 5/9] gitlab: add mingw cross build CI jobs

2020-03-24 Thread Daniel P . Berrangé
This pulls in the mingw cross build jobs using Fedora 30 as a base, matching what is done on Jenkins and Travis. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 8 1 file changed, 8 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 563b126662..329374a34f 100644

[libvirt PATCH v2 4/9] gitlab: rename the cross build jobs

2020-03-24 Thread Daniel P . Berrangé
The pipeline UI will truncate the names of jobs after about 15 characters. As a result with the cross-builds, we truncate the most important part of the job name. Putting the most important part first is robust against truncation, and we can drop the redundant "-cross" stub. Reviewed-by: Erik

[libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

2020-03-24 Thread Daniel P . Berrangé
This patch adds x86_64 native CI jobs for all distros that we currently build container images for. This is a superset of the Linux jobs run on current Jenkins and Travis platforms. The remaining missing platforms are FreeBSD and macOS, neither of which can use the shared runner container based

[libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits

2020-03-24 Thread Daniel P . Berrangé
We don't need the full git history when running CI jobs. From a code POV we only need the most recent commit, but we want to be able to run checks on the commits too. In particular to validate the DCO signoff for each commit. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 1 + 1 file

[libvirt PATCH] docs: news: fix typo

2020-03-24 Thread Ján Tomko
s/ommited/omitted/ Signed-off-by: Ján Tomko --- Pushed as trivial docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 504cf52738..bcec1d81e9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -51,7 +51,7 @@

Re: [libvirt PATCH v2 1/9] gitlab: use CI for building website contents

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:23 +, Daniel P. Berrangé wrote: > Run the bare minimum build that is possible to create the docs. Ideally > the '--without-remote' arg would be passed, but there are several bugs > preventing a build from succeeding without the remote driver built. This comment is no

Re: [libvirt PATCH v2 2/9] gitlab: reduce number of cross-build CI jobs

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:23 +, Daniel P. Berrangé wrote: > We're going to add more build jobs to CI, and users have limited time > granted on the shared CI runners. The number of cross-build jobs > currently present is not sustainable, so cut it down to two interesting > jobs to cover big

Re: [libvirt PATCH v2 3/9] gitlab: group jobs into stages

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:23 +, Daniel P. Berrangé wrote: > Within a stage all jobs run in parallel. Stages are ordered so later > stages are only executed if previous stages succeeded. By using separate > stages for the cross builds, we can avoid wasting CI resources if the > relatively simple

Re: [libvirt PATCH v2 4/9] gitlab: rename the cross build jobs

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > The pipeline UI will truncate the names of jobs after about 15 > characters. As a result with the cross-builds, we truncate the > most important part of the job name. Putting the most important > part first is robust against

Re: [libvirt PATCH v2 5/9] gitlab: add mingw cross build CI jobs

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > This pulls in the mingw cross build jobs using Fedora 30 as a base, > matching what is done on Jenkins and Travis. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.yml | 8 > 1 file changed, 8 insertions(+)

[PATCH v2 3/4] qemu: make Hyperv settings exclusive to x86 and aarch64

2020-03-24 Thread Daniel Henrique Barboza
Hyperv features are supported by both x86 and aarch64. The declaration in the XML by itself is benign to other architectures, but any of its 14 current features will break QEMU with an error like this (from ppc64): qemu-kvm: Expected key=value format, found hv_relaxed This is a more extreme

[PATCH v2 1/4] qemu: avoid launching non-x86 guests with APIC-EOI setting

2020-03-24 Thread Daniel Henrique Barboza
The "" feature, although it's available only for x86 guests, can be declared in the domain XML of other archs without errors. But setting its 'eoi' attribute will break QEMU. For "", in a ppc64 guest: qemu-kvm: Expected key=value format, found +kvm_pv_eoi A similar error happens with eoi='off'.

[PATCH v2 2/4] qemu: avoid launching non-x86 guests with 'pvspinlock' setting

2020-03-24 Thread Daniel Henrique Barboza
The 'pvspinlock' feature is x86 only. The "" declaration will always have a value 'on' or 'off', and both will break QEMU when launching non-x86 guests. This is the error message for "" when running a ppc64 guest: qemu-kvm: Expected key=value format, found +kvm_pv_unhalt A similar error message

[PATCH v2 0/4] APIC-EOI, pvspinlock, hyperv and PMU changes

2020-03-24 Thread Daniel Henrique Barboza
Changes in v2: - changed patch series name to reflect the new approach - Make APIC-EIO exclusive to x86 - Make pvspinlock exclusive to x86 - Make hyperv exclusive to x86 and aarch64 - allow PMU to be declared as 'on' for ppc64 - previous version:

[PATCH v2 4/4] qemu: allow PMU feature to be enabled for ppc64 guests

2020-03-24 Thread Daniel Henrique Barboza
The PMU feature is enabled by default in ppc64 guests and can't be disabled via Libvirt or QEMU [1]. The current PMU feature implementation does not allow PMU to enabled or disabled in the ppc64 guest. Declaring the PMU feature will make the 'pmu' property to be passed on to QEMU, but this

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > To control the total CI execution time, we split the native jobs into > two distinct stages. A representative set of distros are used as the > primary native build sanity test, run for everyone regardless of whether > pre/post merge,

Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile

2020-03-24 Thread Andrea Bolognani
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > +# This artifact published by this job is downloaded to push to Weblate > +# for translation usage: > +# > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile > +potfile: > + stage: prebuild > + only:

Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile

2020-03-24 Thread Daniel P . Berrangé
On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > +# This artifact published by this job is downloaded to push to Weblate > > +# for translation usage: > > +# > >

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

2020-03-24 Thread Daniel P . Berrangé
On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > To control the total CI execution time, we split the native jobs into > > two distinct stages. A representative set of distros are used as the > > primary native

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-24 Thread Jim Fehlig
On 3/24/20 8:30 AM, Jim Fehlig wrote: On 3/24/20 3:44 AM, Jiri Denemark wrote: The situation on the first machine is a bit strange as there are no features disabled in host-model CPU definition, which makes it unclear why QEMU reports Cascadelake-Server as unusable (QEMU reports the reason, but

Re: [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration

2020-03-24 Thread Yan Zhao
On Tue, Mar 24, 2020 at 10:49:54PM +0800, Alex Williamson wrote: > On Tue, 24 Mar 2020 09:23:31 + > "Dr. David Alan Gilbert" wrote: > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > On Tue, Mar 24, 2020 at 05:29:59AM +0800, Alex Williamson wrote: > > > > On Mon, 3 Jun 2019 20:34:22

[libvirt PATCH] util: keep the pidfile locked

2020-03-24 Thread marcandre . lureau
From: Marc-André Lureau Unfortunately, advisory record locking lose the lock if any fd refering to the file is closed. There doesn't seem to be a way to preserve the lock atomically. We could eventually retake the lock if low pidfilefd is required. This fixes processes being leaked, as they are