Re: [PATCH 0/3] Support network interface downscript

2020-05-25 Thread Michal Privoznik
On 5/22/20 7:16 PM, Chen Hanxiao wrote: At 2020-05-22 23:09:21, "Michal Privoznik" wrote: On 5/21/20 3:59 PM, Chen Hanxiao wrote: QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-05-25 Thread Michal Privoznik
On 5/22/20 7:18 PM, Igor Mammedov wrote: On Fri, 22 May 2020 18:28:31 +0200 Michal Privoznik wrote: On 5/22/20 6:07 PM, Igor Mammedov wrote: On Fri, 22 May 2020 16:14:14 +0200 Michal Privoznik wrote: QEMU is trying to obsolete -numa node,cpus= because that uses ambiguous vCPU id to

Re: [PATCH 4/5] qemu_process.c: modernize qemuProcessUpdateCPU code path

2020-05-25 Thread Jiri Denemark
On Fri, May 22, 2020 at 16:56:19 -0300, Daniel Henrique Barboza wrote: > Use automatic cleanup on qemuProcessUpdateCPU and the functions called > by it. > > Signed-off-by: Daniel Henrique Barboza > --- > src/qemu/qemu_process.c | 50 ++--- > 1 file changed,

Re: [libvirt PATCH 0/3] cpu_map: Add Cooperlake x86 CPU model

2020-05-25 Thread Pavel Hrdina
On Sun, May 24, 2020 at 08:10:18PM +0200, Jiri Denemark wrote: > Jiri Denemark (3): > cputest: Add data for Cooperlake CPU > cpu_map: Add pschange-mc-no bit in IA32_ARCH_CAPABILITIES MSR > cpu_map: Add Cooperlake x86 CPU model Reviewed-by: Pavel Hrdina signature.asc Description: PGP

Re: [PATCH] Don't require secdrivers to implement .domainMoveImageMetadata

2020-05-25 Thread Christian Ehrhardt
On Mon, May 18, 2020 at 10:07 AM Michal Privoznik wrote: > > On 5/18/20 10:02 AM, Erik Skultety wrote: > > > Yes, I know, what I meant by "unrelated" here was just the fact that in > > order > > to fix Apparmor, you only need the first hunk, I guess I'll be more explicit > > next time :). It's

Re: [PATCH 3/5] cpu_s390.c: modernize virCPUs390Update

2020-05-25 Thread Jiri Denemark
On Fri, May 22, 2020 at 16:56:18 -0300, Daniel Henrique Barboza wrote: > Use automatic cleanup of variables. > > Signed-off-by: Daniel Henrique Barboza > --- > src/cpu/cpu_s390.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH 2/5] cpu_arm.c: modernize virCPUarmUpdate

2020-05-25 Thread Jiri Denemark
On Fri, May 22, 2020 at 16:56:17 -0300, Daniel Henrique Barboza wrote: > Use automatic cleanup of variables. > > Signed-off-by: Daniel Henrique Barboza > --- > src/cpu/cpu_arm.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH 1/5] cpu_conf.c: modernize virCPUDefCopyWithoutModel and virCPUDefCopy

2020-05-25 Thread Jiri Denemark
On Fri, May 22, 2020 at 16:56:16 -0300, Daniel Henrique Barboza wrote: > Use automatic cleanup of variables. > > Signed-off-by: Daniel Henrique Barboza > --- > src/conf/cpu_conf.c | 22 +++--- > 1 file changed, 7 insertions(+), 15 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH 5/5] qemuProcessUpdateCPU: do not change 'fallback' to ALLOW for pSeries guests

2020-05-25 Thread Jiri Denemark
On Fri, May 22, 2020 at 16:56:20 -0300, Daniel Henrique Barboza wrote: > Commit v3.10.0-182-g237f045d9a ("qemu: Ignore fallback CPU attribute > on reconnect") forced CPU 'fallback' to ALLOW, regardless of user > choice. This fixed a situation in which guests created with older > Libvirt versions,

Re: [PATCH 5/5] qemuProcessUpdateCPU: do not change 'fallback' to ALLOW for pSeries guests

2020-05-25 Thread Daniel Henrique Barboza
On 5/25/20 7:38 AM, Jiri Denemark wrote: On Fri, May 22, 2020 at 16:56:20 -0300, Daniel Henrique Barboza wrote: Commit v3.10.0-182-g237f045d9a ("qemu: Ignore fallback CPU attribute on reconnect") forced CPU 'fallback' to ALLOW, regardless of user choice. This fixed a situation in which

[PATCH v2 1/1] qemuProcessRefreshCPU: skip 'host-model' logic for pSeries guests

2020-05-25 Thread Daniel Henrique Barboza
Commit v3.10.0-182-g237f045d9a ("qemu: Ignore fallback CPU attribute on reconnect") forced CPU 'fallback' to ALLOW, regardless of user choice. This fixed a situation in which guests created with older Libvirt versions, which used CPU mode 'host-model' in runtime, would fail to launch in a newer

[PATCH v2 0/1] qemuProcessRefreshCPU: skip 'host-model' code

2020-05-25 Thread Daniel Henrique Barboza
changes in v2: - resending only patch 5/5 - changed the 'if' placement to qemuProcessRefreshCPU as suggested by Jiri Denemark - changed the commit msg to reflect the new intention of the patch link to v1: https://www.redhat.com/archives/libvir-list/2020-May/msg01049.html Daniel Henrique Barboza

[libvirt PATCH] scripts: Fix E741 that pycodesyle is pointing out during syntax-check

2020-05-25 Thread Erik Skultety
With newer pycodestyle 2.6.0 (which is part of flake8-3.8.2) reports the following pep violation during syntax-check: ../scripts/check-remote-protocol.py:95:9: E741 ambiguous variable name 'l' for l in err.strip().split("\n") On all the distros we test on, this hasn't occurred yet, but with

Re: [libvirt PATCH v2 5/6] hostcpu: Implement virHostCPUGetSignature for s390

2020-05-25 Thread Boris Fiuczynski
Thanks Jiri! Reviewed-by: Boris Fiuczynski On 5/22/20 11:15 AM, Jiri Denemark wrote: Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- src/util/virhostcpu.c | 21 ++- .../linux-s390x-with-frequency.signature | 1 + 2 files changed, 21

Re: [PATCH v2 1/1] qemuProcessRefreshCPU: skip 'host-model' logic for pSeries guests

2020-05-25 Thread Jiri Denemark
On Mon, May 25, 2020 at 09:39:45 -0300, Daniel Henrique Barboza wrote: > Commit v3.10.0-182-g237f045d9a ("qemu: Ignore fallback CPU attribute > on reconnect") forced CPU 'fallback' to ALLOW, regardless of user > choice. This fixed a situation in which guests created with older > Libvirt versions,

Re: [PATCH] Don't require secdrivers to implement .domainMoveImageMetadata

2020-05-25 Thread Michal Privoznik
On 5/25/20 1:14 PM, Christian Ehrhardt wrote: On Mon, May 18, 2020 at 10:07 AM Michal Privoznik wrote: On 5/18/20 10:02 AM, Erik Skultety wrote: Yes, I know, what I meant by "unrelated" here was just the fact that in order to fix Apparmor, you only need the first hunk, I guess I'll be more

Re: [libvirt PATCH] scripts: Fix E741 that pycodesyle is pointing out during syntax-check

2020-05-25 Thread Michal Privoznik
On 5/25/20 2:56 PM, Erik Skultety wrote: With newer pycodestyle 2.6.0 (which is part of flake8-3.8.2) reports the following pep violation during syntax-check: ../scripts/check-remote-protocol.py:95:9: E741 ambiguous variable name 'l' for l in err.strip().split("\n") On all the distros we

[PATCH v2 0/3] Support network interface downscript

2020-05-25 Thread Chen Hanxiao
QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): interface: introduce downscript downscript: add support for booting and hotplug

Re: [PATCH v2 3/3] downscript: docs: add docs and news

2020-05-25 Thread Peter Krempa
On Mon, May 25, 2020 at 12:16:49 -0400, Chen Hanxiao wrote: > Signed-off-by: Chen Hanxiao > --- > docs/formatdomain.html.in | 6 +- > docs/news.xml | 10 ++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/docs/formatdomain.html.in

[PATCH v2 1/3] interface: introduce downscript

2020-05-25 Thread Chen Hanxiao
https://gitlab.com/libvirt/libvirt/-/issues/13 Add support for downscript: Signed-off-by: Chen Hanxiao --- docs/schemas/domaincommon.rng | 8 src/conf/domain_conf.c| 9 + src/conf/domain_conf.h| 1 + 3 files changed, 18 insertions(+) diff

[PATCH v2 3/3] downscript: docs: add docs and news

2020-05-25 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao --- docs/formatdomain.html.in | 6 +- docs/news.xml | 10 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 23eb029234..4e2320d537 100644 ---

[PATCH v2 2/3] downscript: add support for booting and hotplug interface

2020-05-25 Thread Chen Hanxiao
Support downscript for booting vm, and hotunplug interface device. Signed-off-by: Chen Hanxiao --- src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +

Re: [libvirt PATCH] scripts: Fix E741 that pycodesyle is pointing out during syntax-check

2020-05-25 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: On 5/25/20 2:56 PM, Erik Skultety wrote: With newer pycodestyle 2.6.0 (which is part of flake8-3.8.2) reports the following pep violation during syntax-check: ../scripts/check-remote-protocol.py:95:9: E741 ambiguous variable name 'l' for l in

[PATCH v2.1 3/3] news: add description about downscript

2020-05-25 Thread Chen Hanxiao
Signed-off-by: Chen Hanxiao --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4cef804aac..67fb85377d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -52,6 +52,16 @@ + + + qemu: support

[PATCH v2.1 1/3] interface: introduce downscript element for interface

2020-05-25 Thread Chen Hanxiao
https://gitlab.com/libvirt/libvirt/-/issues/13 Add support for downscript: Signed-off-by: Chen Hanxiao --- docs/formatdomain.html.in | 6 +- docs/schemas/domaincommon.rng | 8 src/conf/domain_conf.c| 9 + src/conf/domain_conf.h| 1 + 4

[PATCH v2.1 2/3] downscript: add support for booting and hotplug interface

2020-05-25 Thread Chen Hanxiao
Support downscript for booting vm, and hotunplug interface device. Signed-off-by: Chen Hanxiao --- src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +

[PATCH v2.1 0/3] Support network interface downscript

2020-05-25 Thread Chen Hanxiao
QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): interface: introduce downscript downscript: add support for booting and hotplug

"http://libvirt.org/schemas/domain/qemu/1.0" returns 404 error

2020-05-25 Thread Yan Fu
Hello everyone, The XML namespace request website can not be accessed with 404 error: http://libvirt.org/schemas/domain/qemu/1.0 Could anyone help to fix it please? Thanks, Yan Fu