Re: [libvirt PATCH 01/15] cpu_map: Use g_auto* in loadData

Hi Ján! Am Montag, den 07.09.2020, 17:10 +0200 schrieb Ján Tomko: > On a Monday in 2020, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > src/cpu/cpu_map.c | 20 > > 1 file changed, 8 insertions(+), 12 deletions(-) > > > > diff --git a/src/cpu/cpu_map.c

Re: [libvirt PATCH 06/15] cpu_ppc64: Turn structs ppc64_{vendor, model, map} into typedefs

Am Montag, den 07.09.2020, 12:03 -0400 schrieb Laine Stump: > danielhb had sent similar patches for this file last week, which I > had > planned to review, but didn't get around to before the weekend: > > > https://www.redhat.com/archives/libvir-list/2020-September/msg00124.html > Thank you

Re: [PATCH] wireshark: Prefer ws_version.h over config.h

On Mon, Sep 07, 2020 at 08:30:08PM +0200, Michal Privoznik wrote: A wireshark plugin must declare what major and minor version it was built with as these are checked when wireshark loads plugins. On the top of that, we use major + minor + micro to adapt to changed API between releases. So far,

Re: [PATCH] docs: Discourage users from using fwcfg

On Tue, Sep 08, 2020 at 11:02:10AM +0200, Laszlo Ersek wrote: > On 09/07/20 15:48, Michal Privoznik wrote: > > Even though this was brought up in upstream discussion [1] it > > missed my patches: users should prefer over fwcfg. > > The reason is that fwcfg is considered somewhat internal to QEMU

Re: [PATCH 1/1] QEMU: support USB cdrom devices

Hi, > >> Also "info usb" just shows a single device. I just copied these lines > >> from a normal libvirt SCSI setup with two cdroms. > > > > That is normal, it actually is only one usb device after all ;) > > I was referring to the posted usb-bot example, where "your" docs >

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/07/20 16:38, Daniel P. Berrangé wrote: > On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: >> On 9/7/20 3:57 PM, Martin Kletzander wrote: >>> On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik wrote: Even though this was brought up in upstream discussion [1] it

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/07/20 15:48, Michal Privoznik wrote: > Even though this was brought up in upstream discussion [1] it > missed my patches: users should prefer over fwcfg. > The reason is that fwcfg is considered somewhat internal to QEMU > and it has limited number of slots and neither of these applies > to

Re: [PATCH] docs: Discourage users from using fwcfg

On Tue, Sep 08, 2020 at 08:37:03AM +0200, Martin Kletzander wrote: > On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: > > > On 9/7/20 3:57 PM, Martin Kletzander wrote: > > > > On Mon, Sep 07, 2020 at

Re: [PATCH] docs: Discourage users from using fwcfg

On Tue, Sep 08, 2020 at 08:03:46AM +0100, Daniel P. Berrangé wrote: On Tue, Sep 08, 2020 at 08:37:03AM +0200, Martin Kletzander wrote: On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: > > On 9/7/20 3:57 PM,

Re: [PATCH] docs: Discourage users from using fwcfg

On Tue, Sep 08, 2020 at 10:22:34AM +0200, Laszlo Ersek wrote: On 09/08/20 08:37, Martin Kletzander wrote: On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: On 9/7/20 3:57 PM, Martin Kletzander wrote: > On Mon,

Re: [RFC PATCH 0/3] qemu: Propagate cluster size to new qcow2 images

On Wed, Aug 26, 2020 at 10:32:04 -0500, Eric Blake wrote: > On 8/26/20 9:56 AM, Peter Krempa wrote: > > Cluster size may have performatnce implications. Propagate the cluster > > size used by the original image to any copy or overlay. > > > > Peter Krempa (3): > >qemu: monitor: Detect image

Re: [PATCH] virnuma: Report error when NUMA -> CPUs translation fails

On Mon, Sep 07, 2020 at 05:11:50PM +0200, Michal Privoznik wrote: When starting a domain with set libvirt translates given NUMA nodes into a set of host CPUs which is then used to QEMU process affinity. But, if the numatune contains a non-existent NUMA node then the translation fails with no

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/08/20 08:37, Martin Kletzander wrote: > On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: >> On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: >>> On 9/7/20 3:57 PM, Martin Kletzander wrote: >>> > On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik

Re: [PATCH] docs: Discourage users from using fwcfg

On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: On 9/7/20 3:57 PM, Martin Kletzander wrote: > On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik wrote: > > Even though this was brought up in upstream

Re: [PATCH] wireshark: Prefer ws_version.h over config.h

On Mon, 2020-09-07 at 20:30 +0200, Michal Privoznik wrote: > A wireshark plugin must declare what major and minor version it > was built with as these are checked when wireshark loads plugins. > On the top of that, we use major + minor + micro to adapt to > changed API between releases. So far, we

Re: [PATCH] docs: Discourage users from using fwcfg

On Tue, Sep 08, 2020 at 10:22:34AM +0200, Laszlo Ersek wrote: > On 09/08/20 08:37, Martin Kletzander wrote: > > On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: > >> On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: > >>> On 9/7/20 3:57 PM, Martin Kletzander

Re: [PATCH REBASE 4/7] qemuBuildMemoryBackendProps: Fix const correctness

On a Tuesday in 2020, Michal Privoznik wrote: The objects at @def and @mem pointers is only read and not written. Make the arguments const to make that explicit. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_command.h | 4 ++-- 2 files changed, 4

Re: [PATCH REBASE 6/7] qemu: Track default-ram-id machine attribute

On a Tuesday in 2020, Michal Privoznik wrote: The machine structure has another (optional) attribute: default-ram-id, which specifies the alias of the default RAM object. While the alias is private, it can never change in order to not break migration. QEMU uses the alias when allocating regular,

Re: large number of hot plug disks

On Tue, Sep 08, 2020 at 08:19:21 -0400, Alexander Wels wrote: > Hi, > > I am working on a project, and one of the requirements is that I can > hotplug a large number of disks. Think several dozens to potentially 100+. > The guest OS will be some linux flavor so it should have no problem with a >

[libvirt PATCH] check for NULL before calling g_regex_unref

g_regex_unref reports an error if called with a NULL argument. We have two cases in the code where we (possibly) call it on a NULL argument. The interesting one is in virDomainQemuMonitorEventCleanup. Based on VIR_CONNECT_DOMAIN_QEMU_MONITOR_EVENT_REGISTER_REGEX, we unref data->regex, which has

Re: large number of hot plug disks

On Tue, Sep 8, 2020 at 8:43 AM Daniel P. Berrangé wrote: > On Tue, Sep 08, 2020 at 08:19:21AM -0400, Alexander Wels wrote: > > Hi, > > > > I am working on a project, and one of the requirements is that I can > > hotplug a large number of disks. Think several dozens to potentially > 100+. > > The

Re: [PATCH REBASE 5/7] qemu: Introduce QEMU_CAPS_MACHINE_MEMORY_BACKEND

On a Tuesday in 2020, Michal Privoznik wrote: This capability corresponds to '-machine memory-backend=' command line argument. Unfortunately, it is not possible for us to detect the capability via QMP and therefore we have to have a version check. The QEMU capability was introduced in

Re: large number of hot plug disks

On Tue, Sep 08, 2020 at 08:19:21AM -0400, Alexander Wels wrote: > Hi, > > I am working on a project, and one of the requirements is that I can > hotplug a large number of disks. Think several dozens to potentially 100+. > The guest OS will be some linux flavor so it should have no problem with a

Re: [PATCH v2 2/7] qemu: Introduce functions to handle transient disk

On Fri, Aug 28, 2020 at 10:08:31 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Here is the implementation of transient option for qcow2 and raw format > disk. This gets available directive in domain xml file > like as: > > > > > > > > > When

Re: [PATCH] docs: Discourage users from using fwcfg

On 9/8/20 1:45 PM, Laszlo Ersek wrote: Reviewed-by: Laszlo Ersek Thank you, pushed. Michal

Re: [libvirt PATCH] docs: Rephrase the video 'none' type to clarify the reasoning

On a Tuesday in 2020, Michal Privoznik wrote: On 9/8/20 11:59 AM, Erik Skultety wrote: Signed-off-by: Erik Skultety --- docs/formatdomain.rst | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) This is a tiny follow-up improvement resulting from [1] as I felt the

Re: [PATCH REBASE 1/7] qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part

On a Tuesday in 2020, Michal Privoznik wrote: All three memory backends (-file, -ram and -memfd) have .prealloc attribute. Since we are setting it only for -file, the corresponding code lives only under if() that handles that specific backend. But in near future we will want to set the attribute

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/08/20 11:05, Daniel P. Berrangé wrote: > On Tue, Sep 08, 2020 at 10:22:34AM +0200, Laszlo Ersek wrote: >> On 09/08/20 08:37, Martin Kletzander wrote: >>> On Mon, Sep 07, 2020 at 03:38:23PM +0100, Daniel P. Berrangé wrote: On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote:

Re: [PATCH v2 4/7] qemu: Transient option gets avaiable for qcow2 and raw format disk

On Fri, Aug 28, 2020 at 10:08:33 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_validate.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c >

Re: [PATCH v2 7/7] qemu: Block blockjobs when transient disk option is enabled

On Fri, Aug 28, 2020 at 10:08:34 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Block blockjobs when transient disk option is enabled so far. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_domain.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

[libvirt PATCH] docs: Rephrase the video 'none' type to clarify the reasoning

Signed-off-by: Erik Skultety --- docs/formatdomain.rst | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) This is a tiny follow-up improvement resulting from [1] as I felt the paragraph wasn't clear enough + there were a couple of typographical issues. [1]

Re: [libvirt PATCH] docs: Rephrase the video 'none' type to clarify the reasoning

On 9/8/20 11:59 AM, Erik Skultety wrote: Signed-off-by: Erik Skultety --- docs/formatdomain.rst | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) This is a tiny follow-up improvement resulting from [1] as I felt the paragraph wasn't clear enough + there were a couple

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/08/20 11:12, Daniel P. Berrangé wrote: > On Tue, Sep 08, 2020 at 11:02:10AM +0200, Laszlo Ersek wrote: >> On 09/07/20 15:48, Michal Privoznik wrote: >>> Even though this was brought up in upstream discussion [1] it >>> missed my patches: users should prefer over fwcfg. >>> The reason is

Re: [libvirt PATCH] docs: Rephrase the video 'none' type to clarify the reasoning

On Tue, Sep 08, 2020 at 01:07:42PM +0200, Ján Tomko wrote: > On a Tuesday in 2020, Michal Privoznik wrote: > > On 9/8/20 11:59 AM, Erik Skultety wrote: > > > Signed-off-by: Erik Skultety > > > --- > > > docs/formatdomain.rst | 17 ++--- > > > 1 file changed, 10 insertions(+), 7

Re: large number of hot plug disks

On Tue, Sep 08, 2020 at 02:38:17PM +0200, Peter Krempa wrote: > On Tue, Sep 08, 2020 at 08:19:21 -0400, Alexander Wels wrote: > > Hi, > > > > I am working on a project, and one of the requirements is that I can > > hotplug a large number of disks. Think several dozens to potentially 100+. > > The

Re: [PATCH v2 1/7] qemuSnapshotDiskPrepareOne: Get available even if snapdisk is NULL

On Fri, Aug 28, 2020 at 10:08:30 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Get available even if snapdisk argument is NULL at > qemuSnapshotDiskPrepareOne() > so that the caller can setup dd->src. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_snapshot.c | 5

Re: [PATCH] docs: Discourage users from using fwcfg

On 9/8/20 11:02 AM, Laszlo Ersek wrote: On 09/07/20 15:48, Michal Privoznik wrote: Even though this was brought up in upstream discussion [1] it missed my patches: users should prefer over fwcfg. The reason is that fwcfg is considered somewhat internal to QEMU and it has limited number of

Re: [PATCH REBASE 2/7] qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate

On a Tuesday in 2020, Michal Privoznik wrote: If user specifies immediate memory allocation in the domain XML, they want QEMU to fully allocate its memory. And if the memory was allocated using plain '-m' then we would honour it. But, if a memory backend is used, then we don't set the prealloc

Re: [PATCH REBASE 3/7] qemuBuildMemoryBackendProps: Prealloc mem for memfd backend

On a Tuesday in 2020, Michal Privoznik wrote: If a domain was using hugepages through memory-backend-file or via -mem-path, we would turn prealloc on. But we are not doing that for memory-backend-memfd. Fix this, because we need QEMU to fully allocate hugepages. Signed-off-by: Michal Privoznik

Re: [PATCH] rpm: Remove pointless explicit dependency on 'readline'

On 9/7/20 8:59 PM, Neal Gompa wrote: The 'readline' package only contains the library, which rpm is already generating the (stricter) correct dependency for. Signed-off-by: Neal Gompa --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Michal Privoznik Michal

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/08/20 12:05, Michal Privoznik wrote: > On 9/8/20 11:02 AM, Laszlo Ersek wrote: >> On 09/07/20 15:48, Michal Privoznik wrote: >>> Even though this was brought up in upstream discussion [1] it >>> missed my patches: users should prefer over fwcfg. >>> The reason is that fwcfg is considered

Re: [libvirt PATCH] remove HAL node device driver

Pavel Hrdina wrote: > There was one attempt a year ago done by me to drop HAL [1] but it was > never resolved. There was another time when Dan suggested to drop HAL > driver [2] but it was decided to keep it around in case device > assignment will be implemented for FreeBSD and the fact that >

large number of hot plug disks

Hi, I am working on a project, and one of the requirements is that I can hotplug a large number of disks. Think several dozens to potentially 100+. The guest OS will be some linux flavor so it should have no problem with a large number of disks. During my experimentation I quickly ran into the

Re: [PATCH v2 5/7] qemu: Block migration when transient disk option is enabled

On Fri, Aug 28, 2020 at 10:08:35 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Block migration when transient disk option is enabled because migration > requires some blockjobs. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_migration.c | 22 ++ >

Re: [PATCH v2 6/7] qemu: Block disk hotplug when transient disk option is enabled

On Fri, Aug 28, 2020 at 10:08:36 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Block disk hotplug when transient disk option is enabled so far. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_hotplug.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

On Tue, 2020-09-08 at 15:48 +0200, Pavel Hrdina wrote: > The correct key for dependencies for virt_modules hash is `deps`. > > Signed-off-by: Pavel Hrdina > --- > src/storage/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andrea Bolognani -- Andrea

Re: [PATCH 01/12] cpu_ppc64.c: use typedefs for 'struct ppc64_vendor'

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Introduce virCPUppc64Vendor and virCPUppc64VendorPtr types to improve code readability. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by:

Re: [PATCH 07/12] cpu_ppc64.c: use typedefs for 'struct ppc64_map'

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Introduce virCPUppc64Map and virCPUppc64MapPtr types to improve code readability. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)

Re: [PATCH 06/12] cpu_ppc64.c: use g_autopr() with virCPUppc64ModelPtr

s/autopr/autoptr/ On a Wednesday in 2020, Daniel Henrique Barboza wrote: Use autocleanup with virCPUppc64ModelPtr to simplify existing code. Remove the 'error' label in ppc64ModelCopy() since it is now obsolete. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 21

Re: [PATCH 5/5] node_device: mdev vfio-ccw support

On Mon, Aug 24, 2020 at 01:59:15PM +0200, Bjoern Walk wrote: > From: Boris Fiuczynski > > Allow vfio-ccw mdev devices to be created besides vfio-pci mdev devices > as well. > > Reviewed-by: Bjoern Walk > Signed-off-by: Boris Fiuczynski > --- > src/conf/domain_addr.c | 2 +- >

Re: [PATCH 08/12] cpu_ppc64.c: register AUTOPTR_CLEANUP_FUNC for virCPUppc64MapPtr

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Next patch will use g_autoptr() in virCPUppc64MapPtr pointers for some cleanups. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 10/12] cpu_ppc64.c: use g_autoptr() in virCPUppc64GetHost()

On a Wednesday in 2020, Daniel Henrique Barboza wrote: We don't need to call virCPUppc64DataFree() in a cleanup label. This function is already assigned to the 'dataFree' interface of cpuDriverPPC64, and it will be called by virCPUDataFree(), the autocleanup function of virCPUDataPtr, via

Re: [PATCH 1/5] node_device: refactor udevProcessCCW

On Mon, Aug 24, 2020 at 01:59:11PM +0200, Bjoern Walk wrote: > From: Boris Fiuczynski > > Refactor out CCW address parsing for later reuse. > > Reviewed-by: Bjoern Walk > Signed-off-by: Boris Fiuczynski Reviewed-by: Erik Skultety

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

On Tue, Sep 08, 2020 at 15:48:46 +0200, Pavel Hrdina wrote: > The correct key for dependencies for virt_modules hash is `deps`. > > Signed-off-by: Pavel Hrdina > --- > src/storage/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Krempa

Re: [PATCH 02/12] cpu_ppc64.c: register AUTOPTR_CLEANUP_FUNC for virCPUppc64VendorPtr

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Next patch will use g_autoptr() in virCPUppc64VendorPtr pointers for some cleanups. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 03/12] cpu_ppc64.c: modernize ppc64VendorParse()

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Use g_autoptr() in virCPUppc64VendorPtr and remove the now uneeded 'cleanup' label. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko

Re: [PATCH 04/12] cpu_ppc64.c: use typedefs for 'struct ppc64_model'

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Introduce virCPUppc64Model and virCPUppc64ModelPtr types to improve code readability. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-)

Re: [PATCH v5 2/4] conf: Support to parse rbd namespace from source name

On Wed, Sep 02, 2020 at 16:05:19 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/formatdomain.rst | 12 +--- > src/conf/domain_conf.c| 35 +++ > src/util/virstoragefile.c | 1 + > src/util/virstoragefile.h | 1 + > 4 files changed, 42

Re: [libvirt PATCH] remove HAL node device driver

On Tue, Sep 08, 2020 at 03:50:07PM +0400, Roman Bogorodskiy wrote: > Pavel Hrdina wrote: > > > There was one attempt a year ago done by me to drop HAL [1] but it was > > never resolved. There was another time when Dan suggested to drop HAL > > driver [2] but it was decided to keep it around in

Re: [PATCH REBASE 7/7] qemu: Use memory-backend-* for regular guest memory

On a Tuesday in 2020, Michal Privoznik wrote: So far, Libvirt configures memory-backend-* for memory hotplug, *libvirt possibly NUMA nodes and in a few other cases. This patch switches to constructing the memory-backend-* command line for all cases. To keep ability to migrate guests a little

Re: [libvirt PATCH 05/15] cpu: Use g_auto* in virCPUGetHost

On a Monday in 2020, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko And I went ahead and pushed patches 2~5, since they do not conflict with the cleanups posted earlier

Re: [libvirt PATCH] remove HAL node device driver

On Tue, Sep 08, 2020 at 03:42:58PM +0200, Pavel Hrdina wrote: > On Tue, Sep 08, 2020 at 03:50:07PM +0400, Roman Bogorodskiy wrote: > > Pavel Hrdina wrote: > > > > > There was one attempt a year ago done by me to drop HAL [1] but it was > > > never resolved. There was another time when Dan

Re: [PATCH 09/12] cpu_ppc64.c: use g_autopr() with virCPUppc64MapPtr

s/autopr/autoptr/ On a Wednesday in 2020, Daniel Henrique Barboza wrote: Use autocleanup with virCPUppc64MapPtr to simplify existing code. Remove labels when possible. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 47 ++--- 1 file

Re: [libvirt PATCH] check for NULL before calling g_regex_unref

On Tue, Sep 08, 2020 at 15:20:52 +0200, Ján Tomko wrote: > g_regex_unref reports an error if called with a NULL argument. > > We have two cases in the code where we (possibly) call it on a NULL > argument. The interesting one is in virDomainQemuMonitorEventCleanup. > > Based on

Re: [libvirt PATCH] check for NULL before calling g_regex_unref

On Tue, Sep 08, 2020 at 03:20:52PM +0200, Ján Tomko wrote: g_regex_unref reports an error if called with a NULL argument. We have two cases in the code where we (possibly) call it on a NULL argument. The interesting one is in virDomainQemuMonitorEventCleanup. Based on

Re: [PATCH 1/1] QEMU: support USB cdrom devices

Hi Am 08.09.20 um 08:07 schrieb Gerd Hoffmann: Also "info usb" just shows a single device. I just copied these lines from a normal libvirt SCSI setup with two cdroms. >>> >>> That is normal, it actually is only one usb device after all ;) >> >> I was referring to the posted usb-bot

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

On Tue, Sep 08, 2020 at 04:41:03PM +0200, Ján Tomko wrote: > On a Tuesday in 2020, Pavel Hrdina wrote: > > The correct key for dependencies for virt_modules hash is `deps`. > > > > s/dependencies/dependenciec/ No :) it's not used here as the incorrect key but as regular word with its meaning.

Re: [libvirt PATCH 03/15] cpu_map: Use g_auto* in loadIncludes

On a Monday in 2020, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 11/12] cpu_ppc64.c: use g_autofree() whenever possible

On a Wednesday in 2020, Daniel Henrique Barboza wrote: This allows for a label removal in ppc64ModelParse(). Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

On a Tuesday in 2020, Pavel Hrdina wrote: The correct key for dependencies for virt_modules hash is `deps`. s/dependencies/dependenciec/ Signed-off-by: Pavel Hrdina --- src/storage/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano

Re: device compatibility interface for live migration with assigned devices

On Mon, 31 Aug 2020 12:43:44 +0800 Yan Zhao wrote: > On Fri, Aug 28, 2020 at 03:04:12PM +0100, Sean Mooney wrote: > > On Fri, 2020-08-28 at 15:47 +0200, Cornelia Huck wrote: > > > On Wed, 26 Aug 2020 14:41:17 +0800 > > > Yan Zhao wrote: > > > > > > > previously, we want to regard the two

Re: [libvirt PATCH 04/15] cpu: Use g_auto* in virCPUCompareXML

On a Monday in 2020, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 4/5] node_device: detect DASD devices

On Mon, Aug 24, 2020 at 01:59:14PM +0200, Bjoern Walk wrote: > From: Boris Fiuczynski > > Make Direct Access Storage Devices (DASDs) available in the node_device > driver. > > Reviewed-by: Bjoern Walk > Signed-off-by: Boris Fiuczynski > --- > src/node_device/node_device_udev.c | 24

Re: [PATCH 12/12] cpu_ppc64.c: use g_autoptr() whenever possible

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Using g_autoptr() in virCPUDef pointers allows for more cleanups in ppc64Compute() and virCPUppc64Baseline() Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 55 + 1 file changed,

[libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

The correct key for dependencies for virt_modules hash is `deps`. Signed-off-by: Pavel Hrdina --- src/storage/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/meson.build b/src/storage/meson.build index 18ea0f3fb5..b4cefe9a89 100644 ---

Re: [libvirt PATCH] conf: Add support for GlusterFS volumes as disk

On Thu, Sep 03, 2020 at 20:28:47 +0200, Vincent Vanlaer wrote: > While libvirt has support for GlusterFS pools and volumes, they cannot > be added to a domain. This commit adds the necessary translation between > the pool definition and the disk definition, allowing volumes in a domain > to be

Re: [libvirt PATCH 02/15] cpu_map: Use g_auto* in cpuMapLoadInclude

On a Monday in 2020, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 2/5] node_device: detect CSS devices

On Mon, Aug 24, 2020 at 01:59:12PM +0200, Bjoern Walk wrote: > From: Boris Fiuczynski > > Make channel subsystem (CSS) devices available in the node_device driver.o Can there be more CSS devices per CPC? > The CCS devices reside in the computer system and provide CCW devices, e.g.: > > +-

Re: [PATCH 3/5] virsh: nodedev: ability to filter CSS capabilities

On Mon, Aug 24, 2020 at 01:59:13PM +0200, Bjoern Walk wrote: > From: Boris Fiuczynski > > Allow to filter for CSS devices. > > Reviewed-by: Bjoern Walk > Signed-off-by: Boris Fiuczynski > --- Reviewed-by: Erik Skultety

Re: [PATCH 05/12] cpu_ppc64.c: register AUTOPTR_CLEANUP_FUNC for virCPUppc64ModelPtr

On a Wednesday in 2020, Daniel Henrique Barboza wrote: Next patch will use g_autoptr() in virCPUppc64ModelPtr pointers for some cleanups. Signed-off-by: Daniel Henrique Barboza --- src/cpu/cpu_ppc64.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt PATCH] remove HAL node device driver

On Tue, Sep 08, 2020 at 04:44:38PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 08, 2020 at 03:42:58PM +0200, Pavel Hrdina wrote: > > On Tue, Sep 08, 2020 at 03:50:07PM +0400, Roman Bogorodskiy wrote: > > > Pavel Hrdina wrote: > > > > > > > There was one attempt a year ago done by me to drop

Re: [libvirt PATCH] remove HAL node device driver

On Tue, Sep 08, 2020 at 06:12:19PM +0200, Pavel Hrdina wrote: > On Tue, Sep 08, 2020 at 04:44:38PM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 08, 2020 at 03:42:58PM +0200, Pavel Hrdina wrote: > > > On Tue, Sep 08, 2020 at 03:50:07PM +0400, Roman Bogorodskiy wrote: > > > > Pavel Hrdina

Re: [PATCH] docs: Discourage users from using fwcfg

On Tue, Sep 08, 2020 at 10:17:08AM +0200, Laszlo Ersek wrote: > On 09/07/20 16:38, Daniel P. Berrangé wrote: > > On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: > >> On 9/7/20 3:57 PM, Martin Kletzander wrote: > >>> On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik

Re: [libvirt PATCH 06/15] cpu_ppc64: Turn structs ppc64_{vendor, model, map} into typedefs

On a Tuesday in 2020, Tim Wiederhake wrote: Am Montag, den 07.09.2020, 12:03 -0400 schrieb Laine Stump: danielhb had sent similar patches for this file last week, which I had planned to review, but didn't get around to before the weekend:

[PATCH] qemuFirmwareFillDomain: Fill NVRAM template on migration too

In 8e1804f9f66 I've tried to fix the following use case: domain is started with path to UEFI only and relies on libvirt to figure out corresponding NVRAM template to create a per-domain copy from. The fix consisted of having a check tailored exactly for this use case and if it's hit then using FW

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/08/20 14:28, Michal Privoznik wrote: > On 9/8/20 1:45 PM, Laszlo Ersek wrote: >> Reviewed-by: Laszlo Ersek > > Thank you, pushed. Thank *you* for the patch. :) Laszlo

Re: [PATCH] docs: Discourage users from using fwcfg

On 09/08/20 19:26, Daniel P. Berrangé wrote: > On Tue, Sep 08, 2020 at 10:17:08AM +0200, Laszlo Ersek wrote: >> On 09/07/20 16:38, Daniel P. Berrangé wrote: >>> On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: On 9/7/20 3:57 PM, Martin Kletzander wrote: > On Mon, Sep 07,

[PATCH 0/3] Several small documentation fixes

This patchset fixes several spelling and punctuation errors in the documentation. Where British vs. American conventions differ, I used Google Trends to determine which form is most commonly used, globally. Matt Coleman (3): Fix a typo in compiling.html.in: that -> from Fix errors in

[PATCH 3/3] Fix a typo in hacking.rst: "contirbute" -> "contribute"

--- docs/hacking.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.rst b/docs/hacking.rst index 3fc5888a71..858dd2dfc1 100644 --- a/docs/hacking.rst +++ b/docs/hacking.rst @@ -15,7 +15,7 @@ libvirt-python) `online `__. Patches to

[PATCH 1/3] Fix a typo in compiling.html.in: that -> from

The original author intended to write "different than". "Different" is commonly followed by "from", "than", and "to". Globally, "from" is the most common. --- docs/compiling.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/compiling.html.in b/docs/compiling.html.in

[PATCH 2/3] Fix errors in contribute.html.in

* Add a period to the end of the page's introductory sentence. * Correct a spelling error: "Evangalism"/"evangalise" -> "Evangelism"/"evangelize" --- docs/contribute.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/contribute.html.in

Re: device compatibility interface for live migration with assigned devices

hi All, Per our previous discussion, there are two main concerns to the previous proposal: (1) it's currently hard for openstack to match mdev types. (2) complicated. so, we further propose below changes: (1) requiring two compatible mdevs to have the same mdev type for now. (though kernel

Re: [PATCH 0/3] Several small documentation fixes

On Tue, Sep 08, 2020 at 04:43:51PM -0400, Matt Coleman wrote: > This patchset fixes several spelling and punctuation errors in the > documentation. > > Where British vs. American conventions differ, I used Google Trends to > determine which form is most commonly used, globally. Reviewed-by: Erik

Re: device compatibility interface for live migration with assigned devices

> > still, I'd like to put it more explicitly to make ensure it's not missed: > > the reason we want to specify compatible_type as a trait and check > > whether target compatible_type is the superset of source > > compatible_type is for the consideration of backward compatibility. > > e.g. > > an

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote: > So the hypervisor has at least one (Router Advertised) RA route. > After defining a network like the following, the RA route is removed if > accept_ra isn't set to 2. > > > test5 > > > > family="ipv6" >

Re: [PATCH] doc: add some examples for IPv6 NAT configuration

Gentle ping on this; thanks -i On Wed, Aug 12, 2020 at 11:21:47AM +1000, Ian Wienand wrote: > Add some expanded examples for the nat ipv6 introduced with > 927acaedec7effbe67a154d8bfa0e67f7d08e6c7. > > Unfortunately while for IPv4 it's well-known what addresses ranges are > useful for NAT, with