On 12/21/20 12:57 PM, Martin Kletzander wrote:
Reviewed-by: Martin Kletzander
Pushed now.
Michal
On Tue, Jan 05, 2021 at 05:56:13PM +0800, Cho, Yu-Chen wrote:
> Signed-off-by: Cho, Yu-Chen
> diff --git a/ci/containers/ci-opensuse-151.Dockerfile
> b/ci/containers/ci-opensuse-152.Dockerfile
> similarity index 98%
> rename from ci/containers/ci-opensuse-151.Dockerfile
> rename to
On Tue, Jan 05, 2021 at 10:51:02AM +0100, Michal Privoznik wrote:
> During rewrite to meson it was mistakenly disabled. Originally,
> we had:
>
> LIBVIRT_ARG_WITH_FEATURE([VMWARE], [VMware], [yes])
>
> which enabled the driver by default. But in meson we are checking
> whether the
xenmigr was for xend
Fixes commit 1dac5f06a0341e8087dc33af75c8352d77a4
Signed-off-by: Olaf Hering
---
docs/migration.html.in | 6 --
1 file changed, 6 deletions(-)
diff --git a/docs/migration.html.in b/docs/migration.html.in
index ac38c6e13d..627200f96a 100644
---
During rewrite to meson it was mistakenly disabled. Originally,
we had:
LIBVIRT_ARG_WITH_FEATURE([VMWARE], [VMware], [yes])
which enabled the driver by default. But in meson we are checking
whether the 'driver_vmware' option is enabled without anything
enabling it automagically.
On 1/5/21 12:32 AM, Daniel Henrique Barboza wrote:
On 12/21/20 1:19 PM, Martin Kletzander wrote:
And return the actual extracted value in a parameter. This way we can
later
return success even without any extracted value.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 31
I also realized this is already fixed.
Thank you
发送自 Windows 10 版邮件应用
发件人: Peter Krempa
发送时间: 2021年1月4日 21:15
收件人: liyalei
抄送: libvir-list@redhat.com; liyalei
主题: Re: [PATCH] Fix wrong use of path variable
On Wed, Dec 30, 2020 at 18:39:35 +0800, liyalei wrote:
> From: liyalei
Please
On 12/18/20 10:09 AM, Michal Privoznik wrote:
> Firstly, bring variables that are used only within loops into
> their respective loops. Secondly, drop 'error' label which is
> redundant since we have @rv which holds the return value.
> Thirdly, fix indendation in one case, the rest is indented
On 12/24/20 10:31 AM, Meina Li wrote:
Signed-off-by: Meina Li
---
docs/formatstorageencryption.html.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Pushed now. Congratulations on your first libvirt contribution!
Michal
On Thu, Dec 24, 2020 at 08:14:40AM -0600, Jonathon Jongsma wrote:
> This interface allows you to undefine a persistently defined (but
> inactive) mediated devices. It is implemented via 'mdevctl'
>
> Signed-off-by: Jonathon Jongsma
> ---
This patch doesn't pass tests, because
Currently, we configure QEMU to prealloc memory almost by
default. Well, by default for NVDIMMs, hugepages and if user
asked us to (via memoryBacking ).
However, when guest's NVDIMM is backed by real life NVDIMM this
approach is not the best. In this case users should put
into the device , like
On Tue, Jan 05, 2021 at 12:39:00PM +0100, Michal Privoznik wrote:
> Currently, we configure QEMU to prealloc memory almost by
> default. Well, by default for NVDIMMs, hugepages and if user
> asked us to (via memoryBacking ).
>
> However, when guest's NVDIMM is backed by real life NVDIMM this
>
On Tue, Jan 05, 2021 at 09:28:27PM +0800, Keqian Zhu wrote:
> Hi Daniel,
>
> Thanks for your reply :-) Please see my words below.
>
> On 2021/1/4 19:58, Daniel P. Berrangé wrote:
> > On Fri, Dec 18, 2020 at 04:38:22PM +0800, Keqian Zhu wrote:
> >> Hi Daniel and Jiri,
> >>
> >> On 2020/12/8
On 1/5/21 11:41 AM, Olaf Hering wrote:
xenmigr was for xend
Fixes commit 1dac5f06a0341e8087dc33af75c8352d77a4
Signed-off-by: Olaf Hering
---
docs/migration.html.in | 6 --
1 file changed, 6 deletions(-)
Tweaked the commit message a bit and pushed.
Reviewed-by: Michal Privoznik
Domain name can contain spaces in which case it's not immediately clear
from virsh messages where the boundary of the name is. Enclose all %s
formatters in apostrophes as delimiters.
Done via the following vim regex:
%s/omain %s/omain '%s'/g
This patch changes:
$ virsh undefine
On 12/29/20 12:29 PM, Yi Li wrote:
refactor and remove unused created variable
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index
On 12/29/20 12:29 PM, Yi Li wrote:
remove unused return variable,
The errno will throw by virReportSystemError
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
Patches look good, but I'd reorder them a bit.
When starting a VM with an empty cdrom which has configured the
startup fails as qemu is not happy about setting tuning for an empty
drive:
error: internal error: unable to execute 'block_set_io_throttle', unexpected
error: 'Device has no medium'
Resolve this by skipping the setting of
On 1/5/21 8:22 AM, Peter Krempa wrote:
When starting a VM with an empty cdrom which has configured the
startup fails as qemu is not happy about setting tuning for an empty
drive:
error: internal error: unable to execute 'block_set_io_throttle', unexpected
error: 'Device has no medium'
On 2021/1/5 21:34, Daniel P. Berrangé wrote:
> On Tue, Jan 05, 2021 at 09:28:27PM +0800, Keqian Zhu wrote:
>> Hi Daniel,
>>
>> Thanks for your reply :-) Please see my words below.
>>
>> On 2021/1/4 19:58, Daniel P. Berrangé wrote:
>>> On Fri, Dec 18, 2020 at 04:38:22PM +0800, Keqian Zhu wrote:
On Mon, Jan 04, 2021 at 15:30:19 -0500, Masayoshi Mizuma wrote:
> On Sat, Dec 19, 2020 at 11:30:39PM -0500, Masayoshi Mizuma wrote:
[...]
> I think following qemu command line options and QMP commands work for sharing
> the qcow2 disks. The following uses disk hotplug instead of snapshot
On Thu, Dec 24, 2020 at 08:14:28AM -0600, Jonathon Jongsma wrote:
> Expose a helper function that can be used by udev and mdevctl to
> generate device names for node devices.
>
> Signed-off-by: Jonathon Jongsma
> ---
Reviewed-by: Erik Skultety
On Tue, Jan 05, 2021 at 10:15:47AM +0100, Michal Privoznik wrote:
On 1/5/21 12:32 AM, Daniel Henrique Barboza wrote:
On 12/21/20 1:19 PM, Martin Kletzander wrote:
And return the actual extracted value in a parameter. This way we can
later
return success even without any extracted value.
On 1/5/21 1:18 PM, Peter Krempa wrote:
Domain name can contain spaces in which case it's not immediately clear
from virsh messages where the boundary of the name is. Enclose all %s
formatters in apostrophes as delimiters.
Done via the following vim regex:
%s/omain %s/omain '%s'/g
This patch
Hi Daniel,
Thanks for your reply :-) Please see my words below.
On 2021/1/4 19:58, Daniel P. Berrangé wrote:
> On Fri, Dec 18, 2020 at 04:38:22PM +0800, Keqian Zhu wrote:
>> Hi Daniel and Jiri,
>>
>> On 2020/12/8 18:31, Jiri Denemark wrote:
>>> On Tue, Dec 08, 2020 at 09:27:39 +, Daniel P.
On Mon, Jan 04, 2021 at 06:05:17PM +, Daniel P. Berrangé wrote:
> As soon as a guest using a device is launched, libvirt will change
> the ownership to 'tss' user and group, which will cause RPM verify to
> then fail.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> libvirt.spec.in | 2 +-
>
On 1/5/21 8:39 AM, Michal Privoznik wrote:
Currently, we configure QEMU to prealloc memory almost by
default. Well, by default for NVDIMMs, hugepages and if user
asked us to (via memoryBacking ).
However, when guest's NVDIMM is backed by real life NVDIMM this
approach is not the best. In
On 1/5/21 12:49 PM, John Ferlan wrote:
On 12/18/20 10:09 AM, Michal Privoznik wrote:
Firstly, bring variables that are used only within loops into
their respective loops. Secondly, drop 'error' label which is
redundant since we have @rv which holds the return value.
Thirdly, fix indendation
When rewriting the function, I've mistakenly declared a variable
and assigned it to itself. Let's initialize the variable properly.
Fixes: 5fb6d98c881c42ab41ca72060217b846949a438f
Signed-off-by: Michal Privoznik
---
Pushed as trivial.
src/network/bridge_driver.c | 2 +-
1 file changed, 1
Luyao,
I failed to realize, back in the v1 version of your patches, that you didn't
sign them with a "Signed-off-by" tag. This is required to assert that you agree
with the terms of the Developer Certificate of Origin, described here:
https://developercertificate.org/
This is described in
Signed-off-by: Cho, Yu-Chen
---
.gitlab-ci.yml | 14 +++---
...e-151.Dockerfile => ci-opensuse-152.Dockerfile} | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
rename ci/containers/{ci-opensuse-151.Dockerfile =>
ci-opensuse-152.Dockerfile}
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build| 1 +
docs/manpages/virtinterfaced.rst | 215 +++
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build| 1 +
docs/manpages/virtproxyd.rst | 256 +++
3 files changed, 258 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst| 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtnetworkd.rst | 215 +
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst| 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtnodedevd.rst | 214 +
3 files changed, 216 insertions(+)
create mode 100644
This group will be distinct from the per-driver modular daemon mapages.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/manpages/index.rst b/docs/manpages/index.rst
index 3624ae4e8f..e116c6f415 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtqemud.rst | 215
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtnwfilterd.rst | 215
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst| 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtstoraged.rst | 215 +
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtvzd.rst | 215 ++
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst| 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtxend.rst | 215 +
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtvboxd.rst | 213
3 files changed, 215 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst| 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtlxcd.rst | 215 +
3 files changed, 217 insertions(+)
create mode 100644
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 1 +
docs/manpages/meson.build | 1 +
docs/manpages/virtsecretd.rst | 214 ++
3 files changed, 216 insertions(+)
create mode 100644
Subsitute in the current version so the example always reflect today's
version of reality.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/libvirtd.rst | 2 +-
docs/manpages/meson.build | 1 +
docs/manpages/virtlockd.rst | 2 +-
docs/manpages/virtlogd.rst | 2 +-
4 files changed, 4
This is an adaptation of the libvirtd manpage.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/index.rst | 7 ++
docs/manpages/meson.build| 1 +
docs/manpages/virtbhyved.rst | 193 +++
3 files changed, 201 insertions(+)
create mode 100644
Most of the modular daemon stuff has been done from a single template,
but for the man pages that is more trouble than it is worth, so we
create a separate man page source for each daemon, which makes it easy
to extend with driver specific information.
Changed in v2:
- BHyve man page has had
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/libvirtd.rst | 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/docs/manpages/libvirtd.rst b/docs/manpages/libvirtd.rst
index cd9976c5e4..2ce6284b3a 100644
---
On Mon, Dec 14, 2020 at 11:31 PM Jiangyifei wrote:
>
>
> > -Original Message-
> > From: Alistair Francis [mailto:alistai...@gmail.com]
> > Sent: Wednesday, December 9, 2020 6:26 AM
> > To: Jiangyifei
> > Cc: qemu-de...@nongnu.org Developers ; open
> > list:RISC-V ; Zhangxiaofeng (F)
> >
On 1/5/21 4:54 PM, Martin Kletzander wrote:
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now results in an error and the user not being able to
even dump the
Refactor in 0316c28a453ac used incorrect source variable to initialize
the variable which holds the name of the bitmap which needs to be
deleted after the backup job finishes. This resulted into deleting the
source bitmap of the backup rather than the temporary one.
Use 'dd->incrementalBitmap'
On Thu, Dec 24, 2020 at 08:14:30AM -0600, Jonathon Jongsma wrote:
> Since a mediated device can be persistently defined by the mdevctl
> backend, we need additional lifecycle events beyond CREATED/DELETED to
> indicate that e.g. the device has been stopped but the device definition
> still exists.
refactor and remove unused created variable.
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index c6d0f7a97c..cc8189c3e0 100644
---
remove unused return variable,
The errno will throw by virReportSystemError
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index
refactor storageBackendCreateRaw and remove some unused variable.
Yi Li (3):
createRawFile: remove unused return variable
virStorageBackendCopyToFD: remove unused return variable
storageBackendCreateRaw: remove unused created
src/storage/storage_util.c | 66
remove unused return variable,
The errno will throw by virReportSystemError
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index
On Thu, Dec 24, 2020 at 08:14:29AM -0600, Jonathon Jongsma wrote:
> This adds some internal API to query for persistent mediated devices
> that are defined by mdevctl. Following commits will make use of this
> information. This just provides the infrastructure and tests for this
> feature. One
On 12/21/20 4:23 AM, Shi Lei wrote:
Extract common code as helper function virNetlinkTalk, then simplify
the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 210 +++---
src/util/virnetlink.h |
On 1/5/21 3:43 PM, Yi Li wrote:
refactor and remove unused created variable.
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index
On 1/5/21 3:43 PM, Yi Li wrote:
refactor storageBackendCreateRaw and remove some unused variable.
Yi Li (3):
createRawFile: remove unused return variable
virStorageBackendCopyToFD: remove unused return variable
storageBackendCreateRaw: remove unused created
On Thu, Dec 24, 2020 at 08:14:32AM -0600, Jonathon Jongsma wrote:
> When a mediated device is stopped or undefined by an application outside
> of libvirt, we need to remove it from our list of node devices within
> libvirt. This patch introduces virNodeDeviceObjListRemoveLocked() and
>
On a Tuesday in 2021, Peter Krempa wrote:
Refactor in 0316c28a453ac used incorrect source variable to initialize
the variable which holds the name of the bitmap which needs to be
deleted after the backup job finishes. This resulted into deleting the
source bitmap of the backup rather than the
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this results in an error. Make it behave more closer to
VMWare.
Resolves:
Signed-off-by: Martin Kletzander
---
.../vmx2xml-cdrom-ide-file-missing-datastore.vmx | 6 ++
tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-file.vmx | 6 ++
.../vmx2xml-harddisk-ide-file-missing-datastore.vmx| 6 ++
And return the actual extracted value in a parameter. This way we can later
return success even without any extracted value.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 31 ++-
src/vmware/vmware_conf.c | 20 ++--
There's only one variable to clean-up, others are just tokens inside that
variable, but it is nicer anyway. Positive returns have not been converted
because the function will change soon and it would not make much sense.
Signed-off-by: Martin Kletzander
---
tests/vmx2xmltest.c | 9 +++--
1
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index dde51688f72f..0271f81a5655 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -129,7 +129,7 @@
This will be used later.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 3 ++-
src/vmware/vmware_conf.c | 3 ++-
src/vmware/vmware_conf.h | 3 ++-
src/vmx/vmx.c| 12 +++-
src/vmx/vmx.h| 5 -
tests/vmx2xmltest.c | 13 -
6
The positive branch can just return and the huge negative part does not need to
be indented an extra level. Best viewed with `-w`.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 144 +--
1 file changed, 72 insertions(+), 72 deletions(-)
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now results in an error and the user not being able to
even dump the XML. Instead of erroring out, just keep the
Signed-off-by: Martin Kletzander
---
tests/vmx2xmltest.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c
index bb7c498d1b41..7db2edb12c27 100644
--- a/tests/vmx2xmltest.c
+++ b/tests/vmx2xmltest.c
@@ -66,7
Hi,
This is something I've been giving a thought after working in Gitlab issue
#72 and decided to run through the ML before hitting the code.
We don't have an easy way to retrieve the domain that is using an specific
hostdev. Let's say that I want to know which domain is using the PCI card
We are getting close to the first release of libvirt in 2021. To aim for
the release on Jan 15 I suggest entering the freeze on Friday Jan 08 in
the evening or during the weekend and tagging RC2 on Wednesday Jan 13.
I hope this works for everyone.
Jirka
The kernel refuses to set guest TSC frequency less than a minimum
frequency or greater than maximum frequency (both computed based on the
host TSC frequency). When writing the libvirt code with a reversed logic
(return success when the requested frequency falls within the tolerance
interval) I
On 2021-01-06 at 00:00, Michal Privoznik wrote:
>On 12/21/20 4:23 AM, Shi Lei wrote:
>> Extract common code as helper function virNetlinkTalk, then simplify
>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/util/virnetlink.c | 210
On Tue, Jan 05, 2021 at 07:19:08PM +0100, Michal Privoznik wrote:
On 1/5/21 4:54 PM, Martin Kletzander wrote:
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now
Move macros NETLINK_MSG_[NEST_START|NEST_END|PUT] from .h into .c;
within these macros, replace 'goto' with reporting error and returning;
simplify virNetlinkDumpLink and virNetlinkDelLink by using NETLINK_MSG_PUT.
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 44
NLM_F_CREATE and NLM_F_EXCL are invalid for RTM_DELLINK,
so remove them.
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
index ca735bb8..17e6eeb9 100644
---
Extract common code as helper function virNetlinkTalk, then simplify
the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 225 +-
src/util/virnetlink.h | 4 +-
2 files changed, 94
V1 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00836.html
Since V1:
- Minor fixes for reporting system error in Patch 4.
Shi Lei (4):
netlink: Remove invalid flags(NLM_F_CREATE and NLM_F_EXCL) for RTM_DELLINK
netlink: Minor changes for macros
Introduce a macro NETLINK_MSG_APPEND to wrap nlmsg_append and
simplify code. Remove those labels 'buffer_too_small', since they
are now useless.
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 42 +-
1 file changed, 13 insertions(+), 29 deletions(-)
On Thu, Dec 24, 2020 at 08:14:45AM -0600, Jonathon Jongsma wrote:
> Most of the header files no longer use the space-padded function name
> and parameter alignment. Update the style to be more consistent with
> other headers.
It's actually half of the public ones (9 out of 19 including this one)
Thanks Daniel, I forgot it.
Regards,
Luyao
-Original Message-
From: Daniel Henrique Barboza
Sent: Tuesday, January 5, 2021 8:29 PM
To: Zhong, Luyao ; libvir-list@redhat.com
Subject: Re: [libvirt][PATCH v2 0/3] introduce 'restrictive' mode in numatune
Luyao,
I failed to realize,
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Luyao Zhong
---
include/libvirt/libvirt-domain.h | 1 +
src/conf/numa_conf.c | 9 +
src/qemu/qemu_command.c | 6 ++-
src/qemu/qemu_process.c | 27
When user would like use cgroups to restrict the allowed memory
nodes, and require not setting any specific memory policy, then
'restrictive' mode is useful.
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Luyao Zhong
---
docs/formatdomain.rst | 7 +--
1 file changed, 5 insertions(+),
Before this patch set, numatune only has three memory modes:
static, interleave and prefered. These memory policies are
ultimately set by mbind() system call.
Memory policy could be 'hard coded' into the kernel, but none of
above policies fit our requirment under this case. mbind() support
support 'restrictive' mode in memory element and memnode
element in numatune:
...
...
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Luyao Zhong
---
docs/schemas/domaincommon.rng | 2 ++
1 file changed, 2 insertions(+)
diff --git
87 matches
Mail list logo
