On a Friday in 2021, Yi Li wrote:
get rid of the 'cleanup:' label and created variable.
I changed this to:
Get rid of the 'cleanup' label and 'created' variable.
Signed-off-by: Yi Li
---
src/storage/storage_util.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by:
On Wed, Jan 06, 2021 at 15:32:30 -0600, Ryan Gahagan wrote:
> Signed-off-by: Ryan Gahagan
> ---
> src/qemu/qemu_block.c | 67 +++-
> src/qemu/qemu_domain.c | 70 ++
> 2 files changed, 136 insertions(+), 1 deletion(-)
>
On Wed, Jan 06, 2021 at 15:32:25 -0600, Ryan Gahagan wrote:
> Per Issue 90[1], QEMU supports using an NFS disk but Libvirt had no
> support for attaching a disk of this type. This patch series adds in
> this capability as well as the tests necessary to make sure it works
> correctly.
>
> The
Hi Peter,
Le ven. 8 janv. 2021 11:35, Peter Maydell a
écrit :
> On Thu, 7 Jan 2021 at 22:25, Philippe Mathieu-Daudé
> wrote:
> >
> > The following changes since commit
> 470dd6bd360782f5137f7e3376af6a44658eb1d3:
> >
> > Merge remote-tracking branch
>
On Fri, 8 Jan 2021 at 11:28, Philippe Mathieu-Daudé wrote:
> Le ven. 8 janv. 2021 11:35, Peter Maydell a écrit :
>> Looks like decodetree fails to cope with non-ASCII characters in
>> its input file -- probably this depends on the host locale settings:
>> I think these hosts run in the 'C'
On Thu, Jan 07, 2021 at 06:55:45PM -0500, Matt Coleman wrote:
> > On Nov 26, 2020, at 9:26 AM, Daniel P. Berrangé wrote:
> >
> > On Tue, Nov 24, 2020 at 02:48:31PM -0500, Matt Coleman wrote:
> >> +/* try to shut down the VM if it's not disabled, just to be safe */
> >> +if
On Fri, Jan 08, 2021 at 11:14:48AM +0100, Olaf Hering wrote:
> According to meson.build, and the actual code, Xen 4.6+ is required.
>
> Signed-off-by: Olaf Hering
> ---
> libvirt.spec.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libvirt.spec.in
Signed-off-by: Erik Skultety
---
personal pipeline: https://gitlab.com/eskultety/libvirt/-/pipelines/239002989
Pushed under the build breaker rule.
src/util/virmdev.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/util/virmdev.c b/src/util/virmdev.c
index
On a Thursday in 2021, Laine Stump wrote:
pihole thought it would be cute to include "pihole-" at the beginning
of the version of the dnsmasq build they include...
https://gitlab.com/libvirt/libvirt/-/issues/29
Laine Stump (2):
util: virSkipToDigit()
util: Skip over any extra verbiage
On 1/8/21 7:44 AM, Yi Li wrote:
use the ret variable for return value
Signed-off-by: Yi Li
---
src/storage/storage_backend_rbd.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
Reviewed-by: Michal Privoznik
and pushed.
Michal
On Fri, Jan 08, 2021 at 12:15:04 +0100, Erik Skultety wrote:
Please always describe what you are fixing. The commit message including
summary doesn't shed any light what the problem was. Even if it was
false positive.
Also I'm pretty sure this breaks migw builds even outside of our CI.
>
Only set 'ret' once in any given execution path instead of mixing
it with intermediate return values.
This reverts commit 453bdebe5dcc3ec87d4db011e4f657fa24e42d94
Signed-off-by: Ján Tomko
---
src/storage/storage_backend_rbd.c | 22 --
1 file changed, 16 insertions(+), 6
On a Friday in 2021, Yi Li wrote:
use the ret variable for return value
Signed-off-by: Yi Li
---
src/storage/storage_backend_rbd.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/src/storage/storage_backend_rbd.c
b/src/storage/storage_backend_rbd.c
On Fri, Jan 08, 2021 at 08:28:28AM +0100, Erik Skultety wrote:
> On Thu, Jan 07, 2021 at 07:33:38PM -0300, Daniel Henrique Barboza wrote:
> >
> >
> > On 1/7/21 5:22 PM, Ján Tomko wrote:
> > > On a Thursday in 2021, Laine Stump wrote:
> > > > On 1/7/21 10:09 AM, Michal Privoznik wrote:
> > > > >
On Fri, Jan 08, 2021 at 02:50:25AM -0500, Matt Coleman wrote:
> > On Nov 26, 2020, at 9:42 AM, Daniel P. Berrangé wrote:
> >
> > You ought to pass def->controllers[i] into this method and validate
> > as many properties as practical. At very least validate the model
> > and report
On Thu, 7 Jan 2021 at 22:25, Philippe Mathieu-Daudé wrote:
>
> The following changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3:
>
> Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-060121-4'
> into staging (2021-01-06 22:18:36 +)
>
> are available in the Git
> On Nov 26, 2020, at 9:42 AM, Daniel P. Berrangé wrote:
>
> You ought to pass def->controllers[i] into this method and validate
> as many properties as practical. At very least validate the model
> and report VIR_ERR_CONFIG_UNSUPPORTED for any you can't emulate.
Hyper-V's SCSI controllers are
On Fri, Jan 08, 2021 at 13:13:30 +, Daniel Berrange wrote:
> On Thu, Jan 07, 2021 at 03:59:36PM +0100, Peter Krempa wrote:
> > In certain specific cases it might be beneficial to be able to control
> > the metadata caching of storage image format drivers of a hypervisor.
> >
> > Introduce XML
According to meson.build, and the actual code, Xen 4.6+ is required.
Signed-off-by: Olaf Hering
---
libvirt.spec.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0a8b0ebad4..bd6e7c2747 100644
--- a/libvirt.spec.in
+++
According to meson.build, and the actual code, Xen 4.6+ is required.
Drop the version, they is mentioned in meson.build.
Signed-off-by: Olaf Hering
---
libvirt.spec.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index
On Fri, 2021-01-08 at 00:03 +0100, Jiri Denemark wrote:
> Jiri Denemark (3):
> cpu-gather: Remove redundant "processor" from CPU data file names
> cpu_map: Suggest better command for updating test data files
> cpu-gather: Rename the script as cpu-data.py
>
> src/cpu_map/x86_features.xml
On 1/8/21 8:42 AM, Laine Stump wrote:
For a long time I thought this worked, but during discussion in a
bugzilla report one day I realized it only worked properly for
- we're not even trying to reattach bridges
during libvirtd restart for type='bridge' (i.e. no associated libvirt
network).
On a Friday in 2021, Laine Stump wrote:
two occurences (in libxl_domain.c) couldn't be changed due to a
*occurrences
compile error. I'll send those in a separate mail looking for an
explanation...
or just #include "datatypes.h" and make the changes in the same patch.
Signed-off-by:
On Thu, Jan 07, 2021 at 03:59:36PM +0100, Peter Krempa wrote:
> In certain specific cases it might be beneficial to be able to control
> the metadata caching of storage image format drivers of a hypervisor.
>
> Introduce XML machinery to set the maximum size of the metadata cache
> which will be
On Thu, Jan 07, 2021 at 22:11:42 +0100, Ján Tomko wrote:
> On a Thursday in 2021, Peter Krempa wrote:
> > See patch 3/5 for explanation.
> >
> > Peter Krempa (5):
> > virDomainDiskDefFormatDriver: Rename 'driverBuf' to 'attrBuf'
> > virDomainSnapshotDiskDefFormat: Use virXMLFormatElement
> >
On Fri, Jan 08, 2021 at 00:03:08 +0100, Jiri Denemark wrote:
> Jiri Denemark (3):
> cpu-gather: Remove redundant "processor" from CPU data file names
> cpu_map: Suggest better command for updating test data files
> cpu-gather: Rename the script as cpu-data.py
Reviewed-by: Peter Krempa
On Fri, Jan 8, 2021 at 5:26 AM Olaf Hering wrote:
>
> According to meson.build, and the actual code, Xen 4.6+ is required.
> Drop the version, they is mentioned in meson.build.
>
> Signed-off-by: Olaf Hering
> ---
> libvirt.spec.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
On 1/8/21 5:22 AM, 罗勇刚(Yonggang Luo) wrote:
>>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
>>> 80: ordinal not in range(128)
> Can we always reading file in decodetree with utf8 encoding
> And convert all decodetree to utf8 encoding, and the problem should resolved.
> ```
Am Fri, 8 Jan 2021 14:39:43 -0500
schrieb Neal Gompa :
> Why are we changing to `pkgconfig(xenlight)` from xen-devel? It looks
> like xen-devel provides that name...
Because meson, and configure.ac, checks for entries in the pkgconfig namespace.
Olaf
pgpUzTbd1rml2.pgp
Description: Digitale
On Fri, Jan 08, 2021 at 15:43:02 +0100, Tim Wiederhake wrote:
> The output of cpuid depends on the logical processor id the process
> runs on, as reflected by the "local apic id" present in cpuid leaves
> (eax=1,ebx=0), (eax=11,ebx=0), and (eax=11,ebx=1). This produces
> arbitrary changes in the
Using virtio-blk with SEV on host kernels prior to 5.1 didn't work
because of SWIOTLB limitations and the way virtio has to use it over
DMA-API for SEV (see [1] for detailed info). That is no longer true, so
reword the kbase article accordingly.
For reference, these are the upstream kernel
virtio-blk has been available for use with boot disks for some time now, so
update the text.
Erik Skultety (1):
docs: kbase: sev: Adjust the claims that virtio-blk doesn't work
docs/kbase/launch_security_sev.rst | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
--
The output of cpuid depends on the logical processor id the process
runs on, as reflected by the "local apic id" present in cpuid leaves
(eax=1,ebx=0), (eax=11,ebx=0), and (eax=11,ebx=1). This produces
arbitrary changes in the output files that complicate comparisons.
This patch masks the
Signed-off-by: Laine Stump
Reviewed-by: Ján Tomko
Reviewed-by: Michal Privoznik
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 3 +--
src/libxl/libxl_domain.c | 7 +++
src/libxl/libxl_driver.c | 15 +--
src/lxc/lxc_driver.c | 17 +
Now that this function can be called regardless of interface type (and
whether or not we have a conn for the network driver), let's actually
call it for all interface types. This will assure that we re-connect
any disconnected bridge devices for as
mentioned in
It was late (early) when I sent this the first time, and the final
patch (which was just a cleanup to use g_autoptr in a few places not
even needed for the declared reason for the patches) wasn't compiling
correctly. I intended to send the 1st and 2nd patches on the branch
and forget about the 3rd
The bridge reattach functionality in this function should be called
for interface types other than just type='network', so make it
callable for any type - it just becomes a NOP for types where no
action is needed.
In the case of we need to create a port in
the network driver, and for both
Signed-off-by: Laine Stump
---
src/libxl/libxl_domain.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index c046fcb3f7..afa21bf02e 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -1051,7
On 1/8/21 4:38 PM, Laine Stump wrote:
It was late (early) when I sent this the first time, and the final
patch (which was just a cleanup to use g_autoptr in a few places not
even needed for the declared reason for the patches) wasn't compiling
correctly. I intended to send the 1st and 2nd
> On Nov 26, 2020, at 9:48 AM, Daniel P. Berrangé wrote:
>
> On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote:
>> +g_autofree char *addressString = g_strdup_printf("%u",
>> disk->info.addr.drive.unit);
>
> Validate disk->info.type == DRIVE before accessing this field otherwise
I have just tagged v$version-$rc in the repository and pushed signed
tarballs to https://libvirt.org/sources/. The source RPM is missing
because it is broken for some reason, I will investigate, fix it and
upload later.
Please give the release candidate some testing and in case you find a
serious
41 matches
Mail list logo
