We need qemuBlockIoTuneSetFlags to distinguish cases when some tune is not set
from tune is set explicitly to 0. We don't have the latter case for the group
name and don't need QEMU_BLOCK_IOTUNE_SET_GROUP_NAME.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_driver.c | 3 +--
1 file
On Mon, Jan 11, 2021 at 03:56:03PM +0100, Erik Skultety wrote:
> On Mon, Jan 11, 2021 at 01:53:49PM +, Daniel P. Berrangé wrote:
> > On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> > > Unfortunately GitLab doesn't have a different mechanism on how to mark
> > > jobs as skipped
Unfortunately GitLab doesn't have a different mechanism on how to mark
jobs as skipped or disabled apart from the 'only'/'except' pragmas.
Use the 'except' pragma for the job templates to skip jobs which define
the DISABLE_JOB variable.
Signed-off-by: Erik Skultety
---
.gitlab-ci.yml | 12
>From time to time it happens that some of the distros for which we run our
pipelines break (or the images we pull break). Because we don't have dedicated
maintainers for the jobs/runners, we can only employ the best effort approach
wrt to making the pipeline green again when we're positive the
This showcases how a we'd mark a job as disabled.
---
.gitlab-ci.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index aa55b396a1..1057710ead 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -407,6 +407,7 @@ x64-freebsd-11-build:
This is checked in below call to qemuValidateDomainBlkdeviotune now. Note that
qemuValidateDomainBlkdeviotune does not check *_max_length values as we do
here. But I guess this is for good. I tried setting high _max_lengh values and
looks like their limits depend on *_max values and much less then
Peter Krempa (2):
qemuMigrationSrcNBDStorageCopyReady: Use ready-state of mirror from
qemuBlockJobData
qemuBlockJobEventProcess: Always clear 'mirrorState' when a job
finishes
src/qemu/qemu_blockjob.c | 4
src/qemu/qemu_migration.c | 6 +++---
2 files changed, 7 insertions(+),
Use the per-job state to determine when the non-shared-storage mirror is
complete rather than the per-disk definition one. The qemuBlockJobData
is a newer approach and is always cleared after the blockjob is
terminated while the 'mirrorState' variable in the definition of the
disk may be left
When a block job is terminated we should clear the 'mirrorState' and
'mirrorJob' variables so that stale values are not present prior to a
new job.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_blockjob.c
Now only qemu and test drivers support iotunes and for both of them this check
makes sense. I guess there is little chance that this patch will break loading
of some domains with incorrect config though. If this is the issue then we can
put this common check to a different place.
Signed-off-by:
On Mon, 2021-01-11 at 11:41 +0100, Peter Krempa wrote:
> + * Formal handover of release tarball signing
> +
> +Starting from libvirt-6.6 the release tarballs are signed by Jiří
> Denemark.
> +Releases starting with 7.0 contain a note from the previous maintainer
> +Daniel Veillard
Currenly API is not very convinient when switching from read/write to total
tunes back and forth. read/write and total tunes can not be set simulaneously
so one need to choose one. Now if for example total_bytes_sec and
total_bytes_sec_max are set and we set read_bytes_sec only then API fails. The
We need extra variable in macros thus let's add do {} while (0) wrapping.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_driver.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
On Mon, Jan 11, 2021 at 04:05:48PM +0100, Erik Skultety wrote:
> On Mon, Jan 11, 2021 at 03:03:17PM +, Daniel P. Berrangé wrote:
> > On Mon, Jan 11, 2021 at 03:56:03PM +0100, Erik Skultety wrote:
> > > On Mon, Jan 11, 2021 at 01:53:49PM +, Daniel P. Berrangé wrote:
> > > > On Mon, Jan 11,
In this refresh the PIP variable is renamed to PIP3 and the
PYPI_PKGS variable disappears since we (currently) don't have
any need for it.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.yml | 2 +-
ci/cirrus/build.yml| 2 +-
ci/cirrus/freebsd-11.vars | 5 ++---
On Thu, 2021-01-07 at 13:48 -0500, Neal Gompa wrote:
> On Thu, Jan 7, 2021 at 12:38 PM Jiri Denemark wrote:
> > On Thu, Jan 07, 2021 at 09:58:09 -0500, Neal Gompa wrote:
> > > +++ b/libvirt.spec.in
> > > @@ -614,7 +614,6 @@ volumes using the host iscsi stack.
> > > Summary: Storage driver plugin
There is a little difference though in removed and reused code in
qemuDomainSetBlockIoTune.
First, removed code checked 'set_fields' instead of tune itself. set_fields is
true whenever corresponding virDomainBlockIoTuneInfoHas* it true. But
additionnaly it is true when 0 values are passed
These checks are now in the above call to virDomainBlockIoTuneValidate.
Signed-off-by: Nikolay Shirokovskiy
---
src/test/test_driver.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 4eb04d6..299be2a 100644
---
Signed-off-by: Nikolay Shirokovskiy
---
src/test/test_driver.c | 32 +---
1 file changed, 1 insertion(+), 31 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 29c4c86..4eb04d6 100644
--- a/src/test/test_driver.c
+++
These checks are now in the above call to virDomainBlockIoTuneValidate.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_driver.c | 29 -
1 file changed, 29 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9093baf..02b28f0 100644
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 42 +-
1 file changed, 9 insertions(+), 33 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 024d0e3..bbe6ae7 100644
--- a/src/conf/domain_conf.c
+++
KubeVirt uses Libvirt to manage virtual machines run in
containers. Mention this in our apps page.
Signed-off-by: Michal Privoznik
---
docs/apps.html.in | 7 +++
1 file changed, 7 insertions(+)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 99687c758d..bac1e36365 100644
---
It can also be used for validation of input in qemuDomainSetBlockIoTune.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_validate.c | 100 ++-
src/qemu/qemu_validate.h | 4 ++
2 files changed, 60 insertions(+), 44 deletions(-)
diff --git
On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> Unfortunately GitLab doesn't have a different mechanism on how to mark
> jobs as skipped or disabled apart from the 'only'/'except' pragmas.
> Use the 'except' pragma for the job templates to skip jobs which define
> the DISABLE_JOB
At first glance we don't get much win because of introduction of
virDomainBlockIoTuneFieldNames and virDomainBlockIoTuneFields. But we are going
to use these two in other places to remove usage of macros too.
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 99
It is not used anymore.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_driver.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 57d63b6..29c93de 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@
On Mon, Jan 11, 2021 at 01:53:49PM +, Daniel P. Berrangé wrote:
> On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> > Unfortunately GitLab doesn't have a different mechanism on how to mark
> > jobs as skipped or disabled apart from the 'only'/'except' pragmas.
> > Use the
On Mon, Jan 11, 2021 at 03:03:17PM +, Daniel P. Berrangé wrote:
> On Mon, Jan 11, 2021 at 03:56:03PM +0100, Erik Skultety wrote:
> > On Mon, Jan 11, 2021 at 01:53:49PM +, Daniel P. Berrangé wrote:
> > > On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> > > > Unfortunately
On Mon, 2021-01-11 at 13:53 +, Daniel P. Berrangé wrote:
> On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> > Unfortunately GitLab doesn't have a different mechanism on how to mark
> > jobs as skipped or disabled apart from the 'only'/'except' pragmas.
> > Use the 'except'
On 1/11/21 4:26 PM, Daniel P. Berrangé wrote:
Daniel P. Berrangé (2):
ci: rename the cirrus vars file to remove the "libvirt-" prefix
ci: refresh cirrus vars files
.gitlab-ci.yml| 4 ++--
ci/cirrus/build.yml | 2 +-
ci/cirrus/freebsd-11.vars
Best viewed with --patience.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_driver.c | 72 ++
1 file changed, 8 insertions(+), 64 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 29c93de..8bcb876 100644
---
The check is copied from qemu driver I guess and does not make much sense for
test driver. This patch is a preparation step to get rid of macros in this
place. And I guess it make sence just to drop this check instead of moving to
some function.
Signed-off-by: Nikolay Shirokovskiy
---
Daniel P. Berrangé (2):
ci: rename the cirrus vars file to remove the "libvirt-" prefix
ci: refresh cirrus vars files
.gitlab-ci.yml| 4 ++--
ci/cirrus/build.yml | 2 +-
ci/cirrus/freebsd-11.vars | 8
ci/cirrus/freebsd-12.vars | 8
The "libvirt-" prefix was removed from hostnames in libvirt-ci.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.yml | 2 +-
ci/cirrus/{libvirt-freebsd-11.vars => freebsd-11.vars} | 0
ci/cirrus/{libvirt-freebsd-12.vars => freebsd-12.vars} | 0
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_driver.c | 31 +--
1 file changed, 1 insertion(+), 30 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 984b45d..117c7b7 100644
--- a/src/qemu/qemu_driver.c
+++
On Fri, Jan 08, 2021 at 05:55:55PM -0500, Matt Coleman wrote:
> > On Nov 26, 2020, at 9:48 AM, Daniel P. Berrangé wrote:
> >
> > On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote:
> >> +g_autofree char *addressString = g_strdup_printf("%u",
> >> disk->info.addr.drive.unit);
> >
virDomainBlockIoTuneValidate can be reused in virDomainSetBlockIoTune
implementations.
And also simplify if conditions.
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 78 +---
src/conf/domain_conf.h | 3 ++
It will be used as a replacement for macros code converting params
to iotune structure.
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 32
src/conf/domain_conf.h | 6 ++
src/libvirt_private.syms | 1 +
3 files changed, 39
It will be used as a replacement for macros code adding event params.
Signed-off-by: Nikolay Shirokovskiy
---
src/conf/domain_conf.c | 53
src/conf/domain_conf.h | 7 +++
src/libvirt_private.syms | 1 +
3 files changed, 61 insertions(+)
So far we assumed that any vhostuser interface is plugged into an
OVS bridge and thus 'ovs-vsctl' exists. But this is not always
true. In testing scenarios it is possible to create a vhostuser
interface with this tool dpdk-testpmd (part of dpdk RPM) which
creates/connects to UNIX socket needed for
On Wed, 2021-01-06 at 12:50 -0300, Daniel Henrique Barboza wrote:
> On 1/6/21 12:03 PM, Daniel P. Berrangé wrote:
> > virDomainCreateXML on the source Libvirt 7.0.0 on the source will set
> > PARSE_ABI_UPDATE and thus set the new smaller RAM size.
> >
> > Now we live migrate to libvirt 6.9.0 on
Ping for reviews, since this one would be nice to be pushed
before the release is out.
DHB
On 1/6/21 12:04 PM, Daniel Henrique Barboza wrote:
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
Signed-off-by: Daniel Henrique Barboza
---
Changes from v2:
- clarified that the bug fix will not
Hi,
sorry for the noise, I just want to follow up with the solution in
case someone else runs into this problem and finds this thread.
It turns out this is not a bug, but intended behaviour by iptables: If
you have used nft to create the same tables that iptables uses,
iptables-nft refuses to
It is not safe to pretend that emulated NVDIMM supports
persistence while backend actually failed to enable it
and used non-persistent mapping as fall back.
Instead of falling-back, QEMU should be more strict and
error out with clear message that it's not supported.
So if user asks for persistence
Hi, all.
I started this work as adding missing parts/fixing issues/etc in block iotune
code but then turned to refactoring code. We use a lot of macros in this place
and if we get rid of them I belive we will have much more readable/reusable/
extendable code.
Most of macros usage is for
supportGroupNameOption was originally passed before the below patch. To solve
the issue of that patch this change is not necessary and it make sense to
pass supportGroupNameOption because of qemuMonitorSetBlockIoThrottle
signature.
With patch group_name is passed to qemu if disk in iotune group
I'm going to get rid of macros code in qemuDomainSetBlockIoTune that converts
virTypedParameter parameters into struct. In the scope of the overall effort to
reduce/get rid of using macros when dealing with iotunes. And it will be much
easier to use per field structure which hold whether field was
We are going to delete macros for converting from params/adding event params.
Thus let's make macros conform to existing virDomainBlockIoTuneFromParams.
Signed-off-by: Nikolay Shirokovskiy
---
src/test/test_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Nikolay Shirokovskiy
---
src/test/test_driver.c | 97 +-
1 file changed, 9 insertions(+), 88 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index fba94b9..d0a7040 100644
--- a/src/test/test_driver.c
+++
On a Monday in 2021, Michal Privoznik wrote:
So far we assumed that any vhostuser interface is plugged into an
OVS bridge and thus 'ovs-vsctl' exists. But this is not always
true. In testing scenarios it is possible to create a vhostuser
interface with this tool dpdk-testpmd (part of dpdk RPM)
On a Monday in 2021, Peter Krempa wrote:
Peter Krempa (2):
qemuMigrationSrcNBDStorageCopyReady: Use ready-state of mirror from
qemuBlockJobData
qemuBlockJobEventProcess: Always clear 'mirrorState' when a job
finishes
src/qemu/qemu_blockjob.c | 4
src/qemu/qemu_migration.c | 6
On a Monday in 2021, Michal Privoznik wrote:
KubeVirt uses Libvirt to manage virtual machines run in
containers. Mention this in our apps page.
Signed-off-by: Michal Privoznik
---
docs/apps.html.in | 7 +++
1 file changed, 7 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
On 1/11/21 1:55 PM, Aljoscha Lautenbach wrote:
Hi,
sorry for the noise, I just want to follow up with the solution in
case someone else runs into this problem and finds this thread.
It turns out this is not a bug, but intended behaviour by iptables: If
you have used nft to create the same
On 2021-01-11 at 19:26, Michal Privoznik wrote:
>On 1/11/21 3:23 AM, Shi Lei wrote:
>> Extract common code as helper function virNetlinkTalk, then simplify
>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/util/virnetlink.c | 232
On 1/11/21 2:56 PM, Andrea Bolognani wrote:
On Wed, 2021-01-06 at 12:50 -0300, Daniel Henrique Barboza wrote:
On 1/6/21 12:03 PM, Daniel P. Berrangé wrote:
virDomainCreateXML on the source Libvirt 7.0.0 on the source will set
PARSE_ABI_UPDATE and thus set the new smaller RAM size.
Now we
On Mon, Jan 11, 2021 at 11:17:35 +0100, Peter Krempa wrote:
> Peter Krempa (2):
> docs: downloads: Move 'signatures' section to the end of the document
> docs: downloads: Establish handover of package signing
>
> docs/downloads.html.in | 64 +-
> 1
Signed-off-by: Peter Krempa
---
NEWS.rst | 37 +
1 file changed, 37 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index da88b19d0a..cb111ccb0f 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -11,6 +11,15 @@ For a more fine-grained view, use the `git log`_.
v7.0.0
On Fri, Jan 08, 2021 at 05:23:32PM +0100, Erik Skultety wrote:
Using virtio-blk with SEV on host kernels prior to 5.1 didn't work
because of SWIOTLB limitations and the way virtio has to use it over
DMA-API for SEV (see [1] for detailed info). That is no longer true, so
reword the kbase article
On 1/11/21 3:23 AM, Shi Lei wrote:
Extract common code as helper function virNetlinkTalk, then simplify
the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
Signed-off-by: Shi Lei
---
src/util/virnetlink.c | 232 ++
src/util/virnetlink.h |
On Mon, Jan 11, 2021 at 10:14:58 +0100, Paolo Bonzini wrote:
> On 11/01/21 09:35, Ján Tomko wrote:
> >> This unfortunately cannot be done unconditionally.ÃÂ You need to probe
> >> for the availability of -accel, using something like
> >
> > What are we probing for?
>
> Existence of
On Fri, Jan 08, 2021 at 08:48:09PM +0100, Olaf Hering wrote:
> Am Fri, 8 Jan 2021 14:39:43 -0500
> schrieb Neal Gompa :
>
> > Why are we changing to `pkgconfig(xenlight)` from xen-devel? It looks
> > like xen-devel provides that name...
>
> Because meson, and configure.ac, checks for entries in
On Sun, Jan 10, 2021 at 02:58:05AM +0800, huang...@chinatelecom.cn wrote:
> From: Hyman
>
> The "-machine" options for accelerators are legacy, the "-accel" options
> is a better mechanism. The following are the details:
>
On 11/01/21 10:27, Jiri Denemark wrote:
We use a fallback for capabilities probing (in qemuProcessQMPLaunch) so
in case the old -machine type,accel=... way is going to be deprecated,
Most likely not. We've gotten better at making the "old ways" just
syntactic sugar for the "new ways" without
On 11/01/21 10:38, Daniel P. Berrangé wrote:
The "-machine" options for accelerators are legacy, the "-accel" options
is a better mechanism. The following are the details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
This patch switch the option "-machine
Starting from libvirt-6.6 the releases are done by Jirka. Add a formal
statement from DV handing over the signature.
Signed-off-by: Peter Krempa
---
docs/downloads.html.in | 36
1 file changed, 36 insertions(+)
diff --git a/docs/downloads.html.in
Peter Krempa (2):
docs: downloads: Move 'signatures' section to the end of the document
docs: downloads: Establish handover of package signing
docs/downloads.html.in | 64 +-
1 file changed, 50 insertions(+), 14 deletions(-)
--
2.29.2
Keep the more important stuff outlining how to get to the sources first
since the 'signatures' section will be extended.
Signed-off-by: Peter Krempa
---
docs/downloads.html.in | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git
On a Monday in 2021, Peter Krempa wrote:
Peter Krempa (2):
docs: downloads: Move 'signatures' section to the end of the document
docs: downloads: Establish handover of package signing
docs/downloads.html.in | 64 +-
1 file changed, 50 insertions(+), 14
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty_gfn_count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
This is v1 of Dirty ring support of Libvirt. It is merely the same as v0, but
fix the parameter dirty-gfn-count passed to QEMU command line. A previous
implementation was patched by me mistakenly.
This series of patches is a supplement of dirty ring implementation for Libvirt:
On Fri, Jan 8, 2021 at 3:31 AM Philippe Mathieu-Daudé
wrote:
>
> Hi Peter,
>
> Le ven. 8 janv. 2021 11:35, Peter Maydell a
écrit :
>>
>> On Thu, 7 Jan 2021 at 22:25, Philippe Mathieu-Daudé
wrote:
>> >
>> > The following changes since commit
470dd6bd360782f5137f7e3376af6a44658eb1d3:
>> >
>> >
From: Hyman
This series of patches is a supplement of dirty ring implementation in Libvirt:
https://lore.kernel.org/qemu-devel/20210108165050.406906-10-pet...@redhat.com/
Since QEMU enable the dirty ring feature by specifying the "-accel"
sub-parameter.
Libvirt use "-machine accel=xxx" option
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
The v2 of Dirty ring support of Libvirt just and an empty function of
'qemuBuildAccelCommandLineTcgOptions' and do some code clen, if things
go smoothly, the tcg accelerator property may be support in the future,
this empty function give a hint to do that.
This is v1 of Dirty ring
On a Monday in 2021, Paolo Bonzini wrote:
On 09/01/21 19:58, huang...@chinatelecom.cn wrote:
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 6f970a3..9a64473 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6711,40 +6711,6 @@
On 11/01/21 09:35, Ján Tomko wrote:
This unfortunately cannot be done unconditionally. You need to probe
for the availability of -accel, using something like
What are we probing for?
Existence of "-accel". "-accel" allows configuration of
accelerator-specific, machine-independent
77 matches
Mail list logo
