Re: [PATCH v4 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-26 Thread Laine Stump
On 9/26/21 10:35 AM, Ani Sinha wrote: This change introduces libvirt xml support to enable/disable hotplug on the pci-root controller. It adds a 'target' subelement for the pci-root controller with a 'hotplug' property. This property can be used to enable or disable hotplug for the pci-root

Re: [PATCH v4 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

2021-09-26 Thread Laine Stump
On 9/26/21 10:35 AM, Ani Sinha wrote: This change adds qemu backend command line support for enabling or disabling hotplug on the pci-root controller using the 'target' sub-element of the pci-root controller as shown below: '' is only valid for pc (x86) machines and turns on the

[PATCH v5 4/4] NEWS: release note the new hotplug enable/disable option on pci-root controller

2021-09-26 Thread Ani Sinha
A new 'target' subelement of the pci-root controller has been introduced having a 'hotplug' property. This proprty can be used to turn off or turn on hotplug capability of the devices plugged into the pci-root ports. This change release notes this feature for the next release. The new element can

[PATCH v5 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
This change introduces libvirt xml support to enable/disable hotplug on the pci-root controller. It adds a 'target' subelement for the pci-root controller with a 'hotplug' property. This property can be used to enable or disable hotplug for the pci-root controller. For example, in order to disable

[PATCH v5 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
This change adds qemu backend command line support for enabling or disabling hotplug on the pci-root controller using the 'target' sub-element of the pci-root controller as shown below: '' is only valid for pc (x86) machines and turns on the following command line option that is passed to

[PATCH v5 1/4] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines

2021-09-26 Thread Ani Sinha
The following change in qemu added support for a global boolean flag specific to i440fx machines that would turn off or on acpi based hotplug for pci root bus: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") The option is passed as "-global

[PATCH v5 0/4] Add support to enable/disable hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
changelog: v5: incorporated suggestions from Laine for patches #2 and #3. The qemu command line is now added in a new function and called from qemuBuildControllersByTypeCommandLine(). Output xmls are now symlinked to input xmls for unit tests. v4: split the original patchset into a

[PATCH 4/8] virsh: Add wrapper for virStorageVolFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 2 +- tools/virsh-completer-volume.c | 4 +- tools/virsh-domain.c | 3 +- tools/virsh-util.c | 11 ++

[PATCH 2/8] virsh: Add wrapper for virInterfaceFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 4 +-- tools/virsh-completer-interface.c | 3 +- tools/virsh-interface.c | 55 +--

[PATCH 5/8] virsh: Add wrapper for virNetworkFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 2 +- tools/virsh-completer-network.c | 8 ++-- tools/virsh-network.c | 75 ++--- tools/virsh-util.c

[PATCH 6/8] virsh: Add wrapper for virNodeDeviceFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 2 +- tools/virsh-completer-nodedev.c | 3 +- tools/virsh-nodedev.c | 49 ++--- tools/virsh-util.c

[PATCH 8/8] virsh: Add wrapper for virStreamFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 2 +- tools/virsh-console.c | 8 tools/virsh-domain.c | 4 +--- tools/virsh-util.c| 12

[PATCH 3/8] virsh: Add wrapper for virStoragePoolFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 2 +- tools/virsh-completer-pool.c | 3 +- tools/virsh-completer-volume.c | 4 +- tools/virsh-domain.c | 3 +-

[PATCH 1/8] virsh-util.h: Fix ordering of virshXXXFree functions

2021-09-26 Thread Michal Privoznik
Currently the order of virshXXXFree functions in the header file does not correspond to the order in the corresponding .c file. Signed-off-by: Michal Privoznik --- tools/virsh-util.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/virsh-util.h

[PATCH 0/8] virsh: Use g_autoptr() for public types

2021-09-26 Thread Michal Privoznik
In this patchset I'm switching from virXXXFree to g_autoptr(). There are still some left, but very rare occurrence: libvirt.git $ git grep -o "vir[A-Z].*Free" -- tools/ | \ cut -d':' -f 2 | sort | uniq -c | sort -n And of course, after these some functions could use subsequent

Re: [PATCH v4 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
On Sun, 26 Sep 2021, Laine Stump wrote: > On 9/26/21 10:35 AM, Ani Sinha wrote: > > This change introduces libvirt xml support to enable/disable hotplug on the > > pci-root controller. It adds a 'target' subelement for the pci-root > > controller > > with a 'hotplug' property. This property

[PATCH 7/8] virsh: Add wrapper for virNWFilterFree

2021-09-26 Thread Michal Privoznik
Similarly to virshDomainFree add a wrapper for the snapshot object freeing function. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk| 2 +- tools/virsh-completer-nwfilter.c | 3 ++- tools/virsh-nwfilter.c | 22 +++--- tools/virsh-util.c

Re: [PATCH v4 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
On Sun, 26 Sep 2021, Laine Stump wrote: > On 9/26/21 10:35 AM, Ani Sinha wrote: > > This change adds qemu backend command line support for enabling or disabling > > hotplug on the pci-root controller using the 'target' sub-element of the > > pci-root controller as shown below: > > > > > >

[PATCH v4 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
This change adds qemu backend command line support for enabling or disabling hotplug on the pci-root controller using the 'target' sub-element of the pci-root controller as shown below: '' is only valid for pc (x86) machines and turns on the following command line option that is passed to

[PATCH v4 2/4] conf: introduce option to enable/disable pci hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
This change introduces libvirt xml support to enable/disable hotplug on the pci-root controller. It adds a 'target' subelement for the pci-root controller with a 'hotplug' property. This property can be used to enable or disable hotplug for the pci-root controller. For example, in order to disable

[PATCH v4 1/4] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines

2021-09-26 Thread Ani Sinha
The following change in qemu added support for a global boolean flag specific to i440fx machines that would turn off or on acpi based hotplug for pci root bus: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") The option is passed as "-global

[PATCH v4 0/4] Add support to enable/disable hotplug on pci-root controller

2021-09-26 Thread Ani Sinha
changelog: v4: split the original patchset into a pci-root controller specific patch series. also the libvirt conf is now a sub-element of the pci-root controller as was suggested by Dan Berrange. Please see discussion here:

[PATCH v4 4/4] NEWS: release note the new hotplug enable/disable option on pci-root controller

2021-09-26 Thread Ani Sinha
A new 'target' subelement of the pci-root controller has been introduced having a 'hotplug' property. This proprty can be used to turn off or turn on hotplug capability of the devices plugged into the pci-root ports. This change release notes this feature for the next release. The new element can

[PATCH] qemu: ingore the transient domain state in fake reboot

2021-09-26 Thread Zhenzhong Duan
When action for 'on_poweroff' is set to 'restart', 'fake reboot' is triggered and qemu shutdown state is transient. Domain state need not to be changed and events not sent in this case. Fixes:4ffc807214cb80086d57e1d3e7b60959a41d2874 Signed-off-by: Zhenzhong Duan --- src/qemu/qemu_process.c | 2